Arnav Bhatt
fd39a292af
[MSGINA][SHELL32] Rework friendly UI shutdown dialog box and implement friendly UI log off dialog box ( #3399 )
...
Implement the re-worked shut down dialog box as well as implementing fancy log off dialog box.
- Fancy shut down dialog box has been redesigned to be more comparable to of XP.
- Implement features that were missing earlier.
- Implement the fancy log off dialog which is more comparable to of XP.
2021-02-28 20:03:35 +09:00
Robert Naumann
e4058ee520
[SHELL32] Update German translation
...
-change "Meine Musik" to "Eigene Musik" to get a consistent naming. Same for "Meine Videos".
2021-02-13 20:14:05 +01:00
Siavosh Kasravi
bb723c337a
[SHELL32] Fixing COpenWithMenu.cpp for handling path strings with spaces ( #3449 )
...
CORE-17445
Fixing the bug where open with menu where OpenWithMenu does not handle handler's path when there are spaces in the path string, by adding the missing quote marks around %1 when recording the registry entry for file handler.
2021-02-06 14:35:11 +01:00
Mas Ahmad Muhammad
4ca7926093
[TRANSLATION] Fix format for Indonesian translation ( #3418 )
...
- USETUP: Fix alignment on translation.
- SHELL32: Update and fix translation.
2021-01-07 18:47:10 +01:00
Joachim Henze
1e9547e0d0
[SHELL32] Improve German (de-DE) translation
2021-01-06 00:41:45 +01:00
Piotr Hetnarowicz
eb5972010a
[SHELL32] Improve Polish (pl-PL) translation ( #3410 )
2021-01-03 18:24:18 +03:00
Hermès Bélusca-Maïto
b570fac18b
Happy New Year 2021 to the ReactOS Community!!
...
⚛️ 🍾 🥳 🎆 ☢️
2021-01-01 00:00:00 +01:00
Serge Gautherie
bb01b94f83
[SHELL32] spec: Fix SHGetAttributesFromDataObject() parameter types ( #3317 )
...
Addendum to cdb48b8
. CORE-17337
2020-12-23 15:20:37 +03:00
Riley Bell
3014417919
[SHELL32] Hide "This version of ReactOS is registered to:" text on condition ( #3325 )
...
When the system is not installed yet (e.g. LiveCD or 2nd installation stage)
there is no registered user and organization, so no need to show this text
label in the shell about dialog.
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-11-30 03:12:32 +03:00
Jose Carlos Jesus
47a350c4db
[SHELL32][SHELLEXT] Portuguese (PT) translation improvements and object adjustements ( #3186 )
...
- SHELL32: Improve Portuguese (PT) translation.
Minor objects adjustments to the text
and minor improvements to translation.
- SHELLEXT: Improve Portuguese (PT) translation to acppage rc file.
2020-11-07 17:30:36 +01:00
Hermès Bélusca-Maïto
3c722e35b1
[CMD][SERVMAN][SHELL32][WINSPOOL][ROSAPPS][NTOS:PNP] Fix my build.
2020-11-06 01:06:11 +01:00
Oleg Dubinskiy
cdb48b8219
[SHELL32] Stub SHGetShellStyleHInstance and SHGetAttributesFromDataObject CORE-17337 ( #3295 )
...
They are required by MS Picture and Fax Viewer (shimgvw.dll), together with MS browseui.dll.
CORE-17337
2020-10-24 18:04:54 +03:00
Piotr Hetnarowicz
16d8190f51
[SHELL32] PL-pl Dialogs fix v2
...
shell32.dll PL-pl
-FIXED: invisible icon,text & description
2020-10-24 10:20:59 +02:00
Katayama Hirofumi MZ
de8d156e2c
[SHELL32] Resizable for SHBrowseForFolder ( #3299 )
...
Make the dialog box of SHBrowseForFolder function resizable. CORE-17341
2020-10-21 22:25:16 +09:00
Jérôme Gardou
c004b53d77
Apply suggestions from code review
...
Style fixes
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Victor Perevertkin <victor@perevertkin.ru>
2020-10-20 21:44:54 +02:00
Jérôme Gardou
ed61512236
[CMAKE] Get rid of add_compile_flags_language macro
...
in favor of add_compile_options and the like with generator expressions
Also take this as an opportunity to remove the C++11 standard hack, GCC 8 now defaults to C++14
2020-10-20 21:44:54 +02:00
Jérôme Gardou
7e116f0ef3
[CMAKE] Get rid of replace_compile_flags
...
Introduce a finer-grained remove_target_compile_option instead
2020-10-20 21:44:54 +02:00
Jérôme Gardou
907025a018
[CMAKE] Introduce the atl_classes interface library
...
This takes care of adding the relvant include directory and the _ATL_NO_EXCEPTIONS define, if needed
2020-10-20 21:44:54 +02:00
Jérôme Gardou
d6ea8659c8
[CMAKE] Get rid of the set_cpp macro
...
Instead of messing with global variables and the like, we introduce two target properties:
- WITH_CXX_EXCEPTIONS: if you want to use C++ exceptions
- WITH_CXX_RTTI: if you need RTTI in your module
You can use the newly introduced set_target_cpp_properties function, with WITH_EXCEPTIONS and WITH_RTTI arguments
We also introduce two libraries :
- cpprt: for C++ runtime routines
- cppstl: for the C++ standard template library
NB: On GCC, this requires to create imported libraries with the related built-in libraries:libsupc++, limingwex, libstdc++
Finally, we manage the relevant flags with the ad-hoc generator expressions
So, if you don't need exceptions, nor RTTI, nor use any runtime at all: you simply have nothing else to do than add your C++ file to your module
2020-10-20 21:44:54 +02:00
Mark Jansen
bac45efe5d
[SHELL32][BROWSEUI] Fix usage of ILGetDisplayNameEx
2020-10-04 19:34:20 +02:00
Katayama Hirofumi MZ
a822eadce6
[SHELL32] CoUninitialize only if CoInitialize* is successful
...
Technically CoUninitialize should be called only if CoInitializeEx succeeded (including S_FALSE).
CORE-1419
2020-09-28 20:13:28 +09:00
Katayama Hirofumi MZ
6b6f971939
[BROWSEUI][SHELL32] Enable Ctrl+Backspace in AutoComplete edit boxes ( #3242 )
...
The key combination Ctrl+Back is well working in auto-completion edit boxes. CORE-1419
2020-09-28 09:27:01 +09:00
Timo Kreuzer
68cb54dc58
[SHELL32] Fix usage of return value
2020-09-27 19:58:21 +02:00
Adam Słaboń
50ff453434
[TRANSLATION] Polish translation update ( #3233 )
2020-09-26 21:42:36 +03:00
Katayama Hirofumi MZ
ed02f41af5
[SHELL32] Call SHAutoComplete on 'Run' dialog
...
CORE-9281
2020-09-25 15:59:30 +09:00
Kyle Katarn
b9754fa5d6
[SETUP][MMSYS][SHELL32] Adding missing French translation (and update existing ones) ( #3232 )
...
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-09-25 01:39:31 +02:00
Serge Gautherie
889b077b23
[REACTOS] *.spec: Fix some function/parameter types ( #3154 )
2020-09-20 19:21:11 +02:00
Kyle Katarn
da36f799c7
[SHELL32] Minimal SHRunControlPanel implementation ( #3095 )
...
CORE-9215
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-09-19 16:23:44 +02:00
Kyle Katarn
a5a30fc249
[SHELL32][SHELLEXT] Fix use of SHFileOperation results and improve log on failure / fix log spam ( #3198 )
2020-09-18 21:19:55 +02:00
Katayama Hirofumi MZ
8c87489a43
[COMCTL32][SHELL32] Fix arrow keys and reordering on ListView ( #3162 )
...
- Disable special auto-arrange codes in LISTVIEW_GetNextItem function.
- Add auto-arrange reordering codes on CDefView.
CORE-16875
2020-09-17 22:18:34 +09:00
Hermès Bélusca-Maïto
a373198419
[SHELL32] Fix boot to shell, addendum to commit 14599b0a
.
...
shell32.ShellMessageBoxW redirects to shlwapi.ShellMessageBoxWrapW.
However the latter one (shlwapi) is exported by ordinal only.
Trying to use in shell32.spec file the following syntax:
182 varargs ShellMessageBoxW() shlwapi.ShellMessageBoxWrapW
will therefore fail at runtime, because Windows/ReactOS will fail to
snap shlwapi.ShellMessageBoxWrapW.
Using instead an export by orginal:
182 varargs ShellMessageBoxW() shlwapi.#388
actually fails as well, but at link time, by both MSVC' LINK and GNU's
dlltool.
This generates a .def file containing the line:
ShellMessageBoxW=shlwapi.#388 @182
It is not clear why it fails, because according to:
https://docs.microsoft.com/en-us/cpp/build/reference/exports?view=vs-2019
and
https://devblogs.microsoft.com/oldnewthing/20121116-00/?p=6073
this should be possible.
However one encounters the same errors as those described at:
https://groups.google.com/forum/#!topic/microsoft.public.vc.language/AVnx-EnYdsY
and
https://www.xspdf.com/questions/22333.shtml
...
So instead we use another trick, that appears to be already in use in
the shell32.spec. Since the shlwapi functions are imported because we
link to it, this means that ShellMessageBoxWrapW() is already available
through this import. So we can specify it in the .spec file as is,
without a full name prefixed with "shlwapi." .
Therefore the associated shell32.ShellMessageBoxW function will instead
link to the small ShellMessageBoxWrapW() import stub that is generated
automatically.
2020-09-14 05:54:13 +02:00
Kyle Katarn
aad9bb8e8a
[TRANSLATION][SHELL32] Localization of "System Folder" in My Computer types ( #3168 )
...
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: JoseSanchezz <67137372+JoseSanchezz@users.noreply.github.com>
2020-09-13 23:16:19 +02:00
Kyle Katarn
6d4b853b8a
[SHELL32] Improve Format dialog debug log (trivial) ( #3176 )
...
- Logging of name for unknown filesystem.
- Fix some trace content as not only HDD could be affected.
2020-09-13 23:05:04 +02:00
Hermès Bélusca-Maïto
14599b0a37
[SHELL32][SHLWAPI] Forward shell32.ShellMessageBoxW directly to shlwapi.ShellMessageBoxWrapW. ( #3179 )
...
This makes ShellMessageBoxW use the correct implementation where the
text buffer size is dynamic, instead of having a too small hardcoded
size.
Fixes CORE-17271.
See also PR #3172 by Kyle Katarn, supplemented with some ideas from
Mark Jansen.
However we cannot straightforwardly implement ShellMessageBoxA around
ShellMessageBoxW, by converting some parameters from ANSI to UNICODE,
because there may be some variadic ANSI strings, associated with '%s'
printf-like formatters inside the format string, that would also need
to be converted; however there is no way for us to find these and perform
the conversion ourselves.
Therefore, we re-implement ShellMessageBoxA by doing a copy-paste ANSI
adaptation of the shlwapi.ShellMessageBoxWrapW function.
Note that, on Vista+ onwards, shlwapi implements both ShellMessageBoxA/W,
and shell32 directly forwards these exports to shlwapi, thus avoiding
these workarounds.
[PSDK] Explicily use WINAPIV for the variadic ShellMessageBoxA/W functions.
[INCLUDE/REACTOS] Add ShellMessageBoxWrapW in shlwapi_undoc.h .
2020-09-13 22:44:58 +02:00
Joachim Henze
35dbdaaa0e
[SHELL32] Fix regression CORE-12364
...
The sorting in explorer broke by
SVN r73128 == git
24fcf531e7
Thanks to Doug Lyons for providing this patch.
I do intend to port it back into 0.4.14RC.
2020-09-11 02:24:42 +02:00
Kyle Katarn
7d44c1cb07
[SHELL32] Show "size on disk" in file/folder properties ( #3107 )
...
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
2020-09-10 20:48:40 +02:00
Kyle Katarn
d7fd62d478
[BOOT][DIRECTX][SHELL32] Unneeded semicolons (trivial) ( #3133 )
...
Except in 3rd-party code.
CORE-13162
2020-09-08 21:57:13 +02:00
Katayama Hirofumi MZ
8fa3c147b6
[BROWSEUI][SHELL32] Implement MoveTo/CopyTo buttons ( #3128 )
...
Implement the actions of the MoveTo/CopyTo/Delete buttons.
CORE-11132
2020-09-07 09:42:43 +09:00
Katayama Hirofumi MZ
88cdb9696b
[SHELL32] Make 'hwndServer == NULL' spams quiet
2020-09-06 22:48:29 +09:00
Kyle Katarn
038daa6367
[SHELL32][PAINT][DRIVERS][SHELLEXT] French translation update ( #3092 )
...
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-09-03 15:16:44 +02:00
Katayama Hirofumi MZ
7c134e4d14
[SHELL32] Big fix for change notification ( #3048 )
...
- Reduced the failures of SHChangeNotify testcase.
- Simplified change notification mechanism.
- Realized PIDL aliasing.
CORE-13950
2020-09-03 13:36:31 +09:00
Serge Gautherie
93f017fcc6
[SHELL32] spec: Update SHRunControlPanel() and SHValidateUNC() parameter types ( #3097 )
...
Cherry-pick (missed part of?)
f6be79684f
2020-08-26 17:34:01 +03:00
Kyle Katarn
aab8cd81ff
[SHELL32] Demote noisy ERR() to TRACE() in CRecyclerDropTarget ( #3093 )
2020-08-25 19:12:17 +03:00
Aobi Chan CL
018d4d39a3
[TRANSLATION] Chinese Traditional translation for "Problem with Shortcut" dialog and improvements ( #3079 )
...
- Translation for: setup-reactos, welcome, explorer, appwiz, hdwwiz, intl, mmsys, netid, shell32, syssetup, tapiui.
- Update zh-TW.rc of shell32 (#3075 )
- Just found more Simplified Chinese characters, fixed them. (装 > 裝)
2020-08-23 14:28:55 +02:00
Joachim Henze
f363c27ab4
[SHELL32] Demote 2 noisy goodpath loggings to TRACE CORE-17216
...
Those 2 did spam heavily when browsing folders with
many .zip files within. Mark Jansen confirmed that
this is good-path-logging and was just forgotten
to be disabled earlier.
2020-08-23 00:35:02 +02:00
Katayama Hirofumi MZ
ed445dd775
[SHELL32] Enable CopyTo/MoveTo textbox functionality ( #3075 )
...
- The user can enter the full path of a directory in "Copy To Folder" and "Move To Folder" features.
- Fix two bugs in SHBrowseForFolder function. One is disability of text box to enter a full path. Another one is disability to choose the root item in BFFM_SETSELECTION.
- Add ES_AUTOHSCROLL style to text box. This enables the user to enter a long text.
CORE-11132
2020-08-20 11:35:14 +09:00
Stanislav Motylkov
78607860b7
[SHELL32] Addendum to 4156fd5
2020-08-18 16:50:59 +03:00
Stanislav Motylkov
4156fd5182
[SHELL32] Improve Russian translation
...
Addendum to 46ff964
. CORE-11132
2020-08-18 16:26:52 +03:00
Piotr Hetnarowicz
7d373689fe
[TRANSLATION][SHELL32] Update Polish translation of the "MoveToFolder" dialog ( #3072 )
2020-08-18 12:53:50 +02:00
Katayama Hirofumi MZ
fde7a3b764
[SHELL32] Update Japanese translation
2020-08-18 09:27:10 +09:00
Katayama Hirofumi MZ
46ff964e22
[SHELL32] Implement Move To Folder ( #3056 )
...
- Add context menu item "Mo&ve to folder..." and implement the action.
- Implement the "Mo&ve to folder..." menu item of "Edit" menu of Explorer.
CORE-11132
2020-08-18 05:30:54 +09:00
Mark Jansen
679c95597c
[SHELL32] Fix sorting on size for big files
...
CORE-17205
2020-08-17 18:17:24 +02:00
Kyle Katarn
61d89dec8e
[SHELL32] French translation for "Problem with Shortcut" dialog ( #3047 )
2020-08-17 17:41:59 +03:00
Piotr Hetnarowicz
569a3d63f5
[TRANSLATION][SHELL32] Update Polish translation ("copy to folder" dialog) ( #3064 )
2020-08-17 16:41:31 +02:00
Tibor Lajos Füzi
2490b675fb
[TRANSLATION] Hungarian translation update for aclui, avifil32, browseui, comdlg32, crypt32, cryptdlg, shell32, userenv ( #2978 )
2020-08-17 16:39:42 +02:00
Stanislav Motylkov
9900089fa6
[SHELL32] Fix Russian translation
...
Addendum to 5187ec8
and 824a52a
. CORE-10972 CORE-12906
2020-08-16 16:06:52 +03:00
Stanislav Motylkov
a95c7356ce
[SHELL32] Russian translation for Copy To Folder
...
Addendum to 85fdcdf
. CORE-11132
2020-08-16 15:32:26 +03:00
Katayama Hirofumi MZ
1d1bb53321
[SHELL32] Fix regression #2703 CORE-17041 (trial) ( #3046 )
...
CORE-17041
2020-08-16 11:16:44 +09:00
Joachim Henze
2d4c27c96e
[SHELL32] de-DE translation for CORE-11132
...
Addendum to 0.4.15-dev-524-g
85fdcdf2cc
to keep the german localization up to date
for the new Copy-To-Folder-Dlg.
2020-08-16 02:15:06 +02:00
Katayama Hirofumi MZ
85fdcdf2cc
[SHELL32] Implement Copy To Folder (retrial) ( #3044 )
...
- Add context menu item "Copy to &folder..." and implement the action.
- Implement the "Copy to &folder..." menu item of "Edit" menu of Explorer.
CORE-11132
2020-08-16 08:04:07 +09:00
Stanislav Motylkov
037e84ec7f
[SHELL32] Russian translation for "Problem with Shortcut" dialog
...
Addendum to a3ec01c
. CORE-16816
2020-08-15 17:26:15 +03:00
Piotr Hetnarowicz
9170432c8f
[SHELL32] Polish translation for "Problem with Shortcut" dialog ( #3043 )
...
pl-pl Polish translation update for new dialog with SHORTCUT
2020-08-15 02:07:32 +09:00
Katayama Hirofumi MZ
a3ec01cc28
[SHELL32] Add IDD_LINK_PROBLEM and IDS_LINK_INVALID ( #3037 )
...
A resource dialog and a resource string for shortcut problem. CORE-16816
2020-08-12 14:16:25 +09:00
Katayama Hirofumi MZ
ee231d00b9
[SHELL32] Improve callbacking of CDefView ( #3031 )
...
- Delete DefMessageSFVCB method.
- Add some callbacking.
2020-08-11 16:00:16 +09:00
Katayama Hirofumi MZ
1f31905ecd
[SHELL32] Optimize change notification ( #3030 )
...
- Keep the directory lists only.
- Don't remember file sizes and normal file paths.
CORE-13950
2020-08-10 13:34:48 +09:00
Amine Khaldi
139a3d6661
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905
2020-06-06 21:58:41 +03:00
Katayama Hirofumi MZ
7c9a8c0b89
[SHELL32] Improve readability of filesystem notification ( #2737 )
...
Improve human readability of filesystem change notification.
- Rename the identifiers for human readabilities.
- Split the code into CFilePathList and CDirectoryWatcher classes.
- Encapsulation of code.
CORE-13950
2020-06-02 18:42:07 +09:00
Jose Carlos Jesus
3dad100ea4
[TRANSLATION] Add/update Portuguese translation ( #2850 )
...
- Add translation for: iernonce, modmui.
- Update translation for: jscript, msports, shell32.
2020-06-01 20:48:58 +02:00
Katayama Hirofumi MZ
99b52df014
[SHELL32][INCLUDE] Improve CheckEscapesA/W ( #2795 )
...
Fix and improve shell32!CheckEscapesA/W functions.
Add a testcase for shell32!CheckEscapesA/W to shell32_apitest.
2020-05-28 10:58:26 +09:00
Tibor Lajos Füzi
1017c73a9c
[TRANSLATION] Hungarian translation update for shell32 ( #2828 )
2020-05-23 19:20:16 +02:00
Mark Jansen
83a9f71690
[SHELL32] Allow creation of an empty CFileSysEnum
...
CORE-16908
2020-05-19 20:35:52 +02:00
Julen Urizar Compains
546862babc
[TRANSLATION] Update Spanish, and add Basque translation ( #2667 )
...
Add/update translation for:
charmap_new, logoff, mspaint, notepad, usetup, welcome,
hotplug.cpl, sysdm.cpl, aclui.dll, comctl32.dll, comdlg32.dll,
hhctrl.ocx, kernel32.dll, msi.dll, oledlg.dll, shell32.dll,
tapiui.dll, themeui.dll, wininet.dll, winmm.dll, wldap32.dll,
winsrv.dll.
2020-05-17 18:46:36 +02:00
Mark Jansen
f379a29606
[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders
...
CORE-16908
2020-05-17 17:09:04 +02:00
Mark Jansen
b1003ae909
[SHELL32] Update CFileSysEnum to be maintaineable
...
CORE-16908
2020-05-17 17:09:04 +02:00
Katayama Hirofumi MZ
62e59652a0
[SHELL32] Don't hardcode C: drive again ( #2777 )
...
- Avoid buffer overrun.
- Don't hardcode C: drive.
CORE-13235
2020-05-15 16:36:13 +09:00
Katayama Hirofumi MZ
6c3775f77c
[SHELL32] Implement SheShortenPathA ( #2785 )
...
Implement shell32!SheShortenPathA function.
2020-05-14 22:52:22 +09:00
Katayama Hirofumi MZ
b7a97a2af2
[SHELL32] Implement MakeShellURLFromPathA ( #2784 )
...
Implement shell32!MakeShellURLFromPathA function.
2020-05-14 22:51:53 +09:00
Piotr Hetnarowicz
64ba6e64c8
[SHELL32] PL-pl Dialogs fix ( #2788 )
...
- Fixed invisible text in DIALOGS.
2020-05-14 14:33:32 +02:00
Erdem Ersoy
072be890f3
[TRANSLATIONS] Turkish translation updates ( #2724 )
...
* [TRANSLATIONS] Translate desk.cpl to Turkish
* Update file header
* [TRANSLATIONS]
* Update translations of syssteup
* Update translations of userenv
* Update translations of shell32 (partial)
* [TRANSLATION] Fix a translation
* [TRANSLATION] Translate Turkish strings to Turkish
for hivedef.inf
* Update Turkish translations of shell32 partially
* Update shell32 Turkish translations (partially)
* Update shell32 Turkish translations (partially)
* Fix translation for desk.cpl
2020-05-14 14:23:05 +02:00
Katayama Hirofumi MZ
b70232d416
[SHELL32] Half-implement SHWinHelp
2020-05-14 09:38:38 +09:00
Katayama Hirofumi MZ
711f631849
[SHELL32] Don't hardcode C: drive ( #2768 )
...
CORE-13235
2020-05-11 11:43:07 +09:00
Charles Ambrye
e978ec6125
[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted ( #2703 )
...
Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.
2020-05-09 21:54:15 +09:00
Katayama Hirofumi MZ
1f3cb13fb9
[SHELL32] Distinguish floppy and removable drives ( #2645 )
...
Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221
2020-05-06 00:35:01 +09:00
Katayama Hirofumi MZ
11b6f973b7
[SHELL32] Follow-up 2 of #2659
...
Add TODO comments.
Make CreateAPCThread static.
CORE-13950
2020-05-04 16:22:38 +09:00
Katayama Hirofumi MZ
7980f40911
[SHELL32] Follow-up of #2659
...
Add CreateAPCThread function and use it. CORE-13950
2020-05-04 15:28:16 +09:00
Katayama Hirofumi MZ
5c589b5537
[SHELL32] Notify filesystem changes ( #2659 )
...
Notify filesystem change notifications by using ReadDirectoryChangesW function. Creating/Deleting files/folders will be responsive in Explorer. CORE-13950
2020-05-04 14:53:23 +09:00
Jared Smudde
5b7be1572b
[SHELL32] Set the Run dialog to use the newer style browse for file dialog. ( #2728 )
...
Apply the OFN_EXPLORER flag to the Run dialog so the dialog uses the newer style browse dialog.
2020-05-04 12:53:35 +09:00
Katayama Hirofumi MZ
77b8505393
[SHELL32] Delete IDM_RECENTMENUHEAD resource menu ( #2705 )
...
Follow-up of #2648 . Reduce translation cost and resource data.
CORE-3588, CORE-11483
2020-05-01 15:58:58 +09:00
Kyle Katarn
cd6e1c73c0
[SHELL32] Fix "Open With..." spamming registry MRU keys. ( #2685 )
...
CORE-16981
The problem:
============
- When opening "Open With..." dialog for a given file format, multiple MRU items are appended to registry : 2 items written, even if dialog is closed "cancel".
- Expected behavior : 1 MRU item if execute is selected and 0 MRU if cancel is selected.
Fix:
====
- MRU item to be added when "Execute" is selected only.
- Once added, set the presence flag to avoid multiple MRU items being added later.
2020-04-30 23:03:10 +02:00
Adam Stachowicz
bd33e6b26f
[SHELL32] Update Polish translation ( #2700 )
...
Addendum to 8f3079c
.
2020-04-30 13:37:31 +03:00
Katayama Hirofumi MZ
8f3079c67f
[SHELL32][EXPLORER] Improve Recent Documents of Start Menu ( #2648 )
...
Improve Recent Documents of Start Menu. Add items of "My Documents" and "My Pictures" into Recent menu item.
CORE-3588, CORE-11483
2020-04-30 17:09:14 +09:00
Stanislav Motylkov
68f9fd2f5d
[SHELL32] Fix dialog labels in Recycle Bin properties page ( #2676 )
...
Also fix remaining "Max size" edit box positions.
Addendum to e6e45b3
. CORE-16972
2020-04-27 16:03:27 +03:00
Kyle Katarn
e6e45b34cc
[SHELL32] Fix "Max size" Edit box position in Recycle Bin properties page ( #2676 )
...
CORE-16972
2020-04-27 12:48:26 +02:00
Katayama Hirofumi MZ
771457f37f
[SHELL32] Implement VK_DELETE on SHBrowseForFolder ( #2661 )
...
Enable Del/Delete key to delete the selected folder in "Browse for Folder" dialog.
You can use https://jira.reactos.org/secure/attachment/40118/getfolder.zip as a test program.
CORE-7592
2020-04-26 22:06:19 +09:00
Serge Gautherie
a7e4d66be5
[SHELL32] DoGetProductType(): Use RegGetValueW()
...
instead of RegQueryValueExW(), to enforce a null terminator.
Addendum to 9f4e8ef25b
.
2020-04-26 14:16:59 +02:00
Katayama Hirofumi MZ
c04010c9ad
[SHELL32] Update name in CDefView::LV_RenameItems
2020-04-26 13:21:14 +03:00
Kyle Katarn
07e80dead4
[SHELL32] Improve french translations
2020-04-25 10:38:35 +02:00
Katayama Hirofumi MZ
d32858413d
[SHELL32] Command 'start C:' should open 'C:\' ( #2642 )
...
Based on JIRA user amaneureka's idea.
In SHELL_execute function, add a backslash for Drive "C:", "D:" or "E:" etc.
CORE-16384
2020-04-25 11:01:20 +09:00
Katayama Hirofumi MZ
a48aa21102
[SENDMAIL][ZIPFLDR][MYDOCS] Fix creation of SendTo files ( #2616 )
...
- Improve and move SendTo files creation code and timing.
- Delete IDS_DESKLINK of shell32.
- Add IDS_DESKLINK into sendmail.
CORE-16924
2020-04-23 04:19:20 +09:00
Jose Carlos Jesus
181ed94e22
[SHELL32] Fix grammar mistake in portuguese translation ( #2605 )
2020-04-21 16:38:23 +03:00
Stanislav Motylkov
c6abe80af5
[SHELL32] Update Russian translation
...
Addendum to c82ba34
.
2020-04-21 00:38:42 +03:00
Charles Ambrye
8c4bd09518
[SHELL32] Fix a bug that caused Auto Arrange to always be highlighted in the file explorer
...
This occurred in the file explorer because the menu isn't destroyed and recreated each time, so the menu item, once checked, will stay checked forever. We must call CheckMenuItem with MF_UNCHECKED to clear the check when necessary
2020-04-20 23:13:09 +03:00
Charles Ambrye
c82ba3485e
[SHELL32] Modify context menu to include Align To Grid, and remove Line Up Icons
...
Implement support for using Align To Grid, which itself simply sets the LVS_EX_SNAPTOGRID extended style of the list view control
2020-04-20 23:13:09 +03:00
Ioannis Adamopoulos
0d077c3068
[SHELL32] CDesktopFolder::GetUIObjectOf: fix crash when requested to create a IID_IContextMenu for 0 items.
...
* Tests show that we should return a valid object even in this case.
2020-04-20 17:37:03 +03:00
Mark Jansen
d2b91deb33
[SHELL32] CMyDocsFolder: Ensure the object can be used without calling Initialize
2020-04-20 17:36:44 +03:00
Mark Jansen
6a6a28b634
[SHELL32] Ensure CIDLDataObject::GetData always returns an STGMEDIUM that is safe for use with ReleaseStgMedium
2020-04-20 17:36:43 +03:00
Joachim Henze
4af7888b29
[SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs
...
-Avoid text truncations regarding the checkbox
in a uniform way
-Reduce chance of text truncations for a button
in a uniform way
-Fix es-ES dlg layout and harmonize its dlg Size
with other languages
-de-DE fix double accelerator
2020-04-20 02:08:45 +02:00
Joachim Henze
c0d5e4fd6b
[SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs
...
-Some inspiration from de-DE which I improved years ago
-Avoid text truncations and control overlapping that
happened in almost all other languages
-Increase the size of the listView for all except es-ES & pt-PT
-es-ES & pt-PT had different dlgs sizes, I only slightly tweaked
those therefore
-In sum this brings the RCs much closer to each other
-Unrelated: fix a white-space-typo we had in some but not all RCs
2020-04-19 21:33:13 +02:00
Charles Ambrye
1bee97358e
[SHELL32] Pass LVA_SNAPTOGRID to listview when 'Line up Icons' is selected
2020-04-17 13:23:29 +03:00
Stanislav Motylkov
edc66fdc22
[SHELL32] Update Russian translation
...
CORE-16873
2020-04-16 13:40:49 +03:00
Piotr Hetnarowicz
abd6954d6a
[SHELL32] Update Polish translation ( #2364 )
2020-04-16 13:24:17 +03:00
Stanislav Motylkov
ea298746db
[SHELL32][BROWSEUI] Update Russian translation
...
Addendum to 033f0d9
. CORE-16866
2020-04-16 00:10:12 +03:00
Joachim Henze
2032c3afba
[SHELL32] CORE-12294 File & folder properties dialog fr-FR & de-DE resource
...
Avoids text truncation for french
Improves checkboxes alignment for german
2020-04-15 14:45:48 +02:00
Julen Urizar Compains
d7a632a094
[TRANSLATION] Spanish minor fixes ( #2547 )
...
Translations for:
- Applications: clipbrd, dxdiag, rapps,
- cmdutils: attrib, find, help, label, reg, xcopy
- usetup
- dlls: browseui, shell32, syssetup
- Add Spanish translation for Accesibility Utility (utilman).
Update for the "Choose product options" strings in syssetup:
Originally "ProductType" and "ProductSuite" (typesetted without spaces) were the registry value names where these settings would go, but since it's meaningless to show these values it's better instead to use human-readable names with correct translation and spacing.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-15 13:27:36 +02:00
Stanislav Motylkov
033f0d998a
[SHELL32] Add Russian translation ( #2548 )
...
CORE-16866
2020-04-15 12:38:27 +02:00
Eric Kohl
69e565891d
[SHELL32] No french translation from "right click drag'n'drop"
...
CORE-16815
2020-04-13 15:41:13 +02:00
Eric Kohl
c037278c5f
[SHELL32] Fix missing french translation for "Command prompt here"
...
CORE-16855
2020-04-13 15:27:47 +02:00
Katayama Hirofumi MZ
5af2570b37
[SHELL32] Follow-up No.3 of #2539
...
Improve a comment in CreateNotificationParamAndSend.
CORE-13950
2020-04-13 13:19:12 +09:00
Katayama Hirofumi MZ
b76d053a30
[SHELL32] Follow-up No.2 of #2539
...
Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950
2020-04-13 13:06:15 +09:00
Katayama Hirofumi MZ
bfe36e4f0d
[SHELL32] Follow-up of #2539
...
Improve comment. CORE-13950
2020-04-13 10:41:26 +09:00
Katayama Hirofumi MZ
2727245c86
[SHELL32] Shell notify rework for simplicity and readability ( #2539 )
...
Shell change notification has been implemented in #2432 . But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950
2020-04-13 10:36:24 +09:00
Katayama Hirofumi MZ
ddc1a46456
[SHELL32] Improve CChangeNotify::ShouldNotify more
...
Improved non-recursive cases.
CORE-13950
2020-04-11 11:55:06 +09:00
Katayama Hirofumi MZ
2a32094aa0
[SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify
...
CORE-13950
2020-04-11 09:27:45 +09:00
Katayama Hirofumi MZ
2a6bccb4ce
[SHELL32] Make "Unable to get notification window" quiet
...
CORE-13950
2020-04-11 08:45:23 +09:00
Katayama Hirofumi MZ
60959e34aa
[SHELL32] Simplify CChangeNotify::ShouldNotify
...
CORE-13950
2020-04-10 21:57:58 +09:00
Katayama Hirofumi MZ
59c48a5d33
[SHELL32] Improve CChangeNotify::ShouldNotify
...
Shell change notification was not sent to My Documents.
CORE-13950
2020-04-10 21:51:22 +09:00
Serge Gautherie
745cb1cbda
[SHELL32] Fix SHCNE_UPDATEITEM number of items ( #2409 )
...
Import
83acbb79c1
Related to CORE-13950
2020-04-09 19:42:00 +02:00
Joachim Henze
bf342653df
[SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file)
2020-04-09 18:17:06 +02:00
Katayama Hirofumi MZ
1c706d7483
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save ( #2515 )
...
- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391
2020-04-09 16:56:54 +09:00
Katayama Hirofumi MZ
0903c645a2
[SHELL32] Follow-up of #2432
...
Fixed hang of FireFox.
2020-04-09 08:19:47 +09:00
Katayama Hirofumi MZ
296192685b
[SHELL32] Implement shell change notification ( #2432 )
...
- Rewrite SHChangeNotify, SHChangeNotifyRegister, SHChangeNotify_Lock, SHChangeNotify_Unlock and SHChangeNotifyDeregister functions.
- Fix SHSimpleIDListFromPathA/W functions.
CORE-13950
2020-04-09 07:30:14 +09:00
Julen Urizar Compains
d6e0fe78e7
[TRANSLATION] Updating Spanish translation ( #2503 )
...
Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.
- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".
2020-04-06 13:17:20 +02:00
Serge Gautherie
07efa2ef53
[SHELL32] HCR_GetIconA(): Properly use icon_idx ( #2482 )
...
CORE-11713
Import
7cc2806e0e
2020-03-30 12:24:59 +02:00
jimtabor
10d1afea18
[Explorer|Shell32]
...
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
2020-03-21 19:13:55 -05:00
Robert Naumann
fc4c4d4911
Sync brsfolder.c with keyboard shortcut code from wine ( #2290 )
...
* [SHELL32] Add shortcut to rename folders with the F2 key.
Sync Wine Commit 2e25a43f3fb6230460447bae6fb5db2edbd4a42f by Fabian Maurer
* [SHELL32] Add shortcut to delete folders with the delete key.
Sync Wine Commit 43f44ffb3779ff23c863d9b3297f92720e7e3733 by Fabian Maurer
* Disable the code for file deletion. The Wine way doesn't work on ROS. Add an explaining comment why we can't use the Wine code, as requested by Amine
2020-03-18 21:57:10 +01:00
Serge Gautherie
92aabb07fb
[REACTOS] Fix remaining ' \n' typos, in *.rc ( #2393 )
...
Addendum to commit 554c41e4
(#2387 ).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:08:25 +01:00
Katayama Hirofumi MZ
fc11cf78ca
[SHELL32] Improve ShellExecCmdLine in path resolving ( #2397 )
...
Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409
2020-03-01 19:32:33 +09:00
Katayama Hirofumi MZ
4df9355d0c
[SHELL32][BOOTDATA] Unselect filename extension upon renaming ( #2398 )
...
You can disable unselecting by setting TRUE to SelectExtOnRename value of HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer. CORE-15242
2020-02-29 08:08:26 +09:00
Katayama Hirofumi MZ
3c5b10f4e6
[SHELL32] Fix SHChangeNotify for one item events ( #2386 )
...
Windows sends notification even if two parameters are provided for notification of one parameter. CORE-13950
2020-02-26 10:59:28 +09:00
Katayama Hirofumi MZ
1e60116563
[SYSDM][MSGINA][NETID][SHELL32] Japanese translation (retrial) ( #2369 )
...
Improve Japanese resources. This PR is based on @Midi730's work (#2361 ).
2020-02-25 10:27:49 +09:00
Katayama Hirofumi MZ
0a626dedf8
[SHELL32] Set read-only for some shell folders and delete Desktop.ini of Desktop and Program Files ( #2385 )
...
Set read-only attribute instead of system attribute for some shell folders that has a folder icon.
Delete desktop.ini files in Desktop and Program Files. CORE-16711
2020-02-25 10:07:58 +09:00
Doug Lyons
4e721f780e
[SHELL32] Fix unneeded error Popup with Git for Windows. ( #1854 )
...
* Fix unnecessary error popup when installing Git for Windows.
* Add reasons for return value of 42.
2020-02-23 17:47:48 +01:00
Oleg Dubinskiy
7075bdacb2
[SHELL32] Don't hardcode My Documents path for My Music/Pictures/Videos folders in some translations ( #2354 )
...
Don't hardcode My Documents path in some translations of My Music, My Pictures and My Videos folders in Shell32. It fixes incorrect location of that folders when install ReactOS as Workstation.
Currently they are located in one more My Documents subfolder, which is, in its turn, in the correct My Documents directory. After this fix, they are directly in the 2nd one, as they should be.
CORE-16698
2020-02-15 20:06:16 +01:00
Bișoc George
6ce72ba172
[SHELL32] Better fix for the "Version" string in the About-dialog ( #2349 )
...
The version string kernel number and the localized "version" word were too near in translation files. The patch fixes the problem introduced by #2276 .
Addendum to commit a57f7b50
.
2020-02-14 22:17:48 +01:00
Katayama Hirofumi MZ
358f947975
[SHELL32] Rewrite SHAddToRecentDocs ( #2333 )
...
Rewrite shell32!SHAddToRecentDocs and use it in some applications.
Wine's SHAddToRecentDocs was not Unicode supported and unusable. I will dare to rewrite.
CORE-3588
2020-02-14 11:05:21 +09:00
Katayama Hirofumi MZ
9fc87dacdb
[SDK][INCLUDE] Fix and improve comctl32_undoc.h
2020-02-13 09:16:59 +09:00
Katayama Hirofumi MZ
1cf564c25f
[SHELL32] Use background context if no item selected on File menu
...
CORE-9467
2020-02-12 12:14:15 +09:00
Katayama Hirofumi MZ
bc1519dd87
Shell Folders: Reject invalid characters ( #2328 )
...
Reject invalid input filename characters by using shell32!SHLimitInputEdit function and IItemNameLimits interface. Improve SHLimitInputEdit to sanitize paste.
CORE-11701
2020-02-12 09:18:24 +09:00
Serge Gautherie
9f4e8ef25b
[SHELL32] DoGetProductType(): Check RegQueryValueExW() dwType ( #2331 )
2020-02-11 17:36:12 +01:00
Katayama Hirofumi MZ
ea8a6d6fb7
[SHELL32] Fix and improve SHLimitInputEdit
...
Use CallWindowProcW to call the subclass window procedure.
Use Wide functions explicitly.
CORE-11701
2020-02-11 14:10:38 +09:00
Katayama Hirofumi MZ
9e53e7cd5b
[SHELL32] DoGetProductType should check "LanmanNT" value.
...
CORE-13795
2020-02-11 13:11:58 +09:00
Katayama Hirofumi MZ
c6ed215eef
[SHELL32] Initial implement SHLimitInputEdit ( #2323 )
...
Popup balloon window is not implemented yet.
CORE-11701
2020-02-10 15:57:30 +09:00
Katayama Hirofumi MZ
48160c74b7
[SHELL32][SYSSETUP] Add Product Options page to ReactOS Setup ( #2315 )
...
- Add "Product Options" wizard page into ReactOS Setup.
- Implement CSIDL_Type_InMyDocuments CSIDL type.
- If the product type is workstation, then some special folders will be in My Documents.
CORE-13795
2020-02-10 11:10:42 +09:00
Aaron Dewes
e5813c4644
Update german translation ( #2291 )
...
* Update German translations
* Update translation again
* More translations
* Some fixes in the german translation
* Some more fixes
* Little translation tweak
* Updates to 2nd review
* Little update
* Add back keyboard accel for IDS_OPENFILELOCATION.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-02-08 12:55:53 +01:00
Bișoc George
a57f7b50c0
[SHELL32] Display the ReactOS version to the About dialog programmatically ( #2276 )
...
The current control parameters don't fit well with the version string since ReactOS migrated from SVN to Git. However, modifying the resource parameters doesn't fix the problem as well because the string itself is dynamic (as it can change in words specially the build architecture if the version build is AMD64 or x86 for example).
CORE-16571
2020-02-01 22:47:32 +01:00
Mas4hmad
228eeb7d79
[TRANSLATION] Update Indonesian Translation ( #2268 )
...
- Update Indonesian translation for:
BROWSEUI.DLL, COMCTL32.DLL, DEVMGR.DLL, IEFRAME.DLL, NETID.DLL, SHELL32.DLL,
SYSSETUP.DLL, TIMEDATE.CPL, APPWIZ.CPL, ACCESS.CPL, DESK.CPL and TASKMGR.EXE.
- Add Indonesian translation for: MSHTML.DLL, OLEAUT32.DLL, INPUT.CPL and NTVDM.EXE.
2020-01-26 18:29:38 +01:00
Katayama Hirofumi MZ
aacb9f0ccd
[SHELL32] Improve comments of shell folder paths
2020-01-24 21:32:25 +09:00
Katayama Hirofumi MZ
85474211a1
[SHELL32][USERENV] Update Japanese special folder names
2020-01-24 21:27:50 +09:00
Thomas Faber
aee6cbc50a
[SHELL] Add SHOpenFolderAndSelectItems to shlobj.h.
2020-01-18 13:10:35 +01:00
7OMI
66f6d051eb
[TRANSLATION] Add/update Hungarian translation for shell32, ieframe, browseui ( #2127 )
2020-01-14 18:52:38 +01:00
Katayama Hirofumi MZ
61737d1b3f
[SHELL32] Improve Japanese folder property sheet ( #2247 )
...
Improve Japanese translation.
2020-01-13 22:47:26 +09:00
Katayama Hirofumi MZ
bd5681c027
[SHELL32][SHLWAPI] Improve Japanese file property sheet ( #2246 )
...
- Improve file property dialog (IDD_FILE_PROPERTIES).
- Translate shlwapi resource into Japanese.
2020-01-13 22:33:50 +09:00
Jose Carlos Jesus
10f9a1cb62
[TRANSLATION] [SHELL32] Improvements to Portuguese translation ( #2228 )
...
And minor adjustments because of text lenght.
2020-01-10 13:44:55 +01:00
Suraj K Suresh
fbc14d52cd
[PSDK] Support STRICT_TYPED_ITEMIDS in shdeprecated.idl. CORE-16385
2020-01-03 22:42:35 +01:00
Suraj K Suresh
ecb3ee5427
[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385
2020-01-03 22:42:34 +01:00
Maxim Smirnov
06eb8cda99
[SHELL32] Fix extra fixme ( #1975 )
...
This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`
2020-01-02 13:35:32 +01:00
Hermès Bélusca-Maïto
9ba5594599
Happy New Year 2020 to everyone!!
...
🎊 🎆 🍾 🥳
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
__, ,__) __, ,__) __, ,__) ░░▄████▄░▄███▄░▄████▄░▄███▄░░
(--|__| _ ,_ ,_ (--|\ | _ (--\ | _ _ ,_ ░░▀▀░▄██░██░██░▀▀░▄██░██░██░░
_| |(_||_)|_)(_| _| \|(/_(_|_) \|(/_(_|| ░░░▄██▀░░██░██░░▄██▀░░██░██░░
( | | ,_| ( (__| ░░██████░▀███▀░██████░▀███▀░░
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
███████████████████████████████████████████████████████████████████████████████
██████████████████▓▒▒▒▒▒▒▓▓█████████████████████████▓▓▒▒▒▒▒▒▓██████████████████
███████████████▒▒▒▒▓▓███▓▓▓▒▒░▒▓▓█████████████▓▒▒░▒▒▓▓████▓▓▒▒▒▓███████████████
█████████████▓░░░░░░░░░▒▒▓██████▓▒▒▒▓█████▓▒▒▒▓██████▓▒▒░░░░░░░░░▓█████████████
███████████▒▓░▒█████████▓▓▒░▒▓███▓▓▓▓▓▓▓▓▓▓▓▓████▒▒▒▒▓▓████████▓▒░▓▓███████████
██████████▒▒▓░▓██████████████▓▓▓▓▓█████▓▓▓▓▓▓▓▓▒▒███████████████▓░▓░▒██████████
█████████▓░▓█░▓██████████▓▒▒▒▒▓▓▓▓███████▓▓▓▓▓▓▓▓▓▒▒▓███████████▓░█▒░▓█████████
█████████▓▒██▒▒████████▒▒░░░░▒▒▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▒▒░█████████▒▒█▓▒▒█████████
█████████▓░██▓░▓█████▓▓▒▒░░░░▒▒▓▓▓▓████▓▓▓▓▓▓▓▓▒▒▓▓▓▓▓▒░░▓█████▓░▓█▓░▓█████████
██████████░▓██▒▒▓██▓▓▓▓▓▒▒▒▒▒▒▓▓▓▓██████▓▓▓▓▓▓▒▒▒▒▒▓▓▓▓▒▒░░███▓░▒██▒░██████████
██████████▒▒▓██▒▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████▓▓▓▒▒▒▒▒▒▒▒▒▓▒▒▒▒░░▓█▒▒██▓░▓██████████
███████████▒▒███▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓████▓▓▓▓▓▓▒▒░▒▒▒▒▒▒▒▒▒░░░▒███▒▓███████████
████████████▒▒█▓▓▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒▒░░░░▒▒░░░▒▒▒░░░▓██▒▒████████████
█████████████▒▒▒▒▒▒░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓▒▒░░░░░░░░░░░░░▒▒▒▓▒▒█████████████
██████████████░░▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒░░░░░░░░░▒░░▒░▒██████████████
██████████████▓▒░▒▒▒▒▒░░▒▒░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░▓███████████████
██████████████▓▒▓░░▒▒▒▒░░░░░░░░░░░░░░░░░▒▒▒▒▒▒░░░░░░░░░░▒░░░░░▓▒▓▓█████████████
███████████▓▒▓▓▓▒▒░░░░░▒▒░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░░▒▒▒█▒▒▓███████████
██████████▓▒▒█▓▓▒▒░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▓▒▒▒▒██▒▒▓██████████
█████████▓▒▓██▓▒▒▒▒░░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▒▒▒▒▒▒▓███▓▒▓█████████
████████▓▒▓███▓▒▒▒▒░░░▒░░░░░░▒░░░░░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▓▓▒▒▓▒▓██▓▒▓████████
███████▓▒▓███▒▓▓▒▒▒░░░░░▒░░░░░░▒░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▓▓▓▓▒▒██▓▒▓██▓▒████████
███████▒▒██▓▒▓█▓▓▒▒░░░░░░░▒░░░░░░▒░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▒▓▓▓▒▒▓███▓▒███▒▓███████
██████▓▒▓██▒▒███▓▒▒▒░░░░░░░░▒▒░░░░░▒▒░░░░░░░░▒▒░░▒▓▓▓▓▒▒▒▒▒▒▓█████▒▒██▓░▓██████
██████▒▒██▒▒█████▓▒▒▒░░░░░░░░░▒░░░░░░░▒░░░░▒▒░░▒▓▒▒▒▒▒▒▒▒▒▒████████▒▒██▒▒██████
██████▒▓██░▓██████▓▓▒▒▒░░░░░░░░░░▒░░░░░░░▒░░░░▒▒▒▒▒▒▒▓▓▒▒██████████▒░██▒▒██████
██████▒▒▓▓▒█████████▓▓▒▒▒░░░░░░░░░░▒▒░░░░▒▒▒▓░░░▒▒▒▒▒▓▓████████████▓▒▓▓░▒██████
██████▓░▒▒▒███████████▓▓▒▒░░░░▒▒▒░▒░▒▒▒▒░░▒▒▒▒▒▓▒░░▒▒██████████████▓░▒▒▒███████
███████▓▒░░▒█████████▓▒▒░░▒▓▓▒▒▒░░░░▒▒▒▓▒▓▒░░▒▒▓▓██▓▓▒░▒▒▓█████████▒░░▒████████
██████████▒░░░░░░░▒▒▓▓█████▓▓▒░░▒▓██▓▓████████▒░▒▒▓██████▓▓▒▒░░░░░░░▒██████████
███████████▓▒▒▒▓▓████▓▓▒▒▒░▒▒█████████████████████▒▒░▒▒▓▓▓███▓▓▒▒▒▒████████████
████████████████▓▓▓▓▓▓███████████████████████████████████▓▓▓▓▓▓████████████████
███████████████████████████████████████████████████████████████████████████████
███████████████████████████████████████████████████████████████████████████████
██████████████████████████████████████████████████████████▓░░▓████████░░░▓█████
███▒░░░░▒▓███████████████████████████████████████▒█████▓▒▒▓██▓▒▒▓████▓░█▓░▓████
███▒█████░▒███▓▒▒▒▒▒▓████▓▒▒▒▒▒▓█▓███▓▒▒▒▒▒▒▓██▓▒░▒▒▓▒▓█████████▓▒██▓▒█████████
███▒█████░▒█▓▒▒█████▒▒██▒▒▓████▓░▒██▒▒▓████▓▒▓██▓░▓██▓███████████▓▓██▓░░░▒█████
███▒█▓░░▒▓█▓▒▒▓▒░░▒▓▒░▒▓▒███████▒▒██▒████████████░███▓███████████▓▓██████░▒████
███▒██░▓███▓▒▓█████████▓▒███████▒▒██▒████████████░███▒▓██████████▓████████░▓███
███▒███░▒▓██▓▒▒████▓▒▓██▓▒▒▓██▓▒░▒██▓▒▒▓███▓▒▓███░████▓▒▒█████▒▒▓███▓▒▓██░▓████
███▒████▓░▓████▒▒▒▒▒██████▓▒▒▒▒▓█▓████▓▒▒▒▒▓█████▒███████▓▒▒▒▒▓███████▒▒▒▓█████
███████████████████████████████████████████████████████████████████████████████
2020-01-01 00:00:00 +01:00
Hermès Bélusca-Maïto
be19fda765
[SHELL32] Remove some trailing spaces; use explicitly global namespace for some functions.
2019-12-29 16:14:33 +01:00
Hermès Bélusca-Maïto
d967b5aa25
[BROWSEUI] Remove useless RegenerateUserEnvironment() call.
...
[SHELL32] Call RegenerateUserEnvironment() in WM_SETTINGCHANGE handler **ONLY** when lParam points to the L"Environment" string.
CORE-15147
2019-12-29 16:14:26 +01:00
Hermès Bélusca-Maïto
1ee511a10c
[SHELL32] Fix MSVC warning warning C4390 by adding a bit more debug info.
2019-12-25 19:02:48 +01:00
Hermès Bélusca-Maïto
16f64a9533
[SHELL32] Improve the displayed error on file copy / displacement + simplify code.
...
Also update the corresponding french translations, see CORE-16572.
And fix a regression introduced in 257e7307
that allowed again copying
or moving a directory into its sub-tree...
I also personally think that these checks must also be done within the
copy_files() / move_files() helpers instead?
2019-12-24 18:30:54 +01:00
Bișoc George
8ec05f5fa1
[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() ( #2113 )
...
ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found.
PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures.
CORE-16535
2019-12-12 08:24:20 +09:00
Katayama Hirofumi MZ
257e7307b4
[SHELL32] Fix hung-up of shell32:shlfileop ( #2136 )
...
#2085 caused some failures and hung-up in shell32:shlfileop testcase. This PR will fix it.
CORE-16546
2019-12-08 07:58:14 +09:00
Katayama Hirofumi MZ
2fad488a85
[SHELL32] Add 'm_' prefix to CFSFolder members ( #2129 )
...
CORE-7585
2019-12-05 05:35:25 +09:00
Katayama Hirofumi MZ
c082d08cf3
[SHELL32] Delete unused CNewMenu::m_wszPath
2019-12-03 13:46:35 +09:00
Katayama Hirofumi MZ
364e22fa14
[SHELL32] Improve Japanese translation
2019-12-02 07:03:18 +09:00
Katayama Hirofumi MZ
b582d6ff45
[SHELL32] Improve and fix SendTo ( #2122 )
...
Because of timing of SendTo folder initialization, SendTo My Documents didn't work well.
Now My Documents item is working well. CORE-12562
2019-12-02 04:06:20 +09:00
Shy Zedaka
b6743016f7
[TRANSLATION] Some Hebrew Translation for Shell32 ( #2121 )
2019-12-01 19:30:48 +01:00
Katayama Hirofumi MZ
f1bc04d7e6
[SHELL32][ZIPFLDR] Implement SendTo ZIP folder ( #2118 )
...
Follow-up of #2114 .
- s/Creater/Creator/
- Add an empty file in the SendTo folder.
- Trick.
CORE-16495
2019-12-02 02:26:34 +09:00
Jose Carlos Jesus
62a95e4943
[TRANSLATION] Update Portuguese translation ( #2115 )
2019-12-01 10:14:13 +01:00
Katayama Hirofumi MZ
79d21f7664
[SHELL32] Fix regression of DoCreateSendToFiles
...
CoInitializeEx/CoUninitialize added.
CORE-12562
2019-12-01 13:55:43 +09:00
Katayama Hirofumi MZ
0e2bb5b0b8
[SHELL32] Validate file operation ( #2085 )
...
- Support FOF_RENAMEONCOLLISION flag of SHFileOperationW.
- Add validate_operation function and use it in SHFileOperationW.
CORE-10225
2019-11-30 15:36:16 +09:00
Katayama Hirofumi MZ
5734570a15
[BOOT][SHELL32][INCLUDE] Support 'SuperHidden' files ( #2102 )
...
PR #2101 shows desktop.ini files on Desktop. I want to hide them.
- Add "ShowSuperHidden" setting to Explorer.
- Add SHCONTF_INCLUDESUPERHIDDEN flag.
- Support SHCONTF_INCLUDESUPERHIDDEN in Explorer.
CORE-10045
2019-11-29 15:14:18 +09:00
Katayama Hirofumi MZ
2c272a9017
[SHELL32] Add desktop.ini more to some folders ( #2101 )
...
Provides special icons for special folders by adding desktop.ini. CORE-10045
2019-11-29 14:40:04 +09:00
Katayama Hirofumi MZ
5538facfdd
[SHELL32] Add SendTo DeskLink (Retry) ( #2099 )
...
CORE-12562
2019-11-27 20:09:19 +09:00
Jared Smudde
30e0c2430d
[SHELL32] Disable all controls during format and re-enable after format is complete. ( #2098 )
2019-11-27 09:18:50 +01:00
Katayama Hirofumi MZ
cfdbccf937
[SHELL32] Follow-up of #2076 ( #2091 )
...
Fix EXE and SCR file icons. CORE-16533
2019-11-26 21:45:58 +09:00
Katayama Hirofumi MZ
bd25333e24
[SHELL32] Make SHFormatDrive multi-thread ( #2080 )
...
CORE-12756
2019-11-26 18:26:25 +09:00
Katayama Hirofumi MZ
cd75a87cfd
[SHELL32] Improve DragEnter of CFSDropTarget ( #2073 )
...
Reduce failures of DragDrop testcase. CORE-11238
2019-11-26 17:34:24 +09:00
Katayama Hirofumi MZ
399854ce31
[SHELL32] Set default exe icon ( #2076 )
...
The default icon of an exe file was empty if no icon available from exe.
CORE-10480
2019-11-24 19:26:32 +09:00
Katayama Hirofumi MZ
a2d5a5c301
[SHELL32] Add SVG files of 'Rename' icon ( #2084 )
...
@milawynsrealm has provided the source of 242.ico as svg files. CORE-11736
2019-11-23 14:18:20 +09:00
Katayama Hirofumi MZ
a4deb3f8f1
[SHELL32] Change icon of SendTo My Documents ( #2083 )
...
Follow-up of #2027 . CORE-16496
2019-11-23 14:10:13 +09:00
Katayama Hirofumi MZ
9e20604a5f
[SHELL32] Add Tango icons download URL ( #2079 )
...
Add a download URL for referencing source. CORE-11736
2019-11-22 23:52:35 +09:00
Serge Gautherie
0f92924a99
[REACTOS] Use explicit StringCb*W() ( #2069 )
2019-11-21 00:47:06 +01:00
Katayama Hirofumi MZ
79b030219f
[SHELL32] Improve icon selection upon right click ( #2063 )
...
If the Right-Clicked item is not being selected, then reset the selection and select the Right-Clicked item. CORE-16519
2019-11-20 20:37:57 +09:00
Katayama Hirofumi MZ
aedba8441a
[SHELL32] Improve UI of drive formatting ( #2048 )
...
- Add stub window (StubWindow32) to the drive formatting dialog to avoid locked.
- Separate the thread of drive formatting.
- Move CStubWindow32 codes.
CORE-12756
2019-11-20 10:00:26 +09:00
Joachim Henze
dc047f9630
[BROWSEUI][SHELL32] Fix scroll to selection CORE-16504
...
A patch by Katayama Hirofumi MZ
The bug was unhidden by
0.4.14-dev-312-g
b931f643e3
2019-11-17 02:04:27 +01:00
Katayama Hirofumi MZ
8f129932dd
[SHELL32] Simply return S_OK if *pdwEffect is none ( #2039 )
...
IDropTarget::DragEnter must simply return S_OK if *pdwEffect == DROPEFFECT_NONE. CORE-11238
2019-11-15 18:02:06 +09:00
Katayama Hirofumi MZ
90c63d12a1
[SHELL32][BOOTDATA] Implement Command Prompt here ( #2029 )
...
Add "Command Prompt here" menu item to the Right-click menu of normal folders and drives. Currently, this menu item doesn't work correctly because of the bug of pushd. CORE-12150
2019-11-14 23:25:21 +09:00
Katayama Hirofumi MZ
d037003511
[SHELL32] Add SendTo My Documents ( #2027 )
...
If SendTo folder is empty in SHGetFolderPathAndSubDirW function, then add a shortcut file linked to My Documents. CORE-16496
2019-11-12 16:54:28 +09:00
Katayama Hirofumi MZ
c0f340bca5
[SHELL32] Implement 'Open file location' of shortcut files ( #2028 )
...
"Open file location" is a feature to open the location of the target of a shortcut file.
Ideally we should probably use SHOpenFolderAndSelectItems here, but that is not 100% implemented in ros yet... CORE-12770
2019-11-12 16:47:36 +09:00
Katayama Hirofumi MZ
3b2ead064f
[SHELL32] Follow up of #2021 ( #2022 )
...
- Delete IObjectWithSite interface.
- Use PIDLIST_ABSOLUTE and PITEMID_CHILD rather than LPITEMIDLIST.
- Move CLSID_SendToMenu to shlguid_undoc.h.
- Delete unnecessary codes.
CORE-12562
2019-11-11 00:37:23 +09:00
Katayma Hirofumi MZ
4a1cd04501
[SHELL32] Improve Japanese translation
2019-11-09 19:57:51 +09:00
Pierre Schweitzer
15a703503e
[SHELL32] Update French translation
...
CORE-12562
2019-11-09 10:19:10 +01:00
Katayama Hirofumi MZ
5308a606dc
[SHELL32] Initial SendTo implementation ( #2021 )
...
This PR will realize SendTo feature. Initially, there is no file in SendTo folder (displayed as "(None)"). If you added some shortcut files, then SendTo shows some menu items.
- Copy, Move, and Link are working.
- Added icons.
CORE-12562
2019-11-09 08:08:40 +09:00
Mark Jansen
1f362c1a5a
[SHELL32] CDefaultContextMenu: Don't render a medium just to query if it is present
2019-10-20 17:10:12 +02:00
Mark Jansen
e45beb55f8
[SHELL32] CDefaultContextMenu: Always add the wanted operation to the IDataObject
2019-10-20 17:10:12 +02:00
Mark Jansen
c31327114b
[SDK][SHELL32] Augment the internally used IDataObject with some extra formats
...
This is needed because our code seems to use CF_HDROP a lot, instead of HIDA...
2019-10-20 17:10:12 +02:00
Mark Jansen
f9d3c2c608
[SHELL32] Mark an unexpected failure as unexpected
2019-10-20 17:10:11 +02:00
Mark Jansen
75cabb07be
[SHELL32] Properly release an StgMedium
2019-10-20 17:10:11 +02:00
Mark Jansen
730a99c860
[SHELL32] Update CDataObject,
...
allowing it to accept new formats and behave a bit more like windows
2019-10-19 18:42:15 +02:00
Mark Jansen
5d54b65ceb
[SHELL32] Add support for custom View objects defined with UICLSID
...
CORE-16271
2019-10-19 18:42:15 +02:00
Mark Jansen
5d7ae44059
[SHELL32] Demote an ERR to WARN
2019-10-19 18:41:52 +02:00
Mas4hmad
f84bd4f393
[TRANSLATION] Add/Update Indonesian translations ( #1904 )
...
Add/Update Indonesian translations for CHARMAP, CMDUTILS-HELP, SERVMAN, SETUPAPI, SHELL32, SUBST, SYSSETUP, TASKMGR, USERINIT.
2019-10-08 17:03:14 +02:00
Thomas Faber
a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403
...
Fixes one of many crashes in shell32_winetest:shlfolder.
2019-09-29 12:42:26 +02:00
Thomas Faber
be1f95527a
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385
2019-09-29 12:09:39 +02:00
Thomas Faber
b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385
2019-09-29 12:09:02 +02:00
Thomas Faber
6b0d2c2a2c
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385
...
Addendum to c2b476bd77
.
2019-09-29 12:07:43 +02:00
Shy Zedaka
acaff47682
[BROWSEUI][SHELL32][TRANSLATION] Major Translations to BROWSEUI And New Search function to Hebrew, and Some Other changes. ( #1938 )
2019-09-26 22:18:59 +02:00
Thomas Faber
c2b476bd77
[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385
2019-09-22 16:19:11 +02:00
Thomas Faber
b90c24d640
[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385
2019-09-22 16:19:09 +02:00
Thomas Faber
faae7e5790
[SHELL32] Handle BYREF variants in CFolderItems::Item.
...
Fixes crash in shell32_winetest:shelldispatch.
See also:
6634b31520
2019-09-22 11:41:57 +02:00
Adam Słaboń
c81af08f51
[TRANSLATION] Polish translation update ( #1916 )
...
Added translation for netstat, utilman and netplwiz. Updated translation of find, reg, rapps, regedit, sndvol32, usetup, hivesys, mmsys, openglcfg, powercfg, sysdm, shellext, browseui, devmgr, msgina, netcfgx, shell32, syssetup, shortcuts and vcdcontroltool.
2019-09-20 21:51:47 +02:00
Brock Mammen
957a604b36
[SHELL32] Implement CDefView::AddObject()
2019-09-15 19:46:36 +03:00
Brock Mammen
e7e551afda
[SHELL32] Make SHFindFiles open the search results folder
2019-09-15 19:46:36 +03:00
Ioannis Adamopoulos
e419195d37
[HEADERS] Move some helpers from undocshell.h to shellutils.h as they didn't cover anything undocumented. Merge traycmd.h in undocshell.h as both contain just undocumented shell definitions.
2019-08-25 12:20:52 +03:00
Shy Zedaka
cc8180fe63
[TRANSLATION] Change the recycle bin from 'Trash' to 'Recycle bin'
2019-08-21 18:49:59 +02:00
Serge Gautherie
cb77f1701f
[SHELL32][STOBJECT] Enforce ShellExecuteW(..., file, parameters, ...)
...
CORE-16299
2019-08-19 13:01:08 +02:00
Jose Carlos Jesus
0b4510301b
[SHELL][COMCTL32] pt_PT_Translation Improvements
2019-08-16 19:32:23 +02:00
Shy Zedaka
a3944563c3
[SHELL32] Run Dialog Text Fix
2019-08-15 20:03:55 +02:00
Katayama Hirofumi MZ
944aba1fcc
[SHELL32] Fix Desktop Properties menu item action ( #1833 )
...
1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.
The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299
2019-08-15 23:10:06 +09:00
Shy Zedaka
187c9fc33c
[Translation] More Hebrew Translations
...
Co-authored-by: Baruch Rutman <peterooch@gmail.com>
2019-08-15 13:41:01 +02:00
Mark Jansen
c96ba1aff2
[SHELL32] CDefView: Improve the context menu positioning
...
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.
2019-08-15 11:28:31 +02:00
Joachim Henze
0f16d44b66
[SHELL32] Improve ShellExecute
...
This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.
Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.
Automated tests do improve as well
VBox https://reactos.org/testman/compare.php?ids=68662,68696
KVM https://reactos.org/testman/compare.php?ids=68663,68697
I intend to merge this back into 0.4.12RC.
2019-08-06 20:24:55 +02:00
Mark Jansen
b5423ba70b
[SHELL32] Fix SHCreateDirectoryExW showing an error on success
...
CORE-15145
2019-07-09 22:52:17 +02:00
Bișoc George
019e3ffe5f
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. ( #1688 )
...
CORE-12313
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-07-07 19:01:09 +02:00
Hermès Bélusca-Maïto
8a30801516
[SHELL32] Recycle-Bin: Minor code enhancements.
...
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
2019-07-07 17:56:51 +02:00
Bișoc George
818d660868
[SHELL32] Enable the "Apply" button when user takes action on the edit box control ( #1720 )
...
CORE-12312
2019-07-07 14:47:44 +02:00
Stanislav Motylkov
a76e03d8bc
[SHELL32][USERENV] Improve Russian translation ( #1710 )
...
CORE-16170
2019-07-01 21:43:22 +02:00
Jose Carlos Jesus
86d4156c39
[TRANSLATIONS] Add/Update Portuguese (neutral) translations. ( #1687 )
...
Translations for SYSDM.CPL, SETUPAPI, SHELL32, LSASRV, SAMSRV, SYSSETUP,
USRMGR, THEMEUI, USERENV, WININET, MSCONFIG.
2019-06-29 16:55:33 +02:00
Yaroslav Kibysh
b2e4ff8cfd
[SHELL32] Update Ukrainian translation. ( #1637 )
2019-06-10 16:45:20 +02:00
Serge Gautherie
8a8453494f
[SHELL32] SHCreateShellFolderView(): Fix parameter validation order. ( #1632 )
...
Fixes one modification from commit ae2a85d0
.
CORE-16098
2019-06-09 15:57:45 +02:00
Hermès Bélusca-Maïto
ae2a85d003
[SHELL32] Fix some NULL-pointers validation.
...
- In the exported SHCreateDefaultContextMenu() and
IDataObject_Constructor() functions (called amongst others by
the exported CIDLData_CreateFromIDArray() function).
- In the exported SHCreateShellFolderView() function.
- In CDefView::GetItemObject(), where data was written to *ppvOut before
ppvOut was being checked for NULL.
2019-06-08 19:43:02 +02:00
Yaroslav Kibysh
4d44e11f1e
[SHELL32] Update Ukrainian translation. ( #1623 )
2019-06-08 17:58:42 +02:00
Jose Carlos Jesus
7f5e960e32
[TRANSLATIONS] Update/Add Portuguese translations.
...
Translations for: reactos/setup, usetup, syssetup, netshell, shell32.
2019-05-26 21:19:31 +02:00
Hermès Bélusca-Maïto
62823a08ce
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry.
2019-04-24 03:41:41 +02:00
Hermès Bélusca-Maïto
0416c598f8
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem().
2019-04-24 03:36:27 +02:00
Katayama Hirofumi MZ
8e60c2efee
[SHELL32] Implement 'New Link' (Retrial of #1510 ), CORE-15511 ( #1518 )
...
Correctly create cache about ".lnk" and handling in the member functions.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-04-24 03:28:17 +02:00
Mark Jansen
f5731a41f8
[SHELL32] Use the same definitions for shell32 and it's static libs
2019-04-18 19:21:37 +02:00
Mark Jansen
9824a0154e
[ATL] Retire atlnew
2019-04-18 19:21:37 +02:00