Apply suggestions from code review

Style fixes

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Victor Perevertkin <victor@perevertkin.ru>
This commit is contained in:
Jérôme Gardou 2020-10-16 08:41:35 +02:00 committed by Jérôme Gardou
parent 00ed72d7e8
commit c004b53d77
6 changed files with 6 additions and 6 deletions

View file

@ -4,6 +4,6 @@ set_module_type(tftpd win32cui)
add_importlibs(tftpd advapi32 ws2_32 iphlpapi msvcrt kernel32)
add_cd_file(TARGET tftpd DESTINATION reactos/system32 FOR all)
if ((NOT MSVC) OR USE_CLANG_CL)
if((NOT MSVC) OR USE_CLANG_CL)
target_compile_options(tftpd PRIVATE -Wno-format-overflow)
endif()

View file

@ -62,7 +62,7 @@ add_importlibs(libtiff user32 msvcrt kernel32 ntdll)
add_pch(libtiff precomp.h SOURCE)
add_cd_file(TARGET libtiff DESTINATION reactos/system32 FOR all)
if (MSVC)
if(MSVC)
# error C4311: 'type cast': pointer truncation from 'thandle_t' to 'int'
remove_target_compile_option(libtiff "/we4311")
# error C4312: 'type cast': conversion from 'int' to 'thandle_t' of greater size

View file

@ -53,6 +53,6 @@ add_importlibs(d3dwine user32 opengl32 gdi32 advapi32 msvcrt kernel32 ntdll)
add_pch(d3dwine precomp.h SOURCE)
add_cd_file(TARGET d3dwine DESTINATION reactos/system32 FOR all)
if (NOT MSVC)
if(NOT MSVC)
target_compile_options(d3dwine PRIVATE -Wno-format-overflow)
endif()

View file

@ -73,7 +73,7 @@ add_idl_headers(xmlparser_idlheader xmlparser.idl)
set_module_type(msxml3 win32dll)
target_link_libraries(msxml3 libxml2 iconv-static uuid wine zlib)
if (MSVC)
if(MSVC)
target_compile_options(msxml3 PRIVATE /FIwine/typeof.h /FImsvc.h)
endif()

View file

@ -102,7 +102,7 @@ add_library(shell32 MODULE
shell32.rc
${CMAKE_CURRENT_BINARY_DIR}/shell32.def)
if (MSVC)
if(MSVC)
# error C4311: 'type cast': pointer truncation from 'HANDLE' to 'INT'
remove_target_compile_option(shell32 "/we4311")
endif()

View file

@ -2,7 +2,7 @@
add_executable(createspec createspec.c)
set_module_type(createspec win32cui)
target_link_libraries(createspec wine)
if (NOT MSVC)
if(NOT MSVC)
target_compile_options(createspec PRIVATE -Wno-stringop-overflow)
endif()
add_importlibs(createspec dbghelp msvcrt kernel32)