Commit graph

1673 commits

Author SHA1 Message Date
Eric Kohl 9f41824321 [MMSYS] Set the tab title, implement the 'restore defaults' button and the synchronized trackbar movement. 2019-01-21 00:25:17 +01:00
Eric Kohl 431f9bf311 [MMSYS] Improvements to the speaker volume property page
- Open a separate mixer instance for the page, so that MM_MIXM_CONTROL_CHANGE notifications can be received.
- Keep line and channel configurations in a global struct.
- Handle MM_MIXM_CONTROL_CHANGE and WM_HSCROLL notifications.
2019-01-20 22:00:42 +01:00
Stanislav Motylkov 677edc637c [WINMM] Load Wave/MIDI mapper drivers only after actual device drivers (#1241)
CORE-15620
2019-01-20 17:55:45 +01:00
Eric Kohl 3ae86a245d [MMSYS] Replaces some magic values 2019-01-20 16:35:52 +01:00
Eric Kohl d301d6a378 [MMSYS] Add the speaker volume dialog.
Retrieve information on the channels and initialize the trackbars accordingly.
2019-01-20 15:59:30 +01:00
Stanislav Motylkov d893a6c355 [WINMM:MIDIMAP] Support Windows XP compatible MIDIMap registry setting (#1240)
CORE-15602
2019-01-19 22:48:22 +01:00
Jérôme Gardou c3e4b5fec6 [OPENGL32] Fix wglChoosePixelFormat
Not asking for a feature is not asking not to have it.
2019-01-19 14:23:54 +01:00
Jérôme Gardou 5f2bebf7a5 [OPENGL32][MESA] Downgrade Mesa library to version 2.6
With this commit, we now use a forked version of MESA which only supports OpenGL 1.1, like the windows implementation does.
It exposes :
  - The same pixel formats
  - The same set of extensions
  - Nothing more
All of this without taking 10% of your build time.
If you need a more modern option, look at the MESA package from Rapps, which is (and must be) maintained outside of this code tree.
CORE-7499
2019-01-19 14:23:54 +01:00
Jared Smudde 7d60b2e12f [MMSYS] Set the initial media folder location. (#1248) 2019-01-16 12:53:00 +01:00
Serge Gautherie 6f2aa0cbf9 [SHELL32] CDefView: Remove a remnant string part (#1250)
Addendum to 9ae373a.
2019-01-16 12:51:49 +01:00
Thomas Faber b4a8afe55d
[MSXML3] Handle libxml2 API breakage. CORE-15280
Imports Wine commit 2a8719d280c.
2019-01-16 09:27:30 +01:00
Thomas Faber af4421c39a
[LIBXSLT] Update to version 1.1.33. CORE-15280 2019-01-16 09:27:26 +01:00
Stanislav Motylkov c95f335893 [MMSYS] Properly save Audio/MIDI In/Out in the registry
CORE-15582
2019-01-15 15:27:58 +02:00
Mark Jansen 9ae373a023 [SHELL32] CDefView: Find a reasonable place to show a context menu
Previously, we would treat the input as unsigned coordinates, this is wrong!
If the coordinates are invalid, we try to find a focused or selected item.
The center of this item is where we'll show the menu.
When there is no item, we default to 0,0
2019-01-15 14:34:53 +02:00
Mark Jansen f9e50f5471 [ATL] Add GET_X_LPARAM and GET_Y_LPARAM to atlwin.h
Remove all local definitions
2019-01-15 14:34:53 +02:00
Eric Kohl 5f11c16ca8 [MMSYS] Move global variables into a GLOBAL_DATA struct and free allocated memory on WM_DESTROY. 2019-01-13 23:19:25 +01:00
Stanislav Motylkov e0d80a4ab6 [MMSYS] Add icons for the sound tree (#1235)
CORE-15584
2019-01-13 19:13:20 +01:00
Denis Malikov da9accfba6 [COMCTL32] add padding for status bar text 2019-01-13 18:21:36 +02:00
Joachim Henze daadcc6141 [GDIPLUS] Fix a regression painting gradient CORE-15479
patch is import of Wine commit 0937186f7d15fed60f77fa2014d650f4d0b6b20b
by Nikolay Sivov
2019-01-13 17:14:41 +01:00
Eric Kohl 0ec2fd4c3e [MMSYS] Fix the main volume trackbar
- Increase the height of the trackbar in order to make it fully visible.
- Remove the selection range code.
- Set a range from 0 to 500 and fix the volume calculations accordingly.
- Set a tick frequency of 50 and a page size of 100.
- Play the default sound on TB_ENDTRACK notifications.
2019-01-13 15:38:06 +01:00
Eric Kohl fcadedb306 [MMSYS] Play default sound when the volume trackbar is released.
This works on Windows XP but it might not work on ReactOS because of unimplemented features of PlaySound().
2019-01-13 14:05:00 +01:00
Eric Kohl 5cf2a78473 [MMSYS] Replace the sound event list ListView by a TreeView.
CORE-15584
2019-01-13 10:37:21 +01:00
Stanislav Motylkov 4575747d61 [MMSYS] Fix tab-stop for group controls and comboboxes (#1231)
CORE-15581
2019-01-12 21:18:10 +01:00
Thomas Faber b61b18157b
[LIBPNG] Update to version 1.6.36. CORE-15280 2019-01-12 16:27:18 +01:00
Stanislav Motylkov da528a6606 [MMSYS] Properly select current MIDI output device
CORE-15582
2019-01-11 13:08:24 +02:00
Giannis Adamopoulos 75a80ec823 [COMCTL32] button: Don't erase the area of the checkbox or the text.
Attempt to fix the menace of the world, CORE-13278.
Note that this can also cause visual glitches for classic check boxes or radio buttons.
2019-01-10 23:38:02 +02:00
Denis Malikov 14df8c2e48
[MSVCRT] export _local_unwind4 for 6.0+ version 2019-01-10 19:48:49 +01:00
Stanislav Motylkov e266b8c8c7 [SYSSETUP] Add spec definition for SetupInfObjectInstallActionW (#1228)
CORE-9897
2019-01-10 03:33:46 +01:00
Thomas Faber 0ba5bc40fb
[MBEDTLS] Update to version 2.7.9. CORE-15280 2019-01-09 10:47:38 +01:00
Luo Yufan 980d8b1b12 [TRANSLATION] Update Chinese translation. (#1227)
Update Chinese and Traditional Chinese translations.
2019-01-08 13:42:17 +01:00
Eric Kohl 38160b207d [KERNEL32] GetComputerNameExW: Fix crash in kernel32_winetest environ test 2019-01-07 22:45:33 +01:00
Giannis Adamopoulos 88a69b446b [UXTHEME] Fix a series of problems regarding ThemeCalculateCaptionButtonsPos
Only call it when needed. Also make it fail properly if the window theme could not be opened.
CORE-15564
2019-01-07 11:38:42 +02:00
Luo Yufan 95564d5e30 [TRANSLATION] Update Chinese translation. (#1223)
[CLIPBRD][SOLITAIRE][RAPPS][REGEDIT][WINHLP32][WORDPAD][FDEBUG][SYSDM][BROWSEUI][DEVMGR][IEFRAME][OLEDLG][SHELL32][SYSSETUP][INF][WINFILE][NTVDM][USER32]
2019-01-07 00:35:11 +09:00
Denis Malikov 655d24d9eb [KERNEL32] make some NLS and Format functions work. Wine-sync with latest version 2019-01-05 19:01:30 +01:00
David Quintana 01e5cb0c04
Resource file strings cleanup (#581)
[CMDUTILS/AT] Fix missing translation strings in certain files.
[NOTEPAD] Fix SUBLANG code to brazillian.
[RAPPS] Fix missing translation strings in certain files.
[FDEBUG] Fix translation string ID.
[CPL/INPUT] Fix missing translation strings in certain files.
[ACPPAGE] Fix incorrect resource IDs.
[NETSHELL] Fix incorrect resource IDs.
[DEVMGR] Fix missing translation strings in certain files.
[LSASRV] Fix missing translation strings in certain files.
[RASDLG] Fix missing translation strings in certain files.
[SHELL32] Fix missing translation strings and incorrect resource IDs.
[TAPIUI] Fix missing translation strings in certain files.
[WINFILE] Fix incorrect resource IDs.
[NTVDM] Fix missing translation strings in certain files.
[USERSRV] Fix missing translation strings in certain files.
[BROWSEUI] One more missing string.
[FLTMC] Fix missing translation strings in certain files.

Detected using the TransDiffer tool (early alpha).
This doesn't include everything anymore, but I wanted to get the PR out of the way.
2019-01-05 15:44:16 +01:00
Denis Malikov 343bc19720 [MSVCRT] export _except_handler4_common 2019-01-05 13:44:33 +01:00
Mark Jansen e984cabad2
[APPHELP] Prevent a nullptr dereference 2019-01-05 13:11:36 +01:00
Mark Jansen 6969e85b29
[SHIMENG] Prevent a nullptr dereference 2019-01-05 13:11:35 +01:00
Mark Jansen 1692ab3fe3
[APPCOMPAT] Move sdbtagid.h and sdbtypes.h to a shared location 2019-01-05 13:11:35 +01:00
Mark Jansen 511e793502
[SHIMENG] Ignore shims that are loading 2019-01-05 13:11:35 +01:00
Mark Jansen 58918686aa
[APPHELP] Fix a typo in the logging 2019-01-05 13:11:35 +01:00
Mark Jansen aabefa30d5
[SHIMLIB] c++ compatibility 2019-01-05 13:11:09 +01:00
Timo Kreuzer cfd1647914
[REACTOS] Fix misc 64 bit issues (#783)
* [WIN32K] Fix handle calculation in DbgGdiHTIntegrityCheck
* [NOTEPAD] Fix MSVC warnings
* [PSDK] Simplify *PROC definitions in windef.h
* [VIDEOPRT] Don't try to use NtVdmControl on x64
* [FREELDR] Fix some macros
* [CRT] Make qsort 64 bit compatible
* [NTOS] Use #ifndef _WIN64 instead of #ifdef _M_IX86 around C_ASSERTs
* [FAST486] Fix 64 bit warnings and change DWORD to ULONG, so it can be used in kernel mode
* [APPHELP_APITEST] Fix 64 bit issue
2019-01-05 10:50:11 +01:00
Thomas Faber d9e6c9b539
[MBEDTLS] Update to version 2.7.6. CORE-15280
Note: this disables the MBEDTLS_DEPRECATED_REMOVED configuration value,
because we require the now-deprecated MD5 & SHA functions for bcrypt.
2019-01-05 09:20:35 +01:00
Thomas Faber 9f1e053260
[LIBPNG] Update to version 1.6.35. CORE-15280 2019-01-05 09:20:21 +01:00
Mark Jansen bb6dfbc473
[APISETS] Remove default kernel32 import library, since stubs no longer need it 2019-01-04 20:33:37 +01:00
Mark Jansen 149d22d857
[VERIFIER] Remove stub special case, since our normal 'stub' code no longer links against kernel32 2019-01-04 20:33:26 +01:00
Mark Jansen 6d89d19f39
[LDR] Ensure we start with a valid pointer 2019-01-03 22:52:18 +01:00
Mark Jansen aa912422e5
[LDR] Actually allocate what is asked for 2019-01-03 22:52:18 +01:00
Mark Jansen 3e9cf62470
[LDR] Don't dereference a possible nullptr on a malformed forwarded import 2019-01-03 22:52:18 +01:00
Mark Jansen 97d0595bf6
[LDR] Don't dereference a possible nullptr 2019-01-03 22:52:06 +01:00
Yaroslav Kibysh f759dddb4b [APPWIZ] Russian and Ukrainian Translations Update (#1215) 2019-01-03 22:20:40 +01:00
Julio Carchi 1e141573e4 [TRANSLATION] Spanish translations (#944) 2019-01-02 12:01:44 +01:00
Arnav Bhatt 8ab3652c01 [TRANSLATION] Hindi translation of browseui, comctl32 and shell32 (#1209) 2019-01-01 19:43:42 +01:00
Mark Jansen 04ff7481b1
[LDR] Introduce a private heap for the loader.
This ensures we can still do stuff when the process heap is corrupted.
2019-01-01 16:20:13 +01:00
Hermès Bélusca-Maïto 3fc3447f3e
Happy New Year 2019 everybody! 2019-01-01 00:00:00 +01:00
Luo Yufan 9f54dbff5e [TRANSLATION] Update Chinese translation. (#1212) 2018-12-31 21:47:58 +01:00
Pierre Schweitzer aa55bb1bd3
[IPHLPAPI] Add support for service tags in GetOwnerModuleFromTcp/UdpEntry
If a service tag is set in owner information, then, we'll query advapi32 and
thus services to get the service name instead of the image name
2018-12-31 11:19:36 +01:00
Luo Yufan cfddf95d6f [TRANSLATION] Update Chinese translation. (#1205)
[NET][DISKPART][WINLOGON][ACCESS][APPWIZ][DESK][JOY][MMSYS][POWERCFG][SYSDM][NETCFGX][NETID][SAMSRV][TAPIUI][INF] Update Chinese translation.
2018-12-31 18:47:37 +09:00
Bișoc George 96228ccc0a [APPWIZ] Do not hardcode the strings (#1208)
Let's make those message strings translatable.
2018-12-31 16:42:53 +09:00
Pierre Schweitzer 29b46995aa
[ADVAPI32] When starting or sending a control to a service, set the tag in the TEB
This now allows tracking the threads of the services thanks to their tag.

This fixes the failing test in advapi32:ServiceEnv
2018-12-30 21:44:39 +01:00
Pierre Schweitzer 446e13745c
[ADVAPI32] Stop pretending our advapi32 is NT6+
This is wrong and messes up with internal structures (such as TEB).
For the two needed functions which are "NT6+", they were exported
with NT6, but already existed in W2K3 SP2.

This might fix random bugs

CORE-15526
2018-12-30 21:44:39 +01:00
Pierre Schweitzer e29a99245b
[ADVAPI32] Implement I_ScQueryServiceTagInfo 2018-12-30 14:27:03 +01:00
Pierre Schweitzer 19304da5c3
[ADVAPI32] Implement I_QueryTagInformation 2018-12-30 14:27:02 +01:00
Katayama Hirofumi MZ c5f89b8159 [APPWIZ] Show message box upon error 2018-12-29 05:55:19 +09:00
Thomas Faber 0013b0f71c
[NTDLL:LDR] Avoid passing an uninitialized variable to another function. 2018-12-28 13:41:09 +01:00
Eric Kohl b17e8a5e3c [ADVAPI32] CreateProcessAsUserA/W: Partially revert an obvious case of over-engineering. Only share the common parts! Now it looks a lot better. No more stupid bUnicode! 2018-12-27 19:29:20 +01:00
Luo Yufan c34833390a [TRANSLATION] Update Traditional Chinese translation. (#1193) 2018-12-27 16:24:24 +09:00
Luo Yufan d1de19002a [TRANSLATION] Update Traditional Chinese translation. (#1192) 2018-12-26 21:02:23 +01:00
Luo Yufan 0a3f6f3b47 [TRANSLATION] Update Chinese translation. (#1187)
[REG][REACTOS][EXPLORER][APPWIZ][CONSOLE][INETCPL][INPUT]
[INTL][OPENGLCFG][TIMEDATE][DEVCPUX][COMCTL32][COMDLG32]
[MSGINA][NETCFGX][NETID][SETUPAPI][SHELL32][SYSSETUP]
Update Simplified and Traditional Chinese translations.
2018-12-25 17:28:36 +09:00
Luo Yufan c4118adf80 [COMDLG32] Update Simplified Chinese translation. 2018-12-24 12:00:29 +01:00
Luo Yufan 098c69679f [COMCTL32] Update Simplified Chinese translation. 2018-12-24 12:00:29 +01:00
Eric Kohl 5efe6f00a9 [NETMSG] Fix message table include statement and build netmsg.dll. 2018-12-22 19:04:55 +01:00
Thomas Faber c086edf366
[USP10] Don't mix character and glyph index caches. CORE-14226
Import Wine commits by Nikolay Sivov:
* d1e618d31da usp10: Use glyph index consistently in ScriptGetGlyphABCWidth().
* 8d018d8d1da usp10: Make sure metrics cache is used with glyph indices only.
* eda3a3e37da usp10: Remove extra parentheses.

Fixes font display in UltraISO and GOG installers.

See also https://bugs.winehq.org/show_bug.cgi?id=44410
2018-12-22 11:29:24 +01:00
Oleg Dubinskiy 637fcbb9bc [COMDLG32] Update Ukrainian translation for NEWFILEOPENV2ORD dialog (#1175) 2018-12-21 16:49:05 +01:00
Oleg Dubinskiy 3d1e8143c2 [COMDLG32] Update Russian translation for NEWFILEOPENV2ORD dialog (#1174) 2018-12-21 16:48:36 +01:00
Serge Gautherie 85cd2849c0 [D3DCOMPILER_43] Fix a MSVC-x64 warning about dxbc_init() (#1173)
"...\utils.c(561) : warning C4028: formal parameter 2 different from declaration"

Cherry-pick:
ffe9346120
CORE-7538
2018-12-21 02:53:42 +01:00
Lee Schroeder 94e4c696e5 [THEMEUI][BOOTDATA] Add the Red, White, Blue Classic Color Scheme for Classic Theme, and Localization (#1059)
Adds the 'Red, White, and Blue' Color Scheme used by the Classic Theme and adds localization for all the color schemes into themeui.dll.

Translators, please check the language files for potential copypasta errors.
2018-12-21 00:38:45 +01:00
Serge Gautherie c2083ed360 [JSCRIPT] Fix a MSVC-x64 warning about to_uint32() (#1172)
"...\jsutils.c(679) : warning C4028: formal parameter 3 different from declaration"

Cherry-pick:
961d5c8ed0
CORE-7538
2018-12-21 00:07:24 +01:00
Luo Yufan b460183366 [TRANSLATION] Update Chinese translation. (#1170)
* [BROWSEUI] Update Traditional Chinese translation.
* [BROWSEUI] Update Simplified Chinese translation.
* [SHELL32] Update Traditional Chinese translation.
* [REGEDIT] Update Traditional Chinese translation.
* [BROWSEUI] Update Traditional Chinese translation.
2018-12-20 22:40:03 +09:00
Katayama Hirofumi MZ 6d63d76655
[USETUP][NTDLL_APITEST][KBDROST] Allow non-Latin codepage users to build ReactOS on MSVC (Retrial of #1150) (#1168)
- The converter is code7bit I made. code7bit: https://github.com/katahiromz/code7bit
- This converter converts non-clean characters in string literals.
- However I couldn't erase a ton of codepage C4819 warnings.
- CORE-15447

You can edit an European source file as follows:
- Right click the file in the Solution Explorer.
- Select "Open With...".
- Choose "C++ Source Code Editor (with encoding)".
- Choose "Central European (Windows) - Codepage 1260".
2018-12-20 17:25:32 +09:00
Luo Yufan 25d076789a [TRANSLATION] Update Traditional Chinese translation. (#1166)
Translations for DESK, HDWWIZ, SYSDM, TIMEDATE and BROWSEUI.

If any Taiwanese contributors are present, please help improving the translations!
2018-12-20 03:25:12 +01:00
Stanislav Motylkov c1f0e89e21 [NETSHELL] Use distinct icon for connection status window (#1167)
CORE-15445
2018-12-20 00:35:22 +01:00
Luo Yufan bba8262bc1 Update Chinese translation. (#1164)
* [SYSSETUP] Update Simplified Chinese translation.
* [SYSSETUP] Update Traditional Chinese translation.
* [SHELL32] Update Traditional Chinese translation.
* [VCDCONTROLTOOL] Update Simplified Chinese translation.
* [VCDCONTROLTOOL] Update Traditional Chinese translation.
2018-12-19 21:04:19 +09:00
Katayama Hirofumi MZ 02936d4c67
[DEVMGR][NETCFGX][MSCONFIG][NETSHELL] Fix and improve icons (#1143)
CORE-15445
2018-12-19 20:07:17 +09:00
Yaroslav Kibysh 8540ab04d7 [TRANSLATION] Ukrainian Translation Update & OEM-866 Code Page Problem (#1133)
Also add the Ї ї Є є characters to the VGA font for code page 866.
2018-12-18 18:38:42 +01:00
Luo Yufan 981cbb1b8c [TRANSLATION] Update Chinese translation (zh_CN & zh_TW) (#1159) 2018-12-18 17:24:35 +01:00
Luo Yufan 4b7f1e0a9d [TRANSLATION] Update Traditional Chinese translation. (#1142) 2018-12-18 12:30:48 +09:00
Joachim Henze 6f8cb05cad [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again CORE-15412
addendum to 0.4.10-dev-502-g
d559ca9c98

That copy-paste was done once intentionally to keep our imports similar to 2003.
It's worth reading the conversation in PR #748: Getequ seems to be ok with this.

The ideal solution most likely would be to instead *statically*
link against RegLoadMUIStringW() from advapi32_vista when WINNT=0x502.
For now the stuff runs again at least.
I left the func existing in advapi32_vista.dll.
2018-12-17 22:01:49 +01:00
Mark Jansen c8f216eafd
[BROWSEUI] Add ITaskbarList implementation
CORE-15424
2018-12-17 20:38:38 +01:00
Mark Jansen 959994b67c
[OLE32] Don't free handles that are just copied in the inproc case.
This imports wine commit 25b136d40080a80c006b89e02708d2e248504a42,
by Huw Davies and Zebediah Figura
CORE-14696
2018-12-17 20:36:05 +01:00
Katayama Hirofumi MZ 932a812c66
[SHELL32] Add backslash if path was like C: (#1152)
CORE-15434
2018-12-17 22:42:18 +09:00
Katayama Hirofumi MZ c94ca8128d
[SHELL32] 'Run' dialog box should accept URL (#1153)
Fix ShellExecCmdLine function. CORE-15455, CORE-11772
2018-12-17 22:37:51 +09:00
Katayama Hirofumi MZ 5525c81b2f
[SHELL32] Add CDefView::DefMessageSFVCB (Retrial of #1145) (#1151)
CORE-14976
2018-12-17 19:22:31 +09:00
Katayama Hirofumi MZ 2e2e63e10d
[KBDROST][NTDLL_APITEST] Revert #1135 (Delete UTF-8 BOM) (#1149)
CORE-15447
2018-12-17 11:29:35 +09:00
Eric Kohl 74d50a4da3 [SAMSRV] Implement SamConnect5() and add/improve TRACE messages.
- Implement SamConnect5() and let the other connect functions call SamrConnect5().
- Add missing and improve incomplete TRACE messages for all Samr functions.
2018-12-16 20:43:02 +01:00
Hermès Bélusca-Maïto bc00ea2464
[SHELLBTRFS] Fix MSVC build. 2018-12-16 17:20:37 +01:00
Pierre Schweitzer a4e25b8673
[SHELLBTRFS] Oops, that local change got dropped...
CORE-15452
2018-12-16 12:27:08 +01:00
Pierre Schweitzer 00ff5e8dc9
[SHELLBTRFS] Fix build
CORE-15452
2018-12-16 12:19:32 +01:00
Pierre Schweitzer 215c0778da
[UBTRFS] Upgrade to 1.1
CORE-15452
2018-12-16 12:06:46 +01:00
Pierre Schweitzer 7b718d3627
[SHELLBTRFS] Upgrade to 1.1
CORE-15452
2018-12-16 12:06:46 +01:00
Eric Kohl b2819c353c [KERNEL32] Store the current computer name in the volatile ActiveComputerName key on first query in order to ensure that the visible computer name does not change until the next reboot. 2018-12-16 10:28:26 +01:00
Katayama Hirofumi MZ 235042a16c
[CPL][SHELL32] Add icons to input, joy, sysdm, folder options (#1138)
CORE-15445
2018-12-16 08:40:47 +09:00
Jared Smudde 44bb99cc8e [SHELL32] Add a warning dialog before starting a dialog as well as a format complete dialog. (#1137)
Also fix the progress bar not working and the Allocation unit size combo box disappearing after a format completes.
2018-12-15 21:22:57 +01:00
Luo Yufan adf023e38c [SHELL32] Update Simplified Chinese translation. 2018-12-15 20:13:47 +01:00
Luo Yufan f369ae618d [SHELL32] Update Traditional Chinese translation. 2018-12-15 20:13:47 +01:00
Eric Kohl c87482b1df [NETAPI32] Implement NetRegisterDomainNameChangeNotification() and NetUnregisterDomainNameChangeNotification(). 2018-12-15 17:18:32 +01:00
Mark Jansen 97d7206f8b
[MSPATCHA] Initial patch decoding + applying.
Some initial work is done, all testcases pass now.
However a lot of the patch format is still unknown / not working,
so do not expect anything other than the apitest to work yet.
The next thing to do now, is to gather input, output and patch files,
and analyze how the compression and patching works on bigger /
more complex files.
CORE-15417
2018-12-15 16:28:59 +01:00
Mark Jansen 33e3a69a7f
[MSPATCHA] Implement GetFilePatchSignature functions 2018-12-15 16:28:59 +01:00
Mark Jansen 55e0720509
[MSPATCHA][PSDK] Update / add some function definitions 2018-12-15 16:28:59 +01:00
Katayama Hirofumi MZ 7050ac4dce
[KBDROST][NTDLL_APITEST] Add UTF-8 BOM (#1135)
Add UTF-8 BOM. CORE-15447
2018-12-15 08:00:39 +09:00
Katayama Hirofumi MZ 2be0fe5f8f [SHELL32] Improve French translation of Folder Options View
CORE-15259
2018-12-14 21:41:44 +01:00
Katayama Hirofumi MZ bd55105c8a
[CPL] Properly set display icons of control panel applets (#1129)
CORE-15445
2018-12-14 20:06:57 +09:00
Katayama Hirofumi MZ f222e89d86 [SHELL32] Localize caption of Folder Options
CORE-15247
2018-12-14 19:56:44 +09:00
Katayama Hirofumi MZ fad9f6677a [BROWSEUI] Follow up of #1121
CORE-15434
2018-12-13 20:40:05 +09:00
Katayama Hirofumi MZ c64d31e9b8
[BROWSEUI] Add backslash for directory (#1121)
CORE-15434
2018-12-13 20:04:02 +09:00
Mark Jansen cc2f0a8868
[SHELL32] Add IActiveDesktop stub
CORE-15424
2018-12-12 19:29:09 +01:00
Katayama Hirofumi MZ 472787ffea
[SHELL32] Fix 'Run' dialog crash (#1117)
Running "%SYSTEMROOT%" sometimes crashed. This will fix it. CORE-15431
2018-12-12 10:33:05 +09:00
Auron Hines 86c5cfd81a [TRANSLATION][SHELL32] Grammar fix: content -> contents (#1115) 2018-12-11 19:43:46 +01:00
Katayama Hirofumi MZ 06d717e3bc
[SHELL32] Enable environment variables in 'Run' dialog (#1111)
CORE-15431
2018-12-11 16:35:45 +09:00
Luo Yufan acef266bc6 [TRANSLATION] Update Simplified Chinese translation and notice. (#1108) 2018-12-10 16:03:00 +01:00
Pierre Schweitzer de7c959c4e
[NTDLL] Implement the Etw*Trace functions relying on EtwControlTrace 2018-12-09 10:29:02 +01:00
Ștefan Fulea 8a333e6845
[CPL:INPUT] Update Input's existing localized information. (#861)
Update the name of the Romanian Keyboard layout in localized
resources by renaming the existing one as legacy and adding
the new one as standard.

Use the same resource string ID as the one used in input.cpl from
later versions of Windows that do have kbdrost.
This improves the Windows binary compatibility of kbrost's setup.

CORE-15056
2018-12-08 18:52:56 +01:00
Ștefan Fulea e530bb36ed
[DLL:KEYBOARD] Add Romanian Standard Keyboard layout. (#861)
Define the Romanian Standard Keyboard layout, as defined by
Romanian Standards Association (ASRO). This also renders the
existing Romanian Keyboard layout as Legacy.

CORE-15056
2018-12-08 18:52:25 +01:00
Ștefan Fulea 3c82e46ef1
[DLL:KEYBOARD] Add a dead keys transformations collection. (#861)
It contains all the Unicode characters that can be formed with a
given dead key (i.e. combining character). Keyboard layouts with
dead keys may find these useful.

CORE-15056
2018-12-08 18:50:47 +01:00
Serge Gautherie 5e8e654dfd
[DDRAW] Remove useless 'else's. 2018-12-08 17:10:36 +01:00
Serge Gautherie 166c6e2498
[DDRAW] Fix two duplicate DDSD_WIDTH uses.
Thanks to Kudratov Olimjon who reported this.
CORE-8545
2018-12-08 17:10:31 +01:00
Eric Kohl b9d4e2dae6 [USERENV] Move some functions around to make it look nicer. No code changes. 2018-12-08 16:41:17 +01:00
Pierre Schweitzer e02f3356b1
[MPR] Sync with Wine Staging 3.17. CORE-15127 2018-12-08 11:42:23 +01:00
Pierre Schweitzer bcad6700ec
[MPR] Import Wine commit: 773ff2e83b0547540639c6d4aeb9f817b621fb2f
Implement support for deleting persistent connections.
2018-12-06 22:44:43 +01:00
Pierre Schweitzer 3e8ec64489
[MPR] Import Wine commit: 23a232fce8899a24e76207518175235b7b0f00cd
Implement support for making connections persistent.
2018-12-06 22:42:46 +01:00
Luo Yufan 93ac724b47 [TRANSLATION] Update Simplified Chinese translation. (#1099)
Update Simplified Chinese translation for BROWSEUI, INETCPL and SYSDM.
2018-12-06 14:52:38 +01:00
Luo Yufan 39a478d17b [TRANSLATION] Update Simplified Chinese translation. (#1096) 2018-12-05 16:50:05 +01:00
Pierre Schweitzer 9c2a264d77
[MPR] Import Wine commit: 9988bb5e0729178b527052803d3ad670e5e0b46e
Implement remembered connection enumeration.

CORE-15310
2018-12-05 08:47:25 +01:00
Luo Yufan 07b120bd56 [TRANSLATION] Update Simplified Chinese translation. (#1094) 2018-12-04 17:13:39 +01:00
Eric Kohl 2037bab6c4 [SETUPAPI] GetDeviceInstanceKeyPath: Trying to open the hardware key opens the software key and vice versa. Fix it by swapping the code paths. 2018-12-03 22:03:38 +01:00
Mark Jansen faddd38b36
[KERNEL32] Revert d897e27, which would re-initialized a list.
Spotted by Andrew Boyarshin.
2018-12-03 20:48:14 +01:00
Luo Yufan 6a506156a8 [MSGINA] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Luo Yufan 5066ee4606 [IEFRAME] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Luo Yufan a9f634b5fe [SHELL32] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Katayama Hirofumi MZ cbd52e30d7
[SHELL32] Don't show taskbar button of Folder Options (#1091)
CORE-10481
2018-12-03 13:38:09 +09:00
Katayama Hirofumi MZ c1eb420a91
careless s/E_FAIL/FALSE/ (#1089) 2018-12-03 05:43:21 +09:00
Katayama Hirofumi MZ 623b2e153e
[SHELL32] Follow up of #1085 (#1088)
CORE-10481
2018-12-03 05:38:36 +09:00
Katayama Hirofumi MZ ecd51d99f4
[SHELL32] Don't show taskbar button of file property sheet (#1085)
CORE-10481
2018-12-03 04:25:46 +09:00
Eric Kohl 3f570f3369 [SETUPAPI] Implement SetupGetNonInteractiveMode() and SetupSetNonInteractiveMode(). 2018-12-02 14:10:25 +01:00
Pierre Schweitzer 81aa879c13
[IPHLPAPI] Implement GetOwnerModuleFromUdpEntry() 2018-12-01 14:49:38 +01:00
Joachim Henze 3050d93deb [BROWSEUI] Properly fix CORE-13003 "Explorer address bar display problem"
The patches author is Doug Lyons. Thank you very much!
The patch is an addendum to 0.4.9-dev-732-g
ea0cc1c783
2018-12-01 14:26:33 +01:00
Pierre Schweitzer f5f3ff86ea
[LIBTIRPC] Fix CVE-2018-14621 by backporting its fix
CORE-15407
2018-12-01 12:16:41 +01:00
Hermès Bélusca-Maïto 95deef460b
[XOLEHLP] Import xolehlp.dll from Wine(-Staging) 3.21.
Should help improving the situation of the Microsoft SQL Server 2005
Express Edition installer. CORE-15399
2018-11-30 21:49:28 +01:00
Pierre Schweitzer 226195d4f2
[IPHLPAPI] Don't assume first member of MIB tables is always DWORD-big
This fixes last bits of heap corruption when using UDP/TCP enumeration
functions.
2018-11-30 20:06:29 +01:00
Pierre Schweitzer bf052e120b
[IPHLPAPI] Reduce code duplication and use a single function for TCP and UDP enumerations
Furthermore, memory was improperly allocated before (alignment issues) leading to heap
corruption under certain circumstances
2018-11-30 20:06:29 +01:00
Stanislav Motylkov ed7a78e97a
[SYSDM] Explicitly check DMI strings for NULL pointers
...to make CRT string comparison functions happy. CORE-15403
2018-11-30 16:55:29 +03:00
Pierre Schweitzer 3d2d957f81
[IPHLPAPI] Implement GetOwnerModuleFromTcpEntry()
CORE-4792
2018-11-29 20:36:08 +01:00
Pierre Schweitzer f87c88f6fe
[IPHLPAPI] Implement the *_TABLE_OWNER_MODULE_* in GetExtendedTcp/UdpTable() functions
This fixes CurrPorts in ReactOS. It now properly displays current connections along
with their creation time.

CORE-10134
2018-11-27 23:12:57 +01:00
Pierre Schweitzer 159f5b676a
[IPHLPAPI] Fix broken size computation leading to buffer overrun 2018-11-27 23:12:57 +01:00
Pierre Schweitzer 559297fe81
[IPHLPAPI] Implement getOwnerModUdpTable() and getOwnerModTcpTable()
These allow to enumerate UDP and TCP connections with module information
2018-11-27 23:12:56 +01:00
Pierre Schweitzer 7ce2f09a70
[SDK] Add AllocateAndGetTcp/UdpEx/2TableFromStack() functions family 2018-11-27 21:36:47 +01:00
Giannis Adamopoulos 1d55f459d6 [SHELL32] CFSDropTarget: Fix right click menu when shown over the tree view. CORE-11240 2018-11-27 12:58:08 +02:00
Giannis Adamopoulos 62c33fbf69 [BROWSEUI] CShellBrowser: Don't pass any parameters to Initialize. Let users use the BrowseObject method instead. 2018-11-27 10:33:57 +02:00
Pierre Schweitzer 6d6e371225
[IPHLPAPI] Start handling certain flags in GetAdaptersAddresses()
For now, we only support the most useful ones: IP_ADAPTER_DDNS_ENABLED,
IP_ADAPTER_REGISTER_ADAPTER_SUFFIX, IP_ADAPTER_DHCP_ENABLED
2018-11-26 22:43:43 +01:00
Luo Yufan 289301e22a [INETCFG] Update Simplified Chinese translation. (#1076) 2018-11-26 15:55:57 +01:00
Eric Kohl 57d48a7f1c [NETAPI32] Implement DsGetDcNameA/W --> DsGetDcNameWithAccountA/W --> DsrGetDcNameEx2. 2018-11-25 23:24:21 +01:00
Mark Jansen da02cc337a
[APISETS] Update from wine-3.20-144-g2ef62f9085 2018-11-25 19:06:29 +01:00
Mark Jansen a95afd562e
[APISETS] Teach update.py how to generate a manifest 2018-11-25 19:06:29 +01:00
Mark Jansen 6121df7321
[APISETS] Stubplement versioned forwarders 2018-11-25 19:06:16 +01:00
Pierre Schweitzer 1a964b5139
[IPHLPAPI] In GetAdaptersAddresses(), return friendly name if asked for 2018-11-25 18:04:13 +01:00
Pierre Schweitzer 26415375e3
[IPHLPAPI] Implement AllocateAndGetUdpExTable2FromStack()
CORE-14391
2018-11-25 13:32:52 +01:00
Pierre Schweitzer 0bca12e01f
[IPHLPAPI] Implement AllocateAndGetTcpExTable2FromStack()
CORE-14391
2018-11-25 13:29:26 +01:00
Pierre Schweitzer 291a58951f
[IPHLPAPI] Implement AllocateAndGetUdpExTableFromStack() 2018-11-25 12:23:27 +01:00
Pierre Schweitzer 58799a0ceb
[IPHLPAPI] Implement AllocateAndGetTcpExTableFromStack() 2018-11-25 12:19:44 +01:00
Bernhard Feichtinger 9cc37704f5 [OPENGL32] Fix wglDescribePixelFormat 2018-11-25 11:29:18 +01:00
Pierre Schweitzer 370b03b523
[IPHLPAPI] Reimplement GetUdpTable() using GetExtendedUdpTable() 2018-11-24 21:41:10 +01:00
Pierre Schweitzer 58cef01422
[IPHLPAPI] Implement GetExtendedUdpTable()
We only support IPv4 and UDP_TABLE_BASIC, UDP_TABLE_OWNER_PID
for now

CORE-5126
2018-11-24 21:41:10 +01:00
Pierre Schweitzer 6fb6c7b50b
[IPHLPAPI] Implement getOwnerUdoTable(), to get UDP connections with owner PID 2018-11-24 21:41:10 +01:00
Pierre Schweitzer 73c87d5c14
[IPHLPAPI] Reimplement GetTcpTable() using GetExtendedTcpTable() 2018-11-24 21:41:09 +01:00
Pierre Schweitzer d76ac645e8
[IPHLPAPI] Don't leak memory 2018-11-24 21:41:09 +01:00
Pierre Schweitzer c949a12506
[IPHLPAPI] Implement the IPv4 TCP_TABLE_OWNER_PID_* cases in GetExtendedTcpTable() 2018-11-24 21:41:09 +01:00
Pierre Schweitzer dca7e5689f
[IPHLPAPI] Implement getOwnerTcpTable(), to get TCP connections with owner PID 2018-11-24 21:41:09 +01:00
Pierre Schweitzer 702d44c683
[IPHLPAPI] Implement the IPv4 TCP_TABLE_BASIC_* cases in GetExtendedTcpTable() 2018-11-24 21:41:08 +01:00
Luo Yufan a2819679ec [TRANSLATION] Update Simplified Chinese translation. (#1057) 2018-11-23 16:24:47 +01:00
Joachim Henze 432afb4161 [SHELL32] Improve CORE-15295 IDD_FILE_PROPERTIES
addendum to 0.4.11-dev-673-g
04e1263921

Actually this control must not statically consume width of 170.
There are two different versions of that dialog.
One has a "change"-button. In this case the edit must be only 100 wide.
In case we have the version without the change button, we resize it to have
170 width (same as its neighbor).

This commit is shared work of
Stanislav Motylkov, Giannis Adamopoulos and Joachim Henze.

Commit supersedes PR#1056.
2018-11-23 02:25:28 +01:00
Stanislav Motylkov c1195f5300 [SYSDM][DXDIAG][SYSTEMINFO] Include only one user-mode DMI library (#1054)
Include only one user-mode DMI library. Addendum to baf2c0c.
2018-11-21 22:07:54 +01:00
Denis Malikov d897e271a2
[KERNEL32] FlsAlloc - fiber local storage list was not initialized before using 2018-11-21 19:18:01 +01:00
Pierre Schweitzer 8a98c85c1f
[IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections
This fixes the API not to return the current TCP connections while
enumerating them (and thus, netstat not displaying them).
It seems we return garbage for now though
2018-11-20 22:14:25 +01:00
Serge Gautherie 154ed37062 [NETSHELL] Fix '0' typo, in a text 2018-11-19 09:57:42 +02:00
Hermès Bélusca-Maïto 2d320f5a8d
[OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber. 2018-11-18 21:06:22 +01:00
Pierre Schweitzer d18b1fe24b
[IPHLPAPI] Properly count UDP entries
Fixes crash when running netstat -a with
no TCP connections but with UDP connections

CORE-5401
2018-11-18 18:56:36 +01:00
Pierre Schweitzer e3cb9697a4
[IPHLPAPI] Implement getNumUdpEntries() and getUdpTable()
CORE-5401
2018-11-18 16:30:45 +01:00
Pierre Schweitzer 678204790c
[IPHLPAPI] Implement getNumTcpEntries() and getTcpTable()
CORE-5401
2018-11-18 16:30:45 +01:00
Denis Malikov 6a2f967302 [OLE32] Add stub for CoDisconnectContext function (#1044) 2018-11-18 15:32:07 +01:00
Giannis Adamopoulos a9d92a99c6 [NETSHELL] Add some notes about how it can be tested in windows 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos f722ddac96 [NETSHELL] CNetConnectionPropertyUi: Add a comment about how windows write the settings 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 0654d60eef [NETSHELL] Move the implementation of the Disable button of the status dialog to CNetConnection::Disconnect 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 132463abf2 [NETSHELL] CNetConUiObject: Implement the Connect and Disconnect context menu items 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 7506198780 [NETSHELL] Optionally use the system's CLSID_ConnectionManager
Use a central compile option like we do in the rest of the shell so that when testing in windows we can switch using the one in the current dll or the one registered in the system.
Note that not only CLSID_ConnectionManager isn't implemented in netshell, it can't even be instantiated as CLSCTX_INPROC_SERVER because it is implemented by the netman service
2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 21a5a559f2 [NETSHELL] Rewrite how pidls are created and accessed.
What we did before was completely wrong as we stored pointers in the pidl.
2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 769b102e5f [NETSHELL] Use smart pointers and IID_PPV_ARG 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos c73d8c64bb [NETSHELL] Use ATL 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 8d47872ea0 [NETSHELL] Add missing license headers
Since one of the first files in the module (shfldr_netconnect.c) used the LGPL2.1+ license, all the other files have the same license
2018-11-18 14:01:54 +02:00
Pierre Schweitzer 5e024bfeb6
[MPR] Drop a nasty ReactOS specific hack
That hack (cf. previous commit) was used to restore all
the saved connections. But, because it was implemented
in the wrong place, each time the MPR DLL was attached,
it was trying to restore connections.

With that commit and the previous one, now, ReactOS has
a correct behavior (it tries to bring back connections
only at session opening) and will reduce "workload" for
applications attaching MPR dll.

CORE-15310
2018-11-17 22:13:34 +01:00
Pierre Schweitzer 8b0a126445
[MPR] Implement remembered connection enumeration
Submitted upstream

CORE-15310
2018-11-17 22:13:25 +01:00
Bișoc George c00bafaad9 [SHELL32] Print out the error code (#973)
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
2018-11-16 23:09:15 +01:00
Pierre Schweitzer 007cc5cd8a
[ACGENRAL] Don't leak memory on failure in InitIgnoreFreeLibrary()
CID 1441306
2018-11-16 22:07:09 +01:00
Pierre Schweitzer 52da844825
[COMCTL32] Don't leak memory in CB_ThemedPaint()
CID 1441313
2018-11-16 22:07:09 +01:00
Pierre Schweitzer 699af9f62a
[SETUPAPI] Allocate big enough buffer in CM_Query_Resource_Conflict_List().
CID 1441357
2018-11-16 22:07:08 +01:00
Pierre Schweitzer 3fddd3157c
[COMCTL32] Don't leak memory in PB_ThemedPaint()
CID 1441373
2018-11-16 22:07:08 +01:00
Pierre Schweitzer 402c983094
[SYSSETUP] Fix error message in ApplyRegistryValues()
CID 1441398
2018-11-16 22:07:07 +01:00
Giannis Adamopoulos 9baf05f164 [SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file
CORE-15353
2018-11-15 21:26:17 +02:00
Luo Yufan d8a4e0a8e3 [TRANSLATION]Update Simplified Chinese translation. (#1032) 2018-11-14 21:42:21 +09:00
Baruch Rutman 97150ce9dd [WINMM] Sync wine commit ebae298 as a fix for CORE-15336 (#1031)
Reduce CPU usage by only attempting once to load the default joystick driver.
Fix for CORE-15336

Imported wine commit ebae298
ebae298aa4
https://www.winehq.org/pipermail/wine-devel/2018-November/134767.html
2018-11-14 12:32:55 +01:00
Giannis Adamopoulos 73b679e4a6 [NETSHELL] CNetConUiObject: Fix implementation of IContextMenu.
The id that InvokeCommand gets is the one used by QueryContextMenu after subtracting idCmdFirst.
2018-11-11 20:28:36 +02:00
Giannis Adamopoulos cd7a331749 [NETSHELL] CNetConUiObject: Implement handling the rename context menu item 2018-11-11 20:28:34 +02:00
Giannis Adamopoulos af3a1b1936 [NETSHELL] CNetConUiObject: Use a switch in InvokeCommand 2018-11-11 20:28:32 +02:00
Giannis Adamopoulos 41639e94c2 [NETSHELL] CNetworkConnections: Remove SFGAO_CANRENAME bit when renaming shouldn't be enabled.
This fixes the problem where renaming could take place by clicking on a name even when it is disabled in the context menu.
CORE-14116
2018-11-11 20:28:31 +02:00
Giannis Adamopoulos 91119080bc [NETSHELL] CNetworkConnections: SetNameOf should always return a new pidl on success.
CORE-14116
2018-11-11 20:28:29 +02:00
Giannis Adamopoulos bcd309cb7a [SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before
CORE-14116
2018-11-11 20:28:27 +02:00
Luo Yufan 5cdee1ab82 [TRANSLATION] Update Simplified Chinese translation. (#1028) 2018-11-11 17:57:12 +01:00
Adam Słaboń b8044d6783 [TRANSLATION] Polish translation update (#1029)
Translated missing strings and improved existing translations.
2018-11-11 17:55:01 +01:00
Luo Yufan 91e032f9b1 [TRANSLATION] Update Simplified Chinese translation. (#1025) 2018-11-09 15:31:53 +01:00
Luo Yufan 7fafe923cb [SYSDM] Update Simplified Chinese translation. (#1021) 2018-11-08 14:08:34 +01:00
Joann Mõndresku b63e2d5046 [TRANSLATIONS] Style fixes for Estonian 2018-11-07 22:10:27 +01:00
Zcooger 52eee8955c [APPWIZ] Update polish translation (#921) 2018-11-07 16:20:32 +01:00
Joachim Henze 04e1263921 [SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs 2018-11-07 01:40:53 +01:00
Eric Kohl f26513f942 [NETSHELL] Add missing interface stubs to CNetworkConnections (aka CConnectionFolder). 2018-11-06 22:23:45 +01:00
Eric Kohl ee90e7f608 [LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions that use a policy handle and a domain name or domain SID when the machine is not a domain controller. 2018-11-04 15:27:57 +01:00
Eric Kohl 91eaa5e2d4 [LSASRV] Coding style fixes 2018-11-04 12:50:21 +01:00
Pierre Schweitzer 497a9c8087
[SETUPAPI] Don't let LZClose() reset error code 2018-11-02 09:34:25 +01:00
Carlo Bramini 8236bb8f38
Avoid stray temp files in failure cases of do_file_copyW. CORE-12616 2018-11-02 09:22:34 +01:00
Joachim Henze ad34c91d1c [RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.
2018-10-30 19:06:50 +01:00
Bișoc George 0c88f79480 [USRMGR] Fix a truncated text on French resource
CORE-15267
2018-10-28 19:30:17 +01:00
Mark Jansen 4bfac27ce6
[SHELL32] Fix broken control definition 2018-10-28 13:06:27 +01:00
Mark Jansen 95682e5406
[SETUPAPI] Fix broken control definition. 2018-10-28 13:06:08 +01:00
Mark Jansen 824e5dba51
[KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup 2018-10-28 13:01:38 +01:00
Mark Jansen 40549483f6
[KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup.
This should allow unhandled exceptions in a thread to trigger our crash reporter,
instead of killing the process directly.
2018-10-28 13:01:38 +01:00
Hermès Bélusca-Maïto e405ad257c
[SETUPLIB][USETUP][INPUT.CPL] MUI integration with setuplib.
[SETUPLIB] Copy the mui* files from usetup into the setuplib for later usage, and add mui.c to build.

svn path=/branches/setup_improvements/; revision=75711

[SETUPLIB][USETUP] Start massaging the MUI files and split up what concerns only the usetup "resources",
and what concerns general language parameters (in the setuplib).

It may be interesting to retrieve the language parameters
from INF file (e.g. intl.inf) (suggested by Giannis).

svn path=/branches/setup_improvements/; revision=75715

[SETUPLIB] Add the necessary headers to mui.c to be able to compile.
[USETUP] Comment out the languages that don't have any resources.

svn path=/branches/setup_improvements/; revision=75716

[SETUPLIB][USETUP] Adjust MUI and settings code.

- Re-enable settings code concerning language, keyboards & layout
  in the setuplib, and remove the old code in usetup.

- Remove useless code in setuplib's mui.c.

- Rename usetup's MUI "LanguageList" into "ResourceList" so as to
  avoid colliding with the "LanguageList" of setuplib.

- Add the magic CMakeLists line "add_definitions(${I18N_DEFS})" that
  I forgot previously, that caused the "LanguageList" of setuplib to be empty!

The code compiles and works during my tests.

svn path=/branches/setup_improvements/; revision=75717

[SETUPLIB] Change some string pointer types & function prototypes so that the usetup-specific
"SelectedLanguageId" variable is not used in the library.

svn path=/branches/setup_improvements/; revision=75719

[SETUPLIB] Change some function prototypes so that the usetup-specific "SelectedLanguageId" variable is not used in the library.
Also, make AddEntriesFromInfSection(), DefaultProcessEntry() and the typedef PPROCESS_ENTRY_ROUTINE private again.

svn path=/branches/setup_improvements/; revision=75720
svn path=/branches/setup_improvements/; revision=75724

[USETUP] Code adaptations.

- Transform some do{}while() loops into while(){} ones, since the lists on which we work may only contain one single {NULL} element.
- Modify MUIGetOEMCodePage() call after r75719.
- Use PCWSTR where needed.

svn path=/branches/setup_improvements/; revision=75722

[USETUP] Adjust some MUI & settings calls, following the commits r75719, r75720 and r75721.

svn path=/branches/setup_improvements/; revision=75723

[INPUT.CPL] Adjust inclusion of "muifonts.h" (commit 3dbd44f) due to changes introduced in r75711 and r75715.
2018-10-28 00:13:07 +02:00
Eric Kohl 0ce15a8faa [LSASRV][IDL] The first parameter of the Credr* functions is a PLSAPR_SERVER_NAME. 2018-10-27 18:17:35 +02:00
Hermès Bélusca-Maïto c8d37c1a0d
[SYSSETUP] Use a $winnt$.inf file to retrieve setup information for the 2nd-stage setup.
Following r75518, we use the $winnt$.inf file (created in System32
by the 1st-stage installer) as the setup information file for the
2nd-stage setup for:

- retrieving the installation source media path;
- retrieving the unattended information that was copied from the
  unattend.inf file from the installation source media.

The installation source media path is converted from NT format to
Win32 format for usage with Win32 functions and storage in the registry:
this is done by GetInstallSourceWin32(), which replaces the hackish
GetRosInstallCD() function.

The $winnt$.inf file is also updated, and the registry values "SourcePath"
and "ServicePackSourcePath" are created / updated in:
HKLM\Software\Microsoft\Windows\CurrentVersion\Setup .

svn path=/branches/setup_improvements/; revision=75524
2018-10-27 18:13:38 +02:00
Giannis Adamopoulos e69213448d [BROWSEUI] CInternetToolbar: fix whitespace 2018-10-27 15:08:31 +03:00
Giannis Adamopoulos a2bd9b44a9 [BROWSEUI] Simplify toggling the search band
In windows the toolbar itself creates the search shell extension. In ros we send a command to the CShellBrowser to let it handle it itself. Use the same command for showing and hiding it.
2018-10-27 15:08:28 +03:00
Giannis Adamopoulos a0c5cafce5 [BROWSEUI] Implement toggling the folders and search band with the toolbar and make their buttons appear pressed when they are shown.
CBaseBarSite: Ask the CBaseBar to close itself when the x button is pressed.
CBaseBar: Hide the bar and inform its site that it is closing when it gets the close command.
CShellBrowser: Cache the guid of the current vertical bar and use it to report correct command status to the toolbar.
Also implement toggling the Folders, Favorites, History and search commands.
CInternetToolbar: Query the Folders and Search command status from the site so that they can be properly be shown as pressed.
2018-10-27 15:08:24 +03:00
Stanislav Motylkov c83ac7600d [SHIMGVW] Fix image flickering when rendering animations 2018-10-24 23:05:00 +02:00
Baruch Rutman 6a3b1879a1 [LPK][GDI32] Enable mirroring via version resource (#965)
Add a mechanism that detects via the version resource whether it's needed to mirror
the application layout or not. This is a "follow up" to commit 5b14b6f.

This code is taken from the GetProcessDefaultLayout() function from Wine
(called there "WIN_CreateWindowEx").

In Windows the version-resource mirroring happens when the GDI is loading the LPK.

- Implement mirroring via version resource. GDI linking on startup is required.

- GDI32: Add LPK loading on GDI startup.

To enable mirroring via version resource the lpk.dll must be loaded before any windows are created.
This is done through GdiInitializeLanguagePack() function which is called in GdiProcessSetup().

- LPK: Use Wine debug messaging.
2018-10-24 21:34:38 +02:00
Katayama Hirofumi MZ 375a78e706
[SHIMGVW] Play gif animation (#934)
Make "Picture and Fax Viewer" able to play GIF animation.
CORE-12680
2018-10-24 19:51:30 +09:00
Stanislav Motylkov 7886ad46db [INETCPL] Add icon codes for trusted and restricted zones 2018-10-24 00:27:10 +02:00
Eric Kohl b5e956e7a8 [SETUPAPI] SetupDiGetClassDevPropertySheetsW: Implement adding property pages from an installer.
SetupDiGetClassInstallParamsW must be implemented before this will work.
2018-10-23 23:11:19 +02:00
Giannis Adamopoulos c69ef281c0 [rosctrls.h] CListView: Add Arrange method
[SHELL32] CDefView: Start implementing Auto arrange.
So far its effect is only shown when the browser window resizes.
2018-10-22 23:51:37 +03:00
Giannis Adamopoulos 410cfbfe15 [SHELL32] CDefView: Disable auto arrange in list and details view mode.
This supersedes PR #927 and does it correctly.
2018-10-22 19:18:28 +03:00
Giannis Adamopoulos e9cba5375b [BROWSEUI] CInternetToolbar: Implement hiding and showing the browser toolbars. 2018-10-22 18:42:38 +03:00
Stanislav Motylkov 3290d4619b [SYSDM] Fix controls order and label height in IDD_SYSSETTINGS dialog
This fixes checkbox rendering issue in russian translation.
Dialogs in other translations are ok.

CORE-13792
2018-10-21 15:36:28 +02:00
Bișoc George f31cf503fb
[APPWIZ] Do not display the message box if the user aborts the download
CORE-15183
2018-10-21 13:10:12 +02:00
Adam Słaboń 7abc8be102 [TRANSLATION] Polish translation update
Polish translation of net, telnet, diskpart, devcpux, fontext, iernonce, lsasrv, themes, arping, frag, screensavers, ctm, fontsub, WinetestsGUI and localmon.
Update for dxdiag, msgina, msports, netcfgx, shell32 and syssetup.
2018-10-20 21:26:07 +02:00
Bișoc George e9f993d1b8 [APPWIZ] Translation update for Romanian & Italian 2018-10-20 21:16:48 +02:00
Eric Kohl debb1e521a [NETCFGX] Implement the Min and Max options for int, long and word parameters.
CORE-15095
2018-10-14 21:02:45 +02:00
Eric Kohl 731ef01361 [NEWDEV] Add InstallDevInstEx 2018-10-14 18:19:52 +02:00
Mark Jansen 80c53821c9
[SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view.
CORE-14976
2018-10-13 20:28:49 +02:00
Eric Kohl a5172b4699 [NETCFGX] Move the NetClassInstaller to a separate file. 2018-10-13 19:18:37 +02:00
Mark Jansen 1968776bf2
[DBGHELP] Exclude stubs from pch 2018-10-12 19:30:36 +02:00
Mark Jansen 71993fd8c9
[KERNEL32] Fix some stubs for 0x600+ 2018-10-12 19:30:24 +02:00
Pierre Schweitzer 8f4d8cb616
[APPWIZ] Update French translation 2018-10-10 08:42:38 +02:00
Eric Kohl d58f6558e0 [NETCFGX] NetworkPropertySheetProvider: Fix property selection because the property list box is sorted.
CORE-15095
2018-10-09 23:19:48 +02:00
Hermès Bélusca-Maïto 8468ad5cf4
[SYSSETUP] Delete the created fonts when needed. 2018-10-08 21:16:58 +02:00
Hermès Bélusca-Maïto 6267898583
[SYSSETUP] Use ARRAYSIZE / _countof instead of sizeof ratios.
svn path=/branches/setup_improvements/; revision=75523
2018-10-08 21:16:57 +02:00
Hermès Bélusca-Maïto e9893906a7
[SYSSETUP] Code formatting.
svn path=/branches/setup_improvements/; revision=75522
2018-10-08 21:16:56 +02:00
Eric Kohl 11c9e773fb [NETCFGX] NetPropPageProvider: Add Base and Step parameter options. 2018-10-08 18:55:39 +02:00
Baruch Rutman 87c529a537
[LPK] Small fix and a related comment. (#890)
[LPK][USER32] Fix reading layout checks.

- Both functions don't care about DT_RTLREADING flag.
- Added a different method to check reading order.

[USER32] Remove gcc-build breaker semicolon.
2018-10-08 16:17:42 +02:00
Baruch Rutman a494d0583f
[LPK] Implement LpkPSMTextOut(). (#890)
- The function is almost fully implemented, but some return values change wildly.
  The results are mostly compatible to the Windows results.

- Remove #ifdef (this is primary ReactOS code).
2018-10-08 16:16:40 +02:00
Stanislav Motylkov b3179a0771 [APPWIZ] Update russian translation (#917) 2018-10-08 14:53:11 +02:00
Bișoc George cb499cd1fd [APPWIZ] Display a message box in case of failure (#913)
When the downloading process of Gecko fails, display a warning message box.
2018-10-08 14:36:40 +02:00
Stanislav Motylkov ab9baa2d09 [SYSDM] Fix IDC_ROSVERSION in Romanian translation 2018-10-08 14:34:11 +02:00
Stanislav Motylkov 3779c2e770 [SYSDM] Add system uptime information 2018-10-08 14:34:11 +02:00
Stanislav Motylkov 80d26b1646 [SYSDM] Make MHz and GHz strings translatable 2018-10-08 14:34:11 +02:00
Hermès Bélusca-Maïto 2cbac3d049
[SHELL32] Finally fix the icon location path (un)expansion for shell links, and explain why I originally used SHExpandEnvironmentStringsW().
CORE-14009 CORE-14982
2018-10-08 00:50:38 +02:00
Eric Kohl 1e20a3e5b5 [SHELL32] Fix a potential buffer overrun.
Patch by Kudratov Olimjon.

CORE-8545
2018-10-07 22:56:16 +02:00
Luo Yufan b70ef2ee56 [TRANSLATION] Update Simplified Chinese translation. (#912) 2018-10-07 20:44:00 +02:00
Stanislav Motylkov 732a6b0801 [NETCFGX] Update russian translation 2018-10-07 18:28:43 +02:00
Stanislav Motylkov 0934d4f171 [MSPORTS] Update russian translation 2018-10-07 18:28:43 +02:00
Stanislav Motylkov 10b7b94f45 [DEVMGR] Update russian translation 2018-10-07 18:28:43 +02:00
Eric Kohl 45cd6d5e4e [NETCFGX] NetPropPageProvider: Store the parameters in the registry 2018-10-06 23:57:17 +02:00
Eric Kohl 7ad65a3773 [NETCFGX] NetPropPageProvider: Improve the handling of optional parameters
- Add a pointer to the current parameter.
- Change the 'present' and 'not present' radio buttons to auto radio buttons.
- Display present and non-present optional parameters properly.
2018-10-06 14:33:48 +02:00
Eric Kohl c603c54ab0 [MSPORTS] When the LPT port number gets changed, update the PortName and FriendlyName values in the registry. 2018-10-06 11:12:16 +02:00
Eric Kohl f9739601b3 [DEVMGR] Hackfix CORE-5643 2018-10-05 15:09:27 +02:00
Pierre Schweitzer f2f24c1fa7
[DEVMGR] Update French translation 2018-10-04 11:13:15 +02:00
Eric Kohl c444231b87 [MSPORTS] Check and show which parallel port is in use. 2018-10-04 10:21:06 +02:00
Mark Jansen 1a9b50690a
[LDR] Include dllname in snap failure DPRINT.
CORE-15135
2018-10-03 19:34:14 +02:00
Bișoc George 758f9fbdb9 [NEWDEV] Fix a truncated text on device driver name 2018-10-02 21:54:30 +02:00
Eric Kohl 91ba4e7350 [NETCFGX] Network property page: Add support for enum type options, the 'Optional' setting and the 'TextLimit' and 'Uppercase' settings for edit type options. 2018-10-02 17:58:16 +02:00
Eric Kohl c6142174af [NETCFGX] Network property page: Implement reading of configured settings. Editing and writing is not implemented yet. 2018-10-01 21:16:22 +02:00
Mark Jansen cc27de18f4
[DMUSIC] Fix the build for vs 2010 2018-10-01 20:47:01 +02:00
Amine Khaldi 0ccdd32f50 [ITSS] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:57:08 +01:00
Amine Khaldi 6bd06f3b76 [INETMIB1] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:56:32 +01:00
Amine Khaldi 33351fe5ad [INETCOMM] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:55:17 +01:00
Amine Khaldi 789fa9c819 [IMM32] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:53:21 +01:00
Amine Khaldi d4bc0feb6e [IMAADP32.ACM] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:52:44 +01:00
Amine Khaldi 336b2a4564 [IEFRAME] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:52:10 +01:00
Amine Khaldi a214feb6fe [HHCTRL.OCX] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:51:35 +01:00
Amine Khaldi 8d2e1e843c [GDIPLUS] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:50:25 +01:00
Amine Khaldi fe0fd16499 [FUSION] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:49:44 +01:00
Amine Khaldi 4fc4698f2a [CRYPTUI] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:49:09 +01:00
Amine Khaldi 997d44c915 [CRYPT32] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:47:51 +01:00
Amine Khaldi 409344041f [CREDUI] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:46:19 +01:00
Amine Khaldi eaac1cc75f [COMDLG32] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:44:53 +01:00
Pierre Schweitzer 37e0012be1
[DMUSIC] Fix build? 2018-10-01 11:04:26 +02:00
Amine Khaldi 21d3faa2a6 [ATL] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:26:43 +01:00
Amine Khaldi 0df75d9648 [ADVPACK] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:25:34 +01:00
Amine Khaldi 698fd79dd2 [QEDIT] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:24:54 +01:00
Amine Khaldi 64c1a65258 [MSDMO] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:24:18 +01:00
Amine Khaldi a8126f3f1e [DPLAYX] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:23:02 +01:00
Amine Khaldi a16afc25c9 [DMUSIC] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:22:26 +01:00
Amine Khaldi ad21be5e5f [DINPUT] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:20:57 +01:00
Amine Khaldi db2b3364c6 [D3DXOF] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:20:18 +01:00
Amine Khaldi bcb816619a [D3DX9_36] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:19:39 +01:00
Amine Khaldi c003509323 [D3DCOMPILER_43] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:19:01 +01:00
Amine Khaldi d02c72252c [INETCPL] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:18:08 +01:00
Amine Khaldi 82faa151e5 [XDK][PSDK][WINE] Unify ARRAY_SIZE definition for Wine modules. CORE-15127 2018-09-30 23:57:08 +01:00
Hermès Bélusca-Maïto ccde12483f
[SHELL32] Fixes and improvements for PickIconDlg().
- Deal with expanded paths only when loading icons. If the user specifies
  an unexpanded path to a module containing icons, this unexpanded path
  is returned to the caller!

- Perform the dialog cleanup in WM_DESTROY message handler.

- When pressing ENTER/OK in the dialog box, retrieve the selected icon and
  close the dialog *ONLY WHEN* the user actually has selected an icon.
  If the user modified manually the module path, pressing ENTER/OK instead
  reloads the icons list.
2018-09-30 21:48:34 +02:00
Hermès Bélusca-Maïto ae9ec94240
[SHELL32] Code formatting only. 2018-09-30 21:48:31 +02:00
Eric Kohl 4aa1bee757 [SYSETUP] Implement the CriticalDeviceCoInstaller
The CriticalDeviceCoInstaller adds devices of registered classes to the critical device database.
2018-09-30 17:23:38 +02:00
Eric Kohl 54eb5635d8 [MSPORTS] Implement the 'Enable legacy Plug and Play detection' setting 2018-09-29 18:05:22 +02:00
Abdulganiev Rafael 6f138e2811 [DESK.CPL] Remove monitor resource scaling (#876) 2018-09-29 16:24:10 +02:00
Stanislav Motylkov 4eccca5943
[SYSDM] Add hardware model name print 2018-09-29 17:12:18 +03:00
Stanislav Motylkov 797d2354fa
[SYSDM] Add one more IDC_MACHINELINE for model name 2018-09-29 17:11:57 +03:00
Stanislav Motylkov bd1fc964e7
[SYSDM] Move system information controls 16 points higher 2018-09-29 17:11:31 +03:00
Eric Kohl 133611fed8 [MSPORTS] Implement the 'Filter Resource Method' setting for parallel ports 2018-09-29 14:58:55 +02:00
Pierre Schweitzer 1f85e4fe9f
[DEVCPUX] Add French translation 2018-09-29 11:36:45 +02:00
Eric Kohl f155de483f [msports] Notify the system of changes to the serial port settings. 2018-09-29 01:57:59 +02:00
Hermès Bélusca-Maïto c446ce0d62
[ADVAPI32] Improve a bit CreateProcessAsUser().
- Check whether the user-provided token is a primary token.

- Do not fail when the RtlAdjustPrivilege() call fails (see the code
  comment for an explanation). TL;DR is: that call may indeed fail but
  the privilege may also not be necessary because the user-provided
  token is a restricted version of the caller's primary token.
  And this is situation is perfectly fine.

This fixes Java 7 installation, CORE-14874.
2018-09-28 00:45:04 +02:00
Stanislav Motylkov 0fa744241f [DEVCPUX] Add russian translation
Also make MHz string translatable. Addendum to 793e2a3.
2018-09-27 12:10:06 +02:00
Eric Kohl 3c1e5f7cb9 [NETCFGX] Add the most simple property sheet provider for network adapters
- Switch to WINE debug code.
- Build the UNICODE version of the DLL by default.
- Add the most simple property sheet provider.
2018-09-26 23:49:02 +02:00
Eric Kohl 986ce63c4c [SETUPAPI] SetupDiGetClassDevPropertySheetsW: Support class property sheet providers. 2018-09-26 23:49:01 +02:00
Stanislav Motylkov 68c6641781 [MSPORTS] Add russian translation
Addendum to 69e834f.
2018-09-25 22:50:02 +02:00
Eric Kohl 793e2a38b4 [DEVCPUX] Make the CPU property sheet page a little nicer and make it translatable 2018-09-25 21:51:19 +02:00
Eric Kohl af37e0e565 [MSPORTS] Hackfix the code to determine the serial and parallel port numbers.
Now that SetupDiCreateDevRegKeyW is working as expected, we can no
longer (ab)use it to retrieve a ports resources. Use SetupDiGetDeviceInstanceIdW instead and open the registry keys manually.
2018-09-25 17:48:27 +02:00
Eric Kohl 69e834fa54 [MSPORTS] Implement serial port settings
- Fix the control styles and grouping in the dialogs.
- Implement reading, modifying and writing of the serial port settings.
2018-09-25 14:28:29 +02:00
Eric Kohl 185a8fd835 [NETSHELL] Read, write and display the 'Notify me when this connection...' option for network connections. 2018-09-23 23:31:00 +02:00
Eric Kohl df36ee9fe2 [SETUPAPI] Replace the remaining internal calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKeyW by calls to SETUPDI_OpenDrvKey, SETUPDI_CreateDevKey or SETUPDI_CreateDrvKey. 2018-09-23 20:19:26 +02:00
Hermès Bélusca-Maïto bf164caae8
[SERVICES] Simplify the implementation of RGetServiceDisplayNameA/W() and RGetServiceKeyNameA/W().
Also comment about the observed behaviour of the returned number of "characters"
returned by the ANSI versions of these APIs (which is tested by advapi32_winetest:service).

[ADVAPI32:SCM] Add a comment concerning wide characters vs. bytes mismatch.
2018-09-23 18:09:10 +02:00
Eric Kohl 60e166535a [SETUPAPI] Do not use SetupDiOpenDevRegKey in other SetupDi functions. Use SETUPDI_OpenDevKey or SETUPDI_OpenDrvKey instead.
Note: The remaining calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKey will be fixed in another patch.

Fixes CORE-15091
2018-09-23 16:16:12 +02:00
Hermès Bélusca-Maïto 7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed.
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings()
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981
2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto 41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine.
- Adjust the code with respect to:
  "shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
  4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)

- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
  ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)

- "shell32: Assume that system directory always contains a drive letter."
  54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)

- "shell32: Use ARRAY_SIZE macro."
  612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)

- "shell32: Fix a trace message."
  bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)

- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
  f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)

- "shell32: Pass correct buffer length to RegQueryValueExW()."
  0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)

- "shell32: Remove unused string (Clang)."
  8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)

- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
  730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
2018-09-23 00:16:02 +02:00
Eric Kohl de08785ade [SETUPAPI] SetupDiCreateDevRegKeyW / SetupDiOpenDevRegKey: Create or open the 'Device Parameters' subkey of the given devices enum key when we try to access its hardware key.
This creates the PortName value in the proper location for serial ports.
2018-09-22 14:43:43 +02:00
Abdulganiev Rafael 2a6aa7770e [BTHCI] Add a bluetooth icon (#871)
[BTHCI] Add a bluetooth icon
2018-09-21 23:42:27 +02:00
Eric Kohl f8f83d4d4d [BTHCI] Add a bluetooth class installer stub.
Now we really need a tango-compatible bluetooth icon!
2018-09-20 17:53:08 +02:00
Eric Kohl 5e2fe08918 [WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service.
The Logoff-Handler might try to notify the scheduler service which might already have been shut down. We need to fix the shutdown sequence, so that the service manager stops all running services.

Might fix CORE-14521.
2018-09-19 16:35:12 +02:00
Eric Kohl 76588be0d1 [ADVAPI32][SERVICES] Use the session key provided by SystemFunction028 to encrypt and decrypt the service passwords. 2018-09-19 12:30:33 +02:00
Eric Kohl 4114dcad46 [ADVAPI32] Implement SystemFunction028 to always return the default session key. 2018-09-19 00:20:11 +02:00
Eric Kohl e5fcda922b [ADVAPI32][SERVICES] Pass encrypted passwords to the service manager.
- Encrypt passwords before passing them to the service manager. Right now, we are using a fixed encryption key. This will be fixed later.
- Replace the calls to ZeroMemory which are used to wipe the password buffers by calls to SecureZeroMemory.
2018-09-18 21:33:29 +02:00
Eric Kohl da73c81259 [IDL][LSASRV] Improve the credentials interface a little and update the lsa server code accordingly. 2018-09-18 15:55:18 +02:00
Eric Kohl 6c0d9c01e2 [ADVAPI32] SystemFunction004 and SystemFunction005 must return the required output buffer size via out->Length when the buffer is too small. 2018-09-17 23:19:02 +02:00
Eric Kohl 5e2c4657ca [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager 2018-09-17 16:34:48 +02:00
Eric Kohl 47714b25a9 [NETAPI32] Add more DFS stubs 2018-09-16 21:11:16 +02:00
Pierre Schweitzer 8c5b0fbff3
[KERNEL32_VISTA] Make SleepConditionVariableSRW fail when it times out
This fixes a few newly added winetests.
2018-09-16 14:50:01 +02:00
Pierre Schweitzer 58853297dc
[KERNEL32_VISTA] Make SleepConditionVariableCS fail when it times out
This fixes a few newly added winetests.
2018-09-16 14:42:43 +02:00
Mark Jansen 12654d2852
[KERNEL32] Ensure the PebLock is always released in FlsFree 2018-09-15 17:56:03 +02:00
Mark Jansen 06eb99edef
[NTDLL][KERNEL32] Implement FLS callbacks. 2018-09-15 17:56:03 +02:00
Eric Kohl e13ff1470e [DESK] Add MonitorClassInstaller 2018-09-15 14:11:04 +02:00
Pierre Schweitzer 71ac5e6c65
[SHELLBTRFS] Fix GCC build
CORE-15048
2018-09-15 10:54:00 +02:00
Thomas Faber 0f47f27829
[SHELLBTRFS] Add exports according to upstream .def file. CORE-15048 2018-09-15 09:43:31 +02:00
Pierre Schweitzer f4da2bab03
[MPR] Import Wine commit: 93fb279f4f3e150eee329b02ca5fb0251d8a239d
Properly handle device-less connections.

CORE-15012
2018-09-14 22:34:02 +02:00
Stanislav Motylkov 8d6c519a95 [SYSDM.CPL] Fixup control positions after font metrics fix 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 877dffa918 [DESK.CPL] Settings: Fixup control positions 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 8df45999f2 [DESK.CPL] Screensaver: Fixup control positions 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 36bebe7427 [DESK.CPL] Background: Fixup control positions after font metrics fix 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 432788b59f [DESK.CPL] Appearance: Fixup control positions after font metrics fix
CORE-14274
2018-09-14 11:15:26 +02:00
Katayama Hirofumi MZ 31019e8c0c [TRANSLATION] Update Romanian translation (#851)
Translation from Stefan Fulea.
CORE-15023
2018-09-14 11:04:36 +02:00
Pierre Schweitzer 62f79fae93
[MPR] Import Wine commit: 0799550075654094a3bed080aac722b9bea01307
Implement WNetClearConnections().

CORE-15012
2018-09-14 08:08:57 +02:00
Mark Jansen 8642654a00
[KERNEL32] Do not embed binary data inside a string resource.
CORE-14948
2018-09-12 21:31:55 +02:00
Mark Jansen 25d143dd20
[DBGHELP] Prevent crashing on a malformed PE file.
CORE-15030
2018-09-12 21:30:49 +02:00
Eric Kohl ee4ee2fc1d [NETAPI32] Remove the obsolete file group.c 2018-09-12 17:53:49 +02:00
Eric Kohl 221cdeafe2 [NETAPI32] Rename ENUM_CONTEXT to GROUP_ENUM_CONEXT and fix a use of the wrong type 2018-09-12 17:38:18 +02:00
Eric Kohl 4d9425d123 [NETAPI32] Implement NetGroupSetUsers 2018-09-12 17:11:52 +02:00
Eric Kohl e0b5050089 [NETAPI32] Implement NetLogonGetTimeServiceParentDomain 2018-09-11 15:02:19 +02:00
Pierre Schweitzer cf0112a6e6
[MPR] Implement WNetClearConnections()
This has been submitted upstream.

CORE-15012
2018-09-11 08:30:23 +02:00
Eric Kohl 74620c94d3 [NETAPI32] Implement NetGroupGetUsers 2018-09-10 22:05:49 +02:00
Baruch Rutman ab5fdcc01f
[LPK] Make GetCharacterPlacement caret positions respect bidi. (#842)
- Try to make use of ScriptStringCPtoX when trying to fill the lpCaretPos struct member;
  if USP10 error happens fallback to the unreorder method.
- Remove now incorrect debug print.
2018-09-09 18:03:45 +02:00
Katayama Hirofumi MZ a244e4f6dd [WIN32SS][COMCTL32] Fix button text Y positioning (#766)
Fixes the vertical position of button text.
CORE-14906
2018-09-09 17:37:37 +02:00
Eric Kohl 2d645f62fe [NETAPI32] Implement NetGroupAddUser and NetGroupDelUser 2018-09-09 17:35:18 +02:00
Eric Kohl df0137a169 [NETAPI32] Implement NetGroupSetInfo 2018-09-09 13:39:01 +02:00
Eric Kohl c48d09d19a [NETAPI32] Implement NetGroupAdd and NetGroupDel 2018-09-09 11:52:44 +02:00
Eric Kohl a9da3c50be [NETAPI] Implement NetGroupGetInfo 2018-09-09 09:40:11 +02:00
Eric Kohl 033146ca23 [NETAPI] Implement NetGroupEnum 2018-09-08 20:55:13 +02:00
Eric Kohl 0e69bc3bce [SAMSRV] Fix SamrQueryInformationGroup
- Use the registry value AdminComment for admin comments instead of Description. Fix SamrSetInformationGroup as well.
- Add some TRACEs.
- Do not fail if the Members value does not exist.
2018-09-08 19:24:13 +02:00
Abdulganiev Rafael 25f4ed75a0 [CPL][DESK] Update monitor resource (#816)
[DESK.CPL] Update monitor resource
2018-09-07 08:43:36 +01:00
Pierre Schweitzer 000bbe074e
[LIBTIRPC] Fix CVE-2018-14622 by backporting its fix
CORE-15005
2018-09-05 22:06:30 +02:00
Eric Kohl df053b7d16 [MSV1_0] LsaApLogonUser: Update the logon time/count and bad password time/count 2018-09-05 00:10:54 +02:00
Eric Kohl 97382dee46 [MSV1_0] Use the account expiration time and check account expiration on logon 2018-09-04 23:15:15 +02:00
Eric Kohl e25cbeba2f [IDL] Implement parts of SamrSetInformationUser.UserInternal2Information 2018-09-04 22:42:49 +02:00
Bișoc George 4208e7eed8 [FONTEXT] Add Italian translation (#831) 2018-09-04 22:02:44 +02:00
Bișoc George 773d6a536a [ACCESS] Fix some truncated strings in French resource (#838) 2018-09-03 14:14:57 +02:00
Eric Kohl 653a9be05b [SAMSRV] Implement SamrQueryInformationUser.UserInternal2Information 2018-09-02 17:54:26 +02:00
Stanislav Motylkov c7415b3faa [MSGINA] Update russian translation (#834)
Addendum to 6f4d70b.
2018-09-02 15:59:33 +02:00
Eric Kohl 6f4d70b405 [MSGINA] Display the 'account expired' message when a user tries to log on using an expired account. 2018-09-01 21:10:42 +02:00
Denis Malikov 69a040d275 [KERNEL32] fix spec file for -version=0x600+
CORE-12596
2018-09-01 17:21:21 +02:00
Pierre Schweitzer 2bd33d58d8
[KERNEL32] Shhhh! 2018-09-01 15:46:44 +02:00
Joachim Henze e217e926e1 [SHELL32] Fix typo in comment 2018-08-28 14:24:49 +02:00
Mark Jansen 191dceb034
[LDR] Load kernel32 in LdrpInitializeProcess.
This allows kernel32 to register itself for manifest probing when loading dlls
CORE-9219
2018-08-27 20:05:00 +02:00
Mark Jansen ffae49deaf
[COMCTL32] Unregister some classes that were registered.
This should help fix some crashes.
2018-08-27 19:49:57 +02:00
Katayama Hirofumi MZ 39dc3cdaf6 [SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824)
CORE-14974
2018-08-27 12:21:51 +02:00
Mark Jansen 19e9a44118
[SHELL32] Check the result from PathUnExpandEnvStringsW 2018-08-27 11:58:29 +02:00
Mark Jansen 608cb60e44
[SHELL32] Remove some mostly dead code from CShellLink 2018-08-27 11:58:24 +02:00
Eric Kohl fc2b4bc7ea [LSASRV] LsapLogonUser creates an impersonation token for a network logon 2018-08-27 00:19:10 +02:00
Eric Kohl a7b52d6a44 [SAMSRV] Simplify the initialization of the account expiration time 2018-08-27 00:12:44 +02:00
Eric Kohl 2fafcff3ef [SAMLIB] Add stubs for SamTestPrivateFunctionsDomain and SamTestPrivateFunctionsUser 2018-08-27 00:11:21 +02:00
Eric Kohl a9f2677782 [SAMSRV] Simplify the initialization of the account expiration date for new user accounts 2018-08-26 21:26:31 +02:00
Eric Kohl dcc188e974 [NETAPI32] Add code to handle special values of the last logon time, last logoff time and account expiration time 2018-08-26 21:07:05 +02:00
Katayama Hirofumi MZ 6eb6aa2895 [SHELL32] Fix CShellLink::GetIconLocation (#810)
Fixes a regression from PR #784.
CORE-14961, CORE-14009
2018-08-26 15:37:15 +02:00
Baruch Rutman e7d2bbe726 [WIN32SS][LPK] Add BiDi support to menus and window captions (#738)
Added callback function that redirects calls to GreExtTextOutW that didn't went through lpk BiDi processing, calls that are from the kernel.

Completely solves JIRA issue CORE-6910.
2018-08-23 19:43:12 +02:00
Katayama Hirofumi MZ 86b915ef84 [TRANSLATION][ZIPFLDR] Add Japanese translation (#799)
CORE-14954
2018-08-22 14:26:53 +02:00
Andreas Bjerkeholt 5a2a0314a1 [TRANSLATION][ZIPFLDR] Add Swedish translation (#794) 2018-08-21 16:57:01 +02:00
Serge Gautherie 990e7dfd1a [MSHTML] Fix 3 MSVC warnings about HTML*Element_handle_event()
- "...\htmlanchor.c(769) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlarea.c(427) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlform.c(757) : warning C4028: formal parameter 2 different from declaration"

Cherry-pick Jacek Caban a660f673cb
CORE-7538
2018-08-21 14:33:52 +02:00
Katayama Hirofumi MZ 73798d2e71 [SHELL32] Enable to change shortcut icon (#784)
CORE-11407
2018-08-21 13:49:32 +02:00
Robert Naumann b3cfe88eda [BROWSEUI] Show Tooltip text for 'Go' Button
-Patch by Barret Karish CORE-11058
2018-08-21 12:49:04 +02:00
Andreas Bjerkeholt a4554c07b0
[ZIPFLDR] Enable / disable the correct wizard buttons 2018-08-21 12:06:41 +02:00
Timo Kreuzer 36051d3065 [SYSSETUP] Fix handling of the status message window
This fixes a race condition, where the message thread was still running when InstallReactOS returned and syssetup.dll was unloaded by the caller (setup.exe).
2018-08-20 22:10:04 +02:00
Serge Gautherie 2e7b73dc75 [MSHTML] Fix an MSVC warning about HTMLInputElementImpl_fire_event()
"...\htmlinput.c(1303) : warning C4028: formal parameter 2 different from declaration"

Temporary fix, until WINESYNC replaces this function.
CORE-7538
2018-08-20 19:06:00 +02:00
Adam Słaboń af3d426685 [TRANSLATION] Polish translation update (#781)
In addition: fix the encoding of the comdlg32 and ntvdm polish resource files.
2018-08-20 17:00:33 +02:00
Eric Kohl 91fab9e53b [SETUPAPI] SetupDiGetDeviceRegistryPropertyW call CM_Get_DevNode_Registry_Property_ExW for properties that can not be retrieved from the registry 2018-08-20 00:16:18 +02:00
Pierre Schweitzer e8611d3e65
[NETSHELL] Update French translation to reflect 0725098 2018-08-19 20:50:55 +02:00
Stanislav Motylkov 844483504b [KERNEL32] Implement system firmware functions properly 2018-08-19 20:27:59 +02:00
EUPHORIA-IT\m.jansen bb5f8cfccb [WSHOM.OCX] Zero-initialize timeout and type if they are not set.
This should fix buildbot timeouts
2018-08-19 16:14:08 +02:00
Eric Kohl a8cf35d0e4 [SYSSETUP] SetupStartService: Remove the wait loop
CORE-14909
2018-08-19 14:32:29 +02:00
Thomas Faber c97e9defc1
[WINED3D] Yield CPU to the scheduler in wined3d_pause. CORE-14637 CORE-14534
Much like the previous commit, this is a workaround for our buggy Win32k.
2018-08-19 13:46:08 +02:00
Thomas Faber adfbefde2b
[WINED3D] Avoid spinning in wined3d_cs_run. CORE-14534
Spinning here is supposed to improve performance by avoiding scheduling
overhead, but because ReactOS's Win32 subsystem does not deal with this well,
it causes the system to freeze on ROS.
As a workaround, we disable spinning and jump directly to the wait.

It should become obvious when this starts actually causing performance issues
again and it's time to undo.
2018-08-19 13:46:02 +02:00
Eric Kohl 9a36ee8359 [WLNOTIFY] Use the wine debug method, add wlnotify to the build and fix some typos 2018-08-18 22:20:17 +02:00
Mark Jansen cf56e1cb58 [GDIPLUS] Add sxs registration for 1.0 version.
Needed by by some applications with MSVCR90.dll
CORE-14695
2018-08-18 18:25:13 +02:00
Eric Kohl df849213a2 [WLNOTIFY] Add SCard, Termsrv and Wlballon notifications and remove the test notifications 2018-08-18 16:18:36 +02:00
Katayama Hirofumi MZ 0725098c74 [NETSHELL] Fix the too long texts 2018-08-18 13:18:03 +02:00
Timo Kreuzer 094a90ad4e [NTOS:PS] Fix an issue with PROCESS_DEVICEMAP_INFORMATION size on 64 bit builds
The PROCESS_DEVICEMAP_INFORMATION  union has 2 fields, one is a handle, the other one is a structure of 36 bytes (independent of architecture). The handle forces 64 bit alignment on 64 bit builds, making the structure 4 bytes bigger than on 32 bit builds. The site is checked in NtQueryInformationProcess (case ProcessDeviceMap). The expected size on x64 is the size of the Query structure without alignment. autocheck correctly passes the site of the Query union member, while smss passes the full size of PROCESS_DEVICEMAP_INFORMATION. Packing the structure is not an option, since it is defined in public headers without packing. Using the original headers sizeof(PROCESS_DEVICEMAP_INFORMATION) is 0x28, sizeof(PROCESS_DEVICEMAP_INFORMATION::Query) is 0x24.
2018-08-17 22:08:37 +02:00
Joachim Henze abf9340f1b [SHELL32] Translation de-DE CORE-14916
fix control overlapping in IDD_FOLDER_OPTIONS_FILETYPES
(broke in 0.4.10-dev-24-ed1c6bb0060d06f4c0167d9c2d732f4dc2b4cce4)

and translate IDD_NEWEXTENSION, IDD_EDITTYPE, IDD_ACTION, IDD_FOLDER_CUSTOMIZE
2018-08-17 18:07:35 +02:00
Serge Gautherie 2ad650469e [OLEAUT32] Fix an MSVC warning about VarCyMul()
"...\vartype.c(3808) : warning C4028: formal parameter 2 different from declaration"

Mininal cherry-pick Alexandre Julliard 18f7ec3670
CORE-7538
2018-08-17 16:18:41 +02:00
Getequ d559ca9c98 [ADVAPI32][SHELL32][DESK.CPL] Kill copy-paste of RegLoadMUIString. (#748)
RegLoadMUIStringW/A is part of advapi32.dll . shell32.dll and desk.cpl contained exact line-by-line copy of that function.
2018-08-16 16:10:41 +02:00
Stanislav Motylkov 68a4cdd5ec [SYSDM] Use single string control for system version 2018-08-15 19:30:23 +02:00
Katayama Hirofumi MZ 6d9f89f813 [SYSSETUP] Fix the button sizes of theme selection dialog (#746)
CORE-14896
2018-08-15 18:32:17 +02:00
Mike Swanson 3c7e9bb332 Remove unnecessary executable bits 2018-08-15 18:29:09 +02:00
Mark Jansen 9b6fb9f2f8
[RTL][KERNEL32] Add a comment indicating we need SEH in RtlImageNtHeaderEx
CORE-14532
CORE-14857
2018-08-13 13:24:12 +02:00
Mark Jansen ad08c6631b
[LDR] Guard some sections where we grab a lock.
CORE-14532
2018-08-13 13:24:12 +02:00
Mark Jansen 55053f0099
[LDR] Add debug logging when we encountered an exception in dll/tls callbacks.
CORE-14532
2018-08-13 13:24:12 +02:00
Mark Jansen dfff8ed0d8
[LDR] Protect calls from LdrpCallInitRoutine and LdrpCallTlsInitializers with SEH.
CORE-14532
2018-08-13 13:24:00 +02:00
Eric Kohl 956086d369 [NETAPI32] Add DFS RPC interface and some DFS stubs 2018-08-12 14:31:07 +02:00
Katayama Hirofumi MZ db13b422b3 [SHELL32] Fix a careless mistake of ShellExecCmdLine (#737)
CORE-14886
2018-08-10 13:25:50 +02:00
Eric Kohl fb5d5ecd64 [WLNOTIFY] Add sens service stubs 2018-08-07 22:56:33 +02:00
Hermès Bélusca-Maïto 40000a1716
[WINLOGON][MSGINA] Fix typo. 2018-08-06 17:37:38 +02:00
Eric Kohl 8f911f21b8 [SYSSETUP] SetupStartService: Wait until the service is running 2018-08-05 20:02:22 +02:00
Eric Kohl 5ebcc6cdc1 [ADVAPI32] Add parameter checks to LogonUserExW and initialize the token handle. 2018-08-05 16:16:53 +02:00
Eric Kohl b4040ea740 [NETAPI32] Implement I_NetServerSetServiceBits() 2018-08-05 15:57:03 +02:00
Eric Kohl 89f6e701d4 [NETAPI32] Add annotations and move NetUseGetInfo to a better location. 2018-08-05 15:36:48 +02:00
Katayama Hirofumi MZ bfcbda227f [SHELL32] Fix handling of multiple parameters in the 'Run' dialog (#665)
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.

- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.

CORE-14790
2018-08-05 13:39:17 +02:00
Mark Jansen 572976bb14
[ZIPFLDR] Add 'Extract All' to individual item context menu. 2018-08-05 11:54:56 +02:00
Mark Jansen 875e58d781
[ZIPFLDR] Add 'Extract All' menu item to the folder context menu. 2018-08-05 11:54:56 +02:00
Mark Jansen eb324b6a9c
[ZIPFLDR] Implement RouteTheCall, so that applications can 'launch' zip files 2018-08-05 11:54:56 +02:00