Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-25 01:39:30 +00:00
Code Issues Projects Releases Packages Wiki Activity
78787 commits 97 branches 276 tags 2.1 GiB
Commit graph

2976 commits

Author SHA1 Message Date
Joachim Henze
6d7ebc2048 [WDMAUD.DRV] Workaround multiple issues with AC97 driver from rapps 
By taking alternative code-paths in WdmAud and bypassing Sysaudio.

This relies on the patch 0.4.15-dev-765-g
b8e936a57b

It fixes the following bugs/regressions:
-CORE-13202 Unhandled exception from wdmaud.drv when recording sound in Scratch 1.4 leads to app-crash
-CORE-13488 A deadlock in "DiabloII" character selection screen and "The Lion King II"
-CORE-8726/CORE-9986/CORE-16564 AC97 driver is now working in the same session where driver was installed, no reboot-orgies needed anymore
-CORE-9981 almost 100% fixed, DosBox + Commander Keen6 properly plays music instead of garbled output,
           same improvement for ScummVM 2.0 with Monkey Island 2

The playback is not yet *entirely* perfect, still a few hiccups now and then, but
by orders of magnitude better than before.
 2020-09-14 17:12:16 +02:00
Hermès Bélusca-Maïto
a373198419
[SHELL32] Fix boot to shell, addendum to commit 14599b0a. 
shell32.ShellMessageBoxW redirects to shlwapi.ShellMessageBoxWrapW.
However the latter one (shlwapi) is exported by ordinal only.
Trying to use in shell32.spec file the following syntax:

  182 varargs ShellMessageBoxW() shlwapi.ShellMessageBoxWrapW

will therefore fail at runtime, because Windows/ReactOS will fail to
snap shlwapi.ShellMessageBoxWrapW.
Using instead an export by orginal:

  182 varargs ShellMessageBoxW() shlwapi.#388

actually fails as well, but at link time, by both MSVC' LINK and GNU's
dlltool.
This generates a .def file containing the line:

  ShellMessageBoxW=shlwapi.#388 @182

It is not clear why it fails, because according to:
https://docs.microsoft.com/en-us/cpp/build/reference/exports?view=vs-2019
and
https://devblogs.microsoft.com/oldnewthing/20121116-00/?p=6073
this should be possible.
However one encounters the same errors as those described at:
https://groups.google.com/forum/#!topic/microsoft.public.vc.language/AVnx-EnYdsY
and
https://www.xspdf.com/questions/22333.shtml
...

So instead we use another trick, that appears to be already in use in
the shell32.spec. Since the shlwapi functions are imported because we
link to it, this means that ShellMessageBoxWrapW() is already available
through this import. So we can specify it in the .spec file as is,
without a full name prefixed with "shlwapi." .
Therefore the associated shell32.ShellMessageBoxW function will instead
link to the small ShellMessageBoxWrapW() import stub that is generated
automatically.
 2020-09-14 05:54:13 +02:00
Kyle Katarn
aad9bb8e8a
[TRANSLATION][SHELL32] Localization of "System Folder" in My Computer types (#3168) 
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: JoseSanchezz <67137372+JoseSanchezz@users.noreply.github.com>
 2020-09-13 23:16:19 +02:00
Jose Carlos Jesus
b52189873d
[TRANSLATION][SCREENSAVERS][SYSSETUP] Add Portuguese (PT) translation (#3156) 2020-09-13 23:14:05 +02:00
Kyle Katarn
6d4b853b8a
[SHELL32] Improve Format dialog debug log (trivial) (#3176) 
- Logging of name for unknown filesystem.
- Fix some trace content as not only HDD could be affected.
 2020-09-13 23:05:04 +02:00
Hermès Bélusca-Maïto
14599b0a37
[SHELL32][SHLWAPI] Forward shell32.ShellMessageBoxW directly to shlwapi.ShellMessageBoxWrapW. (#3179) 
This makes ShellMessageBoxW use the correct implementation where the
text buffer size is dynamic, instead of having a too small hardcoded
size.

Fixes CORE-17271.
See also PR #3172 by Kyle Katarn, supplemented with some ideas from
Mark Jansen.

However we cannot straightforwardly implement ShellMessageBoxA around
ShellMessageBoxW, by converting some parameters from ANSI to UNICODE,
because there may be some variadic ANSI strings, associated with '%s'
printf-like formatters inside the format string, that would also need
to be converted; however there is no way for us to find these and perform
the conversion ourselves.
Therefore, we re-implement ShellMessageBoxA by doing a copy-paste ANSI
adaptation of the shlwapi.ShellMessageBoxWrapW function.

Note that, on Vista+ onwards, shlwapi implements both ShellMessageBoxA/W,
and shell32 directly forwards these exports to shlwapi, thus avoiding
these workarounds.

[PSDK] Explicily use WINAPIV for the variadic ShellMessageBoxA/W functions.

[INCLUDE/REACTOS] Add ShellMessageBoxWrapW in shlwapi_undoc.h .
 2020-09-13 22:44:58 +02:00
Adam Stachowicz
f3bc1b396a
[NTOBJSHEX] Update Polish (pl-PL) translation (#3175) 
Addendum to e358d1d. CORE-17268
 2020-09-13 18:22:11 +03:00
Timo Kreuzer
3c1f6631e6 [MSVCRT] Add vista exports 2020-09-13 15:37:29 +02:00
Timo Kreuzer
767a975cf6 [MSVCRT] -i386 -> -arch=i386 for consistency 2020-09-13 15:37:29 +02:00
Timo Kreuzer
dfaba507dc [MSVCRT] Fix some architecture specific exports 2020-09-13 15:37:29 +02:00
Katayama Hirofumi MZ
6e2ede3bd8 [NTOBJSHEX] Improve Japanese (ja-JP) translation 2020-09-13 17:16:12 +09:00
Katayama Hirofumi MZ
7ec021fdc4 [NTOBJSHEX] Add Japanese (ja-JP) translation 2020-09-13 16:39:29 +09:00
Michael Stamper
b8e936a57b
[WDMAUD] Fix race condition bug with USE_MMIXER_LIB defined (#3148) 
Remove misuse of multithreading and use NtDeviceIoContol with completion apc
callback instead (mirrors usage of WriteFileEx in WdmAudCommitWaveBufferByLegacy).

This fixes a crash caused by race condition. Code was simulating completion
callback using a thread, this resulted in single threaded code being executed
simultaneously by multiple threads.

CORE-17214
 2020-09-13 01:56:34 +03:00
Serge Gautherie
4aeb45ce0c
[KERNEL32] GetPriorityClass(): Return explicit 0, not FALSE (match return type) (#3170) 2020-09-12 21:38:06 +02:00
Stanislav Motylkov
25458c7775
[NTOBJSHEX] Update Russian (ru-RU) translation 
Addendum to e358d1d. CORE-17268
 2020-09-12 22:26:52 +03:00
Kyle Katarn
e358d1d219
[NTOBJSHEX] Localize the descriptions of the NT object and registry shell extension (#3167) 
CORE-17268
 2020-09-12 19:43:59 +02:00
Timo Kreuzer
61192390cf
[KERNEL32_VISTA][NTDLL_VISTA][RTL_VISTA] Move Vista Rtl functions from kernel32_vista and ntdll_vista to rtl_vista (#3149) 
* Move RtlRunOnce functions from kernel32_vista to rtl_vista and export them from ntdll_vista
* Move condvar.c and srw.c from ntdll_vista to rtl_vista
* Move ntdll_vista build script to a subfolder of ntdll

The RtlRunOnce functions are taken from wine, completely unmodified.
The code that was in kernel32_vista had change that used a global keyed_event handle, but was never initialized, so we were still passing NULL thus using the global ExpCritSecOutOfMemoryEvent.
 2020-09-12 15:04:02 +02:00
Katayama Hirofumi MZ
183e1eb71b
[FONTEXT] Initial implementation of CFontExt::DoGetFontTitle (#3127) 
This PR is a preparation of fonts folder implementation. CORE-12861
 2020-09-12 09:40:48 +09:00
Joachim Henze
35dbdaaa0e [SHELL32] Fix regression CORE-12364 
The sorting in explorer broke by
SVN r73128 == git
24fcf531e7

Thanks to Doug Lyons for providing this patch.
I do intend to port it back into 0.4.14RC.
 2020-09-11 02:24:42 +02:00
Kyle Katarn
7d44c1cb07
[SHELL32] Show "size on disk" in file/folder properties (#3107) 
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
 2020-09-10 20:48:40 +02:00
Mark Jansen
f2ffd21232
[SHLWAPI] Fix SHLoadIndirectString executing code when loading a string 2020-09-10 19:45:22 +02:00
Oleg Dubinskiy
07f98eb10a [DBGENG] Import dbgeng.dll from Wine Staging 4.18 
CORE-17153.
 2020-09-10 18:19:28 +02:00
Katayama Hirofumi MZ
c8e3ef7894
[SHELLFIND] Split encoding detection code (#3147) 
Split encoding detection code to improve code quality. This is follow-up of #3134 (7376cde). CORE-17250
 2020-09-10 19:03:20 +09:00
Timo Kreuzer
92f4746845 [NTDLL] Add Vista exports 2020-09-09 19:33:29 +02:00
Timo Kreuzer
aaa7dda945 [NTDLL] Mark 2k3 only functions and improve some arch specific definitions 2020-09-09 19:33:29 +02:00
Omer I.S
bca076269f
[INPUT.CPL] Update Hebrew translation (#3121) 2020-09-08 23:01:56 +02:00
Kyle Katarn
d7fd62d478
[BOOT][DIRECTX][SHELL32] Unneeded semicolons (trivial) (#3133) 
Except in 3rd-party code.
CORE-13162
 2020-09-08 21:57:13 +02:00
Katayama Hirofumi MZ
7376cdebb6
[SHELLFIND] Encoding-aware file search (#3134) 
Consider UTF-8/UTF-16/UTF-16BE encodings in file search. Recognize UTF-8/UTF-16/UTF-16BE BOM and NULs at the beginning of the file contents. Optimize for speed.
CORE-17250
 2020-09-07 22:30:47 +09:00
Katayama Hirofumi MZ
7ea54062b0 [BROWSEUI] Improve Japanese translation 2020-09-07 17:11:31 +09:00
Katayama Hirofumi MZ
2dd4f8714d
[SHELLFIND] Fix directory search upon non-empty word/phrase query (#3130) 
If the search phrase was not empty, it must not match the directory. CORE-17244
 2020-09-07 15:48:25 +09:00
Katayama Hirofumi MZ
8fa3c147b6
[BROWSEUI][SHELL32] Implement MoveTo/CopyTo buttons (#3128) 
Implement the actions of the MoveTo/CopyTo/Delete buttons.
CORE-11132
 2020-09-07 09:42:43 +09:00
Katayama Hirofumi MZ
828cf19a29
[BROWSEUI] Set DT_VCENTER to Explorer bars (#3135) 
Make the captions of the explorer bars vertically centered.
 2020-09-07 09:33:21 +09:00
Katayama Hirofumi MZ
88cdb9696b [SHELL32] Make 'hwndServer == NULL' spams quiet 2020-09-06 22:48:29 +09:00
Mark Jansen
246e6a0de9
[BROWSEUI] Stop the address edit box trying to parse a null pidl 2020-09-06 14:32:59 +02:00
Mark Jansen
53badbd2f7
[ZIPFLDR] Fix PathCompactPathW writing out of bounds 
CORE-17245
 2020-09-06 14:28:56 +02:00
Kyle Katarn
038daa6367
[SHELL32][PAINT][DRIVERS][SHELLEXT] French translation update (#3092) 
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
 2020-09-03 15:16:44 +02:00
Omer Itzic S
49972f51c6
[INETCPL] Update Hebrew translation (#3122) 2020-09-03 15:00:08 +03:00
Katayama Hirofumi MZ
7c134e4d14
[SHELL32] Big fix for change notification (#3048) 
- Reduced the failures of SHChangeNotify testcase.
- Simplified change notification mechanism.
- Realized PIDL aliasing.
CORE-13950
 2020-09-03 13:36:31 +09:00
Joachim Henze
1cc84c6db7 [RPCRT4] Check hBinding != 0 CORE-16936 
To prevent logspam that was introduced when syncing
to Wine Staging 4.18 in 0.4.14-dev-422-g
6feb8748d3

Thanks for anyone helping: Doug Lyons,
Fabian Maurer (Wine), Zebediah Figura (Wine)

I intend to port it back into 0.4.14RC so that
none of our releases will be affected.
 2020-09-01 22:10:18 +02:00
Serge Gautherie
f8b0c7c6dd [MESA] Fix 'ATTRIB_h' typo 
clang-cl 10:
'.../attrib.h(32,9): warning: 'ATTRIB_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]'

Addendum to 5f2bebf.
CORE-7499 CORE-14306
 2020-08-30 02:00:57 +03:00
Joachim Henze
7c909cbc7c [COMCTL32] Addendum to last commit 
Sorry, something went terribly wrong with the CORE-ID
in my head 2 times, one time in the commit comment
and one time in the code!

Addendum to 0.4.15-dev-663-g
cd7db5df89
 2020-08-28 01:02:00 +02:00
Joachim Henze
cd7db5df89 [COMCTL32] Workaround regression with toolbar in 7zip CORE-16996 
The regression was introduced by SVN r68553
3b13364f05

Many thanks to the author Doug Lyons for excellent
cooperation once more. Always a pleasure.
 2020-08-28 00:53:18 +02:00
Stanislav Motylkov
22fb1e947d
[SYSDM] Add missing RegCloseKey function calls 
Addendum to 06198c5.
 2020-08-26 23:22:57 +03:00
Stanislav Motylkov
06198c51ac
[SYSDM] Display system identifier when SMBIOS is not available 
Actual for NEC PC-98 and Original Xbox ports.
 2020-08-26 23:16:08 +03:00
Kyle Katarn
ba006b3d49
[OPENGL32] Remove Err Log Spam from wglMakeCurrent in nominal cases (#3096) 
CORE-17224
 2020-08-26 19:56:52 +03:00
Serge Gautherie
93f017fcc6
[SHELL32] spec: Update SHRunControlPanel() and SHValidateUNC() parameter types (#3097) 
Cherry-pick (missed part of?)
f6be79684f
 2020-08-26 17:34:01 +03:00
Vladimir Barinov
2edcb58e65
[MSGINA][SYSSETUP] Implement Friendly UI shutdown dialog (#2762) 
Can be activated by installing ReactOS as a Workstation. CORE-12805

References:
- https://www.remkoweijnen.nl/blog/2009/01/16/windows-xp-x64-terminal-server-patch-part-2-optional/
- https://www.remkoweijnen.nl/blog/2011/01/30/using-fast-user-switching-on-domain-xp-computers/

Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
 2020-08-25 22:52:17 +03:00
Kyle Katarn
aab8cd81ff
[SHELL32] Demote noisy ERR() to TRACE() in CRecyclerDropTarget (#3093) 2020-08-25 19:12:17 +03:00
Aobi Chan CL
018d4d39a3
[TRANSLATION] Chinese Traditional translation for "Problem with Shortcut" dialog and improvements (#3079) 
- Translation for: setup-reactos, welcome, explorer, appwiz, hdwwiz, intl, mmsys, netid, shell32, syssetup, tapiui.
- Update zh-TW.rc of shell32 (#3075)
- Just found more Simplified Chinese characters, fixed them. (装 > 裝)
 2020-08-23 14:28:55 +02:00
Joachim Henze
f363c27ab4 [SHELL32] Demote 2 noisy goodpath loggings to TRACE CORE-17216 
Those 2 did spam heavily when browsing folders with
many .zip files within. Mark Jansen confirmed that
this is good-path-logging and was just forgotten
to be disabled earlier.
 2020-08-23 00:35:02 +02:00
Katayama Hirofumi MZ
ed445dd775
[SHELL32] Enable CopyTo/MoveTo textbox functionality (#3075) 
- The user can enter the full path of a directory in "Copy To Folder" and "Move To Folder" features.
- Fix two bugs in SHBrowseForFolder function. One is disability of text box to enter a full path. Another one is disability to choose the root item in BFFM_SETSELECTION.
- Add ES_AUTOHSCROLL style to text box. This enables the user to enter a long text.
CORE-11132
 2020-08-20 11:35:14 +09:00
Andreas Hausmann
a54004893f
[BROWSEUI] Few corrections for German (de-DE) translation (#3067) 
Corrected some mistakes
 2020-08-19 18:18:05 +03:00
Stanislav Motylkov
78607860b7
[SHELL32] Addendum to 4156fd5 2020-08-18 16:50:59 +03:00
Stanislav Motylkov
4156fd5182
[SHELL32] Improve Russian translation 
Addendum to 46ff964. CORE-11132
 2020-08-18 16:26:52 +03:00
Aobi Chan CL
53bb510352
[TRANSLATION] Improve Chinese Traditional (zh-TW) translation (#3065) 2020-08-18 14:26:04 +03:00
Piotr Hetnarowicz
78e3407c1d
[TRANSLATION][BROWSEUI] Polish "MoveTo" description fix (#3074) 2020-08-18 12:58:48 +02:00
Piotr Hetnarowicz
7d373689fe
[TRANSLATION][SHELL32] Update Polish translation of the "MoveToFolder" dialog (#3072) 2020-08-18 12:53:50 +02:00
Katayama Hirofumi MZ
fde7a3b764 [SHELL32] Update Japanese translation 2020-08-18 09:27:10 +09:00
Katayama Hirofumi MZ
46ff964e22
[SHELL32] Implement Move To Folder (#3056) 
- Add context menu item "Mo&ve to folder..." and implement the action.
- Implement the "Mo&ve to folder..." menu item of "Edit" menu of Explorer.
CORE-11132
 2020-08-18 05:30:54 +09:00
Mark Jansen
679c95597c
[SHELL32] Fix sorting on size for big files 
CORE-17205
 2020-08-17 18:17:24 +02:00
Kyle Katarn
61d89dec8e
[SHELL32] French translation for "Problem with Shortcut" dialog (#3047) 2020-08-17 17:41:59 +03:00
Piotr Hetnarowicz
569a3d63f5
[TRANSLATION][SHELL32] Update Polish translation ("copy to folder" dialog) (#3064) 2020-08-17 16:41:31 +02:00
Tibor Lajos Füzi
2490b675fb
[TRANSLATION] Hungarian translation update for aclui, avifil32, browseui, comdlg32, crypt32, cryptdlg, shell32, userenv (#2978) 2020-08-17 16:39:42 +02:00
Jose Carlos Jesus
4180592654
[TRANSLATION] Update Portuguese (Portugal) translation for CPL files (#3062) 2020-08-17 17:28:09 +03:00
Stanislav Motylkov
1197c90592
[ZIPFLDR] Fix several dialog layout problems 
Addendum to a1108f6. CORE-17209

Co-authored-by: Doug Lyons <douglyons@douglyons.com>
 2020-08-17 16:12:10 +03:00
Stanislav Motylkov
b65ff2084f
[SYSDM] Localize hardcoded megabyte units 
CORE-12485 CORE-16915
 2020-08-17 14:18:09 +03:00
Stanislav Motylkov
94ca261449
[SYSDM] Fix virtual memory dialog layouts 2020-08-17 04:26:31 +03:00
Stanislav Motylkov
79767e1bc6
[SYSDM] Add placeholders for simpler visual editing 2020-08-17 03:38:27 +03:00
Stanislav Motylkov
b5368185da
[SYSDM] Better formatting of user profile size 2020-08-17 03:18:01 +03:00
Stanislav Motylkov
1601afd0a6
[SYSDM] Whitespace fixes only 2020-08-17 03:16:07 +03:00
Stanislav Motylkov
35de9f3925
[SHLWAPI] Add French translation for size units 
Reference: https://fr.wikipedia.org/wiki/Octet

CORE-12485 CORE-14011
 2020-08-17 01:32:37 +03:00
Katayama Hirofumi MZ
8f907ea83a
[SHLWAPI] Localize StrFormatByteSizeA/W (#3051) 
CORE-14011
 2020-08-17 06:40:39 +09:00
Brock Mammen
f0d6d9896d
[SHELLFIND] Fix column sorting (#2814) 
CORE-16825
 2020-08-16 19:02:42 +03:00
Jose Carlos Jesus
887764e607
[COMCTL32] Fix issue on showing current mouse pointer (#2829) 
GetIconInfo() fill info.hbmColor with NULL HBITMAP handle on black/white bitmaps.

CORE-17062
 2020-08-16 18:42:12 +03:00
Stanislav Motylkov
685084b63c
[UXTHEME] Properly show disabled close button 
CORE-17203
 2020-08-16 17:34:38 +03:00
Stanislav Motylkov
9900089fa6
[SHELL32] Fix Russian translation 
Addendum to 5187ec8 and 824a52a. CORE-10972 CORE-12906
 2020-08-16 16:06:52 +03:00
Stanislav Motylkov
a95c7356ce
[SHELL32] Russian translation for Copy To Folder 
Addendum to 85fdcdf. CORE-11132
 2020-08-16 15:32:26 +03:00
Katayama Hirofumi MZ
1d1bb53321
[SHELL32] Fix regression #2703 CORE-17041 (trial) (#3046) 
CORE-17041
 2020-08-16 11:16:44 +09:00
Joachim Henze
2d4c27c96e [SHELL32] de-DE translation for CORE-11132 
Addendum to 0.4.15-dev-524-g
85fdcdf2cc
to keep the german localization up to date
for the new Copy-To-Folder-Dlg.
 2020-08-16 02:15:06 +02:00
Katayama Hirofumi MZ
85fdcdf2cc
[SHELL32] Implement Copy To Folder (retrial) (#3044) 
- Add context menu item "Copy to &folder..." and implement the action.
- Implement the "Copy to &folder..." menu item of "Edit" menu of Explorer.
CORE-11132
 2020-08-16 08:04:07 +09:00
Thomas Faber
12186bec12
[TIMEDATE] Fix a broken function pointer cast. 2020-08-15 22:37:42 +02:00
Stanislav Motylkov
037e84ec7f
[SHELL32] Russian translation for "Problem with Shortcut" dialog 
Addendum to a3ec01c. CORE-16816
 2020-08-15 17:26:15 +03:00
Joachim Henze
e95643c7c9 [SHELLBTRFS] Prevent the compression dropbox from accepting free text CORE-16971 
Initially proposed to ros via https://github.com/reactos/reactos/pull/2677
and already integrated upstream Apr 28, 2020 by
aba729c8f5
 2020-08-15 13:43:00 +02:00
Piotr Hetnarowicz
9170432c8f
[SHELL32] Polish translation for "Problem with Shortcut" dialog (#3043) 
pl-pl Polish translation update for new dialog with SHORTCUT
 2020-08-15 02:07:32 +09:00
Katayama Hirofumi MZ
90456e54a4
[APPWIZ] Don't hung up in Gecko download cancellation #3049 
Do not call EndDialog outside the dialog procedure.
CORE-14538
 2020-08-14 23:40:10 +09:00
James Tabor
96a357b595 [ComDlg32] Fix Driver String 
Use a fixed string for driver name, same as Windows.
 2020-08-13 21:31:04 -05:00
Katayama Hirofumi MZ
a3ec01cc28
[SHELL32] Add IDD_LINK_PROBLEM and IDS_LINK_INVALID (#3037) 
A resource dialog and a resource string for shortcut problem. CORE-16816
 2020-08-12 14:16:25 +09:00
Katayama Hirofumi MZ
526c23bde6
[IMM32] Improve imm32.spec (#3036) 
CORE-11700
 2020-08-12 06:04:28 +09:00
Katayama Hirofumi MZ
4b038ec8b7
[IMM32][NTUSER] Add ImmGetImeInfoEx (#3035) 
- Add the definition of imm32!ImmGetImeInfoEx function.
- Add IMEINFOEXCLASS and IS_IME_HKL into "ntuser.h".
- Modify NtUserGetImeInfoEx function prototype.
CORE-11700
 2020-08-12 06:03:29 +09:00
Katayama Hirofumi MZ
ee231d00b9
[SHELL32] Improve callbacking of CDefView (#3031) 
- Delete DefMessageSFVCB method.
- Add some callbacking.
 2020-08-11 16:00:16 +09:00
Katayama Hirofumi MZ
1f31905ecd
[SHELL32] Optimize change notification (#3030) 
- Keep the directory lists only.
- Don't remember file sizes and normal file paths.
CORE-13950
 2020-08-10 13:34:48 +09:00
Oleg Dubinskiy
8d682f9b05
[IMM32] Stub ImmRegisterClient CORE-16479 (#3009) 
Add a stub for ImmRegisterClient function in imm32.dll. CORE-16479
 2020-08-09 22:49:00 +09:00
Katayama Hirofumi MZ
2705abfb07
[IMM32] Add ImmShowSoftKeyboard and ImmDestroySoftKeyboard (#3027) 
CORE-11700
 2020-08-09 22:42:17 +09:00
Katayama Hirofumi MZ
ec9d277d59
[IMM32][NTUSER] Implement ImmGetHotKey (#3025) 
CORE-11700
- Implement imm32!ImmGetHotKey function.
- Modify NtUserGetImeHotKey function.
- Add LPHKL typedef into <imm.h> header.
 2020-08-09 22:41:11 +09:00
Stanislav Motylkov
357db6d191
[SYSSETUP] Fix Russian translation (#3017) 
Addendum to 75a0787.
 2020-08-08 14:32:10 +03:00
Oleg Dubinskiy
a1108f6155
[ZIPFLDR] Add some bitmap resources CORE-17092 (#2875) 
Add some bitmap images to our zipfldr shell extenson. MS version of this has them, but our one currently hasn't. And I think without bitmaps the wizard dialogs look a bit incompleted.
I made them similar to MS bitmaps. They have exactly the same size (height x width), but looks differently, in ReactOS Tango style. CORE-17092
 2020-08-08 14:13:54 +09:00
Katayama Hirofumi MZ
f7865b8bfa
[IMM32] Add ImmSetActiveContext stub (#3026) 
CORE-11700
Add imm32!ImmSetActiveContext and ImmSetActiveContextConsoleIME function stubs.
 2020-08-08 09:46:13 +09:00
Vladimir Barinov
75a078709a
[SYSSETUP] Fix Russian translation (#3017) 2020-08-04 16:25:33 +03:00
Serge Gautherie
98bbe8358c
[REACTOS] Fix GetTokenInformation() usage (#2997) 
The first call to GetTokenInformation is used to determine the size of a TokenInformation buffer.
It should fail and return ERROR_INSUFFICIENT_BUFFER
 2020-07-21 15:39:11 +03:00
Serge Gautherie
0f8306b37f
[CRYPT32] CRYPT_ExportKeyTrans(): Check 'CRYPT_ConstructBitBlob()' return value (#2983) 
Import 3e8b07309c
CORE-8156

Co-authored-by: Victor Martinez Calvo <vmartinez@reactos.org>
 2020-07-18 15:40:05 +02:00
Serge Gautherie
b509658280
[CMAKE] Remove obsolete 'CMAKE_CXX_COMPILER_VERSION' checks (#2981) 
Following upgrade to RosBE 2.2.0 support and GCC 8.4.
 2020-07-18 15:37:29 +02:00
Serge Gautherie
d6c4411207 [MSGINA] gui: Improve 'DlgData_Destroy()' 
Addendum to 623dd26cce.
 2020-07-11 01:44:26 +02:00
Serge Gautherie
db2aa4c8ca [APISETS] api-ms-win-core-localization-l1-2-1: Is NT6.3+ actually 
CORE-17095
 2020-07-11 01:16:38 +02:00
Serge Gautherie
0de16bc3ba [APISETS] api-ms-win-core-localization-l1-2-0: Is NT6.2+ actually 
CORE-17095
 2020-07-11 01:16:38 +02:00
Serge Gautherie
871f96b66e [APISETS] api-ms-win-core-localization-l1-1-0: Is NT6.1+ actually 
CORE-17095
 2020-07-11 01:16:38 +02:00
Thomas Faber
292f67af5b
[MBEDTLS] Update to version 2.7.16. CORE-17155 2020-07-04 21:53:46 +02:00
Thomas Faber
e57126f5e5
[MBEDTLS] Switch license headers to the dual-licensed version. CORE-17155 
This is the default going forward, and separating it out into its own
commit removes the noise from the following sync commit.
 2020-07-04 21:53:42 +02:00
Oleg Dubinskiy
622f187c04
[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub 
See https://www.geoffchappell.com/studies/windows/win32/services/svchost/dll/svchostpushserviceglobals.htm.
 2020-06-27 14:55:28 +02:00
Serge Gautherie
2dfcb500e2
[MSI] Remove obsolete '__ASM_DEFINE_FUNC()' 
MSVC build reports:
{{
dll\win32\msi\msvchelper.h(3): warning C4005: '__ASM_DEFINE_FUNC': macro redefinition
sdk\include\reactos\wine/asm.h(60): note: see previous definition of '__ASM_DEFINE_FUNC'
dll\win32\msi\custom.c(547): warning C4003: not enough actual parameters for macro '__ASM_DEFINE_FUNC'
}}

Addendum to 476c99b and 9efafd6.
 2020-06-27 14:48:00 +02:00
Serge Gautherie
82272f03e3
[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()' 
Addendum to 0f5d91b.
CORE-16441
 2020-06-27 14:48:00 +02:00
Serge Gautherie
bf88ce89c8
[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type 
MSVC 'Release' build reports:
'dll\apisets\api-ms-win-crt-utility-l1-1-0_stubs.c(41): warning C4391: 'int llabs()': incorrect return type for intrinsic function, expected '__int64''

Addendum to 3f15a0d.
 2020-06-27 14:46:15 +02:00
Serge Gautherie
4213c70e2e
[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive. 
* _atexit_cleanup is no longer used
* Fix cppcheck 'pointerSize' warning
 2020-06-27 14:35:32 +02:00
Jared Smudde
9e20be0fbf [SYSDM] Set the proper icon in title bar 2020-06-27 10:22:07 +02:00
Thomas Brogan
88300ec3b3
[WINMM] Improve implementation of timeGetTime, timeBeginPeriod, timeEndPeriod (#2933) 
Use QueryPerformanceCounter if a high-resolution timer is requested (<= 5ms) instead of the more inaccurate GetTickCount.
 2020-06-20 13:28:25 +03:00
Hervé Poussineau
ea4af587a9 [SETUPAPI] Add function names in traces 2020-06-20 08:16:07 +02:00
Oleg Dubinskiy
1761bedb82 [VSSAPI] Add missing wrapper for ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z and _VSSAPI_CreateVssBackupComponents@4 in msvc.s, to fix MSVC compilation 2020-06-07 19:45:05 +02:00
Oleg Dubinskiy
23a1f8d335 [VSSAPI] Import Wine commits "Stub CreateVssBackupComponentsInternal + ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z" 
ce9b5a7e17
767c94bc5c
CORE-9511.
 2020-06-07 19:45:05 +02:00
Oleg Dubinskiy
31e00140d3
[RPCRT4] Export NdrCreateServerInterfaceFromStub as stub 
Required by MS ole32.dll CORE-15395, CORE-17004.
 2020-06-07 14:08:58 +02:00
Thomas Faber
185591368d [SHELLBARS] Add missing psdk dependency. 2020-06-06 23:02:35 +02:00
Thomas Faber
789c88c185 [MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available. 2020-06-06 23:02:35 +02:00
Amine Khaldi
139a3d6661
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
Serge Gautherie
abe1dd31c4
[SHLWAPI] lang/*.rc : Enforce aa-BB filenames (#2816) 2020-06-06 18:25:43 +02:00
Serge Gautherie
8140203940
[KERNEL32] FatalAppExitW: Add an 'UNREFERENCED_LOCAL_VARIABLE(Status)' (#2883) 
Addendum to 21d2accad3 (r71793).
 2020-06-04 23:35:54 +03:00
Serge Gautherie
450425028c
[IPHLPAPI] getNumInterfacesInt(): Remove 'if()' redundant condition (#2884) 
No impact.

Detected by Cppcheck: redundantCondition.
Addendum to 1fe3a2d6c3 (r9788).
 2020-06-04 23:26:28 +03:00
Katayama Hirofumi MZ
7c9a8c0b89
[SHELL32] Improve readability of filesystem notification (#2737) 
Improve human readability of filesystem change notification.
- Rename the identifiers for human readabilities.
- Split the code into CFilePathList and CDirectoryWatcher classes.
- Encapsulation of code.
CORE-13950
 2020-06-02 18:42:07 +09:00
Jose Carlos Jesus
3dad100ea4
[TRANSLATION] Add/update Portuguese translation (#2850) 
- Add translation for: iernonce, modmui.
- Update translation for: jscript, msports, shell32.
 2020-06-01 20:48:58 +02:00
Jose Carlos Jesus
8189133865
[TRANSLATION] Add/Update Portuguese translation for some shell extensions (#2845) 
- Add translation for: devcpux, netplwiz, ntobjshex, stobject, zipfldr.
- Update translation for: sendmail.
 2020-06-01 20:31:06 +02:00
Serge Gautherie
7094297b7a
[APISETS] Fix some functions that are NT10(v1607)+ (#2738) 
- *_onexit_*() are NT10(v1607)+
- *_seh_filter_*() are NT10(v1607)+ actually

CORE-16700
 2020-06-01 20:04:32 +03:00
Serge Gautherie
64fea1dbd0
[MSGINA] gui: Improve DlgData_LoadBitmaps() (#2520) 
And let bar timer depend on the bar image only.

Addendum to 623dd26cce.
 2020-06-01 12:26:53 +03:00
Serge Gautherie
6baa151888
[APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805) 
* api-ms-win-downlevel-shell32-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-shcore-obsolete-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-downlevel-shlwapi-l2-1-0.dll is NT10+ and win32 only

CORE-8880
 2020-06-01 12:20:13 +03:00
Serge Gautherie
703c56beb3
[REACTOS] RegQueryValueExW() wants bytes, not chars (#2876) 
Cherry-pick:
a359e02666
0662da18b8
e4e5eda3d9

CORE-9665

Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
 2020-06-01 12:06:49 +03:00
Timo Kreuzer
cb99761bc1 [NTDLL] Use lowest OS version GUID in the application manifest, instead of highest 2020-05-31 13:14:01 +02:00
Timo Kreuzer
0ed8b916e4 [MSTASK] Add C stubs and comment out decorated exports 
MSVC's LINK is not able to export both the undecorated and decorated symbol from the same dll. This results in an incoherence between the spec file entries and the actual exports, breaking the dll export versioning.
 2020-05-31 12:26:37 +02:00
Katayama Hirofumi MZ
99b52df014
[SHELL32][INCLUDE] Improve CheckEscapesA/W (#2795) 
Fix and improve shell32!CheckEscapesA/W functions.
Add a testcase for shell32!CheckEscapesA/W to shell32_apitest.
 2020-05-28 10:58:26 +09:00
Serge Gautherie
11345aedd8
[FORMATTING] [CMAKE] Remove space in 'if (' (#2847) 2020-05-26 20:24:02 +02:00
Serge Gautherie
03d5ff7f68
[MMSYS] OnHScroll(): Fix wrong '&&' operator (#2855) 
CORE-17079
 2020-05-25 19:57:52 +02:00
Timo Kreuzer
dd7fb63cd1 [ADVAPI32] Convert ordinals to @ in spec file 2020-05-24 08:22:24 +02:00
Tibor Lajos Füzi
1017c73a9c
[TRANSLATION] Hungarian translation update for shell32 (#2828) 2020-05-23 19:20:16 +02:00
Serge Gautherie
99d0a348aa
[LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839) 
Reported by contributor 'qarmin'.
CORE-17074
 2020-05-23 19:07:04 +02:00
Timo Kreuzer
f323778b0b [NTDLL] Rename ExportEntry to ExportDirectory to better represent what it is 2020-05-23 17:30:52 +02:00
Piotr Hetnarowicz
35b5876a95
[APPWIZ] Polish translation update (#2790) 
FIXED: dialogs, button, description
 2020-05-23 15:43:56 +02:00
Eric Kohl
cf62e22974 [USERENV] Implement DeleteProfileW() 2020-05-23 12:37:16 +02:00
Eric Kohl
5bc6f79399 [SAMSRV] SampInitializeSAM: Fix indentation and add comments 2020-05-23 12:30:54 +02:00
Kyle Katarn
57401cb66d
[DEVMGR] Use the ShellAboutW API routine to display the about dialog and French translation update (#2807) 
As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
Similar to #2743 by @HBelusca
 2020-05-22 22:53:17 +09:00
Kyle Katarn
4ce7081766
[SYSSETUP][MAIN] Fix Mouse Properties UI and improve French translation (#2810) 
- PS2 Mouse Advanced Properties : Static control (frame) added
- PS2 Mouse Advanced Properties : French translation added and control layout adapted accordingly
- Mouse CPL > Wheel > Sroll line text box ES_NUMBER style added
- ReactOS Setup : French translation added
 2020-05-22 22:49:27 +09:00
Serge Gautherie
ef6711c904
[SYSSETUP] DoWriteProductOption(): Fix 'pData' copypastas (#2826) 
Addendum to 612729b092.

CORE-17069
 2020-05-22 01:52:50 +09:00
Jose Carlos Jesus
c3ab469e44
[ACCESS.CPL] Improvements to Portuguese translation (#2800) 2020-05-21 15:36:33 +02:00
Serge Gautherie
924f19f6dc
[REACTOS] Remove executable bits on source files (#2822) 2020-05-20 23:09:44 +02:00
Kyle Katarn
357b3fa858
[MAIN.CPL] Fix of Keyboard settings French translation (#2812) 2020-05-20 15:47:24 +02:00
Kyle Katarn
b8f7d4c56d
[TIMEDATE] French translation (#2811) 2020-05-20 15:45:47 +02:00
Mark Jansen
83a9f71690
[SHELL32] Allow creation of an empty CFileSysEnum 
CORE-16908
 2020-05-19 20:35:52 +02:00
Joachim Henze
4cbb21761c [SYSSETUP] Fix broken build on RosBE2.1.6 CORE-17028 
The build broke due to a typo introduced by
0.4.15-dev-275-g
612729b092

../dll/win32/syssetup/wizard.c: In function 'ProductPageDlgProc':
../dll/win32/syssetup/wizard.c:527:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-
after-statement]
cc1.exe: all warnings being treated as errors
 2020-05-19 20:32:21 +02:00
Kyle Katarn
fb2a9bb60d
[JOY] Fix missing UI elements and French translation (#2808) 
Missing GUI elements added.
Improve French translation.
 2020-05-19 19:09:05 +09:00
Katayama Hirofumi MZ
612729b092
[SYSSETUP][BOOTDATA] Make Server default again and write Service Pack (#2749) 
- Make "ReactOS Server" the default product option again instead of "ReactOS Workstation".
- Write "Service Pack" info onto registry.
- Add ProductOption option to bootcd unattend.inf.
- Delete IDC_PRODUCT_SUITE and IDC_PRODUCT_TYPE controls.
CORE-17028
 2020-05-19 15:41:26 +09:00
Jose Carlos Jesus
d5784d6345
[DESK][TIMEDATE] Update Portuguese translation (#2801) 2020-05-17 23:53:54 +02:00
Eric Kohl
6efb3cbe03 [SETUPAPI] Implement CM_Get_Next_Res_Des_Ex() partially (WIP) 2020-05-17 20:04:26 +02:00
Julen Urizar Compains
546862babc
[TRANSLATION] Update Spanish, and add Basque translation (#2667) 
Add/update translation for:
charmap_new, logoff, mspaint, notepad, usetup, welcome,
hotplug.cpl, sysdm.cpl, aclui.dll, comctl32.dll, comdlg32.dll,
hhctrl.ocx, kernel32.dll, msi.dll, oledlg.dll, shell32.dll,
tapiui.dll, themeui.dll, wininet.dll, winmm.dll, wldap32.dll,
winsrv.dll.
 2020-05-17 18:46:36 +02:00
Jose Carlos Jesus
cd0c06bef3
[ACPPAGE] Add Portuguese translation (#2802) 2020-05-17 18:12:11 +02:00
Mark Jansen
332889b8d7
[COMDLG32] Differentiate between real and virtual folders, 
do not allow traversal inside virtual folders when selecting a file
CORE-16908
 2020-05-17 17:09:05 +02:00
Mark Jansen
f379a29606
[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders 
CORE-16908
 2020-05-17 17:09:04 +02:00
Mark Jansen
b1003ae909
[SHELL32] Update CFileSysEnum to be maintaineable 
CORE-16908
 2020-05-17 17:09:04 +02:00
Mark Jansen
ac215455bb
[SHLWAPI] Fix SHRegGetCLSIDKeyW 2020-05-17 17:09:04 +02:00
Jose Carlos Jesus
2bd6bfdd90
[COMCTL32] Fix recalculation of property-sheet dialog position (#1818) 
During initialization of property sheet dialogs, their overall size can change (when adding property sheets) after the dialog has been created and pre-positioned by win32k.
Therefore their position needs to be recomputed so that they try to fit the best on screen.

CORE-9008, CORE-9602
 2020-05-15 18:12:02 +02:00
Katayama Hirofumi MZ
62e59652a0
[SHELL32] Don't hardcode C: drive again (#2777) 
- Avoid buffer overrun.
- Don't hardcode C: drive.
CORE-13235
 2020-05-15 16:36:13 +09:00
Katayama Hirofumi MZ
6c3775f77c
[SHELL32] Implement SheShortenPathA (#2785) 
Implement shell32!SheShortenPathA function.
 2020-05-14 22:52:22 +09:00
Katayama Hirofumi MZ
b7a97a2af2
[SHELL32] Implement MakeShellURLFromPathA (#2784) 
Implement shell32!MakeShellURLFromPathA function.
 2020-05-14 22:51:53 +09:00
Ricardo Hanke
0c5f367172
[OPENGLCFG] Empty list boxes if registry key is missing (#2750) 
If the registry key that holds the names of installed opengl drivers is missing, all list boxes in openglcfg are empty. This is a minor code rearrangement to fix this behavior.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
 2020-05-14 14:47:48 +02:00
Piotr Hetnarowicz
64ba6e64c8
[SHELL32] PL-pl Dialogs fix (#2788) 
- Fixed invisible text in DIALOGS.
 2020-05-14 14:33:32 +02:00
Kyle Katarn
bd79d1ec23
[SYSDM][USRMGR] French translation update (#2765) 
CORE-16596
 2020-05-14 15:24:13 +03:00
Erdem Ersoy
072be890f3
[TRANSLATIONS] Turkish translation updates (#2724) 
* [TRANSLATIONS] Translate desk.cpl to Turkish

* Update file header

* [TRANSLATIONS]

* Update translations of syssteup
* Update translations of userenv
* Update translations of shell32 (partial)

* [TRANSLATION] Fix a translation

* [TRANSLATION] Translate Turkish strings to Turkish

for hivedef.inf

* Update Turkish translations of shell32 partially

* Update shell32 Turkish translations (partially)

* Update shell32 Turkish translations (partially)

* Fix translation for desk.cpl
 2020-05-14 14:23:05 +02:00
Oleg Dubinskiy
90aff2947b
[REGAPI] Import regapi.dll from Wine Staging 5.7 CORE-16458 (#2723) 
- Comment some other missing exports Windows regapi.dll has them, but Wine's one doesn't.

Required by MS winlogon with Win32SS replaced. I double-rechecked: now it doesn't fail due to missing regapi.dll in system32 or separate missing functions in this dll, exactly the same as with MS regapi. In pair with my profmap.dll (which was merged recently), now it fails due to InitializeUserProfile() stub in our userenv.dll (if to replace msgina too).
Also I compared the exports of MS regapi.dll and Wine's one. Win2k3 version has all exports that Wine version has and some others (which looks like were dropped in NT6). But those exports which already exist, are enough to allow MS winlogon no longer fail.

CORE-16458
 2020-05-14 14:21:16 +02:00
Katayama Hirofumi MZ
d3a550a6a9
[SHLWAPI] Implement SHIsLowMemoryMachine (#2783) 
Implement shlwapi!SHIsLowMemoryMachine function.
 2020-05-14 09:47:21 +09:00
Katayama Hirofumi MZ
b70232d416 [SHELL32] Half-implement SHWinHelp 2020-05-14 09:38:38 +09:00
Yaroslav Kibysh
5f319bafc8
[SYSSETUP] Update Ukrainian translation (#2776) 2020-05-13 15:11:48 +03:00
James Tabor
98bfe2fc89 [PrintUI|NTPrint] Printing Application Utility Support 
PrintUI : Move to printing base directory.
NTPrint : Import from wine.

NTPrint does have a API test program from wine, not imported at this
time.

These will be Sync/Ported to full forked.
 2020-05-12 20:26:02 -05:00
Joachim Henze
666fe66fe9 [MSAFD] Workaround regression CORE-15804 
To fix 'MSTSC fails to connect with error "ERROR: Bad packet header"'
which regressed by 0.4.12-dev-752-g
6bc61f63f1

In 0.4.12 and 0.4.13 releases I totally reverted
Pierre Schweitzer's work instead.

Thanks to Doug Lyons, author of this new workaround,
we can keep Pierre's work.
We think MSAFD is a better place to workaround than
our MSTSC binary, because our MSTSC runs fine on
W2K3SP2.

I will backport this new workaround also into 0.4.14RC.
 2020-05-13 02:39:37 +02:00
Piotr Hetnarowicz
b22484b533 [BROWSEUI] PL-pl update 
browseui.dll - PL-pl translation update :)
 2020-05-11 15:52:31 +02:00
Piotr Hetnarowicz
6f05ea5911 [MAIN.CPL] PL-pl update 
MAIN.CPL - PL-pl
-dialogs fix
-strings update
 2020-05-11 15:52:17 +02:00
Piotr Hetnarowicz
cc6dcfb10e [INTL.CPL] PL-pl update 
intl.cpl - PL-pl update
-dialogs fix
-strings update
 2020-05-11 15:51:53 +02:00
Katayama Hirofumi MZ
711f631849
[SHELL32] Don't hardcode C: drive (#2768) 
CORE-13235
 2020-05-11 11:43:07 +09:00
Kyle Katarn
c1fad34755
[WINNLS] Fix of GetCurrencyFormatW to handle "32" grouping format (#2719) 2020-05-10 08:34:35 +02:00
Charles Ambrye
e978ec6125
[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted (#2703) 
Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.
 2020-05-09 21:54:15 +09:00
Jared Smudde
e2fdfae24f
[COMDLG32] Add some more places to the places bar in the open file dialog. (#2732) 
Add Recent Documents and My Network Places to the places bar in the open file dialog.

NOTE: Technically this "places bar" can be customized:
https://www.tenforums.com/tutorials/126153-change-places-bar-items-common-dialog-box-windows.html
https://www.sevenforums.com/tutorials/85487-common-file-dialog-box-customize-places-bar.html
 2020-05-09 21:50:20 +09:00
Kyle Katarn
295ba62820
Fix of comdlg32 Treeview undue handling of WM_SYSKEYDOWN (#2731) 
Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...)
Early embodiement of the fix proposed to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functionnal limitation in ReactOS. CORE-17020
 2020-05-09 21:37:26 +09:00
Katayama Hirofumi MZ
0ea110cda9 [RSAENH][MSXML3][OLE32] Revert PRIVATE commits (cbe8a9f and 38b438b) 2020-05-09 17:55:37 +09:00
Katayama Hirofumi MZ
38b438b0f6 [MSXML3][OLE32] DllGetClassObject should be PRIVATE 2020-05-09 17:02:08 +09:00
Katayama Hirofumi MZ
cbe8a9f997 [RSAENH] DllRegisterServer should be PRIVATE 2020-05-09 16:59:59 +09:00
Katayama Hirofumi MZ
413d722628
Revert "Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)" (#2758) 
This reverts commit 66b0a48a75.
 2020-05-09 15:32:15 +09:00
Katayama Hirofumi MZ
66b0a48a75
Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753) 
This reverts commit 2d4d3f5fce.

Reverts #2146. I think #2135 (e329e83) and #2146 (2d4d3f5) are my mistakes.
CORE-16552, CORE-16747
 2020-05-09 11:30:11 +09:00
Serge Gautherie
02825c20e4
[APISETS] api-ms-win-core-winrt-l1-1-0: Ro*() are NT8+ (#2739) 
(Supersedes PR #2374.)
CORE-16707
 2020-05-07 13:00:10 +02:00
Kyle Katarn
d635ce0cc0
[SYSDM][DESK] Fix GetDC/ReleaseDC error management (#2707) 
## Purpose
[SYSDM]
- When closing System Properties page, log show
(win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()!
because GetDC() is called (multiple times) without properly calling ReleaseDC() as required in order to release a device context.
- This module also lacks some error management in case null DC are provided (on error).
- LiveCD Userinit, based on SYSDM is affected too.

[DESK]
- Fix missing ReleaseDC related to the spectrum (color depth)

## Proposed changes
- ReleaseDC() added.
- Error management in case of null DC.
- Overall alignement of LiveCD Userinit and SYSDM.
 2020-05-07 12:57:46 +02:00
Katayama Hirofumi MZ
1f3cb13fb9
[SHELL32] Distinguish floppy and removable drives (#2645) 
Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221
 2020-05-06 00:35:01 +09:00
Serge Gautherie
9634a31589
[ADVAPI32] Remove now-redundant comment (#2735) 
Addendum to 5dfe345.
 2020-05-05 11:37:09 +03:00
Kyle Katarn
5dfe3455db
[ADVAPI32] Fix undue debug print in nominal case (#2734) 
In current implementation, when regedit opens HKCR root key, an error is logged
err:(dll/win32/advapi32/reg/hkcr.c:964) Returning 259.
This is not correct as the code 259 is ERROR_NO_MORE_ITEMS which is the nominal return value when end of enumeration is reached.
 2020-05-04 23:30:36 +03:00
Serge Gautherie
8f5b0d8890
[APISETS] *_seh_filter_*() are NT6+ (#2729) 
Addendum to 65fd292. CORE-16700
 2020-05-04 23:26:38 +03:00
Adam Stachowicz
4da611ad4b
[NETID] Update Polish translation (#2709) 
Addendum to c276681.
 2020-05-04 23:20:04 +03:00
Victor Perevertkin
8bd9450da8
[HTTPAPI] Convert httpapi.dll to a stub-only library 
Wine's implementation relies on http.sys driver, which we don't have
anyway. Function declarations are taken from Wine 5.7

CORE-16963
 2020-05-04 11:37:16 +03:00
Katayama Hirofumi MZ
11b6f973b7 [SHELL32] Follow-up 2 of #2659 
Add TODO comments.
Make CreateAPCThread static.
CORE-13950
 2020-05-04 16:22:38 +09:00
Katayama Hirofumi MZ
7980f40911 [SHELL32] Follow-up of #2659 
Add CreateAPCThread function and use it. CORE-13950
 2020-05-04 15:28:16 +09:00
Katayama Hirofumi MZ
5c589b5537
[SHELL32] Notify filesystem changes (#2659) 
Notify filesystem change notifications by using ReadDirectoryChangesW function. Creating/Deleting files/folders will be responsive in Explorer. CORE-13950
 2020-05-04 14:53:23 +09:00
Jared Smudde
5b7be1572b
[SHELL32] Set the Run dialog to use the newer style browse for file dialog. (#2728) 
Apply the OFN_EXPLORER flag to the Run dialog so the dialog uses the newer style browse dialog.
 2020-05-04 12:53:35 +09:00
Kyle Katarn
033a317d06
[SYSDM] Fix the missing TABSTOP style on Startup and Recovery dialog (#2722) 
Now the OS choice and the debug info selection combo-boxes can be selected via keyboard navigation.
 2020-05-03 12:16:45 +02:00
Eric Kohl
8c4b0c9142 [NETID] Disable the 'Network ID' and 'Change' buttons and show the admin note when the current user is not an administrator 2020-05-01 22:34:01 +02:00
Eric Kohl
226878563f [NETID] Fix a typo in NetworkDlg_OnOK 2020-05-01 22:00:32 +02:00
Eric Kohl
b25fe54f29 [NETID] Fix the left margin on the Computer Name dialog 2020-05-01 20:00:12 +02:00
Eric Kohl
c276681ef4 [NETID] Improve the 'Computer name' property page 
- Check for changes of the host and domain name.
- Use NetGetJoinInformation to retrieve the join status.
- Implement the SyncDomainWithMembership setting.
- Disable the administrator warning temporarily.
 2020-05-01 19:44:09 +02:00
Kyle Katarn
8bd6b9b6c2
[OLE32][WINESYNC] Fix Wine's implementation of IMalloc.DidAlloc based from Wine 5.7 (#2662) 
CORE-15262

This fixes the exceptions raised when calling "Scan folder" a second time in SUMo 5.10.16.
The problem was reported to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=48941

Import Wine commits by Nikolay Sivov, with the help of Doug Lyons:
- 08f4b6ee0a
  ole32: Fix IMalloc::DidAlloc() return value to reflect block validity.
- 1e3bc9f3a6
  ole32: Improve thread safety in DidAlloc().
- 06d36b1adf
  ole32: Fix spy callback arguments for IMalloc::GetSize().
 2020-05-01 15:01:19 +02:00
Kyle Katarn
3bee3b92ab
[SYSDM] Virtual Memory panel : Complementary fix from PR #2597 (#2706) 
Fix all lang resources in order to reflect main changes from PR #2597 (16MB>2MB).
To translators: Please sync the respective translations!

CORE-12486
 2020-05-01 14:47:04 +02:00
Oleg Dubinskiy
b0e995728a
[SYSSETUP] Improve SetupQueryRegisteredOsComponent export (#2702) 
CORE-16784

Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
 2020-05-01 13:45:19 +03:00
Katayama Hirofumi MZ
77b8505393
[SHELL32] Delete IDM_RECENTMENUHEAD resource menu (#2705) 
Follow-up of #2648. Reduce translation cost and resource data.
CORE-3588, CORE-11483
 2020-05-01 15:58:58 +09:00
Katayama Hirofumi MZ
d62b1a9ce5 [CPL][HOTPLUG] Add Japanese translation 2020-05-01 10:52:19 +09:00
Katayama Hirofumi MZ
0bf4cc4304 [TIMEDATA] Improve Japanese translation 2020-05-01 10:37:46 +09:00
Katayama Hirofumi MZ
7812c537de [MYDOCS] Add Japanese translation 2020-05-01 10:25:47 +09:00
Kyle Katarn
cd6e1c73c0
[SHELL32] Fix "Open With..." spamming registry MRU keys. (#2685) 
CORE-16981

The problem:
============

- When opening "Open With..." dialog for a given file format, multiple MRU items are appended to registry : 2 items written, even if dialog is closed "cancel".
- Expected behavior : 1 MRU item if execute is selected and 0 MRU if cancel is selected.

Fix:
====

- MRU item to be added when "Execute" is selected only.
- Once added, set the presence flag to avoid multiple MRU items being added later.
 2020-04-30 23:03:10 +02:00
Mark Jansen
190c1b86ec
[ZIPFLDR] Set correct access time on file extraction 2020-04-30 20:38:43 +02:00
Jose Carlos Jesus
534710a6d5 [SHELLEXT] Fixed some typos in Portuguese translation 2020-04-30 20:29:21 +02:00
Stanislav Motylkov
79f5de2a73
[TIMEDATE] Update Russian translation 
Addendum to 5a81a5b. CORE-16684
 2020-04-30 20:58:59 +03:00
Stanislav Motylkov
da9f43e76f
[HOTPLUG] Add Russian translation 
Also made some cosmetic fixes and added missing menu in Indonesian translation

Addendum to 2125fec, bfdd626 and b8dd046.
 2020-04-30 20:58:33 +03:00
Stanislav Motylkov
1dd70d306f
[POWERCFG] Update Russian translation 
Addendum to 535b8dd and 52cd931. CORE-12565 CORE-16893
 2020-04-30 20:58:08 +03:00
Stanislav Motylkov
f956c962f0
[DESK] Update Russian translation 
Addendum to d05f621 and e157468. CORE-14537 CORE-16923
 2020-04-30 20:57:42 +03:00
Stanislav Motylkov
f0e22d15c9
[INTL] Add Russian translation 
Also improve other translations. Addendum to 216b702. CORE-16951
 2020-04-30 20:56:50 +03:00
Stanislav Motylkov
fefe9736ac
[SENDMAIL] Update Russian translation 
Addendum to a48aa21. CORE-16924
 2020-04-30 20:56:22 +03:00
Stanislav Motylkov
44e2b6fdd9
[BOOTDATA][THEMEUI] Add Russian translation 
Addendum to 94e4c69 and a2f5283. CORE-16934
 2020-04-30 20:55:56 +03:00
Stanislav Motylkov
d3e94b4cec
[MYDOCS] Add Russian translation 
Addendum to 4efff7f. CORE-12562
 2020-04-30 20:55:28 +03:00
Mas Ahmad Muhammad
7895704952 [COMDLG32] enlarge list area in CHOOSE_FONT 2020-04-30 18:15:48 +02:00
Adam Stachowicz
bd33e6b26f
[SHELL32] Update Polish translation (#2700) 
Addendum to 8f3079c.
 2020-04-30 13:37:31 +03:00
Jared Smudde
96e6cee044
[DESK] Set some flags for Browse for Wallpaper dialog (#2699) 
* [DESK] Add initial directory flag and set it to My Pictures. Also set OFN_EXPLORER style.

* Use CSIDL_MYPICTURES instead of environment variable concoction.

* Fix formatting.
 2020-04-30 11:10:40 +03:00
Katayama Hirofumi MZ
8f3079c67f
[SHELL32][EXPLORER] Improve Recent Documents of Start Menu (#2648) 
Improve Recent Documents of Start Menu. Add items of "My Documents" and "My Pictures" into Recent menu item.
CORE-3588, CORE-11483
 2020-04-30 17:09:14 +09:00
Jose Carlos Jesus
6d739cb2ce
[APPWIZ] Make shortcut name selected on creation (#2184) 2020-04-30 09:02:33 +03:00
Serge Gautherie
a9161650ad
[MSVCRT][APISETS] Update spec files for __DestructExceptionObject() (#2682) 
- [MSVCRT] __DestructExceptionObject(): Remove '-version=0x600+'
- [APISETS] __DestructExceptionObject(): Forward it to msvcrt

CORE-15135
 2020-04-30 00:36:44 +03:00
Kyle Katarn
bdb4da009a
[MMSYS] Fix combo box and play icon on "Sound" properties page (#2690) 
CORE-16935
 2020-04-29 21:58:34 +03:00
Stanislav Motylkov
8c5c47ec17
[TAPIUI] Fix dialog localization issues 
Addendum to 0a387c9.
 2020-04-29 21:29:52 +03:00
Piotr Hetnarowicz
0a387c9377
[TAPIUI] Update Polish translation (#2694) 2020-04-29 20:02:49 +03:00
Oleg Dubinskiy
125020c23f
[SETUPAPI] Improve SetupRemoveFromSourceListA/W exports (#2680) 
CORE-16968
 2020-04-29 00:58:40 +03:00
Kyle Katarn
02d856c9c5 [NETSHELL] Remove erroneous DNS Server line and fix date/time format (#2655) 
CORE-16947
 2020-04-29 00:18:55 +03:00
Katayama Hirofumi MZ
03c09c9e2c
[SHIMGVW] Correctly draw display border (#2687) 
Use WS_EX_CLIENTEDGE extended style for display window.
Fix message WM_SIZE handling. CORE-16983
 2020-04-28 20:56:18 +09:00
Serge Gautherie
0b530fe496 [RPCRT4] Add I_RpcSNCHOption() as 'stub' 
CORE-12534
 2020-04-27 22:05:29 +02:00
Kyle Katarn
f949e256b5
[SYSDM] User Profiles fix of OnDestroy (CORE-16921) (#2614) 2020-04-27 18:25:19 +02:00
Stanislav Motylkov
68f9fd2f5d
[SHELL32] Fix dialog labels in Recycle Bin properties page (#2676) 
Also fix remaining "Max size" edit box positions.

Addendum to e6e45b3. CORE-16972
 2020-04-27 16:03:27 +03:00
Kyle Katarn
e6e45b34cc
[SHELL32] Fix "Max size" Edit box position in Recycle Bin properties page (#2676) 
CORE-16972
 2020-04-27 12:48:26 +02:00
Kyle Katarn
7c4788695f
[NETID] Fix incorrect component position and size, complete French translation (#2672) 
- Missing fr-fr translation for some items
- Wrong components size and/or position to fully display text

CORE-16597

- Complete fr-fr translation of associated .rc file
- Fix of component design (size, location, BS_MULTILINE).

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
 2020-04-27 12:44:27 +02:00
Piotr Hetnarowicz
3efe1596a5
[RASDLG] pl-PL update (#2675) 2020-04-27 13:38:27 +03:00
Oleg Dubinskiy
70b6658af8
[PROFMAP] Initial implementation (#2119) 
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
 2020-04-26 21:15:21 +02:00
Oleg Dubinskiy
9f0a0f65ea [SHLWAPI] Add version limit for export from NT 5.1 to NT5.2, because it was dropped since NT6 
Co-Authored-By: Serge Gautherie <32623169+SergeGautherie@users.noreply.github.com>
 2020-04-26 20:20:40 +02:00
Oleg Dubinskiy
ee08399112 [SHLWAPI] Improve SHEvaluateSystemCommandTemplate export CORE-14742 2020-04-26 20:20:40 +02:00
Andreas Maier
f95c96e207 [MSV1_0] Create stubs for SECPKG_FUNCTION_TABLE (SpLsaModeInitialize) 
This commit fixes a bug too.
Old code of SpLsaModeInitialze returns a pointer to a local variable (SECPKG_FUNCTION_TABLE).
 2020-04-26 17:26:17 +02:00
Serge Gautherie
a16a37fd2d
[RPCRT4] Fully WineSync spec file. CORE-16441 (#2494) 
* [RPCRT4] Export NdrServerCallAll stub

Addendum to 6feb8748d3.

Import rest of
e54224e88c

With thanks to Hermès B., who noticed it is 64bit only.

CORE-16441

* [RPCRT4] Fix NdrServerContextMarshall spec file entry

Addendum to 6feb8748d3.

Import
660ee356e9

CORE-16441

* [RPCRT4] Fix RpcNetworkIsProtseqValid[AW] spec file entries

Cherry-pick
6127c688ea
 2020-04-26 17:23:13 +02:00
Adam Stachowicz
49e7649730
[INTL.CPL] Polish translation update (#2665) 
After PR #2654
 2020-04-26 16:48:46 +02:00
Katayama Hirofumi MZ
771457f37f
[SHELL32] Implement VK_DELETE on SHBrowseForFolder (#2661) 
Enable Del/Delete key to delete the selected folder in "Browse for Folder" dialog.
You can use https://jira.reactos.org/secure/attachment/40118/getfolder.zip as a test program.
CORE-7592
 2020-04-26 22:06:19 +09:00
Mark Jansen
d5f0b2b160
[RTL] Implement LdrpRecordUnloadEvent 2020-04-26 14:35:51 +02:00
Serge Gautherie
a7e4d66be5 [SHELL32] DoGetProductType(): Use RegGetValueW() 
instead of RegQueryValueExW(), to enforce a null terminator.

Addendum to 9f4e8ef25b.
 2020-04-26 14:16:59 +02:00
Serge Gautherie
f44cb6de96
[NDK][NTDLL] RtlGetNtProductType(): Update it with SAL2 annotations 2020-04-26 14:08:58 +02:00
Saibamen
79c932078d
[SHIMGVW] Update Polish translation (#2666) 
After PR #2606
 2020-04-26 13:56:46 +02:00
Saibamen
55e742119c
[DESK.CPL] Update Polish translation (#2664) 
After PR #2591
 2020-04-26 13:56:17 +02:00
Saibamen
69b3f042e5
[POWERCFG] Update polish translation (#2663) 
Update after PR #2593
 2020-04-26 13:07:25 +02:00
Jose Carlos Jesus
01cb01de94
[CPL] Portuguese translation update (#2629) 
Portuguese translation for:
cpl/input, cpl/hotplug, cpl/liccpa, cpl/telephon, cpl/timedate
 2020-04-26 13:06:34 +02:00
Katayama Hirofumi MZ
c04010c9ad [SHELL32] Update name in CDefView::LV_RenameItems 2020-04-26 13:21:14 +03:00
Kyle Katarn
ab4b001e94
[NETID] fr-fr translation fix and component size (#2586) 2020-04-26 11:54:42 +02:00
Kyle Katarn
52cd931f22
[POWERCFG] Power Scheme fix as per CORE-16893 (#2593) 
Related to CORE-16900

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
 2020-04-26 10:20:22 +02:00
Kyle Katarn
e15746849a
[DESK][THEMEUI] Update French translation (#2591) 
Co-authored-by: Sylvain Deverre <deverre.sylv@gmail.com>
 2020-04-25 18:34:41 +02:00
Kyle Katarn
9c682e4c16
[COMDLG32][REGEDIT] Fix display problems (CORE-16890) (#2638) 2020-04-25 10:41:01 +02:00
Kyle Katarn
07e80dead4
[SHELL32] Improve french translations 2020-04-25 10:38:35 +02:00
Katayama Hirofumi MZ
d32858413d
[SHELL32] Command 'start C:' should open 'C:\' (#2642) 
Based on JIRA user amaneureka's idea.
In SHELL_execute function, add a backslash for Drive "C:", "D:" or "E:" etc.
CORE-16384
 2020-04-25 11:01:20 +09:00
Kyle Katarn
4d2d2dbb25
[SYSDM] Virtual Memory panel : improve settings for pagefile + fr-fr translation 
* Fix for CORE-12486

Co-Authored-By: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Co-authored-by: Sylvain Deverre <deverre.sylv@gmail.com>
 2020-04-24 18:28:38 +02:00
Kyle Katarn
216b702fb6
[INTL] Translate hardcoded string (#2654) 
CORE-16951
 2020-04-24 17:27:07 +03:00
Thomas Faber
3e9c4dad66
[WINDOWSCODECS] Use upstream Wine fix for 4bps BGRA TIFF. CORE-16796 
Import Wine commits by Dmitry Timoshkov:
* 0cd8502b49 windowscodecs: Add support for 4bps RGBA format to TIFF decoder.
* 962bb99352 windowscodecs/tests: Add a separate test for 4bps BGRA TIFF format.
 2020-04-24 14:56:26 +02:00
Thomas Faber
b01a480163
[LIBXSLT] Update to version 1.1.34. CORE-16952 2020-04-24 14:45:03 +02:00
Stanislav Motylkov
56c060b876
[INTL] Fix build (#2612) 
Addendum to 76dd2fc.
 2020-04-24 02:48:22 +03:00
Mas Ahmad Muhammad
76dd2fcff3
[TRANSLATION] Update Indonesian translation for CPL applets (#2612) 
Signed-off-by: Mas Ahmad Muhammad <m.charly81@gmail.com>
 2020-04-24 02:24:32 +03:00
Kyle Katarn
9118a1b8af
[SENDMAIL] Add french translation for "Send To" shell extension 2020-04-23 19:58:32 +02:00
Serge Gautherie
c2040413ec [ACPPAGE] Update now-redirected 'www.reactos.org' URLs 2020-04-23 10:18:10 +02:00
Serge Gautherie
546c606aaa [SYSDM] Update now-redirected 'http' and 'www.reactos.org' URLs 2020-04-23 10:17:52 +02:00
Katayama Hirofumi MZ
352f6a6ad7 [ZIPFLDR] Improve Japanese translation 2020-04-23 16:03:55 +09:00
Katayama Hirofumi MZ
b88d45c676 [SENDMAIL] Improve Japanese IDS_SHORTCUT translation 2020-04-23 15:59:32 +09:00
Piotr Hetnarowicz
1abd40fd3e
[sendmail] pl-pl update (#2637) 2020-04-23 08:50:35 +02:00
Victor Perevertkin
194ea909fd
[BTRFS][UBTRFS][SHELLBTRFS] Upgrade to 1.7.2 
CORE-16679
 2020-04-23 07:07:36 +03:00
Katayama Hirofumi MZ
a48aa21102
[SENDMAIL][ZIPFLDR][MYDOCS] Fix creation of SendTo files (#2616) 
- Improve and move SendTo files creation code and timing.
- Delete IDS_DESKLINK of shell32.
- Add IDS_DESKLINK into sendmail.
CORE-16924
 2020-04-23 04:19:20 +09:00
Katayama Hirofumi MZ
2dc2ec9de3 [MYDOCS] Follow-up of #2624 
Use HIDA_GetPIDLFolder and HIDA_GetPIDLItem.
CORE-12562
 2020-04-22 23:08:56 +09:00
Thomas Faber
c58d7a6df6
[MBEDTLS] Update to version 2.7.15. CORE-16869 2020-04-22 12:37:25 +02:00
Katayama Hirofumi MZ
4efff7f463
[SHELLEXT][MYDOCS][INF] Add mydocs.dll and .mydocs file extension (#2624) 
I found "SendTo My Documents" is realized by .mydocs filename extension in WinXP/2k3. To implement this, I will add mydocs.dll file. CORE-12562
 2020-04-22 19:34:15 +09:00
Hermès Bélusca-Maïto
aa69236646
[TIMEDATE.CPL] In case TimeZone data does not contain a valid StandardName, perform comparisons against the time-zone numerical values instead. 
It may happen that the time-zone information in the registry key
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\TimeZoneInformation
contains an empty StandardName / DaylightName, or is too long for the
standard maximum 32-character length, and therefore is returned empty.
And/or it may happen as well that some of the standard names (value "Std")
present in some of the time zones listed in
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones
are similarly too long, and therefore are returned as empty strings.

In case this happens, perform comparisons instead with the numerical
values Bias, StandardBias, DaylightBias, StandardDate and DaylightDate
in order to find a match.

It is interesting to note also that in Vista+ there is an additional
REG_SZ value "TimeZoneKeyName" in
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\TimeZoneInformation
that allows to directly find a match in the time zones list in
"Windows NT\CurrentVersion\Time Zones".
 2020-04-22 00:58:34 +02:00
Hermès Bélusca-Maïto
7c3e96a26a
[TIMEDATE.CPL][SYSSETUP][TZLIB] Introduce a small static library "tzlib": "TimeZone Utilities Library", and use it in timedate.cpl and syssetup.dll. 
This small win32 library provides time-zone utility wrappers around
Win32 functions, that are used by different ReactOS modules such as
timedate.cpl, syssetup.dll, and a possible future 'tzutil' tool.

The code has been extracted from the common code found in both
timedate.cpl and syssetup.dll.
 2020-04-22 00:58:32 +02:00
Jose Carlos Jesus
181ed94e22
[SHELL32] Fix grammar mistake in portuguese translation (#2605) 2020-04-21 16:38:23 +03:00
Katayama Hirofumi MZ
0950ae26d3 [SHIMGVW] Improve Japanese translation 2020-04-21 19:11:58 +09:00
Kyle Katarn
dd0f498c01
[SHIMGVW] Update French translation (#2610) 
Addendum to 3926e9b. CORE-16911
 2020-04-21 03:18:55 +03:00
Stanislav Motylkov
c6abe80af5
[SHELL32] Update Russian translation 
Addendum to c82ba34.
 2020-04-21 00:38:42 +03:00
Stanislav Motylkov
5ac8d90e57
[SHIMGVW] Update Russian translation 
Addendum to 3926e9b. CORE-16911
 2020-04-21 00:30:22 +03:00
Stanislav Motylkov
2bd4081936
[BROWSEUI] Update Russian translation 
Addendum to d8e47d6. CORE-10989
 2020-04-21 00:24:23 +03:00
Charles Ambrye
8c4bd09518 [SHELL32] Fix a bug that caused Auto Arrange to always be highlighted in the file explorer 
This occurred in the file explorer because the menu isn't destroyed and recreated each time, so the menu item, once checked, will stay checked forever.  We must call CheckMenuItem with MF_UNCHECKED to clear the check when necessary
 2020-04-20 23:13:09 +03:00
Charles Ambrye
c82ba3485e [SHELL32] Modify context menu to include Align To Grid, and remove Line Up Icons 
Implement support for using Align To Grid, which itself simply sets the LVS_EX_SNAPTOGRID extended style of the list view control
 2020-04-20 23:13:09 +03:00
Charles Ambrye
733a32dade [LISTVIEW] Add basic support for LVS_EX_SNAPTOGRID 2020-04-20 23:13:09 +03:00
Kyle Katarn
fbee8fa99e
[BROWSEUI] fr-fr translation update following PR2602 (#2611) 
* PR2602 fr-fr update
* typo following sdever review
 2020-04-20 19:21:36 +02:00
Julen Urizar Compains
6100c8e268
[TRANSLATION][SHIMGVW] Spanish IDS_NOPREVIEW (#2609) 2020-04-21 02:00:43 +09:00
Ioannis Adamopoulos
0d077c3068 [SHELL32] CDesktopFolder::GetUIObjectOf: fix crash when requested to create a IID_IContextMenu for 0 items. 
* Tests show that we should return a valid object even in this case.
 2020-04-20 17:37:03 +03:00
Mark Jansen
d2b91deb33 [SHELL32] CMyDocsFolder: Ensure the object can be used without calling Initialize 2020-04-20 17:36:44 +03:00
Mark Jansen
6a6a28b634 [SHELL32] Ensure CIDLDataObject::GetData always returns an STGMEDIUM that is safe for use with ReleaseStgMedium 2020-04-20 17:36:43 +03:00
Katayama Hirofumi MZ
3926e9b3c8
[SHIMGVW] Consider failure case of loading file (#2606) 
If loading an image file failed, then properly handle it. The command line is rundll32 shimgvw.dll,ImageView_Fullscreen .
CORE-16911
 2020-04-20 21:05:14 +09:00
Charles Ambrye
d8e47d61d4 [BROWSEUI] Display an error message if the path or drive don't exist (CORE-10989) 
The return result of ParseNow was never checked, but contained useful information on what type of error may have occurred.  If the error is an issue with the path not existing the explorer will now show an error message notifying the user of the problem instead of silently failing.
Note:  Shell32 does not properly return ERROR_INVALID_DRIVE when the drive path does not exist.  For that reason, it is still possible to browse to a non-existent drive.  However, once shell32 is patched this code will work properly, as it checks for both ERROR_INVALID_DRIVE and ERROR_FILE_NOT_FOUND.
 2020-04-20 14:21:37 +03:00
Charles Ambrye
b8f4f22ba2 [BROWSEUI] Attempt to parse absolute path even if relative path gets an unexpected failure 
Some 'BindToObject' methods are incomplete, and in some cases relative paths are simply not possible (especially in special folders such as the desktop)
 2020-04-20 14:12:47 +03:00
Joachim Henze
4af7888b29 [SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs 
-Avoid text truncations regarding the checkbox
 in a uniform way
-Reduce chance of text truncations for a button
 in a uniform way
-Fix es-ES dlg layout and harmonize its dlg Size
 with other languages
-de-DE fix double accelerator
 2020-04-20 02:08:45 +02:00