Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-21 16:04:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTDLL] Use lowest OS version GUID in the application manifest, instead of highest

Browse source
This commit is contained in:
Timo Kreuzer 2020-03-01 23:40:57 +01:00
parent 0ed8b916e4
commit cb99761bc1
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
dll/ntdll/ldr/ldrinit.c
View file

@ -1636,8 +1636,13 @@ LdrpInitializeProcessCompat(PVOID pProcessActctx, PVOID* pOldShimData)
if (ContextCompatInfo->ElementCount == 0)
return;
/* Search for known GUID's, starting from newest to oldest. */
for (cur = 0; cur < RTL_NUMBER_OF(KnownCompatGuids); ++cur)
/* Search for known GUIDs, starting from oldest to newest.
Note that on Windows it is somewhat reversed, starting from the latest known
version, going down. But we are not Windows, trying to allow a lower version,
we are ReactOS trying to fake a higher version. So we interpret what Windows
does as "try the closest version to the actual version", so we start with the
lowest version, which is closest to Windows 2003, which we mostly are. */
for (cur = RTL_NUMBER_OF(KnownCompatGuids) - 1; cur != -1; --cur)
{
for (n = 0; n < ContextCompatInfo->ElementCount; ++n)
{
@ -1671,9 +1676,11 @@ LdrpInitializeProcessCompat(PVOID pProcessActctx, PVOID* pOldShimData)
*pOldShimData = pShimData;
}
/* Store the highest found version, and bail out. */
/* Store the lowest found version, and bail out. */
pShimData->dwRosProcessCompatVersion = KnownCompatGuids[cur].Version;
DPRINT1("LdrpInitializeProcessCompat: Found guid for winver 0x%x\n", KnownCompatGuids[cur].Version);
DPRINT1("LdrpInitializeProcessCompat: Found guid for winver 0x%x in manifest from %wZ\n",
KnownCompatGuids[cur].Version,
&(NtCurrentPeb()->ProcessParameters->ImagePathName));
return;
}
}