Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-28 08:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
83259 commits 85 branches 274 tags 1.1 GiB
Commit graph

618 commits

Author SHA1 Message Date
Katayama Hirofumi MZ 5525c81b2f
[SHELL32] Add CDefView::DefMessageSFVCB (Retrial of #1145) (#1151) 
CORE-14976
 2018-12-17 19:22:31 +09:00
Katayama Hirofumi MZ 235042a16c
[CPL][SHELL32] Add icons to input, joy, sysdm, folder options (#1138) 
CORE-15445
 2018-12-16 08:40:47 +09:00
Jared Smudde 44bb99cc8e [SHELL32] Add a warning dialog before starting a dialog as well as a format complete dialog. (#1137) 
Also fix the progress bar not working and the Allocation unit size combo box disappearing after a format completes.
 2018-12-15 21:22:57 +01:00
Luo Yufan adf023e38c [SHELL32] Update Simplified Chinese translation. 2018-12-15 20:13:47 +01:00
Luo Yufan f369ae618d [SHELL32] Update Traditional Chinese translation. 2018-12-15 20:13:47 +01:00
Katayama Hirofumi MZ 2be0fe5f8f [SHELL32] Improve French translation of Folder Options View 
CORE-15259
 2018-12-14 21:41:44 +01:00
Katayama Hirofumi MZ fad9f6677a [BROWSEUI] Follow up of #1121 
CORE-15434
 2018-12-13 20:40:05 +09:00
Mark Jansen cc2f0a8868
[SHELL32] Add IActiveDesktop stub 
CORE-15424
 2018-12-12 19:29:09 +01:00
Katayama Hirofumi MZ 472787ffea
[SHELL32] Fix 'Run' dialog crash (#1117) 
Running "%SYSTEMROOT%" sometimes crashed. This will fix it. CORE-15431
 2018-12-12 10:33:05 +09:00
Auron Hines 86c5cfd81a [TRANSLATION][SHELL32] Grammar fix: content -> contents (#1115) 2018-12-11 19:43:46 +01:00
Katayama Hirofumi MZ 06d717e3bc
[SHELL32] Enable environment variables in 'Run' dialog (#1111) 
CORE-15431
 2018-12-11 16:35:45 +09:00
Luo Yufan 07b120bd56 [TRANSLATION] Update Simplified Chinese translation. (#1094) 2018-12-04 17:13:39 +01:00
Luo Yufan a9f634b5fe [SHELL32] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Katayama Hirofumi MZ cbd52e30d7
[SHELL32] Don't show taskbar button of Folder Options (#1091) 
CORE-10481
 2018-12-03 13:38:09 +09:00
Katayama Hirofumi MZ c1eb420a91
careless s/E_FAIL/FALSE/ (#1089) 2018-12-03 05:43:21 +09:00
Katayama Hirofumi MZ 623b2e153e
[SHELL32] Follow up of #1085 (#1088) 
CORE-10481
 2018-12-03 05:38:36 +09:00
Katayama Hirofumi MZ ecd51d99f4
[SHELL32] Don't show taskbar button of file property sheet (#1085) 
CORE-10481
 2018-12-03 04:25:46 +09:00
Giannis Adamopoulos 1d55f459d6 [SHELL32] CFSDropTarget: Fix right click menu when shown over the tree view. CORE-11240 2018-11-27 12:58:08 +02:00
Luo Yufan a2819679ec [TRANSLATION] Update Simplified Chinese translation. (#1057) 2018-11-23 16:24:47 +01:00
Joachim Henze 432afb4161 [SHELL32] Improve CORE-15295 IDD_FILE_PROPERTIES 
addendum to 0.4.11-dev-673-g
04e1263921

Actually this control must not statically consume width of 170.
There are two different versions of that dialog.
One has a "change"-button. In this case the edit must be only 100 wide.
In case we have the version without the change button, we resize it to have
170 width (same as its neighbor).

This commit is shared work of
Stanislav Motylkov, Giannis Adamopoulos and Joachim Henze.

Commit supersedes PR#1056.
 2018-11-23 02:25:28 +01:00
Bișoc George c00bafaad9 [SHELL32] Print out the error code (#973) 
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
 2018-11-16 23:09:15 +01:00
Giannis Adamopoulos 9baf05f164 [SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file 
CORE-15353
 2018-11-15 21:26:17 +02:00
Luo Yufan d8a4e0a8e3 [TRANSLATION]Update Simplified Chinese translation. (#1032) 2018-11-14 21:42:21 +09:00
Giannis Adamopoulos bcd309cb7a [SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before 
CORE-14116
 2018-11-11 20:28:27 +02:00
Luo Yufan 5cdee1ab82 [TRANSLATION] Update Simplified Chinese translation. (#1028) 2018-11-11 17:57:12 +01:00
Luo Yufan 91e032f9b1 [TRANSLATION] Update Simplified Chinese translation. (#1025) 2018-11-09 15:31:53 +01:00
Joann Mõndresku b63e2d5046 [TRANSLATIONS] Style fixes for Estonian 2018-11-07 22:10:27 +01:00
Joachim Henze 04e1263921 [SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs 2018-11-07 01:40:53 +01:00
Mark Jansen 4bfac27ce6
[SHELL32] Fix broken control definition 2018-10-28 13:06:27 +01:00
Giannis Adamopoulos c69ef281c0 [rosctrls.h] CListView: Add Arrange method 
[SHELL32] CDefView: Start implementing Auto arrange.
So far its effect is only shown when the browser window resizes.
 2018-10-22 23:51:37 +03:00
Giannis Adamopoulos 410cfbfe15 [SHELL32] CDefView: Disable auto arrange in list and details view mode. 
This supersedes PR #927 and does it correctly.
 2018-10-22 19:18:28 +03:00
Adam Słaboń 7abc8be102 [TRANSLATION] Polish translation update 
Polish translation of net, telnet, diskpart, devcpux, fontext, iernonce, lsasrv, themes, arping, frag, screensavers, ctm, fontsub, WinetestsGUI and localmon.
Update for dxdiag, msgina, msports, netcfgx, shell32 and syssetup.
 2018-10-20 21:26:07 +02:00
Mark Jansen 80c53821c9
[SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view. 
CORE-14976
 2018-10-13 20:28:49 +02:00
Hermès Bélusca-Maïto 2cbac3d049
[SHELL32] Finally fix the icon location path (un)expansion for shell links, and explain why I originally used SHExpandEnvironmentStringsW(). 
CORE-14009 CORE-14982
 2018-10-08 00:50:38 +02:00
Eric Kohl 1e20a3e5b5 [SHELL32] Fix a potential buffer overrun. 
Patch by Kudratov Olimjon.

CORE-8545
 2018-10-07 22:56:16 +02:00
Luo Yufan b70ef2ee56 [TRANSLATION] Update Simplified Chinese translation. (#912) 2018-10-07 20:44:00 +02:00
Hermès Bélusca-Maïto ccde12483f
[SHELL32] Fixes and improvements for PickIconDlg(). 
- Deal with expanded paths only when loading icons. If the user specifies
  an unexpanded path to a module containing icons, this unexpanded path
  is returned to the caller!

- Perform the dialog cleanup in WM_DESTROY message handler.

- When pressing ENTER/OK in the dialog box, retrieve the selected icon and
  close the dialog *ONLY WHEN* the user actually has selected an icon.
  If the user modified manually the module path, pressing ENTER/OK instead
  reloads the icons list.
 2018-09-30 21:48:34 +02:00
Hermès Bélusca-Maïto ae9ec94240
[SHELL32] Code formatting only. 2018-09-30 21:48:31 +02:00
Hermès Bélusca-Maïto 7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed. 
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
 2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings() 
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981
 2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto 41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine. 
- Adjust the code with respect to:
  "shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
  4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)

- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
  ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)

- "shell32: Assume that system directory always contains a drive letter."
  54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)

- "shell32: Use ARRAY_SIZE macro."
  612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)

- "shell32: Fix a trace message."
  bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)

- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
  f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)

- "shell32: Pass correct buffer length to RegQueryValueExW()."
  0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)

- "shell32: Remove unused string (Clang)."
  8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)

- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
  730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
 2018-09-23 00:16:02 +02:00
Katayama Hirofumi MZ 31019e8c0c [TRANSLATION] Update Romanian translation (#851) 
Translation from Stefan Fulea.
CORE-15023
 2018-09-14 11:04:36 +02:00
Joachim Henze e217e926e1 [SHELL32] Fix typo in comment 2018-08-28 14:24:49 +02:00
Katayama Hirofumi MZ 39dc3cdaf6 [SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824) 
CORE-14974
 2018-08-27 12:21:51 +02:00
Mark Jansen 19e9a44118
[SHELL32] Check the result from PathUnExpandEnvStringsW 2018-08-27 11:58:29 +02:00
Mark Jansen 608cb60e44
[SHELL32] Remove some mostly dead code from CShellLink 2018-08-27 11:58:24 +02:00
Katayama Hirofumi MZ 6eb6aa2895 [SHELL32] Fix CShellLink::GetIconLocation (#810) 
Fixes a regression from PR #784.
CORE-14961, CORE-14009
 2018-08-26 15:37:15 +02:00
Katayama Hirofumi MZ 73798d2e71 [SHELL32] Enable to change shortcut icon (#784) 
CORE-11407
 2018-08-21 13:49:32 +02:00
Adam Słaboń af3d426685 [TRANSLATION] Polish translation update (#781) 
In addition: fix the encoding of the comdlg32 and ntvdm polish resource files.
 2018-08-20 17:00:33 +02:00
Joachim Henze abf9340f1b [SHELL32] Translation de-DE CORE-14916 
fix control overlapping in IDD_FOLDER_OPTIONS_FILETYPES
(broke in 0.4.10-dev-24-ed1c6bb0060d06f4c0167d9c2d732f4dc2b4cce4)

and translate IDD_NEWEXTENSION, IDD_EDITTYPE, IDD_ACTION, IDD_FOLDER_CUSTOMIZE
 2018-08-17 18:07:35 +02:00
Getequ d559ca9c98 [ADVAPI32][SHELL32][DESK.CPL] Kill copy-paste of RegLoadMUIString. (#748) 
RegLoadMUIStringW/A is part of advapi32.dll . shell32.dll and desk.cpl contained exact line-by-line copy of that function.
 2018-08-16 16:10:41 +02:00
Katayama Hirofumi MZ db13b422b3 [SHELL32] Fix a careless mistake of ShellExecCmdLine (#737) 
CORE-14886
 2018-08-10 13:25:50 +02:00
Katayama Hirofumi MZ bfcbda227f [SHELL32] Fix handling of multiple parameters in the 'Run' dialog (#665) 
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.

- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.

CORE-14790
 2018-08-05 13:39:17 +02:00
Timo Kreuzer 52ea7d39db [SHELL32] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Julio Carchi d3045af9d5 [TRANSLATIONS] Fix some Spanish translations (#715) 
Also added some new ones.
 2018-07-31 10:58:21 +02:00
Hermès Bélusca-Maïto 74adcadbd0
[SHELL32] Silence a noisy DPRINT. 2018-07-29 17:39:09 +02:00
Katayama Hirofumi MZ 75b09f3f88 [EXPLORER][SHELL32][USER32] Implement 'Show the Desktop' action of Task Bar (#668) 
The keyboard shortcuts Win+D and Win+M are also enabled.

- Implement IShellDispatch4::ToggleDesktop().
- Implement some commands in CTrayWindow.
- Add "sdk/include/reactos/traycmd.h" for tray commands.
- Fix task window switching.
- Improve the user32!SwitchToThisWindow() function and use it.

CORE-14318, CORE-13157
See also: CORE-14806 and CORE-8723
 2018-07-13 10:34:42 +02:00
Katayama Hirofumi MZ e018ccea4b [SHELL32] lpDirectory must have priority in ShellExecuteEx (#681) 
Based on a patch by Mark Jansen.
CORE-14469
 2018-07-12 17:45:43 +02:00
Katayama Hirofumi MZ 55469633cf [SHELL32] Add 'Properties' menu item in My Computer (#647) 
- Add a Shell_DefaultContextMenuCallBack() helper function.
- Implement the IContextMenuCB interface in CDrivesFolder.
CORE-12509
 2018-07-08 17:01:12 +02:00
Katayama Hirofumi MZ 96c0ef4209 [SHELL32] Improve CShellLink a little (#651) 
Improve the display and UI in the shortcut dialog.
CORE-11407
 2018-07-08 16:45:40 +02:00
Katayama Hirofumi MZ a882ec7a02 [SHELL32][EXPLORER] Update system-wide environment variables (#663) 
- Implement shell32 RegenerateUserEnvironment() function and use it.
- CShellBrowser and CDesktopBrowser implements WM_SETTINGCHANGE actions.

CORE-1459, CORE-14397
 2018-07-08 16:32:42 +02:00
Mark Jansen 3904fd6257
[SHELL32] Ensure OpenAs_RunDLL does not loop to infinity and beyond. 
This should fix a timeout on the apitests.
 2018-07-06 21:51:24 +02:00
Hermès Bélusca-Maïto 2afb483a9e
[SHELL32] Shell Profile Folders fixes. 
- Fix a regression introduced in r65415 (1795a3bf) where the directory
  paths stored in "Windows\CurrentVersion\Explorer\User Shell Folders"
  were stored in expanded format instead of in unexpanded format:
  _SHGetDefaultValue() *MUST* return unexpanded paths by design!!

- Augment _SHExpandEnvironmentStrings() and _SHGetUserShellFolderPath()
  to take a user token handle to be able to correctly resolve/expand
  user-specific directory paths.

- Fix _SHExpandEnvironmentStrings() so that it always retrieve the
  correct current user / all-users directory paths by calling userenv
  functions, instead of hardcoding a broken logic. As a result this
  removes the "C:\Documents and Settings\SYSTEM" ghost directory we got
  during ReactOS installation.

- Delimit the changes with respect to Wine by #if(n)def __REACTOS__ .
 2018-06-30 18:20:08 +02:00
Stanislav Motylkov 73aa420f0e [SHELL32] Update russian translation 
CORE-11407
 2018-06-30 01:15:41 +02:00
Stanislav Motylkov 707f2ed360 [SHELL32] Fix some elements positions and styles 
Addendum to eb1912b. CORE-11407
 2018-06-30 01:15:41 +02:00
Katayama Hirofumi MZ e353b48cb2 [SHELL32] Refresh 'General' tab if the folder icon is updated (#646) 
CORE-11407
 2018-06-29 14:13:37 +02:00
Katayama Hirofumi MZ eb1912b15f [SHELL32] Initial implementation of Folder Customization (#642) 
- Add property sheet;
- Implement changing the folder icon.
CORE-11407
 2018-06-28 21:51:37 +02:00
Katayama Hirofumi MZ 3189ec9428 [SHELL32] Add missing desktop.ini files (#640) 
Add the "desktop.ini" files to the special folders to realize their custom icons.
CORE-10045
 2018-06-27 23:11:31 +02:00
Katayama Hirofumi MZ c74bd5d662 [SHELL32] Enable custom CD/DVD icons (#639) 
Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766
 2018-06-27 23:06:54 +02:00
Russell Johnson 6a683dc6d8 [SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() (#635) 
Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.

CORE-12340
 2018-06-24 20:29:57 +02:00
Katayama Hirofumi MZ 1b1e1baa6e [SHELL32] Implement Folder Options File Types 'Change' button (#629) 
CORE-12906
 2018-06-24 20:04:25 +02:00
Katayama Hirofumi MZ 1829f5fed7 [SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632) 
#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196
 2018-06-24 19:59:03 +02:00
Katayama Hirofumi MZ cc8b2717ae [SHELL32] Implement OpenAs_RunDLLA/W (#628) 
CORE-14751
 2018-06-24 19:46:06 +02:00
Abdulganiev Rafael 824a52aa99 [TRANSLATION][SHELL32] Update Russian translation (#633) 2018-06-24 19:42:34 +02:00
Katayama Hirofumi MZ a33908b60f [SHELL32] Improve French Folder Options 2018-06-23 10:51:48 +02:00
Katayama Hirofumi MZ cb69443362 [SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604) 
CORE-14678
 2018-06-22 16:40:06 +02:00
Katayama Hirofumi MZ f8926dccbd [SHELL32] Fix desktop.ini folder icon (#595) 
The folder icon location specified in desktop.ini of a folder should accept its relative path.
CORE-9196
 2018-06-22 15:37:03 +02:00
Denis Malikov 7916d0ae3e [SHELL32] Copy-paste files/folders into current place. 
Files are copied with trying to find new path by adding (%d) suffix before asking for overwrite existing item

CORE-13788
 2018-06-13 20:13:44 +02:00
Adam Słaboń 565ce5e827 [TRANSLATION] Polish translation update (#611) 
Polish translation update for MODE, USETUP and SHELL32.
 2018-06-12 15:51:37 +02:00
Katayama Hirofumi MZ 698cbc6184 [SHELL32] Split dialogs/folder_options.cpp (#582) 
The dialogs/folder_options.cpp source file in shell32 is too big to manage. We will split it to smaller files.
CORE-12906
 2018-06-06 14:04:50 +02:00
Katayama Hirofumi MZ 222534a5a2 [SHELL32] Fix and improve the PickIconDlg function (#574) 
CORE-10972
 2018-05-31 15:33:07 +02:00
Katayama Hirofumi MZ 5187ec858f [SHELL32] Implement the 'Advanced' button of the 'File Types' dialog (#565) 
This allows the user to edit the File Type / extension information by clicking 'Advanced' button in the 'File Types' property sheet of Folder Options.
CORE-12906, CORE-10972
 2018-05-30 17:22:31 +02:00
Serge Gautherie 3ca1ac639c [REACTOS] Improve/Fix some "printf" formats (#555) 
The smbios.c one was initially spotted by "Alahndro" on CORE-6328.
 2018-05-30 14:18:23 +02:00
Katayama Hirofumi MZ ed1c6bb006 [SHELL32] Add icons to the 'File Types' listview (#557) 
This commit adds icons to the listview of the 'File Types' property sheet of Folder Options.
CORE-12906
 2018-05-23 23:25:11 +02:00
Katayama Hirofumi MZ 82a5983504 [SHELL32] Allow deleting a file type/extension (#553) 
CORE-12906
 2018-05-19 16:12:11 +02:00
Adam Słaboń 72ad0fe70b [TRANSLATION] Polish translation update (#554) 
- Added translations for cmdutils (at, clip, comp, eventcreate, mode, taskkill, wmic) and zipfldr.
- Updated translations for cmdutils (reg), drwtsn32, mmc, eventvwr, shell32 and cpl applets (console, input).
 2018-05-19 13:17:49 +02:00
Katayama Hirofumi MZ bfb19dd251 [SHELL32] Fix usage of DeferWindowPos (fix of #544) (#552) 2018-05-18 22:27:22 +02:00
Katayama Hirofumi MZ f20bdf1994 [SHELL32] Add 'Create New Extension' IDD_NEWEXTENSION dialog (#544) 
A 'Create New Extension' dialog is implemented, which enables the user to add a new file extension.
CORE-12906
 2018-05-18 12:47:52 +02:00
Katayama Hirofumi MZ 2e96d85133 [SHELL32] In #543, I forgot sq-AL.rc and sv-SE.rc 2018-05-12 17:09:59 +02:00
Katayama Hirofumi MZ 2b0238a48a
[shell32] add some control IDs for IDD_FOLDER_OPTIONS_FILETYPES 2018-05-12 13:47:09 +02:00
Hermès Bélusca-Maïto 34b0f3e4f8
[BOOTDATA][SHELL32] Add some recognized file extensions (.db, .efi, .nls, .ocx, .tlb, .nt), and update some reported MIME types. 
CORE-11308
 2018-05-05 22:20:21 +02:00
Hermès Bélusca-Maïto bf88116252
[SHELL32] Fix the layout of the Run/Execute dialog for many languages. 
French fix covers CORE-12548.
 2018-05-01 17:45:03 +02:00
Mark Jansen b569195ecf
[SHELL32] Partially sync SHGetFileInfo with wine to improve folder type names. 
CORE-14542
 2018-04-22 17:38:44 +02:00
Mark Jansen e8dcbcc61d
[SHELL32] Sync CShellDispatch and family with wine. 
Incorporates work from Ivan Rodionov.
CORE-12955
 2018-04-14 15:47:13 +02:00
Joann Mõndresku 6522bb42df [TRANSLATION][SHELL32] Corrected mistakes 2018-04-10 22:49:16 +02:00
Mark Jansen a69393205a
[SHELL32] Partially implement SHCreateFileExtractIconW 
CORE-14082
 2018-04-07 15:29:58 +02:00
Mark Jansen 0d07967a27
[SHELL32] Initial partial IShellFolderViewCB implementation. 2018-04-07 15:29:53 +02:00
Robert Naumann 69acbe905a
Update German translation (#438) 
* [BROWSEUI] Update German translation

* [SHELL32] Update German translation

* [COMCTL32] Update German translation

* [COMDLG32] Update German Translation

* [SETUPAPI] Update German translation

* [EXPLORER] Update German translation
 2018-03-17 22:48:16 +01:00
Thomas Faber 0aed0fd167
[BROWSEUI][SHELL32] Treat OnWinEvent's result parameter as optional. CORE-14443 
Windows's explorer can call it with NULL.
 2018-03-08 12:21:24 +01:00
Pierre Schweitzer da8a41b97b
[SHELL32] Fix a directory handle leak when browsing folders 
A bit of history: in r71528, I tried to fix our explorer often
crashing while browsing directories. It was linked to the fact
that a notification result may arrive while the notification
structure had already been deleted.

The fix for this was actually broken and was leading to a double
leak: the notification structure was leaked. But also the handle
to the directory that had been browsed!
This means that the directory couldn't be modified anymore as
a leaked handle to it was still open.

Actually, when notifications are cancel, the kernel properly
calls the notification routine, but with a specific error code.
So the correct fix is to stop handling that notification when
we receive this error code. This is the correct fix with no leaks.

This commit is a complete r71528 revert with the appropriate fix.

CORE-10941
CORE-12843
 2018-03-06 20:30:21 +01:00
Katayama Hirofumi MZ 1f4c636453 [SHELL32] Fix item order in Folder Options (#415) 2018-03-05 23:40:41 +01:00
Timo Kreuzer 0182dcd71b [PSDK][REACTOS] Fix definitions and usage of DWLP_MSGRESULT, DWLP_DLGPROC, and DWLP_USER 
- Make sure the DWLP_* values are correct on _WIN64
- Don't use the DWL_* constants, they are not portable. Enforce this by removing them entirely from winuser.h
- Make sure Get/SetWindowLong*Ptr* is used and pointers are not truncated to LONG
 2018-03-04 16:27:07 +01:00
Adam Słaboń 8fd9d3f59b [TRANSLATION] Polish translation update (#413) 
Translation update for sndvol32, shell32 (right click drag menu), rapps and ks.inf.
 2018-03-03 21:24:46 +01:00
Giannis Adamopoulos 5b38fed776 [SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194 
It seems that TBN_DELETINGBUTTON isn't called when the toolbar gets destroyed so the only way to avoid leaking the data is emptying it ourselves.
 2018-02-23 12:27:48 +02:00
Thomas Faber b8741e2bb3 [SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194 2018-02-22 11:53:34 +01:00
Giannis Adamopoulos 3263303844 [SHELL32] CShellItem: Fix GetDisplayName and Compare 
The two methods were completely broken because they passed a full pidl to the parent folder (and not desktop folder).
Compile SHGetNameFromIDList to use it in CShellItem but don't export it.
 2018-02-20 16:59:00 +02:00
Giannis Adamopoulos 9d7313273c [SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on wine 
Fixes lots of tests.
 2018-02-20 16:33:30 +02:00
Giannis Adamopoulos af97de39a2 [SHELL32] CShellItem: Fix return value of Compare method 2018-02-20 14:36:31 +02:00
Giannis Adamopoulos c361e475b4 [SHELL32] CDefaultContextMenu: Implement GetCommandString 2018-02-20 13:05:59 +02:00
Giannis Adamopoulos 7e48c20b3b [SHELL32] Fix a couple of tests 2018-02-20 11:48:40 +02:00
Giannis Adamopoulos ac950ea01d [SHELL32] shellpath: sync a part of _SHGetDefaultValue with wine 
on 32bit builds CSIDL_PROGRAM_FILESX86 is treated as CSIDL_PROGRAM_FILES and on wow64 builds CSIDL_PROGRAM_FILES gets treated as CSIDL_PROGRAM_FILESX86
 2018-02-20 10:58:14 +02:00
Giannis Adamopoulos 730d81b9f7 [SHELL32] Fix some test failures 2018-02-20 10:15:23 +02:00
Giannis Adamopoulos 48d88a3617 [SHELL32] CFSFolder: Fix some tests for GetAttributesOf 2018-02-19 02:01:02 +02:00
Giannis Adamopoulos fd209faa66 [SHELL32] CFSDropTarget: style fixes 2018-02-17 22:01:04 +02:00
Giannis Adamopoulos 4b19b1e49d [SHELL32] CDefView: remove a useless print 2018-02-17 21:40:16 +02:00
Giannis Adamopoulos 6f25b42a31 [SHELL32] CFSDropTarget: Use copy depending on the source drive 
Show the default action as the default menu item in the right click menu.
 2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 6d91269eda [SHELL32] CFSDropTarget: Initial implementation of right click drag menu 2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 8f8ab050db [SHELL32] CDefView: Implement several methods needed for drop targets 
Set the view object as the site of the drop target.
Implement GetItemPosition, SelectAndPositionItems, IsDropOnSource, GetDragPoint.
Use DROPEFFECT_COPY only when the item supports it.
 2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 5bef945cc9 [SHELL32] Add menu resource which is used when dragging files with right click 2018-02-17 20:30:37 +02:00
Hermès Bélusca-Maïto 175e78e50f
[SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes. 2018-02-16 23:31:39 +01:00
Katayama Hirofumi MZ 338799bf8b improve SHGetFileInfo (#118) 
This patch reduces failures of SHGetFileInfo function. CORE-7159
* improve WideByteToWideChar calls
* fix bugs related to file attributes and SHGFI_EXETYPE
* SHGFI_USEFILEATTRIBUTES and SHGFI_ICON fix
* s/sizeof(temppsfi)/0/
 2018-02-16 11:00:08 +00:00
Hermès Bélusca-Maïto fe4704fa64
[SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
Giannis Adamopoulos 67f99833cd [SHELL32] CNewMenu: Don't use CWM_GETISHELLBROWSER. 
CDefaultContextMenu: Set the site for context menu extensions
CNewMenu: Get SID_IFolderView service of the site to get the IShellView
 2018-02-15 00:58:22 +02:00
Giannis Adamopoulos b97886ea9f [SHELL32] Fix the toolbar buttons in the file open dialog 
CDefView: Make GetItemObject return an IContectMenu after setting itself as the site.
CDefViewBckgrndMenu: Make the inner context menu use the same site. Implement handling CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA.
CDefaultContextMenu: CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA shouldn't be handled in this class.
Fixes CORE-14327 and the two buttons that change the view mode
 2018-02-15 00:23:18 +02:00
Joachim Henze e4aa45f63a [SHELL32] Fix glitch in de-DE.rc 
checkbox captions are too long.
issue was introduced by 3624c5d6fd

fixes CORE-14329 for de-DE
 2018-02-14 20:12:10 +01:00
Giannis Adamopoulos 111c40e012 [SHELL32] CDefViewBckgrndMenu: Fix handling string verbs. 
It shouldn't be necessary for QueryContextMenu to be called before InvokeCommand.
Move retrieving the IContextMenu of the folder to the initialization of the class.
CORE-12866
 2018-02-14 00:03:35 +02:00
Mark Jansen 058c2658a4 [SHELL32] CDefViewBckgrndMenu: Fix a crash when pasting on a new explorer window. 2018-02-05 17:39:32 +01:00
Hermès Bélusca-Maïto 131678a025
[SHELL32] Rewrite the wrapping code for shell taskbar notifications. 
- Introduce the TRAYNOTIFYDATAW structure, as documented by Geoff
  Chappell in "WM_COPYDATA for Taskbar Interface", at
  http://www.geoffchappell.com/studies/windows/shell/shell32/api/shlnot/copydata.htm
  that is the data structure passed between shell32 and explorer for
  communicating shell notify icon information.

- In Shell_NotifyIcon(), correctly capture the (ANSI and) UNICODE
  structures provided by the caller, properly taking into account for
  the different NOTIFYICONDATA structure sizes existing out there.
  The different strings are now properly null-terminated (especially
  szTip if it needs to be truncated out), and the flags validated.

- Remove the now unneeded "SHELL_NotifyIcon()" helper function.

[EXPLORER] Use TRAYNOTIFYDATAW and adjust the callers.
 2018-02-04 18:11:50 +01:00
Hermès Bélusca-Maïto 5ecabcce59
[SHELL32] Fix copy-pasta. 2018-02-04 01:56:56 +01:00
Stanislav Motylkov 3624c5d6fd [SHELL32] Fix file and folder properties dialogs 
CORE-12755
 2018-01-31 18:25:14 +01:00
Thomas Faber 682735fb56
[SHELLMENU] Add missing psdk dependency. 2018-01-31 11:48:37 +01:00
Luo Yufan 7082b621a5 [TRANSLATION] Simplified Chinese translation improved. (#346) 2018-01-30 21:49:40 +01:00
Luo Yufan 09168aae12 [TRANSLATION] Update Simplified Chinese Translations of SHELL32 and USRMGR (#340) 2018-01-29 18:21:20 +01:00
Joann Mõndresku d80ef2c90a [TRANSLATION] Various translations to Estonian (#329) 
Estonian translations for shell + explorer, cpl files (access, appwiz, desk, timedate), devmgr, browseui, comctl32, aclui, avifil32, comdlg32 and credui.
 2018-01-29 17:03:27 +01:00
Adam Słaboń fbcf05062e [TRANSLATION] Polish translation update (#328) 2018-01-27 13:21:22 +01:00
Kamil Smoliński 00ed9fc88b [SHELL32] Fix typo in Polish translation pl-PL.rc 2018-01-21 19:13:57 +01:00
Giannis Adamopoulos 6d9a0d0fd4 [SHELL32] CDrivesFolder: Fix showing the drive capacity. CORE-14201 2018-01-13 21:27:57 +02:00
Giannis Adamopoulos 5618b33c3b [SHELL32] CMenuBand: Redraw the toolbars if this is the menu bar of a window and its active state changed. Use COLOR_GRAYTEXT for the text of the inactive menu bar items. CORE-14197 2018-01-13 14:57:24 +02:00
Erdem Ersoy ba3f074320 [TRANSLATIONS] Update the email address and add a note in the Turkish translation document (#271) 2018-01-07 22:09:42 +01:00
Luo Yufan 59aa6b9e74 [TRANSLATION] Improve Simplified Chinese Translations (#265) 
* Update Simplified Chinese translation of SYSSETUP
* Update Simplified Chinese translations and font settings.
* Update Translation of SHELL32.
 2018-01-05 14:15:03 +01:00
Giannis Adamopoulos a671923037 [SHELL32] CMenuToolbarBase: Use COLOR_MENUTEXT color for the text color in normal menu items. CORE-13855 2018-01-05 11:53:35 +02:00
Luo Yufan 2524a0b636 [TRANSLATIONS] Simplified Chinese translation update. #251 2018-01-02 18:39:24 +01:00
Thomas Faber b20280a0f9
[CMAKE] Allow overriding the .dll extension for delay imports in MSVC builds. 
Fixes delay-importing winspool.drv.
 2018-01-01 19:05:30 +01:00
Timo Kreuzer a2f7de7ee8
Amd64/misc 64bit fixes (#236) 
[REACTOS] Misc 64 bit fixes

* [NTOS:MM] Allow MEM_DOS_LIM in NtMapViewOfSection on x64 as well
* [NTOS:MM] Implement x64 version of MmIsDisabledPage
* [HAL] Remove obsolete code
* [NTOS:KE] Fix amd64 version of KeContextToTrapFrame and KeTrapFrameToContext
* [XDK] Fix CONTEXT_XSTATE definition
* [PCNET] Convert physical address types from pointers to PHYSICAL_ADDRESS
 2018-01-01 12:07:50 +01:00
Hermès Bélusca-Maïto 9fa693e59b
[REACTOS] Switch to year 2018... 
... and Happy New Year 2018 to everyone!!

☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆

  ⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰
░░░░░░█░█ █▀█ █▀█ █▀█ █░█░░░░░░
░░░░░░█▀█ █▀█ █▀▀ █▀▀ ▀█▀░░░░░░
░░░░░░▀░▀ ▀░▀ ▀░░ ▀░░ ░▀░░░░░░░
█▄░█ █▀▀ █░█░█░░█░█ █▀▀ █▀█ █▀█
█░██ █▀▀ █░█░█░░▀█▀ █▀▀ █▀█ ██▀
▀░░▀ ▀▀▀ ░▀▀▀░░░░▀░ ▀▀▀ ▀░▀ ▀░▀
  ⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰
░░░▄████▄░▄███▄░░▄██░▄████▄░░░
░░░▀▀░▄██░██░██░████░██▄▄██░░░
░░░░▄██▀░░██░██░░░██░██▀▀██░░░
░░░██████░▀███▀░░░██░▀████▀░░░

☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆
 2018-01-01 00:00:00 +01:00
Katayama Hirofumi MZ 89f9c9101a
[TRANSLATION] Use correct font name in Korean resources, CORE-9566 (#228). 
Localized resources should use the correct Korean fonts that are most suitable
for UI and compatible with Windows.
 2017-12-29 01:51:15 +01:00
Katayama Hirofumi MZ 1ebe4a5b83
[TRANSLATION] Use correct font name in Chinese resources, Part 3/3, CORE-9566 (#223). 
Localized resources should use the correct Chinese font names compatible with Windows.
 2017-12-27 16:11:21 +01:00
Amine Khaldi a3797dba7a [SHELL32] Deduplicate MAX_PROPERTY_SHEET_PAGE and AddPropSheetPageCallback(). #179 2017-12-25 13:22:23 +01:00
Luo Yufan d6131ace49 [TRANSLATION] Improve Simplified Chinese Translations. 
* Fix Simplified Chinese Translation of EXPLORER.
* Fix Simplified Chinese Translation of MSCONFIG_NEW.
* Fix Simplified Chinese Translation of MSPAINT.
* Fix Simplified Chinese Translation of SHELL32.
* Fix Simplified Chinese Translation of SYSDM.
* Fix Simplified Chinese Translation of SETUP/REACTOS.
 2017-12-17 14:40:59 +01:00
Amine Khaldi e83592920b [SHELL32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-07 23:54:22 +01:00
Serge Gautherie 57aa1f1fc6
[SHELL32] shellpath.c: it is _WIN32_WINNT, not WIN32_WINNT. We even need to use __REACTOS__ instead here. CORE-12580 2017-12-03 21:52:37 +01:00
Stanislav Motylkov c2bdad2981 [SHELL32] Fix show properties with Alt+Enter 2017-12-02 18:10:43 +02:00
Katayama Hirofumi MZ 87d276f05d [SHELL32] Don't show error when closing disk prop sheet (#144) 
CORE-14035
 2017-11-25 11:27:20 +02:00
Pierre Schweitzer 63dcfd2de3
[SHELL32] Update French translation 2017-11-21 18:24:08 +01:00
Stanislav Motylkov f884d29c90 [SHELL32] Update Russian translation, following 6465705 2017-11-21 14:06:54 +02:00
Pierre Schweitzer 45b543202d
[SHELL32] Drop slash when dismounting a remote drive. MPR and NP are expecting a drive letter. 
This fixes dismounting a network drive using explorer.
 2017-11-18 21:27:30 +01:00
Pierre Schweitzer 0701527f20
[SHELL32] Update French translation, following 6465705 2017-11-18 18:56:59 +01:00
Katayama Hirofumi MZ 64657051c3 [SHELL32] CDrivesFolder: Implement the eject and disconnect menu items. CORE-13841 
- The items are shown only for the drives where they are applicable.
- May not work fully yet due to bugs in the drivers.
 2017-11-18 16:55:08 +02:00
Giannis Adamopoulos 78b78d6e73 [SHELL32] SHBrowseForFolderW: Fix creating directories in the desktop and in drives like C: CORE-13925 2017-11-05 12:11:10 +02:00
Giannis Adamopoulos dd4af77703 [SHELL32] SHBrowseForFolder: Fix creating a new folder (which was broken two years ago and was properly reported 3 days ago). CORE-13925 2017-11-03 12:12:58 +02:00
Manuel Bachmann 9192d39f6e [SHELL32] Fix multiple selection of desktop icons 
This fixes the following issue : when selecting multiple icons
on the desktop, and then right-clicking; the Properties sheet
would immediately be displayed, conflicting with the context
menu.
 2017-11-02 21:55:39 +02:00
Amine Khaldi fe6d46f86e [SHELL32] Properly set case -714 as TBN_DRAGOUT. CORE-11799 (#94) 2017-10-30 21:53:00 +01:00
Thomas Faber ba8f75557a
[SHELL32][REGEDIT][MSCONFIG_NEW] Correctly check for presence of list view sort header. 2017-10-29 22:00:18 +01:00
Amine Khaldi ce4ecd604d [SHELL32] Remove some unused members and comment out some unused Wine code. CORE-11799 (#94) 2017-10-27 23:51:44 +01:00
Giannis Adamopoulos d310df0dd2 [SHELL32] CDefView: Fix a leak of an HMENU. This fix is thanks to Joachim Henze who found the bug and quickly found the guilty revision. CORE-13911 2017-10-26 21:39:32 +03:00
Adam Słaboń 9c790dfc3b Polish translation update (#29) 
* Polish translation update
 2017-10-10 12:14:38 +02:00
Colin Finck 950c86fb4c Fix remaining text file line endings in the tree. (#18) 
Based on https://stackoverflow.com/a/1511273

Also enforce CRLF for all *.xml files in our tree, because they are distributed with ReactOS.
 2017-10-06 15:00:36 +02:00
Colin Finck c2c66aff7d Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00