reactos/dll/win32/shell32
Pierre Schweitzer da8a41b97b
[SHELL32] Fix a directory handle leak when browsing folders
A bit of history: in r71528, I tried to fix our explorer often
crashing while browsing directories. It was linked to the fact
that a notification result may arrive while the notification
structure had already been deleted.

The fix for this was actually broken and was leading to a double
leak: the notification structure was leaked. But also the handle
to the directory that had been browsed!
This means that the directory couldn't be modified anymore as
a leaked handle to it was still open.

Actually, when notifications are cancel, the kernel properly
calls the notification routine, but with a specific error code.
So the correct fix is to stop handling that notification when
we receive this error code. This is the correct fix with no leaks.

This commit is a complete r71528 revert with the appropriate fix.

CORE-10941
CORE-12843
2018-03-06 20:30:21 +01:00
..
dialogs [SHELL32] Fix item order in Folder Options (#415) 2018-03-05 23:40:41 +01:00
droptargets [SHELL32] CFSDropTarget: style fixes 2018-02-17 22:01:04 +02:00
folders [SHELL32] Fix a couple of tests 2018-02-20 11:48:40 +02:00
lang [TRANSLATION] Polish translation update (#413) 2018-03-03 21:24:46 +01:00
res [SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes. 2018-02-16 23:31:39 +01:00
shelldesktop
shellmenu [SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194 2018-02-23 12:27:48 +02:00
shellrecyclebin
wine [SHELL32] Fix a directory handle leak when browsing folders 2018-03-06 20:30:21 +01:00
avi_res.rc
bitmap_res.rc
CDefaultContextMenu.cpp [SHELL32] CDefaultContextMenu: Implement GetCommandString 2018-02-20 13:05:59 +02:00
CDefView.cpp [SHELL32] CDefView: remove a useless print 2018-02-17 21:40:16 +02:00
CDefViewBckgrndMenu.cpp [SHELL32] Fix the toolbar buttons in the file open dialog 2018-02-15 00:23:18 +02:00
CDefViewDual.cpp
CDropTargetHelper.cpp
CDropTargetHelper.h
CEnumIDListBase.cpp
CEnumIDListBase.h
CExtractIcon.cpp
CFileSysBindData.cpp
CFolder.cpp
CFolder.h
CFolderItems.cpp
CFolderItems.h
CFolderItemVerbs.cpp
CFolderItemVerbs.h
CFolderOptions.cpp
CFolderOptions.h
CIDLDataObj.cpp
CMakeLists.txt [SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
CNewMenu.cpp [SHELL32] CNewMenu: Don't use CWM_GETISHELLBROWSER. 2018-02-15 00:58:22 +02:00
CNewMenu.h [SHELL32] CNewMenu: Don't use CWM_GETISHELLBROWSER. 2018-02-15 00:58:22 +02:00
COpenWithMenu.cpp
COpenWithMenu.h
CQueryAssociations.cpp
CQueryAssociations.h
CShellDispatch.cpp
CShellDispatch.h
CShellItem.cpp [SHELL32] CShellItem: Fix GetDisplayName and Compare 2018-02-20 16:59:00 +02:00
CShellItem.h [SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on wine 2018-02-20 16:33:30 +02:00
CShellLink.cpp [PSDK][REACTOS] Fix definitions and usage of DWLP_MSGRESULT, DWLP_DLGPROC, and DWLP_USER 2018-03-04 16:27:07 +01:00
CShellLink.h
CUserNotification.cpp [SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
CUserNotification.h [SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
debughlp.cpp
debughlp.h
folders.cpp [SHELL32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-07 23:54:22 +01:00
icon_res.rc
iconcache.cpp
precomp.h [SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
rgs_res.rc [SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
shell32.cpp [SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
shell32.rc [TRANSLATION] Various translations to Estonian (#329) 2018-01-29 17:03:27 +01:00
shell32.spec
shell32_shldisp.idl
shell32_version.h
shell32_version.rc
shfldr.h
shlexec.cpp
shlfileop.cpp
shlfolder.cpp
shobjidl_local.idl
shresdef.h [SHELL32] Add menu resource which is used when dragging files with right click 2018-02-17 20:30:37 +02:00
stubs.cpp
systray.cpp [SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
vista.c