Commit graph

1880 commits

Author SHA1 Message Date
Stanislav Motylkov 68f9fd2f5d
[SHELL32] Fix dialog labels in Recycle Bin properties page (#2676)
Also fix remaining "Max size" edit box positions.

Addendum to e6e45b3. CORE-16972
2020-04-27 16:03:27 +03:00
Kyle Katarn e6e45b34cc
[SHELL32] Fix "Max size" Edit box position in Recycle Bin properties page (#2676)
CORE-16972
2020-04-27 12:48:26 +02:00
Kyle Katarn 7c4788695f
[NETID] Fix incorrect component position and size, complete French translation (#2672)
- Missing fr-fr translation for some items
- Wrong components size and/or position to fully display text

CORE-16597

- Complete fr-fr translation of associated .rc file
- Fix of component design (size, location, BS_MULTILINE).

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-27 12:44:27 +02:00
Piotr Hetnarowicz 3efe1596a5
[RASDLG] pl-PL update (#2675) 2020-04-27 13:38:27 +03:00
Oleg Dubinskiy 70b6658af8
[PROFMAP] Initial implementation (#2119)
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
2020-04-26 21:15:21 +02:00
Oleg Dubinskiy 9f0a0f65ea [SHLWAPI] Add version limit for export from NT 5.1 to NT5.2, because it was dropped since NT6
Co-Authored-By: Serge Gautherie <32623169+SergeGautherie@users.noreply.github.com>
2020-04-26 20:20:40 +02:00
Oleg Dubinskiy ee08399112 [SHLWAPI] Improve SHEvaluateSystemCommandTemplate export CORE-14742 2020-04-26 20:20:40 +02:00
Andreas Maier f95c96e207 [MSV1_0] Create stubs for SECPKG_FUNCTION_TABLE (SpLsaModeInitialize)
This commit fixes a bug too.
Old code of SpLsaModeInitialze returns a pointer to a local variable (SECPKG_FUNCTION_TABLE).
2020-04-26 17:26:17 +02:00
Serge Gautherie a16a37fd2d
[RPCRT4] Fully WineSync spec file. CORE-16441 (#2494)
* [RPCRT4] Export NdrServerCallAll stub

Addendum to 6feb8748d3.

Import rest of
e54224e88c

With thanks to Hermès B., who noticed it is 64bit only.

CORE-16441

* [RPCRT4] Fix NdrServerContextMarshall spec file entry

Addendum to 6feb8748d3.

Import
660ee356e9

CORE-16441

* [RPCRT4] Fix RpcNetworkIsProtseqValid[AW] spec file entries

Cherry-pick
6127c688ea
2020-04-26 17:23:13 +02:00
Katayama Hirofumi MZ 771457f37f
[SHELL32] Implement VK_DELETE on SHBrowseForFolder (#2661)
Enable Del/Delete key to delete the selected folder in "Browse for Folder" dialog.
You can use https://jira.reactos.org/secure/attachment/40118/getfolder.zip as a test program.
CORE-7592
2020-04-26 22:06:19 +09:00
Serge Gautherie a7e4d66be5 [SHELL32] DoGetProductType(): Use RegGetValueW()
instead of RegQueryValueExW(), to enforce a null terminator.

Addendum to 9f4e8ef25b.
2020-04-26 14:16:59 +02:00
Saibamen 79c932078d
[SHIMGVW] Update Polish translation (#2666)
After PR #2606
2020-04-26 13:56:46 +02:00
Katayama Hirofumi MZ c04010c9ad [SHELL32] Update name in CDefView::LV_RenameItems 2020-04-26 13:21:14 +03:00
Kyle Katarn ab4b001e94
[NETID] fr-fr translation fix and component size (#2586) 2020-04-26 11:54:42 +02:00
Kyle Katarn 52cd931f22
[POWERCFG] Power Scheme fix as per CORE-16893 (#2593)
Related to CORE-16900

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-26 10:20:22 +02:00
Kyle Katarn e15746849a
[DESK][THEMEUI] Update French translation (#2591)
Co-authored-by: Sylvain Deverre <deverre.sylv@gmail.com>
2020-04-25 18:34:41 +02:00
Kyle Katarn 9c682e4c16
[COMDLG32][REGEDIT] Fix display problems (CORE-16890) (#2638) 2020-04-25 10:41:01 +02:00
Kyle Katarn 07e80dead4
[SHELL32] Improve french translations 2020-04-25 10:38:35 +02:00
Katayama Hirofumi MZ d32858413d
[SHELL32] Command 'start C:' should open 'C:\' (#2642)
Based on JIRA user amaneureka's idea.
In SHELL_execute function, add a backslash for Drive "C:", "D:" or "E:" etc.
CORE-16384
2020-04-25 11:01:20 +09:00
Thomas Faber 3e9c4dad66
[WINDOWSCODECS] Use upstream Wine fix for 4bps BGRA TIFF. CORE-16796
Import Wine commits by Dmitry Timoshkov:
* 0cd8502b49 windowscodecs: Add support for 4bps RGBA format to TIFF decoder.
* 962bb99352 windowscodecs/tests: Add a separate test for 4bps BGRA TIFF format.
2020-04-24 14:56:26 +02:00
Victor Perevertkin 194ea909fd
[BTRFS][UBTRFS][SHELLBTRFS] Upgrade to 1.7.2
CORE-16679
2020-04-23 07:07:36 +03:00
Katayama Hirofumi MZ a48aa21102
[SENDMAIL][ZIPFLDR][MYDOCS] Fix creation of SendTo files (#2616)
- Improve and move SendTo files creation code and timing.
- Delete IDS_DESKLINK of shell32.
- Add IDS_DESKLINK into sendmail.
CORE-16924
2020-04-23 04:19:20 +09:00
Hermès Bélusca-Maïto 7c3e96a26a
[TIMEDATE.CPL][SYSSETUP][TZLIB] Introduce a small static library "tzlib": "TimeZone Utilities Library", and use it in timedate.cpl and syssetup.dll.
This small win32 library provides time-zone utility wrappers around
Win32 functions, that are used by different ReactOS modules such as
timedate.cpl, syssetup.dll, and a possible future 'tzutil' tool.

The code has been extracted from the common code found in both
timedate.cpl and syssetup.dll.
2020-04-22 00:58:32 +02:00
Jose Carlos Jesus 181ed94e22
[SHELL32] Fix grammar mistake in portuguese translation (#2605) 2020-04-21 16:38:23 +03:00
Katayama Hirofumi MZ 0950ae26d3 [SHIMGVW] Improve Japanese translation 2020-04-21 19:11:58 +09:00
Kyle Katarn dd0f498c01
[SHIMGVW] Update French translation (#2610)
Addendum to 3926e9b. CORE-16911
2020-04-21 03:18:55 +03:00
Stanislav Motylkov c6abe80af5
[SHELL32] Update Russian translation
Addendum to c82ba34.
2020-04-21 00:38:42 +03:00
Stanislav Motylkov 5ac8d90e57
[SHIMGVW] Update Russian translation
Addendum to 3926e9b. CORE-16911
2020-04-21 00:30:22 +03:00
Stanislav Motylkov 2bd4081936
[BROWSEUI] Update Russian translation
Addendum to d8e47d6. CORE-10989
2020-04-21 00:24:23 +03:00
Charles Ambrye 8c4bd09518 [SHELL32] Fix a bug that caused Auto Arrange to always be highlighted in the file explorer
This occurred in the file explorer because the menu isn't destroyed and recreated each time, so the menu item, once checked, will stay checked forever.  We must call CheckMenuItem with MF_UNCHECKED to clear the check when necessary
2020-04-20 23:13:09 +03:00
Charles Ambrye c82ba3485e [SHELL32] Modify context menu to include Align To Grid, and remove Line Up Icons
Implement support for using Align To Grid, which itself simply sets the LVS_EX_SNAPTOGRID extended style of the list view control
2020-04-20 23:13:09 +03:00
Charles Ambrye 733a32dade [LISTVIEW] Add basic support for LVS_EX_SNAPTOGRID 2020-04-20 23:13:09 +03:00
Kyle Katarn fbee8fa99e
[BROWSEUI] fr-fr translation update following PR2602 (#2611)
* PR2602 fr-fr update
* typo following sdever review
2020-04-20 19:21:36 +02:00
Julen Urizar Compains 6100c8e268
[TRANSLATION][SHIMGVW] Spanish IDS_NOPREVIEW (#2609) 2020-04-21 02:00:43 +09:00
Ioannis Adamopoulos 0d077c3068 [SHELL32] CDesktopFolder::GetUIObjectOf: fix crash when requested to create a IID_IContextMenu for 0 items.
* Tests show that we should return a valid object even in this case.
2020-04-20 17:37:03 +03:00
Mark Jansen d2b91deb33 [SHELL32] CMyDocsFolder: Ensure the object can be used without calling Initialize 2020-04-20 17:36:44 +03:00
Mark Jansen 6a6a28b634 [SHELL32] Ensure CIDLDataObject::GetData always returns an STGMEDIUM that is safe for use with ReleaseStgMedium 2020-04-20 17:36:43 +03:00
Katayama Hirofumi MZ 3926e9b3c8
[SHIMGVW] Consider failure case of loading file (#2606)
If loading an image file failed, then properly handle it. The command line is rundll32 shimgvw.dll,ImageView_Fullscreen .
CORE-16911
2020-04-20 21:05:14 +09:00
Charles Ambrye d8e47d61d4 [BROWSEUI] Display an error message if the path or drive don't exist (CORE-10989)
The return result of ParseNow was never checked, but contained useful information on what type of error may have occurred.  If the error is an issue with the path not existing the explorer will now show an error message notifying the user of the problem instead of silently failing.
Note:  Shell32 does not properly return ERROR_INVALID_DRIVE when the drive path does not exist.  For that reason, it is still possible to browse to a non-existent drive.  However, once shell32 is patched this code will work properly, as it checks for both ERROR_INVALID_DRIVE and ERROR_FILE_NOT_FOUND.
2020-04-20 14:21:37 +03:00
Charles Ambrye b8f4f22ba2 [BROWSEUI] Attempt to parse absolute path even if relative path gets an unexpected failure
Some 'BindToObject' methods are incomplete, and in some cases relative paths are simply not possible (especially in special folders such as the desktop)
2020-04-20 14:12:47 +03:00
Joachim Henze 4af7888b29 [SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs
-Avoid text truncations regarding the checkbox
 in a uniform way
-Reduce chance of text truncations for a button
 in a uniform way
-Fix es-ES dlg layout and harmonize its dlg Size
 with other languages
-de-DE fix double accelerator
2020-04-20 02:08:45 +02:00
Joachim Henze c0d5e4fd6b [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs
-Some inspiration from de-DE which I improved years ago
-Avoid text truncations and control overlapping that
 happened in almost all other languages
-Increase the size of the listView for all except es-ES & pt-PT
-es-ES & pt-PT had different dlgs sizes, I only slightly tweaked
 those therefore
-In sum this brings the RCs much closer to each other

-Unrelated: fix a white-space-typo we had in some but not all RCs
2020-04-19 21:33:13 +02:00
Jose Carlos Jesus 77b12181a5
[TRANSLATION] New Portuguese translation (#2588)
* [TRANSLATION] New PT translation to inetcpl

* [TRANSLATION] Fix SUBLANG in file cpl/joy/lang/pt-PT.rc to SUBLAG_NEUTRAL

* [TRANSLATION] New PT translation to cpl/mmsys/lang/pt-PT.rc

* [TRANSLATION] Fix SUBLANG in cryptui_Pt.rc file
2020-04-18 23:49:35 +02:00
Piotr Hetnarowicz f1a01694bd
[COMDLG32] Polish translation dialog layout fix (#2570) 2020-04-18 19:21:15 +02:00
Piotr Hetnarowicz b54f9b7f06
[OLEACC] Polish translation update (#2569) 2020-04-18 19:20:45 +02:00
Piotr Hetnarowicz 00ad81d4c4
[OLEDLG] Polish translation dialog fix (#2568) 2020-04-18 19:20:29 +02:00
Joachim Henze db8ba3548e [NETID] CORE-16594 fr-FR Avoid text truncations 2020-04-18 01:26:09 +02:00
Mark Jansen 2ed06c9588
[DBGHELPHOST] Add IMAGE_DIRECTORY_ENTRY_LOAD_CONFIG 2020-04-17 17:47:24 +02:00
Charles Ambrye 963d39bf66 [COMCTL32] Implement a simple version of snap to grid for listview 2020-04-17 13:23:29 +03:00
Charles Ambrye 1bee97358e [SHELL32] Pass LVA_SNAPTOGRID to listview when 'Line up Icons' is selected 2020-04-17 13:23:29 +03:00
Charles Ambrye 08364d08c7 [COMCTL32] Do not allow user to move icons when in auto-arrange mode 2020-04-17 13:23:29 +03:00
Joachim Henze 2b53e33554 [BROWSEUI] CORE-16810 de-DE Translation of "Search Results" titlebar 2020-04-17 09:43:40 +02:00
Piotr Hetnarowicz 3c1c303b2f
[NETID] Update Polish translation (#2559)
Co-authored-by: Adam Słaboń <asaillen456esx@gmail.com>
2020-04-16 23:25:03 +02:00
Piotr Hetnarowicz 458c155c2e
[DEVMGR] Polish translation update (#2554) 2020-04-16 19:25:01 +02:00
Stanislav Motylkov 173a2af48c
[SYSSETUP] Update authors page in second stage setup
Fix layout issues in different languages. CORE-16874
2020-04-16 18:57:14 +03:00
Victor Perevertkin 7e069ccdb2
[CMAKE] Replace custom functions to built-in ones
add_target_compile_definitions -> target_compile_definitions
add_target_compile_flags -> target_compile_options
add_target_include_directories -> target_include_directories
2020-04-16 15:59:38 +03:00
Stanislav Motylkov 480f729f6d
[BROWSEUI] Fix build. Addendum to ac29d29.
CORE-16810
2020-04-16 14:16:48 +03:00
Stanislav Motylkov ac29d29297
[BROWSEUI] Localize "Search Results" shell folder name
Also update French and Russian translations. CORE-16810
2020-04-16 14:10:24 +03:00
Stanislav Motylkov edc66fdc22
[SHELL32] Update Russian translation
CORE-16873
2020-04-16 13:40:49 +03:00
Piotr Hetnarowicz abd6954d6a
[SHELL32] Update Polish translation (#2364) 2020-04-16 13:24:17 +03:00
Piotr Hetnarowicz 83cbab9300
[MSGINA] Update Polish translation (#2362)
Co-Authored-By: Adam Słaboń <asaillen456esx@gmail.com>
2020-04-16 11:09:22 +03:00
Oleg Dubinskiy 7865ff97cc
[SFC][SFC_OS] Add stubs to exported functions (#2431)
- Also remove extra whitespace between function names and their arguments in sfc.
- Required by userenv.dll, win32k.sys, and others from Windows Server 2003 and also by some MS installers like Windows Media Encoder 7.1 installer. Now they should not fail due to that functions.

CORE-16458
2020-04-16 02:06:22 +03:00
Oleg Dubinskiy 2d8b224d71
[WINSTA] Add some missing stubs (#2307)
Add stubs for WinStationCanLogonProceed() and _WinStationOpenSessionDirectory() functions to make winlogon from Windows Server 2003 happy.

CORE-15392 CORE-16458
2020-04-16 01:50:22 +03:00
Stanislav Motylkov ea298746db
[SHELL32][BROWSEUI] Update Russian translation
Addendum to 033f0d9. CORE-16866
2020-04-16 00:10:12 +03:00
Joachim Henze 2032c3afba [SHELL32] CORE-12294 File & folder properties dialog fr-FR & de-DE resource
Avoids text truncation for french
Improves checkboxes alignment for german
2020-04-15 14:45:48 +02:00
Julen Urizar Compains d7a632a094
[TRANSLATION] Spanish minor fixes (#2547)
Translations for:
- Applications: clipbrd, dxdiag, rapps,
- cmdutils: attrib, find, help, label, reg, xcopy
- usetup
- dlls: browseui, shell32, syssetup

- Add Spanish translation for Accesibility Utility (utilman).

Update for the "Choose product options" strings in syssetup:

Originally "ProductType" and "ProductSuite" (typesetted without spaces) were the registry value names where these settings would go, but since it's meaningless to show these values it's better instead to use human-readable names with correct translation and spacing.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-15 13:27:36 +02:00
Serge Gautherie f540b2b20c
[IPHLPAPI] GetAdaptersAddresses(): Add 1 free() in ERROR_NO_DATA case (#2526)
And fix 4 comments.
Follow-up to 68d94581.
2020-04-15 13:05:54 +02:00
Erkin Alp Güney 1769793bd1
[SYSSETUP] Added a flag for mandatory password (#2500)
Use a human-readable #define flag 'PASSWORDS_MANDATORY' instead of the #if 0.
See also CORE-8038.
2020-04-15 12:50:36 +02:00
Stanislav Motylkov 033f0d998a [SHELL32] Add Russian translation (#2548)
CORE-16866
2020-04-15 12:38:27 +02:00
Thomas Faber f4a8d3d704
[WINDOWSCODECS] Avoid buffer underflow in TiffFrameDecode_ReadTile. CORE-16796 2020-04-13 18:18:35 +02:00
Eric Kohl 69e565891d [SHELL32] No french translation from "right click drag'n'drop"
CORE-16815
2020-04-13 15:41:13 +02:00
Eric Kohl c037278c5f [SHELL32] Fix missing french translation for "Command prompt here"
CORE-16855
2020-04-13 15:27:47 +02:00
Eric Kohl 16a4fc76de [DEVMGR] Do not add the 'Resources' page to the device properties if the device does not have any resources 2020-04-13 12:33:58 +02:00
Katayama Hirofumi MZ 5af2570b37 [SHELL32] Follow-up No.3 of #2539
Improve a comment in CreateNotificationParamAndSend.
CORE-13950
2020-04-13 13:19:12 +09:00
Katayama Hirofumi MZ b76d053a30 [SHELL32] Follow-up No.2 of #2539
Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950
2020-04-13 13:06:15 +09:00
Katayama Hirofumi MZ bfe36e4f0d [SHELL32] Follow-up of #2539
Improve comment. CORE-13950
2020-04-13 10:41:26 +09:00
Katayama Hirofumi MZ 2727245c86
[SHELL32] Shell notify rework for simplicity and readability (#2539)
Shell change notification has been implemented in #2432. But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950
2020-04-13 10:36:24 +09:00
Mark Jansen b68749c727
[WINMM] Fix crashing winetest
CORE-16795
CORE-16806
2020-04-13 01:41:02 +02:00
Katayama Hirofumi MZ ddc1a46456 [SHELL32] Improve CChangeNotify::ShouldNotify more
Improved non-recursive cases.
CORE-13950
2020-04-11 11:55:06 +09:00
Katayama Hirofumi MZ 2a32094aa0 [SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify
CORE-13950
2020-04-11 09:27:45 +09:00
Katayama Hirofumi MZ 2a6bccb4ce [SHELL32] Make "Unable to get notification window" quiet
CORE-13950
2020-04-11 08:45:23 +09:00
Eric Kohl de5f67726b [DEVMGR] Remove ATLASSERTs from ListDevicesByType and RecurseChildDevices
Suggested by Mark Jansen. Thanks!
2020-04-10 20:58:02 +02:00
Katayama Hirofumi MZ d04f2e5209
[BROWSEUI] Add 'm_' prefix to CExplorerBand members (#2524)
Add 'm_' prefix to the variable members of class CExplorerBand for readability.
CORE-13950
2020-04-10 23:08:31 +09:00
Katayama Hirofumi MZ 60959e34aa [SHELL32] Simplify CChangeNotify::ShouldNotify
CORE-13950
2020-04-10 21:57:58 +09:00
Katayama Hirofumi MZ 59c48a5d33 [SHELL32] Improve CChangeNotify::ShouldNotify
Shell change notification was not sent to My Documents.
CORE-13950
2020-04-10 21:51:22 +09:00
Jérôme Gardou 68d94581ad [IPHLPAPI] Do not use free() on buffer allocated with HeapAlloc 2020-04-10 12:06:53 +02:00
Serge Gautherie 745cb1cbda
[SHELL32] Fix SHCNE_UPDATEITEM number of items (#2409)
Import
83acbb79c1

Related to CORE-13950
2020-04-09 19:42:00 +02:00
Bișoc George 28e277b65f
[MSGINA] Redraw only the animation bar scroll (#2518)
Invalidating and updating the whole window is a waste of computation resources and may cause certain controls notably the text string control to flicker. So instead, just invalidate the specific portion of the client area which is the animation bar.
2020-04-09 19:06:00 +02:00
Serge Gautherie a5a426f867
[MSGINA] gui: Remove superfluous DLG_DATA.TimerID (#2505)
And use a timer ID define, with a positive value; report SetTimer() failure.
2020-04-09 18:54:15 +02:00
Mas Ahmad Muhammad b8dd046ee4
[TRANSLATION] Add and update Indonesian translations (#2506)
- CMDUTILS: attrib, label (update translation)
- USETUP (add translation)
- HOTPLUG (add translation)
- CONSRV  (update translation)
- USERSRV (update translation)
- USER32  (update translation)
- ACLUI  (update translation)
- LICCPA  (update translation)
- SUBST  (update translation)
- REGSVR32  (update translation)
- REGEDIT-CLB  (update translation)
- ACPPAGE  (update translation)
- TIMEDATE  (update translation)
- SOLITAIRE  (update translation)
- FDEBUG  (update translation)
- SYSSETUP (update translation)
2020-04-09 18:49:45 +02:00
Joachim Henze bf342653df [SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file) 2020-04-09 18:17:06 +02:00
Katayama Hirofumi MZ 1c706d7483
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save (#2515)
- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391
2020-04-09 16:56:54 +09:00
Katayama Hirofumi MZ 0903c645a2 [SHELL32] Follow-up of #2432
Fixed hang of FireFox.
2020-04-09 08:19:47 +09:00
Katayama Hirofumi MZ 296192685b
[SHELL32] Implement shell change notification (#2432)
- Rewrite SHChangeNotify, SHChangeNotifyRegister, SHChangeNotify_Lock, SHChangeNotify_Unlock and SHChangeNotifyDeregister functions.
- Fix SHSimpleIDListFromPathA/W functions.
CORE-13950
2020-04-09 07:30:14 +09:00
Victor Perevertkin dd2ff41dfc [IPHLPAPI] Make icmp functions use IOCTL_ICMP_ECHO_REQUEST from tcpip.sys
This adds missing features like using events and APCs within IcmpSendEcho2
functions and others.
CORE-10742 CORE-14411

Co-authored-by: Tim Crawford <crawfxrd@gmail.com>
2020-04-07 05:32:40 +03:00
Julen Urizar Compains d6e0fe78e7
[TRANSLATION] Updating Spanish translation (#2503)
Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.

- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".
2020-04-06 13:17:20 +02:00
Eric Kohl b857ae808e [DEVMGR] CDeviceView::RecurseChildDevices: Skip invalid device nodes
CORE-16780
2020-04-05 18:29:32 +02:00
Hermès Bélusca-Maïto 76ebd0d054
[RPCRT4] Handle ERROR_BAD_NETPATH failure if an RPC pipe connection is done on an non-existing UNC path.
Addendum to 5274857d (see originally commit 13f41d74). CORE-6561
2020-04-03 13:33:03 +02:00
Hermès Bélusca-Maïto 5274857da9
[RPCRT4] Addendum to support for remote pipes names in ncacn_pipe_name() (24cd7bbe).
CORE-6561 CORE-13442

- Call GetComputerNameA() only when a non-empty server name has been
  provided, thus slightly improving speed for the most common case when
  local calls (with an empty server name) are done.

- When a server name is passed, trim any leading UNC server prefix since
  the latter will be restored when building the pipe name string.
2020-04-02 18:35:39 +02:00
Serge Gautherie 30613b92ab
[ACLUI] Properly enumerate cache+queue entries (#1937) 2020-03-30 13:13:22 +02:00
Serge Gautherie 724466597f [REACTOS] Remove forced _WIN32_IE defines
No impact, as already deactivated or superseded or superfluous.

Import
7770e26f2d
2020-03-30 13:47:09 +03:00
Serge Gautherie 07efa2ef53
[SHELL32] HCR_GetIconA(): Properly use icon_idx (#2482)
CORE-11713

Import
7cc2806e0e
2020-03-30 12:24:59 +02:00
Serge Gautherie 78d8705181
[WINMM] Add a WARN() when winejoystick.drv is missing (#2480)
Follow-up to 97150ce9.

Import
175a2a0276
2020-03-30 12:14:52 +02:00
Serge Gautherie 6e79e60883
[RPCRT4] Fix 'Routeines' typos (#2481)
Addendum to b6fdb56b9a.

Import
c73352047d

CORE-15682
2020-03-30 10:28:52 +02:00
Mark Jansen 177ae91bf6
[RTL] Introduce RtlpImageNtHeader,
which implements the required functionality.
ntdll and ntoskrnl now have a wrapper for this, with SEH.
This protects the function against malformed / bad images,
whilst still being able to use the code in freeldr et al.
Idea from Thomas.
CORE-14857
2020-03-29 21:27:38 +02:00
Andreas Maier 782ff23261
[MSV1_0] LsaApLogonUserEx2: use RtlRunDecodeUnicodeString to decode password 2020-03-28 23:27:34 +01:00
Serge Gautherie 5542dd50d6
[ADVAPI32] wine/crypt.*: Misc fixes
Import
62df03af96
8b9e3dae4f
2df16753f0

And use explicit '#ifndef __REACTOS__'.
2020-03-28 20:43:04 +01:00
Serge Gautherie 8ae8083378
[ADVAPI32][PSDK] CryptReleaseContext(): dwFlags parameter is DWORD, only
Import
9cc8b501ee
2020-03-28 20:43:03 +01:00
Serge Gautherie df224cb710
[ADVAPI32] wine: Remove remnant ros_diff.patch
Added on 4234345b03 (r48090),
merged on d4a89f6cca.

CORE-14434
2020-03-28 20:43:03 +01:00
Andreas Maier 2d36be4963
[MSV1_0] use precompiled headers (#2475) 2020-03-28 17:13:57 +01:00
Hervé Poussineau 5ed1867632 [CMAKE] Add some -D__ROS_LONG64__ to please gcc x64
We can now pass a UINT* to a function wanting a DWORD*
2020-03-26 16:39:16 +01:00
Serge Gautherie 1edfddf07a
[USERENV] sq-AL: Fix '%SistemDrive%' typo (#2469)
Not to translate!

CORE-16762
2020-03-26 07:28:09 +01:00
Eric Kohl 38788a2b07 [STORPROP] Add storprop.dll and implement the DiskClassInstaller stub 2020-03-22 16:40:35 +01:00
jimtabor 10d1afea18 [Explorer|Shell32]
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
2020-03-21 19:13:55 -05:00
Tibor Lajos Füzi 432a5ddc7f
[TRANSLATION] Update Hungarian translation of usetup, syssetup, explorer, netshell, userenv, shortcuts (#2442) 2020-03-20 17:52:46 +01:00
Robert Naumann fc4c4d4911
Sync brsfolder.c with keyboard shortcut code from wine (#2290)
* [SHELL32] Add shortcut to rename folders with the F2 key.

Sync Wine Commit 2e25a43f3fb6230460447bae6fb5db2edbd4a42f by Fabian Maurer

* [SHELL32] Add shortcut to delete folders with the delete key.

Sync Wine Commit 43f44ffb3779ff23c863d9b3297f92720e7e3733 by Fabian Maurer

* Disable the code for file deletion. The Wine way doesn't work on ROS. Add an explaining comment why we can't use the Wine code, as requested by Amine
2020-03-18 21:57:10 +01:00
Mark Jansen 315765ed8b
[MSVCRT] Add _snwscanf 2020-03-15 13:12:20 +01:00
Mark Jansen 550ce7e818
[WINTRUST] Add WTHelperGetFileHash stub 2020-03-15 13:12:05 +01:00
Katayama Hirofumi MZ 6bd0c70f15 [SHLWAPI] Sorry, I updated wrong function at 5a440b2 (#2430)
CORE-13950
2020-03-11 10:41:39 +09:00
Katayama Hirofumi MZ 5a440b2d90 [SHLWAPI] Follow-up of #2430
Add a NULL check in SHLockSharedEx function. CORE-13950
2020-03-11 07:36:07 +09:00
Katayama Hirofumi MZ 7fcdf0be03
[SHLWAPI] Implement SHLockSharedEx function (#2430)
- Implement shlwapi!SHLockSharedEx function.
- Modify shlwapi.spec file (some argument conversions from long to ptr).
CORE-13950
2020-03-11 00:03:45 +09:00
Eric Kohl 3909ebcf35 [SETUPAPI] Improve CM_Disable_DevNode_Ex
Replace the call to PNP_DeviceInstanceAction(PNP_DEVINST_DISABLE) by a call to PNP_DisableDevInst() because PNP_DeviceInstanceAction(PNP_DEVINST_DISABLE) is a no-op.
2020-03-07 13:26:53 +01:00
Serge Gautherie 9ccd179e4a
[RASDLG] Fix remaining '\n\n\n\n\n\n\n' typo (#2416)
Addendum to commit 92aabb07.
2020-03-07 00:51:32 +01:00
Jose Carlos Jesus a6515e2b75
[TRANSLATION] Update PT translation (#2342)
Update Portuguese translation for cryptui, ieframe and mpr DLLs.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:40:03 +01:00
Tibor Lajos Füzi ae7ce69f43
[TRANSLATION] Add Hungarian translation for explorer, msgina (#2341) 2020-03-06 19:15:58 +01:00
Serge Gautherie 92aabb07fb
[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)
Addendum to commit 554c41e4 (#2387).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:08:25 +01:00
Hervé Poussineau 35cb8f1393 [SETUPAPI] Implement StopDevice() 2020-03-05 22:47:15 +01:00
Hermès Bélusca-Maïto 98b58df2bf
[KERNEL32:CONSOLE] Explicitly use _WIN32_WINNT_VISTA. 2020-03-02 01:08:36 +01:00
Katayama Hirofumi MZ fc11cf78ca
[SHELL32] Improve ShellExecCmdLine in path resolving (#2397)
Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409
2020-03-01 19:32:33 +09:00
Katayama Hirofumi MZ 4df9355d0c
[SHELL32][BOOTDATA] Unselect filename extension upon renaming (#2398)
You can disable unselecting by setting TRUE to SelectExtOnRename value of HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer. CORE-15242
2020-02-29 08:08:26 +09:00
Serge Gautherie 554c41e4d7
[REACTOS] Fix trailing spaces and other typos in string resources (#2387) 2020-02-26 11:45:27 +03:00
Katayama Hirofumi MZ 3c5b10f4e6
[SHELL32] Fix SHChangeNotify for one item events (#2386)
Windows sends notification even if two parameters are provided for notification of one parameter. CORE-13950
2020-02-26 10:59:28 +09:00
Katayama Hirofumi MZ 1e60116563
[SYSDM][MSGINA][NETID][SHELL32] Japanese translation (retrial) (#2369)
Improve Japanese resources. This PR is based on @Midi730's work (#2361).
2020-02-25 10:27:49 +09:00
Katayama Hirofumi MZ 0a626dedf8
[SHELL32] Set read-only for some shell folders and delete Desktop.ini of Desktop and Program Files (#2385)
Set read-only attribute instead of system attribute for some shell folders that has a folder icon.
Delete desktop.ini files in Desktop and Program Files. CORE-16711
2020-02-25 10:07:58 +09:00
Doug Lyons 4e721f780e
[SHELL32] Fix unneeded error Popup with Git for Windows. (#1854)
* Fix unnecessary error popup when installing Git for Windows.
* Add reasons for return value of 42.
2020-02-23 17:47:48 +01:00
Hermès Bélusca-Maïto c6058bca24
[ATL] Import Wine upstream patch 3043ab3e62
Author: Puetz Kevin A <PuetzKevinA@JohnDeere.com>
atlbase.h: Fix some declarations on win64.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-23 16:52:03 +01:00
Hermès Bélusca-Maïto b4b0728684
[ATL30] Addendum to commit e410a122: Import Wine upstream patch 5608682dc9
atl: Fix the ATL_WNDCLASSINFOW::m_szAutoName member definition and construction.

Signed-off-by: Hermes Belusca-Maito <hermes.belusca@sfr.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-23 16:51:58 +01:00
Hermès Bélusca-Maïto 570eba2a52
[KERNEL32][CONSRV] Use more often the internal ConioRectHeight/Width() and ConioIsRectEmpty() macros. 2020-02-22 21:15:58 +01:00
Bișoc George 61c8d3432c
[MSGINA] Be sure to always initialize the cached DLG_DATA GINA context (#2360)
The ReactOS logo banner is loaded from the GINA context whereas the animation bar is loaded from the main application instance. However, the aforementioned context is not initialized when WM_INITDIALOG occurs hence DlgData_LoadBitmaps() would fail on proceeding at loading the remaining bitmaps to be loaded.

This fixes the regression introduced by commit 623dd26c (PR #2353).
2020-02-20 00:20:01 +01:00
Katayama Hirofumi MZ 623dd26cce
[MSGINA] Make DLG_DATA object-oriented (#2353)
- Rename hBitmap as hLogoBitmap of DLG_DATA structure.
- Add DlgData_Create. DlgData_LoadBitmaps, and DlgData_Destroy functions.
CORE-16697
2020-02-18 14:35:44 +09:00
Andreas Maier 8b0cfa1d3c
[MSV1_0] Improve LogonUserEx2 (#2356)
- Improve traces, using %wZ for UNICODE_STRING;
- Fix UNICODE_STRING validation.
2020-02-16 16:55:31 +01:00
Oleg Dubinskiy 7075bdacb2
[SHELL32] Don't hardcode My Documents path for My Music/Pictures/Videos folders in some translations (#2354)
Don't hardcode My Documents path in some translations of My Music, My Pictures and My Videos folders in Shell32. It fixes incorrect location of that folders when install ReactOS as Workstation.
Currently they are located in one more My Documents subfolder, which is, in its turn, in the correct My Documents directory. After this fix, they are directly in the 2nd one, as they should be.

CORE-16698
2020-02-15 20:06:16 +01:00
Katayama Hirofumi MZ d51716f131 [SYSSETUP] Small fix in Japanese translation 2020-02-15 11:04:48 +09:00
Katayama Hirofumi MZ 3d53078b1e [BROWSEUI] Improve Japanese translation (IDD_SEARCH_DLG) 2020-02-15 10:28:36 +09:00
Katayama Hirofumi MZ b1c7ca3024 [SYSSETUP] Improve resource ATTENTION comments 2 2020-02-15 10:15:32 +09:00
Katayama Hirofumi MZ ba17d87636 [SYSSETUP] Improve resource ATTENTION comments 2020-02-15 09:52:58 +09:00
Katayama Hirofumi MZ aec7a2bf5b [SYSSETUP] Improve Japanese translation 2020-02-15 09:41:46 +09:00
Bișoc George 6ce72ba172
[SHELL32] Better fix for the "Version" string in the About-dialog (#2349)
The version string kernel number and the localized "version" word were too near in translation files. The patch fixes the problem introduced by #2276.
Addendum to commit a57f7b50.
2020-02-14 22:17:48 +01:00
Oleg Dubinskiy 44e9fee237
[SYSSETUP] Update Russian translation for Product Options page (#2348) 2020-02-14 19:22:48 +01:00
Katayama Hirofumi MZ 358f947975
[SHELL32] Rewrite SHAddToRecentDocs (#2333)
Rewrite shell32!SHAddToRecentDocs and use it in some applications.
Wine's SHAddToRecentDocs was not Unicode supported and unusable. I will dare to rewrite.
CORE-3588
2020-02-14 11:05:21 +09:00