Commit graph

383 commits

Author SHA1 Message Date
Katayama Hirofumi MZ 1c40070561
[EXPLORER] Improve CTrayWindow::OnCopyData (#3028)
Check pCopyData->dwData value. Don't send message needlessly.
CORE-7237
2020-08-10 07:15:21 +09:00
Stanislav Motylkov 21b56d77c6
[EXPLORER] Allocate the string for expanded command line from heap
Addendum to 6fe704b.

CORE-12973 CORE-17168
2020-07-21 19:50:45 +03:00
Stanislav Motylkov 6fe704b0f0
[EXPLORER] Fix auto startup behavior
Command line should be expanded only for REG_EXPAND_SZ values.

CORE-17168
2020-07-21 17:28:48 +03:00
Hermès Bélusca-Maïto 240f6737e9
[CMD] Add a ExecuteCommandWithEcho() helper and use it in Batch() and as the implementation of RunInstance() FOR-loop helper. 2020-05-18 02:21:57 +02:00
Hermès Bélusca-Maïto ce543fbb72
[CMD] Fix the stop-batch prompt appearance: do not display it more than once in a row. 2020-05-18 02:21:57 +02:00
Hermès Bélusca-Maïto d0ced4ffdf
[CMD] Fix the ErrorMessage() function.
Specify its szFormat parameter optional, and correctly initialize the
szMessage buffer.
2020-05-18 02:21:56 +02:00
Hermès Bélusca-Maïto 9c11be5a3a
[CMD] Quick fix for the REM command parser. CORE-17030 2020-05-11 04:27:12 +02:00
Kyle Katarn 6133d55190
[EXPLORER] Fix incorrect component position and size for French language (#2671)
CORE-16930, CORE-12386
2020-04-27 12:32:42 +02:00
Serge Gautherie 96b7cb1a4f [EXPLORER] trayclock: Update timer delay when showing seconds is modified 2020-04-26 21:41:39 +03:00
Serge Gautherie e68bee7518 [EXPLORER] trayclock: Better handle timers, especially when it is hidden 2020-04-26 21:41:39 +03:00
Serge Gautherie e45b15aca2 [EXPLORER] CTrayClockWnd::CalculateDueTime(): Fix uiDueTime value
when showing seconds.
2020-04-26 21:41:39 +03:00
Serge Gautherie 5ce61092b5 [EXPLORER] Update now-redirected 'http' and 'www.reactos.org' URLs 2020-04-23 10:20:15 +02:00
Mark Jansen 5cee1b95c0 [EXPLORER] Keep processing messages while waiting for a startup task
CORE-16909
2020-04-20 15:37:19 +03:00
Piotr Hetnarowicz cd5364ae8e [cmd] pl-pl update 2020-04-16 18:32:08 +02:00
Julen Urizar Compains d6e0fe78e7
[TRANSLATION] Updating Spanish translation (#2503)
Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.

- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".
2020-04-06 13:17:20 +02:00
jimtabor 10d1afea18 [Explorer|Shell32]
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
2020-03-21 19:13:55 -05:00
Tibor Lajos Füzi 432a5ddc7f
[TRANSLATION] Update Hungarian translation of usetup, syssetup, explorer, netshell, userenv, shortcuts (#2442) 2020-03-20 17:52:46 +01:00
Thomas Faber 111721a64a
[CMD] Fix another NtReadVirtualMemory parameter.
Spotted by Hermès.
2020-03-14 21:23:06 +01:00
Thomas Faber 72c51aabba
[NTOS:IO][GDI32][CMD] Fix some under-sized variables. CORE-14922
Fixes x64 boot with RTC.
2020-03-13 20:45:06 +01:00
Tibor Lajos Füzi ae7ce69f43
[TRANSLATION] Add Hungarian translation for explorer, msgina (#2341) 2020-03-06 19:15:58 +01:00
Serge Gautherie 92aabb07fb
[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)
Addendum to commit 554c41e4 (#2387).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:08:25 +01:00
Katayama Hirofumi MZ 4e263367f8
[CMD] Fix 'if' command for root directories (#2394)
CORE-14797
2020-02-27 23:12:19 +09:00
Katayama Hirofumi MZ a9760098f7
[CMD] Correctly parse drive-decorated pathname (#2382)
Correctly interpret the drive-decorated pathnames (C: or D:dir1 etc). CORE-15871
2020-02-26 22:28:02 +09:00
Serge Gautherie 554c41e4d7
[REACTOS] Fix trailing spaces and other typos in string resources (#2387) 2020-02-26 11:45:27 +03:00
Aaron Dewes e5813c4644
Update german translation (#2291)
* Update German translations

* Update translation again

* More translations

* Some fixes in the german translation

* Some more fixes

* Little translation tweak

* Updates to 2nd review

* Little update

* Add back keyboard accel for IDS_OPENFILELOCATION.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-02-08 12:55:53 +01:00
Jose Carlos Jesus fb30239129 [FORMATING] Fix indentation of startmnucust
On branch CodeFormat
 Changes to be committed:
	modified:   base/shell/explorer/startmnucust.cpp

For a better visualization and understanding of the code
2020-02-05 19:27:10 +01:00
Katayama Hirofumi MZ 5f692ed1f0
[EXPLORER][INCLUDE] Fix wrong title on taskbar about ampersand (&) (#2266)
Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
Based on @learn-more's CORE-11619.patch. CORE-11619
2020-01-22 09:58:43 +09:00
Hermès Bélusca-Maïto 771b87dc8f
[CMD] If the prompt displays the information line on top of the screen, ensure that the prompt won't be hidden below it.
CORE-16193
2019-12-29 19:14:03 +01:00
Hermès Bélusca-Maïto 0bede0062a
[CMD] Code formatting; don't hardcode the string buffer sizes in function calls. 2019-12-29 19:13:59 +01:00
Serge Gautherie f6ad093801 [CMD] Fix 'MAX_ULONG' typo in a comment (#2143) 2019-12-10 13:16:26 +01:00
Katayama Hirofumi MZ 1b7732093c
[CMD] Unquote string at pushd (#2031)
pushd command of cmd.exe didn't treat the quoted parameter correctly.
- Call StripQuotes in SetRootPath function.
- Fix typo of FEATURE_DIRECTORY_STACK.
This PR will enable "Command Prompt" here. CORE-12150
2019-11-15 11:51:58 +09:00
Brock Mammen 3fee5d0e1c [EXPLORER] Fix right-click menu for taskbar clock (#1944)
CORE-16397
2019-10-09 01:18:36 +02:00
Eric Kohl 6bfe4f68af [LABEL][CMD] Convert the label command to a standalone executable
CORE-9444
2019-09-22 14:51:23 +02:00
Eric Kohl 432854ee18 [ATTRIB][CMD] Convert the 'attrib' command into a standalone executable
CORE-9444
2019-09-21 11:41:15 +02:00
Joachim Henze d2976ca58e [EXPLORER] Mitigate CORE-15760 'system menu may close unexpectedly'
Looks like a race condition of the async part of SetForegroundWindow().

KVM https://reactos.org/testman/compare.php?ids=69065,69069
VBOX https://reactos.org/testman/compare.php?ids=69064,69068

I intend to merge that back into 0.4.12RC as well.
2019-09-20 00:11:10 +02:00
Brock Mammen 4d097cf8b4 [EXPLORER] Open search from start menu 2019-09-15 19:46:36 +03:00
Jose Carlos Jesus d5dca45e51 [WIN32SS][USER][EXPLORER] Add/Update portuguese translation (#1882) 2019-08-26 21:01:41 +02:00
Ioannis Adamopoulos e419195d37 [HEADERS] Move some helpers from undocshell.h to shellutils.h as they didn't cover anything undocumented. Merge traycmd.h in undocshell.h as both contain just undocumented shell definitions. 2019-08-25 12:20:52 +03:00
Andreas Maier 8d6c9e844c [EXPLORER] Properly initialise tbBtn.iBitmap. CORE-14262.
In CNotifyToolbar::AddButton tbBtn.iBitmap (imagelist-index)
was inialised with 0. Tigthvnc adds the icon wihtout NIF_ICON flag.
So the wrong icon index was kept and later replaced.
2019-06-19 20:37:04 +02:00
Andreas Maier 7796df375a [EXPLORER] fix traces 2019-06-19 20:37:04 +02:00
Hermès Bélusca-Maïto 6afe79f361
[CMD] Fix typo in Norwegian translation. 2019-06-10 16:57:59 +02:00
Yaroslav Kibysh cc387650c2
[CMD] Update Ukrainian translation. (#1641) 2019-06-10 16:56:38 +02:00
Yaroslav Kibysh da340662c6
[EXPLORER] Update Ukrainian translation. (#1624) 2019-06-08 18:30:03 +02:00
Mas Ahmad Muhammad 3300a8353c
[EXPLORER] Add Indonesian translation. (#1598) 2019-06-04 15:52:20 +02:00
Jose Carlos Jesus e2f898aa94
[EXPLORER] Update Portuguese Translation 2019-05-26 21:19:35 +02:00
Jose Carlos Jesus 1a23f3c9df
[EXPLORER] Add Portuguese (Portugal) pt-PT.rc translation. CORE-15967 (#1558) 2019-05-11 22:31:00 +02:00
Hermès Bélusca-Maïto a7ddabcc12
[EXPLORER] Minor cleanup/comment fixes. 2019-04-22 21:25:41 +02:00
Mark Jansen aff8581f6d
[RSHELL] Disable exceptions in atl when compiling without exceptions 2019-04-18 19:21:39 +02:00
Mark Jansen 9824a0154e
[ATL] Retire atlnew 2019-04-18 19:21:37 +02:00
Jérôme Gardou 23373acbb9 [CMAKE] Use modules instead of shared libraries
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.

On my system, this reduces the configure-time by a factor of two.
2019-04-06 17:43:38 +02:00
Brock Mammen fb4c9fbcf2 Fix regression with double click action
The double click action is now triggered by the WM_LBUTTONDBLCLK message
instead of WM_NCLBUTTONDBLCLK.
2019-03-24 23:34:57 +01:00
Brock Mammen e7ad10241f [EXPLORER] Add date tooltip to taskbar clock
CORE-11444
2019-03-24 23:34:57 +01:00
Yaroslav Kibysh a30e644dc4 [EXPLORER][SHPOLICY] Implement "NoSimpleStartMenu" policy (#1258)
- Enable "New Start Menu" control for all languages.
- Implement the "NoSimpleStartMenu" policy in shpolicy.c and its usage in explorer.
- Hide controls instead of disabling (as in Win XP/Vista).
2019-03-24 14:56:43 +01:00
Luo Yufan a0506042a6 Merge pull request #1412 from njlyf2011/improve-zh-translation
[TRANSLATION] Update Traditional Chinese translation
2019-03-11 16:50:17 +01:00
Oleg Dubinskiy b7850f1078 [EXPLORER] Show the Desktop Russian translation update 2019-03-11 16:49:24 +01:00
Mark Jansen f9e50f5471 [ATL] Add GET_X_LPARAM and GET_Y_LPARAM to atlwin.h
Remove all local definitions
2019-01-15 14:34:53 +02:00
Denis Malikov 655d24d9eb [KERNEL32] make some NLS and Format functions work. Wine-sync with latest version 2019-01-05 19:01:30 +01:00
Julio Carchi 1e141573e4 [TRANSLATION] Spanish translations (#944) 2019-01-02 12:01:44 +01:00
Luo Yufan c34833390a [TRANSLATION] Update Traditional Chinese translation. (#1193) 2018-12-27 16:24:24 +09:00
Luo Yufan 0a3f6f3b47 [TRANSLATION] Update Chinese translation. (#1187)
[REG][REACTOS][EXPLORER][APPWIZ][CONSOLE][INETCPL][INPUT]
[INTL][OPENGLCFG][TIMEDATE][DEVCPUX][COMCTL32][COMDLG32]
[MSGINA][NETCFGX][NETID][SETUPAPI][SHELL32][SYSSETUP]
Update Simplified and Traditional Chinese translations.
2018-12-25 17:28:36 +09:00
Mark Jansen 6940d9fdf0
[EXPLORER] Add TWM_GETTASKSWITCH, which seems to be used on windows
to get a handle to the task switch control.
This can then be used to send messages to it, like hiding/showing buttons
CORE-15424
2018-12-17 20:38:38 +01:00
Katayama Hirofumi MZ d310503d9e
[EXPLORER] Set display icon of task properties (#1130)
CORE-10494
2018-12-14 20:07:33 +09:00
Luo Yufan 39a478d17b [TRANSLATION] Update Simplified Chinese translation. (#1096) 2018-12-05 16:50:05 +01:00
Giannis Adamopoulos f05d01ec2f [FILEBROWSER]
In the struct passed to SHCreateFromDesktop the fourth field is the parameter that later on will be passed to ShowWindow. Initialize it properly so that when we run filrbrowser.exe in win2k3 the main window won't be hidden.
2018-11-27 10:33:45 +02:00
Giannis Adamopoulos 84fa20ec8b [EXPLORER]
-Rename StartMenuBtnCtxMenuCreator to CStartMenuBtnCtxMenu_CreateInstance.
-Rename CreateStartMenuSite to CStartMenuSite_CreateInstance.
-Remove a couple of definitions that were not used.
2018-11-27 10:33:42 +02:00
Hermès Bélusca-Maïto e77ffe2c72
[FILEBROWSER] Remove a duplicated include. Noticed by Manuel Oppermann (see ros-dev ML). 2018-11-18 21:06:21 +01:00
Pako Smith 6cc4e9f6f3 [CMD] Fix Coverity #715934 "Copy-paste error" (#1040)
Fix linked-list pointer comparison.
2018-11-15 11:57:41 +01:00
Arnav Bhatt 05c2e3e89e [USETUP][EXPLORER] ReactOS explorer translation and hindi font substitution. (#954) 2018-10-19 17:03:17 +02:00
Katayama Hirofumi MZ 31019e8c0c [TRANSLATION] Update Romanian translation (#851)
Translation from Stefan Fulea.
CORE-15023
2018-09-14 11:04:36 +02:00
Stanislav Motylkov 7cdbdadf34 [CMD] Do not overwrite input string on Ctrl+C (#852)
CORE-15029
2018-09-13 11:47:01 +02:00
Hermès Bélusca-Maïto 3f892a8d6b
[CMD] Add missing memory allocation NULL checks (#161). CORE-8304
Adapted from a patch by Jacob S. Preciado.

Bring also the code suggestions emitted during review.
2018-08-21 14:02:24 +02:00
Adam Słaboń af3d426685 [TRANSLATION] Polish translation update (#781)
In addition: fix the encoding of the comdlg32 and ntvdm polish resource files.
2018-08-20 17:00:33 +02:00
Katayama Hirofumi MZ 35f62fc5ba [WIN32SS][FONT] Fix font metrics (#713)
Fix vertical alignment and Aspect penalty; improve font penalty system; fixes for Wine tests.
This is an update of #706. See CORE-11536 for more details.

The display of the following programs is fixed:
- Total Commander 8.52 setup: font displayed too large - CORE-11620.
- Effective File Search 6.8.1 german localization text rendering issues - CORE-14378.
- Font garbage in register splash screen in Foxit Reader 7.1.5 - CORE-9767.
- Calipers-1 is not displayed correctly - CORE-14302.
- Some MSI-installers draw their dialogs too large (example: Click-N-Type Virtual Keyboard 3.03.0412) - CORE-13161.
- Irfanview 4.50: font in zoom combobox displayed too large - CORE-14396.
- Rufus: The window and controls are displayed larger than necessary - CORE-14461.
2018-08-12 15:12:13 +02:00
Hermès Bélusca-Maïto 65f47728c0
[CMD] Small translation update. 2018-08-08 17:43:09 +02:00
Hermès Bélusca-Maïto 23b36fc173
[CMD] Add speed-optimized checks for dot-directories "." and ".." .
Adapted from PR #592 by Katayama Hirofumi MZ.
2018-08-06 22:40:17 +02:00
Hermès Bélusca-Maïto 17ebc8421a
[CMD] Fix the way the DIR-command pattern is interpreted when it contains paths or filenames with trailing dots.
Particular DIR commands like: "DIR .", "DIR .." now work as expected,
and we also correctly fix the behavior for files without extension,
that r38746 (2b06cfc0) originally tried to fix but broke the previous
examples.
Therefore "DIR *." and "DIR noextfile." work too.

Pathological cases like "DIR \...", "DIR \...\.", "DIR ..\...\.." and
the like (and with more than 3 dots) now work as expected.

Adapted from PR #592 by Katayama Hirofumi MZ, but with extended bugfixing.

CORE-13961
2018-08-06 22:40:17 +02:00
Hermès Bélusca-Maïto c57d49d0c1
[CMD] Code formatting; use LPCTSTR where possible; use a MAX_PATH sized dircmd buffer. 2018-08-06 22:40:17 +02:00
Katayama Hirofumi MZ 12517aa309
[CMD] Create a DirNodeCleanup() helper for cleanup and simplify code (adapted from PR #592). 2018-08-06 22:40:16 +02:00
Hermès Bélusca-Maïto 06504ee4be
[CMD] Fix French translation. 2018-08-06 22:40:12 +02:00
Timo Kreuzer cf77354dce [REACTOS] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Julio Carchi d7559e2354 [TRANSLATIONS] Fix spanish translations for some resources (#725)
Setup wizard
Network settings wizard
Input CPL
Open file dialogs
Devmgr
Explorer
2018-08-03 15:08:13 +02:00
Hermès Bélusca-Maïto 8dbe62b294
[EXPLORER] Improve debug output. 2018-07-29 16:21:06 +02:00
Jared Smudde 1f2f03dd76 [EXPLORER] Fix creation of shortcuts in the start menu. 2018-07-25 00:57:58 +02:00
Katayama Hirofumi MZ 75b09f3f88 [EXPLORER][SHELL32][USER32] Implement 'Show the Desktop' action of Task Bar (#668)
The keyboard shortcuts Win+D and Win+M are also enabled.

- Implement IShellDispatch4::ToggleDesktop().
- Implement some commands in CTrayWindow.
- Add "sdk/include/reactos/traycmd.h" for tray commands.
- Fix task window switching.
- Improve the user32!SwitchToThisWindow() function and use it.

CORE-14318, CORE-13157
See also: CORE-14806 and CORE-8723
2018-07-13 10:34:42 +02:00
Katayama Hirofumi MZ 706a1c5132 [CMD] "del /s directory" command doesn't show the directories or files names in the confirmation message (#680)
CORE-14059
2018-07-13 01:47:45 +02:00
Katayama Hirofumi MZ 58825de892 [EXPLORER] Fix TrackCtxMenu about NULL ppt (#666)
CORE-14772
2018-07-08 16:36:28 +02:00
Katayama Hirofumi MZ a882ec7a02 [SHELL32][EXPLORER] Update system-wide environment variables (#663)
- Implement shell32 RegenerateUserEnvironment() function and use it.
- CShellBrowser and CDesktopBrowser implements WM_SETTINGCHANGE actions.

CORE-1459, CORE-14397
2018-07-08 16:32:42 +02:00
Hermès Bélusca-Maïto 12de9654b0
[EXPLORER] Simplify the current-shell-is-explorer check when trying to start the auto-start programs, by using the existing code. 2018-06-22 16:34:16 +02:00
Katayama Hirofumi MZ 0a8cd95cad [USERINIT][EXPLORER] Fix auto startup of Start Menu (#594)
- Remove code for Start-Menu auto-startup items from userinit and put it where it belongs: in explorer.

CORE-10839
2018-06-22 16:02:25 +02:00
Katayama Hirofumi MZ c84f398306 [EXPLORER] 'Run' (Win+R) should set the proper current directory (#593) 2018-06-21 18:18:57 +02:00
Andrea Crescentini d303b70b7a [TRANSLATION] Improving italian translation (#623)
- Improved Italian translation for USETUP, WELCOME, REACTOS, EXPLORER.
- Completed translation in SYSSETUP.
- Correct some characters encoding and text alignment in USETUP.
2018-06-21 14:03:35 +02:00
Serge Gautherie 637026ffd7 [RSHELL] Remove a duplicated add_custom_command() call (#570) 2018-06-05 20:17:34 +02:00
Hermès Bélusca-Maïto a165999067
[CMD] Improve the situations when the console title can be changed.
- Introduce two small helpers to change and restore the console title.
- Console title can change even when internal commands are executed.
- Note that when commands are run from within batch files, title is unchanged.
- When "cmd.exe /c command" is run, the console title is unchanged; however
  when "cmd.exe /k command" is run, the console title changes.
2018-06-03 02:36:39 +02:00
Hermès Bélusca-Maïto 39af25024a
[CMD] Print a newline after the interactive 'pause' command message finishes to run. 2018-06-03 02:36:32 +02:00
Hermès Bélusca-Maïto ddd03a8973
[CMD] Use string-safe call to build the new console title (possibly truncated, we don't care), avoiding any buffer overflow. Caught by David Quintana. 2018-05-20 19:57:43 +02:00
Hermès Bélusca-Maïto 73f799629b
[TRANSLATION] Minor translation update. 2018-05-01 17:45:06 +02:00
Hermès Bélusca-Maïto 03c233bcd0
[CMD] Improve how the command prompt displays when one presses Ctrl-C/break after having pressed ENTER, or after a command has been run. 2018-04-29 00:57:16 +02:00
Hermès Bélusca-Maïto a3b36f8d3e
[CMD] Don't reset bCtrlBreak too early.
This allows to break commands such as:

C:\ReactOS\system32> for %f in (*.*) do dir

as one would expect: stop the currently running 'dir' and the 'for'.
"bCtrlBreak" doesn't need to be volatile too.
2018-04-29 00:53:49 +02:00
Hermès Bélusca-Maïto 6dd27bd467
[CMD] Use CheckCtrlBreak(). 2018-04-29 00:50:40 +02:00
James Woodcock 8b72fce3e1
[CMD] Use _T() rather than L to initialise TCHARS. 2018-04-28 22:16:59 +02:00
James Woodcock d7e71357dc
[CMD] Fix CTRL-C handling.
Using CTRL-C to cancel command line input would leave the prompt in
a state where the next command would be ignored.  For example:

dir<CTRL-C>
dir

would cause cmd.exe to ignore the second dir command.
2018-04-28 22:16:58 +02:00
James Woodcock 23de2099e0
[CMD] Don't pass CTRL-C to child processes.
CORE-11677

The standard Win32 Console Control Handler will give CTRL-C events to
processes spawned from cmd.exe. If cmd.exe calls GenerateConsolCtrlEvent()
then the child process will receive two CTRL-C events.
2018-04-28 22:16:50 +02:00
Hermès Bélusca-Maïto c62bccdda0
[EXPLORER] Implement the feature of cleanly shutting down the explorer shell when cancelling the shutdown-dialog while pressing the CTRL-ALT-SHIFT keys.
See the feature description in https://msdn.microsoft.com/en-us/library/windows/desktop/cc144064(v=vs.85).aspx
and the additional observations reported in CORE-14358 .
2018-04-08 00:36:56 +02:00
Hermès Bélusca-Maïto 6093abdebb
[EXPLORER] Remove trailing whitespace. 2018-04-08 00:36:51 +02:00
Hermès Bélusca-Maïto eff4c2138d
[EXPLORER] Remove double 'return' statement. Determining whether it should be HTBORDER or HTCLIENT is left as an exercise to the reader.
Spotted by 'mudhead'. CORE-14528
2018-04-07 19:06:22 +02:00
Hermès Bélusca-Maïto 4127024b0d
[EXPLORER] Handle WM_CONTEXTMENU message in CNotifyToolbar and BN_CLICKED notification in CSysPagerWnd.
With these, we generate the WM_CONTEXTMENU and NIN_(KEY)SELECT
shell icon notifications that applications expect when they handle
shell notification icons with uVersion >= 3.

This fixes in particular the previously unresponsive icon of KVIrc 4.x,
and more generally *all* the notifiation icons of Qt applications.
CORE-10605 #resolve
2018-04-02 21:13:35 +02:00
Hermès Bélusca-Maïto 2f108ac8a8
[EXPLORER] Add missing 'break' statements. Spotted by mudhead. CORE-14518 2018-04-02 16:12:25 +02:00
Eric Kohl 4916c4cfd5 [CMD] Correct the action on shorcut Ctrl-M
Patch by Jacob S. Preciado.

CORE-10142
2018-03-22 22:29:33 +01:00
Mark Jansen bc67bb3dd0 [EXPLORER] Do not force X86 in the manifest. 2018-03-19 09:44:25 +01:00
Robert Naumann 69acbe905a
Update German translation (#438)
* [BROWSEUI] Update German translation

* [SHELL32] Update German translation

* [COMCTL32] Update German translation

* [COMDLG32] Update German Translation

* [SETUPAPI] Update German translation

* [EXPLORER] Update German translation
2018-03-17 22:48:16 +01:00
Thomas Faber ede8794c4b
[EXPLORER] Remove SetBandSiteInfo hack. CORE-9809 2018-03-03 17:17:13 +01:00
Giannis Adamopoulos b95fff5bce [EXPLORER] CTrayWindow: Set the initial lock state in the band site
This alongside the previous commit, fix locking and unlocking the taskbar.
2018-02-28 17:21:19 +02:00
Giannis Adamopoulos ec91188fff [WINSRV] Implement sending the hard error balloon package to explorer
[EXPLORER] Implement showing the hard error balloon
2018-02-26 16:51:59 +02:00
Pierre Schweitzer 6061c78e91
[EXPLORER] Update French translation 2018-02-16 19:36:25 +01:00
Serge Gautherie f1535c2d6e [EXPLORER] Fix a Clang-Cl warning about Icon->ProcessId
"warning: expression result unused [-Wunused-value]"
Regressed in be2bf9b.

CORE-14306
2018-02-12 08:41:26 +00:00
Bișoc George abdde0b764 [EXPLORER] WatchList should be freed with delete[], not delete (#374)
WatchList is a set of array objects, initialized with "new[]", so it should be freed with "delete[]" to free all of its elements. Otherwise using only "delete" only frees the first variable but not its array. This would lead to an undefined behaviour.
2018-02-11 22:56:38 +01:00
David Quintana 3003471e64 [EXPLORER] Send balloon notifications to the callback message.
TODO: Send NIN_BALLOONUSERCLICK when the user clicks on the balloon content (not the X button).
2018-02-10 16:31:26 +01:00
Joachim Henze 579e1e6b24 [EXPLORER] Update all preview bitmaps showing notification area
To reflect recent changes in taskbar height, icon spacing,
clock x and y margins.
Also make sure all shots show the exact same time
and choose a more localization agnostic time.
2018-02-06 17:35:08 +01:00
Joachim Henze bd7eae6795 [EXPLORER] Update classic/modern startmenu preview bitmaps
To reflect our recent updates in banners and notification area.
Also reduces explorer binary size by 214.016bytes.
2018-02-06 14:48:43 +01:00
Adam Słaboń 0d838f40a3 [TRANSLATION] Polish translation update (#357) 2018-02-04 18:45:20 +01:00
Hermès Bélusca-Maïto 131678a025
[SHELL32] Rewrite the wrapping code for shell taskbar notifications.
- Introduce the TRAYNOTIFYDATAW structure, as documented by Geoff
  Chappell in "WM_COPYDATA for Taskbar Interface", at
  http://www.geoffchappell.com/studies/windows/shell/shell32/api/shlnot/copydata.htm
  that is the data structure passed between shell32 and explorer for
  communicating shell notify icon information.

- In Shell_NotifyIcon(), correctly capture the (ANSI and) UNICODE
  structures provided by the caller, properly taking into account for
  the different NOTIFYICONDATA structure sizes existing out there.
  The different strings are now properly null-terminated (especially
  szTip if it needs to be truncated out), and the flags validated.

- Remove the now unneeded "SHELL_NotifyIcon()" helper function.

[EXPLORER] Use TRAYNOTIFYDATAW and adjust the callers.
2018-02-04 18:11:50 +01:00
Hermès Bélusca-Maïto 04498f3eb5
[EXPLORER] Don't use deprecated StrNCpy function but use the string-safe StringCchCopy instead. Also fix a copy-paste error in the _countofs. 2018-02-04 01:57:05 +01:00
Hermès Bélusca-Maïto f982d77b8a
[CONUTILS] Diverse improvements: start doxygenating and add some resource messsage helper functions.
- Start to doxygenate the library, focusing in great details on the
  functions of the "outstream" module.
- Add a K32LoadStringEx function that expands (K32)LoadString by
  allowing a LanguageId parameter to be able to load strings from other
  languages than the current one.
- Add "ConResMsg*" helper functions to be able to (format and) print
  message strings with inserts that come *NOT* from a message table (as
  usual) *BUT* from resource string tables.
  Will be helpful for CORE-14265 in particular.

[CMD] Fix the call to ConMsgPrintfV().
2018-02-02 00:41:54 +01:00
Luo Yufan a13c998183 [TRANSLATION] Simplified Chinese translations updated. (#348) 2018-02-01 02:50:29 +01:00
Joachim Henze f5d679aeb9 [EXPLORER] Pixel-perfect x-margins surrounding the clock
To look like XP/2k3.
Relies on d11e7af5f2

CORE-14272
2018-01-30 18:42:21 +01:00
Giannis Adamopoulos 556c485c8b [EXPLORER] Improve the width of the taskbar clock
Don't take into account TRAY_CLOCK_WND_SPACING_X twice
Increase TRAY_CLOCK_WND_SPACING_X
2018-01-29 22:32:17 +02:00
Giannis Adamopoulos d11e7af5f2 [EXPLORER] Center the text of the clock
CTrayClockWnd: Fix the calculation that centered the text of the clock.
CTrayNotifyWnd: Restore the 1 pixel margin between the clock and the pager.
2018-01-29 21:50:33 +02:00
Joachim Henze c109dc9f24 [EXPLORER] Tweak x-margins surrounding the clock
To look more like XP/2k3.
Not pixel-perfect yet, that would require asymmetric margins.

CORE-14272
2018-01-29 19:15:50 +01:00
Giannis Adamopoulos fabf069daf [EXPLORER] Fix showing the lock status in the taskbar popup menu 2018-01-29 18:15:31 +02:00
Joann Mõndresku d80ef2c90a [TRANSLATION] Various translations to Estonian (#329)
Estonian translations for shell + explorer, cpl files (access, appwiz, desk, timedate), devmgr, browseui, comctl32, aclui, avifil32, comdlg32 and credui.
2018-01-29 17:03:27 +01:00
Giannis Adamopoulos 22d1e1017f [EXPLORER] CNotifyToolbar: Set TBMETRICS::cxBarPad and TBMETRICS::cyBarPad
MSDN says that these values are not used but apparently they are used as a padding around the buttons.
This helps to center the buttons in the notification area.
2018-01-29 17:30:44 +02:00
Giannis Adamopoulos c54c5ebb5f [EXPLORER] CTrayWindow: Draw the sizer only when the taskbar is not locked. 2018-01-29 00:27:45 +02:00
Giannis Adamopoulos 488477d10d [EXPLORER] CTrayNotifyWnd: Fix resizing when the clock is hidden 2018-01-28 22:38:48 +02:00
Giannis Adamopoulos 85d7dd4f83 [EXPLORER] CTrayNotifyWnd: Only update the requested dimension when handling TNWM_GETMINIMUMSIZE. 2018-01-28 22:04:34 +02:00
Giannis Adamopoulos 5a1984c998 [EXPLORER] CTaskSwitchWnd: Implement getting the setting for grouping tasks. This doesn't work yet but the setting does get stored in m_IsGroupingEnabled. TSWM_ENABLEGROUPING is not needed. 2018-01-28 20:24:02 +02:00
Giannis Adamopoulos 6c073e9539 [EXPLORER] CTrayClockWnd: Implement showing and hiding seconds or the whole clock from the properties window. 2018-01-28 18:59:18 +02:00
Giannis Adamopoulos 455bce68b5 [EXPLORER] -Make CSysPagerWnd, CTaskSwitchWnd, CTrayClockWnd and CTrayNotifyWnd proper com objects so that their lifetime is managed properly. 2018-01-28 18:35:16 +02:00
Giannis Adamopoulos 7f35908ad2 [EXPLORER] CTrayNotifyWnd: Simplify how it interacts with its parent and children. Clean up. 2018-01-27 19:41:09 +02:00
David Quintana 3d75cc0814 [EXPLORER] Split up the notification area into a few more manageable pieces. 2018-01-24 14:41:31 +01:00
David Quintana 5ec441a867 [EXPLORER] Workaround for something that may or may not be an "unintended feature" of the comctl toolbar.
Apparently the indices provided in NMTBGETINFOTIP (TBN_GETINFOTIP data struct), are not reliable,
but since the lParam values are, and it saves us a lookup, we will be using those instead. Win-Win!
2018-01-23 23:10:44 +01:00
David Quintana bc43733e48 [EXPLORER] Implement balloon queueing. 2018-01-23 22:13:01 +01:00
David Quintana bbca71c4a5 [EXPLORER] Implement rudimentary uVersion management, and notification balloons.
- uVersion will only be truly useful when Vista+'s V4 style notification icons are implemented.
- Balloon notifications do not yet support queuing and auto-closing.
- Force the notification icon tooltips to always show even if the taskbar isn't foreground.
[ROSCTRLS.H] Implement CTooltips class which manages a comctl32 tooltips window.
2018-01-23 22:13:01 +01:00
Ged Murphy cb8cc0d098 [EXPLORER]
We need to leave one slot available for the m_WakeUpEvent handle
2018-01-20 18:50:10 +00:00
Ged Murphy be2bf9b8c5 - Properly handle cases of more than 64 icons
- Don't leak the list of handles on each pass through the loop
- Make sure we clean up if the wait fails for whatever reason
2018-01-20 18:38:42 +00:00
gedmurphy 851e0ca5a8 Delete the lock on exit 2018-01-20 18:38:42 +00:00
gedmurphy 2abd068398 Properly delete the object and allow its destructor to cleanup 2018-01-20 18:38:42 +00:00
gedmurphy 8c91a00fcf Minor update 2018-01-20 18:38:42 +00:00
gedmurphy 6c9629bb72 forgot about the gcc build... 2018-01-20 18:38:42 +00:00
gedmurphy d66c6890f7 Initial implementation of a watcher for the systray (notification area) that removes icons if the owning process dies/terminates without removing it 2018-01-20 18:38:42 +00:00
David Quintana 2c8ed37605 [EXPLORER] Fix the code that requests the taskbar to recalculate the size,
after an icon is removed due to missing owner. Also cleaned up the other case.
2018-01-18 02:20:20 +02:00
David Quintana 74e58d938e [EXPLORER] Fix some issues with the notification area code,
and implement NIS_SHAREDICON while at it.
2018-01-18 02:20:20 +02:00
Giannis Adamopoulos 71e66c69c1 [EXPLORER] CTrayBandSite: Call DBID_SETWINDOWTHEME on new bands to make them use the theme of the taskbar. CORE-14176 2018-01-16 11:50:52 +02:00
Giannis Adamopoulos 4b6d929be1 [EXPLORER] Winkey + E shortcut should open "My Computer" instead of "My documents" CORE-14199 2018-01-13 21:14:16 +02:00
Erdem Ersoy ba3f074320 [TRANSLATIONS] Update the email address and add a note in the Turkish translation document (#271) 2018-01-07 22:09:42 +01:00
Katayama Hirofumi MZ 89f9c9101a
[TRANSLATION] Use correct font name in Korean resources, CORE-9566 (#228).
Localized resources should use the correct Korean fonts that are most suitable
for UI and compatible with Windows.
2017-12-29 01:51:15 +01:00
Katayama Hirofumi MZ e9d8fa57c3
[TRANSLATION][BASE][FDEBUG][MODULES][WIN32SS] Use correct font name in Chinese resources, CORE-9566 (#227).
Localized resources should use the correct Traditional/Simplified Chinese fonts
that are most suitable for UI and compatible with Windows.
2017-12-29 01:51:06 +01:00
Lauri Ojansivu 2246a9f211 [TRANSLATION] Translate Explorer into Finnish, by Lauri Ojansivu (#218) 2017-12-26 20:17:30 +01:00
Markus Gothe e2e699118f Improve swedish translations and add new translations to swedish. 2017-12-25 11:31:22 +01:00
Luo Yufan d6131ace49 [TRANSLATION] Improve Simplified Chinese Translations.
* Fix Simplified Chinese Translation of EXPLORER.
* Fix Simplified Chinese Translation of MSCONFIG_NEW.
* Fix Simplified Chinese Translation of MSPAINT.
* Fix Simplified Chinese Translation of SHELL32.
* Fix Simplified Chinese Translation of SYSDM.
* Fix Simplified Chinese Translation of SETUP/REACTOS.
2017-12-17 14:40:59 +01:00
Hermès Bélusca-Maïto 49db8dc2a2
[CMD] Fix resource string (unrecognized escape sequence); addendum to 9a59558. 2017-12-07 22:08:54 +01:00
Luo Yufan 069546f5a4 Update Simplified Chinese translation. 2017-12-06 16:30:17 +01:00
Hermès Bélusca-Maïto f79d268ea1
[CMD] Fix the del /s command, reported by Pablo De Napoli. CORE-10460
The command should delete files in the specified directory and all of its
sub-directories, using any file pattern specified.

For example, the command:

    del /S .\my_directory

should delete all the files inside my_directory and its sub-directories,
and as such should also detect that "my_directory" is indeed a directory,
while doing:

    del /S .\my_file

should of course detect that "my_file" is indeed a file pattern, and thus,
delete all "my_file" files from the current directory and its sub-directories.

The command:

    del /S some_directory\file_pattern

should delete "file_pattern" files from some_directory and its sub-directories.
2017-12-03 16:01:44 +01:00
Hermès Bélusca-Maïto 9a59558307
[CMD] Fix the presentation of some confirmation prompts. 2017-12-03 15:58:53 +01:00
Hermès Bélusca-Maïto 748c87202c
[CMD] Update the documentation of the FOR command. CORE-5806
- Also update & translate the french translation.
- Translators, please verify & update the translations!
2017-11-21 23:47:46 +01:00
Hermès Bélusca-Maïto 7bd33ac4df
[CMD] Addendum to 26ff2c8 and to r40474 / 8cf1106: Fix CMD process exit code.
As it appears, the process exit code of CMD /C is really the errorlevel,
and not the "command's return value".
2017-11-19 00:48:37 +01:00
Hermès Bélusca-Maïto 26ff2c8ef3
[CMD] Fix the errorlevel value set by the EXIT command, and when a batch file has run.
CORE-10495 CORE-13672

- Fix the behaviour of the EXIT command, where it set the last errorlevel
  value ONLY when it was called with the /b switch and otherwise kept the
  ambient one, instead of always using the value that the user specified
  on the command-line.

- When a batch file has terminated, make the Batch() helper returning the
  errorlevel value so that, when the batch file has been started with the
  CALL command, CALL can in turn set the correct errorlevel value.

Verified with respect to Windows' cmd.exe.
2017-11-18 23:52:50 +01:00
Hermès Bélusca-Maïto 24ed534474
[CMD] Code formatting only. 2017-11-18 23:52:50 +01:00
Hermès Bélusca-Maïto 56a19b1439
[CMD] ExecutePipeline() returns the last error level (set to process exit code).
CORE-13974

This should fix situations where (for example):
   command_1 | command_2 && echo Succeeded
should *NOT* run "echo Succeeded" if any of the command_1 or command_2 has
failed.

This also makes the ExecutePipeline() function on par with the other
"ExecuteXXX()" helpers.

Problem diagnosed by Doug Lyons; patch inspired by contributor 'cagey45'.
2017-11-18 20:59:06 +01:00
Hermès Bélusca-Maïto 8340574fe3
[CMD] Fix support for newlines in the emulated parenthesed set block of the "for" command.
CORE-7998
2017-11-17 00:58:45 +01:00
Hermès Bélusca-Maïto cfcca53856
[CMD] Fix '?' command output by adding a missing new-line. CORE-14016
Patch by Doug Lyons.
2017-11-16 21:27:27 +01:00
David Quintana e10108c088 [EXPLORER] Remove version number from the start menu banner image, as requested.
Also, since we won't be editing the svg as often, move it to the media/graphics folder.
2017-11-14 18:15:34 +01:00
Giannis Adamopoulos 2ed535da8a [EXPLORER] -Rewrite taskbar settings routines and dialog
- Rewrite the taskbar settings and start menu settings property sheets.
- All settings in the taskbar settings property sheet can be loaded and saved properly except for the quick launch one which will be implemented later.
- Implement toggling lock, autohide and always on top. The rest will be implemented later.
2017-11-01 01:04:39 +02:00
Giannis Adamopoulos 82b12ef4cf [EXPLORER] CSysPagerWnd: Notify the CTrayWindow to reposition its children only when the number of the icons shown in the notification area changes. 2017-10-28 22:09:44 +03:00
Giannis Adamopoulos 4238f22396 [EXPLORER] Simplify how autohide is implemented
Do not change m_TrayRects when m_AutoHideOffset is changed. m_AutoHideOffset will be taken into account only while WM_WINDOWPOSCHANGING is processed
2017-10-28 19:27:11 +03:00
Amine Khaldi 5cb0615147 [BROWSEUI][DEVMGR][EXPLORER][NTGDI][NTOBJSHEX][NTVDM][SETUPAPI] Remove/comment out some unused variables. CORE-11799 (#94) 2017-10-28 15:04:18 +01:00
David Quintana f0cc70da49 [EXPLORER] Update start menu banner to match our new versioning scheme for the master branch 2017-10-26 22:33:16 +02:00
Giannis Adamopoulos 0503d8808c [EXPLORER] Reduce the spam due to the broken CBandSite in browseui 2017-10-23 00:34:38 +03:00
Giannis Adamopoulos 8a52080dcc [BROWSEUI] Rename CISFBand_CreateInstance and add a CISFBand_CreateInstance macro that makes easy to switch between the system implementation or the local one. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos f0f1e5ffdb [QCKLNCH] Remove qcklnch (#61)
- Move CIFSBand to the shellbars static lib which is linked to browseui and rshell.
- Move CQuickLaunchBand to rshell.
- Make nescessary adjustments so that they can both be registered and instantiated.
2017-10-16 23:56:34 +03:00
Giannis Adamopoulos da5b61f32f [EXPLORER] Remove an unnecessary refresh of the rebar and its bands. 2017-10-14 18:42:37 +03:00
Adam Słaboń 9c790dfc3b Polish translation update (#29)
* Polish translation update
2017-10-10 12:14:38 +02:00
Hermès Bélusca-Maïto 221ed4cefe Remove unwanted .gitignore files. 2017-10-04 10:28:36 +02:00
Colin Finck c2c66aff7d Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00