Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-24 09:25:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
78548 commits 97 branches 276 tags 2.1 GiB
Commit graph

437 commits

Author SHA1 Message Date
Katayama Hirofumi MZ
5af2570b37 [SHELL32] Follow-up No.3 of #2539 
Improve a comment in CreateNotificationParamAndSend.
CORE-13950
 2020-04-13 13:19:12 +09:00
Katayama Hirofumi MZ
b76d053a30 [SHELL32] Follow-up No.2 of #2539 
Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950
 2020-04-13 13:06:15 +09:00
Katayama Hirofumi MZ
bfe36e4f0d [SHELL32] Follow-up of #2539 
Improve comment. CORE-13950
 2020-04-13 10:41:26 +09:00
Katayama Hirofumi MZ
2727245c86
[SHELL32] Shell notify rework for simplicity and readability (#2539) 
Shell change notification has been implemented in #2432. But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950
 2020-04-13 10:36:24 +09:00
Katayama Hirofumi MZ
ddc1a46456 [SHELL32] Improve CChangeNotify::ShouldNotify more 
Improved non-recursive cases.
CORE-13950
 2020-04-11 11:55:06 +09:00
Katayama Hirofumi MZ
2a32094aa0 [SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify 
CORE-13950
 2020-04-11 09:27:45 +09:00
Katayama Hirofumi MZ
2a6bccb4ce [SHELL32] Make "Unable to get notification window" quiet 
CORE-13950
 2020-04-11 08:45:23 +09:00
Katayama Hirofumi MZ
60959e34aa [SHELL32] Simplify CChangeNotify::ShouldNotify 
CORE-13950
 2020-04-10 21:57:58 +09:00
Katayama Hirofumi MZ
59c48a5d33 [SHELL32] Improve CChangeNotify::ShouldNotify 
Shell change notification was not sent to My Documents.
CORE-13950
 2020-04-10 21:51:22 +09:00
Serge Gautherie
745cb1cbda
[SHELL32] Fix SHCNE_UPDATEITEM number of items (#2409) 
Import
83acbb79c1

Related to CORE-13950
 2020-04-09 19:42:00 +02:00
Joachim Henze
bf342653df [SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file) 2020-04-09 18:17:06 +02:00
Katayama Hirofumi MZ
1c706d7483
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save (#2515) 
- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391
 2020-04-09 16:56:54 +09:00
Katayama Hirofumi MZ
0903c645a2 [SHELL32] Follow-up of #2432 
Fixed hang of FireFox.
 2020-04-09 08:19:47 +09:00
Katayama Hirofumi MZ
296192685b
[SHELL32] Implement shell change notification (#2432) 
- Rewrite SHChangeNotify, SHChangeNotifyRegister, SHChangeNotify_Lock, SHChangeNotify_Unlock and SHChangeNotifyDeregister functions.
- Fix SHSimpleIDListFromPathA/W functions.
CORE-13950
 2020-04-09 07:30:14 +09:00
Julen Urizar Compains
d6e0fe78e7
[TRANSLATION] Updating Spanish translation (#2503) 
Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.

- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".
 2020-04-06 13:17:20 +02:00
Serge Gautherie
07efa2ef53
[SHELL32] HCR_GetIconA(): Properly use icon_idx (#2482) 
CORE-11713

Import
7cc2806e0e
 2020-03-30 12:24:59 +02:00
jimtabor
10d1afea18 [Explorer|Shell32] 
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
 2020-03-21 19:13:55 -05:00
Robert Naumann
fc4c4d4911
Sync brsfolder.c with keyboard shortcut code from wine (#2290) 
* [SHELL32] Add shortcut to rename folders with the F2 key.

Sync Wine Commit 2e25a43f3fb6230460447bae6fb5db2edbd4a42f by Fabian Maurer

* [SHELL32] Add shortcut to delete folders with the delete key.

Sync Wine Commit 43f44ffb3779ff23c863d9b3297f92720e7e3733 by Fabian Maurer

* Disable the code for file deletion. The Wine way doesn't work on ROS. Add an explaining comment why we can't use the Wine code, as requested by Amine
 2020-03-18 21:57:10 +01:00
Serge Gautherie
92aabb07fb
[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393) 
Addendum to commit 554c41e4 (#2387).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
 2020-03-06 19:08:25 +01:00
Katayama Hirofumi MZ
fc11cf78ca
[SHELL32] Improve ShellExecCmdLine in path resolving (#2397) 
Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409
 2020-03-01 19:32:33 +09:00
Katayama Hirofumi MZ
4df9355d0c
[SHELL32][BOOTDATA] Unselect filename extension upon renaming (#2398) 
You can disable unselecting by setting TRUE to SelectExtOnRename value of HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer. CORE-15242
 2020-02-29 08:08:26 +09:00
Katayama Hirofumi MZ
3c5b10f4e6
[SHELL32] Fix SHChangeNotify for one item events (#2386) 
Windows sends notification even if two parameters are provided for notification of one parameter. CORE-13950
 2020-02-26 10:59:28 +09:00
Katayama Hirofumi MZ
1e60116563
[SYSDM][MSGINA][NETID][SHELL32] Japanese translation (retrial) (#2369) 
Improve Japanese resources. This PR is based on @Midi730's work (#2361).
 2020-02-25 10:27:49 +09:00
Katayama Hirofumi MZ
0a626dedf8
[SHELL32] Set read-only for some shell folders and delete Desktop.ini of Desktop and Program Files (#2385) 
Set read-only attribute instead of system attribute for some shell folders that has a folder icon.
Delete desktop.ini files in Desktop and Program Files. CORE-16711
 2020-02-25 10:07:58 +09:00
Doug Lyons
4e721f780e
[SHELL32] Fix unneeded error Popup with Git for Windows. (#1854) 
* Fix unnecessary error popup when installing Git for Windows.
* Add reasons for return value of 42.
 2020-02-23 17:47:48 +01:00
Oleg Dubinskiy
7075bdacb2
[SHELL32] Don't hardcode My Documents path for My Music/Pictures/Videos folders in some translations (#2354) 
Don't hardcode My Documents path in some translations of My Music, My Pictures and My Videos folders in Shell32. It fixes incorrect location of that folders when install ReactOS as Workstation.
Currently they are located in one more My Documents subfolder, which is, in its turn, in the correct My Documents directory. After this fix, they are directly in the 2nd one, as they should be.

CORE-16698
 2020-02-15 20:06:16 +01:00
Bișoc George
6ce72ba172
[SHELL32] Better fix for the "Version" string in the About-dialog (#2349) 
The version string kernel number and the localized "version" word were too near in translation files. The patch fixes the problem introduced by #2276.
Addendum to commit a57f7b50.
 2020-02-14 22:17:48 +01:00
Katayama Hirofumi MZ
358f947975
[SHELL32] Rewrite SHAddToRecentDocs (#2333) 
Rewrite shell32!SHAddToRecentDocs and use it in some applications.
Wine's SHAddToRecentDocs was not Unicode supported and unusable. I will dare to rewrite.
CORE-3588
 2020-02-14 11:05:21 +09:00
Katayama Hirofumi MZ
9fc87dacdb [SDK][INCLUDE] Fix and improve comctl32_undoc.h 2020-02-13 09:16:59 +09:00
Katayama Hirofumi MZ
1cf564c25f [SHELL32] Use background context if no item selected on File menu 
CORE-9467
 2020-02-12 12:14:15 +09:00
Katayama Hirofumi MZ
bc1519dd87
Shell Folders: Reject invalid characters (#2328) 
Reject invalid input filename characters by using shell32!SHLimitInputEdit function and IItemNameLimits interface. Improve SHLimitInputEdit to sanitize paste.
CORE-11701
 2020-02-12 09:18:24 +09:00
Serge Gautherie
9f4e8ef25b
[SHELL32] DoGetProductType(): Check RegQueryValueExW() dwType (#2331) 2020-02-11 17:36:12 +01:00
Katayama Hirofumi MZ
ea8a6d6fb7 [SHELL32] Fix and improve SHLimitInputEdit 
Use CallWindowProcW to call the subclass window procedure.
Use Wide functions explicitly.
CORE-11701
 2020-02-11 14:10:38 +09:00
Katayama Hirofumi MZ
9e53e7cd5b [SHELL32] DoGetProductType should check "LanmanNT" value. 
CORE-13795
 2020-02-11 13:11:58 +09:00
Katayama Hirofumi MZ
c6ed215eef [SHELL32] Initial implement SHLimitInputEdit (#2323) 
Popup balloon window is not implemented yet.
CORE-11701
 2020-02-10 15:57:30 +09:00
Katayama Hirofumi MZ
48160c74b7
[SHELL32][SYSSETUP] Add Product Options page to ReactOS Setup (#2315) 
- Add "Product Options" wizard page into ReactOS Setup.
- Implement CSIDL_Type_InMyDocuments CSIDL type.
- If the product type is workstation, then some special folders will be in My Documents.
CORE-13795
 2020-02-10 11:10:42 +09:00
Aaron Dewes
e5813c4644
Update german translation (#2291) 
* Update German translations

* Update translation again

* More translations

* Some fixes in the german translation

* Some more fixes

* Little translation tweak

* Updates to 2nd review

* Little update

* Add back keyboard accel for IDS_OPENFILELOCATION.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
 2020-02-08 12:55:53 +01:00
Bișoc George
a57f7b50c0
[SHELL32] Display the ReactOS version to the About dialog programmatically (#2276) 
The current control parameters don't fit well with the version string since ReactOS migrated from SVN to Git. However, modifying the resource parameters doesn't fix the problem as well because the string itself is dynamic (as it can change in words specially the build architecture if the version build is AMD64 or x86 for example).

CORE-16571
 2020-02-01 22:47:32 +01:00
Mas4hmad
228eeb7d79 [TRANSLATION] Update Indonesian Translation (#2268) 
- Update Indonesian translation for:
  BROWSEUI.DLL, COMCTL32.DLL, DEVMGR.DLL, IEFRAME.DLL, NETID.DLL, SHELL32.DLL,
  SYSSETUP.DLL, TIMEDATE.CPL, APPWIZ.CPL, ACCESS.CPL, DESK.CPL and TASKMGR.EXE.

- Add Indonesian translation for: MSHTML.DLL, OLEAUT32.DLL, INPUT.CPL and NTVDM.EXE.
 2020-01-26 18:29:38 +01:00
Katayama Hirofumi MZ
aacb9f0ccd [SHELL32] Improve comments of shell folder paths 2020-01-24 21:32:25 +09:00
Katayama Hirofumi MZ
85474211a1 [SHELL32][USERENV] Update Japanese special folder names 2020-01-24 21:27:50 +09:00
Thomas Faber
aee6cbc50a
[SHELL] Add SHOpenFolderAndSelectItems to shlobj.h. 2020-01-18 13:10:35 +01:00
7OMI
66f6d051eb [TRANSLATION] Add/update Hungarian translation for shell32, ieframe, browseui (#2127) 2020-01-14 18:52:38 +01:00
Katayama Hirofumi MZ
61737d1b3f
[SHELL32] Improve Japanese folder property sheet (#2247) 
Improve Japanese translation.
 2020-01-13 22:47:26 +09:00
Katayama Hirofumi MZ
bd5681c027
[SHELL32][SHLWAPI] Improve Japanese file property sheet (#2246) 
- Improve file property dialog (IDD_FILE_PROPERTIES).
- Translate shlwapi resource into Japanese.
 2020-01-13 22:33:50 +09:00
Jose Carlos Jesus
10f9a1cb62 [TRANSLATION] [SHELL32] Improvements to Portuguese translation (#2228) 
And minor adjustments because of text lenght.
 2020-01-10 13:44:55 +01:00
Suraj K Suresh
fbc14d52cd
[PSDK] Support STRICT_TYPED_ITEMIDS in shdeprecated.idl. CORE-16385 2020-01-03 22:42:35 +01:00
Suraj K Suresh
ecb3ee5427
[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385 2020-01-03 22:42:34 +01:00
Maxim Smirnov
06eb8cda99 [SHELL32] Fix extra fixme (#1975) 
This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`
 2020-01-02 13:35:32 +01:00
Hermès Bélusca-Maïto
9ba5594599
Happy New Year 2020 to everyone!! 
🎊 🎆 🍾 🥳

.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
   __,  ,__)            __,  ,__)       __, ,__)        ░░▄████▄░▄███▄░▄████▄░▄███▄░░
  (--|__| _ ,_ ,_      (--|\ | _       (--\ | _  _ ,_   ░░▀▀░▄██░██░██░▀▀░▄██░██░██░░
    _|  |(_||_)|_)(_|    _| \|(/_(_|_)     \|(/_(_||    ░░░▄██▀░░██░██░░▄██▀░░██░██░░
   (        |  |  ,_|   (                (__|           ░░██████░▀███▀░██████░▀███▀░░
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.

   ███████████████████████████████████████████████████████████████████████████████
   ██████████████████▓▒▒▒▒▒▒▓▓█████████████████████████▓▓▒▒▒▒▒▒▓██████████████████
   ███████████████▒▒▒▒▓▓███▓▓▓▒▒░▒▓▓█████████████▓▒▒░▒▒▓▓████▓▓▒▒▒▓███████████████
   █████████████▓░░░░░░░░░▒▒▓██████▓▒▒▒▓█████▓▒▒▒▓██████▓▒▒░░░░░░░░░▓█████████████
   ███████████▒▓░▒█████████▓▓▒░▒▓███▓▓▓▓▓▓▓▓▓▓▓▓████▒▒▒▒▓▓████████▓▒░▓▓███████████
   ██████████▒▒▓░▓██████████████▓▓▓▓▓█████▓▓▓▓▓▓▓▓▒▒███████████████▓░▓░▒██████████
   █████████▓░▓█░▓██████████▓▒▒▒▒▓▓▓▓███████▓▓▓▓▓▓▓▓▓▒▒▓███████████▓░█▒░▓█████████
   █████████▓▒██▒▒████████▒▒░░░░▒▒▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▒▒░█████████▒▒█▓▒▒█████████
   █████████▓░██▓░▓█████▓▓▒▒░░░░▒▒▓▓▓▓████▓▓▓▓▓▓▓▓▒▒▓▓▓▓▓▒░░▓█████▓░▓█▓░▓█████████
   ██████████░▓██▒▒▓██▓▓▓▓▓▒▒▒▒▒▒▓▓▓▓██████▓▓▓▓▓▓▒▒▒▒▒▓▓▓▓▒▒░░███▓░▒██▒░██████████
   ██████████▒▒▓██▒▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████▓▓▓▒▒▒▒▒▒▒▒▒▓▒▒▒▒░░▓█▒▒██▓░▓██████████
   ███████████▒▒███▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓████▓▓▓▓▓▓▒▒░▒▒▒▒▒▒▒▒▒░░░▒███▒▓███████████
   ████████████▒▒█▓▓▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒▒░░░░▒▒░░░▒▒▒░░░▓██▒▒████████████
   █████████████▒▒▒▒▒▒░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓▒▒░░░░░░░░░░░░░▒▒▒▓▒▒█████████████
   ██████████████░░▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒░░░░░░░░░▒░░▒░▒██████████████
   ██████████████▓▒░▒▒▒▒▒░░▒▒░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░▓███████████████
   ██████████████▓▒▓░░▒▒▒▒░░░░░░░░░░░░░░░░░▒▒▒▒▒▒░░░░░░░░░░▒░░░░░▓▒▓▓█████████████
   ███████████▓▒▓▓▓▒▒░░░░░▒▒░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░░▒▒▒█▒▒▓███████████
   ██████████▓▒▒█▓▓▒▒░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▓▒▒▒▒██▒▒▓██████████
   █████████▓▒▓██▓▒▒▒▒░░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▒▒▒▒▒▒▓███▓▒▓█████████
   ████████▓▒▓███▓▒▒▒▒░░░▒░░░░░░▒░░░░░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▓▓▒▒▓▒▓██▓▒▓████████
   ███████▓▒▓███▒▓▓▒▒▒░░░░░▒░░░░░░▒░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▓▓▓▓▒▒██▓▒▓██▓▒████████
   ███████▒▒██▓▒▓█▓▓▒▒░░░░░░░▒░░░░░░▒░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▒▓▓▓▒▒▓███▓▒███▒▓███████
   ██████▓▒▓██▒▒███▓▒▒▒░░░░░░░░▒▒░░░░░▒▒░░░░░░░░▒▒░░▒▓▓▓▓▒▒▒▒▒▒▓█████▒▒██▓░▓██████
   ██████▒▒██▒▒█████▓▒▒▒░░░░░░░░░▒░░░░░░░▒░░░░▒▒░░▒▓▒▒▒▒▒▒▒▒▒▒████████▒▒██▒▒██████
   ██████▒▓██░▓██████▓▓▒▒▒░░░░░░░░░░▒░░░░░░░▒░░░░▒▒▒▒▒▒▒▓▓▒▒██████████▒░██▒▒██████
   ██████▒▒▓▓▒█████████▓▓▒▒▒░░░░░░░░░░▒▒░░░░▒▒▒▓░░░▒▒▒▒▒▓▓████████████▓▒▓▓░▒██████
   ██████▓░▒▒▒███████████▓▓▒▒░░░░▒▒▒░▒░▒▒▒▒░░▒▒▒▒▒▓▒░░▒▒██████████████▓░▒▒▒███████
   ███████▓▒░░▒█████████▓▒▒░░▒▓▓▒▒▒░░░░▒▒▒▓▒▓▒░░▒▒▓▓██▓▓▒░▒▒▓█████████▒░░▒████████
   ██████████▒░░░░░░░▒▒▓▓█████▓▓▒░░▒▓██▓▓████████▒░▒▒▓██████▓▓▒▒░░░░░░░▒██████████
   ███████████▓▒▒▒▓▓████▓▓▒▒▒░▒▒█████████████████████▒▒░▒▒▓▓▓███▓▓▒▒▒▒████████████
   ████████████████▓▓▓▓▓▓███████████████████████████████████▓▓▓▓▓▓████████████████
   ███████████████████████████████████████████████████████████████████████████████
   ███████████████████████████████████████████████████████████████████████████████
   ██████████████████████████████████████████████████████████▓░░▓████████░░░▓█████
   ███▒░░░░▒▓███████████████████████████████████████▒█████▓▒▒▓██▓▒▒▓████▓░█▓░▓████
   ███▒█████░▒███▓▒▒▒▒▒▓████▓▒▒▒▒▒▓█▓███▓▒▒▒▒▒▒▓██▓▒░▒▒▓▒▓█████████▓▒██▓▒█████████
   ███▒█████░▒█▓▒▒█████▒▒██▒▒▓████▓░▒██▒▒▓████▓▒▓██▓░▓██▓███████████▓▓██▓░░░▒█████
   ███▒█▓░░▒▓█▓▒▒▓▒░░▒▓▒░▒▓▒███████▒▒██▒████████████░███▓███████████▓▓██████░▒████
   ███▒██░▓███▓▒▓█████████▓▒███████▒▒██▒████████████░███▒▓██████████▓████████░▓███
   ███▒███░▒▓██▓▒▒████▓▒▓██▓▒▒▓██▓▒░▒██▓▒▒▓███▓▒▓███░████▓▒▒█████▒▒▓███▓▒▓██░▓████
   ███▒████▓░▓████▒▒▒▒▒██████▓▒▒▒▒▓█▓████▓▒▒▒▒▓█████▒███████▓▒▒▒▒▓███████▒▒▒▓█████
   ███████████████████████████████████████████████████████████████████████████████
 2020-01-01 00:00:00 +01:00
Hermès Bélusca-Maïto
be19fda765
[SHELL32] Remove some trailing spaces; use explicitly global namespace for some functions. 2019-12-29 16:14:33 +01:00
Hermès Bélusca-Maïto
d967b5aa25
[BROWSEUI] Remove useless RegenerateUserEnvironment() call. 
[SHELL32]  Call RegenerateUserEnvironment() in WM_SETTINGCHANGE handler **ONLY** when lParam points to the L"Environment" string.
CORE-15147
 2019-12-29 16:14:26 +01:00
Hermès Bélusca-Maïto
1ee511a10c
[SHELL32] Fix MSVC warning warning C4390 by adding a bit more debug info. 2019-12-25 19:02:48 +01:00
Hermès Bélusca-Maïto
16f64a9533
[SHELL32] Improve the displayed error on file copy / displacement + simplify code. 
Also update the corresponding french translations, see CORE-16572.
And fix a regression introduced in 257e7307 that allowed again copying
or moving a directory into its sub-tree...

I also personally think that these checks must also be done within the
copy_files() / move_files() helpers instead?
 2019-12-24 18:30:54 +01:00
Bișoc George
8ec05f5fa1 [SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() (#2113) 
ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found.

PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures.

CORE-16535
 2019-12-12 08:24:20 +09:00
Katayama Hirofumi MZ
257e7307b4
[SHELL32] Fix hung-up of shell32:shlfileop (#2136) 
#2085 caused some failures and hung-up in shell32:shlfileop testcase. This PR will fix it.
CORE-16546
 2019-12-08 07:58:14 +09:00
Katayama Hirofumi MZ
2fad488a85
[SHELL32] Add 'm_' prefix to CFSFolder members (#2129) 
CORE-7585
 2019-12-05 05:35:25 +09:00
Katayama Hirofumi MZ
c082d08cf3 [SHELL32] Delete unused CNewMenu::m_wszPath 2019-12-03 13:46:35 +09:00
Katayama Hirofumi MZ
364e22fa14 [SHELL32] Improve Japanese translation 2019-12-02 07:03:18 +09:00
Katayama Hirofumi MZ
b582d6ff45
[SHELL32] Improve and fix SendTo (#2122) 
Because of timing of SendTo folder initialization, SendTo My Documents didn't work well.
Now My Documents item is working well. CORE-12562
 2019-12-02 04:06:20 +09:00
Shy Zedaka
b6743016f7 [TRANSLATION] Some Hebrew Translation for Shell32 (#2121) 2019-12-01 19:30:48 +01:00
Katayama Hirofumi MZ
f1bc04d7e6
[SHELL32][ZIPFLDR] Implement SendTo ZIP folder (#2118) 
Follow-up of #2114.
- s/Creater/Creator/
- Add an empty file in the SendTo folder.
- Trick.
CORE-16495
 2019-12-02 02:26:34 +09:00
Jose Carlos Jesus
62a95e4943 [TRANSLATION] Update Portuguese translation (#2115) 2019-12-01 10:14:13 +01:00
Katayama Hirofumi MZ
79d21f7664 [SHELL32] Fix regression of DoCreateSendToFiles 
CoInitializeEx/CoUninitialize added.
CORE-12562
 2019-12-01 13:55:43 +09:00
Katayama Hirofumi MZ
0e2bb5b0b8
[SHELL32] Validate file operation (#2085) 
- Support FOF_RENAMEONCOLLISION flag of SHFileOperationW.
- Add validate_operation function and use it in SHFileOperationW.

CORE-10225
 2019-11-30 15:36:16 +09:00
Katayama Hirofumi MZ
5734570a15
[BOOT][SHELL32][INCLUDE] Support 'SuperHidden' files (#2102) 
PR #2101 shows desktop.ini files on Desktop. I want to hide them.
- Add "ShowSuperHidden" setting to Explorer.
- Add SHCONTF_INCLUDESUPERHIDDEN flag.
- Support SHCONTF_INCLUDESUPERHIDDEN in Explorer.
CORE-10045
 2019-11-29 15:14:18 +09:00
Katayama Hirofumi MZ
2c272a9017
[SHELL32] Add desktop.ini more to some folders (#2101) 
Provides special icons for special folders by adding desktop.ini. CORE-10045
 2019-11-29 14:40:04 +09:00
Katayama Hirofumi MZ
5538facfdd
[SHELL32] Add SendTo DeskLink (Retry) (#2099) 
CORE-12562
 2019-11-27 20:09:19 +09:00
Jared Smudde
30e0c2430d [SHELL32] Disable all controls during format and re-enable after format is complete. (#2098) 2019-11-27 09:18:50 +01:00
Katayama Hirofumi MZ
cfdbccf937
[SHELL32] Follow-up of #2076 (#2091) 
Fix EXE and SCR file icons. CORE-16533
 2019-11-26 21:45:58 +09:00
Katayama Hirofumi MZ
bd25333e24
[SHELL32] Make SHFormatDrive multi-thread (#2080) 
CORE-12756
 2019-11-26 18:26:25 +09:00
Katayama Hirofumi MZ
cd75a87cfd
[SHELL32] Improve DragEnter of CFSDropTarget (#2073) 
Reduce failures of DragDrop testcase. CORE-11238
 2019-11-26 17:34:24 +09:00
Katayama Hirofumi MZ
399854ce31
[SHELL32] Set default exe icon (#2076) 
The default icon of an exe file was empty if no icon available from exe.
CORE-10480
 2019-11-24 19:26:32 +09:00
Katayama Hirofumi MZ
a2d5a5c301
[SHELL32] Add SVG files of 'Rename' icon (#2084) 
@milawynsrealm has provided the source of 242.ico as svg files. CORE-11736
 2019-11-23 14:18:20 +09:00
Katayama Hirofumi MZ
a4deb3f8f1
[SHELL32] Change icon of SendTo My Documents (#2083) 
Follow-up of #2027. CORE-16496
 2019-11-23 14:10:13 +09:00
Katayama Hirofumi MZ
9e20604a5f
[SHELL32] Add Tango icons download URL (#2079) 
Add a download URL for referencing source. CORE-11736
 2019-11-22 23:52:35 +09:00
Serge Gautherie
0f92924a99 [REACTOS] Use explicit StringCb*W() (#2069) 2019-11-21 00:47:06 +01:00
Katayama Hirofumi MZ
79b030219f
[SHELL32] Improve icon selection upon right click (#2063) 
If the Right-Clicked item is not being selected, then reset the selection and select the Right-Clicked item. CORE-16519
 2019-11-20 20:37:57 +09:00
Katayama Hirofumi MZ
aedba8441a
[SHELL32] Improve UI of drive formatting (#2048) 
- Add stub window (StubWindow32) to the drive formatting dialog to avoid locked.
- Separate the thread of drive formatting.
- Move CStubWindow32 codes.
CORE-12756
 2019-11-20 10:00:26 +09:00
Joachim Henze
dc047f9630 [BROWSEUI][SHELL32] Fix scroll to selection CORE-16504 
A patch by Katayama Hirofumi MZ

The bug was unhidden by
0.4.14-dev-312-g
b931f643e3
 2019-11-17 02:04:27 +01:00
Katayama Hirofumi MZ
8f129932dd
[SHELL32] Simply return S_OK if *pdwEffect is none (#2039) 
IDropTarget::DragEnter must simply return S_OK if *pdwEffect == DROPEFFECT_NONE. CORE-11238
 2019-11-15 18:02:06 +09:00
Katayama Hirofumi MZ
90c63d12a1
[SHELL32][BOOTDATA] Implement Command Prompt here (#2029) 
Add "Command Prompt here" menu item to the Right-click menu of normal folders and drives. Currently, this menu item doesn't work correctly because of the bug of pushd. CORE-12150
 2019-11-14 23:25:21 +09:00
Katayama Hirofumi MZ
d037003511
[SHELL32] Add SendTo My Documents (#2027) 
If SendTo folder is empty in SHGetFolderPathAndSubDirW function, then add a shortcut file linked to My Documents. CORE-16496
 2019-11-12 16:54:28 +09:00
Katayama Hirofumi MZ
c0f340bca5
[SHELL32] Implement 'Open file location' of shortcut files (#2028) 
"Open file location" is a feature to open the location of the target of a shortcut file.
Ideally we should probably use SHOpenFolderAndSelectItems here, but that is not 100% implemented in ros yet... CORE-12770
 2019-11-12 16:47:36 +09:00
Katayama Hirofumi MZ
3b2ead064f
[SHELL32] Follow up of #2021 (#2022) 
- Delete IObjectWithSite interface.
- Use PIDLIST_ABSOLUTE and PITEMID_CHILD rather than LPITEMIDLIST.
- Move CLSID_SendToMenu to shlguid_undoc.h.
- Delete unnecessary codes.
CORE-12562
 2019-11-11 00:37:23 +09:00
Katayma Hirofumi MZ
4a1cd04501 [SHELL32] Improve Japanese translation 2019-11-09 19:57:51 +09:00
Pierre Schweitzer
15a703503e
[SHELL32] Update French translation 
CORE-12562
 2019-11-09 10:19:10 +01:00
Katayama Hirofumi MZ
5308a606dc
[SHELL32] Initial SendTo implementation (#2021) 
This PR will realize SendTo feature. Initially, there is no file in SendTo folder (displayed as "(None)"). If you added some shortcut files, then SendTo shows some menu items.
- Copy, Move, and Link are working.
- Added icons.
CORE-12562
 2019-11-09 08:08:40 +09:00
Mark Jansen
1f362c1a5a
[SHELL32] CDefaultContextMenu: Don't render a medium just to query if it is present 2019-10-20 17:10:12 +02:00
Mark Jansen
e45beb55f8
[SHELL32] CDefaultContextMenu: Always add the wanted operation to the IDataObject 2019-10-20 17:10:12 +02:00
Mark Jansen
c31327114b
[SDK][SHELL32] Augment the internally used IDataObject with some extra formats 
This is needed because our code seems to use CF_HDROP a lot, instead of HIDA...
 2019-10-20 17:10:12 +02:00
Mark Jansen
f9d3c2c608
[SHELL32] Mark an unexpected failure as unexpected 2019-10-20 17:10:11 +02:00
Mark Jansen
75cabb07be
[SHELL32] Properly release an StgMedium 2019-10-20 17:10:11 +02:00
Mark Jansen
730a99c860
[SHELL32] Update CDataObject, 
allowing it to accept new formats and behave a bit more like windows
 2019-10-19 18:42:15 +02:00
Mark Jansen
5d54b65ceb
[SHELL32] Add support for custom View objects defined with UICLSID 
CORE-16271
 2019-10-19 18:42:15 +02:00
Mark Jansen
5d7ae44059
[SHELL32] Demote an ERR to WARN 2019-10-19 18:41:52 +02:00
Mas4hmad
f84bd4f393 [TRANSLATION] Add/Update Indonesian translations (#1904) 
Add/Update Indonesian translations for CHARMAP, CMDUTILS-HELP, SERVMAN, SETUPAPI, SHELL32, SUBST, SYSSETUP, TASKMGR, USERINIT.
 2019-10-08 17:03:14 +02:00
Thomas Faber
a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403 
Fixes one of many crashes in shell32_winetest:shlfolder.
 2019-09-29 12:42:26 +02:00
Thomas Faber
be1f95527a
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:39 +02:00
Thomas Faber
b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:02 +02:00
Thomas Faber
6b0d2c2a2c
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385 
Addendum to c2b476bd77.
 2019-09-29 12:07:43 +02:00
Shy Zedaka
acaff47682 [BROWSEUI][SHELL32][TRANSLATION] Major Translations to BROWSEUI And New Search function to Hebrew, and Some Other changes. (#1938) 2019-09-26 22:18:59 +02:00
Thomas Faber
c2b476bd77
[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385 2019-09-22 16:19:11 +02:00
Thomas Faber
b90c24d640
[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385 2019-09-22 16:19:09 +02:00
Thomas Faber
faae7e5790
[SHELL32] Handle BYREF variants in CFolderItems::Item. 
Fixes crash in shell32_winetest:shelldispatch.

See also:
6634b31520
 2019-09-22 11:41:57 +02:00
Adam Słaboń
c81af08f51 [TRANSLATION] Polish translation update (#1916) 
Added translation for netstat, utilman and netplwiz. Updated translation of find, reg, rapps, regedit, sndvol32, usetup, hivesys, mmsys, openglcfg, powercfg, sysdm, shellext, browseui, devmgr, msgina, netcfgx, shell32, syssetup, shortcuts and vcdcontroltool.
 2019-09-20 21:51:47 +02:00
Brock Mammen
957a604b36 [SHELL32] Implement CDefView::AddObject() 2019-09-15 19:46:36 +03:00
Brock Mammen
e7e551afda [SHELL32] Make SHFindFiles open the search results folder 2019-09-15 19:46:36 +03:00
Ioannis Adamopoulos
e419195d37 [HEADERS] Move some helpers from undocshell.h to shellutils.h as they didn't cover anything undocumented. Merge traycmd.h in undocshell.h as both contain just undocumented shell definitions. 2019-08-25 12:20:52 +03:00
Shy Zedaka
cc8180fe63 [TRANSLATION] Change the recycle bin from 'Trash' to 'Recycle bin' 2019-08-21 18:49:59 +02:00
Serge Gautherie
cb77f1701f [SHELL32][STOBJECT] Enforce ShellExecuteW(..., file, parameters, ...) 
CORE-16299
 2019-08-19 13:01:08 +02:00
Jose Carlos Jesus
0b4510301b
[SHELL][COMCTL32] pt_PT_Translation Improvements 2019-08-16 19:32:23 +02:00
Shy Zedaka
a3944563c3 [SHELL32] Run Dialog Text Fix 2019-08-15 20:03:55 +02:00
Katayama Hirofumi MZ
944aba1fcc
[SHELL32] Fix Desktop Properties menu item action (#1833) 
1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.

The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299
 2019-08-15 23:10:06 +09:00
Shy Zedaka
187c9fc33c [Translation] More Hebrew Translations 
Co-authored-by: Baruch Rutman <peterooch@gmail.com>
 2019-08-15 13:41:01 +02:00
Mark Jansen
c96ba1aff2
[SHELL32] CDefView: Improve the context menu positioning 
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.
 2019-08-15 11:28:31 +02:00
Joachim Henze
0f16d44b66 [SHELL32] Improve ShellExecute 
This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.

Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.

Automated tests do improve as well
VBox https://reactos.org/testman/compare.php?ids=68662,68696
KVM https://reactos.org/testman/compare.php?ids=68663,68697

I intend to merge this back into 0.4.12RC.
 2019-08-06 20:24:55 +02:00
Mark Jansen
b5423ba70b
[SHELL32] Fix SHCreateDirectoryExW showing an error on success 
CORE-15145
 2019-07-09 22:52:17 +02:00
Bișoc George
019e3ffe5f
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. (#1688) 
CORE-12313

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
 2019-07-07 19:01:09 +02:00
Hermès Bélusca-Maïto
8a30801516
[SHELL32] Recycle-Bin: Minor code enhancements. 
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
 2019-07-07 17:56:51 +02:00
Bișoc George
818d660868 [SHELL32] Enable the "Apply" button when user takes action on the edit box control (#1720) 
CORE-12312
 2019-07-07 14:47:44 +02:00
Stanislav Motylkov
a76e03d8bc [SHELL32][USERENV] Improve Russian translation (#1710) 
CORE-16170
 2019-07-01 21:43:22 +02:00
Jose Carlos Jesus
86d4156c39
[TRANSLATIONS] Add/Update Portuguese (neutral) translations. (#1687) 
Translations for SYSDM.CPL, SETUPAPI, SHELL32, LSASRV, SAMSRV, SYSSETUP,
USRMGR, THEMEUI, USERENV, WININET, MSCONFIG.
 2019-06-29 16:55:33 +02:00
Yaroslav Kibysh
b2e4ff8cfd
[SHELL32] Update Ukrainian translation. (#1637) 2019-06-10 16:45:20 +02:00
Serge Gautherie
8a8453494f [SHELL32] SHCreateShellFolderView(): Fix parameter validation order. (#1632) 
Fixes one modification from commit ae2a85d0.
CORE-16098
 2019-06-09 15:57:45 +02:00
Hermès Bélusca-Maïto
ae2a85d003
[SHELL32] Fix some NULL-pointers validation. 
- In the exported SHCreateDefaultContextMenu() and
  IDataObject_Constructor() functions (called amongst others by
  the exported CIDLData_CreateFromIDArray() function).

- In the exported SHCreateShellFolderView() function.

- In CDefView::GetItemObject(), where data was written to *ppvOut before
  ppvOut was being checked for NULL.
 2019-06-08 19:43:02 +02:00
Yaroslav Kibysh
4d44e11f1e
[SHELL32] Update Ukrainian translation. (#1623) 2019-06-08 17:58:42 +02:00
Jose Carlos Jesus
7f5e960e32
[TRANSLATIONS] Update/Add Portuguese translations. 
Translations for: reactos/setup, usetup, syssetup, netshell, shell32.
 2019-05-26 21:19:31 +02:00
Hermès Bélusca-Maïto
62823a08ce
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry. 2019-04-24 03:41:41 +02:00
Hermès Bélusca-Maïto
0416c598f8
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem(). 2019-04-24 03:36:27 +02:00
Katayama Hirofumi MZ
8e60c2efee
[SHELL32] Implement 'New Link' (Retrial of #1510), CORE-15511 (#1518) 
Correctly create cache about ".lnk" and handling in the member functions.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
 2019-04-24 03:28:17 +02:00
Mark Jansen
f5731a41f8
[SHELL32] Use the same definitions for shell32 and it's static libs 2019-04-18 19:21:37 +02:00
Mark Jansen
9824a0154e
[ATL] Retire atlnew 2019-04-18 19:21:37 +02:00
Timo Kreuzer
146096cd2e [3RDPARTY] Make some warnings non-fatal 2019-04-13 14:07:50 +02:00
Timo Kreuzer
f9a967b2ae [REACTOS] Fix misc 64 bit issues 2019-04-13 14:07:50 +02:00
Katayama Hirofumi MZ
c65156002c
[SHELL32] Fix SHFileOperation Move operation (#1487) 
Reduce failures of Move operation of shell32!SHFileOperation function. CORE-13450
 2019-04-08 21:59:33 +09:00
Katayama Hirofumi MZ
f762aa3dd2 [SHELL32] Fix explorer file item label background CORE-15937 2019-04-07 21:38:00 +09:00
Jérôme Gardou
23373acbb9 [CMAKE] Use modules instead of shared libraries 
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.

On my system, this reduces the configure-time by a factor of two.
 2019-04-06 17:43:38 +02:00
Katayama Hirofumi MZ
6150baf414 [SHELL32] pl-PL.rc escape sequence fix 2019-04-06 11:41:08 +09:00
Adam Słaboń
7047aa80ef [TRANSLATION] Polish translation update 
Polish translation update for calc, fltmc, magnify, notepad, osk, sndvol32, usetup, fdebug, appwiz, mmsys, sysdm, acppage, ziplfdr, browseui, cryptui, jscript, shell32, themeui and inf. Added translation for cyrptext, vcdcontroltool, and (not yet complete) getuname.
 2019-04-05 10:34:10 +02:00
Katayama Hirofumi MZ
d04b4e65d6
[SHELL32] Implement Explorer background image (Retrial of #801) (#1463) 
IconArea_Image, IconArea_Text and IconArea_TextBackground values in desktop.ini in a folder will be supported. It denies network paths. CORE-5516
 2019-04-05 07:59:35 +09:00
Maxim Smirnov
39c0fd5722 [SHELL32] Fix version info in the file dialog 2019-04-03 00:51:24 +02:00
Yaroslav Kibysh
a30e644dc4 [EXPLORER][SHPOLICY] Implement "NoSimpleStartMenu" policy (#1258) 
- Enable "New Start Menu" control for all languages.
- Implement the "NoSimpleStartMenu" policy in shpolicy.c and its usage in explorer.
- Hide controls instead of disabling (as in Win XP/Vista).
 2019-03-24 14:56:43 +01:00
Stanislav Motylkov
cc99d3ad5f [SHELL32] Add line bar to About dialog for consistence 
Addendum to f9d2931. CORE-15215
 2019-03-23 19:11:28 +01:00
Yaroslav Kibysh
3999e875be [SHPOLICY] Fix the missing backslash in SHRestricted. CORE-15666 (#1267) 
Import Wine commit https://source.winehq.org/git/wine.git/?a=commit;h=dbbfa481539acd29de47ff6cd5cc2d24a2e01871

Original patch from Yaroslav Kibysh, reported to Wine and committed there by Fabian Maurer.
Thank you all!
 2019-03-23 18:28:39 +01:00
Jared Smudde
6707efc534 [SHELL32] Disable the Hardware tab in the properties dialog for Network drives (#1249) 
This matches Windows behaviour.
 2019-03-16 15:37:56 +01:00
Ged Murphy
0649f25b48 [SHELL32] Implement SHTestTokenMembership and forward IsUserAnAdmin to it 
Moved to the bottom of the file with the other ros functions to help keep wine syncs easier.
 2019-03-04 11:54:43 +00:00
Joachim Henze
1d7287288d [SHELL32] Update all languages RCs to fix possible text truncation CORE-15765 
IDD_BROWSE_FOR_FOLDER displays text controlled by the calling applications in
IDC_BROWSE_FOR_FOLDER_TITLE. Its old height could lead to text truncation
for existing 3rd party apps.
The new height value for IDC_BROWSE_FOR_FOLDER_TITLE
was inspired by IDC with the same from dialog IDD_BROWSE_FOR_FOLDER_NEW.
I could change all languages to the same height,
as dimensions of the dialog and surrounding controls were same.
 2019-03-03 02:23:34 +01:00
Luo Yufan
ca9cdce760 [TRANSLATION] Update Chinese and Traditional Chinese translations. (#1369) 2019-02-25 00:36:53 +01:00
Mark Jansen
d766391231
[SHELL32] Abort change notifications on a nullptr 
CORE-15703
 2019-02-18 23:00:31 +01:00