Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-24 17:34:57 +00:00
Code Issues Projects Releases Packages Wiki Activity
76904 commits 97 branches 276 tags 2.1 GiB
Commit graph

2271 commits

Author SHA1 Message Date
Amine Khaldi
1c94266177 [INETMIB1] Sync with Wine Staging 4.18. CORE-16441 2019-11-02 18:35:29 +01:00
Amine Khaldi
ae07dd64af [INETCOMM] Sync with Wine Staging 4.18. CORE-16441 2019-11-02 18:35:04 +01:00
Amine Khaldi
9ece2deded [IMM32] Sync with Wine Staging 4.18. CORE-16441 2019-11-02 18:34:15 +01:00
Amine Khaldi
bee818a28a [IMAGEHLP] Sync with Wine Staging 4.18. CORE-16441 2019-11-02 18:33:24 +01:00
Amine Khaldi
c3cabdbf31 [IEFRAME] Sync with Wine Staging 4.18. CORE-16441 2019-11-02 18:32:59 +01:00
Amine Khaldi
ebcc4c6109 [HTTPAPI] Sync with Wine Staging 4.18. CORE-16441 2019-11-02 18:32:29 +01:00
Amine Khaldi
61d79795bd [HLINK] Sync with Wine Staging 4.18. CORE-16441 2019-11-02 18:30:25 +01:00
Katayama Hirofumi MZ
a63678c9a9
[KERNEL32] Fix MultiByteToWideChar(CP_UTF8, ...) (#2007) 
CP_UTF8 validation was not strict. 5- or 6-byte length sequences are invalid in RFC 3629 UTF-8. CORE-16468

- Fix MultiByteToWideChar(CP_UTF8, ...) by making check strict.
 2019-11-02 14:16:26 +09:00
Eric Kohl
a95a0b61bd [SETUPAPI] Add support for the optional StartName entry in inf file service install sections 2019-11-02 00:17:33 +01:00
Oleg Dubinskiy
218118e994 [CRYPTEXT] Add Ukrainian translation (#1999) 2019-10-28 15:27:03 +01:00
Eric Kohl
a2f4e191f4 [DNSAPI] Get rid of the internal/windns.h file. 2019-10-27 23:20:26 +01:00
Eric Kohl
b79246c534 [DNSAPI] Add the Resolver Service RPC client code and implement DnsFlushResolverCache() 
Patch by Peter Hater and Christoph von Wittich.
Slightly modified by me.

CORE-12159
 2019-10-27 20:38:25 +01:00
Serge Gautherie
e133817811 [CMAKE] Use modules instead of shared libraries 
Follow-up to 23373acbb9.
2 missed cases: apisets, lunar.msstyles.
4 new cases: w32time, netplwiz, msxml3r, mizu.msstyles.
 2019-10-27 09:51:28 +01:00
Serge Gautherie
cef6a5b691 [D3D8][D3D9][DDRAW][WINED3D] Use modules instead of shared libraries 
This reverts part of (revert) commit 81cffd7658,
so restores 23373acbb9.
 2019-10-27 09:50:38 +01:00
Eric Kohl
789edebfac [IPCONFIG][DNSAPI][SDK] Renamed DNSCACHEENTRY and fixed its type field(s) 
Now, 'ipconfig /displaydns' displays A- and AAAA-records correctly.
 2019-10-27 08:35:03 +01:00
Amine Khaldi
0c64ffd3ab [COMDLG32] Improve some header inclusions. 2019-10-26 23:11:08 +01:00
Amine Khaldi
6cbb644524 [HHCTRL.OCX] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:57:01 +01:00
Amine Khaldi
88179a5d0f [FUSION] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:56:11 +01:00
Amine Khaldi
683b9f8f98 [FAULTREP] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:55:45 +01:00
Amine Khaldi
b81745a3a0 [CRYPTUI] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:55:21 +01:00
Amine Khaldi
f4663f8ef0 [CRYPTNET] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:54:32 +01:00
Amine Khaldi
e6e75f1cb3 [CRYPTDLL] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:54:07 +01:00
Amine Khaldi
2fdfd36ca5 [CRYPTDLG] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:53:42 +01:00
Amine Khaldi
98ef8700d2 [CREDUI] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:53:18 +01:00
Amine Khaldi
ce73ea1e08 [COMPSTUI] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:52:52 +01:00
Amine Khaldi
5981ef3ecc [COMDLG32] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:52:27 +01:00
Amine Khaldi
00f14ee1f2 [COMCTL32] Sync listview.c and progress.c with Wine Staging 4.18. CORE-16441 2019-10-26 22:51:10 +01:00
Amine Khaldi
0e4180451f [CABINET] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:50:17 +01:00
Amine Khaldi
854ed51035 [AVIFIL32] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:49:48 +01:00
Amine Khaldi
ac78751192 [ATL80] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 22:49:13 +01:00
Pierre Schweitzer
96ca9e39f8
[BROWSEUI] Update French translation 
Addresses changes done in 103c87d

CORE-16427
 2019-10-26 22:11:18 +02:00
Amine Khaldi
51373fdd86 [ATL] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:08:57 +01:00
Amine Khaldi
fa8d16a0eb [ADVPACK] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:08:05 +01:00
Amine Khaldi
a8f780a9db [ACTIVEDS] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:07:38 +01:00
Amine Khaldi
ee5f98cc00 [D3DXOF] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:07:07 +01:00
Amine Khaldi
b25254dcda [MSDMO] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:06:37 +01:00
Amine Khaldi
d6c879a0e0 [DXDIAGN] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:05:45 +01:00
Amine Khaldi
4188095a3a [DPNHPAST] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:05:19 +01:00
Amine Khaldi
eed824362a [DPLAYX] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:04:51 +01:00
Amine Khaldi
c1cf2ac305 [DMUSIC] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:04:24 +01:00
Amine Khaldi
41c8c312e1 [DINPUT] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:03:34 +01:00
Amine Khaldi
3d017d7150 [D3DRM] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:01:38 +01:00
Amine Khaldi
7ce1a24a8b [D3DCOMPILER_43_WINETEST] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:01:05 +01:00
Amine Khaldi
dffb99c172 [D3DCOMPILER_43] Sync with Wine Staging 4.18. CORE-16441 2019-10-26 13:00:33 +01:00
Jared Smudde
a270e5b053 [APPWIZ] Very minor icon fix for the Create Shortcut wizard. (#1993) 
Also cleaned up the other icons to reduce size.
 2019-10-24 13:58:04 +02:00
Serge Gautherie
c8cbd566f9 [HDWWIZ] ProbeListPageDlgProc(): Top 'Item' variable is enough (#1990) 
Addendum to ce498aa571.
 2019-10-22 10:12:04 +09:00
Joachim Henze
082f230ac7 [WINED3D] Workaround regression CORE-15408 
Many 3D applications crashed with 'WineD3D fake window' msgbox
if they were used in VirtualBox with graphics driver
'VBoxDisp.sys from VM guest additions + installed 3D acceleration'

That was a regression of SVN r75847 == git
3d13ed394e

Contrary we had no such issues with the SW emulation.
The reason for the bug is that
VBoxDisp only supports OpenGL 2.1 (GLSL 120) and WineD3D
tried to use shaders for OpenGL 3.2 (GLSL 150).

This workaround disables the usage in a hard-coded way for
all graphics adapters. Should be ok for now, as ros does not
really support any modern GPU drivers yet.
Proper working runtime detection would be better ofc.

Thx to Doug Lyons & Fabian Maurer
 2019-10-22 03:07:09 +02:00
Katayama Hirofumi MZ
6cca46453c [SHELLEXT][ZIPFLDR] Performance: Initialize m_Filename quickly 2019-10-22 09:55:06 +09:00
Katayama Hirofumi MZ
72e5c2e77c [CPL][DESK] hShell32 is always non-NULL in epilogue 2019-10-22 09:43:34 +09:00
Katayama Hirofumi MZ
ce498aa571 [CPL][HDWWIZ] Move 'Index' and 'Item' variables to prologue 2019-10-22 09:41:09 +09:00
Joachim Henze
f2f833c53c [COMCTL32] Address regression CORE-14622 
"Avira Antivir Personal 6.35.00.243" had issues painting its
setup wizard dialog with correct background color.
That part was a regression of SVN r74136 == git
b1b42795a9

and also did not draw its umbrella bmp, which did never work
in ros up to now afaik.

https://reactos.org/testman/compare.php?ids=69394,69478 VBOX
https://reactos.org/testman/compare.php?ids=69395,69479 KVM

Thanks to patches author Doug Lyons and HBelusca.

Wine has been reported to be affected by that bug as well:
https://bugs.winehq.org/show_bug.cgi?id=46636
Not sure whether our patch will be accepted by Wine,
to my naive eye this looks like an interim solution.
 2019-10-22 01:10:28 +02:00
Eric Kohl
4455dcb26e [DNSAPI][REACTOS] Add a header for undocumented dnsapi functions and use it in dnsapi.dll 2019-10-20 23:13:46 +02:00
Amine Khaldi
7c98f2203d [HNETCFG] Sync with Wine Staging 4.18. CORE-16441 2019-10-20 20:03:33 +01:00
Amine Khaldi
c1585bb868 [DEVENUM] Sync with Wine Staging 4.18. CORE-16441 2019-10-20 18:56:05 +01:00
Mark Jansen
1f362c1a5a
[SHELL32] CDefaultContextMenu: Don't render a medium just to query if it is present 2019-10-20 17:10:12 +02:00
Mark Jansen
e45beb55f8
[SHELL32] CDefaultContextMenu: Always add the wanted operation to the IDataObject 2019-10-20 17:10:12 +02:00
Mark Jansen
c31327114b
[SDK][SHELL32] Augment the internally used IDataObject with some extra formats 
This is needed because our code seems to use CF_HDROP a lot, instead of HIDA...
 2019-10-20 17:10:12 +02:00
Mark Jansen
f9d3c2c608
[SHELL32] Mark an unexpected failure as unexpected 2019-10-20 17:10:11 +02:00
Mark Jansen
75cabb07be
[SHELL32] Properly release an StgMedium 2019-10-20 17:10:11 +02:00
Mark Jansen
87fa11f54b
[FONTEXT] Return the correct error in GetDisplayNameOf 2019-10-20 17:10:04 +02:00
Eric Kohl
2ed4b3f780 [NETCFGX] Free all component data on INetCfg_fnUninitialize() 2019-10-20 15:01:55 +02:00
Thomas Faber
c1eccaffaa
[MBEDTLS] Update to version 2.7.12. CORE-16440 2019-10-20 12:46:35 +02:00
Mark Jansen
d9e7c48c1a
[FONTEXT] Initial implementation 
Create Fonts\desktop.ini when registering the shell ext
Also list the shell extension as needing to be registered at install
CORE-14690
 2019-10-19 18:42:15 +02:00
Mark Jansen
730a99c860
[SHELL32] Update CDataObject, 
allowing it to accept new formats and behave a bit more like windows
 2019-10-19 18:42:15 +02:00
Mark Jansen
5d54b65ceb
[SHELL32] Add support for custom View objects defined with UICLSID 
CORE-16271
 2019-10-19 18:42:15 +02:00
Mark Jansen
a99325c716
[ZIPFLDR] Fix number of menu items returned for DFM_MERGECONTEXTMENU 2019-10-19 18:42:14 +02:00
Mark Jansen
5d7ae44059
[SHELL32] Demote an ERR to WARN 2019-10-19 18:41:52 +02:00
Joachim Henze
a01b272578 [BROWSEUI][SHELLFIND] Update de-DE.rc CORE-16427 
Translate the new checkboxes text to german

Addendum to 0.4.14-dev-60-g
103c87d2b9
 2019-10-19 16:36:02 +02:00
Doug Lyons
103c87d2b9
[SHELLFIND] Add Hidden Files & Folders Selection. CORE-16427 2019-10-19 15:57:34 +02:00
Pierre Schweitzer
c290ae21c7
[WSHTCPIP] Print IOCTL as hexa value 2019-10-19 12:04:40 +02:00
Serge Gautherie
a8236e3fa9 [MSAFD] SizeOf*Buffer: Type is ULONG, not INT/DWORD 2019-10-19 10:50:03 +02:00
Serge Gautherie
3f0ba492ad [MSAFD] WSPSetSockOpt(): Fix a copypasta 
Addendum to 6bc61f63f1.

CORE-15804
 2019-10-17 08:18:43 +02:00
Joachim Henze
cd2a274ef7 [BROWSEUI][SHELLFIND] Allow to 'Open Containing Folder' 
of a search result again.

The feature regressed by 0.4.13-dev-1133-g
a3ee648d8b

I chose the shorter solution of Brock Mammen instead
of the patch of Doug Lyons from PR1960.

Still many thanks to Doug Lyons for his encouragement
in creating a fix as well and performing
regression-testing.

I intend to merge that back into 0.4.13RCs as well.
 2019-10-12 15:44:58 +02:00
Mas4hmad
f84bd4f393 [TRANSLATION] Add/Update Indonesian translations (#1904) 
Add/Update Indonesian translations for CHARMAP, CMDUTILS-HELP, SERVMAN, SETUPAPI, SHELL32, SUBST, SYSSETUP, TASKMGR, USERINIT.
 2019-10-08 17:03:14 +02:00
Eric Kohl
80db055135 [SYSSETUP][NETCFGX][INF] Install the TCPIP protocol driver properly 
Get rid of the special RandomProtocolGUID_TCPIP :-)
Works with the Setup CD and Live CD.
 2019-10-06 22:36:19 +02:00
Doug Lyons
b6b7bda443 Shell Find Improvements to make Search Item general and Show Sub-directories (#1927) 
* Shell Find Improvement to make Search Item general by adding asterisks before and after before search and show sub-directories in find listing. CORE-16152
 2019-10-05 16:32:49 +02:00
Joachim Henze
36d9e80add [D3DCOMPILER_43] Addendum to last commit CORE-14955 & CORE-15652 
GCC Linux build had no issues with the last commit but
MSVC x86 & x64 v18.0.31101.0 choked on it with
error C4133: 'function' : incompatible types - from 'D3D_PRIMITIVE *' to 'DWORD *'
and similar.

I could not retest with that exact version of MSVC, but the mentioned problems
vanished for me when compiling locally with MSVC 16.0.40219.1 x86.
Fingers crossed, that this makes the builders happy again!
 2019-10-03 21:16:39 +02:00
Joachim Henze
81cffd7658 [D3D8][D3D9][DDRAW][D3DCOMPILER_43][WINED3D] Revert to Wine Staging 3.3 
Avoid regressions CORE-14955 "Ddraw fullscreen crashes" and CORE-15652

This brings us back to before guilty commit 0.4.10-dev-55-g
7af3969e9f

and therefore downgrades
dll/directx/wine/
D3D8,D3D9,DDRAW,D3DCOMPILER_43,WINED3D
to WineStaging 3.3.
Also downgrades related header sdk/include/reactos/wine/wined3d.h
and for the first time also media/doc/README.WINE

Same versions of these dlls we had in every ros rls since 0.4.10rls.
Amine Khaldi agreed to perform this revert also for master now.

Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
 DxDiag crashed when switching to fullscreen (CORE-14955),
 Diablo II crashed immediately (CORE-15652),
 Monster-Truck-Madness 2 demo crashed after main menu

Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.

squashed commit of 0.4.13-RC-2-g
67dd70e5ef
and 0.4.13-RC-3-g
9f1e2cd172
 2019-10-03 18:38:29 +02:00
Pierre Schweitzer
0ce3941b41
[KERNEL32] Fix FIXME by calling appropriate function in GetNativeSystemInfo() 2019-10-02 10:52:00 +02:00
Thomas Faber
a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403 
Fixes one of many crashes in shell32_winetest:shlfolder.
 2019-09-29 12:42:26 +02:00
Thomas Faber
be1f95527a
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:39 +02:00
Thomas Faber
b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:02 +02:00
Thomas Faber
6b0d2c2a2c
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385 
Addendum to c2b476bd77.
 2019-09-29 12:07:43 +02:00
Shy Zedaka
acaff47682 [BROWSEUI][SHELL32][TRANSLATION] Major Translations to BROWSEUI And New Search function to Hebrew, and Some Other changes. (#1938) 2019-09-26 22:18:59 +02:00
Eric Kohl
bf854f5372 [POWERCFG] Fix the Indentation. No code changes! 2019-09-25 10:52:45 +02:00
Lee Schroeder
43f03da358 [MSXML3R] XML/XSL file description localization (#1926) 
Add localization for the file description of both XML and XSL file formats.
Please check for copypasta errors!

CORE-16390

Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
 2019-09-23 23:30:53 +02:00
Abdulganiev Rafael
9dd71e12b9 [TRANSLATION] Russian translation for browseui (#1928) 
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
 2019-09-23 23:28:46 +02:00
Joachim Henze
a40331b0f4 [COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093 
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147

But greatly eliminates perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.

I committed the same workaround already into 0.4.12-RC-30-g
9513c9bf12

CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de714c

CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476074
 2019-09-22 21:17:10 +02:00
Joachim Henze
b7f62b9bf9 [BROWSEUI] RC de-DE of Search feature & Folderoptions caption CORE-16392 2019-09-22 19:11:39 +02:00
Thomas Faber
c2b476bd77
[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385 2019-09-22 16:19:11 +02:00
Thomas Faber
b90c24d640
[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385 2019-09-22 16:19:09 +02:00
Thomas Faber
d41c5be3bd
[BROWSEUI] Fix a PIDL leak. 2019-09-22 11:42:06 +02:00
Thomas Faber
cfc5b3749f
[SHLWAPI] Import Wine commit c8175e6c7a7 (Fix Stat() method for file streams) by Nikolay Sivov. 
Fixes crash in shlwapi_winetest:istream.
 2019-09-22 11:42:01 +02:00
Thomas Faber
faae7e5790
[SHELL32] Handle BYREF variants in CFolderItems::Item. 
Fixes crash in shell32_winetest:shelldispatch.

See also:
6634b31520
 2019-09-22 11:41:57 +02:00
Carlo Bramini
e7b8f27309 [OPENGLCFG] Fix crash if no drivers (#1919) 
Actually, it crashes here on Windows XP.
 2019-09-21 15:58:38 +02:00
Hermès Bélusca-Maïto
7fccd6b763
[UBTRFS] Addendum to 255ef2c3: Add missing exports expected by mkbtrfs. 
CORE-16383 CORE-16354
 2019-09-21 04:35:01 +02:00
Adam Słaboń
c81af08f51 [TRANSLATION] Polish translation update (#1916) 
Added translation for netstat, utilman and netplwiz. Updated translation of find, reg, rapps, regedit, sndvol32, usetup, hivesys, mmsys, openglcfg, powercfg, sysdm, shellext, browseui, devmgr, msgina, netcfgx, shell32, syssetup, shortcuts and vcdcontroltool.
 2019-09-20 21:51:47 +02:00
Carlo Bramini
ec81c75b49 [OPENGLCFG] Add italian translation. (#1915) 2019-09-20 21:51:33 +02:00
Joachim Henze
841732e45c [COMCTL32] Updown Suppress the NM_RELEASEDCAPTURE notification CORE-14365 
This fixes a strange toggle-back-effect in 'Zeckensacks Glide Wrapper 0.84c'
by importing Wine commit
9dbe886e3f
Thanks to patches author Akihiro Sagawa <sagawa.aki@gmail.com>
 2019-09-20 20:13:09 +02:00
Carlo Bramini
6f5ea7cfba [NETPLWIZ] Add Italian translation. (#1912) 2019-09-19 21:58:00 +02:00
Pierre Schweitzer
86c94e7858
[BROWSEUI] Translate search function into French 
CORE-9279
 2019-09-17 23:06:34 +02:00
Eric Kohl
a66c7d2ecc [LSA][SECUR32] Check for untrusted clients 
Calls  to LsapCallAuthenticationPackage are routed to LsaApCallPackageUntrusted instead of LsaApCallPackage for  untrusted clients.
 2019-09-17 12:58:11 +02:00
Eric Kohl
ba43d1e839 [MSV1_0] Implement LsaApCallPackageUntrusted() 
An untrusted client is only allowed to change passwords
 2019-09-17 12:46:49 +02:00
Eric Kohl
95dd1c6705 [SYSDM] Store the profile path in the PROFILEDATA struct for deleting and copying the profiles 2019-09-16 08:51:08 +02:00
Brock Mammen
9b75b67e9d [SHELLFIND] Use IS_INTRESOURCE() 2019-09-15 19:46:36 +03:00
Brock Mammen
8da23e7eb9 [SHELLFIND] Add missing dependency to CMakeLists.txt 2019-09-15 19:46:36 +03:00
Brock Mammen
80f67b1111 [BROWSEUI] Add search strings to all language resources 2019-09-15 19:46:36 +03:00
Brock Mammen
e32b88be3d [BROWSEUI] Add search dialog to all language resources 2019-09-15 19:46:36 +03:00
Brock Mammen
0311544bb3 [SHELLFIND] Fix return values 2019-09-15 19:46:36 +03:00
Brock Mammen
b766576487 [SHELLFIND] Remove unused COM interfaces 2019-09-15 19:46:36 +03:00
Brock Mammen
8228844241 [SHELLFIND] Remove unused functions 2019-09-15 19:46:36 +03:00
Brock Mammen
12451dc172 [SHELLFIND] Change parameter from array reference to pointer 2019-09-15 19:46:36 +03:00
Brock Mammen
7ac9fd9f51 [SHELLFIND] Remove unnecessary cast 2019-09-15 19:46:36 +03:00
Brock Mammen
0eee3ed368 [SHELLFIND] Remove redundant check 2019-09-15 19:46:36 +03:00
Brock Mammen
2513c47452 [SHELLFIND] Fix unsafe cast 2019-09-15 19:46:36 +03:00
Brock Mammen
fbdc08dceb [SHELLFIND] Use CoTaskMemAlloc instead of SHAlloc 2019-09-15 19:46:36 +03:00
Brock Mammen
d0171027e0 [SHELLFIND] Fix IImageList leak 2019-09-15 19:46:36 +03:00
Brock Mammen
a3ee648d8b [SHELLFIND] Simplify PIDLs to paths 2019-09-15 19:46:36 +03:00
Brock Mammen
0f995d77d1 [SHELLFIND] Remove search results folder from address edit box 2019-09-15 19:46:36 +03:00
Brock Mammen
e6a5821e0c [SHELLFIND] Subscribe to folders that are already opened 2019-09-15 19:46:36 +03:00
Brock Mammen
07d37180a1 [SHELLFIND] Open search bar when search results folder is opened 2019-09-15 19:46:36 +03:00
Brock Mammen
312b628fe1 [SHELLFIND] Remove dependency on internal shell32 functions 2019-09-15 19:46:36 +03:00
Brock Mammen
6c6fd6d989 [SHELLFIND] Localize column names 2019-09-15 19:46:36 +03:00
Brock Mammen
641988a386 [SHELLFIND] Rename data members 2019-09-15 19:46:36 +03:00
Brock Mammen
fe5c76a034 [SHELLFIND] Fix handle leak for stop event 2019-09-15 19:46:36 +03:00
Brock Mammen
dce5ccec4e [SHELLFIND] Use DeferWindowPos for resizing child windows 2019-09-15 19:46:36 +03:00
Brock Mammen
8aa063b451 [SHELLFIND] Use assignment instead of memcpy 2019-09-15 19:46:36 +03:00
Brock Mammen
3b9508e98f [SHELLFIND] Fix copyright headers 2019-09-15 19:46:36 +03:00
Brock Mammen
e15445e0c5 [SHELLFIND] Remove unused function 2019-09-15 19:46:36 +03:00
Brock Mammen
ff7e9870ce [SHELLFIND] Remove unnecessary data member for focus 2019-09-15 19:46:36 +03:00
Brock Mammen
a905699ac6 [SHELLFIND] Use case-insensitive string comparison 2019-09-15 19:46:36 +03:00
Brock Mammen
87c1f457eb [SHELLFIND] Improve search bar UI 2019-09-15 19:46:36 +03:00
Brock Mammen
c46d60360a [SHELLFIND] Update status bar text 2019-09-15 19:46:36 +03:00
Brock Mammen
8246cd4e1b [SHELLFIND] Remove duplicate search code 2019-09-15 19:46:36 +03:00
Brock Mammen
41f9ad120d [SHELLFIND] Add stop search command 2019-09-15 19:46:36 +03:00
Brock Mammen
41d7b3700d [SHELLFIND] Add search command events 2019-09-15 19:46:36 +03:00
Brock Mammen
2f3db8d9a3 [SHELLFIND] Add search functionality 2019-09-15 19:46:36 +03:00
Brock Mammen
3583900b17 [SHELLFIND] Move window message constants to header file 2019-09-15 19:46:36 +03:00
Brock Mammen
6d6bc885cb [SHELLFIND] Use smart pointers for PIDLs 2019-09-15 19:46:36 +03:00
Brock Mammen
27ca55bce6 [SHELLFIND] Add edit box for search location 2019-09-15 19:46:36 +03:00
Brock Mammen
363ddf9c70 [SHELLFIND] Set status bar text after opening search results folder 2019-09-15 19:46:36 +03:00
Brock Mammen
04fcbe3202 [SHELLFIND] Message handler for updating status bar text 2019-09-15 19:46:36 +03:00
Brock Mammen
2fdaa386d2 [SHELLFIND] Add "Open Containing Folder" to right-click menu 2019-09-15 19:46:36 +03:00
Brock Mammen
7c937bd9ef [SHELLFIND] Add search bar click handler for testing search results 2019-09-15 19:46:36 +03:00
Brock Mammen
06fd04d7b0 [SHELLFIND] Message handler for adding search results 2019-09-15 19:46:36 +03:00
Brock Mammen
666bf34640 [SHELLFIND] Create PIDLs and add search results to folder 2019-09-15 19:46:36 +03:00
Brock Mammen
9c29004090 [SHELLFIND] Set default folder view mode to details 2019-09-15 19:46:36 +03:00
Brock Mammen
c0799cd25b [SHELLFIND] Add default columns from CFSFolder 2019-09-15 19:46:36 +03:00
Brock Mammen
ccf9ce324f [SHELLFIND] Add CFindFolder 2019-09-15 19:46:36 +03:00
Brock Mammen
7544656b85 [SHELLFIND] Open search results folder with search button 2019-09-15 19:46:36 +03:00
Brock Mammen
4212f4b175 [SHELLFIND] Add CSearchBar 2019-09-15 19:46:36 +03:00
Brock Mammen
957a604b36 [SHELL32] Implement CDefView::AddObject() 2019-09-15 19:46:36 +03:00
Brock Mammen
e7e551afda [SHELL32] Make SHFindFiles open the search results folder 2019-09-15 19:46:36 +03:00
Eric Kohl
05f0b08085 [SYSDM] Allow deleting and copying of user profiles only for profiles that are currently not in use 2019-09-14 12:22:54 +02:00
Eric Kohl
3d0ae05303 [SYSDM] Show the profile type (local or roaming) in the type column, show the other profile states in the status column 2019-09-12 10:23:33 +02:00
Eric Kohl
6984729f81 [SYSDM] Improvements to the user profile size format 2019-09-11 15:12:26 +02:00
Eric Kohl
7072a34739 [SYSDM] Calculate and display the size of the user profiles 2019-09-11 10:14:02 +02:00
Eric Kohl
cd2d97873e [SYSDM] Remove unused variables 
Thanks a lot Katayama Hirofumi for the hint!
 2019-09-10 15:38:29 +02:00
Eric Kohl
48c01c8717 [SYSDM] Check the profile directory and hive file and display the last write date of the hive file. 2019-09-10 13:40:47 +02:00
Timo Kreuzer
175abab7ad [IPHLPAPI] Simplify spec file 
Also move the exports where they are on Windows. This was already handled correctly by MSVC and still doesn't fix the order on GCC builds, but that is a different story and shall be addressed at a different time.
 2019-09-08 16:23:46 +02:00
Timo Kreuzer
76eed61813 [IPHLPAPI] Improve function stubs 2019-09-08 16:23:46 +02:00
Carlo Bramini
6b8d722bb2 Fix italian translation: "Cancella" -> "Annulla" (#1902) 2019-09-08 14:04:41 +02:00
Pierre Schweitzer
255ef2c332
[UBTRFS] Upgrade to 1.4 
CORE-16354
 2019-09-02 08:19:49 +02:00
Pierre Schweitzer
318da0c18c
[BTRFS] Upgrade to 1.4 
CORE-16354
 2019-09-02 08:19:48 +02:00
Bișoc George
9efe8dab89 [CPL] Do not enable the "Apply" button unconditionally (#1876) 
Fix for WINED3DCFG and OPENGLCFG.
CORE-16330
 2019-09-01 22:58:43 +02:00
Eric Kohl
12e2039743 [SYSDM] Only Administrators should see all user profiles and be able to copy or delete them 2019-09-01 19:39:28 +02:00
Timo Kreuzer
99fe069ce6 [CRT][MSVCRT] Add __DestructExceptionObject from wine 2019-09-01 16:29:26 +02:00
Eric Kohl
fa0eef085c [BOOTDATA][LSASRV] Add the security service(s) 
- Add the service routines for the SamSs service.
- Start the SamSs service.
 2019-08-31 18:17:14 +02:00
Eric Kohl
0625eb3746 [SERVICES][ADVAPI32] Support the security process aka lsass.exe 
- Reserve the pipe NtControlPipe0 for the security process.
- Count regular service control pipes from 1.
- Use I_ScIsSecurityProcess to identify the security process.
- Services.exe uses the SECURITY_SERVICES_STARTED event to notify the security process that NtControlPipe0 is ready for use.
 2019-08-31 17:24:47 +02:00
Eric Kohl
8571c26a71 [NETAPI32] Implement DsEnumerateDomainTrustsA 2019-08-31 12:45:30 +02:00
Eric Kohl
324afc252c [NETAPI32] Implement DsEnumerateDomainTrustsW 2019-08-25 18:23:38 +02:00
Eric Kohl
abeb3324fb [NETAPI32] Implement DsAddressToSiteNamesA and DsAddressToSiteNamesExA 2019-08-25 11:39:53 +02:00
Ioannis Adamopoulos
e419195d37 [HEADERS] Move some helpers from undocshell.h to shellutils.h as they didn't cover anything undocumented. Merge traycmd.h in undocshell.h as both contain just undocumented shell definitions. 2019-08-25 12:20:52 +03:00
Eric Kohl
121f0a5c50 [NETAPI32] Fix a typo in DsDeregisterDnsHostRecordsA 
Thank you very much UserNT and Thomas for the hint!
 2019-08-25 11:15:00 +02:00
Eric Kohl
c9537b392b [NETAPI32] Implement DsDeregisterDnsHostRecordsA 2019-08-24 22:57:36 +02:00
Eric Kohl
47b749aa31 [NETAPI32] Implement DsGetDcNameWithAccountA 2019-08-24 21:40:11 +02:00
Eric Kohl
792d0f6b78 [NETAPI32] Implement DsGetDcSiteCoverageA 2019-08-24 19:44:37 +02:00
Eric Kohl
61ac4f1ee9 [NETAPI32] Add the NetpAllocStrFromWStr helper function 2019-08-24 14:00:33 +02:00
Eric Kohl
3d5c682cd8 [NETAPI32] Implement DsGetSiteNameA 
Also add the NetpAllocAnsiStrFromWStr helper function.
 2019-08-24 13:15:41 +02:00
Mark Jansen
4872912eb2
[SETUPAPI] Demote some noisy dprints 2019-08-23 13:03:36 +02:00
Mark Jansen
029b8f2cf9
[NTDLL] Use the embedded manifest from the process to check compatibility. 2019-08-21 18:57:52 +02:00
Shy Zedaka
cbf47846e7 [TRANSLATION] Changes to Newdev and hdwwiz 2019-08-21 18:49:59 +02:00
Shy Zedaka
cc8180fe63 [TRANSLATION] Change the recycle bin from 'Trash' to 'Recycle bin' 2019-08-21 18:49:59 +02:00
Mark Jansen
ca4b001544
[NTDLL_VISTA] Fix the build for arm 2019-08-20 22:31:56 +02:00
Mark Jansen
6872cef0da
[FRAMEDYN[ARM] Fix some exports 2019-08-20 22:31:55 +02:00
Mark Jansen
419d7e96ad
[NTDLL][ARM] Export pow 2019-08-20 22:31:55 +02:00
Serge Gautherie
9f5f7a97f8 [IPHLPAPI] icmp.c: Restore sync after Wine Staging 1.7.55 
Mark all our (new) differences.
 2019-08-20 15:20:01 +02:00
Mark Jansen
c2b9f94234
[COMCTL32] imagelist: Invalidate the cookie of a destroyed imagelist 
CORE-16316
CORE-16275
 2019-08-19 21:25:07 +02:00
Konstantin Motylkov
ab2c90f1b9
[DNSAPI][DNSAPI_APITEST] Fix DnsQuery_UTF8 function and add tests 
CORE-11634
 2019-08-19 20:01:23 +02:00
Serge Gautherie
cb77f1701f [SHELL32][STOBJECT] Enforce ShellExecuteW(..., file, parameters, ...) 
CORE-16299
 2019-08-19 13:01:08 +02:00
Mark Jansen
343442cc3f
[LDR][APPHELP] Add a shim that disables manifest compatibility version parsing 2019-08-19 12:08:06 +02:00
Eric Kohl
f052817d84 [MSV1_0] Add SpLsaModeInitialize and SpUserModeInitialize. 
SpLsaModeInitialize and SpUserModeInitialize will provide access to SSPI functions. LSASRV will soon access the LsaAp functions via SpLsaModeInialize.
 2019-08-18 14:56:27 +02:00
Serge Gautherie
8ba4b11a33 [IPHLPAPI] icmp.c: Complete sync with Wine Staging 1.7.55 
- Restore a missing brace.
- Mark all our differences (at that time). Please inspect them.

CORE-10536
 2019-08-17 17:48:21 +02:00
Bișoc George
dcf18826a5 [DESK] Change the property "Screensaver" page on text change 
If the user takes action on the edit box control of "Screensaver" dialog page, enable the "Apply" property button.

CORE-16280
 2019-08-17 15:36:47 +02:00
Katayama Hirofumi MZ
344d559935
[COMCTL32] Unchange the property sheet page after WM_INITDIALOG (#1842) 
In my testing on Win2k3, EN_CHANGE is generated in OnInitDialog, that is correct. The target is property sheet. The property sheet does unchange the page after WM_INITDIALOG generation. CORE-16280
 2019-08-17 20:02:57 +09:00
Andreas Maier
2b5f38295b [COMCTL32] remove unused theme_*.c files. 2019-08-17 12:08:04 +02:00
Shy Zedaka
fca051a1d1 [TRANSLATION][NEWDEV] Complete Hebrew Translations for New Device Prompt 2019-08-16 20:04:27 +02:00
Jose Carlos Jesus
3a92f9c3a0
[CONSOLE] New Portuguese Translation 2019-08-16 19:32:24 +02:00
Jose Carlos Jesus
23cac56740
[DESKMON] Update Portuguese Translation 2019-08-16 19:32:23 +02:00
Jose Carlos Jesus
c12b06fb8e
[DESK] New Portuguese translation 2019-08-16 19:32:23 +02:00
Jose Carlos Jesus
0b4510301b
[SHELL][COMCTL32] pt_PT_Translation Improvements 2019-08-16 19:32:23 +02:00
Jose Carlos Jesus
0ddbf9a552
[HDWWIZ] New pt_PT_Translation 2019-08-16 19:32:16 +02:00
Oleg Dubinskiy
5f7575909f [AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826) 
Rename RosAudioSrv to AudioSrv in audio service itself and in all system components which are related to this, same as it done in Win2k3.
It allows MS DxDiag to detect the system audio service correctly, so it becomes possible to run DirectSound test properly with MS dsound.dll, although it works with some minor errors and only in older VirtualBox versions, ~ up to 5.1.38 (and in other emulators as well).

CORE-16307
 2019-08-16 19:11:04 +02:00
Andrew Boyarshin
0a84597679
[COMCTL32] Export LoadIconMetric and LoadIconWithScaleDown 
They are already implemented and there is little sense for them to be hidden.
Required for ProcessHacker 3.0+.
 2019-08-16 18:31:07 +02:00
Andreas Maier
83dcae1e0f [JSCRIPT] import wine commits "stub + implement Enumerator()" 
6630bc4096
a015c62643

CORE-13810
 2019-08-16 16:37:32 +02:00
Waritnan Sookbuntherng
76dfa2b284 [COMCTL32] Checking size grip bounds in x-axis only 2019-08-16 16:22:24 +02:00
Waritnan Sookbuntherng
b9ddad0bbb [COMCTL32] Hide size grip when the parent window is maximized 2019-08-16 16:22:24 +02:00
Andreas Maier
4093681ad0 [COMCTL32] Saturated images: Take mask-images in account. 
This fixes CORE-14209 - Some icons not drawn in IDA Free
 2019-08-15 21:11:45 +02:00
Andreas Maier
49a797543f [COMCTL32] Improve failure cases. 2019-08-15 21:11:45 +02:00
Adam Słaboń
65f42596ce [THEMES][LUNAR] Update 
Improved Button and Combo Button bitmaps, fixed SYSSETUP Lunar resource.
 2019-08-15 20:25:02 +02:00
Shy Zedaka
a3944563c3 [SHELL32] Run Dialog Text Fix 2019-08-15 20:03:55 +02:00
Timo Kreuzer
06e631fafe [KSUSER] Improve pointer arithmetics 2019-08-15 18:04:57 +02:00
Katayama Hirofumi MZ
944aba1fcc
[SHELL32] Fix Desktop Properties menu item action (#1833) 
1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.

The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299
 2019-08-15 23:10:06 +09:00
Denis Malikov
18a9993d69 [KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it 2019-08-15 15:50:59 +02:00
Serge Gautherie
40ab30d6a0 [KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6 
CORE-12596
 2019-08-15 15:42:34 +02:00
Timo Kreuzer
ad89837c0e [3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code 2019-08-15 15:24:12 +02:00
Timo Kreuzer
58588b76e2 [REACTOS] Fix MSVC printf format warnings 2019-08-15 15:24:12 +02:00
Timo Kreuzer
7611cc2b12 [REACTOS] Fix SIZE_T related warnings 2019-08-15 14:20:00 +02:00
Shy Zedaka
187c9fc33c [Translation] More Hebrew Translations 
Co-authored-by: Baruch Rutman <peterooch@gmail.com>
 2019-08-15 13:41:01 +02:00
Mark Jansen
c96ba1aff2
[SHELL32] CDefView: Improve the context menu positioning 
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.
 2019-08-15 11:28:31 +02:00
Joachim Henze
0f16d44b66 [SHELL32] Improve ShellExecute 
This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.

Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.

Automated tests do improve as well
VBox https://reactos.org/testman/compare.php?ids=68662,68696
KVM https://reactos.org/testman/compare.php?ids=68663,68697

I intend to merge this back into 0.4.12RC.
 2019-08-06 20:24:55 +02:00
Katayama Hirofumi MZ
5972b1e284
[SYSSETUP] Caption of 2nd stage ReactOS Setup is too heavy (#1806) 
The caption text of 2nd stage ReactOS Setup was too bold. CORE-16295
 2019-08-06 11:09:56 +09:00
Katayama Hirofumi MZ
836e3107ba
[SYSSETUP] Fix bold font (#1799) 
The font of radio buttons at ReactOS 2nd setup was wrong and too heavy. CORE-16291
 2019-08-05 09:44:25 +09:00
Eric Kohl
7550e9efbf [DEVMGR] Add the code to uninstall a device from the property page 2019-08-04 11:20:04 +02:00
Shy Zedaka
ce2f52d054 [SYSDM] Fix Re-sizing License Prompt (#1789) 
CORE-16278
 2019-08-03 23:34:20 +02:00
Eric Kohl
611989943e [DEVMGR] Change the menu id prefix from IDC_ to IDM_. 2019-08-03 21:52:00 +02:00
Eric Kohl
38d3c4d8da [DEVMGR] Fix the indentation of the menu resources. No code changes! 2019-08-03 16:37:54 +02:00
Eric Kohl
d1a2983c00 [DEVMGR] Fix wonky action menu 
Patch by Pi_User5.

CORE-10364
 2019-08-03 14:54:18 +02:00
Hermès Bélusca-Maïto
44cddadba8
[KERNEL32] Minor enhancements for CreateRemoteThread(). (#804) 
- Add some cleanup code in failure code paths, instead of asserting.
- Move BasepNotifyCsrOfThread() helper to the only file where it is used.
- Don't use ERROR_DBGBREAK in failure paths but just DPRINT the error
  message: we handle the failures properly.
- When creating the remote thread, sync its service tag with the parent
  thread's one.
 2019-08-01 19:12:49 +02:00
Hermès Bélusca-Maïto
effdb6f232
[KERNEL32][RTL] Diverse fixes/improvements for thread stack creation code. (#802) 
- kernel32!BaseCreateStack() is compatible with ntdll!RtlpCreateUserStack().
- When checking whether a stack guard page can be added, its size has to
  be accounted for in the checking logic.
- We have to satisfy the PEB::MinimumStackCommit constraint.
- We cannot use PEB::GuaranteedStackBytes in BaseCreateStack() since it is
  nowhere initialized (default is 0). It gets initialized to a non-zero
  value when the user manually calls SetThreadStackGuarantee().
  https://www.installsetupconfig.com/win32programming/windowsthreadsprocessapis7_6.html

- RtlpCreateUserStack(): Fix memory leak in failure case.
- RtlpFreeUserStack() doesn't need to return anything.

See also commit 1bc59379 (r59868).

CORE-11319
 2019-08-01 19:04:13 +02:00
Joachim Henze
3e581e44a9 [INTL] Addendum to CORE-16252 
That change was not intended.in
commit 0.4.13-dev-740-g
8b67edd8fa

Thx to Stas'M for noticing the windres warning.
 2019-07-31 01:58:42 +02:00
Joachim Henze
8b67edd8fa [INPUT][INTL][SYSSETUP] Limit Combobox height CORE-16252 
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaa

Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
 2019-07-30 23:14:31 +02:00
Eric Kohl
034c6fd0c5 [LSASRV] Improvements to LsapLogonUser() 
- Token handle duplication must be the last step because we cannot close the duplicated token handle if something fails.
- Call LsaApLogonTerminated(), delete the logon session and free the profile buffer if something fails.
 2019-07-30 23:10:33 +02:00
Tibor Lajos Füzi
48200015f7 [KBDHU] Fix Hungarian keyboard layout. (#1765) 
CORE-15567
 2019-07-29 21:55:24 +02:00
Eric Kohl
32861b84b9 [MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHours() for testing. 2019-07-29 01:22:37 +02:00
Jose Carlos Jesus
f699cc96ac [NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position adjustments (#1761) 2019-07-29 00:20:40 +02:00
Hermès Bélusca-Maïto
b6135732d4
[DLLs] Fix .spec files regarding OLE-specific exports. 
- Do not use hardcoded ordinals, add missing '-private'.
  Except for MSXML3, OLE32 and RSAENH, see commit bff824b2 for more details.

- SHSVCS: The 6 first exports are nonamed with ordinals. Replace exported
  commented stubs by actual exported stubs instead.

Co-Authored-By: Timo Kreuzer <timo.kreuzer@reactos.org>
 2019-07-28 16:26:22 +02:00
Eric Kohl
12aba91abb [MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and MsV1_0ReLogonUsers are obsolete. 2019-07-28 14:57:46 +02:00
Oleg Dubinskiy
1a84d120a6 [DSOUND_NEW] Remove unused dsound_convert.c file (#1748) 2019-07-24 19:56:33 +02:00
Doug-Lyons
77671f0337
[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. (#1684) 
CORE-16123

- NETID: Correct the call when using the "Computer Name Change" in ReactOS.
- WINLOGON: Update the volatile "Hostname" and "Domain" variables from
  their non-volatile counterparts.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
 2019-07-22 00:49:47 +02:00
Oleg Dubinskiy
7f59361911
[DSOUND_NEW] Completely fix gcc compilation (addendum to 25e98eb). (#1740) 
CORE-16128
 2019-07-21 17:02:34 +02:00
Michael Maltsev
a303932803
[ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094 2019-07-21 11:39:30 +02:00
Timo Kreuzer
ddb56e8cca [OLEAUT32] Use snprintf instead of sprintf 
Fixes GCC 8 warning:
dll/win32/oleaut32/oleaut.c:876:39: error: '%s' directive writing up to 99 bytes into a region of size between 92 and 291 [-Werror=format-overflow=]
     sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
                                       ^~                     ~~~
dll/win32/oleaut32/oleaut.c:876:5: note: 'sprintf' output between 18 and 316 bytes into a destination of size 300
     sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2019-07-20 13:56:18 +02:00
Timo Kreuzer
3120320c65 [FRAMEDYN] Fix broken asm (.code64 is for x64 only) 2019-07-20 13:56:18 +02:00
Timo Kreuzer
1b70ddd834 [KERNEL32] Improve path name handling 
Fixes GCC 8 warning:
dll/win32/kernel32/client/loader.c: In function 'LoadLibraryA':
dll/win32/kernel32/client/loader.c:129:17: error: 'strncat' specified bound 13 equals source length [-Werror=stringop-overflow=]
                 strncat(PathBuffer, "\\twain_32.dll", 13);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2019-07-20 13:56:18 +02:00
Timo Kreuzer
2800837dc0 [MSGINA] Fix copying the TokenSource string 
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/msgina/lsa.c:195:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "User32  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2019-07-20 13:56:18 +02:00
Timo Kreuzer
f3a9b524f1 [ADVAPI32] Fix copying the TokenSource string 
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "Advapi  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2019-07-20 13:56:18 +02:00
Jose Carlos Jesus
69454b4302 [TRANSLATION] Add Portuguese (neutral) translation. (#1702) 
Add Portuguese (neutral) translation for intl.cpl, main.cpl, msgina.dll, msports.dll, welcome.exe and rundll32.exe, and fix the one in mshtml.dll .
 2019-07-15 00:07:50 +02:00
Eric Kohl
433c9d327e [SETUPAPI] Implement CM_Delete_DevNode_Key_Ex() 
CM_REGISTRY_USER is not supported yet.
 2019-07-13 14:26:57 +02:00
Mark Jansen
b5423ba70b
[SHELL32] Fix SHCreateDirectoryExW showing an error on success 
CORE-15145
 2019-07-09 22:52:17 +02:00
Eric Kohl
93f77f2625 [SETUPAPI] CM_Delete_DevNode_Key[_Ex]: Use DEVINST instead of DEVNODE because we are using DEVINST anywhere else. 2019-07-08 00:08:22 +02:00
Eric Kohl
86e8a477b6 [SETUPAPI] CMP_RegisterNotification: When a window is registered, pass the window text to PNP_RegisterNotification(). 2019-07-07 23:47:01 +02:00
Bișoc George
019e3ffe5f
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. (#1688) 
CORE-12313

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
 2019-07-07 19:01:09 +02:00
Hermès Bélusca-Maïto
8a30801516
[SHELL32] Recycle-Bin: Minor code enhancements. 
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
 2019-07-07 17:56:51 +02:00
Bișoc George
818d660868 [SHELL32] Enable the "Apply" button when user takes action on the edit box control (#1720) 
CORE-12312
 2019-07-07 14:47:44 +02:00
Eric Kohl
ece54dcd2f [SETUPAPI][UMPNPMGR] The 3rd parameter of PNP_RegisterNotification() seems to be the service name 2019-07-07 13:41:00 +02:00
Doug Lyons
119c99ef7e
[TIMEDATE] Allow editing the time server combo box. CORE-13001 2019-07-07 12:45:45 +02:00
Doug Lyons
44b543bad3
[TIMEDATE] Handle manual time server entry. CORE-13001 2019-07-07 12:45:36 +02:00
Doug Lyons
33401f3875
[TIMEDATE] Use w32time compatible registry settings. CORE-13001 2019-07-07 12:45:17 +02:00
Thomas Faber
d19b792511
[W32TIME] Implement a rudimentary version of W32TimeSyncNow. CORE-13001 2019-07-07 12:45:03 +02:00
Thomas Faber
1938b7484e
[TIMEDATE] Avoid the use of DisplayWin32Error in time sync utility functions. CORE-13001 2019-07-07 12:44:51 +02:00
Thomas Faber
aa24ad7429
[TIMEDATE] Separate time sync functions out into their own file. CORE-13001 
This is in preparation for the w32time service, and based on
work by Doug Lyons.
 2019-07-07 12:44:37 +02:00
Victor Perevertkin
042646ceac [IPHLPAPI] Use if_descrlen field for determining the length of 
if_descr in IFEntry structure. This fixes heap corruption on GCC8.
CORE-16088
 2019-07-05 22:49:12 +03:00
Stanislav Motylkov
a76e03d8bc [SHELL32][USERENV] Improve Russian translation (#1710) 
CORE-16170
 2019-07-01 21:43:22 +02:00
Oleg Dubinskiy
25e98eb0da [DSOUND_NEW] Add CMakeLists.txt + mostly fix gcc compilation 2019-06-30 20:06:36 +02:00
Jose Carlos Jesus
86d4156c39
[TRANSLATIONS] Add/Update Portuguese (neutral) translations. (#1687) 
Translations for SYSDM.CPL, SETUPAPI, SHELL32, LSASRV, SAMSRV, SYSSETUP,
USRMGR, THEMEUI, USERENV, WININET, MSCONFIG.
 2019-06-29 16:55:33 +02:00
Eric Kohl
7eb6e42626 [UMPNPMGR][SETUPAPI] PNP_RegisterNotification() has got 9 parameters. 2019-06-29 13:38:42 +02:00
Thomas Faber
d16c9a798a
[LIBPNG] Update to version 1.6.37. CORE-16147 2019-06-27 12:52:12 +02:00
Thomas Faber
430656f0b9
[MBEDTLS] Update to version 2.7.11. CORE-16147 2019-06-27 12:52:00 +02:00
Eric Kohl
a9c4c07955 [SETUPAPI][UMPNPMGR] PNP_UnregisterNotification: Add 2 unknown parameters 2019-06-23 21:45:54 +02:00
Eric Kohl
ca0406131c [SETUPAPI][UMPNPMGR] Improve CMP_RegisterNotification/PNP_RegisterNotification 
Pass the notification filter to PNP_RegisterNotification as a byte-pointer to the filter and the size of the filter.
 2019-06-23 19:31:34 +02:00
Eric Kohl
89c936fdd6 [NETCFGX] Start a network adapter device after the custom install steps have been completed. 
This could probably fix CORE-16103
 2019-06-22 21:01:26 +02:00
Eric Kohl
8dc70d2454 [SETUPAPI] Implement SetupDiRestartDevices() 2019-06-22 21:01:25 +02:00
Andreas Maier
49165276f2 [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) (#1674) 
* [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression)

Fix cb_states / rb_states lookup table.

* [README.WINE] comctl32 is synced to WineStaging-3.3.

See commit b3fb8555 .
 2019-06-22 16:36:14 +02:00
Jose Carlos Jesus
be820b9ca3
[NEWDEV] Add Portuguese (neutral) translation. 2019-06-22 16:17:03 +02:00
Jose Carlos Jesus
0e6732586d
[NETID] Add Portuguese (neutral) translation. 2019-06-22 16:16:58 +02:00
Jose Carlos Jesus
64a647a843
[NETCFGX] Add Portuguese (neutral) translation. 2019-06-22 16:11:55 +02:00
Bișoc George
4c9dc7302b [MAIN.CPL] Adjust the GROUPBOX control spacing for French resource (#1682) 
CORE-12372
 2019-06-22 15:37:59 +02:00
Eric Kohl
214692ff5e [NETSHELL] Improvements to the network setup (2a/x) 
Step 2a: Really check the binding between network components.

Next Step: Bind the Tcpip transport to all enumerated network adapters.
 2019-06-20 22:08:39 +02:00
Eric Kohl
73ca084e96 [NETCFGX] Read a components bind value and implement the IsBoundTo method. 2019-06-20 22:08:38 +02:00
Eric Kohl
79a0f2b430 [NETCFGX] EnumClientServiceProtocol: Use the right parent key when trying to open the 'NDI' subkey. 
This makes the description of the selected item show up in the network connection properties.
 2019-06-20 20:08:36 +02:00
Hermès Bélusca-Maïto
1dc4ba9da7
[DEVMGR] Add the missing pt-PT.rc translation file. Strange, I thought I added it before... 2019-06-20 18:04:26 +02:00
Mas Ahmad Muhammad
fd928f9d6e
[CPL_DESK] Update Indonesian translation. 2019-06-20 17:31:57 +02:00
Mas Ahmad Muhammad
e3c779a855
[CPL_MMSYS] Update Indonesian translation. 2019-06-20 17:31:57 +02:00
Mas Ahmad Muhammad
40be6abdd8
[CPL_TIMEDATE] Update Indonesian translation. 2019-06-20 17:31:56 +02:00
Mas Ahmad Muhammad
37d345d8cc
[CPL_CONSOLE] Update Indonesian translation. 2019-06-20 17:31:56 +02:00
Mas Ahmad Muhammad
456e06ae2a
[CPL_APPWIZ] Add Indonesian translation. 2019-06-20 17:31:55 +02:00
Mas Ahmad Muhammad
aadd11c01d
[CPL_ACCESS] Update Indonesian translation. 2019-06-20 17:31:54 +02:00
Mas Ahmad Muhammad
682ea2206a
[NEWDEV] Update Indonesian translation. 2019-06-20 17:31:53 +02:00
Mas Ahmad Muhammad
11f1b911d8
[IEFRAME] Add Indonesian translation. 2019-06-20 17:31:52 +02:00
Mas Ahmad Muhammad
7f09d9512c
[DEVMGR] Update Indonesian translation. 2019-06-20 17:31:51 +02:00
Mas Ahmad Muhammad
867fdc24d9
[MSGINA] Update Indonesian translation. 2019-06-20 17:31:50 +02:00
Mas Ahmad Muhammad
859199ee16
[COMCTL32] Add Indonesian translation. 2019-06-20 17:31:49 +02:00
Mas Ahmad Muhammad
bb499e4b4e
[THEMEUI] Add Indonesian translation. 2019-06-20 17:31:47 +02:00
Mas Ahmad Muhammad
d0629fde40
[COMDLG32] Add Indonesian translation. 2019-06-20 17:31:46 +02:00
Mas Ahmad Muhammad
4742f65936
[BROWSEUI] Add Indonesian translation. 2019-06-20 17:31:44 +02:00
Jose Carlos Jesus
37c43a7414
[DEVMGR] Add Portuguese (neutral) translation. 2019-06-20 17:15:17 +02:00
Jose Carlos Jesus
666e6561d5
[CREDUI] Update Portuguese (neutral) translation. 2019-06-20 17:15:17 +02:00
Jose Carlos Jesus
af10e1fb74
[COMDLG32] Update Portuguese (neutral) translation. 2019-06-20 17:15:16 +02:00
Jose Carlos Jesus
4bbeb21f6d
[COMCTL32] Update Portuguese (neutral) translation. 2019-06-20 17:15:15 +02:00
Jose Carlos Jesus
7df98d73b3
[BROWSEUI] Add Portuguese (neutral) translation. 2019-06-20 17:15:15 +02:00
Jose Carlos Jesus
64785cf7d3
[ACLUI] Add Portuguese (neutral) translation. 2019-06-20 17:15:14 +02:00
Eric Kohl
e57f103d53 [NETCFGX] Add the interfaces INetCfgBindingInterface and IEnumNetCfgBindingInterface (stubs only). 2019-06-19 22:38:31 +02:00
Eric Kohl
ec9c8fdf25 [NETCFGX] Add the interfaces INetCfgBindingPath and IEnumNetCfgBindingPath (stubs only). 2019-06-18 22:35:46 +02:00
Eric Kohl
2da533a8a4 [NETCFGX] NetPropPageProvider: Handle the Min and Max values for INT, LONG and WORD types properly 
CORE-15095
 2019-06-18 21:47:29 +02:00
Mark Jansen
c8ef4912a7
[URLMON] Directly call cabinet!Extract instead of calling it via advpack!ExtractFilesW 
CORE-15795
 2019-06-17 19:51:58 +02:00
Jose Carlos Jesus
65dc8aba92
[APPWIZ.CPL] Update Portuguese Brazilian, and add Portuguese (neutral) translations. (#1656) 2019-06-17 15:12:08 +02:00
Jose Carlos Jesus
8aca2dafeb
[ACCESS.CPL] Add & update Portuguese translation. (#1656) 2019-06-17 15:12:08 +02:00
Eric Kohl
1270e0a4fc [NETCFGX] Add the INetCfgComponentBindings interface to the NetCfgComponent class. 2019-06-17 14:57:08 +02:00
Eric Kohl
78f13ae5ad [NETSHELL] Improvements to the network setup (1/x) 
Step 1: Find the TcpIp transport and enumerate the installed network adapters using INetCfg.

Next Step: Find out how the binding process works and bind the TcpIp transport to all enumerated network adapters. This will replace the blind binding process we are using right now.
 2019-06-17 01:18:05 +02:00
Eric Kohl
24b22db77e [NETCFGX] Resize a helper buffer to accommodate a device instance id. 
This prevent NULL pointer exceptions in calls to INetCfgComponent::GetPnpDevNodeId().
 2019-06-17 00:46:30 +02:00
Eric Kohl
9bf78b6a95 [NETCFGX] Set the ComponentId value when a NIC is installed. 2019-06-16 23:59:52 +02:00
Mark Jansen
f3d1d38041
[INPUT] Don't race the system to free an imagelist 2019-06-16 23:11:03 +02:00
Mark Jansen
bcffdd0b16
[RASAPI32] Add RasClearConnectionStatistics stub 
CORE-10092
 2019-06-16 13:56:54 +02:00
Serge Gautherie
b13990bd78
[SETUPAPI] Revert "Fix a typo in CM_Query_Resource_Conflict_List." (#1634) 
Previous code was correct.
This reverts commit c47ad98f.
 2019-06-15 17:55:33 +02:00
Baruch Rutman
22064d7787
[LPK] Fix for CORE-16115. (#1654) 
Proposed changes:

- Use the total extent (width) and font metrics (height) as values
  to put in the lpSize variable instead of calling ScriptString_pSize()
  in the LpkGetTextExtentExPoint() function.

- Use GetTextExtentExPointWPri in more cases as another effort to get the data.

- Trailing whitespace fixes.
 2019-06-15 17:37:51 +02:00
Baruch Rutman
1a7ffd29d6
[LPK] Update Wine BiDi code. (#1651) 
Imports the changes from
ef07087f47
 2019-06-15 17:24:38 +02:00
Joachim Henze
10f00f8c1c [MSI] Fix regression CORE-14646 
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.

The regression was introduced to ros by 0.4.8-dev-739-g
f8b992f2d3
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445

Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.

I also committed the same fix to 0.4.12-RC-32-g152ee20.
 2019-06-14 23:21:37 +02:00
Eric Kohl
7b29f4d975 [NETCFGX] InstallNetDevice: Run the default device installer before making class-specific changes. 2019-06-13 14:16:25 +02:00
Giannis Adamopoulos
cc25a266f2 [COMCTL32] imagelist: Make the exported functions use the internal IImageList2 
- Add a hack to rename the exported functions and use the Internal_ prefix for them so that the IImageList can use them with minimal code changes.
- Add the correct implementation of the affected exported functions making them now use the IImageList of the passed HIMAGELIST.

This indirection is possible because an HIMAGELIST is also a IImageList*.
This indirection is also needed because we can end up using image lists created by either comctl32 v5 or comctl32 v6.
This is how windows manage to use an HIMAGELIST created by comctl32 v5 when it is passed to comctl32 v6.
What really happens in this scenario is that the exported functions of both versions end up using the interface
stored in the object without checking if this interface is the version provided in the same dll or in the other.
 2019-06-12 19:20:44 +03:00
Pierre Schweitzer
f381137c89
[BTRFS] Upgrade to 1.3 
CORE-16111
 2019-06-11 12:35:19 +02:00
Eric Kohl
90aa2c26f8 [NETCFGX] Improvements to the TCP/IP settings dialog. 
- Separate the gateway settings from the DHCP settings.
- Enable Edit and Delete buttons only if an item in a list box has been selected.

CORE-9908
 2019-06-11 06:58:42 +02:00
Eric Kohl
8f285f71c9 [NETCFGX] Do not update the TCP/IP properties when the cancels the advanced properties dialog. 
CORE-9908
 2019-06-10 20:28:58 +02:00
Pierre Schweitzer
72d229b38c
[NETPLWIZ] Add French translation 2019-06-10 19:01:30 +02:00
Eric Kohl
de0e19bc72 [NETSHELL] Network connections can't be renamed 
Enable the 'Rename' and 'Delete' menu items for Administrators.
CORE-15348
 2019-06-10 17:23:13 +02:00
Yaroslav Kibysh
27cfe08016
[CONSOLE] Update Ukrainian translation. (#1643) 2019-06-10 17:02:58 +02:00
Yaroslav Kibysh
f0163f124f
[MSGINA] Update Ukrainian translation. (#1642) 2019-06-10 17:00:44 +02:00
Yaroslav Kibysh
b2e4ff8cfd
[SHELL32] Update Ukrainian translation. (#1637) 2019-06-10 16:45:20 +02:00
Pierre Schweitzer
a7b6a1a97d
[MSGINA] Update French translation 2019-06-10 15:37:32 +02:00
Eric Kohl
f2f698587c [MSGINA] Add missing logon restriction messages. 2019-06-09 22:42:10 +02:00
Serge Gautherie
8a8453494f [SHELL32] SHCreateShellFolderView(): Fix parameter validation order. (#1632) 
Fixes one modification from commit ae2a85d0.
CORE-16098
 2019-06-09 15:57:45 +02:00
Eric Kohl
c1421c4108 [NETAPI32] Ignore usriX_logon_hours and usriX_units_per_week if usriX_logon_hours is NULL. 2019-06-09 15:25:13 +02:00
Eric Kohl
1b05c9586c [NETAPI32] Do not try to set usriX_max_storage. Just ignore it. 2019-06-09 14:50:07 +02:00
Serge Gautherie
92e5fabb55
[BROWSEUI] Fix SHEnumClassesOfCategories() parameter validation. (#1622) 
Addendum to fdfef818. CORE-11711
 2019-06-08 20:05:54 +02:00
Hermès Bélusca-Maïto
ae2a85d003
[SHELL32] Fix some NULL-pointers validation. 
- In the exported SHCreateDefaultContextMenu() and
  IDataObject_Constructor() functions (called amongst others by
  the exported CIDLData_CreateFromIDArray() function).

- In the exported SHCreateShellFolderView() function.

- In CDefView::GetItemObject(), where data was written to *ppvOut before
  ppvOut was being checked for NULL.
 2019-06-08 19:43:02 +02:00
Yaroslav Kibysh
47d76db311
[BROWSEUI] Update Ukrainian translation. (#1626) 2019-06-08 18:43:13 +02:00
Yaroslav Kibysh
6a8e99e235
[NEWDEV] Update Ukrainian translation. (#1625) 2019-06-08 18:37:29 +02:00
Yaroslav Kibysh
4d44e11f1e
[SHELL32] Update Ukrainian translation. (#1623) 2019-06-08 17:58:42 +02:00
Eric Kohl
c47ad98ff7 [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List. 2019-06-06 19:12:44 +02:00
Eric Kohl
adc9bd48b7 [SETUPAPI] GetDeviceInstanceKeyPath: Create a new driver instance property if needed and SEH-protect calls to umpnpmgr. 2019-06-06 19:08:43 +02:00
Hermès Bélusca-Maïto
fdfef818ef
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. (#1559) 
CORE-11711
 2019-06-06 17:07:38 +02:00
Serge Gautherie
1f8250f700
[BROWSEUI] browseui.spec: Fix SHEnumClassesOfCategories() parameters. (#1559) 2019-06-06 17:06:52 +02:00
Serge Gautherie
addfb61d8b [NTDLL_VISTA] Check _DEBUG with #ifdef, not #if (#1615) 2019-06-06 01:49:18 +02:00
Serge Gautherie
46259092f9 [ADVAPI32:REG] Remove some useless casts (#1614) 2019-06-05 18:37:07 +02:00
Serge Gautherie
38db074491 Misc addendum to CORE-14271 (#1529) 
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check

RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.

No functional change.

Addendum to
CORE-14271

* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check

RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.

Also, add a FIXME.

No functional change.

Addendum to
CORE-14271

* [USER32] Simplify RegisterClipboardFormatA/W() a bit

No functional change.

* [UDFS] Simplify SeSinglePrivilegeCheck() return value check

No functional change.

Addendum to
CORE-14271
 2019-06-04 16:56:33 +02:00
Joachim Henze
bc3eed68ca [MSHTML] Fake Success in HTMLDocument_put_bgColor() 
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error 8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123

Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
 2019-06-01 22:53:16 +02:00
Eric Kohl
adceb3807e [NETAPI32] Implement parts of NetGetDCName and declare some parameters optional. 2019-05-29 15:35:55 +02:00
Eric Kohl
968bdeddf3 [NETAPI32] Implement NetpAllocWStrFromStr(), NetpAllocWStrFromAnsiStr() (not public, but useful) and NetpAllocWStrFromWStr(). 2019-05-29 12:59:44 +02:00
Katayama Hirofumi MZ
9a39315d46
[SYSSETUP] Set registry hostname in WriteComputerSettings (#1589) 
Based on @Doug-Lyons's patch. CORE-16067
 2019-05-29 19:59:40 +09:00
Hervé Poussineau
74be88ac47 [LDR] Silence some debug logs when images overlap 2019-05-27 13:24:28 +02:00
Timo Kreuzer
801ec51a91 [BROWSEUI] Fix indentation 
Fixes GCC 8 warning:
dll/win32/browseui/explorerband.cpp:1332:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
                 if (!SUCCEEDED(hr) || !pParent.p)
                 ^~
dll/win32/browseui/explorerband.cpp:1335:21: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
                     hr = pParent->SetNameOf(0, pidlChild, dispInfo->item.pszText, SHGDN_INFOLDER, &pidlNew);
                     ^~
 2019-05-27 13:22:40 +02:00
Timo Kreuzer
95269bc8d1 [GLU32] Fix indentation 
Fixes GCC 8 warnings:
dll/opengl/glu32/src/libnurbs/internals/subdivider.cc:852:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if( jarc->pwlArc ) jarc->pwlArc->deleteMe( pwlarcpool ); jarc->pwlArc = 0;
  ^~
dll/opengl/glu32/src/libnurbs/internals/subdivider.cc:852:59: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  if( jarc->pwlArc ) jarc->pwlArc->deleteMe( pwlarcpool ); jarc->pwlArc = 0;
                                                           ^~~~
 2019-05-27 13:22:40 +02:00
Timo Kreuzer
207a0f520e [MSHTML] Convert tabs to spaces 
Fixes GCC 8 warning:
dll/win32/mshtml/script.c:844:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if(!new_buf)
    ^~
dll/win32/mshtml/script.c:846:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
             This->size <<= 1;
             ^~~~
 2019-05-27 13:22:40 +02:00
Timo Kreuzer
51fbf9e8c0 [LIBXSLT] Disable misleading-indentation warnings 
Fixes GCC 8 warning:
dll/3rdparty/libxslt/security.c:358:5: error: this 'else' clause does not guard... [-Werror=misleading-indentation]
     else
     ^~~~
dll/3rdparty/libxslt/security.c:365:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
  if (ret <= 0) {
  ^~
 2019-05-27 13:22:40 +02:00
Timo Kreuzer
089d59bc6c [RSAENH] Use StringCbPrintfA instead of sprintf 
Fixes GCC 8 warning:
dll/win32/rsaenh/rsaenh.c:161:23: error: '%s' directive writing up to 259 bytes into a region of size 235 [-Werror=format-overflow=]
 #define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:161:23: note: in definition of macro 'RSAENH_REGKEY'
 #define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:1107:5: note: 'sprintf' output between 26 and 285 bytes into a destination of size 260
     sprintf(szRSABase, RSAENH_REGKEY, pKeyContainer->szName);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2019-05-27 13:22:40 +02:00
Timo Kreuzer
81bdf4e360 [CRT] Add missing posix error codes 
These are required by latest mingw-w64 stl and we are mixing this with our crt headers.
Define _CRT_NO_POSIX_ERROR_CODES in all modules that define their own constants.
 2019-05-27 13:22:40 +02:00
Katayama Hirofumi MZ
2db0e159a4
[KERNEL32] Fix SetComputerNameExW (#1583) 
Based on @Doug-Lyons's patch. CORE-16058
 2019-05-27 16:18:38 +09:00
Jose Carlos Jesus
7f5e960e32
[TRANSLATIONS] Update/Add Portuguese translations. 
Translations for: reactos/setup, usetup, syssetup, netshell, shell32.
 2019-05-26 21:19:31 +02:00
Hermès Bélusca-Maïto
c4e2826c73
[CONSOLE][CONCFG][CONSRV] Provide support for specified additional TrueType fonts + bugfixes. 
CORE-12451 CORE-13182 CORE-13196

- CONSOLE: Initialize the additional TrueType fonts cache.
  * Fix the font preview when a TrueType font has been selected.
  * Refresh the available fonts and the font preview when the selected
    code page is changed (Work In Progress), or when the OS pool of
    font resources has changed (WM_FONTCHANGE message).

- CONCFG: Implement support for the additional TrueType fonts cache:
  the contents of the cache is enumerated under the registry key
    HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion\Console\TrueTypeFont

  * Add helper functions and macros.
  * In CreateConsoleFontEx(), set the mandatory font pitch&family flags
    and remove those that we do not support.
  * In IsValidConsoleFont2(), update the validity checks and the
    documentation links.

- CONSRV: Load/refresh the additional TrueType fonts cache when needed.
 2019-05-19 23:10:41 +02:00
Jose Carlos Jesus
73d7fd1415
[TRANSLATIONS] Update/Add Portuguese translations. (#1564) 
Translations for: deskadp, deskmon, reactos/setup, usetup, syssetup.

Co-Authored-By: Bișoc George <fraizeraust99@gmail.com>
 2019-05-19 17:04:47 +02:00
Eric Kohl
bb4fc96939 [MMSYS] Reset the speaker volume to its initial value when the user clicks the "Cancel" button 
CORE-13815
 2019-05-19 16:27:10 +02:00
Eric Kohl
a65a260919 [POWERCFG] Show the hibernate page only if the S4 power state is available 2019-05-12 23:52:08 +02:00
Eric Kohl
c58a2163d7 [POWERCFG] Add a separate power schemes dialog for ac-only systems 
The layout issues will be fixed by a future patch.
 2019-05-12 23:48:36 +02:00
Eric Kohl
3a207cdf27 [POWERCFG] Fix-up the lid, power button and sleep button settings according to the power capabilities. 2019-05-09 23:56:37 +02:00
Eric Kohl
cc13842ad4 [POWERCFG] Do not re-initialize all paged directly when the hibernate file setting changes. Re-initialize the pages on PSN_SETACTIVE instead. 2019-05-08 23:31:00 +02:00
Pierre Schweitzer
ea7aca8bdd
[KERNEL32] Drop unused line breaks 2019-05-08 18:34:28 +02:00
Eric Kohl
535b8dda8d [POWERCFG] Implement the power scheme 'Save As' feature 
CORE-12565
 2019-05-06 23:55:42 +02:00
Eric Kohl
af14108ee2 [POWERCFG] Do not call other pages init routines when the hibernate setting changes. This will be fixed later. 2019-05-06 23:39:09 +02:00
Eric Kohl
1dcf8376f0 [POWERCFG] Fix power scheme deletion 
CORE-12566, CORE-12567
 2019-05-05 22:48:53 +02:00
Eric Kohl
077dcfedb9 [POWERCFG] Improve the error handling in AddPowerScheme() and keep track of the current power scheme. 2019-05-05 22:10:00 +02:00
Pierre Schweitzer
204bfa8574
[KERNEL32] Misc. fixes to DefineDosDeviceW 
- Add support for LUIDDeviceMapsEnabled;
- Broadcast proper message in case of device removal;
- Use less memory for strings management;
- Make code a bit cleaner.
 2019-05-05 18:33:15 +02:00
Eric Kohl
b5e6280a72 [POWERCFG] Really fix the power schemes exceptions! 2019-05-05 17:05:59 +02:00
Pierre Schweitzer
5d20d512be
[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces 
It also comes with a small performance boost: instead of performing object
queries one after another, we query them all at once.
 2019-05-05 14:18:09 +02:00
Pierre Schweitzer
8d128aa441
[KERNEL32] Reduce QueryDosDeviceA memory footprint 
by using TEB static unicode string (which is already
preallocated).
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.
 2019-05-05 10:17:16 +02:00
Pierre Schweitzer
1ed7f27466
[KERNEL32] Reduce DefineDosDeviceA memory footprint 
by using TEB static unicode string (which is already
preallocated).
 2019-05-05 10:17:16 +02:00
Hermès Bélusca-Maïto
2ebda0e3d0
[CONSOLE.CPL] Fix the console screen preview when selecting TrueType fonts. 
CORE-13182 CORE-13196

- Use the correct character height & width.
- Additions: use StringCch*() when initializing the dialog title.

[CONSRV:CONCFG] Minor fixes.

- When retrieving font characteristics in ConCfgReadUserSettings(),
  check for NULL/zero values that indicate that we should use default
  ones instead.
- Rename 'dwNumSubKeys' into 'dwNumValues'.
 2019-05-05 01:20:19 +02:00
Eric Kohl
5164c852e8 [POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState. 2019-05-02 20:39:58 +02:00
Hervé Poussineau
7033ab18df [HID] Use hidparser static library for HidP_* functions 
hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys

At the same time, this permis implementation of some HidP_* functions.
 2019-05-02 20:06:47 +02:00
Katayama Hirofumi MZ
dcaaf3e7af
[COMDLG32] Fix treatment of wrong filename extension (#1545) 
Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270
 2019-05-02 22:48:01 +09:00
Mark Jansen
575ab6c760
[ACGENRAL] Add a test shim 2019-05-01 19:22:19 +02:00
Mark Jansen
1570f08b4d
[APPHELP] Add ordinal import support 2019-05-01 19:22:19 +02:00
Eric Kohl
2872cfc3b7 [POWERCFG] Fix indentation. No code changes! 2019-05-01 13:16:38 +02:00
Hermès Bélusca-Maïto
77d234b049
[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989 2019-04-29 22:51:35 +02:00
Serge Gautherie
cf48f8bf8a [REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526) 
No functional change otherwise.
 2019-04-28 21:19:42 +02:00
Bișoc George
89f6929dae [ACCESS] Reposition the "ToggleKeys" group box control (#1541) 
CORE-15383
 2019-04-28 20:21:38 +02:00
Eric Kohl
93b54d007f [POWERCFG] Fix minor power scheme issues 
- Really fix the exception that occurs on closing the property sheet.
- Use the correct scheme ID when the current power scheme is set.
 2019-04-28 13:18:52 +02:00
Katayama Hirofumi MZ
2da24f7274 [COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension 2019-04-28 08:44:52 +09:00
Hermès Bélusca-Maïto
9256c808b1
[NFS] Fix a typo in the precompiled header. 2019-04-28 01:42:52 +02:00
Eric Kohl
ce218f70ec [POWERCFG] Fix an exception that occurs when the control panel is closed. 2019-04-27 19:01:35 +02:00
Hermès Bélusca-Maïto
0e3a043526
[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee(). (#803) 
This should remove some of the "SetThreadStackGuarantee(): stub" messages in some simple cases.
 2019-04-27 18:41:50 +02:00
Katayama Hirofumi MZ
6a7d8112c3
[COMDLG32] Save open/save location by extension (#1514) 
Use the proper open/save initial folder for comdlg32.GetOpenFileName and comdlg32.GetSaveFileName. CORE-7114
 2019-04-27 23:02:34 +09:00
Andrew Cook
716613cddc [CMAKE] Use new policies for CMP0005 and CMP0018 (#1481) 
* [CMAKE] Fix for CMP0018
The new behaviour lets us explicitly disabling position independent code, avoiding the need to change undocumented variables

* LINK_DEPENDS is semicolon separated

* [CMAKE] Fix for CMP0005
it seems impossible to have cmake correct escape PROXY_CLSID_IS so move it to the header
 2019-04-27 11:33:37 +02:00
Eric Kohl
9a24e9799e [POWERCFG] Show the name of the power scheme in the delete confirmation message box 2019-04-26 23:12:36 +02:00
Eric Kohl
7251020e41 [POWERCFG] Some small cleanup 
- Rename IDC_HYBERNATE... to IDC_HIBERNATE...
- Rename IDS_PORCENT to IDS_PERCENT
- Replace %1 by %s in IDS_CONFIG1 and IDS_CONFIG2
 2019-04-26 21:52:30 +02:00
Eric Kohl
0ca4b50791 [POWERCFG] Fix the initialization of the power schemes page 
CORE-4995
 2019-04-26 00:03:27 +02:00
Oleg Dubinskiy
c8611aea13 [DPNHPAST] Import dpnhpast.dll from Wine (Staging) 4.5 2019-04-24 19:59:15 +02:00
Jared Smudde
7e18b6d0eb
[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522) 
CORE-13516, CORE-13518
 2019-04-24 04:28:05 +02:00
Jared Smudde
bf431dd278
[MPR] Implement the function WNetDisconnectDialog(). (#1522) 
CORE-13516, CORE-13518
 2019-04-24 04:28:01 +02:00
Jared Smudde
d1404a7a2a
[NETPLWIZ] Implement the Disconnect Network Drive dialog. (#1522) 
CORE-13516, CORE-13518
 2019-04-24 04:26:12 +02:00
Katayama Hirofumi MZ
9de816c971 [APPWIZ.CPL] Set a default shortcut-link description (#1520) 
CORE-15511
 2019-04-24 03:44:44 +02:00