Commit graph

2756 commits

Author SHA1 Message Date
Katayama Hirofumi MZ fb2aef9e4e
[IMM32] Rewrite ImmNotifyIME (#3853)
Implementing Japanese input... CORE-11700
2021-07-28 23:24:09 +09:00
Katayama Hirofumi MZ a71de262d3
[IMM32] Rewrite ImmSetStatusWindowPos (#3852)
Implementing Japanese input... CORE-11700
2021-07-28 23:23:09 +09:00
Katayama Hirofumi MZ ecb0c0963d
[IMM32] Imm(Lock|Unlock)ImeDpi and ImmSetOpenStatus (#3830)
- Add IMEDPI structure to ntuser.h.
- Implement ImmLockImeDpi/ImmUnlockImeDpi functions.
- Rewrite ImmSetOpenStatus function.
- Modify some NTUSER function prototypes.
- Modify imm32.spec.
CORE-11700
2021-07-25 11:57:57 +09:00
Katayama Hirofumi MZ 97847f2078
[IMM32] Improve ImmGetImeInfoEx (#3833)
- Rewrite ImmGetImeInfoEx function.
- Implement CtfImmIsTextFrameServiceDisabled function.
- Modify imm32.spec.
CORE-11700
2021-07-25 11:56:17 +09:00
Katayama Hirofumi MZ 5afc324359
[IMM32] Improve ImmUnlockClientImc and Imm32HeapAlloc (#3834)
- Fix Imm32HeapAlloc function.
- Fix ImmUnlockClientImc function.
CORE-11700
2021-07-25 11:55:03 +09:00
Joachim Henze c30b1fe893 [SHELL32] Update de-DE.rc in IDD_BROWSE_FOR_FOLDER_NEW
More space for the german text in that button.
Correct the keyboard accelerator.
2021-07-24 15:11:54 +02:00
Mark Jansen d039653959
[SHELL32] CDefView: Respect item attributes 2021-07-23 22:10:36 +02:00
Timo Kreuzer 41bc57ddf0 [REACTOS] Silence warnings in 3r-party code 2021-07-23 22:03:48 +02:00
Timo Kreuzer 5d8e834897 [REACTOS] Fix a number of MSVC warnings 2021-07-23 22:03:48 +02:00
Joachim Henze 1078340f5c [SYSSETUP] Update de-DE.rc
The buttons name on the last dialog of 2nd stage
is "Fertig" and not "Beenden".
So make the help-texts consistent with that.
2021-07-18 17:51:44 +02:00
Eric Kohl 4cae349811 [ADVAPI32][SERVICES] Use the context handle to encrypt and decrypt service passwords 2021-07-17 16:26:16 +02:00
Katayama Hirofumi MZ 3965c93732
[IMM32] Rewrite ImmGetStatusWindowPos (#3824)
Rewrite ImmGetStatusWindowPos function. CORE-11700
2021-07-16 07:30:55 +09:00
Katayama Hirofumi MZ 0966e32146
[IMM32] Rewrite ImmGetCandidateWindow (#3823)
Rewrite ImmGetCandidateWindow function. CORE-11700
2021-07-16 03:04:00 +09:00
Eric Kohl 228dab60da [SAMSRV] SamrQueryInformationDomain: Older functions should call new functions 2021-07-15 17:25:06 +02:00
Katayama Hirofumi MZ b06b628f30
[IMM32] Rewrite ImmGetIMEFileNameA/W (#3822)
- Rewrite ImmGetIMEFileNameA and ImmGetIMEFileNameW functions. CORE-11700
2021-07-15 23:01:50 +09:00
Katayama Hirofumi MZ 3714ee269b
[IMM32] Rewrite ImmGetDefaultIMEWnd (#3821)
- Rewrite ImmGetDefaultIMEWnd function.
- Add g_dwImm32Flags global variable.
- Add Imm32QueryWindow helper function.
- Implement CtfImmIsCiceroEnabled function.
- Modify imm32.spec.
CORE-11700
2021-07-15 21:59:53 +09:00
Eric Kohl 2210d23fc7 [NETAPI32] Return the old values for NetGetJoinInformation() to fix Chrome Installer regression
Should fix CORE-17679
2021-07-14 15:22:17 +02:00
Katayama Hirofumi MZ 192981a1fe
[IMM32] Rewrite ImmGetCompositionWindow (#3820)
Rewrite ImmGetCompositionWindow function. CORE-11700
2021-07-13 21:13:39 +09:00
Katayama Hirofumi MZ 1558e6d0b3
[IMM32] Rewrite ImmGetCompositionFontA/W (#3813)
- Rewrite ImmGetCompositionFontA and ImmGetCompositionFontW functions.
- Add INIT_* macro definitions in <ddk/imm.h>.
CORE-11700
2021-07-13 20:51:28 +09:00
Katayama Hirofumi MZ ee3b5b44c1
[IMM32] Rewrite ImmGetCandidateListCountA/W (#3812)
Implement ImmGetCandidateListCountA and ImmGetCandidateListCountW functions by using newly defined ImmGetCandidateListCountAW function. CORE-11700
2021-07-13 20:17:17 +09:00
Joachim Henze a5365194f4 [COMCTL32] Listview: Only apply horizontal offset when setting header position CORE-17674
This imports
Wine commit d92906249f (diff-7f0ae6301b1f6ea1128640b76cd831308e24466f15399de6d5040557b79f0f16)
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Thanks to Doug Lyons who picked the fix for us from Wine 6.0

It fixes for us CORE-17674 "Corruption of the listview header"
which regressed by 0.4.14-dev-150-g 00f14ee1f2
when we synced to Wine Staging 4.18

Testbot results of the patch:
KVM https://reactos.org/testman/compare.php?ids=78225,78270 LGTM
VBox https://reactos.org/testman/compare.php?ids=78226,78271 LGTM

I intend to port this back into 0.4.14RC94 also, so no official reactos release
will ever be affected by it.
2021-07-13 07:38:45 +02:00
Eric Kohl ccde294b24 [SAMSRV] Older functions should call newer functions 2021-07-11 12:54:28 +02:00
Katayama Hirofumi MZ e2d8837986
[BROWSEUI] Multithreaded auto-completion (#3794)
- Make auto-completion multi-threaded.
CORE-9281
2021-07-11 13:00:00 +09:00
Katayama Hirofumi MZ 92393a7517
[IMM32] Add some candidate handlings (#3799)
- Implement ImmGetCandidateListA and ImmGetCandidateListW, by using newly added ImmGetCandidateListAW function.
- Implement ImmLockClientImc and ImmUnlockClientImc functions.
- Modify imm32.spec.
- Remove #ifdef's.
CORE-11700
2021-07-11 09:48:15 +09:00
Robert Naumann 65387805a0
Add/Update German translation (#3805)
Add translations for:

- [CHARMAP_NEW]
- [COMP]
- [EVENTCREATE]
- [TIMEOUT]
- [WHERE]
- [UTILMAN]
- [CHKDSK]
- [SHELLEXT]: cryptext, devcpux, mycomp, netplwiz
- [MSXML3R]
- [THEMES]: Blackshade, Lunar

Update translations for:

- [CLIPBRD]
- [SHORTCUTS.INF]
2021-07-09 11:15:34 +02:00
Eric Kohl 7faca935e6 [SETUPAPI] PNP_RegisterNotification: Parameter 8 seems to be a process ID 2021-07-08 10:58:47 +02:00
Katayama Hirofumi MZ 5c624d40e7
[IMM32] Rewrite ImmGetOpenStatus (#3804)
- Rewrite ImmGetOpenStatus function. CORE-11700
2021-07-08 14:24:27 +09:00
Katayama Hirofumi MZ 211de1257e
[IMM32] Rewrite ImmIsIME (Retry) (#3803)
- Rewrite ImmIsIME function.
- Fix enum IMEINFOEXCLASS.
CORE-11700
2021-07-08 14:23:25 +09:00
Katayama Hirofumi MZ 6eeea92530
[IMM32] Rewrite IMCC handling functions (#3788)
Rewrite ImmCreateIMCC, ImmDestroyIMCC, ImmReSizeIMCC, ImmGetIMCCLockCount, ImmUnlockIMCC, ImmLockIMCC, and ImmGetIMCCSize functions. CORE-11700
2021-07-07 10:04:30 +09:00
Joachim Henze 2cbb3ebdcb [SHELL32] EOL-white-space-fixes dialogs.cpp
Exclusively touching code that was recently
added during 0.4.15-dev'ing.
2021-07-06 23:27:32 +02:00
Doug Lyons 33c7c91b36
[SHELL32] Improve Start-Run Dialog Box Features (#3797) CORE-17351 CORE-16898
Improve performance of Start-Run Dialog Box Options

This will fix:
CORE-17351 'RunDlg fails calling URL without http'
and
CORE-16898 'RunCommand "iexplore" fails to open Wine IE'
Both regressed by 0.4.10-dev-419-g bfcbda227f
2021-07-06 19:36:15 +02:00
Katayama Hirofumi MZ c238b554b1
[IMM32] Rewrite ImmGetConversionStatus (#3790)
Implementing Japanese input... CORE-11700
2021-07-05 21:20:20 +09:00
Eric Kohl fb8edf90a0 [SAMSRV] Start work on the display cache
Initialize the cache and fill it on demand
2021-07-04 12:45:19 +02:00
Eric Kohl 556cef5be3 [SAMLIB] Add function names to trace messages 2021-07-04 12:31:22 +02:00
Katayama Hirofumi MZ 89f5f5bb95
[IMM32] Rewrite ImmGetDescriptionA/W (#3780)
CORE-11700
2021-07-04 08:18:15 +09:00
Eric Kohl bf05fcbd29 [SAMSRV] Older functions should call newer functions 2021-07-03 14:46:32 +02:00
Timo Kreuzer adc86c2442 [NETAPI32] Zero out lpNameBuffer in NetGetJoinInformation
This is needed, because for some reason, otherwise RPCRT4 will assume that whatever value is in there is already the buffer and copy the string there.
Fixes exception in Chrome 48.
2021-07-03 12:56:48 +02:00
Katayama Hirofumi MZ 650cd77234
[IMM32] ImmDisableIME calls NtUserDisableThreadIme (#3776)
- Just call NtUserDisableThreadIme in ImmDisableIME directly. CORE-11700
2021-07-01 18:03:42 +09:00
Katayama Hirofumi MZ 561fa8d29b
[SHELL32] Implement PathResolveA function (#3771)
- Follow-up of #3762.
- Add PathResolveA implementation by ANSI/Unicode string conversion.
CORE-12665
2021-07-01 08:42:29 +09:00
Hermès Bélusca-Maïto e7a5850d65
Revert "[SHELL32] Don't check for link files being targets for other link files. Addendum to 3a822e4f."
This reverts commit 3249a00364.
2021-06-28 04:11:00 +02:00
Hermès Bélusca-Maïto 3199fdbd44 [SHLWAPI] Fix a trivial bug in PathFileExistsDefExtW() that seems to exist since 16+ years in Wine.
Suppose dwFlags == 1 | 4 (i.e. skipping the flag 2).
Then the while-loop would only run once, because at the second iteration
(after dwWhich >>= 1; has been executed once), dwWhich value == 2, but
dwWhich & 0x1 == 0, which makes the while-loop condition false.
Instead the loop should run, but the handling of the extension should be
skipped.
2021-06-28 02:19:31 +02:00
Hermès Bélusca-Maïto 8ec3580123 [SHELL32] Add the handy WHICH_DEFAULT value to the list of flags in shlwapi_undoc.h.
- Add as well the undocumented 0x40 dwFlags value from shlwapi!PathFileExistsDefExtW()
  to the list.

- Fix a bug (also present in Win2k3) in PathResolveW() where, specifying
  the PRF_DONTFINDLNK flag, would also erroneously exclude checking for
  the .cmd extension as well (which was obviously NOT the original
  intention, from the name of the flag and the documentation as well:
  https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-pathresolve
  ).

Addendum to 3a822e4f.
2021-06-28 02:19:30 +02:00
Hermès Bélusca-Maïto 3249a00364 [SHELL32] Don't check for link files being targets for other link files. Addendum to 3a822e4f. 2021-06-28 02:19:30 +02:00
Joachim Henze adee5ca255 [COMCTL32] Addendum to last commit (#3674) CORE-17199
Keep that section like we had it to
support compilation on VS2010.
It does still work like that.

Addendum to commit 0.4.15-dev-2796-g e382b7bc35
2021-06-28 02:05:56 +02:00
Doug Lyons e382b7bc35
[COMCTL32] Sync datetime.c to Wine-6.0 (#3674) CORE-17199
Fix automatic toggling of date display on second stage setup
Update comctrl from Wine with fix.

Sync datetime.c to Wine-6.0
2021-06-28 01:18:10 +02:00
Katayama Hirofumi MZ 3a822e4f74
[SHELL32] Implement PathResolveW function (#3762)
- Implement PathResolveW function.
- Implement PathQualifyA/W functions using newly-defined PathQualifyExW function.
CORE-12665
2021-06-28 07:53:26 +09:00
Eric Kohl 37f38a80de [SAMSRV] Fix call to SamrCloseHandle in SamrGetDomainPasswordInformation 2021-06-21 21:38:42 +02:00
Eric Kohl be65a8568b [SAMLIB] Check the server name in the binding routine 2021-06-19 21:51:06 +02:00
Eric Kohl 5b6e8af1bd [SAMLIB] SamConnect: Pass a zero-terminated server name to SamrConnect 2021-06-19 20:29:24 +02:00
Joachim Henze a3cadf630a [COMCTL32] Strip EOL whitespace within ifdef __REACTOS__ section
no functional change.
Make that look beautiful before porting it back further.

Addendum to 0.4.15-dev-534-g 887764e607
(CORE-17062)
2021-06-16 11:41:56 +02:00
Joachim Henze d5265b07bb [MSI] Enumerate only type DRIVE_FIXED CORE-17623 (& CORE-14432)
MSI on 2k3sp2 hides empty CD-ROM, and hides CD-ROM with iso mounted.
MSI on 2k3sp2 hides VBox shares, both: writable and read-only-ones.
MSI on 2k3sp2 hides floppy drives with a floppy img mounted.
MSI on XPSP3 hides a mounted writable USB stick.

Thanks to the patches author Doug Lyons.

This patch supersedes
0.4.15-dev-2651-g 864e20b881 (CORE-14432)
and we are also better than Wines
0dd0d879a1
2021-06-13 15:30:49 +02:00
Eric Kohl 6ae7fc2b04 [LSASRV] Notify all authentication packages of a session to be deleted 2021-06-06 11:38:26 +02:00
Mark Jansen 1d68fe209f
[SYSSETUP] Use the calculated full path 2021-06-05 22:14:34 +02:00
Joachim Henze 864e20b881 [MSI] setup should not enumerate read-only CDRoms as install-targets CORE-14432
We decided to check a bit different than Wine currently does.
Wine checks for
if (GetVolumeInformationW(ptr, NULL, 0, NULL, 0, &flags, NULL, 0) && flags & FILE_READ_ONLY_VOLUME)
to exclude read-only-media while we (for now) check for
if (GetDriveTypeW(ptr) == DRIVE_CDROM)

For now this gives us the benefit of covering also CDROM drives, that do not have
a CD put into it.
That does not work properly for us with the Wine patch yet, but it does for Wine!
So this maybe points to some other bug in ros, maybe in our CDROM(FS)-drivers?

In the future we should also test this on other read-only-media in Windows e.g.
a read-only USB stick to decide whether we want to stick with our current solution
or whether we want to switch to Wines solution or whether we want to logically OR
both conditions!

Thanks to Doug Lyons for providing what *currently* does work best for us!

VBox https://reactos.org/testman/compare.php?ids=77537,77546 (no change)
KVM https://reactos.org/testman/compare.php?ids=77531,77541 (no change)
2021-06-05 21:27:40 +02:00
Serge Gautherie 83fcd65700
[MPR] spec: Add stubs, document parameter types, stub-enable 2 functions (#3696)
* Add 20 stubs from mpr.dll v5.2.3790.3959.
* Document some parameter types from https://github.com/Microsoft/winfile/
* Change WNetGetDirectoryType[A|W] to no-op stubs

CORE-14376
2021-06-05 20:49:41 +02:00
Timo Kreuzer 11ffa31155 [BROWSEUI] Fix broken code 2021-06-04 09:15:55 +02:00
Piotr Hetnarowicz 4771551c74
[BROWSEUI] Polish translation update (#3703) 2021-06-02 11:53:07 +02:00
Piotr Hetnarowicz d05a20e7b3
[SHELL32] Polish translation update (#3701) 2021-06-02 11:50:54 +02:00
Eric Kohl 7b970c67a8 [NETCFGX] Create unique network connection names 2021-05-30 21:12:58 +02:00
Mark Jansen f0bee6c4bc
[SHELL32] CDefView: Prevent use after free
While updating the item, the LVIF_STATE would be requested,
for which the old lParam would be accessed.
2021-05-26 22:57:43 +02:00
Eric Kohl 894cc4ac0c [dnsapi][dnsrslvr] Implement DnsFlushResolverCacheEntry_A/_UTF8/_W 2021-05-24 14:43:30 +02:00
Mark Jansen 9fcdc68182
[SHELL32] Include the folder path in logging 2021-05-22 16:34:54 +02:00
Mark Jansen b58c3d73ca
[RTL][KERNEL32] Move the STUB printing code to a place where it's actually called 2021-05-22 16:33:19 +02:00
Joachim Henze cf6c191f69 [SHELL32] *.rc Whitespace fixes just, no functional change
Motivation to fix them in master is to avoid having to also port them back
when porting back nearby code.
2021-05-15 03:44:48 +02:00
Catalin Gabriel Draghita 2636cff09f
[SHELL32] Show Product version on About dialog bmp (#3621)
The About dialog banner will now show the correspondent Product version selected on install.
This will make it easier to tell which edition of ReactOS is installed.
2021-05-08 15:54:32 +09:00
Mas Ahmad Muhammad fd4d8f550c [TRANSLATION] indonesian add and update apps/shell translation 2021-05-05 11:34:28 +02:00
Jérôme Gardou 523912536e [KERNEL32] Sync NLS RC files with wine 6.7
Mostly for having them UTF-8 encoded
2021-05-03 22:00:57 +02:00
Jérôme Gardou 061c7ecb1a [FRAMEDYN] Fix the whole situation with regards to wchar_t
Alias CHSTRING_WCHAR to unsigned short and use inline wrappers
to be able to use the thing with modern compilers

Put the GCC aliases into the public header.

Enable build with clang-cl
2021-05-03 22:00:57 +02:00
Serge Gautherie 249f2388bd
[REACTOS] Fix parameter types on some exports (#3217)
Fix some wrong parameter types on some exports in NTDLL, KERNEL32, WTSAPI32, and NTOSKRNL.
2021-05-01 21:11:34 +02:00
Jérôme Gardou e470b58376 [REACTOS] Explicitly link against pseh & include pseh headers in a few places 2021-04-28 13:10:23 +02:00
Jérôme Gardou 9ef5a7eb7a [CMAKE] Fix compilation with newer windres versions
Also use clang as preprocessor when using it
Also, use *our* headers instead of the platform ones
2021-04-27 11:54:12 +02:00
Hermès Bélusca-Maïto 869a914cfd
[SYSSETUP] Forgot to update the ROS banner after 2021. Addendum to b570fac1. 2021-04-26 02:21:59 +02:00
George Bișoc 1cf1892b14
[COMCTL32] Fix an incorrect returned value for ImageList_Remove
Thanks goes to Kyle Katarn. Had to make a commit myself due to author's account being deleted.

Signed-off-by: Kyle Katarn <contact@kcsoftwares.com>
2021-04-24 20:13:56 +02:00
George Bișoc 84b3fecb26
[MSGINA] Determine which kind of dialog box is before terminating it
Do a sanity check onto the dialog box type before terminating it. As it stands now, a call of PostQuitMessage() is invoked even when the dialog box is modal. This is illegal due to the fact that the shutdown dialog box is initiated by the "Security" main window thus WlxDialogBoxParam.

A call to PostQuitMessage onto a modal dialog box leads to a undefined behaviour, as it'll not just terminate the thread but also eventually killing the Winlogon process whose the thread belongs to.
CORE-17535
2021-04-22 13:30:55 +02:00
Eric Kohl 32428a39ed [NEWDEV] Set the CM_PROB_FAILED_INSTALL problem code on failed install
CORE-17527
2021-04-20 22:00:41 +02:00
Serge Gautherie 0dedb9b474
[WINLOGON][MPR][SDK] WNetClearConnections: Fix function parameter type (#3480)
Addendum to 62f79fae93.

Signed-off-by: Serge Gautherie <reactos-git_serge_171003@gautherie.fr>
2021-04-18 21:58:44 +03:00
Hervé Poussineau af9df93274 [WS2_32] Create registry keys Protocol_Catalog9/NameSpace_Catalog5 if needed
This fixes networking in LiveCD and installation in 2nd stage.
CORE-17514
2021-04-17 23:57:41 +02:00
Eric Kohl 9e947e2b2b [DEVMGR] Get rid of the unknown device class hack
Treat the unknown device class like any other device class.

CORE-17527
2021-04-16 23:45:08 +02:00
Eric Kohl 3fa57b8ff7 [NEWDEV] When a device install fails, set the 'Unknown' device class for that device
CORE-17527
2021-04-15 21:49:32 +02:00
Serge Gautherie 1758c3831b [MSHTML] MSVC: There is no 'error C4028' anymore
MSVC amd64
'...\dll\win32\mshtml\nsio.c(3755): error C4028: formal parameter 3 different from declaration'
was fixed by 5ed1867.

CORE-7538
2021-04-14 20:55:57 +02:00
Tibor Lajos Füzi ea04edce2d [TRANSLATION] Add/update Hungarian translation for solitaire, spider solitaire, rapps, usetup, cpl/timedate, shell32, user32 2021-04-14 16:16:24 +02:00
Hervé Poussineau e044df8736 [SETUPAPI] Correctly enumerate non-installed devices in SetupDiGetClassDevsExW
Always try to read the correct device GUID from registry, even if GUID filter is disabled.

CORE-17527
2021-04-11 15:12:02 +02:00
Hervé Poussineau f9df7af28a [SETUPAPI] Reimplement SetupDiBuildClassInfoListExW using CM_* functions
We can now enumerate device classes on other computers.
2021-04-11 15:12:02 +02:00
Hervé Poussineau 8da00cd97c [SETUPAPI] Fix CM_Open_Class_Key_ExW, when pClassGuid is used
Braces around GUID were missing.
2021-04-11 15:12:02 +02:00
Chan Chilung 6b700c6af1
[TRANSLATION] Chinese Traditional (zh-TW) translation update (#3526)
*Add Chinese Traditional translation for:
- [THEMES]
- [HIVESFT]
- [HIVEDEF]
- [HIVECLS]
- [SCREENSAVERS]
- [VGAFONTEDIT]
- [KERNEL32]
- [TASKLIST]
- [MYDOCS]
- [MSXML3R]
- INFs

*Chinese Traditional translation update for:
PR 3399
- [MSGINA]
- [SHELL32]

PR 3422
- [SOLITAIRE]

Others...

*Wine translation sync
2021-04-11 10:59:19 +02:00
George Bișoc 2ae526a039
[SHELL32] Do not format the partition if it's a system drive
Implement a sanity check helper which determines if the partition is a system drive or not based on the %SystemDrive% environment variable, preventing the user from nuking accidentally the partition with ReactOS system files installed. :P

NOTE: This code serves as a temporary measure to prevent accidental formatting of the system drive. In the future most of this code has to be totally rewritten (and stopping syncing with WINE altogether) as well as FMIFS library code so that we're on par in terms of compatibility with Windows.
2021-04-10 17:38:23 +02:00
Eric Kohl c2757032c8 [DEVMGR] Use FlagsEx to check for DI_FLAGSEX_POWERPAGE_ADDED 2021-04-10 16:22:47 +02:00
Eric Kohl ab0bbeb126 [DEVMGR] UpdateDevInfo: Enable built-in property pages by default
CORE-17532
2021-04-10 15:50:37 +02:00
Victor Perevertkin 74ec94e12c [CMAKE] Some options are only supported by GCC, don't use them for clang
These are (so far):
-Wno-format-overflow
-Wno-nonnull-compare
-Wno-old-style-declaration
-Wno-unused-but-set-variable
2021-04-09 03:58:19 +03:00
Mark Jansen 2587d72ef7 [WINSXS] Add some amd64 manifests
Co-authored-by: Timo Kreuzer <timo.kreuzer@reactos.org>
2021-04-08 20:48:24 +03:00
Katayama Hirofumi MZ 773ad7aebc
[BROWSEUI] auto-completion: Support large number items (#3592)
If the items are too many, enable filtering in item enumeration. CORE-9281
2021-04-08 15:02:05 +09:00
Eric Kohl e4646bc5d1 [SETUPAPI] SetupDiInstallDevice: Do not fail if the .inf file does not have a .Services section
CORE-17530
2021-04-07 21:39:55 +02:00
Hervé Poussineau 4d25869e0e [SYSSETUP] Manually start PlugPlay service, and wait for it before continuing
That way, class installers are already registered before installing devices.

CORE-17538
2021-04-07 19:35:50 +02:00
Katayama Hirofumi MZ 2fd058dce6
[BROWSEUI] Reduce IAutoComplete failures (#3590)
- Delete OnEditUpdate method.
- Improve the expand condition.
CORE-9281
2021-04-07 13:38:22 +09:00
Katayama Hirofumi MZ 2eaf0afcd2
[BROWSEUI] auto-completion: Reduce failures in ACListISF (#3589)
Reduce failures in ACListISF testcase. Skip left space in auto-completion. Accept the pair of drive letter and colon. CORE-9281
2021-04-06 21:56:40 +09:00
Katayama Hirofumi MZ fefac1fb1d [BROWSEUI] Accept environment variables in ACLO_FILESYSDIRS
Properly handle ACLO_FILESYSDIRS. CORE-9281
2021-04-05 22:20:01 +09:00
Katayama Hirofumi MZ badcfb2f7d [BROWSEUI] Accept environment variables on auto-completion
Expand %WINDIR%, %SystemRoot% etc. at CACListISF::Expand. CORE-9281
2021-04-05 17:20:35 +09:00
Katayama Hirofumi MZ a5950308fd [BROWSEUI] Follow-up of #3582
Also fixes VK_HOME and VK_END. CORE-9281
2021-04-05 07:43:40 +09:00
Katayama Hirofumi MZ ab7d8f3616
[BROWSEUI][BROWSEUI_APITEST] Add CLSID_ACLHistory stubs (#3582)
- Initial implement CLSID_ACLHistory as stub.
- Add IACLHistory testcase into browseui_apitest.
CORE-9281
2021-04-05 04:20:18 +09:00
Eric Kohl 6c4b4a107b [DEVMGR] Display hexadecimal values of Capabilities, ConfigFlags, DevnodeFlags and CsFlags 2021-04-04 11:44:38 +02:00
Serge Gautherie 28dadda8be [CMAKE] Properly generate all Bison and Flex files at build time
This fully reverts 09c4d0a.

Addendum to 5375e33.
CORE-15991
2021-04-03 21:50:08 +03:00
Katayama Hirofumi MZ 206156fad5
[BROWSEUI] Fix auto-completion on relative paths (#3578)
Fix the CLSID_ACListISF object about relative paths. If the given path is relative at CACListISF::Expand, then convert it to a full path. CORE-9281
2021-04-03 20:38:25 +09:00
Hervé Poussineau 4712deb8a8 [SETUPAPI] Fix wrong buffer size given to CM_Get_Device_ID_List_ExW
This buffer overflow was introduced in previous commit.
2021-04-03 00:52:01 +02:00
Hervé Poussineau 0f3133c308 [SETUPAPI] Use CM_* functions to get list of devices
- this prevents duplicating the code with umpnpmgr::PNP_GetDeviceList
- we can enumerate devices on other computers

This is part of the bugfix for CORE-17529
2021-04-02 21:41:09 +02:00
Katayama Hirofumi MZ ade5413362
[SHELL32] Auto-completion on Properties for Shortcut (#3574)
Enable auto-completion on "Properties for Shortcut files". CORE-9281
2021-04-02 17:04:43 +09:00
Katayama Hirofumi MZ 62b13979f5
[NEWDEV] Enable auto-completion on Hardware Wizard (#3573)
Realize auto-completion on Hardware Wizard. CORE-9281
2021-04-02 11:06:01 +09:00
Katayama Hirofumi MZ b591bd3354 [NEWDEV] Use new UI dialog for browsing folder
Add BIF_USENEWUI flag to BROWSEINFO. CORE-9281
2021-04-02 08:58:09 +09:00
Katayama Hirofumi MZ bebdfda8b7
[NOTEPAD][WORDPAD][MSPAINT]... Use newer file open dialog (#3571)
Use new-style file open/save-as dialog.
- Add OFN_EXPLORER flag to OPENFILENAME structure in notepad, wordpad, mspaint, clipbrd, mmc, mplay32, mscutils, regedit, winhlp32, progman, shellbtrfs, cryptui, shell32, setupapi, vgafontedit, infinst, and vfdlib modules.
2021-04-01 22:50:32 +09:00
Katayama Hirofumi MZ 7e6550b35e
[COMDLG32] Enable auto-completion on comdlg32 (#3564)
Auto-completion will be enabled when the user opens "Open" or "Save As" dialog of the common dialogs. CORE-9281

NOTE: The relative pathes, "..\" and "\" are not working. Those are bugs in CLSID_ACListISF.
2021-04-01 06:41:24 +09:00
Katayama Hirofumi MZ 91e591b3d5
[BROWSEUI] Enable AutoAppend of auto-completion (#3552)
Fix and improve Auto-Append of auto-completion. CORE-9281
- Implement CAutoComplete::DoAutoAppend method.
2021-03-30 06:50:32 +09:00
Katayama Hirofumi MZ d5c72a2e09
[BROWSEUI] Support ACO_USETAB and SHACF_USETAB on auto-completion (#3549)
Support Tab key on auto-completion. CORE-9281
2021-03-25 07:42:24 +09:00
Serge Gautherie ca1814f2c9 [SYSSETUP] security.c: Remove 3 useless casts
And
* Make 1 cast more explicit.
* Fix 1 'SamSetInformationUser' copypasta in DPRINT1() text.
* Optimize 1 '.MaximumLength' assignment.
2021-03-24 12:15:55 +01:00
Serge Gautherie 4cd92f0d01
[SYSSETUP][TIMEDATE] Use exact setTimer() timeouts, to stay in sync (#3355)
CORE-13121
2021-03-21 12:01:22 +09:00
Katayama Hirofumi MZ 53005587f4
[BROWSEUI] Fix return value on sanity check of auto-completion (#3544)
Reduce failures on sanity check of auto-completion. CORE-9281
- Return E_FAIL rather than E_INVALIDARG in sanity check of CAutoComplete::Init (IAutoComplete::Init).
2021-03-20 14:04:02 +09:00
Katayama Hirofumi MZ f49c164428
[BROWSEUI] Fix auto-completion on VK_DELETE (#3543)
Reduce failures against Delete key on auto-completion. CORE-9281
2021-03-20 13:18:47 +09:00
Mark Jansen 4885c34fa8
[SYSSETUP] SamQueryInformationUser expects a pointer 2021-03-20 00:28:07 +01:00
Katayama Hirofumi MZ 880252fd46 [SHELL32] Fix assertion failure in CDirectoryWatcher.cpp
CORE-17511
2021-03-19 08:30:10 +09:00
Mark Jansen c59ab8fce1 [SYSSETUP] SamQueryInformationDomain expects a pointer 2021-03-18 23:28:17 +01:00
Jérôme Gardou 0d41593749 [WS2_32] Check that the handle table is initialized before accessing it. 2021-03-17 18:53:12 +01:00
Katayama Hirofumi MZ b66bdef370
[SHELL32] Enable auto-completion on SHBrowseForFolder (#3535)
This PR realizes auto-completion on SHBrowseForFolder. CORE-9281

- Call SHAutoComplete in WM_INITDIALOG message handling.
- Fix focus.
- Remove ES_NOHIDESEL style.
- Fix layout initialization.
2021-03-15 16:30:32 +09:00
Katayama Hirofumi MZ 2d066c93fe
[SHELL32] Fix SHBrowseForFolder new UI layout (#3533)
CORE-17507

- Change layout of resource dialogs IDD_BROWSE_FOR_FOLDER_NEW.
- Delete IDC_BROWSE_FOR_FOLDER_FOLDER control.
- Fix focus.
- Add ES_NOHIDESEL style to IDC_BROWSE_FOR_FOLDER_FOLDER_TEXT control.
- Add TVS_SHOWSELALWAYS style to IDC_BROWSE_FOR_FOLDER_TREEVIEW control.
- Fix assertion failure in LayoutUpdate function in <layout.h>.
2021-03-15 07:13:03 +09:00
Katayama Hirofumi MZ e1a5ba188e
[SHELL32] SHBrowseForFolder with BIF_EDITBOX should use new UI (#3532)
CORE-17506

- Convert some judgements against BIF_NEWDIALOGSTYLE to judgements against BIF_USENEWUI. Here BIF_USENEWUI == (BIF_NEWDIALOGSTYLE | BIF_EDITBOX).
- Remove WS_SIZEBOX window style from new UI dialog resource (IDD_BROWSE_FOR_FOLDER_NEW).
- Fix header layout.h for resizing without WS_SIZEBOX.
2021-03-14 18:35:40 +09:00
Katayama Hirofumi MZ 9259ded8ae
[ATL][SHELL32][EXPLORER] Disable ATLASSERT (#3527)
We are not ready for enabling ATLASSERT. Enabling ATL assertions takes time to realize. CORE-17505
- Disable ATLASSERT by undefining _DEBUG.
- Revert currently non-fixable codes.
2021-03-11 20:26:45 +09:00
Katayama Hirofumi MZ 4583eae4f7 [SHELL32] Fix CMenuToolbarBase
CORE-17505
2021-03-11 17:51:47 +09:00
Katayama Hirofumi MZ 6546ad7700 [BROWSEUI] Fix CACListISF::Next assertion
CORE-9281
2021-03-11 17:12:06 +09:00
Katayama Hirofumi MZ bcba930622 [BROWSEUI] Fix CAutoComplete::OnMeasureItem assertion
CORE-17505
2021-03-11 16:56:01 +09:00
Katayama Hirofumi MZ 32a9b64051 [BROWSEUI] Fix addreseditbox.h assertion
CORE-17505
2021-03-11 16:42:36 +09:00
Mark Jansen 1952e5b795
Fix some assertions now that they are enabled (#3524)
Fix some assertions, hack out some others (they need more ATL work).
CORE-17505
2021-03-11 07:43:06 +09:00
Katayama Hirofumi MZ a63213272a
[SHELL32] Enable auto-completion on 'Folder Options' > 'Change Icon' (#3522)
CORE-9281
2021-03-10 21:00:36 +09:00
Katayama Hirofumi MZ 71e4450761 [BROWSEUI] Follow-up of #3507
Case insensitiveness fix. CORE-9281
2021-03-10 19:45:03 +09:00
Katayama Hirofumi MZ c19d9df259
[BROWSEUI] Implement auto-completion (#3507)
Implement IAutoComplete to realize input auto completion. CORE-9281, CORE-1419

- The main features of this PR are Auto-Suggest and Auto-Append.
- Auto-Suggest shows a list near the textbox (an EDIT control) when the user has typed partial pathname into the textbox.
- Auto-Append appends complement text into the textbox to complete the pathname with selected status.
- The list of AutoSuggest is a top-level window whose window class is "Auto-Suggest Dropdown". We call it "the drop-down window".
- The drop-down window contains three controls: a listview, a scrollbar and a sizebox.
- The drop-down window watches the input into the textbox. If the textbox changed, then the window updates the list.
- The sizebox control enables the user to resize the drop-down window.
2021-03-10 16:22:57 +09:00
Chan Chilung 6a31fe6ca7
[TRANSLATION][INF] Update Chinese Traditional (zh-TW) translation (#3468)
- Add / improve Chinese Traditional Translations for INFs.

- Name changing (removed Aobi in my name)

Add Chinese Traditional translation for:
- cmdutils/at
- cmdutils/comp
- hotplug.cpl
- rosapps' sysutils/ctm

Chinese Traditional (zh-TW) translation update for:
- cmdutils/find
- cmdutils/help
- cmdutils/label
- cmdutils/whoami
- mspaint
- shutdown
- taskmgr
- diskpart
- format
- appwiz.cpl
- input.cpl
- powercfg.cpl
- shimgvw
- user32
2021-03-09 16:51:37 +01:00
George Bișoc 5fbf5e78e1
[SHELL32] Avoid code duplication on FAT and EXT2/BtrFS related FSs insertion (#3505)
This is a slight refactor of InsertDefaultClusterSizeForFs() code with the goal to avoid having the same code for FAT-related and EXT2/BtrFS filesystems.
2021-03-09 16:17:23 +01:00
Arnav Bhatt 06f57e1696
initial commit (#3506) 2021-03-06 19:13:05 +01:00
Serge Gautherie 8c18617fa7
[CMAKE] Fix few copy-paste typos in add_pch() calls (#3508)
Follow-up to e898c9e.
2021-03-06 19:11:56 +01:00
Serge Gautherie 62b4c61f82
[NETCFGX] LoadDNSSettings(): Improve one RegQueryValueExW() call (#2870) 2021-03-04 23:29:38 +01:00
Jérôme Gardou 43ea864405 [DBGHELP] Fix use of unix path 2021-03-04 17:41:25 +01:00
Jérôme Gardou 93d741c3f4 [SHLWAPI] Use an object library to separate C & C++ compilation units
CORE-17423
2021-03-03 08:34:32 +01:00
Jose Carlos Jesus 6e40a96145
[DEVMGR][NETID] Update PT translation (#3487)
And readjust objects size to fit all text in Driver tab.
2021-03-03 04:18:15 +01:00
Victor Perevertkin fc2b105e5d
[CMAKE] Use remove_target_compile_option when disabling manually enabled warnings 2021-03-03 06:04:25 +03:00
George Bișoc 9536f44c81
[SHELL32] Determine if the FS is of type FATX (#3398)
FATX is listed as a filesystem for format within the list but it's classed out from current proposed filesystems, thus spamming the debug output and not allowing to actually format a storage drive with this FS.
CORE-17272
2021-03-02 19:37:31 +01:00
Piotr Hetnarowicz 27ca352d2b
[SHELL32] Improve Polish [pl-PL] translation (#3494) 2021-03-02 19:09:53 +01:00
Jérôme Gardou 42b94e728a [ADVAPI32] In RegSetValueExW, do not fail if we fault when checking for ending NUL character 2021-03-02 15:42:21 +01:00
Jérôme Gardou 7320c989fe [WS2_32] Fix error handling on non-existing registry keys 2021-03-02 14:39:22 +01:00
Carlo Bramini a141c91135
[SHIMGVW] Improve zooming feature and realize image edit (#3473)
* [SHIMGVW] Add OLE32 for CoInitializeEx()
* Implemented support for effective image size (100%).
* Fix bug that could leave one of the zoom buttons if 100% size button is now pressed.
* Replace a CreateWindowEx() with CreateWindowExW().
* Added stub for image delete function.
* Implemented support for 'Modify' button.
* [SHIMGVW] Added CoUninitialize()
* [SHIMGVW] Pair CoUninitialize with CoInitializeEx
2021-03-01 23:40:06 +09:00
Arnav Bhatt fd39a292af
[MSGINA][SHELL32] Rework friendly UI shutdown dialog box and implement friendly UI log off dialog box (#3399)
Implement the re-worked shut down dialog box as well as implementing fancy log off dialog box.
- Fancy shut down dialog box has been redesigned to be more comparable to of XP.
- Implement features that were missing earlier.
- Implement the fancy log off dialog which is more comparable to of XP.
2021-02-28 20:03:35 +09:00
Eric Kohl 1fbb295d4a [LSASRV][SECUR32] Fix the naming mess
Rename Untrusted to TrustredCaller in LSA_CONNECTION_INFO and LSAP_LOGON_CONTEXT in order to clarify the meaning of the variable.
2021-02-28 11:03:33 +01:00
Eric Kohl 76247390e5 [LSASRV] Fix a typo in the trusted user identification 2021-02-28 01:57:43 +01:00
Katayama Hirofumi MZ f04890c2af
[BROWSEUI] Fix and small improvement (#3486)
Fix a mistake in CAutoComplete PR #3472 (6bfb76b) and improve.
- Fix confusion between m_hwndEdit and hwndEdit.
- Delete extra this-> codes.
CORE-9281
2021-02-25 20:36:20 +09:00
Jose Carlos Jesus 9039de127c [BROWSEUI]Update PT translation 2021-02-24 07:23:39 +01:00
Katayama Hirofumi MZ 6bfb76b68a
[BROWSEUI] Refactoring CAutoComplete Part 1 (#3472)
- Expand tabs to spaces in CAutoComplete.h.
- Add m_ prefix to every member variable.
CORE-9281
2021-02-23 06:07:09 +09:00
Eric Kohl dd1f0d02bc [LSASRV] Improve the policy change registration code and notify registered events 2021-02-21 18:05:11 +01:00
Katayama Hirofumi MZ 0c15f7d183
[SHIMGVW] Use _countof instead of ARRAYSIZE and use UINT (#3471)
- Use _countof macro instead of non-standard ARRAYSIZE macro.
- Use UINT type for array index instead of INT type, to erase signed/unsigned comparison warning.
JIRA issue: N/A
2021-02-21 10:28:08 +09:00
Colin Finck fd8080b094
[KERNEL32] Align the PROCESS_PRIORITY_CLASS variable in GetPriorityClass on a 4-byte boundary.
Fixes CORE-16757.
This is required for NtQueryInformationProcess as proven by my test application in the bug report.
2021-02-20 17:13:38 +01:00
Eric Kohl ea26bef01d [LSASRV] Add start code for the netlogon service 2021-02-19 21:53:00 +01:00
Václav Zouzalík 0f8224e985 [SHIMGVW] Update Czech (cs-CZ) translation 2021-02-16 15:11:50 +01:00
Katayama Hirofumi MZ 99a9e7e493
[SHIMGVW] Refactoring (#3461)
- Make the calls of CallWindowProc and DefWindowProc Wide (Unicode).
- Delete needless type casts.
- Add const to function arguments.
- Improve ImageView_LoadSettings function.
- Insert OFN_EXPLORER flag.
2021-02-15 19:21:55 +09:00
Carlo Bramini ac4b506eab
[SHIMGVW] Fix wrong text into the title bar. (#3459)
Unicode/ANSI conversion problem happened by some wrong ANSI function calls. This PR fixes them by modifying CMakeLists.txt.
2021-02-15 02:38:36 +09:00
Eric Kohl 2a3c94e301 [NETAPI32] Use our implementation of NetWkstaUserEnum instead of the Wine stub 2021-02-14 11:26:54 +01:00
Eric Kohl 87a4624e20 [WKSSVC][NETAPI32] Implement NetrWkstaGetInfo and get rid of the old NetWkstaGetInfo implementation 2021-02-13 23:19:29 +01:00
Robert Naumann 0d1a804581 [SHIMGVW]Update German translation 2021-02-13 20:59:38 +01:00
Robert Naumann e4058ee520 [SHELL32] Update German translation
-change "Meine Musik" to "Eigene Musik" to get a consistent naming. Same for "Meine Videos".
2021-02-13 20:14:05 +01:00
Carlo Bramini 6aafdc520c
[SHIMGVW] Fix CTRL-K to IDC_ROT_CLOCKW (#3457)
As signaled in CORE-11044, the IDC_ROT_COUNCW was assigned to both CW and CCW rotation.
2021-02-13 19:32:19 +01:00
Carlo Bramini 0d4e921c93
[SHIMGVW] Add new features (CORE-11044) (#3113)
Add these new features:

- Use accelerator table for keyboard hotkeys.
- Updated italian translation.
- Simplified creation of toolbar and tooltips.
- Added missing toolbar buttons.
- Initialize common controls for theming.

French translation by Kyle Katarn.
Polish translation by Adam Stachowicz.
2021-02-13 23:22:21 +09:00
Robert Naumann b493a2f8ab [SYSSETUP] Update German translation. 2021-02-09 21:03:34 +01:00
Serge Gautherie 682f85ad9f
[DOC][WS2_32][WS2HELP] Fix ws2* paths (#3425) 2021-02-07 22:17:01 +01:00
Yaroslav Kibysh c917caf723
[SYSSETUP] Make status dialog look like msgina status dialog (#2825)
* [SYSSETUP] Add msgina-like resources

* [SYSSETUP] Add bitmaps functionality, remove progress bar

* [SYSSETUP] Update resources

* [SYSSETUP] Use DPRINT1

* [SYSSETUP:INSTALL] %d - %lu for GetLastError in DPRINT1

* [SYSSETUP:INSTALL] Check pDlgData for NULL value

+ add some comments
2021-02-07 20:36:55 +01:00
Mark Jansen b809275cbe
[WININET] Fix usage of uninitialized variable 2021-02-07 14:00:12 +01:00
Siavosh Kasravi bb723c337a
[SHELL32] Fixing COpenWithMenu.cpp for handling path strings with spaces (#3449)
CORE-17445

Fixing the bug where open with menu where OpenWithMenu does not handle handler's path when there are spaces in the path string, by adding the missing quote marks around %1 when recording the registry entry for file handler.
2021-02-06 14:35:11 +01:00
Eric Kohl 86a65fccb6 [SYSSETUP] Refactor ApplyAccountSettings() and add NewAdministratorName and NewGuestName options 2021-01-30 13:52:14 +01:00
Eric Kohl 0edaeba452 [SYSSETUP][INF] Add account settings
- Add EnableAdminAccount and EnableGuestAccount options
- Fix typo: TICKS_PER_SECOND --> TICKS_PER_MINUTE
2021-01-30 09:38:00 +01:00
Victor Perevertkin 5375e33490
[CMAKE] Generate Flex and Bison files at build time
We have Flex and Bison distributed along with RosBE 2.2 so this should
not be a problem
2021-01-28 06:43:05 +03:00
Victor Perevertkin e468da06be
[SETUPAPI] Set the CONFIGFLAG_FAILEDINSTALL flag in SetupDiInstallDevice
The code follows the comment now. The fix may be wrong, but DNF_DISABLED
is a kernel flag and should definitely not be used in a dll.
2021-01-27 05:15:14 +03:00
Victor Perevertkin 0b81691806
[DEVMGR] Remove no longer needed hack CORE-5643
This reverts commit f9739601b3.
2021-01-27 05:15:03 +03:00
Eric Kohl c0caa5c0ae [SYSSETUP][INF] Add lockout setup to the security profile 2021-01-24 21:35:33 +01:00
Eric Kohl 83f3bd8bd6 [SYSSETUP][INF] Add password setup to the security profile 2021-01-24 15:28:23 +01:00
Victor Perevertkin 46ca069e42
[XDK] Remove UNREFERENCE_LOCAL_VARIABLE macro
Change UNREFERENCED_PARAMETER to (VOID)P to support const parameters
2021-01-19 00:15:02 +03:00
Eric Kohl 9011382e28 [SYSSETUP][INF] Add audit events setup 2021-01-17 11:46:34 +01:00
Eric Kohl baf9ff45bb [SYSETUP][INF] Add name support for account privilege setup 2021-01-16 13:18:08 +01:00
Hervé Poussineau 4bb7bd1f50 [FRAMEDYN] Fix an x64 export (probably wrong copy/paste from x86 version) 2021-01-07 21:12:11 +01:00
Mas Ahmad Muhammad 4ca7926093
[TRANSLATION] Fix format for Indonesian translation (#3418)
- USETUP: Fix alignment on translation.
- SHELL32: Update and fix translation.
2021-01-07 18:47:10 +01:00
Joachim Henze 1e9547e0d0 [SHELL32] Improve German (de-DE) translation 2021-01-06 00:41:45 +01:00
Joachim Henze 232c45fcd7 [WIN32SS][COMCTL32] Commit Flip_Fix_9.patch
flip_fix_9.patch fixes:
CORE-16984 " 'SPINA Thrulg' / 'SPINA Thyr' / 'Sim Thyr' have images flipped"
CORE-17194 "StretchDIBits test" isn't work correctly"
           "Output of 'Project 3 Test'"
CORE-14701 "DVDStyler 3.0.4 transparent toolbars"
CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg"
CORE-14671 "'Peazip' shows icons in buttons and menubar vertically flipped"
           "Double Commander shoes icons flipped in buttons, menubar, listview and the treeview"
CORE-13273 "Welcome to Lazarus" icon shows flipped
CORE-13026 "'CudaText app' icon shows flipped"

Not all of those are duplicates, although they appear to be at first glance.
It affects different controls and some of those tickets do have different 'guilty revs' than others.

The patch does consist of 3 parts:

1.) win32ss/gdi/ntgdi/dibobj.c
This one is the most clean part of it, that addresses most of the flipping issues now.

2.) The hack in comctl32.h redefining the version:
We used that in the past to appease some, but not all of the issues listed above.
But it does hide additional issues, e.g. in DvDStyler, therefore we seem to still need that appeasement even today.
Most likely it would make sense to aim to avoid this part in the future.
part 2.) was committed as first appeasement on its own already into
0.4.14-RC-24-g 198b61e
0.4.13-RC-7-g 67211fa
0.4.12-RC-5-g 8449527
0.4.11-RC-16-g b906163
0.4.10-RC-7-g f1e80fe
0.4.9-RC-34-g 9d758ae

3.) toolbar.c change
That part fixes at least the toolbar case for DvDStyler
without relying on the comctl32.h hack any longer,
but it was still not enough to completely get rid of part 2.) yet.

Many thanks to all contributors: 'I_kill_Bugs', Doug Lyons and also 'Julenuri' for testing.

The patch gave nice testbot results:
KVM:  https://reactos.org/testman/compare.php?ids=75704,75714
VBox: https://reactos.org/testman/compare.php?ids=75705,75715

and we also created a summary of manual test-results:
https://jira.reactos.org/browse/CORE-17415?focusedCommentId=126668&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-126668

If you read this comment via git blame and your goal is to get rid of the hack in comctl32.h, I would highly recommend
to redo the tests of that testing table, and if that is asked too much, then please test at least the following cases:
CORE-14701 "DVDStyler 3.0.4 transparent toolbars"
CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg"
           "DVDStyler 3.0.4 erroneously black/transparent within comboboxes of properties of VMGM menu"
and try to add what might be needed to fix them, and double-check again:
           "DoubleCommander optionsDlg the most complex testcase, contains flip-prone icons in treeview, listview, menubar, buttons, statics". Only some of its flipped icons were impacted by the comctl32.h change before.
2021-01-05 20:30:40 +01:00
Jérôme Gardou c8d07514c8 [CMAKE] Fix GCC -fstack-protector usage 2021-01-05 13:38:57 +01:00
winesync 208ef143d3 [WINESYNC] wininet: Replacing header fields should fail if they do not exist yet.
A lot of details are not properly covered by tests yet and were
marked with FIXME comments. The implementation was written in such
a way that it behaves identical to the old code in such situations.

wine-staging patch by Michael Müller <michael@fds-team.de>
2021-01-05 11:03:13 +01:00
winesync aa27aac08b [WINESYNC] wininet: Strip filename if no path is set in cookie.
The order of the stored cookies doesn't match in /testC, so
be a bit less strict in the test.

wine-staging patch by Michael Müller <michael@fds-team.de>
2021-01-05 11:03:13 +01:00
winesync e152f78aa3 [WINESYNC] wininet: Use wide-char string literals.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id e88abf0dc4ae7ec6b2fd21130be09dadc478b9fc by Michael Stefaniuc <mstefani@winehq.org>
2021-01-05 11:03:13 +01:00
winesync cde08ff2b7 [WINESYNC] wininet: Use wide-char string literals in struct initialization.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 085f3738a86e6fa0e12b3f59fa4a9ca86826bb60 by Michael Stefaniuc <mstefani@winehq.org>
2021-01-05 11:03:13 +01:00
winesync 23e96deb0b [WINESYNC] wininet: Correctly return error status from InternetSetFilePointer() stub.
Fixes Freestyle 2: Street Basketball update check failure.

Signed-off-by: Paul Gofman <pgofman@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 67295a7844b94ccbfce85dbee22a76f12c9f5b36 by Paul Gofman <pgofman@codeweavers.com>
2021-01-05 11:03:13 +01:00
winesync ef9a828ef8 [WINESYNC] wininet: Prevent use after free in logging.
Make logs which show values that are unmapped by cache_container_unlock_index()
go before it's called.

Signed-off-by: Jan Sikorski <jsikorski@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id bcdb58cc7959afd5fa35ab039e6564934888b4c0 by Jan Sikorski <jsikorski@codeweavers.com>
2021-01-05 11:03:13 +01:00
winesync 8bf2b3cf2c [WINESYNC] wininet: Implement INTERNET_OPTION_SECURITY_CERTIFICATE flag for InternetQueryOption.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ef88a70fa775f3e7a26d8f1618f32ee94bb9ea05 by Daniel Lehman <dlehman25@gmail.com>
2021-01-05 11:03:13 +01:00
winesync c1394ae71a [WINESYNC] wininet: Move INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT handling to helper.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a41cb33afaee0adc6fdf3b8c69b9fb545dc15a96 by Daniel Lehman <dlehman25@gmail.com>
2021-01-05 11:03:13 +01:00
winesync 94e13ca59b [WINESYNC] wininet: Handle empty expires for cookie setting.
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id c06e00ee6a15fd77faf66b28edac5e84ad30b550 by Jactry Zeng <jzeng@codeweavers.com>
2021-01-05 11:03:13 +01:00
winesync 9982fa3c75 [WINESYNC] wininet: Get rid of user buffer in create_cookie_url().
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id d2a1c906dc4979eeabe256f77a58d67290da372d by Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
2021-01-05 11:03:13 +01:00
winesync 94937754ed [WINESYNC] wininet: Use stricmp() instead of _strnicmp(..., -1).
Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id de5d147de8b3d9c2f65bcb6d5646320ef1d92e58 by Paul Gofman <gofmanp@gmail.com>
2021-01-05 11:03:13 +01:00
winesync 9b564981ba [WINESYNC] wininet: Use _ltow instead of sprintf for port number in InternetCreateUrl.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 9fe900532eb310d114c04d15a8d0b986ec831552 by Jacek Caban <jacek@codeweavers.com>
2021-01-05 11:03:13 +01:00
winesync 82be999d2f [WINESYNC] wininet: Add stub for INTERNET_OPTION_IGNORE_OFFLINE.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48739
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 6fcd1378b2516165468bcbd71263c1b18c6be491 by Roman Pišl <rpisl@seznam.cz>
2021-01-05 11:03:13 +01:00
winesync 1fb556935e [WINESYNC] wininet: Don't set default gopher protocol in InternetCrackUrlW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 4335be346271072f440419b9234883aef187d857 by Jacek Caban <jacek@codeweavers.com>
2021-01-05 11:03:13 +01:00
winesync 9eddd0f193 [WINESYNC] wininet: Add missing schemes to url_schemes.
Fixes res URL scheme handling.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=31399
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 64cb9425da43271109bc1df8df4aa32132f257ae by Jacek Caban <jacek@codeweavers.com>
2021-01-05 11:03:13 +01:00
winesync 1e7b402584 [WINESYNC] wininet: Fix the spelling of a comment.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 84069679a407cf0b5b8d185b5d98e9afdb933c45 by Francois Gouget <fgouget@free.fr>
2021-01-05 11:03:13 +01:00
winesync 0a44ccfa80 [WINESYNC] wininet: Handle http_proxy variable entirely in Unicode.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id cadad89d106186a9d0377607096a58677496ec50 by Alexandre Julliard <julliard@winehq.org>
2021-01-05 11:03:13 +01:00
winesync 5f12c8d726 [WINESYNC] wininet: Build with msvcrt.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 3c31cc5836026b45a40818ec874bbbcc4d6ad982 by Alexandre Julliard <julliard@winehq.org>
2021-01-05 11:03:13 +01:00
winesync 4eead52783 [WINESYNC] wininet: Import zlib inflate code.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id cee281a036cf5e9017d5a25e0cbe75c2bcd2c146 by Alexandre Julliard <julliard@winehq.org>
2021-01-05 11:03:13 +01:00
winesync 33fde115eb [WINESYNC] wininet: Add support for detecting the proxy config URL.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a4357043ff9aa14f086207c239f0fc29c0a24b83 by Hans Leidekker <hans@codeweavers.com>
2021-01-05 11:03:13 +01:00
Jérôme Gardou 4a3f32ff30 [WINESYNC]: revert wine-staging patchset for wininet 2021-01-05 11:03:13 +01:00
Piotr Hetnarowicz eb5972010a
[SHELL32] Improve Polish (pl-PL) translation (#3410) 2021-01-03 18:24:18 +03:00
Piotr Hetnarowicz df7b892d97
[COMDLG32] Improve Polish (pl-PL) translation (#3411) 2021-01-03 15:54:10 +03:00
Eric Kohl 54d6fab0e1 [SAMSRV] Add 'Print Operators', 'Performance Monitor Users' and 'Performance Log Users' aliases to servers 2021-01-03 06:17:48 +01:00
Eric Kohl 16532170de [SYSSETUP][INF] Add event log settings to the default security settings and apply them on setup 2021-01-02 21:18:18 +01:00
Eric Kohl 8de143e058 [SYSSETUP] Rename defltws.inf to defltwk.inf 2021-01-01 11:14:28 +01:00
Eric Kohl f1e768c070 [SAMSRV][INF] Add missing aliases and privileges
- Add the 'Backup Operators', 'Replicator', 'RemoteDesktop Users' and 'Network Configuration Operators' aliases.
- Add missing privileges for the aliases.

Happy new year 2021! :-)
2021-01-01 10:24:36 +01:00
Hermès Bélusca-Maïto b570fac18b
Happy New Year 2021 to the ReactOS Community!!
⚛️ 🍾 🥳 🎆 ☢️
2021-01-01 00:00:00 +01:00
Tibor Lajos Füzi 82f0061ddc
[TRANSLATION] Hungarian (hu-HU) translation update (#3388)
For mspaint, notepad, wordpad, cmd, cmdutils/help, appwiz, devmgr, newdev

Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-12-31 01:42:34 +03:00
Václav Zouzalík d40f29601d
[SHIMGVW] Update Czech (cs-CZ) translation (#3409)
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-12-31 00:06:48 +03:00
Jérôme Gardou 8a6d653044 [CRT] Fix _onexit
Avoid calling malloc in CR initialisation code.
Have executables call msvcrt implementation, while the DLLs keep their own function tables

CORE-17362
2020-12-30 19:03:52 +01:00
Jérôme Gardou b96e88894a [CMAKE] Turn import libs into regular C static libs
Embed msvcrtex into libmsvcrt

Idea taken from Thomas Faber
2020-12-28 12:13:30 +01:00
Eric Kohl 65646a75a2 [DEVMGR] Report property changes by the device manager to the installer 2020-12-25 19:14:09 +01:00
Serge Gautherie bb01b94f83
[SHELL32] spec: Fix SHGetAttributesFromDataObject() parameter types (#3317)
Addendum to cdb48b8. CORE-17337
2020-12-23 15:20:37 +03:00
Jérôme Gardou fab4e82647 [INCLUDE/IDL] Give implicit handles a more unique name
This avoids duplicated symbols when linking DLLs using more than one client or server stub
2020-12-22 13:14:13 +01:00
Jérôme Gardou 762f3b9d2a [CMAKE] Add missing dependencies on PSDK 2020-12-22 13:14:00 +01:00
Oleg Dubinskiy d5132f5ce3
[BROWSEUI][PSDK] Stubplement ShellTaskScheduler (#3326)
Required by MS Picture and Fax Viewer (shimgvw.dll).
Now it starts properly without replacing any other system files.

CORE-17337
2020-12-20 22:06:16 +03:00
Oleg Dubinskiy 1f5e0f3fa7
[BROWSEUI][PSDK] Stubplement UserAssist
Initial implementation of `CUserAssist` class, which contains `IUserAssist` interface.
See https://www.geoffchappell.com/studies/windows/ie/browseui/classes/userassist.htm.
Required by MS shell32.dll.

CORE-17345 CORE-17393
2020-12-20 17:32:11 +03:00
Eric Kohl afbff37d98 [STORPROP] Add missing property provider stubs 2020-12-12 16:42:15 +01:00
Eric Kohl d9e20ae3fe Implement the StorageCoInstaller and configure it for CD-ROM and Disk devices
This sets the friendly name for CD-ROM and Disk devices.
2020-12-07 23:17:29 +01:00
Victor Perevertkin aa05649902
[SETUPAPI] Do not use strlen on buffers which may possibly contain REG_MULTI_SZ
CORE-14187
2020-12-06 19:49:57 +03:00
Riley Bell 3014417919 [SHELL32] Hide "This version of ReactOS is registered to:" text on condition (#3325)
When the system is not installed yet (e.g. LiveCD or 2nd installation stage)
there is no registered user and organization, so no need to show this text
label in the shell about dialog.

Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-11-30 03:12:32 +03:00
Oleg Dubinskiy 6bf7f83b2a
[MSGINA] Improve exports for all stubbed functions (#3256)
Since they are completely undocumented and unlikely will be implemented in ROS,
stubbing them only in spec file seems to be a better solution than adding wrong
prototypes.

Use `stdcall -stub` instead of `stub` and enable parameters of the functions.
This allows to properly load our msgina.dll in Windows XP/2003.

Although it still doesn't boot to desktop with dll replaced, but nevertheless
the system crash that was caused by stubbed functions does no longer happen.
2020-11-28 17:32:53 +03:00
Oleg Dubinskiy c0d2cd508f
[MSGINA] Implement ShellTurnOffDialog (#3254)
Based on the following prototype: http://diendan.congdongcviet.com/threads/t13622::tim-handle-cua-cua-so-tat-may-tren-windows-nhu-the-nao.cpp?p=69284#post69284 (line 32) and return ShellShutdownDialog from it with all required parameters.
It allows to open the shutdown dialog properly from the Start menu with shell32.dll from Windows Server 2003 SP2 (when installing ReactOS as Workstation).

CORE-17313
2020-11-28 17:22:46 +03:00
Hermès Bélusca-Maïto 8d3e80e437
[FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions.
[AUTOCHK] Add also support for scanning FATX volumes.

The Format(), FormatEx(), Chkdsk(), ChkdskEx() functions exposed by the
U*.DLL user-mode FS library dlls are different (and have different
prototypes) than the similarly-named functions exported by FMIFS.DLL .

In particular, what we used to call "xxxChkdskEx()" and "xxxFormatEx()"
in our U*.DLL libraries actually correspond more, from their arguments,
to the "Chkdsk()" and "Format()" functions in Windows' U*.DLL . Their
*Ex() counterparts instead take most of the parameters through a
structure passed by pointer.

On FMIFS.DLL side, while FMIFS!Chkdsk() calls U*.DLL!Chkdsk() and
FMIFS!ChkdskEx() calls U*.DLL!ChkdskEx() (and we do not implement these
*Ex() functions at the moment), both FMIFS!Format() and FMIFS!FormatEx()
call U*.DLL!Format() instead, while FMIFS!FormatEx2() calls
U*.DLL!FormatEx() (that we do not implement yet either) !!

To improve that, refactor the calls to these U*.DLL functions so as to
respect the more compatible prototypes: They contain the correct number
of parameters in a compatible order. However, some of the parameters do
not have the same types yet: the strings are kept here in PUNICODE_STRINGS,
while on Windows they are passed via an undocumented DSTRING struct, and
the FMIFS callback is instead a MESSAGE struct/class on Windows.
Finally, the MEDIA_TYPE parameter in U*.DLL!Format() is equivalent, yet
not fully 100% in 1-to-1 correspondence, with the FMIFS_MEDIA_FLAG used
in the corresponding FMIFS.DLL functions.

One thing to notice is that the U*.DLL!Format() (and the Ex) functions
support a BOOLEAN (a flag resp.) for telling that a backwards-compatible
FS version should be used instead of the (default) latest FS version.
This is used e.g. by the FAT FS, where by default FAT32 is selected
(depending also on other constraints like, the disk and the partition
sizes), unless that bit is set in which case, FAT16 (or 12) is used.
2020-11-22 21:57:07 +01:00
Tibor Lajos Füzi 07cc0b5a2b
[TRANSLATION] Hungarian translation update for credui, devmgr, netid, sysdm (#3285) 2020-11-21 18:07:48 +01:00
Aobi Chan CL fc3ccb3948
[TRANSLATION] Improve zh-TW translation (#3218)
- Added zh-TW translation for the following modules: credui, crypt32, getuname, mapi32, themeui, shlwapi.
- Modify zh-TW translation for other files.
- Moving Traditional Chinese translation back to Zh.rc for files came from Wine (comdlg32).

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-11-21 18:03:37 +01:00
Jérôme Gardou 2c4c25e468 [MSVCRT] make some functions static 2020-11-16 16:58:10 +01:00
Serge Gautherie b59bad8d10
[SAMSRV] SamIFree_SAMPR_USER_INFO_BUFFER: Add missing breaks. CORE-17355
Addendum to fda13e (r58742).
2020-11-14 15:23:41 +01:00
Serge Gautherie 3c4d6b0f9e
[SAMSRV] SamrQueryInformationUser: Add missing break. CORE-17355
Addendum to 2f6a92c (r56820).
2020-11-14 15:22:05 +01:00
Timo Kreuzer 8df1bd612a [KERNEL32] Fix register initialization in BaseInitializeContext
Get rid of BaseThreadStartupThunk and BaseProcessStartThunk asm wrappers and go to the C functions directly (home space is allocated on the stack by the kernel)
2020-11-07 18:33:02 +01:00
Timo Kreuzer 2c2c570317 [PSAPI] Fix and simplify FindDeviceDriver
The previous version was miscalculating the buffer size on x64 (due to alignment) and always using a too small buffer.
The new version removes the size calculation entirely and uses the required size returned by NtQuerySystemInformation.
2020-11-07 17:39:42 +01:00
Jose Carlos Jesus 47a350c4db
[SHELL32][SHELLEXT] Portuguese (PT) translation improvements and object adjustements (#3186)
- SHELL32: Improve Portuguese (PT) translation.
Minor objects adjustments to the text
and minor improvements to translation.

- SHELLEXT: Improve Portuguese (PT) translation to acppage rc file.
2020-11-07 17:30:36 +01:00
Hermès Bélusca-Maïto d829bcc629
[WINDOWSCODECS] It turns out that /wd4133 is not enough to demote the error; we need to use remove_target_compile_option() to completely remove the /we4133 flag.
Addendum to commits 7e116f0e and 00ed72d7.

This removes the "error C4133: 'function': incompatible types - from
'WICPixelFormatNumericRepresentation *' to 'DWORD *'"
message that still remains even when using /wd4133 .
2020-11-06 01:06:13 +01:00
Hermès Bélusca-Maïto 3c722e35b1
[CMD][SERVMAN][SHELL32][WINSPOOL][ROSAPPS][NTOS:PNP] Fix my build. 2020-11-06 01:06:11 +01:00
Victor Perevertkin da4ee18cc9
[STORPROP][CDROM_NEW][DISK_NEW] Improve disk and cdrom device installation
- Take a proper inf file for disk.sys
- Add class information into cdrom.inf
- Make a correct stub for storprop!DvdClassInstaller
2020-11-03 23:12:40 +03:00
Carlo Bramini 4ffd9fb3a0
[DBGHELP] Add missing support for AMD64. (#3083)
See:
https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-context
2020-10-25 12:30:37 +01:00
Oleg Dubinskiy cdb48b8219
[SHELL32] Stub SHGetShellStyleHInstance and SHGetAttributesFromDataObject CORE-17337 (#3295)
They are required by MS Picture and Fax Viewer (shimgvw.dll), together with MS browseui.dll.
CORE-17337
2020-10-24 18:04:54 +03:00
Oleg Dubinskiy d0a7df49fa
[BROWSEUI] CCommonBrowser class should support aggregation (#3308)
It will remove the following error from the log when use MS shell32.dll in ReactOS:
`fixme:(dll/win32/ole32/compobj.c:3454) Class {af604efe-8897-11d1-b944-00a0c90312e1} does not support aggregation`.
References:
https://www.geoffchappell.com/studies/windows/ie/browseui/classes/ccommonbrowser.htm
https://docs.microsoft.com/en-us/cpp/atl/reference/aggregation-and-class-factory-macros?view=vs-2019
CORE-17345
2020-10-24 18:02:18 +03:00
Piotr Hetnarowicz 16d8190f51 [SHELL32] PL-pl Dialogs fix v2
shell32.dll PL-pl
-FIXED: invisible icon,text & description
2020-10-24 10:20:59 +02:00
Serge Gautherie be08d69bc3 [MLANG] Fix scripts values in fnIMLangFontLink2_GetScriptFontInfo()
MSVC:
'...\mlang.c(3568): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)'

Import
2dc0758b5d
2020-10-24 10:17:05 +02:00
Jérôme Gardou 23e04ae1ee [CMAKE] Use an INTERFACE library to perform the msvcrt <-> msvcrtex binding 2020-10-22 18:07:27 +02:00
Jérôme Gardou c321d3e88b [CRTDLL] Make this a stand-alone CRT DLL
Because CRTs must be isolated from each other.
This basically reverts commit f0c91ae
2020-10-22 18:07:27 +02:00
Victor Perevertkin 953c03c336
[DEVMGR] Avoid buffer overflow when device reg key size is > 100 chars 2020-10-22 14:38:55 +03:00
Katayama Hirofumi MZ de8d156e2c
[SHELL32] Resizable for SHBrowseForFolder (#3299)
Make the dialog box of SHBrowseForFolder function resizable. CORE-17341
2020-10-21 22:25:16 +09:00
Jérôme Gardou c004b53d77 Apply suggestions from code review
Style fixes

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Victor Perevertkin <victor@perevertkin.ru>
2020-10-20 21:44:54 +02:00
Jérôme Gardou 00ed72d7e8 [CMAKE] Get rid of add_compile_flags
Use add_compile_options and the like instead
2020-10-20 21:44:54 +02:00
Jérôme Gardou ed61512236 [CMAKE] Get rid of add_compile_flags_language macro
in favor of add_compile_options and the like with generator expressions
Also take this as an opportunity to remove the C++11 standard hack, GCC 8 now defaults to C++14
2020-10-20 21:44:54 +02:00
Jérôme Gardou 7e116f0ef3 [CMAKE] Get rid of replace_compile_flags
Introduce a finer-grained remove_target_compile_option instead
2020-10-20 21:44:54 +02:00
Jérôme Gardou 907025a018 [CMAKE] Introduce the atl_classes interface library
This takes care of adding the relvant include directory and the _ATL_NO_EXCEPTIONS define, if needed
2020-10-20 21:44:54 +02:00
Jérôme Gardou d6ea8659c8 [CMAKE] Get rid of the set_cpp macro
Instead of messing with global variables and the like, we introduce two target properties:
 - WITH_CXX_EXCEPTIONS: if you want to use C++ exceptions
 - WITH_CXX_RTTI: if you need RTTI in your module
You can use the newly introduced set_target_cpp_properties function, with WITH_EXCEPTIONS and WITH_RTTI arguments
We also introduce two libraries :
 - cpprt: for C++ runtime routines
 - cppstl: for the C++ standard template library

NB: On GCC, this requires to create imported libraries with the related built-in libraries:libsupc++, limingwex, libstdc++

Finally, we manage the relevant flags with the ad-hoc generator expressions

So, if you don't need exceptions, nor RTTI, nor use any runtime at all: you simply have nothing else to do than add your C++ file to your module
2020-10-20 21:44:54 +02:00
Katayama Hirofumi MZ 24833a6dde
[BROWSEUI] Implement CLSID_ACListISF (#3298)
Implement enumeration of IShellFolder items of auto-completion. CORE-9281
2020-10-17 17:49:24 +09:00
Serge Gautherie ad4c174eb6
[SYSSETUP] fr-FR: Change keyboard accelerator for Owner Organization field (#3282)
'S' is already used for Next ('Suivant') button.
2020-10-08 22:41:33 +02:00
Katayama Hirofumi MZ 957d07436b
[BROWSEUI] Remove '\1' from AutoComplete list (#3264)
Delete "backslash one" (indicates SW_ values) from auto-completion list. CORE-9281
2020-10-06 17:44:20 +09:00
Hirofumi Katayama 14c18657bc [BROWSEUI] Fix assertion in CACLCustomMRU::AddMRUString
CORE-9281
2020-10-05 08:49:42 +09:00
Hirofumi Katayama 179da0b237 [SHLWAPI] Fix parameter ordering at call of AutoComplete_AdaptFlags
CORE-9281
2020-10-05 08:47:21 +09:00
Mark Jansen bac45efe5d [SHELL32][BROWSEUI] Fix usage of ILGetDisplayNameEx 2020-10-04 19:34:20 +02:00
Mark Jansen b3f2ba0522 [BROWSEUI] Show virtual folders in the log for SHOpenFolderWindow 2020-10-04 19:34:20 +02:00
Mark Jansen ca087b6a18 [BROWSEUI] Update the current directory before creating a view
This way, when the view asks for a directory _during creation_ it
does not get either an old, or an invalid directory
CORE-17270
2020-10-04 19:34:20 +02:00
Mark Jansen 7b17d8d900 [BROWSEUI] Remove refactoring leftovers 2020-10-04 19:34:20 +02:00
Joachim Henze 5bb36e92c5 [WDMAUD.DRV] Revert "Workaround multiple issues with AC97 driver from rapps"
This reverts commit 0.4.15-dev-791-g
6d7ebc2048

It was a workaround just. To bypass sysaudio. It had a very positive effect on
our playback performance, but using the different codepaths did also lead to
regressions, that I have no idea how to address, therefore I think it's my
personal responsibility to revert it. I guess it's better to improve on the
code-paths that we intend to use finally, instead of fixing what will
be dead paths in the future.

The revert will fix:
- CORE-17277 crash of dsound:duplex on "GCCLin_x86 on Test VBox"
- CORE-17278 crash of dsound:capture on "GCCLin_x86 on Test VBox"
- CORE-17285 Realtek HD Audio does no longer work in ReactOS

But ofc now we will suffer again from very severe things that the hack could workaround:
- CORE-13202 Unhandled exception from wdmaud.drv when recording sound in Scratch 1.4 leads to app-crash
- CORE-13488 A deadlock in "DiabloII" character selection screen and "The Lion King II"
- CORE-8726/CORE-9986/CORE-16564 AC97 driver from rapps will need reboot-orgies again, does not longer
  work in the same session that we installed the driver
- CORE-9981 "DosBox + Commander Keen6" totally garbled sound output instead of music
    "ScummVM 2.0 with Monkey Island 2" totally garbled sound output instead of music
- the test execution times of "GCCLin_x86 on Test VBox" will almost double
2020-10-03 16:39:13 +02:00
Joachim Henze c947eb4d17 [COMCTL32] Button.c Fix CORE-17260
Press'n'Hold of a button, then leaving the button rect
should redraw the button in unpressed state

Thanks to JIRA user 'I_kill_Bugs' for perfecting
my initial experiments to fix that.

It regressed by 0.4.9-dev-719-g
b3fb8555bf

No need to sync anything with Wine, their code is
correct on Wine head. The bug was in ros specific diff.
2020-10-03 15:38:02 +02:00
Katayama Hirofumi MZ bb8cb671b8
[BROWSEUI] Accept TypedURLs to CLSID_ACLCustomMRU (#3250)
Related to #3249. IACLCustomMRU has a special case of TypedURLs. The TypedURLs key consists of the registry values of "url1", "url2", "url3" etc instead of "MRUList", "a", "b" etc. CORE-9281
2020-10-02 21:27:23 +09:00
Katayama Hirofumi MZ 0733d96d9d [COMCTL32] Fix wrong behavior about Tab key
Pressing Tab key should focus next dialog item.
Fix 0a8fb87 and 3f30b1e.
CORE-3479
2020-10-01 22:53:59 +09:00
Joachim Henze d2bbf54b6f [MSGINA] Allow to pair FriendlyShutDownDlg with 'Server' CORE-17282
A ros specific addition that does not exist on Windows.

Default for Server is still the classic shutdown dlg,
no change on that.

But interested users can manually now create the registry setting
"EnforceFriendlyShutdown" REG_DWORD to "1"
within "SYSTEM\\CurrentControlSet\\Control\\Windows"
to allow overriding the Windows default behavior
without relying on changing the product version number, because
that would not be side-effect-free.

Addendum to 0.4.15-dev-650-g
2edcb58e65
2020-09-30 13:08:58 +02:00
Katayama Hirofumi MZ e1a01de7f7
[BROWSEUI] Fix Edit_BackWord function (#3247)
Fix and improve Edit_BackWord function (for Ctrl+Back key combination on auto-completion in edit boxes) by using GetStringTypeW. CORE-1419
2020-09-28 22:05:14 +09:00
Katayama Hirofumi MZ a822eadce6 [SHELL32] CoUninitialize only if CoInitialize* is successful
Technically CoUninitialize should be called only if CoInitializeEx succeeded (including S_FALSE).
CORE-1419
2020-09-28 20:13:28 +09:00
Katayama Hirofumi MZ 467feb9996 [BROWSEUI] Follow-up part 3 of #3242 (6b6f971)
Also recognize slash, dot, colon, and semicolon.
CORE-1419
2020-09-28 10:58:22 +09:00
Katayama Hirofumi MZ 737278276f [BROWSEUI] Follow-up part 2 of #3242 (6b6f971)
Don't recognize backslash of the last character.
CORE-1419
2020-09-28 10:41:21 +09:00
Katayama Hirofumi MZ 9812bce271 [BROWSEUI] Follow-up of #3242 (6b6f971)
Recognize backslashes in Ctrl+Back.
CORE-1419
2020-09-28 10:14:36 +09:00
Katayama Hirofumi MZ 6b6f971939
[BROWSEUI][SHELL32] Enable Ctrl+Backspace in AutoComplete edit boxes (#3242)
The key combination Ctrl+Back is well working in auto-completion edit boxes. CORE-1419
2020-09-28 09:27:01 +09:00
Timo Kreuzer 68cb54dc58 [SHELL32] Fix usage of return value 2020-09-27 19:58:21 +02:00
Katayama Hirofumi MZ fe41acdc11 [SHLWAPI] Follow-up of #3230 (f496a5f)
CORE-9281
2020-09-27 15:47:10 +09:00
Katayama Hirofumi MZ f496a5fc4f
[SHLWAPI] 1/3-implement SHAutoComplete (#3230)
Retrial of #3214. Try to implment shlwapi!SHAutoComplete function. Unfinished. CORE-9281
2020-09-27 15:27:18 +09:00
Adam Słaboń 50ff453434
[TRANSLATION] Polish translation update (#3233) 2020-09-26 21:42:36 +03:00
Katayama Hirofumi MZ c8e1460ac5
[COMDLG32] Support shortcut keys on Open/Save Dialog (#3238)
Enable key accelerators on File Open/Save Dialog. CORE-14332
2020-09-26 21:26:06 +09:00
Timo Kreuzer d8b5c00c33 [KERNEL32_VISTA] Move vista.c from kernel32 to kernel32_vista
- Remove duplicated functions
- Use AreFileApisANSI() instead of global variable bIsFileApiAnsi in shared kernel32_shared
2020-09-25 09:45:54 +02:00
Timo Kreuzer fcd83242d4 [KERNEL32] Move some functions into a static library to be shared between kernel32 and kernel32_vista 2020-09-25 09:45:54 +02:00
Timo Kreuzer 4e72da0858 [KERNEL32_VISTA] Move under kernel32 2020-09-25 09:45:54 +02:00
Katayama Hirofumi MZ ed02f41af5 [SHELL32] Call SHAutoComplete on 'Run' dialog
CORE-9281
2020-09-25 15:59:30 +09:00
Katayama Hirofumi MZ 0a8fb87d84 [COMCTL32] IP Address controls follow-up of #3212 (3f30b1e)
The rightest field didn't work Left arrow key.

CORE-3479
2020-09-25 15:32:58 +09:00
Kyle Katarn b9754fa5d6
[SETUP][MMSYS][SHELL32] Adding missing French translation (and update existing ones) (#3232)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-09-25 01:39:31 +02:00
Katayama Hirofumi MZ 3f30b1eda7
[COMCTL32] Improve IP Address Controls (Tab and caret) (#3212)
Improve IP address controls.
- Set focus to EDIT control to show caret.
- Process WM_GETDLGCODE messages on EDIT control to catch Tab key.
- Process Tab key and Shift+Tab key in processing WM_KEYDOWN.
CORE-3479
2020-09-23 08:32:40 +09:00
Doug Lyons 90be2f4e1b
[IPHLPAPI] Fix for hasArp which crashes some iphlpapi tests. (#3216)
CORE-16513
2020-09-22 15:50:41 +02:00
Serge Gautherie 889b077b23
[REACTOS] *.spec: Fix some function/parameter types (#3154) 2020-09-20 19:21:11 +02:00
Kyle Katarn da36f799c7
[SHELL32] Minimal SHRunControlPanel implementation (#3095)
CORE-9215
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-09-19 16:23:44 +02:00
Katayama Hirofumi MZ ab115e30fe
[IMM32][INCLUDE] Add immtable.h and modify imm32.spec (#3207)
- Add immtable.h header into win32ss/user/user32/misc/.
- Modify imm32.spec file.
CORE-11700
2020-09-19 22:47:40 +09:00
Kyle Katarn a5a30fc249
[SHELL32][SHELLEXT] Fix use of SHFileOperation results and improve log on failure / fix log spam (#3198) 2020-09-18 21:19:55 +02:00
Katayama Hirofumi MZ 378b26ce27
[KERNEL32] Improve SetComputerNameExW (#3171)
Reduce failures of kernel32_apitest SetComputerNameExW testcase and improve SetComputerNameExW.
2020-09-17 23:51:47 +09:00
Katayama Hirofumi MZ 8c87489a43
[COMCTL32][SHELL32] Fix arrow keys and reordering on ListView (#3162)
- Disable special auto-arrange codes in LISTVIEW_GetNextItem function.
- Add auto-arrange reordering codes on CDefView.
CORE-16875
2020-09-17 22:18:34 +09:00
winesync c15a8e78b0 [WINESYNC] dbghelp: Always check for debug symbols in BINDIR.
wine-staging patch by Sebastian Lackner <sebastian@fds-team.de>
2020-09-16 10:36:02 +02:00
winesync 767cb4cff4 [WINESYNC] dbghelp: Add xmm and mxcsr register mapping functions for i386.
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 7e965d60b542c0baa6f79605f45669a2ea9bceb8 by Vijay Kiran Kamuju <infyquest@gmail.com>
2020-09-16 10:36:02 +02:00
winesync 97b990849f [WINESYNC] dbghelp: Replace another usage of GetEnvironmentVariable() with the target process's environment.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 70b2d181b1547dbe3c2a62e57c6afb0ee903f358 by Zebediah Figura <z.figura12@gmail.com>
2020-09-16 10:36:02 +02:00
winesync ee8def7d76 [WINESYNC] dbghelp: Ignore missing debug info in SymInitializeW.
When fInvadeProcess is used, we return an error if the target process
is found but its debug info is not. We should only return an error if
the process is not found.

This fixes a SymInitializeW popup error on Hard Reset Redux startup.

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 774ee4734a7d6c02f648fdf1747df837c964583d by Rémi Bernon <rbernon@codeweavers.com>
2020-09-16 10:36:01 +02:00
winesync c8c8313c67 [WINESYNC] dbghelp: Remove support for PPC32.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 30f17befaf216a42a4e2cfbca3ed7bdce43e476a by André Hentschel <nerv@dawncrow.de>
2020-09-16 10:36:01 +02:00
winesync 5637f59e51 [WINESYNC] dbghelp: Use debuggee environment in search_unix_path.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 7b6f6257bc7e9d8f8a93dfa969510ab4aa16e765 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:36:00 +02:00
winesync 76ecb16c96 [WINESYNC] dbghelp: Fix the spelling of a comment.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ab4665f4ae3c67317e21d42868cae0af72ffcb7a by Francois Gouget <fgouget@free.fr>
2020-09-16 10:36:00 +02:00
winesync be0572902a [WINESYNC] dbghelp: Use debuggee environment variables in search_dll_path.
This fixes searching wow32 binaries, where debuggee search path is
different than debugger's.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 2b0977fc711e1faadfef69e3a46c2d1848b4826b by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:36:00 +02:00
winesync 37eff17d4d [WINESYNC] dbghelp: Use stricmp() instead of _strnicmp(..., -1).
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 341feeb10eddd3d139c4c206a43db80d0671ff3b by Alexandre Julliard <julliard@winehq.org>
2020-09-16 10:35:59 +02:00
winesync 4cc24ef20e [WINESYNC] dbghelp: Make qsort callback explicitly cdecl.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 0163db5152124efbd1a5ba46aa52a6da66d897d5 by Alexandre Julliard <julliard@winehq.org>
2020-09-16 10:35:59 +02:00
winesync 4710112bb7 [WINESYNC] dbghelp: Get rid of no longer needed #ifdefs.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id e014d325ddb87dbb4678ef47ef17f9e7f49b0248 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:58 +02:00
winesync 63c0d5e35a [WINESYNC] dbghelp: Get rid of no longer needed HAVE_ZLIB checks.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 6b1bc0beac510aa48a848b8182b9310f92609dd0 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:58 +02:00
winesync 0fd6a91bf1 [WINESYNC] dbghelp: Don't use PATH to search for libraries.
It should be used only for the main executable, for which we get full
path anyway.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 5bc58410f28aefea3c3f41e056a372aff4dceac7 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:58 +02:00
winesync 9a9f849895 [WINESYNC] dbghelp: Remove unneeded includes.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ceae3f0207fb8f174d0a762ef7fe4f405316541f by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:57 +02:00
winesync 237aa3a9c1 [WINESYNC] dbghelp: Import zlib inflate code.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id d483eb21cff1f2b44f048195106d87a414dd66b8 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:57 +02:00
winesync b991284341 [WINESYNC] dbghelp: Always build all loader backends.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 131fb79535c74e8011ac82c279f6f4a9d971e1af by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:57 +02:00
winesync 833e54f874 [WINESYNC] dbghelp: Fix GCC warnings in macho_module.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 9896f1ce33561771989d3117c1536fb472df8558 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:57 +02:00
winesync 27e660114b [WINESYNC] dbghelp: Introduce read_process_memory helper.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 26f5bfdd4d071a91a38b25c0064ed5ea48993249 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:56 +02:00
winesync 4959c2568a [WINESYNC] dbghelp: Ignore N_INDR symbols.
These are aliases for another symbol. They are often seen on Mac OS when
a dylib reexports some symbols defined in another dylib.

Signed-off-by: Chip Davis <cdavis@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 53b5c3b6c674f4bd6d02f20986598b5b6580a2d8 by Chip Davis <cdavis@codeweavers.com>
2020-09-16 10:35:56 +02:00
winesync 9a390991b8 [WINESYNC] dbghelp: Use mount manager to lookup dsym by uuid.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 88edff846714422c9f875fe6c9e509ee34072d27 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:56 +02:00
winesync 329ea60f7c [WINESYNC] dbghelp: Factor out query_dsym.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id c3c2cda9d2792f8c9c612b5bd6e9fd4d08cbb073 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:56 +02:00
winesync e2e7cce46f [WINESYNC] dbghelp: Don't bother trying to initialize loader backend if we can't get debug base address from PEB.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 3047385437c7ef36996d0418ac378677f3e9d67c by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:56 +02:00
winesync 13d60fef36 [WINESYNC] dbghelp: Get rid of get_dyld_image_info_address.
We should get the address from PEB anyway.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id f2b8af7e7e159a5259aaab42169c4f8220b121eb by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:55 +02:00
winesync 7a5f84b3a8 [WINESYNC] dbghelp: Don't use _NSGetExecutablePath in macho_search_loader.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id dab78486d3d0063e32e99fb795311b74eb632d3a by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:55 +02:00
winesync ad13638bd6 [WINESYNC] dbghelp: Use local constants definitions instead of mach-o/loader.h.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id e341bd7fe4f2572597ee10cbed5bb2a76ddcc03a by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:55 +02:00
winesync 1358cd2d9b [WINESYNC] dbghelp: Don't use stdint.h types.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 1420e64e5f1df4c8bbb016d1b8ff71337cda4884 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:55 +02:00
winesync 95450374ac [WINESYNC] dbghelp.c: Use local mach header declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 0c56a8f87bac01488349af0ffe3923a1672e72a0 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:55 +02:00
winesync 92dc946e86 [WINESYNC] dbghelp: Use local symtab and segment commands declarations.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 7b2e53f5b550e8a4d844c5e74941b02d1c770b0b by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:54 +02:00
winesync 63f681c1e6 [WINESYNC] dbghelp: Use local fat header declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 8230889f1f2e545222f3a51ba9b47fa02196eb98 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:54 +02:00
winesync eff9360f47 [WINESYNC] dbghelp: Use local macho section declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 64341284c58bcc22f13f8146bcb6c8a08c0c4ff2 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:54 +02:00
winesync 739259ac2f [WINESYNC] dbghelp: Use local macho load command declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id c695e7e99e0a06b6039d46f98fea35c363aa6cbe by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:54 +02:00
winesync 00783527e0 [WINESYNC] dbghelp: Don't store entire mach header in image_file_map.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 7254579417f337063734933975b25d21da4d31f3 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:54 +02:00
winesync 45b55dc9b2 [WINESYNC] dbghelp: Don't use system headers for ELF declarations.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id b664ae8e60e08224cdc3025c28a37cb22356aaa4 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:53 +02:00
winesync 9228b75d7f [WINESYNC] dbghelp: Use local ELF constants definitions.
Based on glibc.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 56f2b950c3a090d1951edd687e1c6e9ed9388732 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:53 +02:00
winesync d8cc719cb4 [WINESYNC] dbghelp: Don't use ELF32_ST_BIND and ELF32_ST_TYPE macros.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 6fde25300d6c93290887e47c3c4bfd55a948609b by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:53 +02:00
winesync 345ffb9a3c [WINESYNC] dbghelp: Inline ELF magic constants.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 66ab2c503de6d39f1a0256d66511da05d326ac5e by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:53 +02:00
winesync 9e0f62624e [WINESYNC] dbghelp: Use local symbol table entry declaration.
Based on glibc.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 7b12b1849c711476b64b3ed6bc60805ff8f2715f by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:53 +02:00
winesync 44ef7f5ff5 [WINESYNC] dbghelp: Use local dynamic section entry declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 849cf6ed514aaa5071e61dc471dca6be1d58393f by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:53 +02:00
winesync 582c24d09a [WINESYNC] dbghelp: Use local ELF program segment header declaration.
Based on glibc.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 186d610442e1db009e40945fc4725c43ea8721ab by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:53 +02:00
winesync 2a7f64af1f [WINESYNC] dbghelp: Use local elf_section_header declaration.
Based on glibc.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a6f0fe8d1ca16243771784ec34c49453c96e6479 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:52 +02:00
winesync 6c0765a0ec [WINESYNC] dbghelp: Use local elf_header declaration.
Based on glibc.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 78845911da06fc75c6d74237f816a1547c24b20b by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:52 +02:00
winesync 8f9ab8954d [WINESYNC] dbghelp: Use local declarations of r_debug and link_map structs.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 11ea231501f4f2a54433031ada21052d81641fee by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:52 +02:00
winesync 72a0721cf7 [WINESYNC] dbghelp: Use local AT_SYSINFO_EHDR definition.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 620019fd71fd519470b4d624949a74fba9f350e9 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:52 +02:00
winesync 77888f05a4 [WINESYNC] dbghelp: Don't use *_NULL constants.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ee34cf365d34b23669c2ead03b040f09b7fb1e2b by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:52 +02:00
winesync eed384bb16 [WINESYNC] dbghelp: Use local NOTE_GNU_BUILD_ID declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 2534c2a2d22d3c610ffdfbb6b33e0b5176509aa1 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:52 +02:00
winesync aa015b65dc [WINESYNC] dbghelp: Fix misleading indentation warning.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 94ad6bd2e66f589303fe9102b9a81b1f3e8ea9c6 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:51 +02:00
winesync 36388062cd [WINESYNC] dbghelp: Pass stab size to stabs_parse.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 9c2cedabc7c7b48c4f9042d444c45a3036cfd4be by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:51 +02:00
winesync 7fa8c40ed5 [WINESYNC] dbghelp: Use local declaration for 64-bit macho nlist.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id f48f8cc39980f2d93015ecd56f28e3e9f52843fe by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:51 +02:00
winesync 43384a1d3c [WINESYNC] dbghelp: Use local stab_nlist declaration in macho_module.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 061146c2ab530a54f8323331e88c5771dd7bba49 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:51 +02:00
winesync 2d57c6b88f [WINESYNC] dbghelp: Clear N_PEXT flag of stab type in macho files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 47f1c5a993ed34e5f1e4783360019613d0f9682a by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:51 +02:00
winesync e99c66b8bc [WINESYNC] dbghelp: Provide N_PEXT and N_SECT defines when not available.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 208719a7507c41b77d3db9f6b8ffbcc5a4e02f3d by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:51 +02:00
winesync d6dca1da17 [WINESYNC] dbghelp: Use DWARF registry mapping quirk only for actual macho modules.
Fixes handling DWARF in PE on macOS.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 3b6c268380d703079fa3c5ca06f67b6feb02487f by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:50 +02:00
winesync 0b8d0e0a61 [WINESYNC] dbghelp: Pass module to map_dwarf_register.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 5d8067c6088a30cdb4fe6945e6ae1cda0da85467 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:50 +02:00
winesync e656f48c38 [WINESYNC] dbghelp: Define NT_GNU_BUILD_ID regardless of whether __ELF__ is defined.
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id f7a091af4812ef692fb2b1ec835b8146668aec5c by Gerald Pfeifer <gerald@pfeifer.com>
2020-09-16 10:35:50 +02:00
winesync 9b31d0349d [WINESYNC] dbghelp: Use LONG_PTR instead of long type.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id f803da493aeb4cf118fb9b076e8042c2535fbcdb by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:50 +02:00
winesync 31d5e64eb8 [WINESYNC] dbghelp: Remove unused code in module_find_cb.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 8d702a3aa54fc61bd146f584e66364a12a0ee3a0 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:50 +02:00
winesync e0db46fa2e [WINESYNC] dbghelp: Move reading debug base address from PEB to check_live_target.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id e3354e44f17d74f0ac4547d8a4494c83ea3d6d37 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:50 +02:00
winesync ab49d97a84 [WINESYNC] dbghelp: Use PE type for virtual modules.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 635506921a28c65bfc9b339d59c63d96092d97d8 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:50 +02:00
winesync 065f0d9772 [WINESYNC] dbghelp: Explicitly pass file type to path_find_symbol_file.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id c8b5a3be55963fcda51b8e13c10bcd45ecc4bc97 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:49 +02:00
winesync 87c943516f [WINESYNC] dbghelp: Use loader_ops for load_debug_info.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a676c5785ea56fede37370cd6d5e4508e9d8c62a by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:49 +02:00
winesync f308fa857b [WINESYNC] dbghelp: Use loader_ops for load_module.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 5ae3f969d4ec525a14a8109a5ee4c5a2e2238405 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:49 +02:00
winesync afc1e47291 [WINESYNC] dbghelp: Use loader_ops for enum_modules.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 16a3481bd22243183281c60ff375d4e61d5c4198 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:49 +02:00
winesync df9fadccb3 [WINESYNC] dbghelp: Pass process struct to image_uses_split_segs.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 2a5160c4f2eb80dcc8770cd10d702a5d8233314f by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:49 +02:00
winesync ba7ee56d52 [WINESYNC] dbghelp: Use loader_ops for fetch_file_info.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 1bbd54409a546c26af8ac2a64f2603114d73a18c by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:49 +02:00
winesync f9b46d2c9f [WINESYNC] dbghelp: Don't use elf_fetch_file_info and macho_fetch_file_info in module_find_cb.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id adecdb1d01487af16f5f708ae92a05ba4707187e by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:48 +02:00
winesync 031700a760 [WINESYNC] dbghelp: Introduce loader_ops to abstract platform-specific loader and use it to synchronize module list.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id fec0157585e9d8bd03a8a71d1ed9b9d7ca59cb56 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:48 +02:00
winesync 86173a5f26 [WINESYNC] dbghelp: Move loader search functions to the end of module files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id f30fdd1822462326d3339a21b838d28b623e6486 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:48 +02:00
winesync 58c50e916e [WINESYNC] dbghelp: Pass process struct to elf_enum_modules and macho_enum_modules.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 724f433f39f71e8869c49a5960364c5669759b08 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:48 +02:00
winesync ca7d01b33f [WINESYNC] dbghelp: Store process struct pointer in dump context.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 6b3018d03da983050516821caa2aada2f4814678 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:48 +02:00
winesync fbc5f830fc [WINESYNC] dbghelp: Use search_dll_path to load seach macho files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id be9072ec743e22ed6a20288e5539b8ba307f9280 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:48 +02:00
winesync 8194b5dee6 [WINESYNC] dbghelp: Use search_unix_path to load seach macho files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id c3bb866bfc53b8c3b7b7355cb8311325a40a0a6b by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:47 +02:00
winesync 73bb9b5ffd [WINESYNC] dbghelp: Introduce search_unix_path helper and use it in elf_search_and_load_file.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ca49552f646bf30b492da4668745f9f65b9de18d by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:47 +02:00
winesync bf9bb9c911 [WINESYNC] dbghelp: Use search_dll_path in elf_search_and_load_file.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ee5d29b7aa85c109bf9ad5ac59fbe484f53da0ea by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:47 +02:00
winesync e01d28abd8 [WINESYNC] dbghelp: Make dll builtin PE path search helper more generic.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 21af2e194792aaa263c144c8fb42fe678ad2ecd7 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:47 +02:00
winesync 981f24bd1a [WINESYNC] dbghelp: Use file_name helper in more places.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 77e880e6d22ef9be031f783fbb4b6a5e8c8826e8 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:47 +02:00
winesync eaa0c1a8d7 [WINESYNC] dbghelp: Rename helpers to make unicode variants default.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 63d41a41f21c4d9f32b484d6c7ed78c9d7b2a48d by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:47 +02:00
winesync cf4c36cd26 [WINESYNC] dbghelp: Use page size from sysinfo.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 1ece841d9354296f374228b9e16246a076f57196 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:47 +02:00
winesync e2e4ea2f5f [WINESYNC] dbghelp: Call GetSystemInfo in DllMain.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 7544b9f6fb0bf39c714452968e20e478efaa104a by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:46 +02:00
winesync 6a54330242 [WINESYNC] dbghelp: Use Windows API to map macho files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ebf57f01f4890b726a0af702ab7751258f5ab03d by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:46 +02:00
winesync 429c6cd3aa [WINESYNC] dbghelp: Lookup real image paths in image_locate_debug_link.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 838de56e0ac5b91e2ffa27a696d33e0f09179b2e by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:46 +02:00
winesync 5768b7b75c [WINESYNC] dbghelp: Support PE debug link files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 2642f43eabe6c61341daee24487372b57723894d by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:46 +02:00
winesync 710c080147 [WINESYNC] dbghelp: Support GNU debug link and build id in PE files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 0dd495868846f30d9bb8f15f389d2b1ff6f383cb by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:46 +02:00
winesync ebdb2b35d9 [WINESYNC] dbghelp: Move elf_check_alternate implementation to module.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 4694801e4f58f0e856327d251ac98cfb573fd83b by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:46 +02:00
winesync 1a2b28fc64 [WINESYNC] dbghelp: Move get_dos_file_name to path.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id d38682397997c56359f6d161467a56ffe5bfa9fa by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:45 +02:00
winesync 56b57ef7c5 [WINESYNC] dbghelp: Use elf_check_debug_link in elf_locate_build_id_target.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 171c6fadab8eb444968c1b3a4b364e2e978a639a by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:45 +02:00
winesync 3d39743d1b [WINESYNC] dbghelp: Check checksum before mapping elf file.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id c1d867fa872fafe1e6cc54ba6da63868fb7a4a6f by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:45 +02:00
winesync 9743bd26bd [WINESYNC] dbghelp: Pass module struct to elf_locate_debug_link.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 5ba1c5960e716bdec9052efeb9f3ddfba3cf9e0c by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:45 +02:00
winesync f71124fa11 [WINESYNC] dbghelp: Support Windows paths in elf_locate_debug_link.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id e1b28a9c988ef0ff49d7254fd7ba05316f1c9b98 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:45 +02:00
winesync 9a74d137ed [WINESYNC] dbghelp: Move HANDLE-based crc32 helper to dbghelp.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a5a6b0dcb65d8e3576e34d350c80f4789dcfdb7a by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:45 +02:00
winesync 6a1595b09d [WINESYNC] dbghelp: Introduce generic image_unmap_file.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 1d96af362789aa8aaa0be94a046b0afba2ecefb3 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:45 +02:00
winesync fff3c0ca2c [WINESYNC] dbghelp: Use vtbl to handle different image_file_map types.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 95a5f8296188d7dd8ffb86afd4f0c3280e2f5656 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:44 +02:00
winesync 2fc432db92 [WINESYNC] dbghelp: Move alternate file map pointer to generic image_file_map.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 02dfd959ca6f2295ca279ab65f6b6429cd53673c by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:44 +02:00
winesync bf6f0cfe9b [WINESYNC] dbghelp: Use generic image_find_section in elf_check_alternate.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a3e1c7fa02351b032de60fc2a685f14e9f7308fe by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:44 +02:00
winesync 4fc82fc5bd [WINESYNC] dbghelp: Use Windows API to map ELF files.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a60b3985bf37827fd0b0f7583c31dcf52069b4a8 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:44 +02:00
winesync c82f34344e [WINESYNC] dbghelp: Search also real path location in path_find_symbol_file.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id d731208602393877709d3bb0bdeb28c80f9719b0 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:44 +02:00
winesync 95f6a74d85 [WINESYNC] dbghelp: Try loading builtin modules from unix installation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id e21b61392cbc3a4879f837316c869c44b8dcf685 by Jacek Caban <jacek@codeweavers.com>
2020-09-16 10:35:44 +02:00
winesync a6145efdfd [WINESYNC] dbghelp: Use RtlImageDirectoryEntryToData in pe_load_msc_debug_info.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 7e16acf3806f9e810884d710c640f5f82c158093 by Piotr Caban <piotr@codeweavers.com>
2020-09-16 10:35:43 +02:00
winesync e27e4dbaee [WINESYNC] dbghelp: Support 32 and 64-bit binaries in ImageDirectoryEntryToDataEx.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ab4c64a4093b98ca7a74ec29a9d947333791b26d by Piotr Caban <piotr@codeweavers.com>
2020-09-16 10:35:43 +02:00
winesync b7d8c1b1c2 [WINESYNC] dbghelp: Look for .eh_fram if no .eh_frame is found.
lld produces these, because '.eh_frame' misses the eight-character limit
by one character, but '.eh_fram' does not. This allows it to avoid
producing a string table for this common section.

Signed-off-by: Chip Davis <cdavis@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 8000b5415d2c249176bda3d8b49f8fc9978e1623 by Chip Davis <cdavis@codeweavers.com>
2020-09-16 10:35:43 +02:00
winesync 82a89ba33c [WINESYNC] dbghelp: Fix reading the target's dyld image info, based on its CPU architecture.
Signed-off-by: Ken Thomases <ken@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 4b9defe09a24e77547cde4e8211f701a4984681b by Ken Thomases <ken@codeweavers.com>
2020-09-16 10:35:43 +02:00
winesync 30e30ca49a [WINESYNC] dbghelp: Fix reading the address of the target's dyld image info from its PEB.
Signed-off-by: Ken Thomases <ken@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 28a25b052d21a9e2e4fc3c7790711b290d44a488 by Ken Thomases <ken@codeweavers.com>
2020-09-16 10:35:43 +02:00
winesync 910ece9f87 [WINESYNC] dbghelp: Avoid dead assignment (scan-build).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id ae6e4017548fc30bf5220bebc674230dc4ccfe06 by Alex Henrie <alexhenrie24@gmail.com>
2020-09-16 10:35:42 +02:00
winesync b66bb64916 [WINESYNC] dbghelp: Prevent an invalid memory access when the search path element is empty.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id d263ba97fb7c9ada7ae847909f35cbf5db671216 by Rémi Bernon <rbernon@codeweavers.com>
2020-09-16 10:35:42 +02:00
winesync 5e225d76e5 [WINESYNC] dbghelp: Return NULL instead of IMAGE_NO_MAP when PE file mapping fails.
A NULL test is always applied to the return value from pe_map_full(), but
IMAGE_NO_MAP is not NULL, it is ((void*)-1).

Signed-off-by: Conor McCarthy <cmccarthy@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 9d3687ad324f866c835c4b73922f859a30e47aee by Conor McCarthy <cmccarthy@codeweavers.com>
2020-09-16 10:35:42 +02:00
winesync 8105772fc4 [WINESYNC] dbghelp: Use RtlComputeCrc32().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id a91b0faefd801d44063c8d9289dbc69de985f8b6 by Zebediah Figura <z.figura12@gmail.com>
2020-09-16 10:35:42 +02:00
winesync 70880dd15f [WINESYNC] dbghelp: Return a dos path from SymGetLineFromAddr.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34687
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wine commit id 4aa7fbe0561e6a27f098a05a63c5a7d12397e678 by Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
2020-09-16 10:35:42 +02:00