Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-23 08:55:19 +00:00
Code Issues Projects Releases Packages Wiki Activity
reactos/dll/win32
History
Joachim Henze 232c45fcd7 [WIN32SS][COMCTL32] Commit Flip_Fix_9.patch 
flip_fix_9.patch fixes:
CORE-16984 " 'SPINA Thrulg' / 'SPINA Thyr' / 'Sim Thyr' have images flipped"
CORE-17194 "StretchDIBits test" isn't work correctly"
           "Output of 'Project 3 Test'"
CORE-14701 "DVDStyler 3.0.4 transparent toolbars"
CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg"
CORE-14671 "'Peazip' shows icons in buttons and menubar vertically flipped"
           "Double Commander shoes icons flipped in buttons, menubar, listview and the treeview"
CORE-13273 "Welcome to Lazarus" icon shows flipped
CORE-13026 "'CudaText app' icon shows flipped"

Not all of those are duplicates, although they appear to be at first glance.
It affects different controls and some of those tickets do have different 'guilty revs' than others.

The patch does consist of 3 parts:

1.) win32ss/gdi/ntgdi/dibobj.c
This one is the most clean part of it, that addresses most of the flipping issues now.

2.) The hack in comctl32.h redefining the version:
We used that in the past to appease some, but not all of the issues listed above.
But it does hide additional issues, e.g. in DvDStyler, therefore we seem to still need that appeasement even today.
Most likely it would make sense to aim to avoid this part in the future.
part 2.) was committed as first appeasement on its own already into
0.4.14-RC-24-g 198b61e
0.4.13-RC-7-g 67211fa
0.4.12-RC-5-g 8449527
0.4.11-RC-16-g b906163
0.4.10-RC-7-g f1e80fe
0.4.9-RC-34-g 9d758ae

3.) toolbar.c change
That part fixes at least the toolbar case for DvDStyler
without relying on the comctl32.h hack any longer,
but it was still not enough to completely get rid of part 2.) yet.

Many thanks to all contributors: 'I_kill_Bugs', Doug Lyons and also 'Julenuri' for testing.

The patch gave nice testbot results:
KVM:  https://reactos.org/testman/compare.php?ids=75704,75714
VBox: https://reactos.org/testman/compare.php?ids=75705,75715

and we also created a summary of manual test-results:
https://jira.reactos.org/browse/CORE-17415?focusedCommentId=126668&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-126668

If you read this comment via git blame and your goal is to get rid of the hack in comctl32.h, I would highly recommend
to redo the tests of that testing table, and if that is asked too much, then please test at least the following cases:
CORE-14701 "DVDStyler 3.0.4 transparent toolbars"
CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg"
           "DVDStyler 3.0.4 erroneously black/transparent within comboboxes of properties of VMGM menu"
and try to add what might be needed to fix them, and double-check again:
           "DoubleCommander optionsDlg the most complex testcase, contains flip-prone icons in treeview, listview, menubar, buttons, statics". Only some of its flipped icons were impacted by the comctl32.h change before.
2021-01-05 20:30:40 +01:00
..
acledit
aclui [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
activeds
actxprxy
advapi32 [REACTOS] *.spec: Fix some function/parameter types (#3154) 2020-09-20 19:21:11 +02:00
advapi32_vista
advpack [REACTOS] RegQueryValueExW() wants bytes, not chars (#2876) 2020-06-01 12:06:49 +03:00
atl
atl80
atl100
authz
avicap32
avifil32 [TRANSLATION] Hungarian translation update for aclui, avifil32, browseui, comdlg32, crypt32, cryptdlg, shell32, userenv (#2978) 2020-08-17 16:39:42 +02:00
batt
bcrypt
beepmidi
browseui [BROWSEUI][PSDK] Stubplement ShellTaskScheduler (#3326) 2020-12-20 22:06:16 +03:00
bthci
cabinet [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
cards
cfgmgr32
clusapi [CMAKE] Get rid of replace_compile_flags 2020-10-20 21:44:54 +02:00
comcat
comctl32 [WIN32SS][COMCTL32] Commit Flip_Fix_9.patch 2021-01-05 20:30:40 +01:00
comdlg32 [COMDLG32] Improve Polish (pl-PL) translation (#3411) 2021-01-03 15:54:10 +03:00
compstui
credui [TRANSLATION] Hungarian translation update for credui, devmgr, netid, sysdm (#3285) 2020-11-21 18:07:48 +01:00
crtdll [CRTDLL] Make this a stand-alone CRT DLL 2020-10-22 18:07:27 +02:00
crypt32 [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
cryptdlg [TRANSLATION] Hungarian translation update for aclui, avifil32, browseui, comdlg32, crypt32, cryptdlg, shell32, userenv (#2978) 2020-08-17 16:39:42 +02:00
cryptdll
cryptnet
cryptui
dbgeng [DBGENG] Import dbgeng.dll from Wine Staging 4.18 2020-09-10 18:19:28 +02:00
dbghelp [DBGHELP] Add missing support for AMD64. (#3083) 2020-10-25 12:30:37 +01:00
dciman32
devmgr [TRANSLATION] Hungarian (hu-HU) translation update (#3388) 2020-12-31 01:42:34 +03:00
dnsapi
esent
faultrep
fltlib
fmifs [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
fontsub
framedyn [CMAKE] Get rid of add_compile_flags 2020-10-20 21:44:54 +02:00
fusion
gdiplus [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
getuname [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
hhctrl.ocx [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
hid
hlink [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
hnetcfg
httpapi
iccvid
icmp
ieframe [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
iernonce [TRANSLATION] Add/update Portuguese translation (#2850) 2020-06-01 20:48:58 +02:00
imaadp32.acm
imagehlp [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
imm32 [IMM32][INCLUDE] Add immtable.h and modify imm32.spec (#3207) 2020-09-19 22:47:40 +09:00
inetcomm [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
inetmib1
initpki
inseng [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
iologmsg
iphlpapi [IPHLPAPI] Fix for hasArp which crashes some iphlpapi tests. (#3216) 2020-09-22 15:50:41 +02:00
iprtprio
itircl
itss [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
jscript [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
jsproxy
kernel32 [KERNEL32] Fix register initialization in BaseInitializeContext 2020-11-07 18:33:02 +01:00
loadperf
lpk
lsasrv [LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839) 2020-05-23 19:07:04 +02:00
lz32
mapi32 [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
mciavi32
mcicda
mciqtz32
mciseq
mciwave
mgmtapi
mlang [MLANG] Fix scripts values in fnIMLangFontLink2_GetScriptFontInfo() 2020-10-24 10:17:05 +02:00
mmdevapi
mmdrv
modemui [TRANSLATION] Add/update Portuguese translation (#2850) 2020-06-01 20:48:58 +02:00
mpr
mprapi
msacm32
msacm32.drv
msadp32.acm
msafd [MSAFD] Workaround regression CORE-15804 2020-05-13 02:39:37 +02:00
mscat32
mscms
mscoree [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
msctf
msftedit
msg711.acm
msgina Happy New Year 2021 to the ReactOS Community!! 2021-01-01 00:00:00 +01:00
msgsm32.acm
mshtml [CMAKE] Get rid of replace_compile_flags 2020-10-20 21:44:54 +02:00
mshtml.tlb
msi [CMAKE] Get rid of replace_compile_flags 2020-10-20 21:44:54 +02:00
msimg32
msimtf
msisip
msisys.ocx
msnet32
mspatcha
msports [TRANSLATION] Add/update Portuguese translation (#2850) 2020-06-01 20:48:58 +02:00
msrle32 [CMAKE] Get rid of replace_compile_flags 2020-10-20 21:44:54 +02:00
mssign32
mssip32
mstask [MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available. 2020-06-06 23:02:35 +02:00
msv1_0
msvcrt [CMAKE] Fix GCC -fstack-protector usage 2021-01-05 13:38:57 +01:00
msvcrt20
msvcrt40
msvfw32
msvidc32
mswsock [MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub 2020-06-27 14:55:28 +02:00
msxml
msxml2
msxml3 Apply suggestions from code review 2020-10-20 21:44:54 +02:00
msxml3r [CMAKE] Add missing dependencies on PSDK 2020-12-22 13:14:00 +01:00
msxml4
msxml6
mycomput [CMAKE] Add missing dependencies on PSDK 2020-12-22 13:14:00 +01:00
nddeapi
netapi32 [INCLUDE/IDL] Give implicit handles a more unique name 2020-12-22 13:14:13 +01:00
netcfgx [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
netevent
netid [TRANSLATION] Hungarian translation update for credui, devmgr, netid, sysdm (#3285) 2020-11-21 18:07:48 +01:00
netmsg
newdev [TRANSLATION] Hungarian (hu-HU) translation update (#3388) 2020-12-31 01:42:34 +03:00
npptools
ntdsapi
ntlanman
ntmarta
objsel
odbc32
odbccp32
ole32 [OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()' 2020-06-27 14:48:00 +02:00
oleacc [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
oleaut32 [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
olecli32
oledlg [REACTOS] *.spec: Fix some function/parameter types (#3154) 2020-09-20 19:21:11 +02:00
olepro32
olesvr32
olethk32
pdh
pidgen
powrprof
profmap
propsys
psapi [PSAPI] Fix and simplify FindDeviceDriver 2020-11-07 17:39:42 +01:00
pstorec
qmgr
qmgrprxy
query
rasadhlp
rasapi32
rasdlg
rasman
regapi [REGAPI] Import regapi.dll from Wine Staging 5.7 CORE-16458 (#2723) 2020-05-14 14:21:16 +02:00
resutils
riched20
riched32
rpcrt4 [RPCRT4] Check hBinding != 0 CORE-16936 2020-09-01 22:10:18 +02:00
rsabase
rsaenh [RSAENH][MSXML3][OLE32] Revert PRIVATE commits (cbe8a9f and 38b438b) 2020-05-09 17:55:37 +09:00
samlib
samsrv [SAMSRV] Add 'Print Operators', 'Performance Monitor Users' and 'Performance Log Users' aliases to servers 2021-01-03 06:17:48 +01:00
sccbase
schannel
scrrun [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
secur32
security
sensapi
serialui
setupapi [SETUPAPI] Do not use strlen on buffers which may possibly contain REG_MULTI_SZ 2020-12-06 19:49:57 +03:00
sfc
sfc_os
shdoclc
shdocvw
shell32 [SHELL32] Improve Polish (pl-PL) translation (#3410) 2021-01-03 18:24:18 +03:00
shfolder
shimgvw [SHIMGVW] Update Czech (cs-CZ) translation (#3409) 2020-12-31 00:06:48 +03:00
shlwapi [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
slbcsp
smdll
sndblst
snmpapi
softpub
srclient
stdole2.tlb
stdole32.tlb
sti [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
storprop [STORPROP] Add missing property provider stubs 2020-12-12 16:42:15 +01:00
streamci
sxs [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
syssetup [SYSSETUP][INF] Add event log settings to the default security settings and apply them on setup 2021-01-02 21:18:18 +01:00
t2embed
tapi32
tapiui [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
themeui [TRANSLATION] Improve zh-TW translation (#3218) 2020-11-21 18:03:37 +01:00
traffic
twain_32
ubtrfs [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
ucdfs [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
uext2 [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
ufat [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
ufatx [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
uffs [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
untfs [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
updspapi
ureiserfs [FSLIB][FMIFS][AUTOCHK][SETUPLIB] Use more Windows-compatible (but not fully compatible yet) Format() and Chkdsk() ULIB functions. 2020-11-22 21:57:07 +01:00
url
urlmon [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
userenv [TRANSLATION] Hungarian translation update for aclui, avifil32, browseui, comdlg32, crypt32, cryptdlg, shell32, userenv (#2978) 2020-08-17 16:39:42 +02:00
usp10
uxtheme [UXTHEME] Properly show disabled close button 2020-08-16 17:34:38 +03:00
vbscript [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
verifier
version
vssapi [VSSAPI] Add missing wrapper for ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z and _VSSAPI_CreateVssBackupComponents@4 in msvc.s, to fix MSVC compilation 2020-06-07 19:45:05 +02:00
wbemdisp [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
wbemprox [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
wdmaud.drv [WDMAUD.DRV] Revert "Workaround multiple issues with AC97 driver from rapps" 2020-10-03 16:39:13 +02:00
windowscodecs [WINDOWSCODECS] It turns out that /wd4133 is not enough to demote the error; we need to use remove_target_compile_option() to completely remove the /we4133 flag. 2020-11-06 01:06:13 +01:00
windowscodecsext
winemp3.acm
winfax
wing32
winhttp
wininet [WINESYNC] wininet: Replacing header fields should fail if they do not exist yet. 2021-01-05 11:03:13 +01:00
winmm [CMAKE] Get rid of replace_compile_flags 2020-10-20 21:44:54 +02:00
winscard
winsta
wintrust
wlanapi
wldap32 [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
wlnotify
wmi
wmiutils
wmvcore
ws2_32
ws2help
wshirda
wshom.ocx [CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
wshtcpip
wsock32
wtsapi32
wuapi
xinput1_1
xinput1_2
xinput1_3
xinput9_1_0
xmllite
xolehlp
CMakeLists.txt [KERNEL32_VISTA] Move under kernel32 2020-09-25 09:45:54 +02:00