Commit graph

487 commits

Author SHA1 Message Date
Amine Khaldi 8d51a38cbc [DBGHELP] Sync with Wine Staging 3.3. CORE-14434 2018-03-04 23:54:20 +01:00
Amine Khaldi 87a48c832a [RPCRT4] Sync with Wine Staging 3.3. CORE-14434 2018-03-04 23:49:21 +01:00
Timo Kreuzer 0182dcd71b [PSDK][REACTOS] Fix definitions and usage of DWLP_MSGRESULT, DWLP_DLGPROC, and DWLP_USER
- Make sure the DWLP_* values are correct on _WIN64
- Don't use the DWL_* constants, they are not portable. Enforce this by removing them entirely from winuser.h
- Make sure Get/SetWindowLong*Ptr* is used and pointers are not truncated to LONG
2018-03-04 16:27:07 +01:00
Amine Khaldi d3fd5bdd97 [SHLWAPI] Sync with Wine Staging 3.3. CORE-14434 2018-03-04 13:17:11 +01:00
Amine Khaldi d506c2af65 [OLEAUT32] Sync with Wine Staging 3.3. CORE-14434 2018-03-04 13:14:52 +01:00
Adam Słaboń 8fd9d3f59b [TRANSLATION] Polish translation update (#413)
Translation update for sndvol32, shell32 (right click drag menu), rapps and ks.inf.
2018-03-03 21:24:46 +01:00
Thomas Faber eab8a0b968
[BEEPMIDI] Don't busy-wait when no notes are playing. CORE-12860
- Use a new work_available event to allow ProcessPlayingNotes to sleep when no
  notes are to be played.
- Get rid of the pointless thread_termination_complete event, wait on the
  thread handle instead.
- Don't leak thread_handle.
2018-03-01 08:58:33 +01:00
Giannis Adamopoulos 2f11904000 [SHIMGVW] -Add the 123 manifest to load the v6 comctl32. CORE-14415
This shows that we may have problems in the future with applications using just comctl32 v5
2018-03-01 09:23:06 +02:00
Giannis Adamopoulos 6d4a091b4a [BROWSEUI] CBandSite: Implement SetBandSiteInfo and GetBandSiteInfo
Only BSIS_LOCKED, BSIS_NOGRIPPER, BSIS_ALWAYSGRIPPER and BSIS_NOCAPTION supported so far.
2018-02-28 17:20:46 +02:00
Giannis Adamopoulos 6785192fe6 [BROWSEUI] CBandSite: Style fixes 2018-02-28 17:20:44 +02:00
Hermès Bélusca-Maïto 295ea36f9e
[ADVAPI32] Few improvements for Services.
- Set some last errors.
- Fix error code returned by ScLookupServiceByServiceName().
- Check the validity of the handler proc in RegisterServiceCtrlHandler(Ex)W().
- Improve some traces; comment some code.
2018-02-26 00:37:09 +01:00
Hermès Bélusca-Maïto 2e3f80f940
[ADVAPI32] Code formatting + improve two traces. 2018-02-26 00:37:05 +01:00
Hermès Bélusca-Maïto 0c44925ec1
[ADVAPI32] ScStartService(): Just start the thread straight ahead, and return a suitable error code if thread creation failed. 2018-02-26 00:37:01 +01:00
Hermès Bélusca-Maïto 91b50f9ccb
[ADVAPI32] Take into account the service handler context when dispatching a control notification to a service. (Used e.g. by tcpsvcs.) 2018-02-26 00:36:57 +01:00
Hermès Bélusca-Maïto 635aabb011
[ADVAPI32] Use RPC types where needed. Comments cleanup. 2018-02-26 00:36:53 +01:00
Thomas Faber af6c5806d5
[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerName in PathUnExpandEnvStrings) by Katayama Hirofumi MZ. CORE-13816 2018-02-24 14:18:29 +01:00
Eric Kohl 1dfbed9c3d [SERVICES][ADVAPI32] Fix the broken service stop sequence
services\database.c:
- Refactor ScmControlService() so that it can be used to send the dispatcher loop stop command.
- Separate the code to decrement the image run counter from the service image cleanup code.

services\rpcserver.c:
- RSetServiceStatus(): Stop the dispatcher loop when the image run counter is zero and remove the service image after that.

advapi32\service\sctrl.c:
- Do not terminate the service dispatcher loop when the last service is being stopped. Wait for an explicit dispatcher stop command (empty service name).

CORE-12413
2018-02-24 11:14:05 +01:00
Serge Gautherie b6c060ce04 [IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391) 2018-02-23 17:35:02 +00:00
Giannis Adamopoulos 5b38fed776 [SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
It seems that TBN_DELETINGBUTTON isn't called when the toolbar gets destroyed so the only way to avoid leaking the data is emptying it ourselves.
2018-02-23 12:27:48 +02:00
Thomas Faber b8741e2bb3 [SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194 2018-02-22 11:53:34 +01:00
Thomas Faber 182a31074f [IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353 2018-02-21 18:42:43 +01:00
Giannis Adamopoulos 3263303844 [SHELL32] CShellItem: Fix GetDisplayName and Compare
The two methods were completely broken because they passed a full pidl to the parent folder (and not desktop folder).
Compile SHGetNameFromIDList to use it in CShellItem but don't export it.
2018-02-20 16:59:00 +02:00
Giannis Adamopoulos 9d7313273c [SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on wine
Fixes lots of tests.
2018-02-20 16:33:30 +02:00
Giannis Adamopoulos af97de39a2 [SHELL32] CShellItem: Fix return value of Compare method 2018-02-20 14:36:31 +02:00
Giannis Adamopoulos c361e475b4 [SHELL32] CDefaultContextMenu: Implement GetCommandString 2018-02-20 13:05:59 +02:00
Giannis Adamopoulos 7e48c20b3b [SHELL32] Fix a couple of tests 2018-02-20 11:48:40 +02:00
Giannis Adamopoulos ac950ea01d [SHELL32] shellpath: sync a part of _SHGetDefaultValue with wine
on 32bit builds CSIDL_PROGRAM_FILESX86 is treated as CSIDL_PROGRAM_FILES and on wow64 builds CSIDL_PROGRAM_FILES gets treated as CSIDL_PROGRAM_FILESX86
2018-02-20 10:58:14 +02:00
Giannis Adamopoulos 730d81b9f7 [SHELL32] Fix some test failures 2018-02-20 10:15:23 +02:00
Timo Kreuzer d281d14fd1 [REACTOS] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of GWL_* where appropriate. 2018-02-19 22:36:36 +01:00
Mark Jansen ee7f479c57
[RTL][XDK][KERNERL32_WINETEST] Import wine actctx changes from 3.2-37c98396
This adds support for reading the trustInfo (requestedExecutionLevel),
and the compatibility (supportedOs) sections.
2018-02-19 22:23:39 +01:00
Giannis Adamopoulos 48d88a3617 [SHELL32] CFSFolder: Fix some tests for GetAttributesOf 2018-02-19 02:01:02 +02:00
Mark Jansen b02d78586c
[COMCTL32] Export GetWindowSubclass by name.
CORE-14346
2018-02-18 23:04:45 +01:00
Giannis Adamopoulos fd209faa66 [SHELL32] CFSDropTarget: style fixes 2018-02-17 22:01:04 +02:00
Giannis Adamopoulos 4b19b1e49d [SHELL32] CDefView: remove a useless print 2018-02-17 21:40:16 +02:00
Giannis Adamopoulos 6f25b42a31 [SHELL32] CFSDropTarget: Use copy depending on the source drive
Show the default action as the default menu item in the right click menu.
2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 6d91269eda [SHELL32] CFSDropTarget: Initial implementation of right click drag menu 2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 8f8ab050db [SHELL32] CDefView: Implement several methods needed for drop targets
Set the view object as the site of the drop target.
Implement GetItemPosition, SelectAndPositionItems, IsDropOnSource, GetDragPoint.
Use DROPEFFECT_COPY only when the item supports it.
2018-02-17 20:30:37 +02:00
Giannis Adamopoulos 5bef945cc9 [SHELL32] Add menu resource which is used when dragging files with right click 2018-02-17 20:30:37 +02:00
Hermès Bélusca-Maïto 175e78e50f
[SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes. 2018-02-16 23:31:39 +01:00
Katayama Hirofumi MZ 338799bf8b improve SHGetFileInfo (#118)
This patch reduces failures of SHGetFileInfo function. CORE-7159
* improve WideByteToWideChar calls
* fix bugs related to file attributes and SHGFI_EXETYPE
* SHGFI_USEFILEATTRIBUTES and SHGFI_ICON fix
* s/sizeof(temppsfi)/0/
2018-02-16 11:00:08 +00:00
Hermès Bélusca-Maïto fe4704fa64
[SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177 2018-02-15 22:38:22 +01:00
Giannis Adamopoulos 67f99833cd [SHELL32] CNewMenu: Don't use CWM_GETISHELLBROWSER.
CDefaultContextMenu: Set the site for context menu extensions
CNewMenu: Get SID_IFolderView service of the site to get the IShellView
2018-02-15 00:58:22 +02:00
Giannis Adamopoulos b97886ea9f [SHELL32] Fix the toolbar buttons in the file open dialog
CDefView: Make GetItemObject return an IContectMenu after setting itself as the site.
CDefViewBckgrndMenu: Make the inner context menu use the same site. Implement handling CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA.
CDefaultContextMenu: CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA shouldn't be handled in this class.
Fixes CORE-14327 and the two buttons that change the view mode
2018-02-15 00:23:18 +02:00
Joachim Henze e4aa45f63a [SHELL32] Fix glitch in de-DE.rc
checkbox captions are too long.
issue was introduced by 3624c5d6fd

fixes CORE-14329 for de-DE
2018-02-14 20:12:10 +01:00
Giannis Adamopoulos 111c40e012 [SHELL32] CDefViewBckgrndMenu: Fix handling string verbs.
It shouldn't be necessary for QueryContextMenu to be called before InvokeCommand.
Move retrieving the IContextMenu of the folder to the initialization of the class.
CORE-12866
2018-02-14 00:03:35 +02:00
Hermès Bélusca-Maïto eb3987e172
[SHLWAPI] Import wine commit 2c163225730e88 as addendum to the SHCreateWorkerWindowW/A fixes from commit 770bf93. 2018-02-13 22:30:59 +01:00
Mark Jansen fb7caa7452
[COMCTL32] Import wine commit 71cf0a31d99feb to fix the name column width in rapps. 2018-02-13 19:48:18 +01:00
Hermès Bélusca-Maïto 770bf93be3
[SHLWAPI] Improvements for SHCreateWorkerWindowW/A() prototypes + fix x64-bit compatibility. Sent upstream.
[SHLWAPI] Refactor the SHCreateWorkerWindowW() prototype to match its ANSI SHCreateWorkerWindowA() counterpart.

The last parameter is really to be understood as an extra window data, and not a "message result" (as it would be the case for dialog window procedure).
That is why I also remove the mention of "DWLP_MSGRESULT" in the SetWindowLongPtrW() call.
SHCreateWorkerWindowA() had it OK but SHCreateWorkerWindowW() did not.

------------------

[SHLWAPI] Make SHCreateWorkerWindowA() and SHCreateWorkerWindowW() x64-compatible.

The first parameter of these functions is a pointer to a window procedure, having a definite prototype, so employ a correct typedef WNDPROC,
which ensures both correct pointer size and parameter type enforcement.
This also ensures that we use instead a correct pointer size, since otherwise LONG remains 32-bits for Windows compatibility on x64 platforms.
The wndProc parameter is thus casted to LONG_PTR to comply with the SetWindowLongPtrA/W calls.

In SHCreateWorkerWindowW(), the last "wnd_extra" parameter should also be LONG_PTR to be able to pass 64-bit data pointer on x64 platforms.
Therefore fix also setting the wc.cbWndExtra size. One should note that the ANSI SHCreateWorkerWindowA() function had everything OK already.
2018-02-13 00:13:47 +01:00
Luo Yufan 19737a2cb9 [TRANSLATION] Simplified Chinese translation update for NETID and PING. (#369) 2018-02-07 14:03:42 +01:00
Giannis Adamopoulos e05f08be4e [SYSSETUP] Hackfix CORE-14228
Wine's comctl32 somehow fails to load an 24bpp image with ImageList_LoadImageW
when crMask is CLR_NONE so use a color that doesn't exist in the bitmaps until
comctl32 gets fixed.

I prefer to add this silly hack in a non critical dll than make a hasty change in the
critical comctl32 until some proper tests are written for this absurd failure.
2018-02-07 02:26:28 +02:00
Giannis Adamopoulos 218b8eda92 [SYSSETUP] Don't load ISOLATIONAWARE_MANIFEST_RESOURCE_ID manually
Such a manifest is meant to be activated by the caller of the exports of the dll.
This means that the user of syssetup which is setup.exe is the one that should do the proper handling of the manifests.
Since setup.exe is the one that needs to do the right thing, add a CREATEPROCESS_MANIFEST_RESOURCE_ID to it and avoid
dealing with ISOLATIONAWARE_MANIFEST_RESOURCE_ID altogether (which is supposed to be used by activating the activation context
before calling the exports of the dll that has it). We don't really use ISOLATIONAWARE_MANIFEST_RESOURCE_ID correctly in any
place in the tree so let's rely on CREATEPROCESS_MANIFEST_RESOURCE_ID for now.

This fixes one part of CORE-14228 where no image was shown in the theme selector buttons. This happened because comctl32 was
statically linked and calling ImageList_LoadImage ended up creating an image list with comctl32 v5. Then we passed this image
list to a button created with comctl32 v6 and as a result the image list was unusable. This is yet another issue that needs
to be addressed in the future. Namely, it seems that in windows comctl32 v6 can use image lists created by comctl32 v5 whereas
we cannot.

This fix is not a hack but cleverly works around these two bugs that need to be addressed some time in the future.
CORE-14228
2018-02-07 01:15:49 +02:00
Luo Yufan b97f0a8fed [TRANSLATION][BROWSEUI][MEDIA] Simplified Chinese translations update (#360) 2018-02-05 18:47:53 +01:00
Mark Jansen 058c2658a4 [SHELL32] CDefViewBckgrndMenu: Fix a crash when pasting on a new explorer window. 2018-02-05 17:39:32 +01:00
Eric Kohl e5870819a3 [SETUPAPI] Machine handles are pointers. 2018-02-04 22:03:17 +01:00
Eric Kohl 19fc20f222 [SETUPAPI] Add a proper (SEH protected) check for LOG_CONF handles 2018-02-04 20:23:51 +01:00
Eric Kohl 60a218948e [SETUPAPI] Fix the coding style, annotations and debug messages
* Fix the coding style.
* Add missing annotations.
* Add the function name to the debug messages.
* Treat all machine handles like pointers.
2018-02-04 20:16:46 +01:00
Thomas Faber b9f88d594d
[PSDK][XDK] Remove DECLSPEC_* from windef.h, protect against redefinition in winnt.h 2018-02-04 19:28:36 +01:00
Hermès Bélusca-Maïto 131678a025
[SHELL32] Rewrite the wrapping code for shell taskbar notifications.
- Introduce the TRAYNOTIFYDATAW structure, as documented by Geoff
  Chappell in "WM_COPYDATA for Taskbar Interface", at
  http://www.geoffchappell.com/studies/windows/shell/shell32/api/shlnot/copydata.htm
  that is the data structure passed between shell32 and explorer for
  communicating shell notify icon information.

- In Shell_NotifyIcon(), correctly capture the (ANSI and) UNICODE
  structures provided by the caller, properly taking into account for
  the different NOTIFYICONDATA structure sizes existing out there.
  The different strings are now properly null-terminated (especially
  szTip if it needs to be truncated out), and the flags validated.

- Remove the now unneeded "SHELL_NotifyIcon()" helper function.

[EXPLORER] Use TRAYNOTIFYDATAW and adjust the callers.
2018-02-04 18:11:50 +01:00
Hermès Bélusca-Maïto e2c6c3cfc7
[BROWSEUI] Shut a warning down ("windef.h(121) : warning RC4005: 'DECLSPEC_IMPORT' : redefinition" when compiling the resource). 2018-02-04 18:11:47 +01:00
Eric Kohl 65d3bf7482 [SETUPAPI] Fix the coding style, add annotations and fix the debug messages. 2018-02-04 15:41:13 +01:00
Eric Kohl c7fc2ef4d2 [SETUPAPI] Update some more functions to the current coding style, add annotations and add function names to the TRACE calls. 2018-02-04 11:17:30 +01:00
Hermès Bélusca-Maïto 5ecabcce59
[SHELL32] Fix copy-pasta. 2018-02-04 01:56:56 +01:00
Luo Yufan a13c998183 [TRANSLATION] Simplified Chinese translations updated. (#348) 2018-02-01 02:50:29 +01:00
Stanislav Motylkov 63ad8a71c0 [IPHLPAPI] Fix IcmpSendEcho output when host is not reachable
- Add missing error code to DDK/NDIS
- Fix error code in IP driver
- Patch MSAFD to reply correct WSA error code
- Fix IcmpSendEcho function
  - Fix returning error code in ICMP_ECHO_REPLY (see MSDN)
  - Fix returning host address (using GetBestInterface and GetIpAddrTable functions)
- Fix GetBestRoute function (it is used by GetBestInterface)

Relates to #318 and CORE-14241
2018-01-31 17:28:21 +00:00
Stanislav Motylkov 3624c5d6fd [SHELL32] Fix file and folder properties dialogs
CORE-12755
2018-01-31 18:25:14 +01:00
Thomas Faber 682735fb56
[SHELLMENU] Add missing psdk dependency. 2018-01-31 11:48:37 +01:00
Luo Yufan 7082b621a5 [TRANSLATION] Simplified Chinese translation improved. (#346) 2018-01-30 21:49:40 +01:00
Katayama Hirofumi MZ 0864d2de85 [SHIMGVW] Enable zooming
* merge ZoomIn and ZoomOut functions
* NULL to hbrBackground
* use GET_X_LPARAM and GET_Y_LPARAM for WM_MOUSEWHEEL
2018-01-30 19:36:59 +00:00
Jared Smudde 817beaf9c5 [NETCFGX] Rename 'Network connection' to 'Network Connection'. (#345)
English capitalization fix. It should look a little better both in the system tray and in the Network Connections folder.
2018-01-30 18:07:09 +01:00
Timo Kreuzer 2b57c9f47d Revert "[OLEAUT32] Sync with Wine 3.0. CORE-14225"
This reverts commit 13fd286c18.

The "sync" zapped a lot of fixes, in particular 64 bit compatibility.
2018-01-29 23:31:08 +01:00
Luo Yufan 09168aae12 [TRANSLATION] Update Simplified Chinese Translations of SHELL32 and USRMGR (#340) 2018-01-29 18:21:20 +01:00
Joann Mõndresku d80ef2c90a [TRANSLATION] Various translations to Estonian (#329)
Estonian translations for shell + explorer, cpl files (access, appwiz, desk, timedate), devmgr, browseui, comctl32, aclui, avifil32, comdlg32 and credui.
2018-01-29 17:03:27 +01:00
Giannis Adamopoulos 8c4b7b0747 [COMCTL32] toolbar: Use szBarPadding.cy as the default top margin 2018-01-29 17:51:06 +02:00
Adam Słaboń fbcf05062e [TRANSLATION] Polish translation update (#328) 2018-01-27 13:21:22 +01:00
Giannis Adamopoulos 5b8975211d [GDIPLUS] Add it to winsxs.
[NTDLL_APITEST] Remove a hack for gdiplus
2018-01-27 02:45:50 +02:00
Stanislav Motylkov 25564cda9d [UXTHEME] Add missing THEME_BUTTON_STATES
CORE-14245 #resolve
2018-01-23 14:46:57 +02:00
Hermès Bélusca-Maïto 9e07da5ccb
[SHLWAPI] Partly revert SHLWAPI Wine 3.0 sync b725032 .
This Wine sync (that was not done against WineStaging) erased code
that had been submitted to WineStaging by the ReactOS team (clist.c
fixes, see r73565 a05881c and r73976 7b6b597) or added in r68042 9a78054.

To that aim I add explicit #if(n)def __REACTOS__ guards around the code.
2018-01-22 21:07:21 +01:00
Eric Kohl 9d29ee3a62 [DEVMGR] Implement missing device power information (current power state, power capabilities and power state mappings). 2018-01-22 00:35:21 +01:00
Amine Khaldi 90f14ccef3 [WTSAPI32] Sync with Wine 3.0. CORE-14225 2018-01-21 22:01:34 +01:00
Amine Khaldi 3672658e75 [WSHOM.OCX] Sync with Wine 3.0. CORE-14225 2018-01-21 21:59:45 +01:00
Amine Khaldi 81b5ed93e1 [WMVCORE] Sync with Wine 3.0. CORE-14225 2018-01-21 21:58:37 +01:00
Amine Khaldi 87c506baca [WLDAP32] Sync with Wine 3.0. CORE-14225 2018-01-21 21:57:04 +01:00
Amine Khaldi c95e9203e6 [WININET] Sync with Wine 3.0. CORE-14225 2018-01-21 21:53:54 +01:00
Kamil Smoliński 00ed9fc88b [SHELL32] Fix typo in Polish translation pl-PL.rc 2018-01-21 19:13:57 +01:00
Thomas Faber cd992d022f
[USP10] Re-use script caches for the same font. CORE-14192
This significantly speeds up WM_SETTEXT in multiline edit controls.
2018-01-20 15:55:07 +01:00
Amine Khaldi 9048bdf976 [WINHTTP] Sync with Wine 3.0. CORE-14225 2018-01-20 13:55:24 +01:00
Amine Khaldi c8f158b700 [WINEMP3.ACM] Sync with Wine 3.0. CORE-14225 2018-01-20 13:52:52 +01:00
Amine Khaldi c3715ca58f [WINDOWSCODECS] Sync with Wine 3.0. CORE-14225 2018-01-20 13:50:46 +01:00
Amine Khaldi 7e99651d65 [WBEMPROX] Sync with Wine 3.0. CORE-14225 2018-01-20 13:47:34 +01:00
Amine Khaldi b99f0b4922 [WBEMDISP] Sync with Wine 3.0. CORE-14225 2018-01-20 13:45:23 +01:00
Amine Khaldi 9e01104f70 [VERSION] Sync with Wine 3.0. CORE-14225 2018-01-20 13:41:59 +01:00
Amine Khaldi e0b80a0929 [VBSCRIPT] Sync with Wine 3.0. CORE-14225 2018-01-20 13:39:40 +01:00
Amine Khaldi 2eb77351e0 [URLMON] Sync with Wine 3.0. CORE-14225 2018-01-20 13:29:39 +01:00
Amine Khaldi 0edcbac349 [TWAIN_32] Sync with Wine 3.0. CORE-14225 2018-01-20 13:17:45 +01:00
Amine Khaldi b7250325e4 [SHLWAPI] Sync with Wine 3.0. CORE-14225 2018-01-20 13:15:19 +01:00
Amine Khaldi b2462dae72 [SHDOCVW] Sync with Wine 3.0. CORE-14225 2018-01-20 13:14:14 +01:00
Amine Khaldi 90155f749f [RPCRT4] Sync with Wine 3.0. CORE-14225 2018-01-20 13:13:03 +01:00
Amine Khaldi 2bf764722b [RICHED20] Sync with Wine 3.0. CORE-14225 2018-01-20 13:09:57 +01:00
Amine Khaldi 95c3773f73 [PROPSYS] Sync with Wine 3.0. CORE-14225 2018-01-20 13:02:49 +01:00
Amine Khaldi 13fd286c18 [OLEAUT32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:59:23 +01:00
Amine Khaldi 2178977b54 [OLE32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:57:25 +01:00
Amine Khaldi 0506c9332a [MSXML3] Sync with Wine 3.0. CORE-14225 2018-01-20 12:35:17 +01:00
Amine Khaldi d023d396ee [MSVIDC32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:33:41 +01:00
Amine Khaldi 76e5652fb4 [MSVFW32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:31:50 +01:00
Amine Khaldi f8b992f2d3 [MSI] Sync with Wine 3.0. CORE-14225 2018-01-20 12:29:30 +01:00
Amine Khaldi a3eb2d3811 [MMDEVAPI] Sync with Wine 3.0. CORE-14225 2018-01-20 12:26:03 +01:00
Amine Khaldi cea8085626 [USP10] Sync with Wine 3.0. CORE-14225 2018-01-20 12:17:14 +01:00
Thomas Faber 73e6bc960a
[COMCTL32] Unset the toolbar's hot item when deleting a button. CORE-14222
This fixes occasional crashes when hovering over disappearing tray icons.
2018-01-20 02:24:01 +01:00
Amine Khaldi 7821493171 [MPR] Sync with Wine 3.0. CORE-14225 2018-01-19 12:30:00 +01:00
Amine Khaldi 5e2c163f70 [MLANG] Sync with Wine 3.0. CORE-14225 2018-01-19 12:27:23 +01:00
Amine Khaldi 3381ee4b89 [JSCRIPT] Sync with Wine 3.0. CORE-14225 2018-01-19 00:45:08 +01:00
Amine Khaldi 08fb1fc8fe [ITSS] Sync with Wine 3.0. CORE-14225 2018-01-19 00:43:54 +01:00
Amine Khaldi 31fbc03b86 [INSENG] Sync with Wine 3.0. CORE-14225 2018-01-19 00:42:56 +01:00
Amine Khaldi 88221e598a [INETCOMM] Sync with Wine 3.0. CORE-14225 2018-01-19 00:39:56 +01:00
Amine Khaldi fc87cf0bc3 [IMAGEHLP] Sync with Wine 3.0. CORE-14225 2018-01-19 00:37:52 +01:00
Amine Khaldi c4b0f2155f [IEFRAME] Sync with Wine 3.0. CORE-14225 2018-01-19 00:36:36 +01:00
Amine Khaldi d848f99bf9 [ICCVID] Sync with Wine 3.0. CORE-14225 2018-01-19 00:32:44 +01:00
Amine Khaldi 221fc8fd30 [HNETCFG] Sync with Wine 3.0. CORE-14225 2018-01-19 00:30:10 +01:00
Amine Khaldi 73921e9412 [HLINK] Sync with Wine 3.0. CORE-14225 2018-01-19 00:23:23 +01:00
Amine Khaldi 8d2d12d7ee [HHCTRL.OCX] Sync with Wine 3.0. CORE-14225 2018-01-19 00:21:29 +01:00
Amine Khaldi 007122e774 [GDIPLUS] Sync with Wine 3.0. CORE-14225 2018-01-19 00:17:41 +01:00
Amine Khaldi 975d9d4d4c [FUSION] Sync with Wine 3.0. CORE-14225 2018-01-19 00:10:53 +01:00
Amine Khaldi f9c57f8489 [DBGHELP] Sync with Wine 3.0. CORE-14225 2018-01-19 00:09:29 +01:00
Amine Khaldi 736e16553a [CABINET] Sync with Wine 3.0. CORE-14225 2018-01-19 00:06:11 +01:00
Amine Khaldi f1713a3c60 [AVIFIL32] Sync with Wine 3.0. CORE-14225 2018-01-19 00:04:19 +01:00
Amine Khaldi 9c96b06291 [ATL][ATL80][ATL100] Sync with Wine 3.0. CORE-14225 2018-01-19 00:01:06 +01:00
Amine Khaldi b53d60cfc5 [COMDLG32] Sync with Wine 3.0. CORE-14225 2018-01-18 23:52:46 +01:00
Amine Khaldi edd99e8ccc [COMCTL32] Sync with Wine 3.0. CORE-14225 2018-01-18 23:49:20 +01:00
Giannis Adamopoulos 4c23b78b5e [BROWSEUI] CISFBand: Handle DBID_SETWINDOWTHEME. CORE-14176 2018-01-16 11:50:51 +02:00
Mark Jansen 4a2ad113e5 [KERNEL32] Add version info to VerifyVersionInfo mismatch print. 2018-01-15 19:47:58 +01:00
Giannis Adamopoulos 7e9f56229f [UXTHEME] -Pass a non 0 wParam when themes get enabled and 0 when they get disabled 2018-01-15 12:57:08 +02:00
Giannis Adamopoulos b8062bde5d [COMCTL32] rebar: Remove some hacks and fix checking for transparent background 2018-01-15 12:57:06 +02:00
Mark Jansen 1d4d88b062 [PSDK][ACTXPROXY] Add IExplorerCommand and related classes (Vista+) 2018-01-13 23:49:58 +01:00
Mark Jansen e5f9029826
[BROWSEUI] Do not clear a CComPtr with memset. 2018-01-13 20:57:04 +01:00
Giannis Adamopoulos 6d9a0d0fd4 [SHELL32] CDrivesFolder: Fix showing the drive capacity. CORE-14201 2018-01-13 21:27:57 +02:00
Giannis Adamopoulos 5966a18e66 [COMCTL32] toolbar: Use the theme text color for the dropdown arrows. CORE-13855 2018-01-13 16:19:27 +02:00
Giannis Adamopoulos 5618b33c3b [SHELL32] CMenuBand: Redraw the toolbars if this is the menu bar of a window and its active state changed. Use COLOR_GRAYTEXT for the text of the inactive menu bar items. CORE-14197 2018-01-13 14:57:24 +02:00
Giannis Adamopoulos f463ebe9e7 [COMCTL32] -toolbar: Improve drawing diabled text with themes. CORE-13855 2018-01-10 23:30:26 +02:00
Giannis Adamopoulos 789881672a [COMCTL32] status: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-10 15:52:42 +02:00
Giannis Adamopoulos 92732f1bcf [COMCTL32] rebar: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-10 13:44:32 +02:00
Thomas Faber bf5e33201e
[MSAFD] Avoid magic numbers in NtCreateEvent calls. 2018-01-10 11:26:21 +01:00
Colin Finck 63a3a2cbb8
[KERNEL32] Accept all images for NT 3.1 and higher instead of bailing out at image versions > 5.01 (#273)
Print a debug message whenever an application newer than ReactOS' internal NT version is started.
This gets a simple "Hello World" compiled by VS' 2017 regular "v141" toolchain to run under ReactOS.

Please retry NT6+ applications!
2018-01-10 09:24:22 +01:00
Andreas Maier 387067ad29
[SETUPAPI]: Fix a FIXME in SetupDiSetDeviceRegistryPropertyA.
Rename SetupDiSetDeviceRegistryPropertyW to IntSetupDiSetDeviceRegistryPropertyAW and use it for both (A/W).
The FIXME in the A-Version was already implemented in the W-Version.

CORE-14173.
2018-01-09 18:51:12 +01:00
Thomas Faber 58f2c14c23
[ADVAPI32] Fix non-PCH build. 2018-01-08 09:51:15 +01:00
Mark Jansen d0f3fa51fb [ADVAPI32] Stub OpenTrace and ProcessTrace so newer versions of ProcessExplorer start again.
CORE-10312
2018-01-07 22:29:17 +01:00
Erdem Ersoy ba3f074320 [TRANSLATIONS] Update the email address and add a note in the Turkish translation document (#271) 2018-01-07 22:09:42 +01:00
Luo Yufan 59aa6b9e74 [TRANSLATION] Improve Simplified Chinese Translations (#265)
* Update Simplified Chinese translation of SYSSETUP
* Update Simplified Chinese translations and font settings.
* Update Translation of SHELL32.
2018-01-05 14:15:03 +01:00
Giannis Adamopoulos a671923037 [SHELL32] CMenuToolbarBase: Use COLOR_MENUTEXT color for the text color in normal menu items. CORE-13855 2018-01-05 11:53:35 +02:00
Giannis Adamopoulos 695147eaac [COMCTL32] tab: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-04 23:27:48 +02:00
Giannis Adamopoulos 522601d050 [COMCTL32] toolbar: Draw checked and not hot buttons as checked, not hot. CORE-13592
Should be sent to wine.
2018-01-04 14:30:47 +02:00
Bișoc George 699b8bf857 [DLL][WIN32][NEWDEV] Wrong character in the Romanian translation removed (#259)
Replaced "ú" with "u". Is that letter even a thing? :D
2018-01-03 21:29:44 +01:00
Stanislav Motylkov 6fa16d791a [SYSSETUP] Add marquee progress bar to show setup is alive (#262)
CORE-14163 #resolve
2018-01-03 21:24:26 +01:00
Luo Yufan 2524a0b636 [TRANSLATIONS] Simplified Chinese translation update. #251 2018-01-02 18:39:24 +01:00
Thomas Faber b20280a0f9
[CMAKE] Allow overriding the .dll extension for delay imports in MSVC builds.
Fixes delay-importing winspool.drv.
2018-01-01 19:05:30 +01:00
Timo Kreuzer a2f7de7ee8
Amd64/misc 64bit fixes (#236)
[REACTOS] Misc 64 bit fixes

* [NTOS:MM] Allow MEM_DOS_LIM in NtMapViewOfSection on x64 as well
* [NTOS:MM] Implement x64 version of MmIsDisabledPage
* [HAL] Remove obsolete code
* [NTOS:KE] Fix amd64 version of KeContextToTrapFrame and KeTrapFrameToContext
* [XDK] Fix CONTEXT_XSTATE definition
* [PCNET] Convert physical address types from pointers to PHYSICAL_ADDRESS
2018-01-01 12:07:50 +01:00
Hermès Bélusca-Maïto 9fa693e59b
[REACTOS] Switch to year 2018...
... and Happy New Year 2018 to everyone!!

☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆

  ⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰
░░░░░░█░█ █▀█ █▀█ █▀█ █░█░░░░░░
░░░░░░█▀█ █▀█ █▀▀ █▀▀ ▀█▀░░░░░░
░░░░░░▀░▀ ▀░▀ ▀░░ ▀░░ ░▀░░░░░░░
█▄░█ █▀▀ █░█░█░░█░█ █▀▀ █▀█ █▀█
█░██ █▀▀ █░█░█░░▀█▀ █▀▀ █▀█ ██▀
▀░░▀ ▀▀▀ ░▀▀▀░░░░▀░ ▀▀▀ ▀░▀ ▀░▀
  ⋱☆⋰⋱★⋰⋱☆⋰⋱★⋰⋱★⋰⋱☆⋰⋱★⋰⋱☆⋰
░░░▄████▄░▄███▄░░▄██░▄████▄░░░
░░░▀▀░▄██░██░██░████░██▄▄██░░░
░░░░▄██▀░░██░██░░░██░██▀▀██░░░
░░░██████░▀███▀░░░██░▀████▀░░░

☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆.¸¸.•´☆
2018-01-01 00:00:00 +01:00
Hermès Bélusca-Maïto e0baa58f1b
[SETUPAPI] Fix extraction of files from a cabinet file using the SetupQueueCopy and SetupCommitFileQueue method.
CORE-14164

- Contrary to what Wine thought, this works even if the cabinet file does not have a ".cab" extension.
- Instead of polluting the directory where the cabinet file exists with all the files extracted from it,
  we only extract the needed file to a temporary folder (thus being sure it does not overwrite any other
  existing file with the same name), and then we move the extracted file to its final destination with rename.
2017-12-31 02:48:58 +01:00
Hermès Bélusca-Maïto 7c447a15a0
[SETUPAPI] Add __REACTOS__ guards around our own code; addendum to r68659 and r73442, CORE-10000 and CORE-12471. 2017-12-31 02:48:54 +01:00
Katayama Hirofumi MZ 89f9c9101a
[TRANSLATION] Use correct font name in Korean resources, CORE-9566 (#228).
Localized resources should use the correct Korean fonts that are most suitable
for UI and compatible with Windows.
2017-12-29 01:51:15 +01:00
Stanislav Motylkov e7485ea00c [RASAPI32] Add stub for RasGetConnectionStatistics
See CORE-10426
2017-12-28 11:51:40 +01:00
Joachim Henze 5e5e5cde68 [COMCTL32] use previous version of cursor files CORE-14144,
idc_divider.cur & idc_divideropen.cur,
justify their diff in comctl32/comctl32_ros.diff
2017-12-28 00:04:53 +01:00
Katayama Hirofumi MZ 1ebe4a5b83
[TRANSLATION] Use correct font name in Chinese resources, Part 3/3, CORE-9566 (#223).
Localized resources should use the correct Chinese font names compatible with Windows.
2017-12-27 16:11:21 +01:00
Katayama Hirofumi MZ 074f5c6c13
[TRANSLATION] Use correct font name in Chinese resources, Part 2/3, CORE-9566 (#222).
Localized resources should use the correct Chinese font names compatible with Windows.
2017-12-27 16:11:08 +01:00
Katayama Hirofumi MZ 81d6232aa3
[TRANSLATION] Use correct font name in Chinese resources, Part 1/3, CORE-9566 (#221).
Localized resources should use the correct Chinese font names compatible with Windows.
2017-12-27 16:10:56 +01:00
Amine Khaldi a3797dba7a [SHELL32] Deduplicate MAX_PROPERTY_SHEET_PAGE and AddPropSheetPageCallback(). #179 2017-12-25 13:22:23 +01:00
Markus Gothe e2e699118f Improve swedish translations and add new translations to swedish. 2017-12-25 11:31:22 +01:00
Giannis Adamopoulos c5e707ec1f [UXTHEME] EnableThemeDialogTexture: Update window theme only when ETDT_USETABTEXTURE is used 2017-12-24 23:52:10 +02:00
Giannis Adamopoulos 435b0b19d2 [COMCTL32] Install comctl32 v6 and its manifest in first stage 2017-12-24 21:19:03 +02:00
Mark Jansen 99c7c93b83 [DLL] Fix wrong manifest includes. 2017-12-24 11:44:21 +01:00
Stanislav Motylkov a89c979fe0 [TRANSLATION] [NETCFGX] Fix russian translation 2017-12-20 20:35:08 +01:00
Ivan Labutin d6792047f3 [NTOS][NDK][RTL] A bunch of 'wrong size' fixes 2017-12-20 06:56:09 +01:00
Mark Jansen ad181d892c [BROWSEUI] Implement ACLCustomMRU.
CORE-9281
2017-12-18 23:17:17 +01:00
Amine Khaldi 0a4e5911fc [UUID] Add SID_SHTMLEditServices. 2017-12-18 13:18:26 +01:00
Luo Yufan d6131ace49 [TRANSLATION] Improve Simplified Chinese Translations.
* Fix Simplified Chinese Translation of EXPLORER.
* Fix Simplified Chinese Translation of MSCONFIG_NEW.
* Fix Simplified Chinese Translation of MSPAINT.
* Fix Simplified Chinese Translation of SHELL32.
* Fix Simplified Chinese Translation of SYSDM.
* Fix Simplified Chinese Translation of SETUP/REACTOS.
2017-12-17 14:40:59 +01:00
Hermès Bélusca-Maïto eea43394bf
[KERNEL32] Improve the definition of EXENAME_LENGTH. 2017-12-16 21:07:23 +01:00
Hermès Bélusca-Maïto 197ec4c5b8
[KERNEL32] Update some console API prototypes. 2017-12-10 17:04:29 +01:00
Amine Khaldi 1c4f4818ea [ITSS] Get the stubs file out of the source files list. #179 2017-12-09 23:21:22 +01:00
Amine Khaldi 287d7cd80a [SMDLL] Use precomp.h in dllmain.c. 2017-12-09 20:47:27 +01:00
Amine Khaldi b3544fd00b [BROWSEUI/SHELLBARS] Add a PCH. 2017-12-09 20:46:40 +01:00
Amine Khaldi d6cb9f60d1 [ACLEDIT][ATL][ATL80][FLTMGR] Get the def files out of the source files lists. #179 2017-12-09 19:59:02 +01:00
Amine Khaldi 44d57334de [LSASRV] Deduplicate SAMPR_ULONG_ARRAY. 2017-12-09 13:29:58 +01:00
Amine Khaldi f6108f3187 [MSAFD] Move the default debug channel to msafd.h. 2017-12-09 13:24:35 +01:00
Amine Khaldi d086a431cb [SAMLIB] Use precomp.h in dllmain.c. 2017-12-09 12:32:34 +01:00
Pierre Schweitzer 4fcaf92ec3
[KERNEL32] Silent a noisy DPRINT1 2017-12-09 11:54:18 +01:00
James Tabor c45a6e15bf [User32|IMM32] Fix a recursion crash in IMM. See CORE-14041.
Required a sync port from wine. This is a hack fix with Win32SS until
proper IMM support is added to Win32SS.
2017-12-07 21:14:21 -06:00
Amine Khaldi 9b349f958c [ADVAPI32_APITEST][NTDLL_APITEST][WINDOWSCODECS] Comment out some unused functions and types. Silences some clang-cl warnings. 2017-12-08 00:22:05 +01:00
Amine Khaldi ccd5377851 [COMCTL32][FLTLIB][NETAPI32][SNDVOL32][STOBJECT][WBEMPROX] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-08 00:06:13 +01:00
Amine Khaldi e83592920b [SHELL32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-07 23:54:22 +01:00
Amine Khaldi 7ed4c1dd03 [ADVAPI32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-07 23:34:28 +01:00
Giannis Adamopoulos d163627319 [BROWSEUI] Move _ILIsDesktop to a shared header to avoid having 3 instances of it 2017-12-07 23:26:30 +02:00
Stanislav Motylkov 53edadb8c0 [BROWSEUI] SHExplorerParseCmdLine: Improve relative path handling
CORE-12882, CORE-13847
2017-12-05 10:48:37 +02:00
Serge Gautherie 57aa1f1fc6
[SHELL32] shellpath.c: it is _WIN32_WINNT, not WIN32_WINNT. We even need to use __REACTOS__ instead here. CORE-12580 2017-12-03 21:52:37 +01:00
Stanislav Motylkov a2cc76af84 [IPHLPAPI] Implement interface name resolving functions
Including:
- NhGetInterfaceNameFromDeviceGuid
- NhGetInterfaceNameFromGuid

CORE-13831, CORE-14033

Reference:
https://github.com/boundary/wireshark/blob/master/capture_win_ifnames.c#L275
2017-12-03 21:08:31 +01:00
Stanislav Motylkov c2bdad2981 [SHELL32] Fix show properties with Alt+Enter 2017-12-02 18:10:43 +02:00
Katayama Hirofumi MZ 87d276f05d [SHELL32] Don't show error when closing disk prop sheet (#144)
CORE-14035
2017-11-25 11:27:20 +02:00
Giannis Adamopoulos 4a843c4e85 [COMCTL32] syslink: Don't free the return value of WM_CTLCOLORSTATIC. CORE-13605
-This is a bug in wine and should be sent upstream
2017-11-24 00:15:57 +02:00
Giannis Adamopoulos fc6c07c385 [UXTHEME] Add a hack for themed scrollbars
- After inspecting a theme file with different upper or lower tracks it seems that windows use what is called LowerTrackHorz and LowerTrackVert in the upper track and UpperTrackHorz and  UpperTrackVert are used in the lower track.
CORE-13513
2017-11-23 23:07:35 +02:00
Giannis Adamopoulos 51333f3eec [UXTHEME] Fix text background on themed tabs. CORE-13605 2017-11-23 22:25:52 +02:00
Giannis Adamopoulos 68af472a21 [UXTHEME] Improve drawing of the scrollbars when they are too small. CORE-13513 2017-11-23 21:19:03 +02:00
Amine Khaldi 09c06a2f45 [CLANG-CL] Initial commit that allows us to compile ReactOS with clang-cl. 2017-11-23 14:09:57 +01:00
Pierre Schweitzer 63dcfd2de3
[SHELL32] Update French translation 2017-11-21 18:24:08 +01:00
Stanislav Motylkov f884d29c90 [SHELL32] Update Russian translation, following 6465705 2017-11-21 14:06:54 +02:00
Pierre Schweitzer 9904aafd12
[MSGINA] Fix buttons alignment in French translation 2017-11-21 11:49:01 +01:00
Giannis Adamopoulos 8f98574e1d [UXTHEME] -Don't change the behaviour of DefWindowProc if SetWindowRgn was called before 2017-11-21 10:52:56 +02:00
Giannis Adamopoulos 1bfbdb6123 [COMCTL32] Button: Use double buffering when themes are enabled. 2017-11-20 18:51:03 +02:00
Giannis Adamopoulos 3a68bebf87 [UXTHEME] EnumThemes: Don't fail if a theme doesn't have a tooltip. CORE-13732 2017-11-19 16:02:44 +02:00
Pierre Schweitzer 45b543202d
[SHELL32] Drop slash when dismounting a remote drive. MPR and NP are expecting a drive letter.
This fixes dismounting a network drive using explorer.
2017-11-18 21:27:30 +01:00
Pierre Schweitzer 0701527f20
[SHELL32] Update French translation, following 6465705 2017-11-18 18:56:59 +01:00
Katayama Hirofumi MZ 64657051c3 [SHELL32] CDrivesFolder: Implement the eject and disconnect menu items. CORE-13841
- The items are shown only for the drives where they are applicable.
- May not work fully yet due to bugs in the drivers.
2017-11-18 16:55:08 +02:00
Stanislav Motylkov 06919cde1a [BROWSEUI] [TRANSLATION] Improve english, polish and russian translation 2017-11-18 16:43:27 +02:00
Stanislav Motylkov e12763d5bc [BROWSEUI] CISFBand: Add "Open Folder" feature
CORE-13996 #resolve
2017-11-18 12:08:16 +02:00
Stanislav Motylkov f01e6ed6c5 [BROWSEUI] CBandSiteMenu: Show Toolbar error on failure 2017-11-18 11:40:58 +02:00
Giannis Adamopoulos a4ea17218f [COMCTL32] Implement using different image list images depending on the button state 2017-11-17 14:44:52 +02:00
Giannis Adamopoulos 34c563fa2a [COMCTL32] Button: Don't use a class brush. CORE-13445 2017-11-17 01:26:37 +02:00
Serge Gautherie 067bb2fcef [SETUPAPI] driver.c: it is _WIN32_WINNT, not WIN32_WINNT. CORE-12580 2017-11-16 18:58:57 +01:00
Eric Kohl 3ad5c7fd84 [SETUPAPI] Improve the range list implementation.
- SEH-protect the range list validation and move it into a separate function.
- Use a mutex to synchronize access to the range list.
- Implement CM_First_Range and parts of CM_Add_Range.
2017-11-12 23:27:09 +01:00
Giannis Adamopoulos 18dee7a392 [COMCTL32] Button: Implement sending CDDS_PREERASE, CDDS_POSTERASE, CDDS_PREPAINT and CDDS_POSTPAINT according to the apitest and the visual tests.
Remove some #ifdef __REACTOS__ from theme_button.c as this file has been forked for good and there is not real plan to keep syncing it with wine.
2017-11-11 13:56:28 +02:00
Giannis Adamopoulos a98ff4d77c [COMCTL32] Button: Draw the image list even when the button has the BS_ICON or the BS_BITMAP style. CORE-13170 2017-11-11 01:31:32 +02:00
Giannis Adamopoulos dea602cd70 [COMCTL32] -Button: Implement drawing the image list with the BUTTON_IMAGELIST_ALIGN_CENTER parameter. This is enough to fix buttons with images created by Lazarus but only with themes. The non themed branch of the code is slightly more complex and will be fixed next. CORE-13170 2017-11-10 20:59:25 +02:00
Adam Słaboń 7273a7ba21
Polish Translation update 2017-11-09 22:40:49 +01:00
Eric Kohl a2a372398a [SETUPAPI]: CM_Open_DevNode_Key_Ex: FIXME/ERR --> TRACE 2017-11-05 17:55:25 +01:00
Eric Kohl d57b0ef91e [SETUPAPI] GetDeviceInstanceKeyPath: Fix temporary buffer allocation, add missing code paths and fix registry paths.
This should fix parts of CORE-13944.
2017-11-05 17:31:34 +01:00
Stas'M 484f33f0d3 [BROWSEUI] CBandSiteMenu
- Move SHGetFolder code to CreateBuiltInISFBand
- Get rid of CSIDL_FLAG_CREATE (Windows doesn't create Quick Launch
directory)
- Use ILFree since variables are reused now
2017-11-05 14:06:47 +02:00
Eric Kohl d9a3398172 [SETUPAPI] Update some more functions to the current coding style, add annotations and add function names to the TRACE calls. 2017-11-05 11:33:08 +01:00
Giannis Adamopoulos 78b78d6e73 [SHELL32] SHBrowseForFolderW: Fix creating directories in the desktop and in drives like C: CORE-13925 2017-11-05 12:11:10 +02:00
Eric Kohl 8e850d19bc [SETUPAPI] GetDeviceInstanceKeyPath: Implement the CM_REGISTRY_SOFTWARE | CM_REGISTRY_CONFIG part. 2017-11-05 09:39:44 +01:00
Eric Kohl 06f9e1220f [SETUPAPI] CM_Open_DevNode_Key_Ex: Add support for remote registry access and the Disposition parameter. 2017-11-04 21:19:39 +01:00
Eric Kohl f86e78d00b [SETUPAPI] Update some functions to the current coding style, add annotations and add function names to the TRACE calls. 2017-11-04 19:01:28 +01:00
Eric Kohl 78cf2a04a5 [SETUPAPI] Start the implementation of CM_Open_DevNode_Key_Ex(). 2017-11-04 17:26:38 +01:00
Stas'M 1eea9304e1 [DBGHELP] [XDK] [ARM64] Fix magic constant 2017-11-04 14:01:27 +01:00
Giannis Adamopoulos dd4af77703 [SHELL32] SHBrowseForFolder: Fix creating a new folder (which was broken two years ago and was properly reported 3 days ago). CORE-13925 2017-11-03 12:12:58 +02:00
Hermès Bélusca-Maïto 11049bd6d8
[COMCTL32] comctl32/propsheet: Fix redrawing of the static text elements.
Partial revert of SVN r74136 (b1b4279): enforce the correct "color" for
the background of the static text elements: indeed, using a "transparent"
background kept instead the old window color, which was not correctly
repainted, unless you enforced a repaint by, e.g. moving away then back
the window, or moved something else on top of it.

Tested and approved by 'reactosfanboy'.
Was detected as a regression in the wizard of DVDWrite Now 1.5.12
Formatter GUI.

CORE-13929
CORE-12912
2017-11-02 23:52:33 +01:00
Manuel Bachmann 9192d39f6e [SHELL32] Fix multiple selection of desktop icons
This fixes the following issue : when selecting multiple icons
on the desktop, and then right-clicking; the Properties sheet
would immediately be displayed, conflicting with the context
menu.
2017-11-02 21:55:39 +02:00
Giannis Adamopoulos 2875a70c0a [BROWSEUI] Add a todo comment block in CISFBand.cpp and CBandSite.cpp regarding some problems and missing features when using the quick launch toolbar. These two lists are not complete but cover most important problems of quick launch. There is no need to create bug reports for these. 2017-11-02 19:52:02 +02:00
Amine Khaldi fe6d46f86e [SHELL32] Properly set case -714 as TBN_DRAGOUT. CORE-11799 (#94) 2017-10-30 21:53:00 +01:00
Amine Khaldi 830fc82afe [SERIALUI] Set the stdcall calling convention for CommDlgProc() and make it return INT_PTR. CORE-11799 (#94) 2017-10-30 21:49:10 +01:00
Thomas Faber ba8f75557a
[SHELL32][REGEDIT][MSCONFIG_NEW] Correctly check for presence of list view sort header. 2017-10-29 22:00:18 +01:00
Pierre Schweitzer ebe9735835
[KERNEL32] Fix a FIXME in WaitNamedPipeW(): allow waiting on a remote pipe 2017-10-29 20:34:49 +01:00
Pierre Schweitzer a80f5f53e7 [KERNEL32] In GetLogicalDrives(), if NtQueryInformationProcess() call succeed, but return drive map is empty, make sure returned error is success.
Patch by Alex Ionescu
2017-10-29 14:49:59 +01:00
Amine Khaldi 5cb0615147 [BROWSEUI][DEVMGR][EXPLORER][NTGDI][NTOBJSHEX][NTVDM][SETUPAPI] Remove/comment out some unused variables. CORE-11799 (#94) 2017-10-28 15:04:18 +01:00
Amine Khaldi ce4ecd604d [SHELL32] Remove some unused members and comment out some unused Wine code. CORE-11799 (#94) 2017-10-27 23:51:44 +01:00
Amine Khaldi 5a14845970 [MSAFD] Properly define SockAsyncThread() and avoid the cast. CORE-11799 (#94) 2017-10-27 23:47:30 +01:00
Giannis Adamopoulos d310df0dd2 [SHELL32] CDefView: Fix a leak of an HMENU. This fix is thanks to Joachim Henze who found the bug and quickly found the guilty revision. CORE-13911 2017-10-26 21:39:32 +03:00
Pierre Schweitzer 0add5d0a79 [KERNEL32] Fix MSVC build 2017-10-23 17:25:19 +02:00
Pierre Schweitzer 34c39a1336 [KERNEL32] Implement NpGetUserNamep() 2017-10-23 17:09:21 +02:00
Pierre Schweitzer 19cef7806c [KERNEL32] Fix a FIXME in GetNamedPipeHandleStateW and stub a private function for a left unimplemented function 2017-10-23 14:36:18 +02:00
Pierre Schweitzer 3832f83a32 [KERNEL32] Check Basep8BitStringToDynamicUnicodeString() return and only call -W in case of success
CID 1419330
2017-10-23 13:39:44 +02:00
Pierre Schweitzer 19f1cd78c1 [KERNEL32] Check NtQueryInformationFile succeed before using its return. Also fix coding style
CID 512966
2017-10-23 12:36:43 +02:00
Giannis Adamopoulos 143c306006 [BROWSEUI] CBandSiteMenu: Use CSimpleArray and CComHeapPtr. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 3bfdbf3b2c [BROWSEUI] Improve CBandSiteBase::OnWinEvent to forward messages correctly to the child bands. 2017-10-22 20:03:32 +03:00