Katayama Hirofumi MZ
2727245c86
[SHELL32] Shell notify rework for simplicity and readability ( #2539 )
...
Shell change notification has been implemented in #2432 . But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950
2020-04-13 10:36:24 +09:00
Mark Jansen
b68749c727
[WINMM] Fix crashing winetest
...
CORE-16795
CORE-16806
2020-04-13 01:41:02 +02:00
Katayama Hirofumi MZ
ddc1a46456
[SHELL32] Improve CChangeNotify::ShouldNotify more
...
Improved non-recursive cases.
CORE-13950
2020-04-11 11:55:06 +09:00
Katayama Hirofumi MZ
2a32094aa0
[SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify
...
CORE-13950
2020-04-11 09:27:45 +09:00
Katayama Hirofumi MZ
2a6bccb4ce
[SHELL32] Make "Unable to get notification window" quiet
...
CORE-13950
2020-04-11 08:45:23 +09:00
Eric Kohl
de5f67726b
[DEVMGR] Remove ATLASSERTs from ListDevicesByType and RecurseChildDevices
...
Suggested by Mark Jansen. Thanks!
2020-04-10 20:58:02 +02:00
Katayama Hirofumi MZ
d04f2e5209
[BROWSEUI] Add 'm_' prefix to CExplorerBand members ( #2524 )
...
Add 'm_' prefix to the variable members of class CExplorerBand for readability.
CORE-13950
2020-04-10 23:08:31 +09:00
Katayama Hirofumi MZ
60959e34aa
[SHELL32] Simplify CChangeNotify::ShouldNotify
...
CORE-13950
2020-04-10 21:57:58 +09:00
Katayama Hirofumi MZ
59c48a5d33
[SHELL32] Improve CChangeNotify::ShouldNotify
...
Shell change notification was not sent to My Documents.
CORE-13950
2020-04-10 21:51:22 +09:00
Jérôme Gardou
68d94581ad
[IPHLPAPI] Do not use free() on buffer allocated with HeapAlloc
2020-04-10 12:06:53 +02:00
Serge Gautherie
745cb1cbda
[SHELL32] Fix SHCNE_UPDATEITEM number of items ( #2409 )
...
Import
83acbb79c1
Related to CORE-13950
2020-04-09 19:42:00 +02:00
Bișoc George
28e277b65f
[MSGINA] Redraw only the animation bar scroll ( #2518 )
...
Invalidating and updating the whole window is a waste of computation resources and may cause certain controls notably the text string control to flicker. So instead, just invalidate the specific portion of the client area which is the animation bar.
2020-04-09 19:06:00 +02:00
Serge Gautherie
a5a426f867
[MSGINA] gui: Remove superfluous DLG_DATA.TimerID ( #2505 )
...
And use a timer ID define, with a positive value; report SetTimer() failure.
2020-04-09 18:54:15 +02:00
Mas Ahmad Muhammad
b8dd046ee4
[TRANSLATION] Add and update Indonesian translations ( #2506 )
...
- CMDUTILS: attrib, label (update translation)
- USETUP (add translation)
- HOTPLUG (add translation)
- CONSRV (update translation)
- USERSRV (update translation)
- USER32 (update translation)
- ACLUI (update translation)
- LICCPA (update translation)
- SUBST (update translation)
- REGSVR32 (update translation)
- REGEDIT-CLB (update translation)
- ACPPAGE (update translation)
- TIMEDATE (update translation)
- SOLITAIRE (update translation)
- FDEBUG (update translation)
- SYSSETUP (update translation)
2020-04-09 18:49:45 +02:00
Joachim Henze
bf342653df
[SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file)
2020-04-09 18:17:06 +02:00
Katayama Hirofumi MZ
1c706d7483
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save ( #2515 )
...
- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391
2020-04-09 16:56:54 +09:00
Katayama Hirofumi MZ
0903c645a2
[SHELL32] Follow-up of #2432
...
Fixed hang of FireFox.
2020-04-09 08:19:47 +09:00
Katayama Hirofumi MZ
296192685b
[SHELL32] Implement shell change notification ( #2432 )
...
- Rewrite SHChangeNotify, SHChangeNotifyRegister, SHChangeNotify_Lock, SHChangeNotify_Unlock and SHChangeNotifyDeregister functions.
- Fix SHSimpleIDListFromPathA/W functions.
CORE-13950
2020-04-09 07:30:14 +09:00
Victor Perevertkin
dd2ff41dfc
[IPHLPAPI] Make icmp functions use IOCTL_ICMP_ECHO_REQUEST from tcpip.sys
...
This adds missing features like using events and APCs within IcmpSendEcho2
functions and others.
CORE-10742 CORE-14411
Co-authored-by: Tim Crawford <crawfxrd@gmail.com>
2020-04-07 05:32:40 +03:00
Julen Urizar Compains
d6e0fe78e7
[TRANSLATION] Updating Spanish translation ( #2503 )
...
Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.
- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".
2020-04-06 13:17:20 +02:00
Eric Kohl
b857ae808e
[DEVMGR] CDeviceView::RecurseChildDevices: Skip invalid device nodes
...
CORE-16780
2020-04-05 18:29:32 +02:00
Hermès Bélusca-Maïto
76ebd0d054
[RPCRT4] Handle ERROR_BAD_NETPATH failure if an RPC pipe connection is done on an non-existing UNC path.
...
Addendum to 5274857d
(see originally commit 13f41d74
). CORE-6561
2020-04-03 13:33:03 +02:00
Hermès Bélusca-Maïto
5274857da9
[RPCRT4] Addendum to support for remote pipes names in ncacn_pipe_name() ( 24cd7bbe
).
...
CORE-6561 CORE-13442
- Call GetComputerNameA() only when a non-empty server name has been
provided, thus slightly improving speed for the most common case when
local calls (with an empty server name) are done.
- When a server name is passed, trim any leading UNC server prefix since
the latter will be restored when building the pipe name string.
2020-04-02 18:35:39 +02:00
Serge Gautherie
30613b92ab
[ACLUI] Properly enumerate cache+queue entries ( #1937 )
2020-03-30 13:13:22 +02:00
Serge Gautherie
724466597f
[REACTOS] Remove forced _WIN32_IE defines
...
No impact, as already deactivated or superseded or superfluous.
Import
7770e26f2d
2020-03-30 13:47:09 +03:00
Serge Gautherie
07efa2ef53
[SHELL32] HCR_GetIconA(): Properly use icon_idx ( #2482 )
...
CORE-11713
Import
7cc2806e0e
2020-03-30 12:24:59 +02:00
Serge Gautherie
78d8705181
[WINMM] Add a WARN() when winejoystick.drv is missing ( #2480 )
...
Follow-up to 97150ce9
.
Import
175a2a0276
2020-03-30 12:14:52 +02:00
Serge Gautherie
6e79e60883
[RPCRT4] Fix 'Routeines' typos ( #2481 )
...
Addendum to b6fdb56b9a
.
Import
c73352047d
CORE-15682
2020-03-30 10:28:52 +02:00
Mark Jansen
177ae91bf6
[RTL] Introduce RtlpImageNtHeader,
...
which implements the required functionality.
ntdll and ntoskrnl now have a wrapper for this, with SEH.
This protects the function against malformed / bad images,
whilst still being able to use the code in freeldr et al.
Idea from Thomas.
CORE-14857
2020-03-29 21:27:38 +02:00
Andreas Maier
782ff23261
[MSV1_0] LsaApLogonUserEx2: use RtlRunDecodeUnicodeString to decode password
2020-03-28 23:27:34 +01:00
Serge Gautherie
5542dd50d6
[ADVAPI32] wine/crypt.*: Misc fixes
...
Import
62df03af96
8b9e3dae4f
2df16753f0
And use explicit '#ifndef __REACTOS__'.
2020-03-28 20:43:04 +01:00
Serge Gautherie
8ae8083378
[ADVAPI32][PSDK] CryptReleaseContext(): dwFlags parameter is DWORD, only
...
Import
9cc8b501ee
2020-03-28 20:43:03 +01:00
Serge Gautherie
df224cb710
[ADVAPI32] wine: Remove remnant ros_diff.patch
...
Added on 4234345b03
(r48090),
merged on d4a89f6cca
.
CORE-14434
2020-03-28 20:43:03 +01:00
Andreas Maier
2d36be4963
[MSV1_0] use precompiled headers ( #2475 )
2020-03-28 17:13:57 +01:00
Hervé Poussineau
5ed1867632
[CMAKE] Add some -D__ROS_LONG64__ to please gcc x64
...
We can now pass a UINT* to a function wanting a DWORD*
2020-03-26 16:39:16 +01:00
Serge Gautherie
1edfddf07a
[USERENV] sq-AL: Fix '%SistemDrive%' typo ( #2469 )
...
Not to translate!
CORE-16762
2020-03-26 07:28:09 +01:00
Eric Kohl
38788a2b07
[STORPROP] Add storprop.dll and implement the DiskClassInstaller stub
2020-03-22 16:40:35 +01:00
jimtabor
10d1afea18
[Explorer|Shell32]
...
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
2020-03-21 19:13:55 -05:00
Tibor Lajos Füzi
432a5ddc7f
[TRANSLATION] Update Hungarian translation of usetup, syssetup, explorer, netshell, userenv, shortcuts ( #2442 )
2020-03-20 17:52:46 +01:00
Robert Naumann
fc4c4d4911
Sync brsfolder.c with keyboard shortcut code from wine ( #2290 )
...
* [SHELL32] Add shortcut to rename folders with the F2 key.
Sync Wine Commit 2e25a43f3fb6230460447bae6fb5db2edbd4a42f by Fabian Maurer
* [SHELL32] Add shortcut to delete folders with the delete key.
Sync Wine Commit 43f44ffb3779ff23c863d9b3297f92720e7e3733 by Fabian Maurer
* Disable the code for file deletion. The Wine way doesn't work on ROS. Add an explaining comment why we can't use the Wine code, as requested by Amine
2020-03-18 21:57:10 +01:00
Mark Jansen
315765ed8b
[MSVCRT] Add _snwscanf
2020-03-15 13:12:20 +01:00
Mark Jansen
550ce7e818
[WINTRUST] Add WTHelperGetFileHash stub
2020-03-15 13:12:05 +01:00
Katayama Hirofumi MZ
6bd0c70f15
[SHLWAPI] Sorry, I updated wrong function at 5a440b2
( #2430 )
...
CORE-13950
2020-03-11 10:41:39 +09:00
Katayama Hirofumi MZ
5a440b2d90
[SHLWAPI] Follow-up of #2430
...
Add a NULL check in SHLockSharedEx function. CORE-13950
2020-03-11 07:36:07 +09:00
Katayama Hirofumi MZ
7fcdf0be03
[SHLWAPI] Implement SHLockSharedEx function ( #2430 )
...
- Implement shlwapi!SHLockSharedEx function.
- Modify shlwapi.spec file (some argument conversions from long to ptr).
CORE-13950
2020-03-11 00:03:45 +09:00
Eric Kohl
3909ebcf35
[SETUPAPI] Improve CM_Disable_DevNode_Ex
...
Replace the call to PNP_DeviceInstanceAction(PNP_DEVINST_DISABLE) by a call to PNP_DisableDevInst() because PNP_DeviceInstanceAction(PNP_DEVINST_DISABLE) is a no-op.
2020-03-07 13:26:53 +01:00
Serge Gautherie
9ccd179e4a
[RASDLG] Fix remaining '\n\n\n\n\n\n\n' typo ( #2416 )
...
Addendum to commit 92aabb07
.
2020-03-07 00:51:32 +01:00
Jose Carlos Jesus
a6515e2b75
[TRANSLATION] Update PT translation ( #2342 )
...
Update Portuguese translation for cryptui, ieframe and mpr DLLs.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:40:03 +01:00
Tibor Lajos Füzi
ae7ce69f43
[TRANSLATION] Add Hungarian translation for explorer, msgina ( #2341 )
2020-03-06 19:15:58 +01:00
Serge Gautherie
92aabb07fb
[REACTOS] Fix remaining ' \n' typos, in *.rc ( #2393 )
...
Addendum to commit 554c41e4
(#2387 ).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:08:25 +01:00
Hervé Poussineau
35cb8f1393
[SETUPAPI] Implement StopDevice()
2020-03-05 22:47:15 +01:00
Hermès Bélusca-Maïto
98b58df2bf
[KERNEL32:CONSOLE] Explicitly use _WIN32_WINNT_VISTA.
2020-03-02 01:08:36 +01:00
Katayama Hirofumi MZ
fc11cf78ca
[SHELL32] Improve ShellExecCmdLine in path resolving ( #2397 )
...
Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409
2020-03-01 19:32:33 +09:00
Katayama Hirofumi MZ
4df9355d0c
[SHELL32][BOOTDATA] Unselect filename extension upon renaming ( #2398 )
...
You can disable unselecting by setting TRUE to SelectExtOnRename value of HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer. CORE-15242
2020-02-29 08:08:26 +09:00
Serge Gautherie
554c41e4d7
[REACTOS] Fix trailing spaces and other typos in string resources ( #2387 )
2020-02-26 11:45:27 +03:00
Katayama Hirofumi MZ
3c5b10f4e6
[SHELL32] Fix SHChangeNotify for one item events ( #2386 )
...
Windows sends notification even if two parameters are provided for notification of one parameter. CORE-13950
2020-02-26 10:59:28 +09:00
Katayama Hirofumi MZ
1e60116563
[SYSDM][MSGINA][NETID][SHELL32] Japanese translation (retrial) ( #2369 )
...
Improve Japanese resources. This PR is based on @Midi730's work (#2361 ).
2020-02-25 10:27:49 +09:00
Katayama Hirofumi MZ
0a626dedf8
[SHELL32] Set read-only for some shell folders and delete Desktop.ini of Desktop and Program Files ( #2385 )
...
Set read-only attribute instead of system attribute for some shell folders that has a folder icon.
Delete desktop.ini files in Desktop and Program Files. CORE-16711
2020-02-25 10:07:58 +09:00
Doug Lyons
4e721f780e
[SHELL32] Fix unneeded error Popup with Git for Windows. ( #1854 )
...
* Fix unnecessary error popup when installing Git for Windows.
* Add reasons for return value of 42.
2020-02-23 17:47:48 +01:00
Hermès Bélusca-Maïto
c6058bca24
[ATL] Import Wine upstream patch 3043ab3e62
...
Author: Puetz Kevin A <PuetzKevinA@JohnDeere.com>
atlbase.h: Fix some declarations on win64.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-23 16:52:03 +01:00
Hermès Bélusca-Maïto
b4b0728684
[ATL30] Addendum to commit e410a122: Import Wine upstream patch 5608682dc9
...
atl: Fix the ATL_WNDCLASSINFOW::m_szAutoName member definition and construction.
Signed-off-by: Hermes Belusca-Maito <hermes.belusca@sfr.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-23 16:51:58 +01:00
Hermès Bélusca-Maïto
570eba2a52
[KERNEL32][CONSRV] Use more often the internal ConioRectHeight/Width() and ConioIsRectEmpty() macros.
2020-02-22 21:15:58 +01:00
Bișoc George
61c8d3432c
[MSGINA] Be sure to always initialize the cached DLG_DATA GINA context ( #2360 )
...
The ReactOS logo banner is loaded from the GINA context whereas the animation bar is loaded from the main application instance. However, the aforementioned context is not initialized when WM_INITDIALOG occurs hence DlgData_LoadBitmaps() would fail on proceeding at loading the remaining bitmaps to be loaded.
This fixes the regression introduced by commit 623dd26c
(PR #2353 ).
2020-02-20 00:20:01 +01:00
Katayama Hirofumi MZ
623dd26cce
[MSGINA] Make DLG_DATA object-oriented ( #2353 )
...
- Rename hBitmap as hLogoBitmap of DLG_DATA structure.
- Add DlgData_Create. DlgData_LoadBitmaps, and DlgData_Destroy functions.
CORE-16697
2020-02-18 14:35:44 +09:00
Andreas Maier
8b0cfa1d3c
[MSV1_0] Improve LogonUserEx2 ( #2356 )
...
- Improve traces, using %wZ for UNICODE_STRING;
- Fix UNICODE_STRING validation.
2020-02-16 16:55:31 +01:00
Oleg Dubinskiy
7075bdacb2
[SHELL32] Don't hardcode My Documents path for My Music/Pictures/Videos folders in some translations ( #2354 )
...
Don't hardcode My Documents path in some translations of My Music, My Pictures and My Videos folders in Shell32. It fixes incorrect location of that folders when install ReactOS as Workstation.
Currently they are located in one more My Documents subfolder, which is, in its turn, in the correct My Documents directory. After this fix, they are directly in the 2nd one, as they should be.
CORE-16698
2020-02-15 20:06:16 +01:00
Katayama Hirofumi MZ
d51716f131
[SYSSETUP] Small fix in Japanese translation
2020-02-15 11:04:48 +09:00
Katayama Hirofumi MZ
3d53078b1e
[BROWSEUI] Improve Japanese translation (IDD_SEARCH_DLG)
2020-02-15 10:28:36 +09:00
Katayama Hirofumi MZ
b1c7ca3024
[SYSSETUP] Improve resource ATTENTION comments 2
2020-02-15 10:15:32 +09:00
Katayama Hirofumi MZ
ba17d87636
[SYSSETUP] Improve resource ATTENTION comments
2020-02-15 09:52:58 +09:00
Katayama Hirofumi MZ
aec7a2bf5b
[SYSSETUP] Improve Japanese translation
2020-02-15 09:41:46 +09:00
Bișoc George
6ce72ba172
[SHELL32] Better fix for the "Version" string in the About-dialog ( #2349 )
...
The version string kernel number and the localized "version" word were too near in translation files. The patch fixes the problem introduced by #2276 .
Addendum to commit a57f7b50
.
2020-02-14 22:17:48 +01:00
Oleg Dubinskiy
44e9fee237
[SYSSETUP] Update Russian translation for Product Options page ( #2348 )
2020-02-14 19:22:48 +01:00
Katayama Hirofumi MZ
358f947975
[SHELL32] Rewrite SHAddToRecentDocs ( #2333 )
...
Rewrite shell32!SHAddToRecentDocs and use it in some applications.
Wine's SHAddToRecentDocs was not Unicode supported and unusable. I will dare to rewrite.
CORE-3588
2020-02-14 11:05:21 +09:00
Katayama Hirofumi MZ
9fc87dacdb
[SDK][INCLUDE] Fix and improve comctl32_undoc.h
2020-02-13 09:16:59 +09:00
Katayama Hirofumi MZ
3ef235e7cb
[SYSSETUP] Make Workstation default product option ( #2332 )
...
We set ReactOS Workstation as the default product option. That means we retargeted this project to Windows XP. Unattended Setup is supported.
CORE-13795
2020-02-12 19:29:56 +09:00
Katayama Hirofumi MZ
1cf564c25f
[SHELL32] Use background context if no item selected on File menu
...
CORE-9467
2020-02-12 12:14:15 +09:00
Katayama Hirofumi MZ
bc1519dd87
Shell Folders: Reject invalid characters ( #2328 )
...
Reject invalid input filename characters by using shell32!SHLimitInputEdit function and IItemNameLimits interface. Improve SHLimitInputEdit to sanitize paste.
CORE-11701
2020-02-12 09:18:24 +09:00
Katayama Hirofumi MZ
0a7a747d87
[SYSSETUP] Plan A: Also write ReportAsWorkstation value ( #2326 )
...
Write the ReportAsWorkstation value of the registry key HKLM\SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version.
The reason is shown at CORE-6611.
CORE-13795
2020-02-12 09:03:14 +09:00
Serge Gautherie
9f4e8ef25b
[SHELL32] DoGetProductType(): Check RegQueryValueExW() dwType ( #2331 )
2020-02-11 17:36:12 +01:00
Katayama Hirofumi MZ
ea8a6d6fb7
[SHELL32] Fix and improve SHLimitInputEdit
...
Use CallWindowProcW to call the subclass window procedure.
Use Wide functions explicitly.
CORE-11701
2020-02-11 14:10:38 +09:00
Katayama Hirofumi MZ
9e53e7cd5b
[SHELL32] DoGetProductType should check "LanmanNT" value.
...
CORE-13795
2020-02-11 13:11:58 +09:00
Katayama Hirofumi MZ
c6ed215eef
[SHELL32] Initial implement SHLimitInputEdit ( #2323 )
...
Popup balloon window is not implemented yet.
CORE-11701
2020-02-10 15:57:30 +09:00
Katayama Hirofumi MZ
48160c74b7
[SHELL32][SYSSETUP] Add Product Options page to ReactOS Setup ( #2315 )
...
- Add "Product Options" wizard page into ReactOS Setup.
- Implement CSIDL_Type_InMyDocuments CSIDL type.
- If the product type is workstation, then some special folders will be in My Documents.
CORE-13795
2020-02-10 11:10:42 +09:00
Timo Kreuzer
9efafd640f
[CRT] Import wine exception handling code
...
The code is mostly unchanged. This includes the following changes:
* Move all wine code to crt/wine to keep it separated from our own code
* Add a minimal winternl.h
* Remove the asm macros from wine/config.h
* Include wine/asm.h where required
* Fix the names of the exported functions (GCC uses thiscall now and no wrappers are used anymore)
2020-02-09 15:56:30 +01:00
Eric Kohl
85a854f6b5
[MSPORTS] Notify the installer of changes to the configuration of serial or parallel ports
2020-02-09 14:19:13 +01:00
Aaron Dewes
e5813c4644
Update german translation ( #2291 )
...
* Update German translations
* Update translation again
* More translations
* Some fixes in the german translation
* Some more fixes
* Little translation tweak
* Updates to 2nd review
* Little update
* Add back keyboard accel for IDS_OPENFILELOCATION.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-02-08 12:55:53 +01:00
Tibor Lajos Füzi
a16c02f283
[TRANSLATION] Update Hungarian translation of userenv ( #2293 )
2020-02-07 18:12:20 +01:00
Katayama Hirofumi MZ
4e964c7cb4
[SETUPAPI] Add Japanese translation
2020-02-07 21:45:59 +09:00
Bișoc George
a57f7b50c0
[SHELL32] Display the ReactOS version to the About dialog programmatically ( #2276 )
...
The current control parameters don't fit well with the version string since ReactOS migrated from SVN to Git. However, modifying the resource parameters doesn't fix the problem as well because the string itself is dynamic (as it can change in words specially the build architecture if the version build is AMD64 or x86 for example).
CORE-16571
2020-02-01 22:47:32 +01:00
Mark Jansen
09edc062ba
[SYSSETUP] Zero out propsheet data fields
...
This prevents +propsheet logging accessing uninitialized data
2020-01-29 22:58:42 +01:00
Mark Jansen
097355db60
[NEWDEV] Zero out propsheet data fields
...
This prevents +propsheet logging accessing uninitialized data
2020-01-29 22:58:42 +01:00
Mark Jansen
5b3e84f2ef
[BROWSEUI] Fix infinite recursion in autocomplete control
...
import wine commits 9c2217 and 644358, slightly tweaked to fit our code
2020-01-28 19:25:11 +01:00
Joachim Henze
7527483301
[NETID] Fix typo in de-DE.rc
...
addendum to 0.4.14-dev-854-g
b9426a3f0e
2020-01-27 20:11:25 +01:00
Eric Kohl
b9426a3f0e
[NETID] Fix validation of host and domain names and show proper error messages.
2020-01-26 21:00:12 +01:00
Mas4hmad
228eeb7d79
[TRANSLATION] Update Indonesian Translation ( #2268 )
...
- Update Indonesian translation for:
BROWSEUI.DLL, COMCTL32.DLL, DEVMGR.DLL, IEFRAME.DLL, NETID.DLL, SHELL32.DLL,
SYSSETUP.DLL, TIMEDATE.CPL, APPWIZ.CPL, ACCESS.CPL, DESK.CPL and TASKMGR.EXE.
- Add Indonesian translation for: MSHTML.DLL, OLEAUT32.DLL, INPUT.CPL and NTVDM.EXE.
2020-01-26 18:29:38 +01:00
Eric Kohl
6a67450893
[NETID] Implement DNS suffix and NetBIOS computer name support
...
- Load and store the non volatile host, domain and computer names instead of the volatile ones.
- Validate the domain name before it is stored.
- Update the full computer name whenever the host or domain name changes.
2020-01-26 10:04:44 +01:00
Mark Jansen
ea35843c30
[COMCTL] Use DIALOG instead of DIALOGEX resources
...
This is needed, because property sheets can modify the dialog resource,
and example code (and some existing applications) expect DIALOG.
One such application is the VB6 setup.
CORE-16650
2020-01-25 12:58:27 +01:00
Hermès Bélusca-Maïto
15bc263b07
[MSPAINT] Shorten the license string that is displayed in ShellAbout() dialog. CORE-12356
...
[MPLAY32][REGEDIT][TASKMGR][WORDPAD][BROWSEUI]
Use NULL for empty handles / string pointers in ShellAbout() calls.
2020-01-24 23:40:32 +01:00
Katayama Hirofumi MZ
cefc378b0d
[USERENV] Add 'See also' comments for translators
2020-01-24 21:48:22 +09:00
Katayama Hirofumi MZ
aacb9f0ccd
[SHELL32] Improve comments of shell folder paths
2020-01-24 21:32:25 +09:00
Katayama Hirofumi MZ
85474211a1
[SHELL32][USERENV] Update Japanese special folder names
2020-01-24 21:27:50 +09:00
Katayama Hirofumi MZ
257a701e9b
[BOOTDATA][USERENV] Improve and fix user profile info ( #2265 )
...
The international user profile info was inconsistent; thus TEMP and TMP environment variables were wrong. CORE-16635
2020-01-22 08:19:39 +09:00
Serge Gautherie
367a94211b
[ATL] Re-enable MSVC warning C4477 ( #2010 )
...
Follow-up to e410a122
.
2020-01-20 14:24:06 +01:00
Jose Carlos Jesus
8dfd2338f1
[TRANSLATION] Update Portuguese translation ( #2257 )
...
Improvements/updates for sysdm.cpl, devmgr.dll, hhctrl.ocx, netid.dll,
and add new Portuguese translation for shimgvw.dll .
2020-01-19 15:45:06 +01:00
Eric Kohl
9e2ae9b05c
[SYSSETUP] When the physical host name is set, also set an empty physical domain name
2020-01-19 13:34:32 +01:00
Eric Kohl
c645660384
[KERNEL32] Improvements to Get/SetComputerNameExW
...
- The ComputerNamePhysicalDnsDomain name type gets or sets the 'NV Domain' registry value.
- The ComputerNamePhysicalDnsHostname name type gets or sets the 'NV Hostname' registry value.
- IsValidComputerName: Enforce name length restrictions according to the name type.
2020-01-19 13:34:31 +01:00
Eric Kohl
0f4827edde
[NETEVENT] Netevent.dll does not have an entry point because it is a resource-only dll.
2020-01-19 13:34:29 +01:00
Serge Gautherie
63cf8625a0
[WBEMPROX] Always free 'new_path' ( #2056 )
...
Cherry-pick
a45dfea99a
CORE-13391
2020-01-18 18:53:11 +01:00
Eric Kohl
0a274da7cd
[DNSAPI] DnsQuery_W: Check names for invalid characters before querying the dns resolver.
2020-01-18 15:03:12 +01:00
Thomas Faber
aee6cbc50a
[SHELL] Add SHOpenFolderAndSelectItems to shlobj.h.
2020-01-18 13:10:35 +01:00
Hermès Bélusca-Maïto
e410a12242
[ATL30] Fix m_szAutoName definition and construction in Wine's ATL30 dll.
...
- Make the format actually MS-compatible: "ATL" followed by colon,
followed by hexadecimal digits of pointer.
- The MS counterpart of this DLL was delivered with Visual C++ 6.0 and
Windows 98+, so obviously it always was 32-bit and they never had a
64-bit version for it. But we do. So make the size of the m_szAutoName
buffer cross-compatible.
- See previous commit dbddd878 and the discussion in PR #2010 .
2020-01-15 01:21:25 +01:00
7OMI
66f6d051eb
[TRANSLATION] Add/update Hungarian translation for shell32, ieframe, browseui ( #2127 )
2020-01-14 18:52:38 +01:00
Katayama Hirofumi MZ
11851e1a81
[MSGINA] Improve Japanese status dialog ( #2248 )
...
Improve Japanese translation (IDD_STATUS).
2020-01-13 23:01:39 +09:00
Katayama Hirofumi MZ
61737d1b3f
[SHELL32] Improve Japanese folder property sheet ( #2247 )
...
Improve Japanese translation.
2020-01-13 22:47:26 +09:00
Katayama Hirofumi MZ
bd5681c027
[SHELL32][SHLWAPI] Improve Japanese file property sheet ( #2246 )
...
- Improve file property dialog (IDD_FILE_PROPERTIES).
- Translate shlwapi resource into Japanese.
2020-01-13 22:33:50 +09:00
Eric Kohl
7789ce1ebc
[DNSAPI] Answer queries for ip addresses before they are passed to the resolver cache.
2020-01-12 15:15:55 +01:00
Eric Kohl
2c6cba1fc8
[NETCFGX] Notify the installer of changes to the properties
2020-01-12 15:15:54 +01:00
Jose Carlos Jesus
10f9a1cb62
[TRANSLATION] [SHELL32] Improvements to Portuguese translation ( #2228 )
...
And minor adjustments because of text lenght.
2020-01-10 13:44:55 +01:00
Suraj K Suresh
fbc14d52cd
[PSDK] Support STRICT_TYPED_ITEMIDS in shdeprecated.idl. CORE-16385
2020-01-03 22:42:35 +01:00
Suraj K Suresh
ecb3ee5427
[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385
2020-01-03 22:42:34 +01:00
Hermès Bélusca-Maïto
cf7981fe4e
[LSASRV] Add parameter validation in LsapSetLogonSessionData().
2020-01-02 22:17:03 +01:00
Hermès Bélusca-Maïto
8210396cb4
[MSV1_0] Extend parameter validation in LsaApLogonUserEx2() and MsvpChangePassword(); fix crash in LsaApLogonUserEx2() when LogonDomainName points to a NULL string.
2020-01-02 22:16:58 +01:00
Maxim Smirnov
06eb8cda99
[SHELL32] Fix extra fixme ( #1975 )
...
This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`
2020-01-02 13:35:32 +01:00
Hermès Bélusca-Maïto
9ba5594599
Happy New Year 2020 to everyone!!
...
🎊 🎆 🍾 🥳
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
__, ,__) __, ,__) __, ,__) ░░▄████▄░▄███▄░▄████▄░▄███▄░░
(--|__| _ ,_ ,_ (--|\ | _ (--\ | _ _ ,_ ░░▀▀░▄██░██░██░▀▀░▄██░██░██░░
_| |(_||_)|_)(_| _| \|(/_(_|_) \|(/_(_|| ░░░▄██▀░░██░██░░▄██▀░░██░██░░
( | | ,_| ( (__| ░░██████░▀███▀░██████░▀███▀░░
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
███████████████████████████████████████████████████████████████████████████████
██████████████████▓▒▒▒▒▒▒▓▓█████████████████████████▓▓▒▒▒▒▒▒▓██████████████████
███████████████▒▒▒▒▓▓███▓▓▓▒▒░▒▓▓█████████████▓▒▒░▒▒▓▓████▓▓▒▒▒▓███████████████
█████████████▓░░░░░░░░░▒▒▓██████▓▒▒▒▓█████▓▒▒▒▓██████▓▒▒░░░░░░░░░▓█████████████
███████████▒▓░▒█████████▓▓▒░▒▓███▓▓▓▓▓▓▓▓▓▓▓▓████▒▒▒▒▓▓████████▓▒░▓▓███████████
██████████▒▒▓░▓██████████████▓▓▓▓▓█████▓▓▓▓▓▓▓▓▒▒███████████████▓░▓░▒██████████
█████████▓░▓█░▓██████████▓▒▒▒▒▓▓▓▓███████▓▓▓▓▓▓▓▓▓▒▒▓███████████▓░█▒░▓█████████
█████████▓▒██▒▒████████▒▒░░░░▒▒▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▒▒░█████████▒▒█▓▒▒█████████
█████████▓░██▓░▓█████▓▓▒▒░░░░▒▒▓▓▓▓████▓▓▓▓▓▓▓▓▒▒▓▓▓▓▓▒░░▓█████▓░▓█▓░▓█████████
██████████░▓██▒▒▓██▓▓▓▓▓▒▒▒▒▒▒▓▓▓▓██████▓▓▓▓▓▓▒▒▒▒▒▓▓▓▓▒▒░░███▓░▒██▒░██████████
██████████▒▒▓██▒▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████▓▓▓▒▒▒▒▒▒▒▒▒▓▒▒▒▒░░▓█▒▒██▓░▓██████████
███████████▒▒███▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓████▓▓▓▓▓▓▒▒░▒▒▒▒▒▒▒▒▒░░░▒███▒▓███████████
████████████▒▒█▓▓▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒▒░░░░▒▒░░░▒▒▒░░░▓██▒▒████████████
█████████████▒▒▒▒▒▒░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓▒▒░░░░░░░░░░░░░▒▒▒▓▒▒█████████████
██████████████░░▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒░░░░░░░░░▒░░▒░▒██████████████
██████████████▓▒░▒▒▒▒▒░░▒▒░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░▓███████████████
██████████████▓▒▓░░▒▒▒▒░░░░░░░░░░░░░░░░░▒▒▒▒▒▒░░░░░░░░░░▒░░░░░▓▒▓▓█████████████
███████████▓▒▓▓▓▒▒░░░░░▒▒░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░░▒▒▒█▒▒▓███████████
██████████▓▒▒█▓▓▒▒░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▓▒▒▒▒██▒▒▓██████████
█████████▓▒▓██▓▒▒▒▒░░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▒▒▒▒▒▒▓███▓▒▓█████████
████████▓▒▓███▓▒▒▒▒░░░▒░░░░░░▒░░░░░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▓▓▒▒▓▒▓██▓▒▓████████
███████▓▒▓███▒▓▓▒▒▒░░░░░▒░░░░░░▒░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▓▓▓▓▒▒██▓▒▓██▓▒████████
███████▒▒██▓▒▓█▓▓▒▒░░░░░░░▒░░░░░░▒░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▒▓▓▓▒▒▓███▓▒███▒▓███████
██████▓▒▓██▒▒███▓▒▒▒░░░░░░░░▒▒░░░░░▒▒░░░░░░░░▒▒░░▒▓▓▓▓▒▒▒▒▒▒▓█████▒▒██▓░▓██████
██████▒▒██▒▒█████▓▒▒▒░░░░░░░░░▒░░░░░░░▒░░░░▒▒░░▒▓▒▒▒▒▒▒▒▒▒▒████████▒▒██▒▒██████
██████▒▓██░▓██████▓▓▒▒▒░░░░░░░░░░▒░░░░░░░▒░░░░▒▒▒▒▒▒▒▓▓▒▒██████████▒░██▒▒██████
██████▒▒▓▓▒█████████▓▓▒▒▒░░░░░░░░░░▒▒░░░░▒▒▒▓░░░▒▒▒▒▒▓▓████████████▓▒▓▓░▒██████
██████▓░▒▒▒███████████▓▓▒▒░░░░▒▒▒░▒░▒▒▒▒░░▒▒▒▒▒▓▒░░▒▒██████████████▓░▒▒▒███████
███████▓▒░░▒█████████▓▒▒░░▒▓▓▒▒▒░░░░▒▒▒▓▒▓▒░░▒▒▓▓██▓▓▒░▒▒▓█████████▒░░▒████████
██████████▒░░░░░░░▒▒▓▓█████▓▓▒░░▒▓██▓▓████████▒░▒▒▓██████▓▓▒▒░░░░░░░▒██████████
███████████▓▒▒▒▓▓████▓▓▒▒▒░▒▒█████████████████████▒▒░▒▒▓▓▓███▓▓▒▒▒▒████████████
████████████████▓▓▓▓▓▓███████████████████████████████████▓▓▓▓▓▓████████████████
███████████████████████████████████████████████████████████████████████████████
███████████████████████████████████████████████████████████████████████████████
██████████████████████████████████████████████████████████▓░░▓████████░░░▓█████
███▒░░░░▒▓███████████████████████████████████████▒█████▓▒▒▓██▓▒▒▓████▓░█▓░▓████
███▒█████░▒███▓▒▒▒▒▒▓████▓▒▒▒▒▒▓█▓███▓▒▒▒▒▒▒▓██▓▒░▒▒▓▒▓█████████▓▒██▓▒█████████
███▒█████░▒█▓▒▒█████▒▒██▒▒▓████▓░▒██▒▒▓████▓▒▓██▓░▓██▓███████████▓▓██▓░░░▒█████
███▒█▓░░▒▓█▓▒▒▓▒░░▒▓▒░▒▓▒███████▒▒██▒████████████░███▓███████████▓▓██████░▒████
███▒██░▓███▓▒▓█████████▓▒███████▒▒██▒████████████░███▒▓██████████▓████████░▓███
███▒███░▒▓██▓▒▒████▓▒▓██▓▒▒▓██▓▒░▒██▓▒▒▓███▓▒▓███░████▓▒▒█████▒▒▓███▓▒▓██░▓████
███▒████▓░▓████▒▒▒▒▒██████▓▒▒▒▒▓█▓████▓▒▒▒▒▓█████▒███████▓▒▒▒▒▓███████▒▒▒▓█████
███████████████████████████████████████████████████████████████████████████████
2020-01-01 00:00:00 +01:00
Eric Kohl
5d3fe05505
[ADVAPI32] OpenSCManagerA/W: Set the last error even in case of success
...
This fixes a failure in the QueryServiceConfig2 api test.
2019-12-31 23:23:23 +01:00
Eric Kohl
17864b49e3
[LSASRV] LsarLookupSids: Return proper domain information for nameless domains
2019-12-31 17:59:10 +01:00
Victor Perevertkin
4bf76a659e
[WINHTTP] Initialize winsock upon WinHttpOpen
...
As it was done before syncing with wine-staging 4.18 (5bd6580
)
ROSTESTS-348
2019-12-30 14:57:58 +02:00
Eric Kohl
4bc5d44f06
[SAMSRV] SamrEnumerate...: Return STATUS_NO_MORE_ENTRIES if there is nothing to enumerate.
2019-12-29 17:29:43 +01:00
Hermès Bélusca-Maïto
a946146efc
[BROWSEUI] Remove unneeded header, addendum to d967b5aa
.
2019-12-29 16:23:37 +01:00
Hermès Bélusca-Maïto
da7cd27018
[NETAPI32] Improve some error traces.
2019-12-29 16:14:34 +01:00
Hermès Bélusca-Maïto
be19fda765
[SHELL32] Remove some trailing spaces; use explicitly global namespace for some functions.
2019-12-29 16:14:33 +01:00
Hermès Bélusca-Maïto
d967b5aa25
[BROWSEUI] Remove useless RegenerateUserEnvironment() call.
...
[SHELL32] Call RegenerateUserEnvironment() in WM_SETTINGCHANGE handler **ONLY** when lParam points to the L"Environment" string.
CORE-15147
2019-12-29 16:14:26 +01:00
Eric Kohl
eb7be70007
[SYSSETUP] Start the dnscache service after the network support has been installed
...
CORE-16558
2019-12-29 10:10:43 +01:00
Hermès Bélusca-Maïto
1ee511a10c
[SHELL32] Fix MSVC warning warning C4390 by adding a bit more debug info.
2019-12-25 19:02:48 +01:00
Hermès Bélusca-Maïto
16f64a9533
[SHELL32] Improve the displayed error on file copy / displacement + simplify code.
...
Also update the corresponding french translations, see CORE-16572.
And fix a regression introduced in 257e7307
that allowed again copying
or moving a directory into its sub-tree...
I also personally think that these checks must also be done within the
copy_files() / move_files() helpers instead?
2019-12-24 18:30:54 +01:00
Katayama Hirofumi MZ
ad319ef944
[SHIMGVW] Image Viewer transparent image fix ( #2165 )
...
If the pixel is transparent or translucent, fill the background with a checkered pattern. CORE-15287
2019-12-23 19:43:20 +09:00
Amine Khaldi
fba7694887
[XMLLITE] Sync with Wine Staging 4.18. CORE-16441
2019-12-23 00:56:19 +01:00
Amine Khaldi
a80c5a56e3
[WUAPI] Sync with Wine Staging 4.18. CORE-16441
2019-12-23 00:55:33 +01:00
Amine Khaldi
667d393424
[WTSAPI32] Sync with Wine Staging 4.18. CORE-16441
2019-12-23 00:54:46 +01:00
Eric Kohl
b4777797aa
[DNSAPI] Set proper record flags for query results and converted records
2019-12-22 14:40:18 +01:00
Eric Kohl
6c7878f35e
[DNSAPI][DNSRSLVR] Implement DnsGetCacheDataTable()
2019-12-22 11:21:04 +01:00
Eric Kohl
7908e2e41f
[NETAPI32][WKSSVC] Implement NetGetJoinInformation using the workstation service
2019-12-15 19:53:23 +01:00
Bișoc George
8ec05f5fa1
[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() ( #2113 )
...
ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found.
PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures.
CORE-16535
2019-12-12 08:24:20 +09:00
Jose Carlos Jesus
d347163fab
[TRANSLATION] Update Portuguese translation ( #2125 )
...
Add translation for joy.cpl and update it for comdlg32.dll.
2019-12-10 13:13:58 +01:00
Katayama Hirofumi MZ
2d4d3f5fce
[COMCTL32][USER32] Fix radio button regression ( #2146 )
...
PR #2135 (e329e83
) caused radiobutton regression. This PR will fix it.
- Clear DT_BOTTOM | DT_VCENTER flags upon calculating the button text height.
CORE-16552
2019-12-10 11:07:56 +09:00
jimtabor
0785633649
[SetupAPI] Sync to wine.
...
See CORE-16543.
2019-12-09 19:15:49 -06:00
Tibor Lajos Füzi
74ec76df08
[TRANSLATION] Fix hungarian translation for usetup & syssetup to use formal addressing / conjugation ( #2138 )
2019-12-09 02:09:31 +01:00
Eric Kohl
18a6d7c36f
[NETAPI32] Add RPC binding code to remaining functions that require explicit binding
2019-12-08 12:48:28 +01:00
Eric Kohl
3fe3f9acc7
[NETAPI32] Add RPC binding code to functions that require explicit binding
2019-12-08 10:52:37 +01:00