Commit graph

70252 commits

Author SHA1 Message Date
Joachim Henze 0ada4aee18 [0.4.7][COMCTL32] IP Address ctrl CORE-9853, LVIS-CUT CORE-16722, RC, compiler-warning
This ports back:
0.4.15-dev-7156-g 414f3da7a6 [COMCTL32] IP Address control: Fix background drawing (#6133) CORE-9853
0.4.15-dev-6773-g 855008d97b [COMCTL32] Invalidate LVIS_CUT selected items too (#4218) CORE-16722

And port back a few selected RC-improvements.

To compensate binary increase, I stripped a few TRACE's and debug-functions in the older branches within listview.c.
That fixed the following compiler warning for (GCC) *rls*-configuration:
warning: variable 'prev' set but not used [-Wunused-but-set-variable] within the function ranges_assert()

comctl32.dll binary therefore shrinks on all branches:
comctl32.dll master    RosBEWin2.2.2 GCC8.4.0dbg               2.001.408 (0.4.15-dev-7906-g1b85a5f)
comctl32.dll 0.4.14rls RosBEWin2.2.2 GCC8.4.0dbg  1.997.824 -> 1.982.976
comctl32.dll 0.4.14rls RosBEWin2.1.6 GCC4.7.2dbg  1.807.360 -> 1.794.560
comctl32.dll 0.4.13rls RosBEWin2.1.6 GCC4.7.2dbg  1.803.264 -> 1.790.464
comctl32.dll 0.4.12rls RosBEWin2.1.6 GCC4.7.2dbg  1.817.088 -> 1.803.264
comctl32.dll 0.4.11rls RosBEWin2.1.6 GCC4.7.2dbg  1.809.408 -> 1.796.096
comctl32.dll 0.4.10rls RosBEWin2.1.6 GCC4.7.2dbg  1.806.848 -> 1.793.536
comctl32.dll 0.4. 9rls RosBEWin2.1.6 GCC4.7.2dbg  1.806.848 -> 1.793.536
comctl32.dll 0.4. 8rls RosBEWin2.1.6 GCC4.7.2dbg  1.632.768 -> 1.618.944
comctl32.dll 0.4. 7rls RosBEWin2.1.6 GCC4.7.2dbg  1.602.048 -> 1.588.224
2024-04-18 02:05:54 +02:00
Joachim Henze d708fe0246 [0.4.7][COMCTL32] status.c sizegrip-backports 2024-04-15
This ports back 3 commits:

0.4.15-dev-7861-g a771729e69 [COMCTL32] Fix Status Bar Updating (#6696)
which fixes CORE-19497 'Regression, part of the statusbar with the sizegrip is not redrawn properly'
which regressed on this branch by 0.4.7-release-259-g 1c40222cc2

also port back:
0.4.13-dev-888-g 76dfa2b284 [COMCTL32] Checking size grip bounds in x-axis only (#991)
0.4.13-dev-887-g b9ddad0bbb [COMCTL32] Hide size grip when the parent window is maximized CORE-15240 (#991)

To compensate binary increase, I stripped a few TRACE's and the debugstr_t() function in the older branches.
comctl32.dll binary therefore has a tendency to shrink a tiny bit on most branches:
comctl32.dll master    RosBEWin2.2.2 GCC8.4.0dbg               2.001.408 (0.4.15-dev-7906-g1b85a5f)
comctl32.dll 0.4.14rls RosBEWin2.2.1 GCC8.4.0dbg  1.998.336 -> 1.997.824
comctl32.dll 0.4.14rls RosBEWin2.1.6 GCC4.7.2dbg  1.807.872 -> 1.807.360
comctl32.dll 0.4.13rls RosBEWin2.1.6 GCC4.7.2dbg  1.804.800 -> 1.803.264
comctl32.dll 0.4.12rls RosBEWin2.1.6 GCC4.7.2dbg  1.817.600 -> 1.817.088
comctl32.dll 0.4.11rls RosBEWin2.1.6 GCC4.7.2dbg  1.809.920 -> 1.809.408
comctl32.dll 0.4.10rls RosBEWin2.1.6 GCC4.7.2dbg  1.806.848 -> 1.806.848
comctl32.dll 0.4. 9rls RosBEWin2.1.6 GCC4.7.2dbg  1.806.848 -> 1.806.848
comctl32.dll 0.4. 8rls RosBEWin2.1.6 GCC4.7.2dbg  1.633.792 -> 1.632.768
comctl32.dll 0.4. 7rls RosBEWin2.1.6 GCC4.7.2dbg  1.602.048 -> 1.602.048
2024-04-15 18:28:53 +02:00
Joachim Henze d6715ddcad [0.4.7][REGEDIT] Fix condition of enabling load/unload hive menu item (#6251), + RC-stuff
Port back:

0.4.15-dev-7362-g 1aeac0bf24 [REGEDIT] Fix condition of enabling load/unload hive menu item (#6251) CORE-19298
which was an addendum to 0.4.15-dev-243-g 4d1cd72317 (where I ported back parts earlier from)

and ports back various unrelated RC-tweaks, e.g.
partially 0.4.15-dev-7887-g 64a59a17b5 [REGEDIT] RC-tweak, only the it-IT-addendum
0.4.15-dev-6940-g 03dc2ef724 [REGEDIT] Update Romanian (ro-RO) translation (#5961)
and a few others

regedit.exe binary does shrink a tiny bit on all branches:

regedit.exe master          RosBEWin2.2.2 GCC8.4.0 dbg x86            1.049.600 (0.4.15-dev-7886-g938a39a)
regedit.exe releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86  755.712 ->  755.200
regedit.exe releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86  750.080 ->  749.056
regedit.exe releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86  742.400 ->  741.888
regedit.exe releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86  744.448 ->  743.424
regedit.exe releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86  744.448 ->  743.424
regedit.exe releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86  744.448 ->  743.424
regedit.exe releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86  744.448 ->  743.424
regedit.exe releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86  743.936 ->  742.912
regedit.exe releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86  743.936 ->  742.912
2024-04-12 09:00:58 +02:00
Joachim Henze 7345dc1151 [0.4.7][COMDLG32] RC Backports 2024-04-11 + fontdlg.c
This ports back:

*PARTIALLY* 0.4.15-dev-7884-g d72d61fe47 [COMDLG32] *.rc Improve translations (#6729)

0.4.15-dev-3493-g a36cc8054d [COMDLG32] Fix ico3 not shown in Print dialog (#2831)

0.4.15-dev-95-g 7895704952 [COMDLG32] Enlarge list area in CHOOSE_FONT dialog (#2670)

*PARTIALLY* 0.4.9-dev-189-g 45ed51c1ba [COMDLG32] Sync with Wine Staging 3.3. CORE14434.
This picks only a few lines within fontdlg.c where the internal select_combo_item()-helper-func was introduced and used.

As always pick some selected/improved translations here and there from newer branches.
Furthermore strip the accelerators from the pshhelp-buttons *in the older branches*, not in master. They do collide in so many languages,
and since the old releases will never get any help-functionality ported to, they are actually counterproductive.
Stripping them is not so easy though, because some dlgs, especially the file-open-dlgs get dynamically resized at runtime
by the height of that button, and by the height of the read-only-checkboxes. Ugly stuff.
Maybe they can be hidden later, and de-stringified to save a few bytes and missing translations.
Not important for today, maybe something to consider in 10years from now.
The stripped accelerators can then serve as a reminder for that.

Binary size of comdlg32.dll shrinks slightly for all branches:

comdlg32.dll master          RosBEWin2.2.2 GCC8.4.0 dbg x86               1.011.712 (0.4.15-dev-7874-g0cfc9ab)
comdlg32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86  1.008.128 -> 1.006.080
comdlg32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86    974.336 ->   972.288
comdlg32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86    974.336 ->   972.288
comdlg32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86    958.464 ->   956.416
comdlg32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86    944.128 ->   941.568
comdlg32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86    941.568 ->   939.520
comdlg32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86    914.432 ->   912.384
comdlg32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86    914.944 ->   912.384
comdlg32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86    899.584 ->   896.512
2024-04-11 02:01:25 +02:00
Joachim Henze fa855b5b71 [0.4.7][I8042PRT] Add service registry entry for the driver CORE-17819
CORE-17819 This allows Microsoft VirtualPC 2004/2007 to boot LiveCD SAFEMODE to desktop,
the regular mode booted also without that addition already.

Fix picked from 0.4.15-dev-1537-g b1c460d34e
This commit was part of a much bigger PR3396, which I don't pick entirely today.
For CORE-17819 only this part is actually needed.
2024-03-29 15:22:41 +01:00
Joachim Henze 00925edc13 [0.4.7][SHELL32] RC-backports 2024-03-27
This backport covers tons of improvements within the Shell32-RCs.
E.g. It improves the IDD_FILE_PROPERTIES and IDD_FOLDER_PROPERTIES significantly in the older releases for all langs, but also the Run-Dlg and IDD_OPEN_WITH.

The following master commits are part of it:

0.4.15-dev-7838-g e3bfcdf9e2 [SHELL32] pl-PL.rc: Fix IDD_FILE_PROPERTIES & IDD_FOLDER_PROPERTIES (#6678)

Some 100%-safe parts of the yet uncommitted PR6657 [SHELL32] Update Romanian (ro-RO) translation. I didn't pick all of that yet, as most parts are still WIP.

0.4.15-dev-7833-g ee0329e0e2 [SHELL32] *.rc: accelerator fixes, drive-properties bg-BG and fr-FR (#6591).
   I addressed many of the FIXMEs already in the backport so this state is superior to master even.

0.4.15-dev-7216-g d387c799ed [SHELL32] 640x480-ify four dialogs (#6004) IDD_DRIVE_PROPERTIES, IDD_DRIVE_TOOLS, IDD_DRIVE_HARDWARE, IDD_FOLDER_CUSTOMIZE

0.4.15-dev-6333-g fa429c8e2f [SHELL32] *.rc: Use 1996 as birth year in IDD_ABOUT for consistency (this leaves now only the cmd-part left to be done in this context)

0.4.15-dev-5993-g a5bff2457a [SHELL32] Improve disk properties pie chart (#5239) CORE-18906
(I picked only the rc changes for that, but left the code changes out of the backport, the result is still appealing to my eyes)

0.4.14-dev-1492-g 4af7888b29 [SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs

Important for me is also:
0.4.11-dev-30-g 39dc3cdaf6 [SHELL32] height of pickicon (#824) CORE-14974
I ported that back into 0.4.10-RC-21-g 38462453e2 already, because in releases/0.4.10 it fixed a regression (which isn't the case for the older branches)
Because that is an important preparation-step for when I will port back Katayamas font-metrics-fixes from 0.4.10-dev'ing later. It doesn't fix anything in the older branches until then.

partially 0.4.9-dev-794-g bf88116252 I took the 70 y-pos for the 3 buttons, and still managed to fix CORE-12548 properly. I used shorter strings here instead (which will bring us closer to Windows btw)

In releases/0.4.14 and lower I stripped the en-GB.rc,
because that was (aside from 3-4 lines of forgotten sync) the same content to en-US.rc still. Real intended changes reached en-GB.rc not before 0.4.15-dev.
Furthermore this translation does not exist in 2k3sp2 afaik.
Also strip GUI-controls for some other features that are yet unimplemented in older ros versions, and that I won't port back, namely:
- drive-indexing/compression-checkboxes and "Disk Cleanup"-button in IDD_DRIVE_PROPERTIES
- controls for GUI-versions of "Backup" and "Defragmentation" in IDD_DRIVE_TOOLS DIALOGEX
- and the related icons for the above

In releases/0.4.9 and lower I additionally stripped the IDD_FOLDER_OPTIONS_GENERAL tab, because it is a 100% dummy there without any functionality.
First bits of its functionality was implemented only during 0.4.10-dev'ing, and I don't intend to port that back further.
It's not worth wasting my time with tweaking its appearance further in those older versions.
We can use those freed bytes to port back more helpful stuff instead later.

Binary size of shell32.dll shrinks for all branches:

shell32.dll master          RosBEWin2.2.2 GCC8.4.0 dbg x86               10.579.968 (0.4.15-dev-7836-g72a27e6)
shell32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86  9.316.684 ->  9.201.664
shell32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.345.024 ->  9.230.336
shell32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.199.616 ->  9.086.976
shell32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.146.368 ->  9.031.680
shell32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.077.248 ->  8.954.880
shell32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.069.568 ->  8.945.152
shell32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.821.760 ->  8.618.496
shell32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.736.256 ->  8.536.576
shell32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.663.040 ->  8.466.944
2024-03-27 21:52:24 +01:00
Joachim Henze 3e7b79ed85 [0.4.7][SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file
This picks:
0.4.11-dev-728-g 9baf05f164
please notice that CORE-15353 'NOTEPAD does not open text file via openWith-dialog if the filepath contains spaces'
did not actually affect the older branches releases/0.4.7 - releases/0.4.9
I picked this solely for the sake of slightly simplifying the code.

-------------

Also take the COpenWithMenu.cpp-part of 0.4.10-dev-316-g 3904fd6257
with me, not to fix any bug in the older releases, but also for the sole reason of
it simplifying the code a bit

binary size of shell32.dll shrinks slightly:

releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.072.128 -> 9.069.568
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.824.832 -> 8.821.760
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.738.816 -> 8.736.256
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.666.624 -> 8.663.040
2024-03-04 14:27:03 +01:00
Joachim Henze 734e4958da [0.4.7][SHELL32] Ports from 0.4.8-dev: e.g. Drive Capacity CORE-14201, and Alt+Enter (#155)
This ports back the following master-commits:

0.4.8-dev-1090-g 175e78e50f [SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes.
   FTR: usernotification.rgs does not exist yet in releases/0.4.7, therefore left out

0.4.8-dev-670-g 6d9a0d0fd4 [SHELL32] CDrivesFolder: Fix showing the drive capacity. (in MyComputer Details-View) CORE-14201

0.4.8-dev-514-g a3797dba7a [SHELL32] Deduplicate MAX_PROPERTY_SHEET_PAGE and AddPropSheetPageCallback().
   FTR: The original master-commit referenced the unmerged PR179, but that is a wrong linking!

0.4.8-dev-239-g c2bdad2981 [SHELL32] Fix show properties with Alt+Enter (#155)

0.4.8-dev-32-g fe6d46f86e [SHELL32] Properly set case -714 as TBN_DRAGOUT.
   FTR: The original master-commit (erroneously?) referenced PR94, and CORE11799. But those deal with Clang-related changes and do not contain this part (anymore?).

no change in binary size for both compilers in dbg configuration:

releases/0.4.8 RosBEWin2.1.6 GCC4.7.2    dbg x86               8.738.816
releases/0.4.7 RosBEWin2.1.6 GCC4.7.2    dbg x86  8.666.624 -> 8.666.624
releases/0.4.7 RosBEWin2.1.6 MSVC2010SP1 dbg x86  7.455.232 -> 7.455.232
2024-02-25 18:09:00 +01:00
Joachim Henze ec0a98776d [0.4.7][BTRFS][SETUPAPI][SHELL32] It is _WIN32_WINNT, not WIN32_WINNT CORE-12589 CORE-12580
This is *no* functional change: I verified with a #pragma message "test"
locally within all those blocks that the compilers output does not change
before and after those changes.
The 3 binaries do not change in size.
After this commit no such issue remains in releases/0.4.7

[BTRFS] It is _WIN32_WINNT, not WIN32_WINNT CORE-12589
This is a partial port of:
0.4.10-dev-36-g c7806a6b29 CORE-12589 'drivers/filesystems/btrfs/fsctl.c: 1 _WIN32_WINNT is misspelled as WIN32_WINNT'
------------
[SETUPAPI] It is _WIN32_WINNT, not WIN32_WINNT
This is a pure backport of
0.4.8-dev-139-g 067bb2fcef [SETUPAPI] it is _WIN32_WINNT, not WIN32_WINNT (#125) CORE-12580
------------
[SHELL32] It is _WIN32_WINNT, not WIN32_WINNT

This is *no* backport of 0.4.8-dev-251-g 57aa1f1fc6 [SHELL32] shellpath.c: it is _WIN32_WINNT, not WIN32_WINNT (#129) CORE-12580
but instead I deleted the workaround-blocks in [SHELL32] shellpath.c entirely, because they do depend on global variables which also do not exist in releases/0.4.7.

CORE-12580 is now completely covered, except the unrelated 'reminder comment' which was added to [SDK].
2024-02-25 07:59:05 +01:00
Joachim Henze 861b514095 [0.4.7][SHELL32] Backport format+logging-trivia, ARRAYSIZE/_countof, x64
Picks various trivial improvements from newer branches, does not fix specific JIRA-tickets and also doesn't
*entirely* cover a specific PR, therefore none of those are mentioned here.
Main motivation is to reduce large scale white-noise diff between the branches, to make
future commits diffs (with some fixes that actually matter) smaller in size and therefore easier to review.

Specifically:
- large-scale formatting & logging improvements, including but not limited to 0.4.15-dev-7653-g 6f91b6c0fe
- strip trailing whitespace
- also typos like 'unkown', missing \n as it was
  part of 0.4.15-dev-6323-g 3854a5d8e9 and
  0.4.15-dev-4492-g 03422451b3
  (I left out the MOUSE_MOVE-one from that, because I consider the missing \n there intentional)
- ports back many usages of ARRAYSIZE/_countof as it was added as part of some commits from Hermes, e.g.:
  *partial* pick of 0.4.13-dev-622-g 8a30801516 and
  *partial* pick of 0.4.15-dev-3642-g 83be315abf (I left out the literals here for now, ...
    I *might* pick them later on their own, but not now. I first want to verify their isolated impact on all compilers generated file-sizes.
    Some of those changes would even increase the binary size, especially those where the same literal is used multiple times,
    because string-pooling is currently not enabled for all toolchains and configurations.)
- COpenWithMenu.cpp: strip double-semicolon
- COpenWithMenu.cpp && folder_options.cpp: add \n to some dbg-prints without increasing their length
- CFSDropTarget.cpp: add \n to some dbg-prints, strip some good-path-traces that are no longer present in master in return to avoid size increase, fix indentation
- CShellLink.cpp: add \n to some dbg-prints without increasing their length
- iconcache.cpp: fix wrong indentation
- 0.4.10 and lower: shellpath.c Strip some TRACEs with wrong format-strings, strip unused string my_DocumentsW
- 0.4.8/0.4.7 *partially* 0.4.9-dev-126-g 0182dcd71b x64 DWL->DWLP (just the SHELL32 parts)
- just 0.4.7: *partially* 0.4.8-dev-273-g e83592920b [SHELL32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings.
               shellpath.c: instead of ifdefing them like the master commit did, I deleted them entirely within 0.4.7, because the ifdefs for surrounding code are not proper.
               I might adapt those ifdefs later, but not within this large back-port-commit which picks only 100%-bullet-proof things.

binary size of shell32.dll has tendency to shrink slightly, which is caused solely by the logging changes:

master          RosBEWin2.2.2 GCC8.4.0 dbg x86               10.538.496 (0.4.15-dev-7640-gbdcfc6b)
releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86  9.317.888 ->  9.316.684
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.345.024 ->  9.345.024
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.201.152 ->  9.200.640
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.146.880 ->  9.146.880
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.077.760 ->  9.077.248
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86  9.074.176 ->  9.072.128
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.825.856 ->  8.824.832
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.740.864 ->  8.738.816
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86  8.668.160 ->  8.666.624
2024-02-25 01:57:39 +01:00
Joachim Henze 1de4e19fa9 [0.4.7][NETSHELL] Double-click and mostly RC-improvements, x64
0.4.15-dev-7606-g 874b5a4e00 [NETSHELL] Trivial tweaks (#6484)
0.4.15-dev-7126-g a6341b49d8 [NETSHELL] 640x480-ify complete that module (#6109)
0.4.15-dev-7018-g cbc60aa07a [NETSHELL] Double click on component should open properties (#6008) CORE-19330
PARTIALLY 0.4.15-dev-6857-g 55563fa891 [NETSHELL] IDD_NETPROPERTIES must fit 640x480 CORE-19284 (#5899) (I left out the 3 accelerators)
and a tiny fraction of 0.4.9-dev-126-g 0182dcd71b [x64][NETSHELL] GWL_ -> GWLP_

Also port back some other rc tweaks and strip EOL-whitespaces and the IDS_NET_REPAIR from the context menu which is still unimplemented in the older branches
and for which I do never intend to port back the implementation.

binary size of netshell.dll shrinks slightly on all branches:

master          RosBEWin2.2.2 GCC8.4.0 dbg x86             659.968 (0.4.15-dev-7598-geb55d98)
releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86  644.608 -> 640.512 (netshell.dll is one of the rare modules where GCC8.4.0 produces more efficient output than GCC4.7.2)
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86  687.104 -> 682.496
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86  685.568 -> 681.472
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86  666.624 -> 662.016
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86  657.408 -> 653.312
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86  576.512 -> 572.928
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86  576.512 -> 572.416
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86  576.512 -> 572.416
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86  576.000 -> 571.904
2024-02-11 23:40:05 +01:00
Joachim Henze 89ea247468 [0.4.7][JOY] Add IDCANCEL action to MainPageProc (#6346) CORE-19424 + RC tweaks
This ports back:
0.4.15-dev-7456-g cbc3ee2287 CORE-19424 "Game Controller" control panel applet : ESC does not close
and a few trivial rc improvements.

Tendency for binary size is to shrink slightly, but manages to only reach the next lower quantum in releases/0.4.14:

master          RosBEWin2.2.2 GCC8.4.0 dbg x86                144.384 (0.4.15-dev-7557-gc858429)
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86     133.632 -> 133.120
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86     125.440 -> 125.440 (interesting: 0.4.12 & 0.4.13 do have the exact same code *within* this module)
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86     127.488 -> 127.488 (interesting: 0.4.12 & 0.4.13 do have the exact same code *within* this module)
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86     125.952 -> 125.952
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86     125.952 -> 125.952
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86     125.952 -> 125.952
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86     125.952 -> 125.952
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86     125.952 -> 125.952

I am not aware yet which exact commit in the toolchain or dependent libs made it shrink from releases/0.4.12 to releases/0.4.13
2024-02-07 22:53:14 +01:00
Joachim Henze 0e7278a438 [0.4.7][NETCFGX] RC-fixes, Radiobuttons, optimization, x64
This backports the following commits:
0.4.15-dev-7247-g 8f349ab3c2 [NETCFGX] Create only one "Alternative Configuration" tab CORE-19328
0.4.15-dev-7124-g 6a7315228c [NETCFGX] IDD_TCPIP_ALTCF_DLG Fix radiobutton (#6083) CORE-19327
0.4.15-dev-7099-g 5012c6a2b0 [NETCFGX] IDD_TCPIP_BASIC_DLG Radiobuttons need 2 arrow-down-presses instead of one (#6049) CORE-19327
*PARTIALLY* 0.4.15-dev-7023-g a95863b132 [NETCFGX] Half-implement TCP/IP alternate configuration (#6009) (I picked only some formatting, and the RC changes from that, not the initialization implementation yet) CORE-19331
0.4.15-dev-7015-g 9e42809fc1 [NETCFGX] Use CheckDlgButton/IsDlgButtonChecked instead of BM_GETCHECK/BM_SETCHECK CORE-19331
0.4.15-dev-6990-g 4939936165 [NETCFGX] Strip 2x wrong WS_DISABLED style on dlgs (#5987)
0.4.15-dev-6904-g 1997c12252 [NETCFGX] 640x480-ify (#5946)
0.4.15-dev-6858-g 0177b1af45 [NETCFGX] *.rc 640x480-ify IDD_TCPIP_BASIC_DLG and IDD_TCPIP_ALTCF_DLG (#5902)
a fraction of 0.4.9-dev 0182dcd71b only the [NETCFGX] x64 fixes DWL->DWLP
0.4.8-dev-943-g 817beaf9c5 [NETCFGX] Rename 'Network connection' to 'Network Connection'. (#345)

The binary size shrinks slightly on all branches:

master          RosBEWin2.2.2 GCC8.4.0 dbg x86                602.112 (0.4.15-dev-7264-ga328886)
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86     570.880 -> 568.832
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86     569.344 -> 567.808
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86     548.864 -> 547.328
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86     502.272 -> 500.736
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86     452.096 -> 450.560
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86     452.096 -> 450.560
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86     452.096 -> 450.560
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86     452.096 -> 450.560
2024-02-04 20:47:51 +01:00
Joachim Henze 9880739084 [0.4.7][NTOS:MM] Fix Regression, "Precision" demo executable doesn't load CORE-12400 (#503), + follow-up (#5002)
This fixes the "Farbrausch - Precision" demo
https://files.scene.org/view/parties/2006/assembly06/in64/fr-048_precision_by_farbrausch.zip
from not loading any longer.
It broke by SVN r72989 == git 63bbaff803

The fix is a combined backport of 2 commits:
1.)
0.4.10-dev-136-g c7eb46d9fd (#503)
where Mark Jansen aimed to fix loading executables treated with the binary packer "mPress".
This is what fixed the "Farbrausch - Precision" demo as well.
Marks commit back then referenced CORE-12582 and CORE-14556 although it never was enough to solve any of the 2 tickets entirely.
I do just reference them here again to preserve that ancient (questionable) linkage.

2.)
Since Marks commit back then introduced a very severe regression as well, I do have to port back also the following commit:
0.4.15-dev-5589-g 0d4a8d0ea6 (#5002)
to prevent me to introduce into older releases the bug
CORE-18797 "SizeOfRawData of BSS section should not be processed"
(which had many duplicates, e.g. Doom95, compiled with Watcom-C-compilers would not longer work without that)

-------------

I felt the need to underline that I have tested that porting back the following commit
0.4.10-dev-474-g dfff8ed0d8
is *NOT* needed in the older branches to prevent
CORE14838 "Antivir 6 deadlocks RtlpWaitForCriticalSection when 'scanning the process list'"
although the JIRA-tickets referenced the same unhiding commit 0.4.10-dev-136-g c7eb46d9fd for the master branch.
I consider that as being a temporary workaround that has been applied to master, which seems to be not needed in the older branches,
and it may be possible that we may get rid of that on master too at some point in the future.

------------

NTOSKRNL binary size unchanged:
releases/0.4.9 RosBEWin2.1.6 GCC4.7.2dbg  4.311.552 -> 4.311.552
releases/0.4.8 RosBEWin2.1.6 GCC4.7.2dbg  4.296.704 -> 4.296.704
releases/0.4.7 RosBEWin2.1.6 GCC4.7.2dbg  4.231.168 -> 4.231.168
2023-12-18 15:06:11 +01:00
Joachim Henze 72b1898b1b [0.4.7][TASKMGR] Some RC backports (2023-12-03) (#5949) (#5978)
ports back:
0.4.15-dev-7082-g 628d4a92e9 [TASKMGR] Fix text cutoff statusbar2 CPU%, improve statusbar3 Mem (#5978)
0.4.15-dev-6928-g b693eddd74 [TASKMGR] Harmonize and beautify the borders in performance tab (#5949)

Note:
Regarding (#5978) I intentionally did not port-back the chinese colons for the CPU% in the statusbar,
because the older release-branches do structurally use the english : still
here and in other controls.

Binary size shrinks slightly on all branches:

master taskmgr.exe RosBEWin2.2.2 GCC8.4.0dbg             695.808 (0.4.15-dev-7112-gd795021)
0.4.14 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  548.864 -> 547.840
0.4.13 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  542.208 -> 541.184
0.4.12 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  543.232 -> 542.720
0.4.11 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  543.232 -> 542.720
0.4.10 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  530.432 -> 529.920
0.4. 9 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  530.432 -> 529.920
0.4. 8 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  530.432 -> 529.920
0.4. 7 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  529.408 -> 528.896

       taskmgr.exe MS XPSP3 german                                           140.800 Bytes
0.4.14 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=de-DE  109.056 Bytes -> 109.056 Bytes (my current taskmgr of choice)
0.4. 8 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US  105.984 Bytes -> 105.984 Bytes
0.4. 7 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US  105.472 Bytes -> 105.472 Bytes
2023-12-03 01:00:05 +01:00
Joachim Henze ac630552e2 [0.4.7][PARPORT] Fix I/O port length check, [REACTOS] Logging & formatting, e.g. CORE-14388 CORE-19105
Ports back a real fix:
0.4.15-dev-1173-g ba09834c5e [PARPORT] Fix I/O port length check

Ports back logging and formatting:
0.4.15-dev-6794-g 4eace8d762 [IPHLPAPI] Silence obsolete FIXME in GetAdaptersAddresses (#5834) CORE-14388
0.4.15-dev-6438-g b12ab486d8 [MUP] Mute DPRINT1's that slow down shared folder accesses (#5545) CORE-19105

And mutes some other loggings as well for stuff, that I either never want to port back, e.g. the IMM-implementations,
or which is not really helpful in the older branches:
fixme:(win32ss/user/user32/misc/imm.c:446) WINNLSEnableIME is UNIMPLEMENTED!
fixme:(../dll/win32/iphlpapi/address.c:290) GetAdaptersAddresses - Semi Stub: Family 2, Flags 0x0000002e, Reserved 00000000, pAdapterAddress 00000000, pOutBufLen 0143EBD4.

when browsing the startmenu:
fixme:(dll/win32/comctl32/toolbar.c:394) [00080086] TBSTYLE_REGISTERDROP not implemented
fixme:(dll/win32/comctl32/toolbar.c:5636) [00080086] response 2045774661 not handled to NM_CUSTOMDRAW (CDDS_PREERASE)
fixme:(dll/win32/comctl32/toolbar.c:5673) [00080086] response 3225142 not handled to NM_CUSTOMDRAW (CDDS_POSTERASE)
fixme:(dll/win32/comctl32/toolbar.c:5636) [000200BA] response 9 not handled to NM_CUSTOMDRAW (CDDS_PREERASE)
fixme:(dll/win32/comctl32/toolbar.c:5636) [00080086] response 2288892 not handled to NM_CUSTOMDRAW (CDDS_PREERASE)
fixme:(dll/win32/comctl32/toolbar.c:5673) [00080086] response 3291448 not handled to NM_CUSTOMDRAW (CDDS_POSTERASE)

and a bigger block regarding the parallel port during booting:
(drivers/parallel/parport/parport.c:127) Parport DriverEntry
(drivers/parallel/parport/fdo.c:391) AddDevice(B0B50548 B0FED980)
(drivers/parallel/parport/fdo.c:25) AddDeviceInternal()
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:582) IRP_MJ_PNP / IRP_MN_FILTER_RESOURCE_REQUIREMENTS
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:546) IRP_MJ_PNP / IRP_MN_START_DEVICE
(drivers/parallel/parport/misc.c:42) Calling lower device B0FED980
(drivers/parallel/parport/fdo.c:116) FdoStartDevice ()
(drivers/parallel/parport/fdo.c:160) Port: BaseAddress 0x378  Length 8
(drivers/parallel/parport/fdo.c:160) Port: BaseAddress 0x778  Length 8
(drivers/parallel/parport/fdo.c:174) Interrupt: Level 20  Vector 55
(drivers/parallel/parport/fdo.c:195) New LPT port: Base 0x378
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:586) Unknown minor function 0x9
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:586) Unknown minor function 0x14
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:564) IRP_MJ_PNP / IRP_MN_QUERY_DEVICE_RELATIONS / BusRelations
(drivers/parallel/parport/fdo.c:351) FdoQueryBusRelations()
(drivers/parallel/parport/fdo.c:233) FdoCreateRawParallelPdo()
(drivers/parallel/parport/fdo.c:378) Done
(drivers/parallel/parport/pdo.c:165) PdoPnp()
2023-11-05 13:56:03 +01:00
Joachim Henze f49cead384 [0.4.7][TASKMGR] Mainly Graph-stuff backports 2023-10-31
This backports the following commits:
0.4.15-dev-6770-g ddd1d19b3f [TASKMGR] Get rid of cplusplus extern c (#5808)
partially 0.4.15-dev-6120-g 6e77747b30 [TASKMGR] Simplify tray icon code
0.4.15-dev-6114-g 9a6c85f68a [TASKMGR] Fix PerfDataDeallocCommandLineCache, part of CORE-18014 (unresolved still)
0.4.15-dev-6113-g 7989e3f26c [TASKMGR] GraphCtrl_Dispose: Delete hdcGraph first, part of CORE-18014 (unresolved still)
0.4.15-dev-6112-g dc14a9f6e0 [TASKMGR] GraphCtrl: Use DeleteDC instead of DeleteObject to delete inst->hdcGraph, part of CORE-18014 (unresolved still)
partially 0.4.15-dev-4994-g 15a0f7adb0 picked a tiny part from PR4657 (I picked only the refactoring to switch-statement, no functional changes. Especially NOT the formatting changes which would require the additional winnls.h-include)
0.4.15-dev-3737-g f8faa0b660 [TASKMGR] Fix a heap corruption bug (#4311), just an addendum to PR4141 which is picked with this backport as well. Older branches were never affected.
partially 0.4.15-dev-3514-g 1c82bf0324 [TASKMGR] Avoid freezing in getting icons, from (PR4180) CORE17894. I picked only the 1000ms->100ms part and the stripping of WM_QUERYDRAGICON call. Therefore I don't consider CORE17894 as fully covered.
0.4.15-dev-3486-g 545e1190f2 [TASKMGR] Avoid hangs as much as possible (#4166) CORE17894
partially 0.4.15-dev-3483-g 403222dd4f [TASKMGR] Preserve graphs history on resizes (#4141). I left aside the structs type renaming and OOM-Handling upon graph creation. Picked all the logical changes though.
0.4.15-dev-3269-g 0ed04e3640 [TASKMGR] Make performance graph grid scroll (#3581)
0.4.15-dev-3268-g a4ab9a1e19 [TASKMGR] Formatting only (#3581). Covers the last bits of that PR.

Main motivation was getting the toggling of ShowKernelTimes in the Performance tab
switch on and off in realtime without introducing gaps in the graph.
It also makes the grid scroll together with the data, like on Windows.

Most other parts I picked solely for their binary-shrinking effect.
I decided to strip the ID_HELP_TOPICS from the rc files, as this was not implemented,
and I would never port that back later. So it is one less non-functional-button in the older branches.
I favored memset() over Zeromemory() in this usermode-app everywhere, and favored for (;;) over while(1).

Binary size shrinks slightly on all branches:

master taskmgr.exe RosBEWin2.2.2 GCC8.4.0dbg             696.832 (0.4.15-dev-6820-gb3194e3)
0.4.14 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  549.888 -> 548.864
0.4.13 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  542.720 -> 542.208
0.4.12 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  545.792 -> 543.232
0.4.11 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  545.792 -> 543.232
0.4.10 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  532.480 -> 530.432
0.4. 9 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  532.480 -> 530.432
0.4. 8 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  532.480 -> 530.432
0.4. 7 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  531.456 -> 529.408

       taskmgr.exe MS XPSP3 german                                           140.800 Bytes
0.4.14 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=de-DE  110.080 Bytes -> 109.056 Bytes (my current taskmgr of choice)
0.4. 8 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US  108.032 Bytes -> 105.984 Bytes
0.4. 7 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US  107.520 Bytes -> 105.472 Bytes
2023-10-31 21:09:58 +01:00
Joachim Henze 89f60aba16 [0.4.7][SDK:RTL] RtlpCallQueryRegistryRoutine(): Correctly set SpareData and SpareLength (#5466)
ports back:
0.4.15-dev-6640-g 02883d1c16

SpareData and SpareLength need to be calculated correctly, as they are used
later in that function as well.
This allows to not overwrite Source UString when writing to Destination UString.

Fixes the problem described in the following JIRA issue, where services could
not start in 2nd-stage-bootcd-setup when installing ReactOS in a very-long-named directory.

CORE-18988
2023-10-21 22:27:20 +02:00
Joachim Henze 3f33517d3f [0.4.7][TASKMGR] Backport many fixes and improvements
Some commits I do port back all the way down till releases/0.4.7:
partially 0.4.15-dev-6768-g 63eaf2bd52 [TASKMGR] *.rc Deduplicate dynamic menu strings (#5772) (I left out the FIXME-comments)
0.4.15-dev-6712-g 46b4b5581d [TASKMGR] Favor _countof(), no functional change intended (#5757)
0.4.15-dev-6703-g 6528ab8fcb [TASKMGR] de-DE.rc Update part 3
0.4.15-dev-6702-g 65ce20896a [TASKMGR] *.rc Strip unused IDD_DEBUG_CHANNELS_DIALOG
0.4.15-dev-6700-g e15d68ba5d [TASKMGR] de-DE German Update & bug-fixes
partially 0.4.15-dev-6447-g 016acd170d [TASKMGR] Do not free shared icon for ShellAbout() calls (I picked just the taskmgr part) (was part of larger PR5519)
0.4.15-dev-6297-g 831288fe69 [TASKMGR] Fix text truncation for fr-FR.rc (#5380) CORE-18523
0.4.15-dev-6127-g c706222f3f [TASKMGR] Fix the license. Turns out it's LGPL-2.1-or-later from the texts.
0.4.15-dev-6124-g 9927163455 [TASKMGR] Reorder page controls to have natural TAB-ordering.
0.4.15-dev-6122-g d5707eefe2 [TASKMGR] High speed update is twice per second, and not every second.
0.4.15-dev-6121-g 2da0506f2a [TASKMGR] Remove more dead code.
partially 0.4.15-dev-6120-g 6e77747b30 [TASKMGR] Simplify tray icon code. (I left out using the strsafe.h-dependent stuff, as this is safe also in old-style)
0.4.15-dev-6119-g 0b4c8bdd1c [TASKMGR] Clamp the values returned from PerfDataGetProcessorUsage() and PerfDataGetProcessorSystemUsage() inside these functions.
0.4.15-dev-6118-g 7b53126375 [TASKMGR] Completely reformat perfpage.c, perfpage.h, procpage.h and trayicon.c
partially 0.4.15-dev-6117-g da7dcec6a0 [TASKMGR] Reformat the files' headers
0.4.15-dev-6115-g 36aea8e56e [TASKMGR] affinity.c: Use _countof instead of sizeof/sizeof (was part of the larger CORE18991)
partially 0.4.15-dev-6109-g 99fb812be4 [TASKMGR] Refactor trayicon.c
0.4.15-dev-5404-g c093d4f803 [TASKMGR] Prevent context menu on idle process (#4889) CORE-18640
0.4.15-dev-5031-g 46ea5171bd [TASKMGR] Pixel-perfection for left border (#4680) CORE-18061
0.4.15-dev-4988-g de5af76811 [TASKMGR] Fix overlapping controls (French only) (#4658)
0.4.15-dev-4987-g f8c28b9773 [TASKMGR] Fix UI on SwitchTo for multiple application (#4652)
0.4.15-dev-3497-g e8a7e0da2b [TASKMGR] Make 'Hide When Minimized' non-default (#4169)
0.4.15-dev-3085-g 515e0cf38f [TASKMGR] Handles: Get number only, skip data (#3910)
and a few *.rc improvements that are not explicitly mentioned here,
especially I stripped the menuLoop-statusbar-help-texts within the older branches.

A few improvements are still left to be done in a future commit (mostly around the plotgraphs and the trayicon-handling),
but I need to have a closer look at them and their impact on binary size,
so I do not want to squash them into this bigger backport,
where I concentrated on the safe/obvious and easy things.

Binary size decreases for all branches:
master taskmgr.exe RosBEWin2.2.2 GCC8.4.0dbg  708.608 -> 696.832 (0.4.15-dev-6768-g63eaf2b)
0.4.14 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  660.992 -> 549.888
0.4.13 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  659.968 -> 542.720
0.4.12 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  662.016 -> 545.792
0.4.11 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  662.016 -> 545.792
0.4.10 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  645.120 -> 532.480
0.4. 9 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  645.120 -> 532.480
0.4. 8 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  645.120 -> 532.480
0.4. 7 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg  645.120 -> 531.456

       taskmgr.exe MS XPSP3 german                             140.800 Bytes
0.4.14 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=de-DE  -> 110.080 Bytes (my current taskmgr of choice)
0.4. 8 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US  -> 108.032 Bytes
0.4. 7 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US  -> 107.520 Bytes
2023-10-19 15:25:14 +02:00
Joachim Henze f643e3b829 [0.4.7][NTOBJSHEX][NTVDM][SETUPAPI] Remove some unused variables. (#94)
This ports back the remaining parts of
0.4.8-dev-18-g 5cb0615147 [BROWSEUI][DEVMGR][EXPLORER][NTGDI][NTOBJSHEX][NTVDM][SETUPAPI] Remove/comment out some unused variables. (#94)

The other parts in [BROWSEUI][DEVMGR][EXPLORER][NTGDI] I did port back earlier already.
That's why they are not visible here. But (#94) is fully covered now.

I intentionally did not mention CORE11799 because that ticket is about making Clang run,
and I don't intend to port that back (yet).

Ftr:
In regfolder.cpp, devclass.c and vidbios.c I deleted a bit more superfluous stuff
than what was done in master. I did that just, because the file was 100% in sync
after the pick between 0.4.7 and 0.4.8. So that doesn't hide/obfuscate any real diff between both.
2023-10-03 05:46:42 +02:00
Joachim Henze 08e5547d76 [0.4.7][COMCTL32] rebar: Remove some hacks and fix checking for transparent background
by porting back:
0.4.8-dev-679-g b8062bde5d [COMCTL32] rebar: Remove some hacks and fix checking for transparent background

I would rather call it: 'make the hacks as local as possible' instead of actually 'removing' them.

Since the state of this file is now semantically the same between releases/0.4.7 and releases/0.4.8
we can use that non-existing interbranch-diff to 'park' some white-space-diff of stripping the majority
of the TRACEs in here in 0.4.7. comctl32 was the first module to trigger relocations in 0.4.9-dev'-master
and I did not regenerate the baseaddresses for 0.4.7 with the script (because there was no need yet).
This will leave some more reserve for future addings in 0.4.7.
For the same reason I stripped some of the now unused local dbg-funcs: REBAR_FmtStyle(), REBAR_DumpBandInfo(), REBAR_DumpBand()
and the GLATESTING dbg-macro.
So we do have that file one time with all that stuff inside, and one time without.

0.4.8 comctl32.dll RosBEWin2.1.6 GCC4.7.2dbg               1.634.304
0.4.7 comctl32.dll RosBEWin2.1.6 GCC4.7.2dbg  1.624.576 -> 1.603.584
2023-10-01 21:31:06 +02:00
Joachim Henze cf099e2bce [0.4.7][COMCTL32] tooltips.c trivial log tweaks, no functional change
partially pick 0.4.8-dev-694-g edd99e8ccc
which (also) tweaked a few loggings. Take what was done for simplifying the ERR().
But strip entirely the TRACEs that were touched or had tab-indentation.
Also fuse 2 ifs into one, as it was done in that same commit.
No functional changes!

0.4.8 comctl32.dll RosBEWin2.1.6 GCC4.7.2dbg               1.634.304
0.4.7 comctl32.dll RosBEWin2.1.6 GCC4.7.2dbg  1.629.184 -> 1.624.576
2023-10-01 11:19:04 +02:00
Joachim Henze 0c09cd7e98 [0.4.7][REACTOS] Reduce count of (DLGPROC) casts, [CMIDRIVER] Remove useless aps file
ports back the following commits:
0.4.15-dev-3822-g 78a7d7dc32 [CMIDRIVER] Remove useless Visual Studio resource editor aps-file
0.4.12-dev-399-g 32faa24733 [BUTTERFLIES] Fix GCC build, addendum to 0.4.12-dev-397-g 2890a22179
a tiny fraction of 0.4.12-dev-397-g 2890a22179 just the [BUTTERFLIES] Avoid DLGPROC cast
0.4.8-dev-58-g bcbe0dd8cd [CPL] Remove unnecessary DLGPROC casts. (#99)
0.4.8-dev-30-g 830fc82afe [SERIALUI] Set the stdcall calling convention for CommDlgProc() and make it return INT_PTR

Ftr, there are still a few DLGPROC casts left after this commit in ros source tree,
but I don't want to port back the commits yet, which addressed them.
Too fresh still, no need to rush that.
2023-09-18 16:15:28 +02:00
Joachim Henze 509c7c3a90 [0.4.7][USER32] Redraw children when the combo box is dropped down (#5679)
port back the following commit:
0.4.15-dev-6613-g e13ebd44c6 [USER32] Pure Whitespace sync from comctl32/combo.c, no functional change
0.4.15-dev-6612-g d97313181e [USER32] Sync comctl32 combo.c code in context of CORE-17883
(0.4.15-dev-3453-g ff89651ed0 is not needed in the branches <= releases/0.4.8 because we had still not entirely split up comctl32 v5/v6 yet, and comctl32/combo.c does not exist yet)

and tweak [USER32] combo.c a bit more even than on master, e.g. strip a few TRACEs. Possible because
unlike master we don't need to be as much in sync as possible to Wine in the older branches.
But we need to have binary size under control for the backports due to base-addresses.

Binary size:
user32.dll master    RosBEWin2.2.2 GCC8.4.0dbg               1.579.008
user32.dll 0.4.14rls RosBEWin2.1.6 GCC4.7.2dbg  1.448.448 -> 1.448.448
user32.dll 0.4.13rls RosBEWin2.1.6 GCC4.7.2dbg  1.445.376 -> 1.444.864
user32.dll 0.4.12rls RosBEWin2.1.6 GCC4.7.2dbg  1.455.616 -> 1.455.104
user32.dll 0.4.11rls RosBEWin2.1.6 GCC4.7.2dbg  1.453.056 -> 1.451.008
user32.dll 0.4.10rls RosBEWin2.1.6 GCC4.7.2dbg  1.434.624 -> 1.434.112
user32.dll 0.4. 9rls RosBEWin2.1.6 GCC4.7.2dbg  1.422.336 -> 1.421.824
user32.dll 0.4. 8rls RosBEWin2.1.6 GCC4.7.2dbg  1.421.824 -> 1.421.824
user32.dll 0.4. 7rls RosBEWin2.1.6 GCC4.7.2dbg  1.418.752 -> 1.417.216
2023-09-16 16:09:09 +02:00
Joachim Henze 37f8af24f6 [0.4.7][COMCTL32] Listview: marqueeRect before starting highlight (#5555), RC: VB6-InstallWizard (#2270)
port back:
0.4.15-dev-6456-g 918a818071 [WINESYNC][COMCTL32] Listview: Initialize marqueeRect from left-click coordinates before starting a marquee highlight (#5555)

The infoPtr->marqueeRect structure is not currently initialized before the
marquee highlight sequence starts, resulting in the RECT having initial
coordinates of (0,0)-(0,0). These coordinates cause the first item in
the listview control to be identified as being within the range of the
marqueeRect's coordinates. This can be best observed when our filebrowser is in details-mode.

That item is then set to LVIS_SELECTED even though it is not part of the
marquee selection.

Wine commit: daf95aaadf3a59f0ccc129a853327417b5e4f07c

author: Hugh McMaster <hugh.mcmaster@outlook.com>
Mon, 26 Apr 2021 10:59:51 +0000 (20:59 +1000)

---------------

Also fix CORE-16650 'VB6 installation does not show the wizard correctly'
by porting back:
0.4.14-dev-844-g ea35843c30 [COMCTL] Use DIALOG instead of DIALOGEX resources (#2270)

This is needed, because property sheets can modify the dialog resource,
and example code (and some existing applications) expect DIALOG.
One such application is the VB6 setup.
CORE-16650

---------------

also port back a few other trivial improvements from never branches, e.g.:
a tiny fraction of 0.4.14-dev-150-g 00f14ee1f2 the type/cast-changes in LISTVIEW_MouseWheel()

---------------

0.4.13-dev-26-g 6122f3f436 [COMCTL32] Remove an unnecessary include

---------------

and port back also a few trivial RC improvements, mainly to keep binary size under control.

Binary size:
comctl32.dll master    RosBEWin2.2.2 GCC8.4.0dbg               1.999.872
comctl32.dll 0.4.14rls RosBEWin2.1.6 GCC4.7.2dbg  1.808.896 -> 1.808.896
comctl32.dll 0.4.13rls RosBEWin2.1.6 GCC4.7.2dbg  1.810.944 -> 1.805.312
comctl32.dll 0.4.12rls RosBEWin2.1.6 GCC4.7.2dbg  1.823.232 -> 1.818.112
comctl32.dll 0.4.11rls RosBEWin2.1.6 GCC4.7.2dbg  1.816.064 -> 1.810.944
comctl32.dll 0.4.10rls RosBEWin2.1.6 GCC4.7.2dbg  1.813.504 -> 1.808.384
comctl32.dll 0.4. 9rls RosBEWin2.1.6 GCC4.7.2dbg  1.813.504 -> 1.808.384
comctl32.dll 0.4. 8rls RosBEWin2.1.6 GCC4.7.2dbg  1.639.424 -> 1.634.304
comctl32.dll 0.4. 7rls RosBEWin2.1.6 GCC4.7.2dbg  1.634.304 -> 1.629.184
2023-09-12 01:19:04 +02:00
Joachim Henze 16c7c9f92a [0.4.7][REACTOS] Optimize existing PNGs (#5486) (#5492) (#5506)
This ports back the following commits about lossless PNG-shrinking:
0.4.15-dev-6410-g cf4bb8fced [WALLPAPERS] Optimize PNG images (#5506)
0.4.15-dev-6398-g e5993f13f0 [REACTOS] Optimize PNG images (#5492)
0.4.15-dev-6376-g 8f3a09722e [MSPAINT] Optimize images for help docs (#5486)

Most of those PNGs have not been touched ever since we switched from SVN to git, so they can safely be ported back by copying over.
But did not port them back any further than where they existed already.

Tweak a few related txt/html files also with trivial stuff like EOL-whitespace-removal.
2023-09-08 19:33:18 +02:00
Joachim Henze 1c40222cc2 [0.4.7] Anti-flicker backport winpos.c
This effective one-liner-backport fixes flickering in some apps like:
- CORE-7652 Hyperlink Blinking text while installing vc2008 redist package
and many duplicate-tickets of that same symptom, like:
- CORE-18553 CPUID CPU-Z 1.84 "about" flickers
- CORE-7753 Caesar 3: Autorun.exe flickers endlessly
- CORE-10741 API monitor high CPU usage
- CORE-15300 Worksoft Navigator 0.985 installer is locked in an endless redrawing loop
- CORE-16325 Some of MWSnap's installation windows fail to display content
- CORE-17925 MS Visual C++ 2008 Redistributable Setup takes long time
- CORE-18153 BitComet 1.86 forces the shell to a endless redrawing
- CORE-18434 Ubisoft installers (SetupUbi) - continously refresh of window
- CORE-15546 Shed 1.0 from rapps - setup does not draw some dlgs initially, but redraw can be enforced
- CORE-18582 Emule 0.50a - Interface frozen / flickering until window is moved

And since I do also port back the follow-up-commit of that, we can achieve that without introducing
the following regressions which the initial fixes caused:
- CORE-18817 [NTUSER] Winpos.c modification generates bad first drawing of some elements
- CORE-18830 Explorer Drawing glitch: Missing "X" on "Folder" pane when Right Click > Explore from Desktop icons
Those 2 things did not happen in the older releases beforehand.

In sum this is a squashed backport of:
0.4.15-dev-6507-g 49dbc8fbbb [NTUSER] Whitespace-fixes winpos.c
0.4.15-dev-5684-g 57eb2a6bf4 [NTUSER] Missing "X" on "Folder" pane when Right Click > Explore from Desktop icons & Rapps toolbar errors (#5068) CORE-18830, CORE-18817
the superseded 0.4.15-dev-5618-g 8866b9d7b0 Update win32ss/user/ntuser/winpos.c
the superseded 0.4.15-dev-5617-g 7866eb2886 [NTUSER] Fix winpos bug hyperlink&images loop redrawing CORE-7652 (#4995)

To prevent increased binary size for the added conditions in the code in older branches, strip a single good-path-TRACE()
which had no trailing \n in the older branches,
but where that \n was added in master head meanwhile. So that TRACE was a diff to older branches anyway.
2023-08-20 02:57:32 +02:00
Joachim Henze a99751b915 [0.4.7][MSAFD] Fix non-blocking sockets support for recv() (#5575)
by porting back:
0.4.15-dev-6491-g 442f5dfab5 [MSAFD] Fix non-blocking sockets support for recv() (#5575) CORE-14486 for Nginx web server; Firefox 52, Mypal 29.3.0, New Moon 28 web browser
partially 0.4.15-dev-4492-g 03422451b3 [REACTOS] Add '\n' to debug logs. Only the [MSAFD] parts

Also strip some EOL-whitespace and sacrifice some good-path-TRACEs to not increase the binary sizes:

msafd.dll GCC8.4.0dbg RosBEWin2.2.2 master             155.648
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.14  144.384 -> 142.336
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.13  144.384 -> 142.336
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.12  145.920 -> 144.896
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.11  143.872 -> 141.824
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.10  142.336 -> 140.800
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4. 9  142.336 -> 140.800
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4. 8  142.336 -> 140.800
msafd.dll GCC4.7.2dbg RosBEWin2.1.6 0.4. 7  142.336 -> 140.800
2023-08-18 21:48:40 +02:00
Joachim Henze c9a2e31ae8 [0.4.7][BROWSEUI] Fix pos of taskbar toolbar right-click menu (#5421)
Don't call ClientToScreen in handling NM_RCLICK message because NMMOUSE.pt is already in screen coordinates.
CORE-18966

A backport of:
0.4.15-dev-6298-g b4e946f5b0

and strip EOL whitespace
2023-08-17 00:12:10 +02:00
Joachim Henze 8c1c026db5 [0.4.7][IP][TCPIP][LWIP] Backports 2023-08-13 (also fixes a BSOD)
0.4.15-dev-6399-g f8a6542b15 [IP] Don't reference uninitialized PCB to avoid BSOD. CORE-18982
0.4.15-dev-6395-g 2010a5b8d9 [IP] Unlock Connection when TCPAllocatePort() fails. CORE-18371
0.4.15-dev-5707-g 874d317a71 [IP] Allow 0xFFFF as Valid Network Port Number (#5074) CORE-18371 CORE-18764
PARTIALLY pick 0.4.14-dev-1326-g 792b64ea46 [TCPIP][FORMATTING] Format TiDispatch function. No functional changes (#2112)
0.4.13-dev-368-g 3a98d96eac [LWIP] Fix src/core/init.c a bit (#1620)
0.4.8-dev-781-g 63775c3215 [LWIP] dhcp.c: Cherry-pick lwIP 32aa9a4. CORE-8978 (#302)

and strip some EOL-whitespace.

Just to make sure that the binary sizes did not increase:
tcpip.sys master GCC8.4.0dbg RosBEWin2.2.2              462.848
tcpip.sys 0.4.14 GCC4.7.2dbg RosBEWin2.1.6   425.984 -> 425.984
tcpip.sys 0.4.13 GCC4.7.2dbg RosBEWin2.1.6   417.792 -> 417.792
tcpip.sys 0.4.12 GCC4.7.2dbg RosBEWin2.1.6   421.888 -> 421.888
tcpip.sys 0.4.11 GCC4.7.2dbg RosBEWin2.1.6   421.888 -> 421.888
tcpip.sys 0.4.10 GCC4.7.2dbg RosBEWin2.1.6   413.696 -> 413.696
tcpip.sys 0.4. 9 GCC4.7.2dbg RosBEWin2.1.6   413.696 -> 413.696
tcpip.sys 0.4. 8 GCC4.7.2dbg RosBEWin2.1.6   413.696 -> 413.696
tcpip.sys 0.4. 7 GCC4.7.2dbg RosBEWin2.1.6   413.696 -> 413.696
2023-08-13 16:35:33 +02:00
Joachim Henze 17b97d2be2 [0.4.7][NDIS] Fix parameter order when calling ResetHandler. CORE-14624
Backport of:
0.4.9-dev-841-g ccaf7b24c3 [NDIS] Fix parameter order when calling ResetHandler. CORE-14624
2023-08-07 22:37:18 +02:00
Joachim Henze 0d16cd41f1 [0.4.7][NTOS][WIN32SS][UDFS] Fix double free in ObCreateObject, fix retvals CORE-14271
Backport the following commits:
0.4.15-dev-6401-g 53b30e3f3b [NTOSKRNL][NTGDI] Formatting addendum, no functional change
0.4.15-dev-5487-g e7bbbf049e [NTOS] Fix double free on allocation failure in ObCreateObject
partially 0.4.13-dev-358-g 38db074491 [WIN32SS][UDFS] Misc addendum to CORE-14271 (#1529)
0.4.12-dev-648-g 17af7f0c27 [UDFS] Correctly check SeSinglePrivilegeCheck() return value (#1324) CORE-14271
0.4.12-dev-552-g 0483a5a380 [NTOS:OB] Correctly check SeSinglePrivilegeCheck() return value (#1323) CORE-14271
partially 0.4.10-dev-528-g 2c909db295 [NTOS:OB] Remove duplicated ObpTypeObjectType from ob.h
0.4.8-dev-954-g 862b82f3fa [WIN32K:NTGDI] Fix more uses of RtlCreateUnicodeString. CORE-14271
0.4.8-dev-949-g 7f687154a0 [WIN32K:NTGDI] Correctly interpret RtlCreateUnicodeString return value. CORE-14271
0.4.8-dev-948-g 6e750d189a [NTOS:CM] Correctly interpret RtlCreateUnicodeString return value. CORE-14271

Just for verifying that the size didn't increase anywhere:

ntoskrnl.exe GCC8.4.0dbg RosBEWin2.2.2 master               5.124.096
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4.14  4.413.440 -> 4.413.440
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4.13  4.367.360 -> 4.367.360
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4.12  4.377.600 -> 4.377.600
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4.11  4.377.088 -> 4.377.088
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4.10  4.344.320 -> 4.344.320
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4. 9  4.311.552 -> 4.311.552
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4. 8  4.296.704 -> 4.296.704
ntoskrnl.exe GCC4.7.2dbg RosBEWin2.1.6 0.4. 7  4.231.168 -> 4.231.168

udfs.sys     GCC8.4.0dbg RosBEWin2.2.2 master             835.584
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4.14  745.472 -> 745.472
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4.13  745.472 -> 745.472
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4.12  749.568 -> 749.568
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4.11  749.568 -> 749.568
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4.10  749.568 -> 749.568
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4. 9  749.568 -> 749.568
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4. 8  749.568 -> 749.568
udfs.sys     GCC4.7.2dbg RosBEWin2.1.6 0.4. 7  749.568 -> 749.568

user32.dll   GCC8.4.0dbg RosBEWin2.2.2 master               1.585.152
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.14  1.448.448 -> 1.448.448
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.13  1.445.376 -> 1.445.376
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.12  1.455.616 -> 1.455.616
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.11  1.453.056 -> 1.453.056
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.10  1.434.624 -> 1.434.624
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4. 9  1.422.336 -> 1.422.336
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4. 8  1.421.824 -> 1.421.824
user32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4. 7  1.418.752 -> 1.418.752

win32k.sys   GCC8.4.0dbg RosBEWin2.2.2 master               3.477.504
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4.14  2.904.064 -> 2.904.064
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4.13  2.895.872 -> 2.895.872
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4.12  2.887.680 -> 2.887.680
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4.11  2.867.200 -> 2.867.200
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4.10  2.863.104 -> 2.863.104
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4. 9  2.834.432 -> 2.834.432
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4. 8  2.830.336 -> 2.830.336
win32k.sys   GCC4.7.2dbg RosBEWin2.1.6 0.4. 7  2.830.336 -> 2.830.336
2023-08-02 01:01:40 +02:00
Joachim Henze 82e9061e36 [0.4.7][TRANSLATION] Simplified Chinese translation improved. (#346)
This is a partial backport of:
0.4.8-dev-946-g 7082b621a5

It fixes the broken bootcd Startmenu (and very likely also other stuff, like 3rd party apps)
for zh-CN by untranslating selected folder paths.
It regressed in multiple steps on master before the SVN->GIT-transition.

Ftr: It was mentioned in the PR, that even MS Windows for Simplified Chinese does not translate those folders.

shell32.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.7  8.668.160 -> 8.668.160
shimgvw.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.7    173.056 ->   173.056
syssetup.dll  GCC4.7.2dbg RosBEWin2.1.6 0.4.7    829.440 ->   829.440
userenv.dll   GCC4.7.2dbg RosBEWin2.1.6 0.4.7    185.344 ->   185.344
2023-08-01 21:40:48 +02:00
Joachim Henze 020bd0b819 [0.4.7][NTUSER] NtUserWaitForInputIdle: Fix unhandled exception BSOD 0x1E, and tweaks
Backport the following commits:

0.4.15-dev-6397-g 6b7efb331c [NTUSER] co_IntSendMessageWithCallBack: Formatting only, no functional changes
0.4.15-dev-6227-g c7e4c3a8e9 [NTUSER] NtUserWaitForInputIdle: Fix unhandled exception BSOD 0x1E CORE-18728 CORE-19014 (#5391)
0.4.15-dev-697-g 9f428f5522 [NTUSER] Demote ERR to TRACE, also some minor corrections (#3132)

win32k.sys master GCC8.4.0dbg RosBEWin2.2.0              3.477.504
win32k.sys 0.4.14 GCC4.7.2dbg RosBEWin2.1.6 2.904.064 -> 2.904.064
win32k.sys 0.4.13 GCC4.7.2dbg RosBEWin2.1.6 2.895.872 -> 2.895.872
win32k.sys 0.4.12 GCC4.7.2dbg RosBEWin2.1.6 2.887.680 -> 2.887.680
win32k.sys 0.4.11 GCC4.7.2dbg RosBEWin2.1.6 2.867.200 -> 2.867.200
win32k.sys 0.4.10 GCC4.7.2dbg RosBEWin2.1.6 2.863.104 -> 2.863.104
win32k.sys 0.4. 9 GCC4.7.2dbg RosBEWin2.1.6 2.834.432 -> 2.834.432
win32k.sys 0.4. 8 GCC4.7.2dbg RosBEWin2.1.6 2.830.336 -> 2.830.336
win32k.sys 0.4. 7 GCC4.7.2dbg RosBEWin2.1.6 2.830.336 -> 2.830.336
2023-07-30 21:58:45 +02:00
Joachim Henze c5d1a054c2 [0.4.7][DXDIAG] Backport trivial translation fixes 2023-07-23
0.4.15-dev-5770-g 793e9f20ef [DXDIAG] Fix text truncation on button for french fr-FR.rc CORE-18853
0.4.15-dev-5768-g 29d0deef13 [DXDIAG] Fix text truncation german de-DE.rc CORE-18853 (#5137)
0.4.15-dev-5533-g 5b8886de26 [DXDIAG] Fix Portuguese (pt-BR) translation (#4953)

and some other translation improvements + EOL-whitespace,
and a few _countof() in system.c taken from 0.4.10-dev'ing

master dxdiag.exe GCC8.4.0dbg            406.016
0.4.14 dxdiag.exe GCC4.7.2dbg 375.296 -> 375.296
0.4.13 dxdiag.exe GCC4.7.2dbg 375.296 -> 374.784
0.4.12 dxdiag.exe GCC4.7.2dbg 376.320 -> 375.808
0.4.11 dxdiag.exe GCC4.7.2dbg 376.320 -> 375.808
0.4.10 dxdiag.exe GCC4.7.2dbg 376.320 -> 375.808
0.4.9  dxdiag.exe GCC4.7.2dbg 371.712 -> 371.200
0.4.8  dxdiag.exe GCC4.7.2dbg 371.712 -> 371.200
0.4.7  dxdiag.exe GCC4.7.2dbg 371.200 -> 371.200
2023-07-23 23:03:30 +02:00
Joachim Henze d3710ecc55 [0.4.7][ADVAPI32][PSDK] Selected Backports 2023-07-22
0.4.15-dev-5927-g bfc6a119c5 [ADVAPI32] Do not fail on creating a registry key if the security attributes have an invalid length. (#5230) fixes regression CORE-15471
partially 0.4.15-dev-999-g 889b077b23 [REACTOS] *.spec: Fix some function/parameter types (only the [ADVAPI32] part)
0.4.14-dev-1245-g 8ae8083378 [ADVAPI32][PSDK] CryptReleaseContext(): dwFlags parameter is DWORD, only
0.4.13-dev-666-g f3a9b524f1 [ADVAPI32] Fix copying the TokenSource string
0.4.13-dev-363-g 46259092f9 [ADVAPI32:REG] Remove some useless casts (#1614)
0.4.12-dev-237-g 446e13745c [ADVAPI32] Stop pretending our advapi32 is NT6+, inconsistent TEB definitions CORE-15526

also fix a bit of whitespace, wrong format-strings and missing \n in debugprints

---------
in 0.4.9 + 0.4.10: scm.c: fix wrong arguments count in 2 TRACEs, which were introduced by the guilty 0.4.9-dev-417-g 32bb592e12
Contrary to that delete all those TRACEs in 0.4.7 and 0.4.8 because they have been touched a thousand times after their introduction to fix all their format-string-glitches.
---------
in 0.4.7+0.4.8+0.4.9 reg.c: delete load_string() and RegLoadMUIStringW(), inspired by 0.4.10-dev-502-g d559ca9c98
Both were neither used, nor exported yet luckily in <=0.4.9
Tip: In 0.4.9 dxdiag network.c we got some interesting workaround code worth to look at if ever needed for older releases. Search for "RegLoadMUIString" within

---------

advapi32.dll master GCC8.4.0dbg            671.232
advapi32.dll 0.4.14 GCC4.7.2dbg 602.624 -> 602.624
advapi32.dll 0.4.13 GCC4.7.2dbg 602.112 -> 602.112
advapi32.dll 0.4.12 GCC4.7.2dbg 615.424 -> 615.424
advapi32.dll 0.4.11 GCC4.7.2dbg 613.888 -> 613.888
advapi32.dll 0.4.10 GCC4.7.2dbg 604.672 -> 604.672
advapi32.dll 0.4.9  GCC4.7.2dbg 607.744 -> 604.672
advapi32.dll 0.4.8  GCC4.7.2dbg 602.624 -> 589.824
advapi32.dll 0.4.7  GCC4.7.2dbg 601.600 -> 589.312
2023-07-22 20:01:40 +02:00
Joachim Henze 6fe5bebccf [0.4.7][SDK] Shorten autogenerated Copyright strings (#5210)
Ports back:
0.4.15-dev-5910-g 99e5f51d5b
in a slightly adapted form, which respects that we were still
a "Team" in 0.4.7 - 0.4.14 and no "Project" yet.
The idea with the "Project" was born during 0.4.15-dev'ing.
That existing difference does also manifest in media/inf/*.inf and I don't intend to
ever change that for the older branches.
That means also that in the older branches we do not need to scroll at all to
see all the text.
Also adopt ReactOS birth year from 1998 to 1996 which we do also use in the msgina startup-dlgs-pics
all the way from releases/0.4.7 at least to todays master head.
2023-07-15 23:57:25 +02:00
Joachim Henze 87c6a80e70 [0.4.7][TRANSLATION] Fix MANY font glitches in zh-CN.rc & zh-TW.rc CORE-9566, email tr-TR.rc
this ports back (also) the following commit:
0.4.15-dev-6308-g 2d9877470d

While touching those files, port back some minor translation improvements also.

but actually I did concentrate here on porting back the following commits:
0.4.8-dev-547-g e9d8fa57c3 [TRANSLATION][BASE][FDEBUG][MODULES][WIN32SS] Use correct font name in Chinese resources, CORE-9566 (#227)
0.4.8-dev-546-g d09998dfc7 [TRANSLATION][APPLICATIONS] Use correct font name in Chinese resources, CORE-9566 (#226)
0.4.8-dev-539-g bf51ed17f8 [SHELLEXT] Use correct font name in Chinese resources, CORE-9566 (#224)
0.4.8-dev-538-g 1ebe4a5b83 [TRANSLATION] Use correct font name in Chinese resources, Part 3/3, CORE-9566 (#223)
0.4.8-dev-537-g 074f5c6c13 [TRANSLATION] Use correct font name in Chinese resources, Part 2/3, CORE-9566 (#222)
0.4.8-dev-536-g 81d6232aa3 [TRANSLATION] Use correct font name in Chinese resources, Part 1/3, CORE-9566 (#221)
partially 0.4.8-dev-534-g b214b160b6 setup: Use correct font name in resource: CORE-9566 (#219) (I left out all the changes to [WELCOME])
0.4.8-dev-533-g 2b91b29642 [CPL] Control Panel Applets: Use correct font name in Chinese resources, CORE-9566 (#220)
------
tr-TR.rc: Also strip outdated email address erdemersoy@live.com instead of following 0.4.8-dev'ing
with replacing it with an even longer address, that later got changed another time.
The auto-replacement during 0.4.8-dev'ing did lead to some very long lines in many header sections. Don't want that.
2023-07-13 03:22:34 +02:00
Joachim Henze eea7665e93 [0.4.7][RAPPS] Selected backports
partially 0.4.15-dev-6292-g 5f533bd019 [RAPPS] Update *.rc
partially 0.4.15-dev-6280-g ec974d8a81 [RAPPS] Main toolbar: Tooltip strings refactoring (#5007)
0.4.10-dev-210-g 0ec08818b5 [RAPPS] Select the search bar with ctrl+f

and pick some other translation improvements from master, strip outdated email-addresses

releases/0.4.7 - releases/0.4.11: Had a bug regarding category "Selected for installation",
it was populated with garbage after starting up the app. The bug in ReactOS is outside of the rapps source-folder.
So I decided to delay introduction of that feature to releases/0.4.12
2023-07-10 01:43:16 +02:00
Katayama Hirofumi MZ 4cdffa2dba [0.4.7][TRANSLATION] Use correct font name in Korean resources (#228)
Localized resources should use the correct Korean fonts that are most suitable
for UI and compatible with Windows.

fix picked from commit 0.4.8-dev-548-g 89f9c9101a

This fixes a part of CORE-9566
2023-07-08 19:59:37 +02:00
Joachim Henze 0654a0a377 [0.4.7][NETSTAT] Picky Backports up to master-state 2023-07-06
0.4.15-dev-6256-g 8ef47d2e5e [NETSTAT] Optimize a bit (#5405)
partially 0.4.15-dev-6245-g 5ee97b9537 [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
partially 0.4.15-dev-6211-g 40864bc15c [NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)
0.4.15-dev-3338-g 0e75fc9240 [NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831 [I ported this double-free-fix earlier already into releases/0.4.13 & releases/0.4.14 and it didn't affect any older releases than that]
partially 0.4.14-dev-479-g 1fa2780796 [NETSTAT] Fix output formats
0.4.13-dev-584-g 5e10c4ed32 [NETSTAT] ShowUdpTable(): Fix "tcp" copypasta (#1699)
partially 0.4.13-dev-579-g b695971c7f [NETSTAT] Simplify some code
partially 0.4.13-dev-578-g ab7dc56d6c [NETSTAT] Formatting
partially 0.4.13-dev-519-g dda5ec44b0 [NETSTAT] Simplify DoFormatMessage() (just the changed retval)
0.4.11-dev-820-g 29c883e2a5 [NETSTAT] Add support for displaying UDP connections owning process
0.4.11-dev-814-g 2b55073360 [NETSTAT] Add support for displaying TCP connections owning process
2023-07-06 01:08:53 +02:00
Joachim Henze 40bbab2b8c [0.4.7][IPHLPAPI][TCPIP][IP][LWIP][SDK][PSDK] Port back groundworks for netstat
This fixes:
CORE-15363 'netstat TCP foreign address port is wrong'
CORE-5401 'Netstat returns ERROR_NO_DATA Pipe being closed'
CORE-5126 'UNIMPLEMENTED: iphlpapi: GetExtendedUdpTable'
even without touching the netstat binary yet.
And is mostly based on work done by Pierre Schweitzer during 0.4.11-dev'ing.

by porting back:
0.4.15-dev-6231-g a5360f542f [IPHLPAPI] Formatting only, no functional change
partially 0.4.14-dev-1425-g f540b2b20c [IPHLPAPI] GetAdaptersAddresses(): Add 1 free() in ERROR_NO_DATA case (#2526) (but leave out adding the comments in .h)
0.4.12-dev-686-g 22f60faf43 [IPHLPAPI] Remove dead code to fix CID 513306, 1442673, 1442697
0.4.11-dev-880-g bf052e120b [IPHLPAPI] Reduce code duplication and use a single function for TCP and UDP enumerations + fix corruption
0.4.11-dev-867-g 159f5b676a [IPHLPAPI] Fix broken size computation leading to buffer overrun
0.4.11-dev-861-g 05657bfcfd [SDK] Add a non documenter TOIID used to query modules information
0.4.11-dev-827-g ce7f9211a0 [TCPIP] In InfoTdiQueryGetConnectionTcpTable(), only return if there's a connection
0.4.11-dev-823-g 0ec92100bc [TCPIP] Properly display local information for established connections
0.4.11-dev-819-g fbdfe7bd40 [SDK] Add GetExtendedUdpTable()
0.4.11-dev-818-g 370b03b523 [IPHLPAPI] Reimplement GetUdpTable() using GetExtendedUdpTable()
0.4.11-dev-817-g 58cef01422 [IPHLPAPI] Implement GetExtendedUdpTable() CORE-5126
0.4.11-dev-816-g 6fb6c7b50b [IPHLPAPI] Implement getOwnerUdoTable(), to get UDP connections with owner PID
0.4.11-dev-815-g 13de7f08af [TCPIP] Implement enumerating UDP connections with owner PID
0.4.11-dev-813-g 73c87d5c14 [IPHLPAPI] Reimplement GetTcpTable() using GetExtendedTcpTable()
0.4.11-dev-812-g d76ac645e8 [IPHLPAPI] Don't leak memory
0.4.11-dev-811-g c949a12506 [IPHLPAPI] Implement the IPv4 TCP_TABLE_OWNER_PID_* cases in GetExtendedTcpTable()
0.4.11-dev-810-g dca7e5689f [IPHLPAPI] Implement getOwnerTcpTable(), to get TCP connections with owner PID
0.4.11-dev-809-g 411504b5f4 [TCPIP] Implement enumerating TCP connections with owner PID
0.4.11-dev-808-g 935978ee57 [TCPIP] Store creator PID in ADDRESS_FILE
0.4.11-dev-807-g 702d44c683 [IPHLPAPI] Implement the IPv4 TCP_TABLE_BASIC_* cases in GetExtendedTcpTable()
0.4.11-dev-804-g 91b013d387 [TCPIP] When enumerating sockets, retrieve their state and return it
0.4.11-dev-803-g 738f327668 [IP] Add a TCPGetSocketStatus() wrapper around LibTCPGetSocketStatus()
0.4.11-dev-802-g 29c1510423 [LWIP] Implement a LibTCPGetSocketStatus() function in our LwIP glue
0.4.11-dev-792-g 8a98c85c1f [IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections
0.4.11-dev-784-g f29016dabe [TCPIP] Properly handle listening sockets
0.4.11-dev-782-g 007f43dd56 [TCPIP] Implement returning UDP connections CORE-5401
0.4.11-dev-781-g 77d5f04f22 [TCPIP] Implement returning TCP connections CORE-5401
0.4.11-dev-799-g 500a5151ea [TCPIP] Fix returned IP address when querying TCP connections CORE-15363
0.4.11-dev-783-g d18b1fe24b [IPHLPAPI] Properly count UDP entries CORE-5401
0.4.11-dev-780-g e3cb9697a4 [IPHLPAPI] Implement getNumUdpEntries() and getUdpTable() CORE-5401
0.4.11-dev-779-g 678204790c [IPHLPAPI] Implement getNumTcpEntries() and getTcpTable() CORE-5401
0.4.9-dev-59-g b6c060ce04 [IPHLPAPI] Fix getNumRoutes() return value on Mib error (#391)
----------------
Strip some DPRINTs entirely in IPHLPAPI/TCPIP in releases/0.4.7 - 0.4.10 (instead of fixing them like we did on master). Many of them had x64 issues:
This was partially *inspired* by watching the following commits:
0.4.13-dev-14-g f9a967b2ae [IPHLPAPI] Fix misc 64 bit issues (only the parts in iphlpapi_main.c with the format strings)
0.4.10-dev-409-g 0f8439aa71 [IPHLPAPI] Fix 64 bit issue, just the one within [IPHLPAPI] ifenum_reactos.c
0.4.9-dev-856-g 6c9359221c [IPHLPAPI] ipstats_reactos: Review all TRACE/WARN calls
This does not only fix the x64 incompatibilities by superseding those 3 commits but also will keep the file-sizes under control for the backports.
2023-07-03 01:57:54 +02:00
Joachim Henze 6812097a8b [0.4.7][NTOS:KDBG] Fix DPRINT format specifier in KdPortInitializeEx. CORE-14174 (#263)
By porting back
0.4.8-dev-612-g a8bd06be98
2023-07-03 00:02:43 +02:00
Joachim Henze 03fe564d33 [0.4.7][AFD] Port back 2 fixes CORE-18328 (#4972) and CORE-13067 (#440)
fix CORE-18328 'FileZilla 3.8 unable to list content of a remote directory due to undue ECONNRESET'
I tested to list the contents of ftp.heise.de and downloaded some files from its pub.

by porting back:
0.4.15-dev-5870-g 9f9b81e396 [AFD] ReceiveActivity: Don't return STATUS_FILE_CLOSED in case of FCB overread CORE-18328 (#4972)
-------------
fix CORE-13067 'wget can not download'
I tested to wget.exe http://download.microsoft.com/download/vc60pro/update/2/w9xnt4/en-us/vc6redistsetup_deu.exe

by porting back:
0.4.9-dev-349-g 9168226378 [AFD] Respond to FileFsDeviceInformation. CORE-13067 (#440)
0.4.9-dev-350-g 8b84b1c6b3 [AFD] Mark the socket as named pipe, so NtWriteFile actually knows what to do with it. CORE-13067 (#440)
-------------
also port back unrelated:
0.4.8-dev-233-g 44e36b616a [AFD] Zap unused TaCopyAddress() and TaCopyAddressInPlace().
partially 0.4.8-dev-589-g a2f7de7ee8 [AFD] just pick the main.c one-liner with the %p format-string
and a few whitespace improvements from 0.4.8-dev'ing
2023-06-14 23:52:06 +02:00
Joachim Henze e4f0ba5cae [0.4.7][USETUP][MBEDTLS] Port back some cleanup
by picking:
0.4.9-dev-884-g 7b618314c2 [USETUP] Remove now-unneeded file.
0.4.9-dev-849-g 7c3cff3a68 [USETUP] Remove the WIN32 support because usetup is a native-only application
0.4.9-dev-847-g 1b323ff2f4 [USETUP] Remove unused VolumeLabel and FileSystemName from the PARTENTRY type
partially 0.4.9-dev-843-g 3bf2f30cf2 [USETUP] only the Cleanup-part in consup.c, **not** the part which improved on the keys for CORE13975

0.4.8-dev-979-g 25bca520f5 [MBEDTLS] Don't link with zlib, we don't use it. CORE-14290
0.4.8-dev-978-g dc51b419c7 [USETUP] Use the smaller zlib_solo instead of the full zlib. CORE-14290
partially 0.4.8-dev-271-g 5633423086 [USETUP] Silence some clang-cl warnings. (only the [USETUP]-part)
partially 0.4.8-dev-107-g f0e6c11bba [USETUP] NtWriteFile() calls: Remove unused 'ByteOffset = 0',

In sum:
0.4.9 usetup binary size RosBEWin2.1.6 GCC4.7.2dbg == 849.920bytes
0.4.8 usetup binary size RosBEWin2.1.6 GCC4.7.2dbg shrinks from 847.872bytes -> 846.848bytes
0.4.7 usetup binary size RosBEWin2.1.6 GCC4.7.2dbg shrinks from 853.504bytes ->	845.312bytes
2023-06-13 01:04:25 +02:00
Joachim Henze c41493fcf9 [0.4.7][NTUSER] co_UserDestroyWindow: Validate window before destroying it (#5054)
Prevent the window from being destroyed twice
fixes CORE-18821 'WIN32K BSOD 0x1E when opening Build menu in AVR Studio 4.19'
port of 0.4.15-dev-5938-g 77d4653164

And port back also some unrelated formatting improvements,
and kill a block of code that was commented out in all branches,
and was not x64 compatible in 0.4.7/0.4.8, and therefore was a diff already anyway.
2023-06-10 12:44:02 +02:00
Joachim Henze a373df0d07 [0.4.7][BLUE] Optimize ScrIoControl for speed (#5185)
Optimize IOCTL_CONSOLE_FILL_OUTPUT_ATTRIBUTE and IOCTL_CONSOLE_FILL_OUTPUT_CHARACTER for speed by using cache.
a part of CORE-18838
It is faster because it minimizes the amount of pointer dereferences within the for-loops.

fix picked from 0.4.15-dev-5881-g 3526ffc094
---------
also partially pick unrelated cleanup from:
0.4.14-dev-439-g 75f188c200 (only the change in blue.c)
---------
and take back with me some whitespace-tweaks to bring the file closer to todays releases/0.4.14
2023-06-06 23:45:20 +02:00
Joachim Henze 5e8c720402 [0.4.7][USETUP] Get rid of the interface directory because we support text-mode only
Just port back 0.4.9-dev-846-g 3ce0c5d48b

Does not fix anything, but simplifies comparing code to newer branches and
flat layout is good.
2023-06-06 01:09:37 +02:00
Joachim Henze 983450cb44 [0.4.7][BOOTDATA] hivesys.inf Play safe with ServiceGroupOrder
Restores *inferior* code for older branches.

I recently ported back the *proper* 0.4.15-dev-4352-g cfe387a9b0
as part of:
0.4.10-release-186-g e5d8019d24
0.4.9-release-197-g 557db9a1ac
0.4.8-release-203-g 78daf4169a
0.4.7-release-229-g e0a3b0c8f5

That backport worked very well in releases/0.4.11 to releases/0.4.14

and it also caused no severe issues for releases/0.4.7 to releases/0.4.10
e.g. the mouse and keyboard works well, tested with VBox4.3.12 & MS VirtualPC 2007 SP1 6.0.192.0
but I noticed some logspam that happens for releases/0.4.7 to releases/0.4.10 and only during 2nd stage:

bad-path (with the commas):
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\kbdclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\mouclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\vbemp.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\kbdclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\mouclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
...
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0F03\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0F03\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0F03\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0F03\2&ccb86d17&0000

good-path (without the commas):
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\vbemp.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
...
(../../ntoskrnl/mm/ARM3/sysldr.c:176) Loading: \SystemRoot\System32\DRIVERS\i8042prt.sys at F771B000 with 1b pages
...
and no such 'Removal pending'

So we do still miss some unknown commit from 0.4.11-dev'ing that will avoid that additional logspam with the corrected hivesys.inf.
I have not identified that commit yet, and until I will, I do play safe by restoring the wrong List-multi-string in hivesys.inf.
2023-06-05 23:48:53 +02:00
Joachim Henze 5b1eb5407a [0.4.7][REGEDIT] Port back several improvements and crash-fixes
0.4.15-dev-5985-g 31fdaca8c0 [REGEDIT] Strip redundant include, minor formatting (#5264)
0.4.15-dev-5970-g 9d7d3314b3 [REGEDIT] Check whether pszSelectKey is NULL on CDN_FILEOK (#5255)
0.4.15-dev-5898-g 84e580b67e [REGEDIT] Fix ListView selection and finding (#5150)
(superseded) 0.4.15-dev-5802-g cce3eb9393 Fix buffer read past end problem. (#5146) CORE-15896 and CORE-18230
partially 0.4.15-dev-5753-g 1ee9ea4518 [REGEDIT] Avoid buffer overflow in SelectNode. CORE-18602 (I left the wscpy-replacement at the end for the fixed size strings, as they would increase binary size, and are totally safe)
partially 0.4.15-dev-5308-g 5daf5cd057 [REGEDIT] Use shell icons for the tree view (#4841) CORE-10764
0.4.15-dev-4850-g 568383c9b9 [REGEDIT] Fix issue at Find registry key (#4341)
partially 0.4.15-dev-2265-g bebdfda8b7 [REGEDIT]... Use newer file open dialog (#3571)
0.4.15-dev-1470-g 9de8787187 [REGEDIT] Display search finished messagebox when using Find Next (F3) menu item (#3371) CORE-17368
0.4.15-dev-1302-g 6aae5f4fdd [REGEDIT] Make "finished find" messagebox owned by Regedit window (#3369) CORE-17367
0.4.15-dev-169-g 0461de33c5 [REGEDIT] Fix HeapFree() on the wrong variable (#2736)
0.4.14-dev-1484-g c832112771 [REGEDIT] Fix tree view popup menu issues CORE-16887
0.4.14-dev-1468-g 763de230b2 [REGEDIT] Fix inconsistent menu state for 'Permissions' CORE-16889
a more efficient solution than 0.4.14-dev-1467-g b280615b85 [REGEDIT] Crash on selecting 'New' on root item 'My computer' CORE-16888
0.4.14-dev-1466-g 13dd917589 [REGEDIT] CORE-16892 fr-FR Translation update
0.4.13-dev-464-g 6b95727282 [REGEDIT] Adjust ListView column widths (#1663) CORE-15187
0.4.12-dev-47-g 63a0ac0461 [REGEDIT] Set background brush to child window (#1122) CORE-15442
0.4.11-dev-481-g efbebf983c [REGEDIT] Improve the layout of controls (#967) CORE-15187
0.4.11-dev-480-g e4c2cff6c8 [REGEDIT] Don't paint background in WM_PAINT (#970) CORE-15187
0.4.11-dev-458-g 125db5ead9 [REGEDIT] Trivial resizing code fix (#950)
0.4.11-dev-457-g b3231e0bf5 [REGEDIT] Code formatting (#949)
0.4.10-dev-244-g b9415740a1 [REGEDIT] Fix importing very big *.reg files (HEX values commonly) (#618)

a few fragments only of 0.4.15-dev-5304-g 36a7f0dc7c [REGEDIT] framewnd.c resize_frame_rect(), main.h strip externs before func declarations and reordering, treeview.c InitTreeViewImageLists()

also port back a few selected translation improvements, and strip the suggestions-feature in older branches <= 0.4.13 which does not exist in 2k3sp2.
2023-05-01 20:04:46 +02:00