Commit graph

2808 commits

Author SHA1 Message Date
Joachim Henze 35dbdaaa0e [SHELL32] Fix regression CORE-12364
The sorting in explorer broke by
SVN r73128 == git
24fcf531e7

Thanks to Doug Lyons for providing this patch.
I do intend to port it back into 0.4.14RC.
2020-09-11 02:24:42 +02:00
Kyle Katarn 7d44c1cb07
[SHELL32] Show "size on disk" in file/folder properties (#3107)
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
2020-09-10 20:48:40 +02:00
Mark Jansen f2ffd21232
[SHLWAPI] Fix SHLoadIndirectString executing code when loading a string 2020-09-10 19:45:22 +02:00
Oleg Dubinskiy 07f98eb10a [DBGENG] Import dbgeng.dll from Wine Staging 4.18
CORE-17153.
2020-09-10 18:19:28 +02:00
Katayama Hirofumi MZ c8e3ef7894
[SHELLFIND] Split encoding detection code (#3147)
Split encoding detection code to improve code quality. This is follow-up of #3134 (7376cde). CORE-17250
2020-09-10 19:03:20 +09:00
Timo Kreuzer 92f4746845 [NTDLL] Add Vista exports 2020-09-09 19:33:29 +02:00
Timo Kreuzer aaa7dda945 [NTDLL] Mark 2k3 only functions and improve some arch specific definitions 2020-09-09 19:33:29 +02:00
Omer I.S bca076269f
[INPUT.CPL] Update Hebrew translation (#3121) 2020-09-08 23:01:56 +02:00
Kyle Katarn d7fd62d478
[BOOT][DIRECTX][SHELL32] Unneeded semicolons (trivial) (#3133)
Except in 3rd-party code.
CORE-13162
2020-09-08 21:57:13 +02:00
Katayama Hirofumi MZ 7376cdebb6
[SHELLFIND] Encoding-aware file search (#3134)
Consider UTF-8/UTF-16/UTF-16BE encodings in file search. Recognize UTF-8/UTF-16/UTF-16BE BOM and NULs at the beginning of the file contents. Optimize for speed.
CORE-17250
2020-09-07 22:30:47 +09:00
Katayama Hirofumi MZ 7ea54062b0 [BROWSEUI] Improve Japanese translation 2020-09-07 17:11:31 +09:00
Katayama Hirofumi MZ 2dd4f8714d
[SHELLFIND] Fix directory search upon non-empty word/phrase query (#3130)
If the search phrase was not empty, it must not match the directory. CORE-17244
2020-09-07 15:48:25 +09:00
Katayama Hirofumi MZ 8fa3c147b6
[BROWSEUI][SHELL32] Implement MoveTo/CopyTo buttons (#3128)
Implement the actions of the MoveTo/CopyTo/Delete buttons.
CORE-11132
2020-09-07 09:42:43 +09:00
Katayama Hirofumi MZ 828cf19a29
[BROWSEUI] Set DT_VCENTER to Explorer bars (#3135)
Make the captions of the explorer bars vertically centered.
2020-09-07 09:33:21 +09:00
Katayama Hirofumi MZ 88cdb9696b [SHELL32] Make 'hwndServer == NULL' spams quiet 2020-09-06 22:48:29 +09:00
Mark Jansen 246e6a0de9
[BROWSEUI] Stop the address edit box trying to parse a null pidl 2020-09-06 14:32:59 +02:00
Mark Jansen 53badbd2f7
[ZIPFLDR] Fix PathCompactPathW writing out of bounds
CORE-17245
2020-09-06 14:28:56 +02:00
Kyle Katarn 038daa6367
[SHELL32][PAINT][DRIVERS][SHELLEXT] French translation update (#3092)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-09-03 15:16:44 +02:00
Omer Itzic S 49972f51c6
[INETCPL] Update Hebrew translation (#3122) 2020-09-03 15:00:08 +03:00
Katayama Hirofumi MZ 7c134e4d14
[SHELL32] Big fix for change notification (#3048)
- Reduced the failures of SHChangeNotify testcase.
- Simplified change notification mechanism.
- Realized PIDL aliasing.
CORE-13950
2020-09-03 13:36:31 +09:00
Joachim Henze 1cc84c6db7 [RPCRT4] Check hBinding != 0 CORE-16936
To prevent logspam that was introduced when syncing
to Wine Staging 4.18 in 0.4.14-dev-422-g
6feb8748d3

Thanks for anyone helping: Doug Lyons,
Fabian Maurer (Wine), Zebediah Figura (Wine)

I intend to port it back into 0.4.14RC so that
none of our releases will be affected.
2020-09-01 22:10:18 +02:00
Serge Gautherie f8b0c7c6dd [MESA] Fix 'ATTRIB_h' typo
clang-cl 10:
'.../attrib.h(32,9): warning: 'ATTRIB_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]'

Addendum to 5f2bebf.
CORE-7499 CORE-14306
2020-08-30 02:00:57 +03:00
Joachim Henze 7c909cbc7c [COMCTL32] Addendum to last commit
Sorry, something went terribly wrong with the CORE-ID
in my head 2 times, one time in the commit comment
and one time in the code!

Addendum to 0.4.15-dev-663-g
cd7db5df89
2020-08-28 01:02:00 +02:00
Joachim Henze cd7db5df89 [COMCTL32] Workaround regression with toolbar in 7zip CORE-16996
The regression was introduced by SVN r68553
3b13364f05

Many thanks to the author Doug Lyons for excellent
cooperation once more. Always a pleasure.
2020-08-28 00:53:18 +02:00
Stanislav Motylkov 22fb1e947d
[SYSDM] Add missing RegCloseKey function calls
Addendum to 06198c5.
2020-08-26 23:22:57 +03:00
Stanislav Motylkov 06198c51ac
[SYSDM] Display system identifier when SMBIOS is not available
Actual for NEC PC-98 and Original Xbox ports.
2020-08-26 23:16:08 +03:00
Kyle Katarn ba006b3d49
[OPENGL32] Remove Err Log Spam from wglMakeCurrent in nominal cases (#3096)
CORE-17224
2020-08-26 19:56:52 +03:00
Serge Gautherie 93f017fcc6
[SHELL32] spec: Update SHRunControlPanel() and SHValidateUNC() parameter types (#3097)
Cherry-pick (missed part of?)
f6be79684f
2020-08-26 17:34:01 +03:00
Vladimir Barinov 2edcb58e65
[MSGINA][SYSSETUP] Implement Friendly UI shutdown dialog (#2762)
Can be activated by installing ReactOS as a Workstation. CORE-12805

References:
- https://www.remkoweijnen.nl/blog/2009/01/16/windows-xp-x64-terminal-server-patch-part-2-optional/
- https://www.remkoweijnen.nl/blog/2011/01/30/using-fast-user-switching-on-domain-xp-computers/

Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2020-08-25 22:52:17 +03:00
Kyle Katarn aab8cd81ff
[SHELL32] Demote noisy ERR() to TRACE() in CRecyclerDropTarget (#3093) 2020-08-25 19:12:17 +03:00
Aobi Chan CL 018d4d39a3
[TRANSLATION] Chinese Traditional translation for "Problem with Shortcut" dialog and improvements (#3079)
- Translation for: setup-reactos, welcome, explorer, appwiz, hdwwiz, intl, mmsys, netid, shell32, syssetup, tapiui.
- Update zh-TW.rc of shell32 (#3075)
- Just found more Simplified Chinese characters, fixed them. (装 > 裝)
2020-08-23 14:28:55 +02:00
Joachim Henze f363c27ab4 [SHELL32] Demote 2 noisy goodpath loggings to TRACE CORE-17216
Those 2 did spam heavily when browsing folders with
many .zip files within. Mark Jansen confirmed that
this is good-path-logging and was just forgotten
to be disabled earlier.
2020-08-23 00:35:02 +02:00
Katayama Hirofumi MZ ed445dd775
[SHELL32] Enable CopyTo/MoveTo textbox functionality (#3075)
- The user can enter the full path of a directory in "Copy To Folder" and "Move To Folder" features.
- Fix two bugs in SHBrowseForFolder function. One is disability of text box to enter a full path. Another one is disability to choose the root item in BFFM_SETSELECTION.
- Add ES_AUTOHSCROLL style to text box. This enables the user to enter a long text.
CORE-11132
2020-08-20 11:35:14 +09:00
Andreas Hausmann a54004893f
[BROWSEUI] Few corrections for German (de-DE) translation (#3067)
Corrected some mistakes
2020-08-19 18:18:05 +03:00
Stanislav Motylkov 78607860b7
[SHELL32] Addendum to 4156fd5 2020-08-18 16:50:59 +03:00
Stanislav Motylkov 4156fd5182
[SHELL32] Improve Russian translation
Addendum to 46ff964. CORE-11132
2020-08-18 16:26:52 +03:00
Aobi Chan CL 53bb510352
[TRANSLATION] Improve Chinese Traditional (zh-TW) translation (#3065) 2020-08-18 14:26:04 +03:00
Piotr Hetnarowicz 78e3407c1d
[TRANSLATION][BROWSEUI] Polish "MoveTo" description fix (#3074) 2020-08-18 12:58:48 +02:00
Piotr Hetnarowicz 7d373689fe
[TRANSLATION][SHELL32] Update Polish translation of the "MoveToFolder" dialog (#3072) 2020-08-18 12:53:50 +02:00
Katayama Hirofumi MZ fde7a3b764 [SHELL32] Update Japanese translation 2020-08-18 09:27:10 +09:00
Katayama Hirofumi MZ 46ff964e22
[SHELL32] Implement Move To Folder (#3056)
- Add context menu item "Mo&ve to folder..." and implement the action.
- Implement the "Mo&ve to folder..." menu item of "Edit" menu of Explorer.
CORE-11132
2020-08-18 05:30:54 +09:00
Mark Jansen 679c95597c
[SHELL32] Fix sorting on size for big files
CORE-17205
2020-08-17 18:17:24 +02:00
Kyle Katarn 61d89dec8e
[SHELL32] French translation for "Problem with Shortcut" dialog (#3047) 2020-08-17 17:41:59 +03:00
Piotr Hetnarowicz 569a3d63f5
[TRANSLATION][SHELL32] Update Polish translation ("copy to folder" dialog) (#3064) 2020-08-17 16:41:31 +02:00
Tibor Lajos Füzi 2490b675fb
[TRANSLATION] Hungarian translation update for aclui, avifil32, browseui, comdlg32, crypt32, cryptdlg, shell32, userenv (#2978) 2020-08-17 16:39:42 +02:00
Jose Carlos Jesus 4180592654
[TRANSLATION] Update Portuguese (Portugal) translation for CPL files (#3062) 2020-08-17 17:28:09 +03:00
Stanislav Motylkov 1197c90592
[ZIPFLDR] Fix several dialog layout problems
Addendum to a1108f6. CORE-17209

Co-authored-by: Doug Lyons <douglyons@douglyons.com>
2020-08-17 16:12:10 +03:00
Stanislav Motylkov b65ff2084f
[SYSDM] Localize hardcoded megabyte units
CORE-12485 CORE-16915
2020-08-17 14:18:09 +03:00
Stanislav Motylkov 94ca261449
[SYSDM] Fix virtual memory dialog layouts 2020-08-17 04:26:31 +03:00
Stanislav Motylkov 79767e1bc6
[SYSDM] Add placeholders for simpler visual editing 2020-08-17 03:38:27 +03:00
Stanislav Motylkov b5368185da
[SYSDM] Better formatting of user profile size 2020-08-17 03:18:01 +03:00
Stanislav Motylkov 1601afd0a6
[SYSDM] Whitespace fixes only 2020-08-17 03:16:07 +03:00
Stanislav Motylkov 35de9f3925
[SHLWAPI] Add French translation for size units
Reference: https://fr.wikipedia.org/wiki/Octet

CORE-12485 CORE-14011
2020-08-17 01:32:37 +03:00
Katayama Hirofumi MZ 8f907ea83a
[SHLWAPI] Localize StrFormatByteSizeA/W (#3051)
CORE-14011
2020-08-17 06:40:39 +09:00
Brock Mammen f0d6d9896d
[SHELLFIND] Fix column sorting (#2814)
CORE-16825
2020-08-16 19:02:42 +03:00
Jose Carlos Jesus 887764e607
[COMCTL32] Fix issue on showing current mouse pointer (#2829)
GetIconInfo() fill info.hbmColor with NULL HBITMAP handle on black/white bitmaps.

CORE-17062
2020-08-16 18:42:12 +03:00
Stanislav Motylkov 685084b63c
[UXTHEME] Properly show disabled close button
CORE-17203
2020-08-16 17:34:38 +03:00
Stanislav Motylkov 9900089fa6
[SHELL32] Fix Russian translation
Addendum to 5187ec8 and 824a52a. CORE-10972 CORE-12906
2020-08-16 16:06:52 +03:00
Stanislav Motylkov a95c7356ce
[SHELL32] Russian translation for Copy To Folder
Addendum to 85fdcdf. CORE-11132
2020-08-16 15:32:26 +03:00
Katayama Hirofumi MZ 1d1bb53321
[SHELL32] Fix regression #2703 CORE-17041 (trial) (#3046)
CORE-17041
2020-08-16 11:16:44 +09:00
Joachim Henze 2d4c27c96e [SHELL32] de-DE translation for CORE-11132
Addendum to 0.4.15-dev-524-g
85fdcdf2cc
to keep the german localization up to date
for the new Copy-To-Folder-Dlg.
2020-08-16 02:15:06 +02:00
Katayama Hirofumi MZ 85fdcdf2cc
[SHELL32] Implement Copy To Folder (retrial) (#3044)
- Add context menu item "Copy to &folder..." and implement the action.
- Implement the "Copy to &folder..." menu item of "Edit" menu of Explorer.
CORE-11132
2020-08-16 08:04:07 +09:00
Thomas Faber 12186bec12
[TIMEDATE] Fix a broken function pointer cast. 2020-08-15 22:37:42 +02:00
Stanislav Motylkov 037e84ec7f
[SHELL32] Russian translation for "Problem with Shortcut" dialog
Addendum to a3ec01c. CORE-16816
2020-08-15 17:26:15 +03:00
Joachim Henze e95643c7c9 [SHELLBTRFS] Prevent the compression dropbox from accepting free text CORE-16971
Initially proposed to ros via https://github.com/reactos/reactos/pull/2677
and already integrated upstream Apr 28, 2020 by
aba729c8f5
2020-08-15 13:43:00 +02:00
Piotr Hetnarowicz 9170432c8f
[SHELL32] Polish translation for "Problem with Shortcut" dialog (#3043)
pl-pl Polish translation update for new dialog with SHORTCUT
2020-08-15 02:07:32 +09:00
Katayama Hirofumi MZ 90456e54a4
[APPWIZ] Don't hung up in Gecko download cancellation #3049
Do not call EndDialog outside the dialog procedure.
CORE-14538
2020-08-14 23:40:10 +09:00
James Tabor 96a357b595 [ComDlg32] Fix Driver String
Use a fixed string for driver name, same as Windows.
2020-08-13 21:31:04 -05:00
Katayama Hirofumi MZ a3ec01cc28
[SHELL32] Add IDD_LINK_PROBLEM and IDS_LINK_INVALID (#3037)
A resource dialog and a resource string for shortcut problem. CORE-16816
2020-08-12 14:16:25 +09:00
Katayama Hirofumi MZ 526c23bde6
[IMM32] Improve imm32.spec (#3036)
CORE-11700
2020-08-12 06:04:28 +09:00
Katayama Hirofumi MZ 4b038ec8b7
[IMM32][NTUSER] Add ImmGetImeInfoEx (#3035)
- Add the definition of imm32!ImmGetImeInfoEx function.
- Add IMEINFOEXCLASS and IS_IME_HKL into "ntuser.h".
- Modify NtUserGetImeInfoEx function prototype.
CORE-11700
2020-08-12 06:03:29 +09:00
Katayama Hirofumi MZ ee231d00b9
[SHELL32] Improve callbacking of CDefView (#3031)
- Delete DefMessageSFVCB method.
- Add some callbacking.
2020-08-11 16:00:16 +09:00
Katayama Hirofumi MZ 1f31905ecd
[SHELL32] Optimize change notification (#3030)
- Keep the directory lists only.
- Don't remember file sizes and normal file paths.
CORE-13950
2020-08-10 13:34:48 +09:00
Oleg Dubinskiy 8d682f9b05
[IMM32] Stub ImmRegisterClient CORE-16479 (#3009)
Add a stub for ImmRegisterClient function in imm32.dll. CORE-16479
2020-08-09 22:49:00 +09:00
Katayama Hirofumi MZ 2705abfb07
[IMM32] Add ImmShowSoftKeyboard and ImmDestroySoftKeyboard (#3027)
CORE-11700
2020-08-09 22:42:17 +09:00
Katayama Hirofumi MZ ec9d277d59
[IMM32][NTUSER] Implement ImmGetHotKey (#3025)
CORE-11700
- Implement imm32!ImmGetHotKey function.
- Modify NtUserGetImeHotKey function.
- Add LPHKL typedef into <imm.h> header.
2020-08-09 22:41:11 +09:00
Stanislav Motylkov 357db6d191
[SYSSETUP] Fix Russian translation (#3017)
Addendum to 75a0787.
2020-08-08 14:32:10 +03:00
Oleg Dubinskiy a1108f6155
[ZIPFLDR] Add some bitmap resources CORE-17092 (#2875)
Add some bitmap images to our zipfldr shell extenson. MS version of this has them, but our one currently hasn't. And I think without bitmaps the wizard dialogs look a bit incompleted.
I made them similar to MS bitmaps. They have exactly the same size (height x width), but looks differently, in ReactOS Tango style. CORE-17092
2020-08-08 14:13:54 +09:00
Katayama Hirofumi MZ f7865b8bfa
[IMM32] Add ImmSetActiveContext stub (#3026)
CORE-11700
Add imm32!ImmSetActiveContext and ImmSetActiveContextConsoleIME function stubs.
2020-08-08 09:46:13 +09:00
Vladimir Barinov 75a078709a
[SYSSETUP] Fix Russian translation (#3017) 2020-08-04 16:25:33 +03:00
Serge Gautherie 98bbe8358c
[REACTOS] Fix GetTokenInformation() usage (#2997)
The first call to GetTokenInformation is used to determine the size of a TokenInformation buffer.
It should fail and return ERROR_INSUFFICIENT_BUFFER
2020-07-21 15:39:11 +03:00
Serge Gautherie 0f8306b37f
[CRYPT32] CRYPT_ExportKeyTrans(): Check 'CRYPT_ConstructBitBlob()' return value (#2983)
Import 3e8b07309c
CORE-8156

Co-authored-by: Victor Martinez Calvo <vmartinez@reactos.org>
2020-07-18 15:40:05 +02:00
Serge Gautherie b509658280
[CMAKE] Remove obsolete 'CMAKE_CXX_COMPILER_VERSION' checks (#2981)
Following upgrade to RosBE 2.2.0 support and GCC 8.4.
2020-07-18 15:37:29 +02:00
Serge Gautherie d6c4411207 [MSGINA] gui: Improve 'DlgData_Destroy()'
Addendum to 623dd26cce.
2020-07-11 01:44:26 +02:00
Serge Gautherie db2aa4c8ca [APISETS] api-ms-win-core-localization-l1-2-1: Is NT6.3+ actually
CORE-17095
2020-07-11 01:16:38 +02:00
Serge Gautherie 0de16bc3ba [APISETS] api-ms-win-core-localization-l1-2-0: Is NT6.2+ actually
CORE-17095
2020-07-11 01:16:38 +02:00
Serge Gautherie 871f96b66e [APISETS] api-ms-win-core-localization-l1-1-0: Is NT6.1+ actually
CORE-17095
2020-07-11 01:16:38 +02:00
Thomas Faber 292f67af5b
[MBEDTLS] Update to version 2.7.16. CORE-17155 2020-07-04 21:53:46 +02:00
Thomas Faber e57126f5e5
[MBEDTLS] Switch license headers to the dual-licensed version. CORE-17155
This is the default going forward, and separating it out into its own
commit removes the noise from the following sync commit.
2020-07-04 21:53:42 +02:00
Oleg Dubinskiy 622f187c04
[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub
See https://www.geoffchappell.com/studies/windows/win32/services/svchost/dll/svchostpushserviceglobals.htm.
2020-06-27 14:55:28 +02:00
Serge Gautherie 2dfcb500e2
[MSI] Remove obsolete '__ASM_DEFINE_FUNC()'
MSVC build reports:
{{
dll\win32\msi\msvchelper.h(3): warning C4005: '__ASM_DEFINE_FUNC': macro redefinition
sdk\include\reactos\wine/asm.h(60): note: see previous definition of '__ASM_DEFINE_FUNC'
dll\win32\msi\custom.c(547): warning C4003: not enough actual parameters for macro '__ASM_DEFINE_FUNC'
}}

Addendum to 476c99b and 9efafd6.
2020-06-27 14:48:00 +02:00
Serge Gautherie 82272f03e3
[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()'
Addendum to 0f5d91b.
CORE-16441
2020-06-27 14:48:00 +02:00
Serge Gautherie bf88ce89c8
[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type
MSVC 'Release' build reports:
'dll\apisets\api-ms-win-crt-utility-l1-1-0_stubs.c(41): warning C4391: 'int llabs()': incorrect return type for intrinsic function, expected '__int64''

Addendum to 3f15a0d.
2020-06-27 14:46:15 +02:00
Serge Gautherie 4213c70e2e
[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive.
* _atexit_cleanup is no longer used
* Fix cppcheck 'pointerSize' warning
2020-06-27 14:35:32 +02:00
Jared Smudde 9e20be0fbf [SYSDM] Set the proper icon in title bar 2020-06-27 10:22:07 +02:00
Thomas Brogan 88300ec3b3
[WINMM] Improve implementation of timeGetTime, timeBeginPeriod, timeEndPeriod (#2933)
Use QueryPerformanceCounter if a high-resolution timer is requested (<= 5ms) instead of the more inaccurate GetTickCount.
2020-06-20 13:28:25 +03:00
Hervé Poussineau ea4af587a9 [SETUPAPI] Add function names in traces 2020-06-20 08:16:07 +02:00
Oleg Dubinskiy 1761bedb82 [VSSAPI] Add missing wrapper for ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z and _VSSAPI_CreateVssBackupComponents@4 in msvc.s, to fix MSVC compilation 2020-06-07 19:45:05 +02:00
Oleg Dubinskiy 23a1f8d335 [VSSAPI] Import Wine commits "Stub CreateVssBackupComponentsInternal + ?CreateVssBackupComponents@@YGJPAPAVIVssBackupComponents@@@Z"
ce9b5a7e17
767c94bc5c
CORE-9511.
2020-06-07 19:45:05 +02:00
Oleg Dubinskiy 31e00140d3
[RPCRT4] Export NdrCreateServerInterfaceFromStub as stub
Required by MS ole32.dll CORE-15395, CORE-17004.
2020-06-07 14:08:58 +02:00
Thomas Faber 185591368d [SHELLBARS] Add missing psdk dependency. 2020-06-06 23:02:35 +02:00
Thomas Faber 789c88c185 [MSTASK] Add netapi32 dependency to ensure atsvc_c.h is available. 2020-06-06 23:02:35 +02:00
Amine Khaldi 139a3d6661
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
Serge Gautherie abe1dd31c4
[SHLWAPI] lang/*.rc : Enforce aa-BB filenames (#2816) 2020-06-06 18:25:43 +02:00
Serge Gautherie 8140203940
[KERNEL32] FatalAppExitW: Add an 'UNREFERENCED_LOCAL_VARIABLE(Status)' (#2883)
Addendum to 21d2accad3 (r71793).
2020-06-04 23:35:54 +03:00
Serge Gautherie 450425028c
[IPHLPAPI] getNumInterfacesInt(): Remove 'if()' redundant condition (#2884)
No impact.

Detected by Cppcheck: redundantCondition.
Addendum to 1fe3a2d6c3 (r9788).
2020-06-04 23:26:28 +03:00
Katayama Hirofumi MZ 7c9a8c0b89
[SHELL32] Improve readability of filesystem notification (#2737)
Improve human readability of filesystem change notification.
- Rename the identifiers for human readabilities.
- Split the code into CFilePathList and CDirectoryWatcher classes.
- Encapsulation of code.
CORE-13950
2020-06-02 18:42:07 +09:00
Jose Carlos Jesus 3dad100ea4
[TRANSLATION] Add/update Portuguese translation (#2850)
- Add translation for: iernonce, modmui.
- Update translation for: jscript, msports, shell32.
2020-06-01 20:48:58 +02:00
Jose Carlos Jesus 8189133865
[TRANSLATION] Add/Update Portuguese translation for some shell extensions (#2845)
- Add translation for: devcpux, netplwiz, ntobjshex, stobject, zipfldr.
- Update translation for: sendmail.
2020-06-01 20:31:06 +02:00
Serge Gautherie 7094297b7a
[APISETS] Fix some functions that are NT10(v1607)+ (#2738)
- *_onexit_*() are NT10(v1607)+
- *_seh_filter_*() are NT10(v1607)+ actually

CORE-16700
2020-06-01 20:04:32 +03:00
Serge Gautherie 64fea1dbd0
[MSGINA] gui: Improve DlgData_LoadBitmaps() (#2520)
And let bar timer depend on the bar image only.

Addendum to 623dd26cce.
2020-06-01 12:26:53 +03:00
Serge Gautherie 6baa151888
[APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805)
* api-ms-win-downlevel-shell32-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-shcore-obsolete-l1-1-0.dll is NT10+ and win32 only
* api-ms-win-downlevel-shlwapi-l2-1-0.dll is NT10+ and win32 only

CORE-8880
2020-06-01 12:20:13 +03:00
Serge Gautherie 703c56beb3
[REACTOS] RegQueryValueExW() wants bytes, not chars (#2876)
Cherry-pick:
a359e02666
0662da18b8
e4e5eda3d9

CORE-9665

Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
2020-06-01 12:06:49 +03:00
Timo Kreuzer cb99761bc1 [NTDLL] Use lowest OS version GUID in the application manifest, instead of highest 2020-05-31 13:14:01 +02:00
Timo Kreuzer 0ed8b916e4 [MSTASK] Add C stubs and comment out decorated exports
MSVC's LINK is not able to export both the undecorated and decorated symbol from the same dll. This results in an incoherence between the spec file entries and the actual exports, breaking the dll export versioning.
2020-05-31 12:26:37 +02:00
Katayama Hirofumi MZ 99b52df014
[SHELL32][INCLUDE] Improve CheckEscapesA/W (#2795)
Fix and improve shell32!CheckEscapesA/W functions.
Add a testcase for shell32!CheckEscapesA/W to shell32_apitest.
2020-05-28 10:58:26 +09:00
Serge Gautherie 11345aedd8
[FORMATTING] [CMAKE] Remove space in 'if (' (#2847) 2020-05-26 20:24:02 +02:00
Serge Gautherie 03d5ff7f68
[MMSYS] OnHScroll(): Fix wrong '&&' operator (#2855)
CORE-17079
2020-05-25 19:57:52 +02:00
Timo Kreuzer dd7fb63cd1 [ADVAPI32] Convert ordinals to @ in spec file 2020-05-24 08:22:24 +02:00
Tibor Lajos Füzi 1017c73a9c
[TRANSLATION] Hungarian translation update for shell32 (#2828) 2020-05-23 19:20:16 +02:00
Serge Gautherie 99d0a348aa
[LSASRV] LsapLogonUser(): Fix 'AuthenticatingAuthority' copypasta (#2839)
Reported by contributor 'qarmin'.
CORE-17074
2020-05-23 19:07:04 +02:00
Timo Kreuzer f323778b0b [NTDLL] Rename ExportEntry to ExportDirectory to better represent what it is 2020-05-23 17:30:52 +02:00
Piotr Hetnarowicz 35b5876a95
[APPWIZ] Polish translation update (#2790)
FIXED: dialogs, button, description
2020-05-23 15:43:56 +02:00
Eric Kohl cf62e22974 [USERENV] Implement DeleteProfileW() 2020-05-23 12:37:16 +02:00
Eric Kohl 5bc6f79399 [SAMSRV] SampInitializeSAM: Fix indentation and add comments 2020-05-23 12:30:54 +02:00
Kyle Katarn 57401cb66d
[DEVMGR] Use the ShellAboutW API routine to display the about dialog and French translation update (#2807)
As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
Similar to #2743 by @HBelusca
2020-05-22 22:53:17 +09:00
Kyle Katarn 4ce7081766
[SYSSETUP][MAIN] Fix Mouse Properties UI and improve French translation (#2810)
- PS2 Mouse Advanced Properties : Static control (frame) added
- PS2 Mouse Advanced Properties : French translation added and control layout adapted accordingly
- Mouse CPL > Wheel > Sroll line text box ES_NUMBER style added
- ReactOS Setup : French translation added
2020-05-22 22:49:27 +09:00
Serge Gautherie ef6711c904
[SYSSETUP] DoWriteProductOption(): Fix 'pData' copypastas (#2826)
Addendum to 612729b092.

CORE-17069
2020-05-22 01:52:50 +09:00
Jose Carlos Jesus c3ab469e44
[ACCESS.CPL] Improvements to Portuguese translation (#2800) 2020-05-21 15:36:33 +02:00
Serge Gautherie 924f19f6dc
[REACTOS] Remove executable bits on source files (#2822) 2020-05-20 23:09:44 +02:00
Kyle Katarn 357b3fa858
[MAIN.CPL] Fix of Keyboard settings French translation (#2812) 2020-05-20 15:47:24 +02:00
Kyle Katarn b8f7d4c56d
[TIMEDATE] French translation (#2811) 2020-05-20 15:45:47 +02:00
Mark Jansen 83a9f71690
[SHELL32] Allow creation of an empty CFileSysEnum
CORE-16908
2020-05-19 20:35:52 +02:00
Joachim Henze 4cbb21761c [SYSSETUP] Fix broken build on RosBE2.1.6 CORE-17028
The build broke due to a typo introduced by
0.4.15-dev-275-g
612729b092

../dll/win32/syssetup/wizard.c: In function 'ProductPageDlgProc':
../dll/win32/syssetup/wizard.c:527:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-
after-statement]
cc1.exe: all warnings being treated as errors
2020-05-19 20:32:21 +02:00
Kyle Katarn fb2a9bb60d
[JOY] Fix missing UI elements and French translation (#2808)
Missing GUI elements added.
Improve French translation.
2020-05-19 19:09:05 +09:00
Katayama Hirofumi MZ 612729b092
[SYSSETUP][BOOTDATA] Make Server default again and write Service Pack (#2749)
- Make "ReactOS Server" the default product option again instead of "ReactOS Workstation".
- Write "Service Pack" info onto registry.
- Add ProductOption option to bootcd unattend.inf.
- Delete IDC_PRODUCT_SUITE and IDC_PRODUCT_TYPE controls.
CORE-17028
2020-05-19 15:41:26 +09:00
Jose Carlos Jesus d5784d6345
[DESK][TIMEDATE] Update Portuguese translation (#2801) 2020-05-17 23:53:54 +02:00
Eric Kohl 6efb3cbe03 [SETUPAPI] Implement CM_Get_Next_Res_Des_Ex() partially (WIP) 2020-05-17 20:04:26 +02:00
Julen Urizar Compains 546862babc
[TRANSLATION] Update Spanish, and add Basque translation (#2667)
Add/update translation for:
charmap_new, logoff, mspaint, notepad, usetup, welcome,
hotplug.cpl, sysdm.cpl, aclui.dll, comctl32.dll, comdlg32.dll,
hhctrl.ocx, kernel32.dll, msi.dll, oledlg.dll, shell32.dll,
tapiui.dll, themeui.dll, wininet.dll, winmm.dll, wldap32.dll,
winsrv.dll.
2020-05-17 18:46:36 +02:00
Jose Carlos Jesus cd0c06bef3
[ACPPAGE] Add Portuguese translation (#2802) 2020-05-17 18:12:11 +02:00
Mark Jansen 332889b8d7
[COMDLG32] Differentiate between real and virtual folders,
do not allow traversal inside virtual folders when selecting a file
CORE-16908
2020-05-17 17:09:05 +02:00
Mark Jansen f379a29606
[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders
CORE-16908
2020-05-17 17:09:04 +02:00
Mark Jansen b1003ae909
[SHELL32] Update CFileSysEnum to be maintaineable
CORE-16908
2020-05-17 17:09:04 +02:00
Mark Jansen ac215455bb
[SHLWAPI] Fix SHRegGetCLSIDKeyW 2020-05-17 17:09:04 +02:00
Jose Carlos Jesus 2bd6bfdd90
[COMCTL32] Fix recalculation of property-sheet dialog position (#1818)
During initialization of property sheet dialogs, their overall size can change (when adding property sheets) after the dialog has been created and pre-positioned by win32k.
Therefore their position needs to be recomputed so that they try to fit the best on screen.

CORE-9008, CORE-9602
2020-05-15 18:12:02 +02:00
Katayama Hirofumi MZ 62e59652a0
[SHELL32] Don't hardcode C: drive again (#2777)
- Avoid buffer overrun.
- Don't hardcode C: drive.
CORE-13235
2020-05-15 16:36:13 +09:00
Katayama Hirofumi MZ 6c3775f77c
[SHELL32] Implement SheShortenPathA (#2785)
Implement shell32!SheShortenPathA function.
2020-05-14 22:52:22 +09:00
Katayama Hirofumi MZ b7a97a2af2
[SHELL32] Implement MakeShellURLFromPathA (#2784)
Implement shell32!MakeShellURLFromPathA function.
2020-05-14 22:51:53 +09:00
Ricardo Hanke 0c5f367172
[OPENGLCFG] Empty list boxes if registry key is missing (#2750)
If the registry key that holds the names of installed opengl drivers is missing, all list boxes in openglcfg are empty. This is a minor code rearrangement to fix this behavior.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-05-14 14:47:48 +02:00
Piotr Hetnarowicz 64ba6e64c8
[SHELL32] PL-pl Dialogs fix (#2788)
- Fixed invisible text in DIALOGS.
2020-05-14 14:33:32 +02:00