Don't call ClientToScreen in handling NM_RCLICK message because NMMOUSE.pt is already in screen coordinates.
CORE-18966
A backport of:
0.4.15-dev-6298-g b4e946f5b0
and strip EOL whitespace
This is a partial backport of:
0.4.8-dev-946-g 7082b621a5
It fixes the broken bootcd Startmenu (and very likely also other stuff, like 3rd party apps)
for zh-CN by untranslating selected folder paths.
It regressed in multiple steps on master before the SVN->GIT-transition.
Ftr: It was mentioned in the PR, that even MS Windows for Simplified Chinese does not translate those folders.
shell32.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.7 8.668.160 -> 8.668.160
shimgvw.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.7 173.056 -> 173.056
syssetup.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.7 829.440 -> 829.440
userenv.dll GCC4.7.2dbg RosBEWin2.1.6 0.4.7 185.344 -> 185.344
0.4.15-dev-5927-g bfc6a119c5 [ADVAPI32] Do not fail on creating a registry key if the security attributes have an invalid length. (#5230) fixes regression CORE-15471
partially 0.4.15-dev-999-g 889b077b23 [REACTOS] *.spec: Fix some function/parameter types (only the [ADVAPI32] part)
0.4.14-dev-1245-g 8ae8083378 [ADVAPI32][PSDK] CryptReleaseContext(): dwFlags parameter is DWORD, only
0.4.13-dev-666-g f3a9b524f1 [ADVAPI32] Fix copying the TokenSource string
0.4.13-dev-363-g 46259092f9 [ADVAPI32:REG] Remove some useless casts (#1614)
0.4.12-dev-237-g 446e13745c [ADVAPI32] Stop pretending our advapi32 is NT6+, inconsistent TEB definitions CORE-15526
also fix a bit of whitespace, wrong format-strings and missing \n in debugprints
---------
in 0.4.9 + 0.4.10: scm.c: fix wrong arguments count in 2 TRACEs, which were introduced by the guilty 0.4.9-dev-417-g 32bb592e12
Contrary to that delete all those TRACEs in 0.4.7 and 0.4.8 because they have been touched a thousand times after their introduction to fix all their format-string-glitches.
---------
in 0.4.7+0.4.8+0.4.9 reg.c: delete load_string() and RegLoadMUIStringW(), inspired by 0.4.10-dev-502-g d559ca9c98
Both were neither used, nor exported yet luckily in <=0.4.9
Tip: In 0.4.9 dxdiag network.c we got some interesting workaround code worth to look at if ever needed for older releases. Search for "RegLoadMUIString" within
---------
advapi32.dll master GCC8.4.0dbg 671.232
advapi32.dll 0.4.14 GCC4.7.2dbg 602.624 -> 602.624
advapi32.dll 0.4.13 GCC4.7.2dbg 602.112 -> 602.112
advapi32.dll 0.4.12 GCC4.7.2dbg 615.424 -> 615.424
advapi32.dll 0.4.11 GCC4.7.2dbg 613.888 -> 613.888
advapi32.dll 0.4.10 GCC4.7.2dbg 604.672 -> 604.672
advapi32.dll 0.4.9 GCC4.7.2dbg 607.744 -> 604.672
advapi32.dll 0.4.8 GCC4.7.2dbg 602.624 -> 589.824
advapi32.dll 0.4.7 GCC4.7.2dbg 601.600 -> 589.312
Ports back:
0.4.15-dev-5910-g 99e5f51d5b
in a slightly adapted form, which respects that we were still
a "Team" in 0.4.7 - 0.4.14 and no "Project" yet.
The idea with the "Project" was born during 0.4.15-dev'ing.
That existing difference does also manifest in media/inf/*.inf and I don't intend to
ever change that for the older branches.
That means also that in the older branches we do not need to scroll at all to
see all the text.
Also adopt ReactOS birth year from 1998 to 1996 which we do also use in the msgina startup-dlgs-pics
all the way from releases/0.4.7 at least to todays master head.
this ports back (also) the following commit:
0.4.15-dev-6308-g 2d9877470d
While touching those files, port back some minor translation improvements also.
but actually I did concentrate here on porting back the following commits:
0.4.8-dev-547-g e9d8fa57c3 [TRANSLATION][BASE][FDEBUG][MODULES][WIN32SS] Use correct font name in Chinese resources, CORE-9566 (#227)
0.4.8-dev-546-g d09998dfc7 [TRANSLATION][APPLICATIONS] Use correct font name in Chinese resources, CORE-9566 (#226)
0.4.8-dev-539-g bf51ed17f8 [SHELLEXT] Use correct font name in Chinese resources, CORE-9566 (#224)
0.4.8-dev-538-g 1ebe4a5b83 [TRANSLATION] Use correct font name in Chinese resources, Part 3/3, CORE-9566 (#223)
0.4.8-dev-537-g 074f5c6c13 [TRANSLATION] Use correct font name in Chinese resources, Part 2/3, CORE-9566 (#222)
0.4.8-dev-536-g 81d6232aa3 [TRANSLATION] Use correct font name in Chinese resources, Part 1/3, CORE-9566 (#221)
partially 0.4.8-dev-534-g b214b160b6 setup: Use correct font name in resource: CORE-9566 (#219) (I left out all the changes to [WELCOME])
0.4.8-dev-533-g 2b91b29642 [CPL] Control Panel Applets: Use correct font name in Chinese resources, CORE-9566 (#220)
------
tr-TR.rc: Also strip outdated email address erdemersoy@live.com instead of following 0.4.8-dev'ing
with replacing it with an even longer address, that later got changed another time.
The auto-replacement during 0.4.8-dev'ing did lead to some very long lines in many header sections. Don't want that.
partially 0.4.15-dev-6292-g 5f533bd019 [RAPPS] Update *.rc
partially 0.4.15-dev-6280-g ec974d8a81 [RAPPS] Main toolbar: Tooltip strings refactoring (#5007)
0.4.10-dev-210-g 0ec08818b5 [RAPPS] Select the search bar with ctrl+f
and pick some other translation improvements from master, strip outdated email-addresses
releases/0.4.7 - releases/0.4.11: Had a bug regarding category "Selected for installation",
it was populated with garbage after starting up the app. The bug in ReactOS is outside of the rapps source-folder.
So I decided to delay introduction of that feature to releases/0.4.12
Localized resources should use the correct Korean fonts that are most suitable
for UI and compatible with Windows.
fix picked from commit 0.4.8-dev-548-g 89f9c9101a
This fixes a part of CORE-9566
This fixes:
CORE-15363 'netstat TCP foreign address port is wrong'
CORE-5401 'Netstat returns ERROR_NO_DATA Pipe being closed'
CORE-5126 'UNIMPLEMENTED: iphlpapi: GetExtendedUdpTable'
even without touching the netstat binary yet.
And is mostly based on work done by Pierre Schweitzer during 0.4.11-dev'ing.
by porting back:
0.4.15-dev-6231-g a5360f542f [IPHLPAPI] Formatting only, no functional change
partially 0.4.14-dev-1425-g f540b2b20c [IPHLPAPI] GetAdaptersAddresses(): Add 1 free() in ERROR_NO_DATA case (#2526) (but leave out adding the comments in .h)
0.4.12-dev-686-g 22f60faf43 [IPHLPAPI] Remove dead code to fix CID 513306, 1442673, 1442697
0.4.11-dev-880-g bf052e120b [IPHLPAPI] Reduce code duplication and use a single function for TCP and UDP enumerations + fix corruption
0.4.11-dev-867-g 159f5b676a [IPHLPAPI] Fix broken size computation leading to buffer overrun
0.4.11-dev-861-g 05657bfcfd [SDK] Add a non documenter TOIID used to query modules information
0.4.11-dev-827-g ce7f9211a0 [TCPIP] In InfoTdiQueryGetConnectionTcpTable(), only return if there's a connection
0.4.11-dev-823-g 0ec92100bc [TCPIP] Properly display local information for established connections
0.4.11-dev-819-g fbdfe7bd40 [SDK] Add GetExtendedUdpTable()
0.4.11-dev-818-g 370b03b523 [IPHLPAPI] Reimplement GetUdpTable() using GetExtendedUdpTable()
0.4.11-dev-817-g 58cef01422 [IPHLPAPI] Implement GetExtendedUdpTable() CORE-5126
0.4.11-dev-816-g 6fb6c7b50b [IPHLPAPI] Implement getOwnerUdoTable(), to get UDP connections with owner PID
0.4.11-dev-815-g 13de7f08af [TCPIP] Implement enumerating UDP connections with owner PID
0.4.11-dev-813-g 73c87d5c14 [IPHLPAPI] Reimplement GetTcpTable() using GetExtendedTcpTable()
0.4.11-dev-812-g d76ac645e8 [IPHLPAPI] Don't leak memory
0.4.11-dev-811-g c949a12506 [IPHLPAPI] Implement the IPv4 TCP_TABLE_OWNER_PID_* cases in GetExtendedTcpTable()
0.4.11-dev-810-g dca7e5689f [IPHLPAPI] Implement getOwnerTcpTable(), to get TCP connections with owner PID
0.4.11-dev-809-g 411504b5f4 [TCPIP] Implement enumerating TCP connections with owner PID
0.4.11-dev-808-g 935978ee57 [TCPIP] Store creator PID in ADDRESS_FILE
0.4.11-dev-807-g 702d44c683 [IPHLPAPI] Implement the IPv4 TCP_TABLE_BASIC_* cases in GetExtendedTcpTable()
0.4.11-dev-804-g 91b013d387 [TCPIP] When enumerating sockets, retrieve their state and return it
0.4.11-dev-803-g 738f327668 [IP] Add a TCPGetSocketStatus() wrapper around LibTCPGetSocketStatus()
0.4.11-dev-802-g 29c1510423 [LWIP] Implement a LibTCPGetSocketStatus() function in our LwIP glue
0.4.11-dev-792-g 8a98c85c1f [IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections
0.4.11-dev-784-g f29016dabe [TCPIP] Properly handle listening sockets
0.4.11-dev-782-g 007f43dd56 [TCPIP] Implement returning UDP connections CORE-5401
0.4.11-dev-781-g 77d5f04f22 [TCPIP] Implement returning TCP connections CORE-5401
0.4.11-dev-799-g 500a5151ea [TCPIP] Fix returned IP address when querying TCP connections CORE-15363
0.4.11-dev-783-g d18b1fe24b [IPHLPAPI] Properly count UDP entries CORE-5401
0.4.11-dev-780-g e3cb9697a4 [IPHLPAPI] Implement getNumUdpEntries() and getUdpTable() CORE-5401
0.4.11-dev-779-g 678204790c [IPHLPAPI] Implement getNumTcpEntries() and getTcpTable() CORE-5401
0.4.9-dev-59-g b6c060ce04 [IPHLPAPI] Fix getNumRoutes() return value on Mib error (#391)
----------------
Strip some DPRINTs entirely in IPHLPAPI/TCPIP in releases/0.4.7 - 0.4.10 (instead of fixing them like we did on master). Many of them had x64 issues:
This was partially *inspired* by watching the following commits:
0.4.13-dev-14-g f9a967b2ae [IPHLPAPI] Fix misc 64 bit issues (only the parts in iphlpapi_main.c with the format strings)
0.4.10-dev-409-g 0f8439aa71 [IPHLPAPI] Fix 64 bit issue, just the one within [IPHLPAPI] ifenum_reactos.c
0.4.9-dev-856-g 6c9359221c [IPHLPAPI] ipstats_reactos: Review all TRACE/WARN calls
This does not only fix the x64 incompatibilities by superseding those 3 commits but also will keep the file-sizes under control for the backports.
fix CORE-18328 'FileZilla 3.8 unable to list content of a remote directory due to undue ECONNRESET'
I tested to list the contents of ftp.heise.de and downloaded some files from its pub.
by porting back:
0.4.15-dev-5870-g 9f9b81e396 [AFD] ReceiveActivity: Don't return STATUS_FILE_CLOSED in case of FCB overread CORE-18328 (#4972)
-------------
fix CORE-13067 'wget can not download'
I tested to wget.exe http://download.microsoft.com/download/vc60pro/update/2/w9xnt4/en-us/vc6redistsetup_deu.exe
by porting back:
0.4.9-dev-349-g 9168226378 [AFD] Respond to FileFsDeviceInformation. CORE-13067 (#440)
0.4.9-dev-350-g 8b84b1c6b3 [AFD] Mark the socket as named pipe, so NtWriteFile actually knows what to do with it. CORE-13067 (#440)
-------------
also port back unrelated:
0.4.8-dev-233-g 44e36b616a [AFD] Zap unused TaCopyAddress() and TaCopyAddressInPlace().
partially 0.4.8-dev-589-g a2f7de7ee8 [AFD] just pick the main.c one-liner with the %p format-string
and a few whitespace improvements from 0.4.8-dev'ing
by picking:
0.4.9-dev-884-g 7b618314c2 [USETUP] Remove now-unneeded file.
0.4.9-dev-849-g 7c3cff3a68 [USETUP] Remove the WIN32 support because usetup is a native-only application
0.4.9-dev-847-g 1b323ff2f4 [USETUP] Remove unused VolumeLabel and FileSystemName from the PARTENTRY type
partially 0.4.9-dev-843-g 3bf2f30cf2 [USETUP] only the Cleanup-part in consup.c, **not** the part which improved on the keys for CORE13975
0.4.8-dev-979-g 25bca520f5 [MBEDTLS] Don't link with zlib, we don't use it. CORE-14290
0.4.8-dev-978-g dc51b419c7 [USETUP] Use the smaller zlib_solo instead of the full zlib. CORE-14290
partially 0.4.8-dev-271-g 5633423086 [USETUP] Silence some clang-cl warnings. (only the [USETUP]-part)
partially 0.4.8-dev-107-g f0e6c11bba [USETUP] NtWriteFile() calls: Remove unused 'ByteOffset = 0',
In sum:
0.4.9 usetup binary size RosBEWin2.1.6 GCC4.7.2dbg == 849.920bytes
0.4.8 usetup binary size RosBEWin2.1.6 GCC4.7.2dbg shrinks from 847.872bytes -> 846.848bytes
0.4.7 usetup binary size RosBEWin2.1.6 GCC4.7.2dbg shrinks from 853.504bytes -> 845.312bytes
Prevent the window from being destroyed twice
fixes CORE-18821 'WIN32K BSOD 0x1E when opening Build menu in AVR Studio 4.19'
port of 0.4.15-dev-5938-g 77d4653164
And port back also some unrelated formatting improvements,
and kill a block of code that was commented out in all branches,
and was not x64 compatible in 0.4.7/0.4.8, and therefore was a diff already anyway.
Optimize IOCTL_CONSOLE_FILL_OUTPUT_ATTRIBUTE and IOCTL_CONSOLE_FILL_OUTPUT_CHARACTER for speed by using cache.
a part of CORE-18838
It is faster because it minimizes the amount of pointer dereferences within the for-loops.
fix picked from 0.4.15-dev-5881-g 3526ffc094
---------
also partially pick unrelated cleanup from:
0.4.14-dev-439-g 75f188c200 (only the change in blue.c)
---------
and take back with me some whitespace-tweaks to bring the file closer to todays releases/0.4.14
Restores *inferior* code for older branches.
I recently ported back the *proper* 0.4.15-dev-4352-g cfe387a9b0
as part of:
0.4.10-release-186-g e5d8019d24
0.4.9-release-197-g 557db9a1ac
0.4.8-release-203-g 78daf4169a
0.4.7-release-229-g e0a3b0c8f5
That backport worked very well in releases/0.4.11 to releases/0.4.14
and it also caused no severe issues for releases/0.4.7 to releases/0.4.10
e.g. the mouse and keyboard works well, tested with VBox4.3.12 & MS VirtualPC 2007 SP1 6.0.192.0
but I noticed some logspam that happens for releases/0.4.7 to releases/0.4.10 and only during 2nd stage:
bad-path (with the commas):
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\kbdclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\mouclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\vbemp.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\kbdclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\mouclass.sys' with status 0xc000003a
(../ntoskrnl/io/iomgr/driver.c:696) Failed to load class upper filters: C000003A
(../ntoskrnl/io/iomgr/device.c:434) No DriverUnload function on PnP driver! '\Driver\I8042PRT' will not be unloaded!
...
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0F03\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0F03\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0303\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3653) Removal pending: ACPI\PNP0F03\2&ccb86d17&0000
(../base/services/umpnpmgr/umpnpmgr.c:3623) Safe removal: ACPI\PNP0F03\2&ccb86d17&0000
good-path (without the commas):
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\system32\drivers\vbemp.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
(../ntoskrnl/mm/ARM3/sysldr.c:3025) ZwOpenFile failed for '\SystemRoot\System32\DRIVERS\i8042prt.sys' with status 0xc000003a
...
(../../ntoskrnl/mm/ARM3/sysldr.c:176) Loading: \SystemRoot\System32\DRIVERS\i8042prt.sys at F771B000 with 1b pages
...
and no such 'Removal pending'
So we do still miss some unknown commit from 0.4.11-dev'ing that will avoid that additional logspam with the corrected hivesys.inf.
I have not identified that commit yet, and until I will, I do play safe by restoring the wrong List-multi-string in hivesys.inf.
0.4.15-dev-5985-g 31fdaca8c0 [REGEDIT] Strip redundant include, minor formatting (#5264)
0.4.15-dev-5970-g 9d7d3314b3 [REGEDIT] Check whether pszSelectKey is NULL on CDN_FILEOK (#5255)
0.4.15-dev-5898-g 84e580b67e [REGEDIT] Fix ListView selection and finding (#5150)
(superseded) 0.4.15-dev-5802-g cce3eb9393 Fix buffer read past end problem. (#5146) CORE-15896 and CORE-18230
partially 0.4.15-dev-5753-g 1ee9ea4518 [REGEDIT] Avoid buffer overflow in SelectNode. CORE-18602 (I left the wscpy-replacement at the end for the fixed size strings, as they would increase binary size, and are totally safe)
partially 0.4.15-dev-5308-g 5daf5cd057 [REGEDIT] Use shell icons for the tree view (#4841) CORE-10764
0.4.15-dev-4850-g 568383c9b9 [REGEDIT] Fix issue at Find registry key (#4341)
partially 0.4.15-dev-2265-g bebdfda8b7 [REGEDIT]... Use newer file open dialog (#3571)
0.4.15-dev-1470-g 9de8787187 [REGEDIT] Display search finished messagebox when using Find Next (F3) menu item (#3371) CORE-17368
0.4.15-dev-1302-g 6aae5f4fdd [REGEDIT] Make "finished find" messagebox owned by Regedit window (#3369) CORE-17367
0.4.15-dev-169-g 0461de33c5 [REGEDIT] Fix HeapFree() on the wrong variable (#2736)
0.4.14-dev-1484-g c832112771 [REGEDIT] Fix tree view popup menu issues CORE-16887
0.4.14-dev-1468-g 763de230b2 [REGEDIT] Fix inconsistent menu state for 'Permissions' CORE-16889
a more efficient solution than 0.4.14-dev-1467-g b280615b85 [REGEDIT] Crash on selecting 'New' on root item 'My computer' CORE-16888
0.4.14-dev-1466-g 13dd917589 [REGEDIT] CORE-16892 fr-FR Translation update
0.4.13-dev-464-g 6b95727282 [REGEDIT] Adjust ListView column widths (#1663) CORE-15187
0.4.12-dev-47-g 63a0ac0461 [REGEDIT] Set background brush to child window (#1122) CORE-15442
0.4.11-dev-481-g efbebf983c [REGEDIT] Improve the layout of controls (#967) CORE-15187
0.4.11-dev-480-g e4c2cff6c8 [REGEDIT] Don't paint background in WM_PAINT (#970) CORE-15187
0.4.11-dev-458-g 125db5ead9 [REGEDIT] Trivial resizing code fix (#950)
0.4.11-dev-457-g b3231e0bf5 [REGEDIT] Code formatting (#949)
0.4.10-dev-244-g b9415740a1 [REGEDIT] Fix importing very big *.reg files (HEX values commonly) (#618)
a few fragments only of 0.4.15-dev-5304-g 36a7f0dc7c [REGEDIT] framewnd.c resize_frame_rect(), main.h strip externs before func declarations and reordering, treeview.c InitTreeViewImageLists()
also port back a few selected translation improvements, and strip the suggestions-feature in older branches <= 0.4.13 which does not exist in 2k3sp2.
port back:
0.4.15-dev-5901-g c37addcbf5 [CONSOLE] Harmonize IDC_LBOX_FONTTYPE height to 40 for *.rc (#5211), tweak some headers
and partially 0.4.15-dev-5503-g 5123edd731 [CONSOLE] Improve font preview and Update de-DE.rc (#4933)
and also pick a few other rc improvements here and there, mainly dupe-accelerator-fixes, and whitespace+logmuting in some .c
0.4.15-dev-5688-g 460a01b167 [BROWSEUI] CORE-18646 Fix crash while editing a label in the folder tree, add missing break
0.4.15-dev-5686-g a777cc2cc4 [BROWSEUI] CORE-18646 Fix crash on backspace while editing a label in the folder panel (#5059)
0.4.15-dev-4497-g beefb07d18 [BROWSEUI] CORE-12804 Remove useless variable and unreachable code (#4483) and strip EOL whitespace
0.4.13-dev-1186-g d41c5be3bd [BROWSEUI] Fix a PIDL leak.
0.4.13-dev-283-g 801ec51a91 [BROWSEUI] Fix indentation
0.4.10-dev-252-g 6e6c46a832 [BROWSEUI] CORE-11141 Re-enable the "Folder Options" menu item (#630) It was originally disabled in SVN r71192 == git 8b77c254f8
partially pick 0.4.9-dev-39-g d281d14fd1 [BROWSEUI] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of GWL_* where appropriate. I picked only the [BROWSEUI] parts
0.4.8-dev-267-g d163627319 [BROWSEUI] Move _ILIsDesktop to a shared header to avoid having 3 instances of it
and inspired by parts of 0.4.8-dev-18-g 5cb0615147 [BROWSEUI] delete some unused variables in brandband.cpp, desktopipc.cpp, shellbrowser.cpp, toolsband.cpp. Unlike the master commit I really deleted the lines. Enough to have the commented out stuff in master.
0.4.15-dev-5890-g 56bf3969cd [SYSSETUP] Tweak IDD_COMPUTERPAGE positioning (#5158)
0.4.15-dev-5875-g 7c755d9b84 [SYSSETUP] Delete obsolete lt-LT.rc
0.4.15-dev-5874-g c762234546 [SYSSETUP] Fix font glitch in ja-JP.rc (#5192)
0.4.15-dev-5871-g 3963d7d5f2 [SYSSETUP] Delete obsolete fi-FI.rc
0.4.15-dev-5772-g 784946db8c [SYSSETUP] Tweak resources CORE-18870
0.4.15-dev-5732-g 909b165c4a [SYSSETUP] Removed qemu credit entirely (#4971)
0.4.15-dev-5678-g cc54ecd779 [SYSSETUP] Fix a space-typo in IDS_WZD_PASSWORDEMPTY for *.rc (#5049)
0.4.15-dev-1102-g ad4c174eb6 [SYSSETUP] fr-FR: Change keyboard accelerator for Owner Organization field (#3282)
0.4.14-dev-1445-g 173a2af48c CORE-16874 [SYSSETUP] Update authors page in second stage setup
(that part got unhidden by 0.4.10-dev-466-g 35f62fc5ba . Picked as one of the needed preparations in case I would ever port back the guilty rev later)
0.4.10-dev-484-g 6d9f89f813 [SYSSETUP] Fix the button sizes of theme selection dialog (#746) CORE-14896
(that part got unhidden by 0.4.10-dev-466-g 35f62fc5ba . Picked as one of the needed preparations in case I would ever port back the guilty rev later) )
and a few other gems from other partially picked master-commits that are not explicitly mentioned here.
--------
Also strip the IDC_LOCALETEXT and IDC_LAYOUTTEXT from the resources as that was only implemented in releases/0.4.15,
is even today still not properly localized there, they changed their dimensions again with that
and I don't intend to port that back anytime soon. And if I ever will, then all the resources would need to be touched again anyway.
port back:
0.4.15-dev-5785-g c766ee9ebb CORE-18874 [NETSHELL] Shrink radio buttons vertically (#5157)
0.4.14-dev-1481-g fff2fc9327 CORE-16903 [NETSHELL] RC Overhaul all languages IDD_LAN_NETSTATUS & IDD_LAN_NETSTATUSADVANCED
0.4.14-dev-293-g 2b39b42a0a CORE-15248 [NETSHELL] Fix checkboxes in the network adapter properties
partially 0.4.12-dev-315-g 01e5cb0c04 [NETSHELL] Fix incorrect resource IDs.
and port back also a few other small RC-improvements from master here and there
port back:
0.4.10-dev-615-g 45fd48bd0f [CDFS_NEW] -> [CDFS] No old driver, thus no new driver
0.4.10-dev-614-g 5795254933 [CDFS] Delete the old CDFS driver.
The new MS PL licensed one worked for several years fine for us now
even in the older releases.
So no need to keep our old unfinished one any longer within
the release-branches. They are no mausoleum.
This does *not* change, which driver is actually in use.
We do continue to use 1:1 the state of current releases/0.4.10
0.4.15-dev-5102-g 18d40ebe81 [BOOTDATA] hivesys.inf: Remove redundant fastfat "Start" entry. The one in the [AddReg] section has the very same value.
-------
0.4.15-dev-5012-g e3f8f52f3d [BOOTDATA] Delete "Layout Id" from Japanese/Korean Keyboard Layout
Katayama explained: These registry values are for pre-installed IMEs we don't have. It is safe to remove them also in the older branches.
-------
0.4.15-dev-4352-g cfe387a9b0 [BOOTDATA] Add two missing separating commas in the ServiceGroupOrder List multi-string.
-------
PARTIALLY PICK: 0.4.15-dev-4412-g 94d144f8a5 [BOOTDATA] Fix some services groups
- AudioSrv belongs to "AudioGroup" (and not "Audio" that doesn't exist).
- lanmanworkstation belongs to "NetworkProvider" (without a space).
I dared only to pick the "NetworkProvider" and "AudioGroup" part for now. The MUP part I might do later when actually being able to retest CORE12107 "VMWare tools" myself.
-------
0.4.15-dev-1097-g 0689455bb3 [BOOTDATA] Comment out biosinfo.inf (#3266)
This allows ros to boot with its LiveCD files using MS NTLDR!
I stripped the line here, instead of commenting it as the master commit did. The file does not exist.
-------
0.4.9-dev-643-g 40d7381e28 [BOOTDATA] Remove 'debugout.sys' mention. since this driver has been removed in SVN r26032 == git ad07a1e58f
-------
Additionally to those backports I cleaned up some of the stuff that was previously commented out and/or broken:
- strip some 'translated' service strings that were just copy-pasted from the english strings section
without actually getting translated at all. The english ones will be used anyway.
It is enough to have that redundant stuff in master to allow translators to see it.
- Also strip the disabled BENGALI_INSCRIPT kbdinben.dll. Where the existing lines even had bugs in the older branches as proven by 0.4.15-dev-3322-g c6e002bfb3
It was always disabled and was neither localizable, nor did it have the correct layout code even. No such file even.
None of those changes will introduce any additional diff or break any existing features.
They just slightly move the already existing diffs position in time towards newer release-branches.
by porting back:
0.4.15-dev-5784-g 2aea4ab945 [NTUSER] Scrollbar.c pure whitespace fixes
0.4.15-dev-5680-g 5ad5737370 CORE-18050 [NTUSER] Delete temporary workarounds in co_IntSetScrollInfo() (#4985)
0.4.15-dev-5355-g 0484beb04b CORE-18593 [NTUSER] Don't redraw scrollbar if it is hidden command prompt (#4849)
0.4.15-dev-4492-g 03422451b3 Add '\n' to debug logs (partially, only the scrollbar.c part)
0.4.15-dev-3875-g 977c129f33 CORE-18048 [USER32] SetScrollPos should not bypass UserApiHook (#4372)
0.4.15-dev-3849-g fd28a69de6 CORE-17780 [WIN32SS] Store the scrollbar theming enabled flag in the scrollbar (#4367)
0.4.15-dev-3175-g 222acf5a3e CORE-17777 [NTUSER] Scrollbar.c, Avoid potential out-of-bounds-accesses in co_IntSetScrollInfo()
0.4.15-dev-3174-g dda9c3979e CORE-17769 'Rapps Listview manual resize may erroneously not draw the triangles sometimes'
0.4.15-dev-3147-g 3bf7e3ac13 CORE-17754 and CORE-17755 [NTUSER] Improve Themed Scrollbars by Minimizing Updates (#3953)
0.4.15-dev-3086-g 236649c626 CORE-16375 [UXTHEME][NTUSER] Fix flashing of scrollbar when scrolling (#3868)
0.4.15-dev-2375-g ffea5152e6 [WIN32SS][NTUSER] Fix an integer underflow within scrollbar info setting
0.4.14-dev-1134-g 00adb1a3f9 [WIN32SS] Improve Drawing Scrollbars
- CORE-14755 fixed, flashing scrollbar triangles (we know 131 affected apps just from rapps!)
- CORE-13931 fixed, FamiTracker invisible about-dlg
- CORE-14685 improves a bit, but is not entirely fixed
- CORE-11561 'Notepad scrollbars problem' fixed
This will also speed up NSIS installers that display their file-copy-progress by
a self-scrolling listview.
by partially porting back:
0.4.15-dev-xxx [WMISVC] Fix DPRINT that lacks arguments
0.4.13-dev-684-g eab73ad1a4 [SRVSVC] Make the server service stoppable
0.4.13-dev-683-g 4073a8c58d [WKSSVC] Make the workstation service stoppable
0.4.13-dev-680-g eb532bc641 [WMISVC] Accept stop and shutdown commands when the service is running
0.4.12-dev-1063-g 15a828c86d [DHCPCSVC] Eliminate unused code and associated parameters
0.4.9-dev-547-g 444338ae2e [RPCSS] Sync with Wine Staging 3.3. CORE-14434
partially 0.4.9-dev-351-g 9febc82acf [DHCPCSVC] Add the ability to stop the DHCP client (first part of CORE-14390)
Port back
0.4.12-dev-973-g d29e216f99
[NTOSKRNL] In MmCreateImageSection, properly check whether cache was initialized
This fixes a crash that occurs if nul is typed in cmd.exe (BSOD0x1E)
----------
Port back also some unrelated formatting-improvements within section.c, e.g.: return(xyz) -> return xyz
A *partial* port of
0.4.15-dev-1793-g b7eb0fddf3
0.4.15-dev-3341-g 4bc95812fd defwnd.c Mark default as unreachable.
0.4.15-dev-316-g 938df97b54 nonclient.c NC_IconForWindow(): Remove redundant if() (#2842)
and:
-defwnd.c: delete a malformed TRACE() which had a format string, but no argument.
-sysparams.c: A single line from 0.4.14-dev-676-g 9ce12f0b4c avoiding a wcslen() call in SpiLoadTimeOut()
It regressed in this branch by 0.4.7-release-218-g 4471bfb7cb
( in master it was by 0.4.15-dev-5613-g 7a17c7d9ad )
It was the only place within the ros sources where message WM_SHOWSTATUSDLG
was sent also from code. And therefore the only one that needed to be updated as well.
Fix picked from:
0.4.15-dev-5712-g a5cd42c1ea
by porting back:
[SHELL32] Ignore unused flag SEE_MASK_UNICODE (#5033)
0.4.15-dev-5676-g 5c22ce3742
to mute logspam of the kind
fixme:(dll/win32/shell32/shlexec.cpp:1934) flags ignored: 0x00004000
e.g. when starting Rapps.
-------------------------------------------------------------
[SHELL32] brsfolder.c Delete unused #ifndef __REACTOS__ block
It is a partial pick of:
0.4.15-dev-3642-g 83be315abf
and strip all EOL-whitespace in that file.
This part is done as the file is part of a backport into even older branches.
brsfolder.c will be 100% in sync between releases/0.4.7 - releases/0.4.14 afterwards.
-------------------------------------------------------------
[SHELL32] de-DE.rc Update regarding IDC_BROWSE_FOR_FOLDER_NEW_FOLDER
0.4.15-dev-2957-g c30b1fe893
and pick other small tweaks in that file from master
-------------------------------------------------------------
[COMDLG32] Support shortcut keys on Open/Save Dialog (#3238)
Enable key accelerators on File Open/Save Dialog. CORE-14332
0.4.15-dev-1050-g c8e1460ac5
--------------------------------------------------------------
[SHELL32] Implement VK_DELETE on SHBrowseForFolder (#2661)
Enable Del/Delete key to delete the selected folder in "Browse for Folder" dialog.
You can use https://jira.reactos.org/secure/attachment/40118/getfolder.zip as a test program.
0.4.15-dev-39-g 771457f37f
--------------------------------------------------------------
[SHELL32] Sync brsfolder.c with keyboard shortcut code from wine (#2290)
0.4.14-dev-1187-g fc4c4d4911
by porting back:
0.4.15-dev-5542-g f9dfc45375 CORE-18587
0.4.14-dev-980-g b1c7ca3024 Attention comment
0.4.14-dev-979-g ba17d87636 Attention comment
and pick a few places where translators decided to shorten their strings
not on LBUTTONDOWN
by porting back:
0.4.15-dev-5613-g 7a17c7d9ad CORE-18813 LBUTTONUP
0.4.9-dev-126-g 0182dcd71b *only the lanstatusui.cpp-part* DWL->DWLP x64compat
0.4.8-dev-972-g af4bdd4388 [NETSHELL] Don't use hardcoded values.
and strip EOL whitespace
by porting back the following commits from master:
0.4.8-dev-185-g 4067eb1454 [OPENGL32] Get rid of the TLS based implementation CORE-14024 (#133)
0.4.8-dev-184-g 31acac46a1 [OPENGL32] Get rid of the default stub table, use NULL instead CORE-14024 (#133)
0.4.8-dev-183-g b060a81d5d [OPENGL] Always use the TEB to store opengl data CORE-14024 (#133)
0.4.8-dev-182-g 640af3f429 [OPENGL32] Fix a trace CORE-14024 (#133)
0.4.8-dev-181-g 6aaf217b10 [OPENGL32] Implement storing thread data into the TEB CORE-14024 (#133)
0.4.8-dev-148-g 64d10228ee [OPENGL32] Allocate thread data in IntMakeCurrent if it is not allocated yet. CORE-12232
0.4.8-dev-147-g fa9ce98d8e [OPENGL32] Do not crash in IntGetCurrentDC if thread data was not allocated. CORE-12232
0.4.8-dev-15-g 788efd34a8 [OPENGL32] Set the stdcall calling convention for wglGetDHGLRC(). part of CORE-11799, part of (#94)
Prevents a BSOD 0x1E upon dereference.
CORE-18091 CORE-18558
By partially porting back:
0.4.15-dev-5587-ga999c43 a999c43746
and take also some cosmetic changes from master head, like EOL-whitespace-removal.
by porting back:
0.4.15-dev-5588-g e89675768b [SHELL32] Add 3 accelerators for IDM_DRAGFILE MENU de-DE.rc (#5001)
pick a single line only of 0.4.15-dev-984-g a5a30fc249 [SHELL32] CFSDropTarget.cpp ERR->TRACE to mute logspam
0.4.11-dev-858-g 1d55f459d6 [SHELL32] CFSDropTarget: Fix right click menu when shown over the tree view CORE-11240
0.4.9-dev-8-g fd209faa66 [SHELL32] CFSDropTarget: style fixes
0.4.9-dev-7-g 4b19b1e49d [SHELL32] CDefView: remove a useless print
0.4.9-dev-6-g 6f25b42a31 [SHELL32] CFSDropTarget: Use copy depending on the source drive
0.4.9-dev-5-g 6d91269eda [SHELL32] CFSDropTarget: Initial implementation of right click drag menu
0.4.9-dev-4-g 8f8ab050db [SHELL32] CDefView: Implement several methods needed for drop targets
0.4.9-dev-3-g 5bef945cc9 [SHELL32] Add menu resource which is used when dragging files with right click
and strip some EOL-whitespaces in the 3 related source-files.
CORE-11240
Switches from "FreeMono" and "Dejavu Sans Mono" to "Courier New" and "Lucida Console"
and therefore brings us closer to 2k3sp2 stock fonts. Saves some RAM also.
Deletes some "Ubuntu" font left-overs in some Themes.
CORE-18605 (and partially CORE-16264)
By porting back the following commits:
0.4.15-dev-5362-g c47758b102 [SETUP][INF][MEDIA] Get rid of the last Ubuntu references CORE-18607 (#4871)
0.4.15-dev-5336-g bd40c13f6f [SETUP][BOOTDATA][FONTS][INF] Delete DejaVu Sans Mono and re-map (#4856)
0.4.15-dev-5335-g a4193ade03 [SETUP][FONTS][INF][GDI32_APITEST] Delete FreeMono and re-map (#4852)
0.4.15-dev-5324-g d035452148 [SETUP][INF][ROSTESTS] Delete font substitutions and tests for "DejaVu Sans" (#4829)
0.4.13-dev-768-g dc1aa8010a [FONTS][SETUP][BOOTDATA] Add Lucida Console font (#1793) CORE-16264
0.4.13-dev-750-g faa3237d46 [FONTS][BOOTDATA][SETUP] Add Courier New fonts (#1783)
by hand!
Motivation is to fix relocations during 2nd/3rd stage of the kind:
(C:\047rls\reactos\dll\ntdll\ldr\ldrutils.c:1311) LDR: LdrpMapDll Relocating Image Name C:\ReactOS\System32\spool\PRTPROCS\W32X86\winprint.dll (10000000-1000A000 -> 003D0000)
(C:\047rls\reactos\dll\ntdll\ldr\ldrutils.c:1350) Overlapping DLL: C:\ReactOS\system32\localmon.dll
(C:\047rls\reactos\dll\ntdll\ldr\ldrutils.c:1311) LDR: LdrpMapDll Relocating Image Name beepmidi.dll (7A140000-7A147000 -> 00BF0000)
(C:\047rls\reactos\dll\ntdll\ldr\ldrutils.c:1350) Overlapping DLL: C:\ReactOS\System32\browseui.dll
Motivation is to fix the following warnings at configure-time for *MSVC x86 dbg* :
-- shsvcs has no base address
-- libtirpc has no base address
-- acgenral has no base address
-- nfs41_np has no base address
-- shellbtrfs has no base address
-- ntdll_vista has no base address
-- redirtest1 has no base address
-- redirtest2 has no base address
-- localspl_apitest.dll has no base address
-- localmon has no base address
-- winprint has no base address
This fixes CORE-14831 for *MSVC dbg* for this release-branch at least.
Meaning: It hides the effect, without fixing the cause.
It is not a sustainable solution for master yet.
We'd need to improve the python script for that.
I tested afterwards the bootup of a build configured via:
-DENABLE_ROSTESTS=1 -DENABLE_ROSAPPS=1
and built with:
MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration
and verified that we had no relocation happening until 3rd stage desktop VBox4.3.12.
MSVC 2010SP1 (16.0.40219.1) x86 target in *rls* configuration was not
tested yet, as that up to now did never reach the desktop yet for unrelated reasons.
I will not upload an iso to sourceforge after this commit,
because it will not have any impact for our primary GCC 4.7.2 toolchain.
This updates the GCC baseaddress_msvc.cmake
to the state we do use in releases/0.4.10 to date
leaving out the components that do not exist in releases/0.4.7 yet,
And additionally preserves the addresses for the 3 fusion dlls,
which our script currently cannot handle yet.
Therefore manually respecting the differences for:
set(baseaddress_localspl_apitest.dll
set(baseaddress_fusion
set(baseaddress_fusion_1_1
set(baseaddress_fusion_2_0
Based on patch by I_Kill_Bugs.
Fixes the regression which was introduced to master by 0.4.15-dev-1126-g 58b0558f94
fix picked from 0.4.15-dev-5532-g ca9ded7af8
WS_EX_NOACTIVATE flag forbids the window to be activated
fix picked from 0.4.15-dev-5137-g 826bd41d88 (1 of 3 commits for CORE-18417)
My reason for picking it is that it fixes CORE-13257 'Reboot leaving Evernote 5.9.8 in tray causes WIN32K BSOD 0x50'
I also had to pick together with it the
0.4.15-dev-5491-g 1fbed1710e to prevent it from introducing (+2 failures in user32:msg_focus) unittests.
----------------
The above patch allows/encourages us to pick then also:
0.4.15-dev-5492-g 47f3a4e144 [OSK] Delete WS_EX_NOACTIVATE workaround code
(which referenced CORE-18528, but is not fixing this minor GUI glitch yet, it just removes workaround-code that is no longer needed,
I just mention the ticket here, because the commit on master did that as well)
----------------
----------------
The following 2 things were small *unrelated* improvements nearby, and I decided to take them with me:
0.4.15-dev-4323-g 9f5cde9cbe [WIN32K:NTUSER] window.c Remove broken assert in NtUserCreateWindowEx. CORE-18123 fixed
and
a tiny part of 0.4.15-dev-3476-g 55a1c29341 [WIN32K] appswitch.c: delete unused func DWORD wtodw(const WCHAR *psz)
----------------
and also backport a few whitespace improvements in the files touched.
- This fixes problems with "F17" or "F14" shortcut key in the menu items of some programs,
e.g. SQLiteAdmin 0.8.3.2
CORE-17906 CORE-3903
fix picked from 0.4.15-dev-5145-g cdf907074d
--------------
[KEYBOARD] Switch to QWERTZ for Croatian keyboard layout (#4177)
fix picked from 0.4.15-dev-3503-g 2196a06fc1
--------------
[KBDHU] Fix Hungarian keyboard layout. (#1765) CORE-15567
partial pick from 0.4.13-dev-732-g 48200015f7
(I left out the header comment to keep the file pure ASCI)
--------------
Also ported back some EOL whitespace trimming
