George Bișoc
f1d2a44859
[NTOS:CM] Lock the cached KCB before removing it from cache entries
...
- Annotate the CmpEnumerateOpenSubKeys function with SAL2
- When removing an orphaned cached KCB, ensure that it is locked before clearing it from cache table entries
2024-03-24 19:03:43 +01:00
Whindmar Saksit
2449ed5d85
[ADVAPI32] Handle HKCR in RegDeleteValueA+W and RegDeleteKeyValueW ( #6033 )
...
- HKCR delete handling; delete the value in HKCU if it exists there, otherwise delete it in HKLM.
- Changed RegDeleteKeyValueW to just use the regular Reg functions to get HKCR handling for free.
2024-03-24 18:28:26 +01:00
Whindmar Saksit
373816c729
[SHELL32] Support IDropTarget handler in IContextMenu static verbs ( #5860 )
...
This adds support for the `DropHandler` subkey in static verbs. `IDropTarget` is called when the verb is invoked. The advantage of this is that no library needs to be loaded until the verb is actually invoked unlike `IContextMenu` shell extensions that have to be loaded during menu creation.
This method is preferred for verb implementations that must work on Windows XP, see
https://learn.microsoft.com/en-us/previous-versions/windows/desktop/legacy/dd940354%28v%3Dvs.85%29?redirectedfrom=MSDN#description
2024-03-24 18:23:07 +01:00
Julen Urizar Compains
54df31ccac
[TRANSLATION] Update Spanish (es-ES) translation ( #6449 )
...
- [REACTOS] es-ES: Fixes and typos
- [USETUP] es-ES: Fixes and typos
- [HOTPLUG] es-ES: Fixes and typos
- [OPENGLCFG] Add Spanish (es-ES) translation
- [NETSHELL] es-ES: Fixes and typos
- [SHELL32] es-ES: Fixes and typos
- [SYSSETUP] es-ES: Fixes and typos
Reviewed-by: Ismael Ferreras Morezuelas <swyterzone@gmail.com>
2024-03-24 12:30:56 +03:00
Timo Kreuzer
752c64d152
[USBOHCI] Fix broken indentation
2024-03-23 23:08:01 +01:00
Timo Kreuzer
5869af7821
[USBUHCI] Fix broken indentation
2024-03-23 23:08:01 +01:00
Whindmar Saksit
1408de02ce
[SHELL32] SHOpenFolderAndSelectItems should handle children correctly ( #6151 )
...
- Free pidl from ILCombine.
- ILGetNext will never return NULL on valid input, it is not the correct way to check.
2024-03-23 22:24:04 +01:00
Andrei Miloiu
f9c93888b7
[CALC] Update Romanian (ro-RO) translation ( #6601 )
2024-03-23 22:22:50 +01:00
Andrei Miloiu
8d36ad1de6
[SOLITAIRE] Update Romanian (ro-RO) translation ( #6600 )
2024-03-23 22:21:32 +01:00
Andrei Miloiu
8eb80987e4
[TIMEDATE] Update Romanian (ro-RO) translation ( #6613 )
2024-03-23 22:20:24 +01:00
Andrei Miloiu
50a15424c8
[SNDVOL32] Update Romanian (ro-RO) translation ( #6612 )
2024-03-23 22:18:51 +01:00
Andrei Miloiu
269907e44c
[HOTPLUG] Add Romanian (ro-RO) translation ( #6644 )
2024-03-23 22:17:20 +01:00
Andrei Miloiu
54c816d1f3
[MSCONFIG] Update Romanian (ro-RO) translation ( #6533 )
2024-03-23 22:16:14 +01:00
Andrei Miloiu
d0ce13a0e1
[APPWIZ] Improve Romanian (ro-RO) translation ( #6532 )
2024-03-23 22:12:30 +01:00
Andrei Miloiu
9b1d21dfa0
[CLIPBRD] Update Romanian (ro-RO) translation ( #6535 )
2024-03-23 21:18:20 +01:00
Andrei Miloiu
5e31354ff6
[DEVMGR] Update Romanian (ro-RO) translation ( #6529 )
2024-03-23 21:17:24 +01:00
Andrei Miloiu
ef4a2497d7
[NOTEPAD] Update Romanian (ro-RO) translation ( #6528 )
2024-03-23 21:16:07 +01:00
Andrei Miloiu
d1207f6f47
[WININET] Update Romanian (ro-RO) translation ( #6527 )
2024-03-23 21:14:12 +01:00
Andrei Miloiu
f9d2f84d4b
[EVENTVWR] Update Romanian (ro-RO) translation ( #6518 )
2024-03-23 21:12:52 +01:00
Andrei Miloiu
0c2cc368e2
[MSPAINT] Update Romanian (ro-RO) translation ( #6511 )
2024-03-23 21:12:23 +01:00
Andrei Miloiu
202114f3ae
[DISKPART][MC] Update Romanian (ro-RO) translation for message table ( #6509 )
2024-03-23 21:09:42 +01:00
Andrei Miloiu
7d45bb2a21
[OPENGLCFG] Update Romanian (ro-RO) translation ( #6507 )
2024-03-23 21:07:32 +01:00
Andrei Miloiu
c9bab6be25
[NET][MC] Update Romanian (ro-RO) translation for message table ( #6506 )
2024-03-23 21:07:05 +01:00
Hermès Bélusca-Maïto
3b62a89d4d
[BOOTVID] Don't NTAPI non-exported functions; remove useless @implemented
( #6650 )
2024-03-23 15:16:00 +01:00
Hermès Bélusca-Maïto
ff790a9111
[BOOTVID] Add file copyright information headers ( #6650 )
2024-03-23 15:15:41 +01:00
Serge Gautherie
a8c52fa165
[RSYM/x64] Sync UNW_FLAG_* values ( #6653 )
...
Follow-up to PR #6641 and commit d45876b81
2024-03-23 15:13:23 +01:00
Katayama Hirofumi MZ
17b0623cf8
[EXPLORER] Start menu: Fix Small Icons flag ( #6651 )
...
Follow-up to #6646 .
Fix wrong flag use: #6646 (comment)
JIRA issue: CORE-19494
- Delete SmallStartMenu flag (wrong) from
_TW_STUCKRECTS2.
- Rename _TW_STUCKRECTS2.SmallIcons as
SmSmallIcons.
- Use SmSmallIcons flag.
2024-03-22 21:15:22 +09:00
Stanislav Motylkov
2ec785b1ee
[SHELL32] Update Russian (ru-RU) translation
...
Addendum to ad748b0b3b
. CORE-19494
2024-03-20 12:26:58 +03:00
Katayama Hirofumi MZ
de5c472033
[WIN32SS][USER32] Refactor USER32 callbacks ( #6619 )
...
Refactoring kernel-to-USER32 callback code.
Localize USER32 callback entry definitions.
JIRA issue: N/A
- Add header file win32ss/include/u32cb.h and use it to define the
USER32 callback entries.
2024-03-20 09:45:04 +09:00
Katayama Hirofumi MZ
3be8934107
[SHLWAPI_APITEST] Add AssocQueryString testcase ( #6648 )
...
JIRA issue: CORE-19493
- Add AssocQueryString testcase.
- Test AssocQueryStringA and AssocQueryStringW
functions.
2024-03-20 07:37:37 +09:00
Katayama Hirofumi MZ
436cfa94c9
[SHELL32_APITEST] Add RealShellExecuteEx testcase ( #6647 )
...
Follow-up to #5849 .
JIRA issue: CORE-19278
- Add closewnd.cpp, closewnd.h, and
RealShellExecuteEx.cpp files.
- In closewnd.cpp, close newly-opened windows.
- Add RealShellExecuteEx testcase.
2024-03-20 07:36:14 +09:00
Katayama Hirofumi MZ
ad748b0b3b
[EXPLORER][SHELL32] Smaller Start Menu ( #6646 )
...
Improve customization of Start Menu.
JIRA issue: CORE-19494
- Add SmallStartMenu flag to TW_STRUCKRECTS2
structure.
- Add IDS_ADVANCED_SMALL_START_MENU
resource string.
- Update g_TaskbarSettings.sr.SmallStartMenu via
a callback function.
- Check g_TaskbarSettings.sr.SmallStartMenu
when Start Menu is updated.
2024-03-20 07:32:52 +09:00
Timo Kreuzer
2f03b146da
[CRT] intrin_x86.h: Use movsl instead of movsd to fix a GCC 13 warning
2024-03-19 07:44:40 +01:00
Timo Kreuzer
d45876b810
[DBGHELP] Remove useless broken CMake defines
2024-03-19 07:43:58 +01:00
Timo Kreuzer
2185848fc8
[HDAUDBUS] Silence debug spam
...
- Demote a DPRINT1 to a DPRINT
- Define NDEBUG
2024-03-19 07:43:39 +01:00
Timo Kreuzer
7fff216bed
[NTOS:EX] Fix a loop bug
2024-03-19 07:43:20 +01:00
Timo Kreuzer
01c05f33dc
[RTL/x64] Fix a GCC compiler warning
2024-03-19 07:42:35 +01:00
Katayama Hirofumi MZ
e27f06b889
[SHLWAPI] SHLWAPI_DEF_ASSOCF: Add ASSOCF_INIT_NOREMAPCLSID ( #6636 )
...
Step up to correct shell32!FindExecutable.
JIRA issue: CORE-19493
2024-03-19 09:44:10 +09:00
Katayama Hirofumi MZ
10d9e9de05
[SHELL32][SDK] Implement RealShellExecute(,Ex)(A,W) ( #5849 )
...
Implementing missing features...
JIRA issue: CORE-19278
- Modify shell32.spec.
- Implement RealShellExecuteA, RealShellExecuteW, RealShellExecuteExA,
and RealShellExecuteExW functions.
- Add the prototypes to <undocshell.h>.
- Modify SEE_MASK_... constants.
2024-03-19 08:58:07 +09:00
Katayama Hirofumi MZ
1ad90967d7
[SHELL32_APITEST] Enhance FindExecutable testcase ( #6634 )
...
I want to know the details of FindExecutable
behavior.
JIRA issue: CORE-19493
Enhance the tests of return values.
2024-03-18 07:36:17 +09:00
Katayama Hirofumi MZ
6af1813fda
[MSPAINT] Support JPEG/PNG/GIF/TIFF wallpapers ( #6632 )
...
Improve usability.
JIRA issue: CORE-19485
- Enable the menu items to set the wallpapars.
- Save the current bitmap as file Wallpaper1.bmp
in CSIDL_LOCAL_APPDATA folder.
- Support JPEG/PNG/GIF/TIFF files in
RegistrySettings::SetWallpaper.
2024-03-18 07:32:47 +09:00
Katayama Hirofumi MZ
c5e6456377
[MSCTFIME] Use QISearch for QueryInterface ( #6630 )
...
Simplify code and reduce binary size.
JIRA issue: CORE-19360
- Use shlwapi!QISearch for QueryInterface
implementation.
- Add delay link to shlwapi.
2024-03-17 12:44:03 +09:00
Katayama Hirofumi MZ
1af0dbe36e
[MSUTB][SDK] Use QISearch for QueryInterface ( #6631 )
...
Simplify code and reduce binary size.
JIRA issue: CORE-19363
- Use shlwapi!QISearch for QueryInterface
implementation.
- Add delay link to shlwapi.
- Define QITABENT macro in <shlwapi.h>.
2024-03-17 11:55:19 +09:00
Katayama Hirofumi MZ
1fbf09f531
[RAPPS][SHLWAPI][SDK] Un-escape URL filename ( #6626 )
...
Choosing the better filename.
JIRA issue: CORE-19490
- Add UrlUnescapeAndMakeFileNameValid helper function.
- Use UrlUnescapeW and PathIsValidCharW.
- Add PATH_CHAR_CLASS_... flags for PathIsValidCharA/W.
2024-03-17 08:15:08 +09:00
Katayama Hirofumi MZ
dc4992ce4a
[TOOLS] gen_baseaddress.py: Add '.ime' to ALL_EXTENSIONS ( #6628 )
...
We have dll/ime/msctfime for the DLL
file msctfime.ime.
JIRA issue: N/A
Add '.ime' to ALL_EXTENSIONS.
2024-03-16 19:37:26 +09:00
Katayama Hirofumi MZ
73d0d24d67
[CMAKE] Update sdk/cmake/baseaddress(,_msvc).cmake ( #6627 )
...
Follow-up to #6624 (fd96666
). ReactOS got rekt in that PR
because kernel32.dll got so larger.
Fix base addresses of DLLs to boot successfully. Sorry.
(dll/ntdll/ldr/ldrutils.c:1423) Illegal DLL relocation!
C:\ReactOS\System32\ntdll.dll overlaps kernel32.dll
*** Fatal System Error: 0xc0000269
Proposed changes
After latest build:
python gen_baseaddress.py C:\Users\katahiromz\reactos-1\output-VS-i386
python gen_baseaddress.py C:\Users\katahiromz\reactos-1\output-MinGW-i386
2024-03-16 13:46:10 +09:00
Katayama Hirofumi MZ
fd9666630e
[SDK][MC] errcodes.mc: Add Japanese (ja-JP) translation ( #6624 )
...
Localize the error messages.
JIRA issue: CORE-18706
Modify errcodes.mc for Japanese localization.
2024-03-16 00:11:53 +09:00
Katayama Hirofumi MZ
4854a1d7b6
[SHELL32_APITEST] ShellExecuteEx: Fix command line checker ( #6618 )
...
Follow-up to #6617 .
JIRA issue: CORE-19482
Add traces for error checking.
2024-03-15 23:46:14 +09:00
Katayama Hirofumi MZ
cbad6cef24
[SHLWAPI] Implement SHSetDefaultDialogFont ( #6620 )
...
Implementing missing features...
JIRA issue: CORE-19278
- Implement SHSetDefaultDialogFont function.
- Add SHSetDefaultDialogFont prototype to
<shlwapi_undoc.h>.
2024-03-15 21:25:53 +09:00
Oleg Dubinskiy
c6b8638815
[SHELL32] Add transparent icon resource ( #6621 ) CORE-19471
...
Add transparent 16x16 icon (just small picec of transparent background) as resource and use it for 50, 51, 52, 53 resource IDs.
Define it as IDI_SHELL_NONE_XX for all four IDs appropriately (since the icon displays nothing).
These resources are not used by anything yet, but they are confirmed to exist as resources with 50, 51, 52, 53 IDs in shell32.dll from Windows XP/Server 2003.
This allows to correct the ordering of all other resources those come starting from index 54, and hence it fixes the following icons displayed incorrectly after restoring to default system icon set via Stardock IconPackager 5.1:
- Control Panel folder icon;
- Folder Options item icon in Control Panel;
- My Music special folder in My Documents;
- several File extensions icons (.ini, .txt etc).
The icons are fixed as in the preview of IconPackager app, same in ReactOS itself.
Now only Web Browser item icon on the Desktop remains invalid. All other icons are restored correctly.
CORE-19471
2024-03-14 20:58:12 +01:00