Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-24 23:11:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[SHELL32] Add transparent icon resource (#6621) CORE-19471

Browse source 
Add transparent 16x16 icon (just small picec of transparent background) as resource and use it for 50, 51, 52, 53 resource IDs.
Define it as IDI_SHELL_NONE_XX for all four IDs appropriately (since the icon displays nothing).
These resources are not used by anything yet, but they are confirmed to exist as resources with 50, 51, 52, 53 IDs in shell32.dll from Windows XP/Server 2003.
This allows to correct the ordering of all other resources those come starting from index 54, and hence it fixes the following icons displayed incorrectly after restoring to default system icon set via Stardock IconPackager 5.1:
- Control Panel folder icon;
- Folder Options item icon in Control Panel;
- My Music special folder in My Documents;
- several File extensions icons (.ini, .txt etc).
The icons are fixed as in the preview of IconPackager app, same in ReactOS itself.
Now only Web Browser item icon on the Desktop remains invalid. All other icons are restored correctly.
CORE-19471
This commit is contained in:
Oleg Dubinskiy 2024-03-14 20:58:12 +01:00 committed by GitHub
parent 2f6b17593f
commit c6b8638815
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dll/win32/shell32/icon_res.rc
View file

@ -47,6 +47,10 @@ IDI_SHELL_EXPLORER ICON "res/icons/46.ico"
IDI_SHELL_UPDATE ICON "res/icons/47.ico"
IDI_SHELL_LOCKED ICON "res/icons/48.ico"
IDI_SHELL_DISCONN ICON "res/icons/49.ico"
IDI_SHELL_NONE_50 ICON "res/icons/50.ico"
IDI_SHELL_NONE_51 ICON "res/icons/50.ico"
IDI_SHELL_NONE_52 ICON "res/icons/50.ico"
IDI_SHELL_NONE_53 ICON "res/icons/50.ico"
IDI_SHELL_NOT_CONNECTED_HDD ICON "res/icons/54.ico"
IDI_SHELL_MULTIPLE_FILES ICON "res/icons/133.ico"
IDI_SHELL_OPEN_WITH ICON "res/icons/134.ico"

BIN
dll/win32/shell32/res/icons/50.ico Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 318 B

4
dll/win32/shell32/shresdef.h
View file

@ -595,6 +595,10 @@
#define IDI_SHELL_UPDATE 47
#define IDI_SHELL_LOCKED 48
#define IDI_SHELL_DISCONN 49
#define IDI_SHELL_NONE_50 50
#define IDI_SHELL_NONE_51 51
#define IDI_SHELL_NONE_52 52
#define IDI_SHELL_NONE_53 53
#define IDI_SHELL_NOT_CONNECTED_HDD 54
#define IDI_SHELL_MULTIPLE_FILES 133
#define IDI_SHELL_OPEN_WITH 134