Commit graph

284 commits

Author SHA1 Message Date
Amine Khaldi 4ce8df2ba6 [SCHTASKS] Sync with Wine Staging 3.3. CORE-14434 2018-03-25 12:53:36 +01:00
Amine Khaldi 80c45b1f06 [REG] Sync with Wine Staging 3.3. CORE-14434 2018-03-25 12:50:15 +01:00
Amine Khaldi eae3333c2f [CSCRIPT][WSCRIPT] Sync with Wine Staging 3.3. CORE-14434 2018-03-25 12:48:58 +01:00
Eric Kohl 4916c4cfd5 [CMD] Correct the action on shorcut Ctrl-M
Patch by Jacob S. Preciado.

CORE-10142
2018-03-22 22:29:33 +01:00
Li Keqing 5ddbd37371 [TRANSLATION] Update Simplified Chinese Translations (#417) 2018-03-21 22:27:04 +01:00
Eric Kohl 9febc82acf [DHCPCSVC] Add the ability to stop the DHCP client
- Use a stop event to terminate the dispatch loop.
- Report to the services manager that the service can be stopped or shut-down while it is running.

CORE-14390
2018-03-21 21:07:26 +01:00
Eric Kohl 745ef8bf3a [SNDVOL32] Remove the TBS_AUTOTICKS style from the trackbars 2018-03-19 20:22:06 +01:00
Mark Jansen bc67bb3dd0 [EXPLORER] Do not force X86 in the manifest. 2018-03-19 09:44:25 +01:00
Eric Kohl 5b2ff8a3f9 [SNDVOL32] Add the ability to select the record mode by using the /r option and select the right mixer after changing the mixer preferences 2018-03-18 14:15:12 +01:00
Robert Naumann 69acbe905a
Update German translation (#438)
* [BROWSEUI] Update German translation

* [SHELL32] Update German translation

* [COMCTL32] Update German translation

* [COMDLG32] Update German Translation

* [SETUPAPI] Update German translation

* [EXPLORER] Update German translation
2018-03-17 22:48:16 +01:00
Eric Kohl ad3bda1c8d [SNDVOL32] Set the ranges, pagesize and ticks for the balance and volume trackbars and fix the conversion between trackbar position and volume value 2018-03-15 22:03:33 +01:00
Alexander Shaposhnikov 9591550116
[RAPPS] Replace Extract with FDI for handling .cab
FDI allows to have user-defined callbacks for file handling.
Since it doesn't provide support for Unicode we convert strings to
multi-byte UTF-8 and handle them appropriately in the callbacks. They
are properly null-terminated so FDI won't choke when doing operations
with strings.

Thanks to hbelusca and mjansen for the help.

CORE-14466
2018-03-11 21:56:32 +02:00
Eric Kohl 4ddb1bfd96 [SNDVOL32] Add the small line dialog 2018-03-11 10:41:41 +01:00
Eric Kohl 8a7e1a7b7b [SNDVOL32] Add the normal line dialog 2018-03-11 10:14:43 +01:00
Eric Kohl 6f2feac70a [SNDVOL32] Fix the layout of the normal master dialog
- Fix the layout of the normal master dialog layout.
- Change the name of the normal and tray master dialogs.
- Add the WS_EX_LAYOUTRTL style to the hebrew dialogs.
2018-03-11 01:13:22 +01:00
Eric Kohl 849fdca3f9 [SNDVOL32] Add the small master dialog
- Add the small master dialog.
- Add support for tray (/t), small (/s) and normal (/n) dialog sizes.
- Fix the font size calculation for the dialogs.
- Fix the dialog unit to pixel conversion.
- Fix the client window size calculation.
- Do not leak font handles.
2018-03-10 21:11:08 +01:00
Mark Jansen 516c5a9a4f
[DRWTSN32] Indicate the thread that crashed. 2018-03-10 00:04:57 +01:00
William Kent 6f6ce101f7
[DRWTSN32] Add code to write a minidump 2018-03-10 00:04:57 +01:00
William Kent 1d10606fad
[DRWTSN32] Various improvements
* Convert to wWinMain()
* Add a resource file
* Use a slightly friendlier application name
* Add code to load the output path from the Registry
* Add localized string resources
2018-03-10 00:04:57 +01:00
Timo Kreuzer 0182dcd71b [PSDK][REACTOS] Fix definitions and usage of DWLP_MSGRESULT, DWLP_DLGPROC, and DWLP_USER
- Make sure the DWLP_* values are correct on _WIN64
- Don't use the DWL_* constants, they are not portable. Enforce this by removing them entirely from winuser.h
- Make sure Get/SetWindowLong*Ptr* is used and pointers are not truncated to LONG
2018-03-04 16:27:07 +01:00
Luo Yufan 767e2419e9 [TRANSLATION][SUBST] Update Simplified Chinese translation. (#414) 2018-03-04 03:37:20 +01:00
Adam Słaboń 8fd9d3f59b [TRANSLATION] Polish translation update (#413)
Translation update for sndvol32, shell32 (right click drag menu), rapps and ks.inf.
2018-03-03 21:24:46 +01:00
Thomas Faber ede8794c4b
[EXPLORER] Remove SetBandSiteInfo hack. CORE-9809 2018-03-03 17:17:13 +01:00
Giannis Adamopoulos b95fff5bce [EXPLORER] CTrayWindow: Set the initial lock state in the band site
This alongside the previous commit, fix locking and unlocking the taskbar.
2018-02-28 17:21:19 +02:00
Simon Dräger f80d227ec2 [TRANSLATION] Completed German translation in taskmgr 2018-02-26 22:20:38 +01:00
Giannis Adamopoulos ec91188fff [WINSRV] Implement sending the hard error balloon package to explorer
[EXPLORER] Implement showing the hard error balloon
2018-02-26 16:51:59 +02:00
Eric Kohl 40bd09a2ce [SNDVOL32] Add the tray volume dialog
- Add the tray volume dialog (run "sndvol32 /t").
- Add a simple command line parser.
2018-02-26 00:44:41 +01:00
Simon Dräger ff23123615 [TRANSLATION] Minor German grammatical improvements 2018-02-25 17:26:43 +01:00
Eric Kohl a0d412b77a [SC] Support the paramchange and netbind* control codes in the control command 2018-02-25 14:08:16 +01:00
Eric Kohl 9f0c54fcd3 [SC][SERVICES] Support SERVICE_CONTROL_PARAMCHANGE and SERVICE_CONTROL_NETBIND* control codes 2018-02-25 11:07:41 +01:00
Hermès Bélusca-Maïto c6d65fec69
[SERVICES] Use safe-string routines in some places, and do not hardcode buffer lengths. 2018-02-25 00:50:01 +01:00
Hermès Bélusca-Maïto 1aa359ec7f
[SERVICES] Send services shutdown notifications only if they accept them. 2018-02-25 00:49:58 +01:00
Hermès Bélusca-Maïto 6c097b4740
[SERVICES] Add french translation. 2018-02-25 00:49:55 +01:00
Simon Dräger fd3b6d8c09
[TRANSLATION] German syntax fix.
It is rather unusual to put a "then" after "If..", so removed that.
2018-02-24 23:32:31 +01:00
Eric Kohl 4b8f53c9e9 [SERVMAN] Add an accelerator for the F5 (refresh) key
CORE-14389
2018-02-24 18:38:08 +01:00
Eric Kohl 1dfbed9c3d [SERVICES][ADVAPI32] Fix the broken service stop sequence
services\database.c:
- Refactor ScmControlService() so that it can be used to send the dispatcher loop stop command.
- Separate the code to decrement the image run counter from the service image cleanup code.

services\rpcserver.c:
- RSetServiceStatus(): Stop the dispatcher loop when the image run counter is zero and remove the service image after that.

advapi32\service\sctrl.c:
- Do not terminate the service dispatcher loop when the last service is being stopped. Wait for an explicit dispatcher stop command (empty service name).

CORE-12413
2018-02-24 11:14:05 +01:00
Thomas Faber 87d3fdf99e [DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353 2018-02-22 11:53:34 +01:00
Serge Gautherie e1bd79e3df [SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387) 2018-02-20 19:45:55 +01:00
Timo Kreuzer d281d14fd1 [REACTOS] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of GWL_* where appropriate. 2018-02-19 22:36:36 +01:00
Mark Jansen 07f3691cd8 [RAPPS] Various fixes
- Ask the user if they want to continue on cab certificate problems
- Fix memory leaks in failure paths
- Properly disable caching
2018-02-19 11:54:33 +01:00
Giannis Adamopoulos 21ae3a0862 [SNDREC32] it-IT.rc: add a missing new line 2018-02-19 02:03:35 +02:00
Eric Kohl a8d256bf23 [SERVICES] Update a drivers status properly
- ScmUnloadDriver: Handle failed unload properly.
- ScmGetDriverStatus: A driver is running when its driver object was found. Otherwise it has been stopped.
- ScmControlDriver: Check a drivers status before and after unloading.

CORE-14317
2018-02-19 00:14:58 +01:00
Mark Jansen b56193a27c
[RAPPS] Some fixes to our completely broken cert pinning attempt.
- We should not open a new connection to request a certificate.
- Update the issuer / subject for the LE certificate.
- User proper types.
- Require all fields that we check to be present.

Without checking the public key or the entire certificate it's still not secure, but we are a step closer.
Dedicated to Joachim Henze
CORE-14350
2018-02-18 13:01:02 +01:00
Hermès Bélusca-Maïto 5f59f0380d
[SC] Fix MSVC build. 2018-02-17 21:08:28 +01:00
Eric Kohl 4728157154 [SC] Implement missing query/queryex options
- PrintService: Print optional display name.
- MainUsage: Print missing query options.
- Parse query options and use them to enumerate services.
2018-02-17 19:28:16 +01:00
Pierre Schweitzer 6061c78e91
[EXPLORER] Update French translation 2018-02-16 19:36:25 +01:00
Serge Gautherie 46f96733bd [SC] Disable debug messages on user interface (#382) 2018-02-15 13:58:17 +00:00
Eric Kohl 6c9cdd84bb [SERVICES] Set a complete service status for running boot start or system start drivers 2018-02-12 15:50:30 +01:00
Eric Kohl e917471e04 [SERVICES] Fix the initial service status
- The initial dwWin32ExitCode for a disabled service is ERROR_SERVICE_DISABLED and ERROR_SRVICE_NEVER_STARTED for non-disabled services.
- The initial dwWaitHint is 2000 (2 seconds) for (user-mode) services and 0 for drivers.
- Move all driver-related code to driver.c.
2018-02-12 14:58:02 +01:00
Serge Gautherie f1535c2d6e [EXPLORER] Fix a Clang-Cl warning about Icon->ProcessId
"warning: expression result unused [-Wunused-value]"
Regressed in be2bf9b.

CORE-14306
2018-02-12 08:41:26 +00:00
Bișoc George abdde0b764 [EXPLORER] WatchList should be freed with delete[], not delete (#374)
WatchList is a set of array objects, initialized with "new[]", so it should be freed with "delete[]" to free all of its elements. Otherwise using only "delete" only frees the first variable but not its array. This would lead to an undefined behaviour.
2018-02-11 22:56:38 +01:00
Hermès Bélusca-Maïto a3403eff05
[MAGNIFY] Call PostQuitMessage() only at the very end. 2018-02-11 00:35:29 +01:00
Eric Kohl 85b71880fa [SERVICES] Update the service status after unloading a driver
Update the service status after unloading the driver and pass the new status to the caller.

CORE-14269
2018-02-10 17:02:23 +01:00
David Quintana 3003471e64 [EXPLORER] Send balloon notifications to the callback message.
TODO: Send NIN_BALLOONUSERCLICK when the user clicks on the balloon content (not the X button).
2018-02-10 16:31:26 +01:00
Eric Kohl 905d65b75b [SERVICES] Support the NoInteractiveServices registry value 2018-02-10 14:23:11 +01:00
Alexander Shaposhnikov f4fedb936e
[RAPPS] Fix column sorting
CORE-13793
2018-02-09 00:53:31 +02:00
Alexander Shaposhnikov b698067e35
[RAPPS] Set header style when sorting by column 2018-02-09 00:41:55 +02:00
Luo Yufan 19737a2cb9 [TRANSLATION] Simplified Chinese translation update for NETID and PING. (#369) 2018-02-07 14:03:42 +01:00
Giannis Adamopoulos 218b8eda92 [SYSSETUP] Don't load ISOLATIONAWARE_MANIFEST_RESOURCE_ID manually
Such a manifest is meant to be activated by the caller of the exports of the dll.
This means that the user of syssetup which is setup.exe is the one that should do the proper handling of the manifests.
Since setup.exe is the one that needs to do the right thing, add a CREATEPROCESS_MANIFEST_RESOURCE_ID to it and avoid
dealing with ISOLATIONAWARE_MANIFEST_RESOURCE_ID altogether (which is supposed to be used by activating the activation context
before calling the exports of the dll that has it). We don't really use ISOLATIONAWARE_MANIFEST_RESOURCE_ID correctly in any
place in the tree so let's rely on CREATEPROCESS_MANIFEST_RESOURCE_ID for now.

This fixes one part of CORE-14228 where no image was shown in the theme selector buttons. This happened because comctl32 was
statically linked and calling ImageList_LoadImage ended up creating an image list with comctl32 v5. Then we passed this image
list to a button created with comctl32 v6 and as a result the image list was unusable. This is yet another issue that needs
to be addressed in the future. Namely, it seems that in windows comctl32 v6 can use image lists created by comctl32 v5 whereas
we cannot.

This fix is not a hack but cleverly works around these two bugs that need to be addressed some time in the future.
CORE-14228
2018-02-07 01:15:49 +02:00
Joachim Henze 579e1e6b24 [EXPLORER] Update all preview bitmaps showing notification area
To reflect recent changes in taskbar height, icon spacing,
clock x and y margins.
Also make sure all shots show the exact same time
and choose a more localization agnostic time.
2018-02-06 17:35:08 +01:00
Joachim Henze bd7eae6795 [EXPLORER] Update classic/modern startmenu preview bitmaps
To reflect our recent updates in banners and notification area.
Also reduces explorer binary size by 214.016bytes.
2018-02-06 14:48:43 +01:00
Mark Jansen 64d32eab27 [RAPPS] Do not resize (hide) the treeview when minimizing. 2018-02-06 00:08:12 +01:00
Bișoc George 7b71877676 [TRANSLATION] Romanian translation for FONTEXT and TIMEOUT (#363)
[FONTEXT]: At the moment there is a comment in the en-US.rc resource file that advises to not translate it. I only created this file as a basis for the future. The file will be updated later when there is the possibility for FONTEXT to be translated further.
2018-02-05 18:57:39 +01:00
Eric Kohl f0c7db730c [SERVICES] Remove the synchronous service control pipe code
Remove the synchronous service control pipe code because we are using the asynchronous service control pipe code for years.
2018-02-04 22:30:33 +01:00
Adam Słaboń 0d838f40a3 [TRANSLATION] Polish translation update (#357) 2018-02-04 18:45:20 +01:00
Hermès Bélusca-Maïto 131678a025
[SHELL32] Rewrite the wrapping code for shell taskbar notifications.
- Introduce the TRAYNOTIFYDATAW structure, as documented by Geoff
  Chappell in "WM_COPYDATA for Taskbar Interface", at
  http://www.geoffchappell.com/studies/windows/shell/shell32/api/shlnot/copydata.htm
  that is the data structure passed between shell32 and explorer for
  communicating shell notify icon information.

- In Shell_NotifyIcon(), correctly capture the (ANSI and) UNICODE
  structures provided by the caller, properly taking into account for
  the different NOTIFYICONDATA structure sizes existing out there.
  The different strings are now properly null-terminated (especially
  szTip if it needs to be truncated out), and the flags validated.

- Remove the now unneeded "SHELL_NotifyIcon()" helper function.

[EXPLORER] Use TRAYNOTIFYDATAW and adjust the callers.
2018-02-04 18:11:50 +01:00
Thomas Faber dc51b419c7
[USETUP] Use the smaller zlib_solo instead of the full zlib. CORE-14290 2018-02-04 12:54:39 +01:00
Hermès Bélusca-Maïto 04498f3eb5
[EXPLORER] Don't use deprecated StrNCpy function but use the string-safe StringCchCopy instead. Also fix a copy-paste error in the _countofs. 2018-02-04 01:57:05 +01:00
Hermès Bélusca-Maïto 3b777fd133
[RAPPS] Remove trailing spaces. 2018-02-03 23:43:56 +01:00
Hermès Bélusca-Maïto 26ac8ac81e
[RAPPS] Remove deprecated TODO; use _countof() where needed. 2018-02-03 23:43:53 +01:00
Hermès Bélusca-Maïto 3f5fe94104
[RAPPS] Usability fixes. 2018-02-03 23:43:47 +01:00
Hermès Bélusca-Maïto f982d77b8a
[CONUTILS] Diverse improvements: start doxygenating and add some resource messsage helper functions.
- Start to doxygenate the library, focusing in great details on the
  functions of the "outstream" module.
- Add a K32LoadStringEx function that expands (K32)LoadString by
  allowing a LanguageId parameter to be able to load strings from other
  languages than the current one.
- Add "ConResMsg*" helper functions to be able to (format and) print
  message strings with inserts that come *NOT* from a message table (as
  usual) *BUT* from resource string tables.
  Will be helpful for CORE-14265 in particular.

[CMD] Fix the call to ConMsgPrintfV().
2018-02-02 00:41:54 +01:00
Luo Yufan a13c998183 [TRANSLATION] Simplified Chinese translations updated. (#348) 2018-02-01 02:50:29 +01:00
Joachim Henze f5d679aeb9 [EXPLORER] Pixel-perfect x-margins surrounding the clock
To look like XP/2k3.
Relies on d11e7af5f2

CORE-14272
2018-01-30 18:42:21 +01:00
Bișoc George 4a5b30ee1f [TRANSLATION][CLIPBRD] Italian translation implemented (#344) 2018-01-29 22:33:22 +01:00
Giannis Adamopoulos 556c485c8b [EXPLORER] Improve the width of the taskbar clock
Don't take into account TRAY_CLOCK_WND_SPACING_X twice
Increase TRAY_CLOCK_WND_SPACING_X
2018-01-29 22:32:17 +02:00
Giannis Adamopoulos d11e7af5f2 [EXPLORER] Center the text of the clock
CTrayClockWnd: Fix the calculation that centered the text of the clock.
CTrayNotifyWnd: Restore the 1 pixel margin between the clock and the pager.
2018-01-29 21:50:33 +02:00
Joachim Henze c109dc9f24 [EXPLORER] Tweak x-margins surrounding the clock
To look more like XP/2k3.
Not pixel-perfect yet, that would require asymmetric margins.

CORE-14272
2018-01-29 19:15:50 +01:00
Bișoc George 7169c7703d [TRACERT] Translation for Italian and Romanian language (#333) 2018-01-29 18:23:52 +01:00
Giannis Adamopoulos fabf069daf [EXPLORER] Fix showing the lock status in the taskbar popup menu 2018-01-29 18:15:31 +02:00
Joann Mõndresku d80ef2c90a [TRANSLATION] Various translations to Estonian (#329)
Estonian translations for shell + explorer, cpl files (access, appwiz, desk, timedate), devmgr, browseui, comctl32, aclui, avifil32, comdlg32 and credui.
2018-01-29 17:03:27 +01:00
Giannis Adamopoulos 22d1e1017f [EXPLORER] CNotifyToolbar: Set TBMETRICS::cxBarPad and TBMETRICS::cyBarPad
MSDN says that these values are not used but apparently they are used as a padding around the buttons.
This helps to center the buttons in the notification area.
2018-01-29 17:30:44 +02:00
Giannis Adamopoulos c54c5ebb5f [EXPLORER] CTrayWindow: Draw the sizer only when the taskbar is not locked. 2018-01-29 00:27:45 +02:00
Giannis Adamopoulos 488477d10d [EXPLORER] CTrayNotifyWnd: Fix resizing when the clock is hidden 2018-01-28 22:38:48 +02:00
Giannis Adamopoulos 85d7dd4f83 [EXPLORER] CTrayNotifyWnd: Only update the requested dimension when handling TNWM_GETMINIMUMSIZE. 2018-01-28 22:04:34 +02:00
Giannis Adamopoulos 5a1984c998 [EXPLORER] CTaskSwitchWnd: Implement getting the setting for grouping tasks. This doesn't work yet but the setting does get stored in m_IsGroupingEnabled. TSWM_ENABLEGROUPING is not needed. 2018-01-28 20:24:02 +02:00
Giannis Adamopoulos 6c073e9539 [EXPLORER] CTrayClockWnd: Implement showing and hiding seconds or the whole clock from the properties window. 2018-01-28 18:59:18 +02:00
Giannis Adamopoulos 455bce68b5 [EXPLORER] -Make CSysPagerWnd, CTaskSwitchWnd, CTrayClockWnd and CTrayNotifyWnd proper com objects so that their lifetime is managed properly. 2018-01-28 18:35:16 +02:00
Eric Kohl 2d69520595 [SERVICES] Do not delete running services.
CORE-14260
2018-01-28 00:57:58 +01:00
Serge Gautherie 2e868f2604 [SC] print.c: Minor code improvements. (#324)
- Plus: Update license header.
- Re-use PrintServiceStatus(), as SERVICE_STATUS_PROCESS is in fact an extension of SERVICE_STATUS.
- Use the "SERVICE_*" defines, not magic numbers.
2018-01-27 19:54:26 +00:00
Giannis Adamopoulos 7f35908ad2 [EXPLORER] CTrayNotifyWnd: Simplify how it interacts with its parent and children. Clean up. 2018-01-27 19:41:09 +02:00
Stanislav Motylkov dd65d06270 [TRANSLATION] Add and fix translations for ping and tracert (#331) 2018-01-27 16:25:51 +01:00
Pierre Schweitzer 79887db12e
[TRACERT] Add French translation 2018-01-27 13:01:45 +01:00
Pierre Schweitzer 77105d9c5b
[PING] Complete French translation 2018-01-27 12:49:14 +01:00
toehead2001 a30d12dde7 [SNDVOL32] Fix controls' offset (#280)
CORE-9108
2018-01-26 23:30:15 +02:00
Joann Mõndresku 757511c4e8 [TRANSLATION] Estonian translation for Notepad & Paint
Added Estonian translation for the common base applications Notepad and MS Paint. These are the initial translations, and are subject to change, as they may not be the most perfect.
2018-01-26 22:43:25 +02:00
Stanislav Motylkov 906fdf9ccb [PING] Fix error handling and response address decoding (#318)
- Host/net unreachable error should be obtained from EchoReply->Status
- Use GetNameInfoW to decode actual response addresses (borrowed from tracert code)

CORE-14241 #resolve
2018-01-26 18:38:47 +00:00
Stanislav Motylkov 010c7bfc9b [TRACERT] Improve error handling and output (#319)
- Correctly interpret network error codes
- Add output for generic transmit failure

CORE-14242 #resolve
2018-01-26 18:37:43 +00:00
Baruch Rutman b917d826a4 [BASE/APPLICATIONS] Hebrew translation updates (#321)
Translation updates + mirroring support.
2018-01-24 16:00:43 +01:00
David Quintana 3d75cc0814 [EXPLORER] Split up the notification area into a few more manageable pieces. 2018-01-24 14:41:31 +01:00