Doug Lyons
103c87d2b9
[SHELLFIND] Add Hidden Files & Folders Selection. CORE-16427
2019-10-19 15:57:34 +02:00
Pierre Schweitzer
c290ae21c7
[WSHTCPIP] Print IOCTL as hexa value
2019-10-19 12:04:40 +02:00
Serge Gautherie
a8236e3fa9
[MSAFD] SizeOf*Buffer: Type is ULONG, not INT/DWORD
2019-10-19 10:50:03 +02:00
Serge Gautherie
3f0ba492ad
[MSAFD] WSPSetSockOpt(): Fix a copypasta
...
Addendum to 6bc61f63f1
.
CORE-15804
2019-10-17 08:18:43 +02:00
Joachim Henze
cd2a274ef7
[BROWSEUI][SHELLFIND] Allow to 'Open Containing Folder'
...
of a search result again.
The feature regressed by 0.4.13-dev-1133-g
a3ee648d8b
I chose the shorter solution of Brock Mammen instead
of the patch of Doug Lyons from PR1960.
Still many thanks to Doug Lyons for his encouragement
in creating a fix as well and performing
regression-testing.
I intend to merge that back into 0.4.13RCs as well.
2019-10-12 15:44:58 +02:00
Mas4hmad
f84bd4f393
[TRANSLATION] Add/Update Indonesian translations ( #1904 )
...
Add/Update Indonesian translations for CHARMAP, CMDUTILS-HELP, SERVMAN, SETUPAPI, SHELL32, SUBST, SYSSETUP, TASKMGR, USERINIT.
2019-10-08 17:03:14 +02:00
Eric Kohl
80db055135
[SYSSETUP][NETCFGX][INF] Install the TCPIP protocol driver properly
...
Get rid of the special RandomProtocolGUID_TCPIP :-)
Works with the Setup CD and Live CD.
2019-10-06 22:36:19 +02:00
Doug Lyons
b6b7bda443
Shell Find Improvements to make Search Item general and Show Sub-directories ( #1927 )
...
* Shell Find Improvement to make Search Item general by adding asterisks before and after before search and show sub-directories in find listing. CORE-16152
2019-10-05 16:32:49 +02:00
Pierre Schweitzer
0ce3941b41
[KERNEL32] Fix FIXME by calling appropriate function in GetNativeSystemInfo()
2019-10-02 10:52:00 +02:00
Thomas Faber
a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403
...
Fixes one of many crashes in shell32_winetest:shlfolder.
2019-09-29 12:42:26 +02:00
Thomas Faber
be1f95527a
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385
2019-09-29 12:09:39 +02:00
Thomas Faber
b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385
2019-09-29 12:09:02 +02:00
Thomas Faber
6b0d2c2a2c
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385
...
Addendum to c2b476bd77
.
2019-09-29 12:07:43 +02:00
Shy Zedaka
acaff47682
[BROWSEUI][SHELL32][TRANSLATION] Major Translations to BROWSEUI And New Search function to Hebrew, and Some Other changes. ( #1938 )
2019-09-26 22:18:59 +02:00
Lee Schroeder
43f03da358
[MSXML3R] XML/XSL file description localization ( #1926 )
...
Add localization for the file description of both XML and XSL file formats.
Please check for copypasta errors!
CORE-16390
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
2019-09-23 23:30:53 +02:00
Abdulganiev Rafael
9dd71e12b9
[TRANSLATION] Russian translation for browseui ( #1928 )
...
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
2019-09-23 23:28:46 +02:00
Joachim Henze
a40331b0f4
[COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093
...
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147
But greatly eliminates perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.
I committed the same workaround already into 0.4.12-RC-30-g
9513c9bf12
CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de714c
CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476074
2019-09-22 21:17:10 +02:00
Joachim Henze
b7f62b9bf9
[BROWSEUI] RC de-DE of Search feature & Folderoptions caption CORE-16392
2019-09-22 19:11:39 +02:00
Thomas Faber
c2b476bd77
[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385
2019-09-22 16:19:11 +02:00
Thomas Faber
b90c24d640
[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385
2019-09-22 16:19:09 +02:00
Thomas Faber
d41c5be3bd
[BROWSEUI] Fix a PIDL leak.
2019-09-22 11:42:06 +02:00
Thomas Faber
cfc5b3749f
[SHLWAPI] Import Wine commit c8175e6c7a7 (Fix Stat() method for file streams) by Nikolay Sivov.
...
Fixes crash in shlwapi_winetest:istream.
2019-09-22 11:42:01 +02:00
Thomas Faber
faae7e5790
[SHELL32] Handle BYREF variants in CFolderItems::Item.
...
Fixes crash in shell32_winetest:shelldispatch.
See also:
6634b31520
2019-09-22 11:41:57 +02:00
Hermès Bélusca-Maïto
7fccd6b763
[UBTRFS] Addendum to 255ef2c3: Add missing exports expected by mkbtrfs.
...
CORE-16383 CORE-16354
2019-09-21 04:35:01 +02:00
Adam Słaboń
c81af08f51
[TRANSLATION] Polish translation update ( #1916 )
...
Added translation for netstat, utilman and netplwiz. Updated translation of find, reg, rapps, regedit, sndvol32, usetup, hivesys, mmsys, openglcfg, powercfg, sysdm, shellext, browseui, devmgr, msgina, netcfgx, shell32, syssetup, shortcuts and vcdcontroltool.
2019-09-20 21:51:47 +02:00
Joachim Henze
841732e45c
[COMCTL32] Updown Suppress the NM_RELEASEDCAPTURE notification CORE-14365
...
This fixes a strange toggle-back-effect in 'Zeckensacks Glide Wrapper 0.84c'
by importing Wine commit
9dbe886e3f
Thanks to patches author Akihiro Sagawa <sagawa.aki@gmail.com>
2019-09-20 20:13:09 +02:00
Pierre Schweitzer
86c94e7858
[BROWSEUI] Translate search function into French
...
CORE-9279
2019-09-17 23:06:34 +02:00
Eric Kohl
a66c7d2ecc
[LSA][SECUR32] Check for untrusted clients
...
Calls to LsapCallAuthenticationPackage are routed to LsaApCallPackageUntrusted instead of LsaApCallPackage for untrusted clients.
2019-09-17 12:58:11 +02:00
Eric Kohl
ba43d1e839
[MSV1_0] Implement LsaApCallPackageUntrusted()
...
An untrusted client is only allowed to change passwords
2019-09-17 12:46:49 +02:00
Brock Mammen
9b75b67e9d
[SHELLFIND] Use IS_INTRESOURCE()
2019-09-15 19:46:36 +03:00
Brock Mammen
8da23e7eb9
[SHELLFIND] Add missing dependency to CMakeLists.txt
2019-09-15 19:46:36 +03:00
Brock Mammen
80f67b1111
[BROWSEUI] Add search strings to all language resources
2019-09-15 19:46:36 +03:00
Brock Mammen
e32b88be3d
[BROWSEUI] Add search dialog to all language resources
2019-09-15 19:46:36 +03:00
Brock Mammen
0311544bb3
[SHELLFIND] Fix return values
2019-09-15 19:46:36 +03:00
Brock Mammen
b766576487
[SHELLFIND] Remove unused COM interfaces
2019-09-15 19:46:36 +03:00
Brock Mammen
8228844241
[SHELLFIND] Remove unused functions
2019-09-15 19:46:36 +03:00
Brock Mammen
12451dc172
[SHELLFIND] Change parameter from array reference to pointer
2019-09-15 19:46:36 +03:00
Brock Mammen
7ac9fd9f51
[SHELLFIND] Remove unnecessary cast
2019-09-15 19:46:36 +03:00
Brock Mammen
0eee3ed368
[SHELLFIND] Remove redundant check
2019-09-15 19:46:36 +03:00
Brock Mammen
2513c47452
[SHELLFIND] Fix unsafe cast
2019-09-15 19:46:36 +03:00
Brock Mammen
fbdc08dceb
[SHELLFIND] Use CoTaskMemAlloc instead of SHAlloc
2019-09-15 19:46:36 +03:00
Brock Mammen
d0171027e0
[SHELLFIND] Fix IImageList leak
2019-09-15 19:46:36 +03:00
Brock Mammen
a3ee648d8b
[SHELLFIND] Simplify PIDLs to paths
2019-09-15 19:46:36 +03:00
Brock Mammen
0f995d77d1
[SHELLFIND] Remove search results folder from address edit box
2019-09-15 19:46:36 +03:00
Brock Mammen
e6a5821e0c
[SHELLFIND] Subscribe to folders that are already opened
2019-09-15 19:46:36 +03:00
Brock Mammen
07d37180a1
[SHELLFIND] Open search bar when search results folder is opened
2019-09-15 19:46:36 +03:00
Brock Mammen
312b628fe1
[SHELLFIND] Remove dependency on internal shell32 functions
2019-09-15 19:46:36 +03:00
Brock Mammen
6c6fd6d989
[SHELLFIND] Localize column names
2019-09-15 19:46:36 +03:00
Brock Mammen
641988a386
[SHELLFIND] Rename data members
2019-09-15 19:46:36 +03:00
Brock Mammen
fe5c76a034
[SHELLFIND] Fix handle leak for stop event
2019-09-15 19:46:36 +03:00
Brock Mammen
dce5ccec4e
[SHELLFIND] Use DeferWindowPos for resizing child windows
2019-09-15 19:46:36 +03:00
Brock Mammen
8aa063b451
[SHELLFIND] Use assignment instead of memcpy
2019-09-15 19:46:36 +03:00
Brock Mammen
3b9508e98f
[SHELLFIND] Fix copyright headers
2019-09-15 19:46:36 +03:00
Brock Mammen
e15445e0c5
[SHELLFIND] Remove unused function
2019-09-15 19:46:36 +03:00
Brock Mammen
ff7e9870ce
[SHELLFIND] Remove unnecessary data member for focus
2019-09-15 19:46:36 +03:00
Brock Mammen
a905699ac6
[SHELLFIND] Use case-insensitive string comparison
2019-09-15 19:46:36 +03:00
Brock Mammen
87c1f457eb
[SHELLFIND] Improve search bar UI
2019-09-15 19:46:36 +03:00
Brock Mammen
c46d60360a
[SHELLFIND] Update status bar text
2019-09-15 19:46:36 +03:00
Brock Mammen
8246cd4e1b
[SHELLFIND] Remove duplicate search code
2019-09-15 19:46:36 +03:00
Brock Mammen
41f9ad120d
[SHELLFIND] Add stop search command
2019-09-15 19:46:36 +03:00
Brock Mammen
41d7b3700d
[SHELLFIND] Add search command events
2019-09-15 19:46:36 +03:00
Brock Mammen
2f3db8d9a3
[SHELLFIND] Add search functionality
2019-09-15 19:46:36 +03:00
Brock Mammen
3583900b17
[SHELLFIND] Move window message constants to header file
2019-09-15 19:46:36 +03:00
Brock Mammen
6d6bc885cb
[SHELLFIND] Use smart pointers for PIDLs
2019-09-15 19:46:36 +03:00
Brock Mammen
27ca55bce6
[SHELLFIND] Add edit box for search location
2019-09-15 19:46:36 +03:00
Brock Mammen
363ddf9c70
[SHELLFIND] Set status bar text after opening search results folder
2019-09-15 19:46:36 +03:00
Brock Mammen
04fcbe3202
[SHELLFIND] Message handler for updating status bar text
2019-09-15 19:46:36 +03:00
Brock Mammen
2fdaa386d2
[SHELLFIND] Add "Open Containing Folder" to right-click menu
2019-09-15 19:46:36 +03:00
Brock Mammen
7c937bd9ef
[SHELLFIND] Add search bar click handler for testing search results
2019-09-15 19:46:36 +03:00
Brock Mammen
06fd04d7b0
[SHELLFIND] Message handler for adding search results
2019-09-15 19:46:36 +03:00
Brock Mammen
666bf34640
[SHELLFIND] Create PIDLs and add search results to folder
2019-09-15 19:46:36 +03:00
Brock Mammen
9c29004090
[SHELLFIND] Set default folder view mode to details
2019-09-15 19:46:36 +03:00
Brock Mammen
c0799cd25b
[SHELLFIND] Add default columns from CFSFolder
2019-09-15 19:46:36 +03:00
Brock Mammen
ccf9ce324f
[SHELLFIND] Add CFindFolder
2019-09-15 19:46:36 +03:00
Brock Mammen
7544656b85
[SHELLFIND] Open search results folder with search button
2019-09-15 19:46:36 +03:00
Brock Mammen
4212f4b175
[SHELLFIND] Add CSearchBar
2019-09-15 19:46:36 +03:00
Brock Mammen
957a604b36
[SHELL32] Implement CDefView::AddObject()
2019-09-15 19:46:36 +03:00
Brock Mammen
e7e551afda
[SHELL32] Make SHFindFiles open the search results folder
2019-09-15 19:46:36 +03:00
Timo Kreuzer
175abab7ad
[IPHLPAPI] Simplify spec file
...
Also move the exports where they are on Windows. This was already handled correctly by MSVC and still doesn't fix the order on GCC builds, but that is a different story and shall be addressed at a different time.
2019-09-08 16:23:46 +02:00
Timo Kreuzer
76eed61813
[IPHLPAPI] Improve function stubs
2019-09-08 16:23:46 +02:00
Carlo Bramini
6b8d722bb2
Fix italian translation: "Cancella" -> "Annulla" ( #1902 )
2019-09-08 14:04:41 +02:00
Pierre Schweitzer
255ef2c332
[UBTRFS] Upgrade to 1.4
...
CORE-16354
2019-09-02 08:19:49 +02:00
Timo Kreuzer
99fe069ce6
[CRT][MSVCRT] Add __DestructExceptionObject from wine
2019-09-01 16:29:26 +02:00
Eric Kohl
fa0eef085c
[BOOTDATA][LSASRV] Add the security service(s)
...
- Add the service routines for the SamSs service.
- Start the SamSs service.
2019-08-31 18:17:14 +02:00
Eric Kohl
0625eb3746
[SERVICES][ADVAPI32] Support the security process aka lsass.exe
...
- Reserve the pipe NtControlPipe0 for the security process.
- Count regular service control pipes from 1.
- Use I_ScIsSecurityProcess to identify the security process.
- Services.exe uses the SECURITY_SERVICES_STARTED event to notify the security process that NtControlPipe0 is ready for use.
2019-08-31 17:24:47 +02:00
Eric Kohl
8571c26a71
[NETAPI32] Implement DsEnumerateDomainTrustsA
2019-08-31 12:45:30 +02:00
Eric Kohl
324afc252c
[NETAPI32] Implement DsEnumerateDomainTrustsW
2019-08-25 18:23:38 +02:00
Eric Kohl
abeb3324fb
[NETAPI32] Implement DsAddressToSiteNamesA and DsAddressToSiteNamesExA
2019-08-25 11:39:53 +02:00
Ioannis Adamopoulos
e419195d37
[HEADERS] Move some helpers from undocshell.h to shellutils.h as they didn't cover anything undocumented. Merge traycmd.h in undocshell.h as both contain just undocumented shell definitions.
2019-08-25 12:20:52 +03:00
Eric Kohl
121f0a5c50
[NETAPI32] Fix a typo in DsDeregisterDnsHostRecordsA
...
Thank you very much UserNT and Thomas for the hint!
2019-08-25 11:15:00 +02:00
Eric Kohl
c9537b392b
[NETAPI32] Implement DsDeregisterDnsHostRecordsA
2019-08-24 22:57:36 +02:00
Eric Kohl
47b749aa31
[NETAPI32] Implement DsGetDcNameWithAccountA
2019-08-24 21:40:11 +02:00
Eric Kohl
792d0f6b78
[NETAPI32] Implement DsGetDcSiteCoverageA
2019-08-24 19:44:37 +02:00
Eric Kohl
61ac4f1ee9
[NETAPI32] Add the NetpAllocStrFromWStr helper function
2019-08-24 14:00:33 +02:00
Eric Kohl
3d5c682cd8
[NETAPI32] Implement DsGetSiteNameA
...
Also add the NetpAllocAnsiStrFromWStr helper function.
2019-08-24 13:15:41 +02:00
Mark Jansen
4872912eb2
[SETUPAPI] Demote some noisy dprints
2019-08-23 13:03:36 +02:00
Shy Zedaka
cbf47846e7
[TRANSLATION] Changes to Newdev and hdwwiz
2019-08-21 18:49:59 +02:00
Shy Zedaka
cc8180fe63
[TRANSLATION] Change the recycle bin from 'Trash' to 'Recycle bin'
2019-08-21 18:49:59 +02:00
Mark Jansen
ca4b001544
[NTDLL_VISTA] Fix the build for arm
2019-08-20 22:31:56 +02:00
Mark Jansen
6872cef0da
[FRAMEDYN[ARM] Fix some exports
2019-08-20 22:31:55 +02:00
Serge Gautherie
9f5f7a97f8
[IPHLPAPI] icmp.c: Restore sync after Wine Staging 1.7.55
...
Mark all our (new) differences.
2019-08-20 15:20:01 +02:00
Mark Jansen
c2b9f94234
[COMCTL32] imagelist: Invalidate the cookie of a destroyed imagelist
...
CORE-16316
CORE-16275
2019-08-19 21:25:07 +02:00
Konstantin Motylkov
ab2c90f1b9
[DNSAPI][DNSAPI_APITEST] Fix DnsQuery_UTF8 function and add tests
...
CORE-11634
2019-08-19 20:01:23 +02:00
Serge Gautherie
cb77f1701f
[SHELL32][STOBJECT] Enforce ShellExecuteW(..., file, parameters, ...)
...
CORE-16299
2019-08-19 13:01:08 +02:00
Eric Kohl
f052817d84
[MSV1_0] Add SpLsaModeInitialize and SpUserModeInitialize.
...
SpLsaModeInitialize and SpUserModeInitialize will provide access to SSPI functions. LSASRV will soon access the LsaAp functions via SpLsaModeInialize.
2019-08-18 14:56:27 +02:00
Serge Gautherie
8ba4b11a33
[IPHLPAPI] icmp.c: Complete sync with Wine Staging 1.7.55
...
- Restore a missing brace.
- Mark all our differences (at that time). Please inspect them.
CORE-10536
2019-08-17 17:48:21 +02:00
Katayama Hirofumi MZ
344d559935
[COMCTL32] Unchange the property sheet page after WM_INITDIALOG ( #1842 )
...
In my testing on Win2k3, EN_CHANGE is generated in OnInitDialog, that is correct. The target is property sheet. The property sheet does unchange the page after WM_INITDIALOG generation. CORE-16280
2019-08-17 20:02:57 +09:00
Andreas Maier
2b5f38295b
[COMCTL32] remove unused theme_*.c files.
2019-08-17 12:08:04 +02:00
Shy Zedaka
fca051a1d1
[TRANSLATION][NEWDEV] Complete Hebrew Translations for New Device Prompt
2019-08-16 20:04:27 +02:00
Jose Carlos Jesus
0b4510301b
[SHELL][COMCTL32] pt_PT_Translation Improvements
2019-08-16 19:32:23 +02:00
Andrew Boyarshin
0a84597679
[COMCTL32] Export LoadIconMetric and LoadIconWithScaleDown
...
They are already implemented and there is little sense for them to be hidden.
Required for ProcessHacker 3.0+.
2019-08-16 18:31:07 +02:00
Andreas Maier
83dcae1e0f
[JSCRIPT] import wine commits "stub + implement Enumerator()"
...
6630bc4096
a015c62643
CORE-13810
2019-08-16 16:37:32 +02:00
Waritnan Sookbuntherng
76dfa2b284
[COMCTL32] Checking size grip bounds in x-axis only
2019-08-16 16:22:24 +02:00
Waritnan Sookbuntherng
b9ddad0bbb
[COMCTL32] Hide size grip when the parent window is maximized
2019-08-16 16:22:24 +02:00
Andreas Maier
4093681ad0
[COMCTL32] Saturated images: Take mask-images in account.
...
This fixes CORE-14209 - Some icons not drawn in IDA Free
2019-08-15 21:11:45 +02:00
Andreas Maier
49a797543f
[COMCTL32] Improve failure cases.
2019-08-15 21:11:45 +02:00
Adam Słaboń
65f42596ce
[THEMES][LUNAR] Update
...
Improved Button and Combo Button bitmaps, fixed SYSSETUP Lunar resource.
2019-08-15 20:25:02 +02:00
Shy Zedaka
a3944563c3
[SHELL32] Run Dialog Text Fix
2019-08-15 20:03:55 +02:00
Katayama Hirofumi MZ
944aba1fcc
[SHELL32] Fix Desktop Properties menu item action ( #1833 )
...
1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.
The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299
2019-08-15 23:10:06 +09:00
Denis Malikov
18a9993d69
[KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it
2019-08-15 15:50:59 +02:00
Serge Gautherie
40ab30d6a0
[KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6
...
CORE-12596
2019-08-15 15:42:34 +02:00
Timo Kreuzer
ad89837c0e
[3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code
2019-08-15 15:24:12 +02:00
Shy Zedaka
187c9fc33c
[Translation] More Hebrew Translations
...
Co-authored-by: Baruch Rutman <peterooch@gmail.com>
2019-08-15 13:41:01 +02:00
Mark Jansen
c96ba1aff2
[SHELL32] CDefView: Improve the context menu positioning
...
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.
2019-08-15 11:28:31 +02:00
Joachim Henze
0f16d44b66
[SHELL32] Improve ShellExecute
...
This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.
Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.
Automated tests do improve as well
VBox https://reactos.org/testman/compare.php?ids=68662,68696
KVM https://reactos.org/testman/compare.php?ids=68663,68697
I intend to merge this back into 0.4.12RC.
2019-08-06 20:24:55 +02:00
Katayama Hirofumi MZ
5972b1e284
[SYSSETUP] Caption of 2nd stage ReactOS Setup is too heavy ( #1806 )
...
The caption text of 2nd stage ReactOS Setup was too bold. CORE-16295
2019-08-06 11:09:56 +09:00
Katayama Hirofumi MZ
836e3107ba
[SYSSETUP] Fix bold font ( #1799 )
...
The font of radio buttons at ReactOS 2nd setup was wrong and too heavy. CORE-16291
2019-08-05 09:44:25 +09:00
Eric Kohl
7550e9efbf
[DEVMGR] Add the code to uninstall a device from the property page
2019-08-04 11:20:04 +02:00
Eric Kohl
611989943e
[DEVMGR] Change the menu id prefix from IDC_ to IDM_.
2019-08-03 21:52:00 +02:00
Eric Kohl
38d3c4d8da
[DEVMGR] Fix the indentation of the menu resources. No code changes!
2019-08-03 16:37:54 +02:00
Eric Kohl
d1a2983c00
[DEVMGR] Fix wonky action menu
...
Patch by Pi_User5.
CORE-10364
2019-08-03 14:54:18 +02:00
Hermès Bélusca-Maïto
44cddadba8
[KERNEL32] Minor enhancements for CreateRemoteThread(). ( #804 )
...
- Add some cleanup code in failure code paths, instead of asserting.
- Move BasepNotifyCsrOfThread() helper to the only file where it is used.
- Don't use ERROR_DBGBREAK in failure paths but just DPRINT the error
message: we handle the failures properly.
- When creating the remote thread, sync its service tag with the parent
thread's one.
2019-08-01 19:12:49 +02:00
Hermès Bélusca-Maïto
effdb6f232
[KERNEL32][RTL] Diverse fixes/improvements for thread stack creation code. ( #802 )
...
- kernel32!BaseCreateStack() is compatible with ntdll!RtlpCreateUserStack().
- When checking whether a stack guard page can be added, its size has to
be accounted for in the checking logic.
- We have to satisfy the PEB::MinimumStackCommit constraint.
- We cannot use PEB::GuaranteedStackBytes in BaseCreateStack() since it is
nowhere initialized (default is 0). It gets initialized to a non-zero
value when the user manually calls SetThreadStackGuarantee().
https://www.installsetupconfig.com/win32programming/windowsthreadsprocessapis7_6.html
- RtlpCreateUserStack(): Fix memory leak in failure case.
- RtlpFreeUserStack() doesn't need to return anything.
See also commit 1bc59379
(r59868).
CORE-11319
2019-08-01 19:04:13 +02:00
Joachim Henze
8b67edd8fa
[INPUT][INTL][SYSSETUP] Limit Combobox height CORE-16252
...
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaa
Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
2019-07-30 23:14:31 +02:00
Eric Kohl
034c6fd0c5
[LSASRV] Improvements to LsapLogonUser()
...
- Token handle duplication must be the last step because we cannot close the duplicated token handle if something fails.
- Call LsaApLogonTerminated(), delete the logon session and free the profile buffer if something fails.
2019-07-30 23:10:33 +02:00
Eric Kohl
32861b84b9
[MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHours() for testing.
2019-07-29 01:22:37 +02:00
Jose Carlos Jesus
f699cc96ac
[NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position adjustments ( #1761 )
2019-07-29 00:20:40 +02:00
Eric Kohl
12aba91abb
[MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and MsV1_0ReLogonUsers are obsolete.
2019-07-28 14:57:46 +02:00
Doug-Lyons
77671f0337
[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. ( #1684 )
...
CORE-16123
- NETID: Correct the call when using the "Computer Name Change" in ReactOS.
- WINLOGON: Update the volatile "Hostname" and "Domain" variables from
their non-volatile counterparts.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-07-22 00:49:47 +02:00
Michael Maltsev
a303932803
[ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094
2019-07-21 11:39:30 +02:00
Timo Kreuzer
ddb56e8cca
[OLEAUT32] Use snprintf instead of sprintf
...
Fixes GCC 8 warning:
dll/win32/oleaut32/oleaut.c:876:39: error: '%s' directive writing up to 99 bytes into a region of size between 92 and 291 [-Werror=format-overflow=]
sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
^~ ~~~
dll/win32/oleaut32/oleaut.c:876:5: note: 'sprintf' output between 18 and 316 bytes into a destination of size 300
sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer
3120320c65
[FRAMEDYN] Fix broken asm (.code64 is for x64 only)
2019-07-20 13:56:18 +02:00
Timo Kreuzer
1b70ddd834
[KERNEL32] Improve path name handling
...
Fixes GCC 8 warning:
dll/win32/kernel32/client/loader.c: In function 'LoadLibraryA':
dll/win32/kernel32/client/loader.c:129:17: error: 'strncat' specified bound 13 equals source length [-Werror=stringop-overflow=]
strncat(PathBuffer, "\\twain_32.dll", 13);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer
2800837dc0
[MSGINA] Fix copying the TokenSource string
...
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.
Fixes GCC 8 warning:
dll/win32/msgina/lsa.c:195:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(TokenSource.SourceName, "User32 ", sizeof(TokenSource.SourceName));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer
f3a9b524f1
[ADVAPI32] Fix copying the TokenSource string
...
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.
Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(TokenSource.SourceName, "Advapi ", sizeof(TokenSource.SourceName));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Jose Carlos Jesus
69454b4302
[TRANSLATION] Add Portuguese (neutral) translation. ( #1702 )
...
Add Portuguese (neutral) translation for intl.cpl, main.cpl, msgina.dll, msports.dll, welcome.exe and rundll32.exe, and fix the one in mshtml.dll .
2019-07-15 00:07:50 +02:00
Eric Kohl
433c9d327e
[SETUPAPI] Implement CM_Delete_DevNode_Key_Ex()
...
CM_REGISTRY_USER is not supported yet.
2019-07-13 14:26:57 +02:00
Mark Jansen
b5423ba70b
[SHELL32] Fix SHCreateDirectoryExW showing an error on success
...
CORE-15145
2019-07-09 22:52:17 +02:00
Eric Kohl
93f77f2625
[SETUPAPI] CM_Delete_DevNode_Key[_Ex]: Use DEVINST instead of DEVNODE because we are using DEVINST anywhere else.
2019-07-08 00:08:22 +02:00
Eric Kohl
86e8a477b6
[SETUPAPI] CMP_RegisterNotification: When a window is registered, pass the window text to PNP_RegisterNotification().
2019-07-07 23:47:01 +02:00
Bișoc George
019e3ffe5f
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. ( #1688 )
...
CORE-12313
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-07-07 19:01:09 +02:00
Hermès Bélusca-Maïto
8a30801516
[SHELL32] Recycle-Bin: Minor code enhancements.
...
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
2019-07-07 17:56:51 +02:00
Bișoc George
818d660868
[SHELL32] Enable the "Apply" button when user takes action on the edit box control ( #1720 )
...
CORE-12312
2019-07-07 14:47:44 +02:00
Eric Kohl
ece54dcd2f
[SETUPAPI][UMPNPMGR] The 3rd parameter of PNP_RegisterNotification() seems to be the service name
2019-07-07 13:41:00 +02:00
Victor Perevertkin
042646ceac
[IPHLPAPI] Use if_descrlen field for determining the length of
...
if_descr in IFEntry structure. This fixes heap corruption on GCC8.
CORE-16088
2019-07-05 22:49:12 +03:00
Stanislav Motylkov
a76e03d8bc
[SHELL32][USERENV] Improve Russian translation ( #1710 )
...
CORE-16170
2019-07-01 21:43:22 +02:00
Jose Carlos Jesus
86d4156c39
[TRANSLATIONS] Add/Update Portuguese (neutral) translations. ( #1687 )
...
Translations for SYSDM.CPL, SETUPAPI, SHELL32, LSASRV, SAMSRV, SYSSETUP,
USRMGR, THEMEUI, USERENV, WININET, MSCONFIG.
2019-06-29 16:55:33 +02:00
Eric Kohl
7eb6e42626
[UMPNPMGR][SETUPAPI] PNP_RegisterNotification() has got 9 parameters.
2019-06-29 13:38:42 +02:00
Eric Kohl
a9c4c07955
[SETUPAPI][UMPNPMGR] PNP_UnregisterNotification: Add 2 unknown parameters
2019-06-23 21:45:54 +02:00
Eric Kohl
ca0406131c
[SETUPAPI][UMPNPMGR] Improve CMP_RegisterNotification/PNP_RegisterNotification
...
Pass the notification filter to PNP_RegisterNotification as a byte-pointer to the filter and the size of the filter.
2019-06-23 19:31:34 +02:00
Eric Kohl
89c936fdd6
[NETCFGX] Start a network adapter device after the custom install steps have been completed.
...
This could probably fix CORE-16103
2019-06-22 21:01:26 +02:00
Eric Kohl
8dc70d2454
[SETUPAPI] Implement SetupDiRestartDevices()
2019-06-22 21:01:25 +02:00
Andreas Maier
49165276f2
[COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) ( #1674 )
...
* [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression)
Fix cb_states / rb_states lookup table.
* [README.WINE] comctl32 is synced to WineStaging-3.3.
See commit b3fb8555
.
2019-06-22 16:36:14 +02:00
Jose Carlos Jesus
be820b9ca3
[NEWDEV] Add Portuguese (neutral) translation.
2019-06-22 16:17:03 +02:00
Jose Carlos Jesus
0e6732586d
[NETID] Add Portuguese (neutral) translation.
2019-06-22 16:16:58 +02:00
Jose Carlos Jesus
64a647a843
[NETCFGX] Add Portuguese (neutral) translation.
2019-06-22 16:11:55 +02:00
Eric Kohl
73ca084e96
[NETCFGX] Read a components bind value and implement the IsBoundTo method.
2019-06-20 22:08:38 +02:00
Eric Kohl
79a0f2b430
[NETCFGX] EnumClientServiceProtocol: Use the right parent key when trying to open the 'NDI' subkey.
...
This makes the description of the selected item show up in the network connection properties.
2019-06-20 20:08:36 +02:00
Hermès Bélusca-Maïto
1dc4ba9da7
[DEVMGR] Add the missing pt-PT.rc translation file. Strange, I thought I added it before...
2019-06-20 18:04:26 +02:00
Mas Ahmad Muhammad
682ea2206a
[NEWDEV] Update Indonesian translation.
2019-06-20 17:31:53 +02:00
Mas Ahmad Muhammad
11f1b911d8
[IEFRAME] Add Indonesian translation.
2019-06-20 17:31:52 +02:00
Mas Ahmad Muhammad
7f09d9512c
[DEVMGR] Update Indonesian translation.
2019-06-20 17:31:51 +02:00
Mas Ahmad Muhammad
867fdc24d9
[MSGINA] Update Indonesian translation.
2019-06-20 17:31:50 +02:00
Mas Ahmad Muhammad
859199ee16
[COMCTL32] Add Indonesian translation.
2019-06-20 17:31:49 +02:00
Mas Ahmad Muhammad
bb499e4b4e
[THEMEUI] Add Indonesian translation.
2019-06-20 17:31:47 +02:00
Mas Ahmad Muhammad
d0629fde40
[COMDLG32] Add Indonesian translation.
2019-06-20 17:31:46 +02:00
Mas Ahmad Muhammad
4742f65936
[BROWSEUI] Add Indonesian translation.
2019-06-20 17:31:44 +02:00
Jose Carlos Jesus
37c43a7414
[DEVMGR] Add Portuguese (neutral) translation.
2019-06-20 17:15:17 +02:00
Jose Carlos Jesus
666e6561d5
[CREDUI] Update Portuguese (neutral) translation.
2019-06-20 17:15:17 +02:00
Jose Carlos Jesus
af10e1fb74
[COMDLG32] Update Portuguese (neutral) translation.
2019-06-20 17:15:16 +02:00
Jose Carlos Jesus
4bbeb21f6d
[COMCTL32] Update Portuguese (neutral) translation.
2019-06-20 17:15:15 +02:00
Jose Carlos Jesus
7df98d73b3
[BROWSEUI] Add Portuguese (neutral) translation.
2019-06-20 17:15:15 +02:00
Jose Carlos Jesus
64785cf7d3
[ACLUI] Add Portuguese (neutral) translation.
2019-06-20 17:15:14 +02:00
Eric Kohl
e57f103d53
[NETCFGX] Add the interfaces INetCfgBindingInterface and IEnumNetCfgBindingInterface (stubs only).
2019-06-19 22:38:31 +02:00
Eric Kohl
ec9c8fdf25
[NETCFGX] Add the interfaces INetCfgBindingPath and IEnumNetCfgBindingPath (stubs only).
2019-06-18 22:35:46 +02:00
Eric Kohl
2da533a8a4
[NETCFGX] NetPropPageProvider: Handle the Min and Max values for INT, LONG and WORD types properly
...
CORE-15095
2019-06-18 21:47:29 +02:00
Mark Jansen
c8ef4912a7
[URLMON] Directly call cabinet!Extract instead of calling it via advpack!ExtractFilesW
...
CORE-15795
2019-06-17 19:51:58 +02:00
Eric Kohl
1270e0a4fc
[NETCFGX] Add the INetCfgComponentBindings interface to the NetCfgComponent class.
2019-06-17 14:57:08 +02:00
Eric Kohl
24b22db77e
[NETCFGX] Resize a helper buffer to accommodate a device instance id.
...
This prevent NULL pointer exceptions in calls to INetCfgComponent::GetPnpDevNodeId().
2019-06-17 00:46:30 +02:00
Eric Kohl
9bf78b6a95
[NETCFGX] Set the ComponentId value when a NIC is installed.
2019-06-16 23:59:52 +02:00
Mark Jansen
bcffdd0b16
[RASAPI32] Add RasClearConnectionStatistics stub
...
CORE-10092
2019-06-16 13:56:54 +02:00
Serge Gautherie
b13990bd78
[SETUPAPI] Revert "Fix a typo in CM_Query_Resource_Conflict_List." ( #1634 )
...
Previous code was correct.
This reverts commit c47ad98f
.
2019-06-15 17:55:33 +02:00
Baruch Rutman
22064d7787
[LPK] Fix for CORE-16115. ( #1654 )
...
Proposed changes:
- Use the total extent (width) and font metrics (height) as values
to put in the lpSize variable instead of calling ScriptString_pSize()
in the LpkGetTextExtentExPoint() function.
- Use GetTextExtentExPointWPri in more cases as another effort to get the data.
- Trailing whitespace fixes.
2019-06-15 17:37:51 +02:00
Baruch Rutman
1a7ffd29d6
[LPK] Update Wine BiDi code. ( #1651 )
...
Imports the changes from
ef07087f47
2019-06-15 17:24:38 +02:00
Joachim Henze
10f00f8c1c
[MSI] Fix regression CORE-14646
...
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.
The regression was introduced to ros by 0.4.8-dev-739-g
f8b992f2d3
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445
Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.
I also committed the same fix to 0.4.12-RC-32-g152ee20.
2019-06-14 23:21:37 +02:00
Eric Kohl
7b29f4d975
[NETCFGX] InstallNetDevice: Run the default device installer before making class-specific changes.
2019-06-13 14:16:25 +02:00
Giannis Adamopoulos
cc25a266f2
[COMCTL32] imagelist: Make the exported functions use the internal IImageList2
...
- Add a hack to rename the exported functions and use the Internal_ prefix for them so that the IImageList can use them with minimal code changes.
- Add the correct implementation of the affected exported functions making them now use the IImageList of the passed HIMAGELIST.
This indirection is possible because an HIMAGELIST is also a IImageList*.
This indirection is also needed because we can end up using image lists created by either comctl32 v5 or comctl32 v6.
This is how windows manage to use an HIMAGELIST created by comctl32 v5 when it is passed to comctl32 v6.
What really happens in this scenario is that the exported functions of both versions end up using the interface
stored in the object without checking if this interface is the version provided in the same dll or in the other.
2019-06-12 19:20:44 +03:00
Pierre Schweitzer
f381137c89
[BTRFS] Upgrade to 1.3
...
CORE-16111
2019-06-11 12:35:19 +02:00
Eric Kohl
90aa2c26f8
[NETCFGX] Improvements to the TCP/IP settings dialog.
...
- Separate the gateway settings from the DHCP settings.
- Enable Edit and Delete buttons only if an item in a list box has been selected.
CORE-9908
2019-06-11 06:58:42 +02:00
Eric Kohl
8f285f71c9
[NETCFGX] Do not update the TCP/IP properties when the cancels the advanced properties dialog.
...
CORE-9908
2019-06-10 20:28:58 +02:00
Yaroslav Kibysh
f0163f124f
[MSGINA] Update Ukrainian translation. ( #1642 )
2019-06-10 17:00:44 +02:00
Yaroslav Kibysh
b2e4ff8cfd
[SHELL32] Update Ukrainian translation. ( #1637 )
2019-06-10 16:45:20 +02:00
Pierre Schweitzer
a7b6a1a97d
[MSGINA] Update French translation
2019-06-10 15:37:32 +02:00
Eric Kohl
f2f698587c
[MSGINA] Add missing logon restriction messages.
2019-06-09 22:42:10 +02:00
Serge Gautherie
8a8453494f
[SHELL32] SHCreateShellFolderView(): Fix parameter validation order. ( #1632 )
...
Fixes one modification from commit ae2a85d0
.
CORE-16098
2019-06-09 15:57:45 +02:00
Eric Kohl
c1421c4108
[NETAPI32] Ignore usriX_logon_hours and usriX_units_per_week if usriX_logon_hours is NULL.
2019-06-09 15:25:13 +02:00
Eric Kohl
1b05c9586c
[NETAPI32] Do not try to set usriX_max_storage. Just ignore it.
2019-06-09 14:50:07 +02:00
Serge Gautherie
92e5fabb55
[BROWSEUI] Fix SHEnumClassesOfCategories() parameter validation. ( #1622 )
...
Addendum to fdfef818
. CORE-11711
2019-06-08 20:05:54 +02:00
Hermès Bélusca-Maïto
ae2a85d003
[SHELL32] Fix some NULL-pointers validation.
...
- In the exported SHCreateDefaultContextMenu() and
IDataObject_Constructor() functions (called amongst others by
the exported CIDLData_CreateFromIDArray() function).
- In the exported SHCreateShellFolderView() function.
- In CDefView::GetItemObject(), where data was written to *ppvOut before
ppvOut was being checked for NULL.
2019-06-08 19:43:02 +02:00
Yaroslav Kibysh
47d76db311
[BROWSEUI] Update Ukrainian translation. ( #1626 )
2019-06-08 18:43:13 +02:00
Yaroslav Kibysh
6a8e99e235
[NEWDEV] Update Ukrainian translation. ( #1625 )
2019-06-08 18:37:29 +02:00
Yaroslav Kibysh
4d44e11f1e
[SHELL32] Update Ukrainian translation. ( #1623 )
2019-06-08 17:58:42 +02:00
Eric Kohl
c47ad98ff7
[SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List.
2019-06-06 19:12:44 +02:00
Eric Kohl
adc9bd48b7
[SETUPAPI] GetDeviceInstanceKeyPath: Create a new driver instance property if needed and SEH-protect calls to umpnpmgr.
2019-06-06 19:08:43 +02:00
Hermès Bélusca-Maïto
fdfef818ef
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. ( #1559 )
...
CORE-11711
2019-06-06 17:07:38 +02:00
Serge Gautherie
1f8250f700
[BROWSEUI] browseui.spec: Fix SHEnumClassesOfCategories() parameters. ( #1559 )
2019-06-06 17:06:52 +02:00
Serge Gautherie
addfb61d8b
[NTDLL_VISTA] Check _DEBUG with #ifdef, not #if ( #1615 )
2019-06-06 01:49:18 +02:00
Serge Gautherie
46259092f9
[ADVAPI32:REG] Remove some useless casts ( #1614 )
2019-06-05 18:37:07 +02:00
Serge Gautherie
38db074491
Misc addendum to CORE-14271 ( #1529 )
...
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.
Also, add a FIXME.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RegisterClipboardFormatA/W() a bit
No functional change.
* [UDFS] Simplify SeSinglePrivilegeCheck() return value check
No functional change.
Addendum to
CORE-14271
2019-06-04 16:56:33 +02:00
Joachim Henze
bc3eed68ca
[MSHTML] Fake Success in HTMLDocument_put_bgColor()
...
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error 8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
2019-06-01 22:53:16 +02:00
Eric Kohl
adceb3807e
[NETAPI32] Implement parts of NetGetDCName and declare some parameters optional.
2019-05-29 15:35:55 +02:00
Eric Kohl
968bdeddf3
[NETAPI32] Implement NetpAllocWStrFromStr(), NetpAllocWStrFromAnsiStr() (not public, but useful) and NetpAllocWStrFromWStr().
2019-05-29 12:59:44 +02:00
Katayama Hirofumi MZ
9a39315d46
[SYSSETUP] Set registry hostname in WriteComputerSettings ( #1589 )
...
Based on @Doug-Lyons's patch. CORE-16067
2019-05-29 19:59:40 +09:00
Timo Kreuzer
801ec51a91
[BROWSEUI] Fix indentation
...
Fixes GCC 8 warning:
dll/win32/browseui/explorerband.cpp:1332:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if (!SUCCEEDED(hr) || !pParent.p)
^~
dll/win32/browseui/explorerband.cpp:1335:21: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
hr = pParent->SetNameOf(0, pidlChild, dispInfo->item.pszText, SHGDN_INFOLDER, &pidlNew);
^~
2019-05-27 13:22:40 +02:00
Timo Kreuzer
207a0f520e
[MSHTML] Convert tabs to spaces
...
Fixes GCC 8 warning:
dll/win32/mshtml/script.c:844:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if(!new_buf)
^~
dll/win32/mshtml/script.c:846:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
This->size <<= 1;
^~~~
2019-05-27 13:22:40 +02:00
Timo Kreuzer
089d59bc6c
[RSAENH] Use StringCbPrintfA instead of sprintf
...
Fixes GCC 8 warning:
dll/win32/rsaenh/rsaenh.c:161:23: error: '%s' directive writing up to 259 bytes into a region of size 235 [-Werror=format-overflow=]
#define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:161:23: note: in definition of macro 'RSAENH_REGKEY'
#define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:1107:5: note: 'sprintf' output between 26 and 285 bytes into a destination of size 260
sprintf(szRSABase, RSAENH_REGKEY, pKeyContainer->szName);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-05-27 13:22:40 +02:00
Timo Kreuzer
81bdf4e360
[CRT] Add missing posix error codes
...
These are required by latest mingw-w64 stl and we are mixing this with our crt headers.
Define _CRT_NO_POSIX_ERROR_CODES in all modules that define their own constants.
2019-05-27 13:22:40 +02:00
Katayama Hirofumi MZ
2db0e159a4
[KERNEL32] Fix SetComputerNameExW ( #1583 )
...
Based on @Doug-Lyons's patch. CORE-16058
2019-05-27 16:18:38 +09:00
Jose Carlos Jesus
7f5e960e32
[TRANSLATIONS] Update/Add Portuguese translations.
...
Translations for: reactos/setup, usetup, syssetup, netshell, shell32.
2019-05-26 21:19:31 +02:00
Jose Carlos Jesus
73d7fd1415
[TRANSLATIONS] Update/Add Portuguese translations. ( #1564 )
...
Translations for: deskadp, deskmon, reactos/setup, usetup, syssetup.
Co-Authored-By: Bișoc George <fraizeraust99@gmail.com>
2019-05-19 17:04:47 +02:00
Pierre Schweitzer
ea7aca8bdd
[KERNEL32] Drop unused line breaks
2019-05-08 18:34:28 +02:00
Pierre Schweitzer
204bfa8574
[KERNEL32] Misc. fixes to DefineDosDeviceW
...
- Add support for LUIDDeviceMapsEnabled;
- Broadcast proper message in case of device removal;
- Use less memory for strings management;
- Make code a bit cleaner.
2019-05-05 18:33:15 +02:00
Pierre Schweitzer
5d20d512be
[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces
...
It also comes with a small performance boost: instead of performing object
queries one after another, we query them all at once.
2019-05-05 14:18:09 +02:00
Pierre Schweitzer
8d128aa441
[KERNEL32] Reduce QueryDosDeviceA memory footprint
...
by using TEB static unicode string (which is already
preallocated).
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.
2019-05-05 10:17:16 +02:00
Pierre Schweitzer
1ed7f27466
[KERNEL32] Reduce DefineDosDeviceA memory footprint
...
by using TEB static unicode string (which is already
preallocated).
2019-05-05 10:17:16 +02:00
Eric Kohl
5164c852e8
[POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState.
2019-05-02 20:39:58 +02:00
Hervé Poussineau
7033ab18df
[HID] Use hidparser static library for HidP_* functions
...
hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys
At the same time, this permis implementation of some HidP_* functions.
2019-05-02 20:06:47 +02:00
Katayama Hirofumi MZ
dcaaf3e7af
[COMDLG32] Fix treatment of wrong filename extension ( #1545 )
...
Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270
2019-05-02 22:48:01 +09:00
Hermès Bélusca-Maïto
77d234b049
[KERNEL32] Addendum to 0e3a0435
(PR #803 ): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989
2019-04-29 22:51:35 +02:00
Serge Gautherie
cf48f8bf8a
[REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE ( #1526 )
...
No functional change otherwise.
2019-04-28 21:19:42 +02:00
Katayama Hirofumi MZ
2da24f7274
[COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension
2019-04-28 08:44:52 +09:00
Hermès Bélusca-Maïto
0e3a043526
[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee(). ( #803 )
...
This should remove some of the "SetThreadStackGuarantee(): stub" messages in some simple cases.
2019-04-27 18:41:50 +02:00
Katayama Hirofumi MZ
6a7d8112c3
[COMDLG32] Save open/save location by extension ( #1514 )
...
Use the proper open/save initial folder for comdlg32.GetOpenFileName and comdlg32.GetSaveFileName. CORE-7114
2019-04-27 23:02:34 +09:00
Andrew Cook
716613cddc
[CMAKE] Use new policies for CMP0005 and CMP0018 ( #1481 )
...
* [CMAKE] Fix for CMP0018
The new behaviour lets us explicitly disabling position independent code, avoiding the need to change undocumented variables
* LINK_DEPENDS is semicolon separated
* [CMAKE] Fix for CMP0005
it seems impossible to have cmake correct escape PROXY_CLSID_IS so move it to the header
2019-04-27 11:33:37 +02:00
Jared Smudde
7e18b6d0eb
[BROWSEUI] Enable the Disconnect Network Drive menu item. ( #1522 )
...
CORE-13516, CORE-13518
2019-04-24 04:28:05 +02:00
Jared Smudde
bf431dd278
[MPR] Implement the function WNetDisconnectDialog(). ( #1522 )
...
CORE-13516, CORE-13518
2019-04-24 04:28:01 +02:00
Hermès Bélusca-Maïto
62823a08ce
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry.
2019-04-24 03:41:41 +02:00
Hermès Bélusca-Maïto
0416c598f8
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem().
2019-04-24 03:36:27 +02:00
Katayama Hirofumi MZ
8e60c2efee
[SHELL32] Implement 'New Link' (Retrial of #1510 ), CORE-15511 ( #1518 )
...
Correctly create cache about ".lnk" and handling in the member functions.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-04-24 03:28:17 +02:00
Mark Jansen
774f497721
[SYSSETUP] Fix a broken DPRINT
...
Thanks to Thomas for spotting it.
2019-04-22 16:24:59 +02:00
Eric Kohl
eabae983e0
[POWRPROF] EnumPwrSchemes: Fix callback string lengths
...
The callback routine should get the real lengths of the name and description strings in bytes instead of the buffer sizes in characters. This fixes buffer overflows in powercfg.cpl.
2019-04-22 00:44:47 +02:00
Eric Kohl
afca8367ea
[KERNEL32] GetSystemPowerStatus(): Set the BATTERY_FLAG_CRITICAL flag if the battery life gets lower than 5 percent.
2019-04-19 22:30:46 +02:00
Eric Kohl
333eb16f30
[KERNEL32] GetSystemPowerStatus(): Fix coding style. No code changes!
2019-04-19 22:28:11 +02:00
Andreas Maier
0263151f3c
[DBGHELP] SymFromAddr: Handle 2 or more symbols at the same address correct.
...
There could be more then 2 symbols at the same addr.
Adjust function to handle that case correct.
2019-04-19 21:09:45 +02:00
Andreas Maier
b2bcd8afdd
[DBGHELP] Set LastError for SymGetModuleBase-calls to ERROR_MOD_NOT_FOUND.
...
Correct last error in module_find_by_addr.
2019-04-19 21:09:45 +02:00
Andreas Maier
6175044aed
[DBGHELP] set correct values in symt_fill_sym_info (SYMBOL_INFO).
...
* symtype: set to SymPdb not SymCv (may be for old pdb-files pre VS 6.0)
* flags: return SYMFLAG_PUBLIC_CODE for SymTagPublicSymbol if its a function.
* flags: do not return SYMFLAG_FUNCTION for SymTagFuncion.
2019-04-19 21:09:45 +02:00
Andreas Maier
9466a005e9
[DBGHELP] Add SYMFLAG_- and SYMTYPE_-defines.
2019-04-19 21:09:44 +02:00
Andreas Maier
e3447d02c1
[DBGHELP] use correct record in codeview_snarf_public.
...
Use public_vx iststead of data_vx for public symbols.
2019-04-19 21:09:44 +02:00
Andreas Maier
183294a12e
[DBGHELP] search for debugfiles in modulepath too.
...
Debug symbols (like PDB, ...) could not be found if the direcory of
the module and application differs. Applying this patch they will
be found.
Dbghelp searches the module path too. (See MS docs).
2019-04-19 21:09:38 +02:00
Mark Jansen
9f00854bad
[MSGINA] Disable exceptions in atl when compiling without exceptions
2019-04-18 19:21:38 +02:00
Mark Jansen
f5731a41f8
[SHELL32] Use the same definitions for shell32 and it's static libs
2019-04-18 19:21:37 +02:00
Mark Jansen
9824a0154e
[ATL] Retire atlnew
2019-04-18 19:21:37 +02:00
Katayama Hirofumi MZ
083d6be31e
[KERNEL32] Implement InvalidateNLSCache
2019-04-16 21:41:58 +09:00
Katayama Hirofumi MZ
a004233bd3
[KERNEL32] Fix handle leak and caching (follow-up of 7e38267
)
2019-04-16 20:57:02 +09:00
Katayama Hirofumi MZ
7e3826786e
[KERNEL32] Era first year is GANNEN
2019-04-16 11:10:00 +09:00
Thomas Faber
6122f3f436
[COMCTL32] Remove an unnecessary include.
2019-04-14 14:35:29 +02:00
Thomas Faber
5685ad4a12
[CMAKE] Don't use the PCH for generated files.
...
The PCH must be used with the same compiler flags it was generated with,
so don't use it for files that use modified flags.
2019-04-13 15:58:22 +02:00
Timo Kreuzer
146096cd2e
[3RDPARTY] Make some warnings non-fatal
2019-04-13 14:07:50 +02:00
Timo Kreuzer
c2e16abc91
[DBGHELP] Fix 64 bit issue
2019-04-13 14:07:50 +02:00
Timo Kreuzer
f9a967b2ae
[REACTOS] Fix misc 64 bit issues
2019-04-13 14:07:50 +02:00
Katayama Hirofumi MZ
c65156002c
[SHELL32] Fix SHFileOperation Move operation ( #1487 )
...
Reduce failures of Move operation of shell32!SHFileOperation function. CORE-13450
2019-04-08 21:59:33 +09:00
Stanislav Motylkov
d2a2632fd9
[SYSSETUP] Update Russian translation
...
Addendum to 5d4d48a
, 21b7648
, and ea799b7
.
2019-04-07 23:51:34 +02:00
Foxlet
ea799b74f1
[SYSSETUP] Add Mizu to syssetup.
2019-04-07 22:47:20 +02:00
Hervé Poussineau
11d11cf6d0
[CMAKE] Temporarly disable pch in some modules to fix travis-ci
...
Problem appeared after 09c4d0a74b
2019-04-07 21:00:49 +02:00
Hervé Poussineau
10ecbaddd0
[ADVAPI32] Send correct type to ElfrChangeNotify()
...
This fixes the following compiler error:
../dll/win32/advapi32/service/eventlog.c:658:59: error: passing argument 3 of 'ElfrChangeNotify' makes integer from pointer without a cast [-Werror=int-conversion]
dll/win32/advapi32/eventlogrpc_c.h:391:20: note: expected 'ULONG {aka long unsigned int}' but argument is of type 'HANDLE {aka void *}'
2019-04-07 18:32:29 +02:00
Hervé Poussineau
09c4d0a74b
[CMAKE] Prevent out-of-bound accesses in parser/lexer files
...
which try to remove path prefix from them.
2019-04-07 18:32:29 +02:00
Joachim Henze
b71429059a
[COMCTL32] Improve status bar margin for unthemed and themed CORE-15834
...
Improve further what was recently committed in
0.4.12-dev-361-g
da9accfba6
2019-04-07 15:15:25 +02:00
Katayama Hirofumi MZ
f762aa3dd2
[SHELL32] Fix explorer file item label background CORE-15937
2019-04-07 21:38:00 +09:00
Katayama Hirofumi MZ
15537c3bbe
[KERNEL32] Support Japanese calendar ( #1482 )
...
Implement the Japanese calendar in kernel32. Locale info and date formatting. CORE-15920
2019-04-07 20:20:23 +09:00
Jérôme Gardou
23373acbb9
[CMAKE] Use modules instead of shared libraries
...
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.
On my system, this reduces the configure-time by a factor of two.
2019-04-06 17:43:38 +02:00
Katayama Hirofumi MZ
c7bebe40cb
[KERNEL32] Improve MultiByteToWideChar ( #1477 )
...
Reduce MultiByteToWideChar failures. CORE-13349
2019-04-06 20:11:07 +09:00
Katayama Hirofumi MZ
6150baf414
[SHELL32] pl-PL.rc escape sequence fix
2019-04-06 11:41:08 +09:00
Adam Słaboń
21b7648f15
[SYSSETUP] Add Lunar theme option to 2nd setup stage
...
This adds Lunar theme option to the 2nd setup stage theme chooser page.
2019-04-06 01:10:52 +02:00
Mark Jansen
5d4d48a850
[SYSSETUP] Add a theme chooser that can handle multiple styles
2019-04-05 21:56:31 +02:00
Adam Słaboń
7047aa80ef
[TRANSLATION] Polish translation update
...
Polish translation update for calc, fltmc, magnify, notepad, osk, sndvol32, usetup, fdebug, appwiz, mmsys, sysdm, acppage, ziplfdr, browseui, cryptui, jscript, shell32, themeui and inf. Added translation for cyrptext, vcdcontroltool, and (not yet complete) getuname.
2019-04-05 10:34:10 +02:00
Katayama Hirofumi MZ
f55ded91a4
[SHIMGVW] Fix cursor ( #1471 )
...
Fix the cursor of shimgvw.dll. CORE-15219
2019-04-05 16:52:11 +09:00
Katayama Hirofumi MZ
d04b4e65d6
[SHELL32] Implement Explorer background image (Retrial of #801 ) ( #1463 )
...
IconArea_Image, IconArea_Text and IconArea_TextBackground values in desktop.ini in a folder will be supported. It denies network paths. CORE-5516
2019-04-05 07:59:35 +09:00
Mark Jansen
d71712e909
[SYSSETUP] Ask for common controls v6 when using v6 features
2019-04-03 19:44:27 +02:00
Mark Jansen
bae083355d
[SYSSETUP] Add a missing break
2019-04-03 19:44:16 +02:00
Maxim Smirnov
39c0fd5722
[SHELL32] Fix version info in the file dialog
2019-04-03 00:51:24 +02:00
Julien Schueller
23d0aead53
[KERNEL32] Fix typo in kernel32.spec ( #1453 )
2019-04-02 15:48:41 +02:00
Timo Kreuzer
be97da34ac
[NETAPI32] Fix NetUserEnum to work on x64
...
The previous implementation used the resume_handle parameter to return a pointer to the active enumeration context, but resume_handle is a DWORD. To support 64 bit pointers, the enumeration context is inserted into a global linked list and given a unique 32 bit value as identifier for later lookup.
The way the function is implemented, leaking a data structure while the MSDN description does not indicate that, seems a little questionable in general, but that is something that I leave to the original author to investigate.
2019-04-02 01:45:51 +02:00
Timo Kreuzer
61e35141e8
[SETUPAPI] Use ClassInstallReserved field instead of Reserved to store a pointer.
...
The Reserved field is ULONG and we need ULONG_PTR. ClassInstallReserved was unused so far. I have no idea whether this is correct, but it cannot be more incorrect than what we had.
2019-04-01 22:20:39 +02:00
Hervé Poussineau
6cc607bac2
[SETUPAPI] SetupDiGetDeviceInfoListClass: fix buffer overflow (and return correct results)
2019-04-01 11:38:32 +02:00
Hervé Poussineau
faa938e9dc
[USERENV] Initialize variable before using it
2019-04-01 11:38:32 +02:00
Hervé Poussineau
6668178cff
[PSDK] Remove throw specifiers, deprecated in C++11
2019-04-01 11:38:32 +02:00
Yaroslav Kibysh
cc7c6d21f8
[DEVMGR] Fix Ukrainian translation ( #1441 )
2019-03-25 23:15:00 +01:00
Stanislav Motylkov
cd7011388e
[COMCTL32] Edit: Fix caret and scroll position
...
Based on patch by JIRA contributor 'I_Kill_Bugs'. CORE-15780
2019-03-24 23:26:20 +01:00
Hermès Bélusca-Maïto
780f2ba215
[USER32][COMCTL32] Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
...
CORE-8526
Import Wine commit:
96d0af52eb
"user32: Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
This patch also changes the logic to get the control style with WM_GETDLGCODE
instead of GetWindowLong to make the message test pass.
"
by Dmitry Timoshkov.
See bug report https://bugs.winehq.org/show_bug.cgi?id=42010
- (ReactOS-only) Fix also the corresponding logic in COMCTL32.
2019-03-24 17:23:24 +01:00
Yaroslav Kibysh
a30e644dc4
[EXPLORER][SHPOLICY] Implement "NoSimpleStartMenu" policy ( #1258 )
...
- Enable "New Start Menu" control for all languages.
- Implement the "NoSimpleStartMenu" policy in shpolicy.c and its usage in explorer.
- Hide controls instead of disabling (as in Win XP/Vista).
2019-03-24 14:56:43 +01:00