Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-01-04 21:38:43 +00:00
Code Issues Projects Releases Packages Wiki Activity
74036 commits 94 branches 276 tags 1 GiB
Commit graph

970 commits

Author SHA1 Message Date
Pierre Schweitzer
8a98c85c1f
[IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections 
This fixes the API not to return the current TCP connections while
enumerating them (and thus, netstat not displaying them).
It seems we return garbage for now though
 2018-11-20 22:14:25 +01:00
Hermès Bélusca-Maïto
2d320f5a8d
[OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber. 2018-11-18 21:06:22 +01:00
Pierre Schweitzer
d18b1fe24b
[IPHLPAPI] Properly count UDP entries 
Fixes crash when running netstat -a with
no TCP connections but with UDP connections

CORE-5401
 2018-11-18 18:56:36 +01:00
Pierre Schweitzer
e3cb9697a4
[IPHLPAPI] Implement getNumUdpEntries() and getUdpTable() 
CORE-5401
 2018-11-18 16:30:45 +01:00
Pierre Schweitzer
678204790c
[IPHLPAPI] Implement getNumTcpEntries() and getTcpTable() 
CORE-5401
 2018-11-18 16:30:45 +01:00
Denis Malikov
6a2f967302 [OLE32] Add stub for CoDisconnectContext function (#1044) 2018-11-18 15:32:07 +01:00
Pierre Schweitzer
5e024bfeb6
[MPR] Drop a nasty ReactOS specific hack 
That hack (cf. previous commit) was used to restore all
the saved connections. But, because it was implemented
in the wrong place, each time the MPR DLL was attached,
it was trying to restore connections.

With that commit and the previous one, now, ReactOS has
a correct behavior (it tries to bring back connections
only at session opening) and will reduce "workload" for
applications attaching MPR dll.

CORE-15310
 2018-11-17 22:13:34 +01:00
Pierre Schweitzer
8b0a126445
[MPR] Implement remembered connection enumeration 
Submitted upstream

CORE-15310
 2018-11-17 22:13:25 +01:00
Bișoc George
c00bafaad9 [SHELL32] Print out the error code (#973) 
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
 2018-11-16 23:09:15 +01:00
Pierre Schweitzer
52da844825
[COMCTL32] Don't leak memory in CB_ThemedPaint() 
CID 1441313
 2018-11-16 22:07:09 +01:00
Pierre Schweitzer
699af9f62a
[SETUPAPI] Allocate big enough buffer in CM_Query_Resource_Conflict_List(). 
CID 1441357
 2018-11-16 22:07:08 +01:00
Pierre Schweitzer
3fddd3157c
[COMCTL32] Don't leak memory in PB_ThemedPaint() 
CID 1441373
 2018-11-16 22:07:08 +01:00
Pierre Schweitzer
402c983094
[SYSSETUP] Fix error message in ApplyRegistryValues() 
CID 1441398
 2018-11-16 22:07:07 +01:00
Giannis Adamopoulos
9baf05f164 [SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file 
CORE-15353
 2018-11-15 21:26:17 +02:00
Luo Yufan
d8a4e0a8e3 [TRANSLATION]Update Simplified Chinese translation. (#1032) 2018-11-14 21:42:21 +09:00
Baruch Rutman
97150ce9dd [WINMM] Sync wine commit ebae298 as a fix for CORE-15336 (#1031) 
Reduce CPU usage by only attempting once to load the default joystick driver.
Fix for CORE-15336

Imported wine commit ebae298
ebae298aa4
https://www.winehq.org/pipermail/wine-devel/2018-November/134767.html
 2018-11-14 12:32:55 +01:00
Giannis Adamopoulos
bcd309cb7a [SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before 
CORE-14116
 2018-11-11 20:28:27 +02:00
Luo Yufan
5cdee1ab82 [TRANSLATION] Update Simplified Chinese translation. (#1028) 2018-11-11 17:57:12 +01:00
Adam Słaboń
b8044d6783 [TRANSLATION] Polish translation update (#1029) 
Translated missing strings and improved existing translations.
 2018-11-11 17:55:01 +01:00
Luo Yufan
91e032f9b1 [TRANSLATION] Update Simplified Chinese translation. (#1025) 2018-11-09 15:31:53 +01:00
Joann Mõndresku
b63e2d5046 [TRANSLATIONS] Style fixes for Estonian 2018-11-07 22:10:27 +01:00
Joachim Henze
04e1263921 [SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs 2018-11-07 01:40:53 +01:00
Eric Kohl
ee90e7f608 [LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions that use a policy handle and a domain name or domain SID when the machine is not a domain controller. 2018-11-04 15:27:57 +01:00
Eric Kohl
91eaa5e2d4 [LSASRV] Coding style fixes 2018-11-04 12:50:21 +01:00
Pierre Schweitzer
497a9c8087
[SETUPAPI] Don't let LZClose() reset error code 2018-11-02 09:34:25 +01:00
Carlo Bramini
8236bb8f38
Avoid stray temp files in failure cases of do_file_copyW. CORE-12616 2018-11-02 09:22:34 +01:00
Joachim Henze
ad34c91d1c [RICHED20] Revert ocr_reverse.cur to fix CORE-15190 
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.
 2018-10-30 19:06:50 +01:00
Mark Jansen
4bfac27ce6
[SHELL32] Fix broken control definition 2018-10-28 13:06:27 +01:00
Mark Jansen
95682e5406
[SETUPAPI] Fix broken control definition. 2018-10-28 13:06:08 +01:00
Mark Jansen
824e5dba51
[KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup 2018-10-28 13:01:38 +01:00
Mark Jansen
40549483f6
[KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup. 
This should allow unhandled exceptions in a thread to trigger our crash reporter,
instead of killing the process directly.
 2018-10-28 13:01:38 +01:00
Eric Kohl
0ce15a8faa [LSASRV][IDL] The first parameter of the Credr* functions is a PLSAPR_SERVER_NAME. 2018-10-27 18:17:35 +02:00
Hermès Bélusca-Maïto
c8d37c1a0d
[SYSSETUP] Use a $winnt$.inf file to retrieve setup information for the 2nd-stage setup. 
Following r75518, we use the $winnt$.inf file (created in System32
by the 1st-stage installer) as the setup information file for the
2nd-stage setup for:

- retrieving the installation source media path;
- retrieving the unattended information that was copied from the
  unattend.inf file from the installation source media.

The installation source media path is converted from NT format to
Win32 format for usage with Win32 functions and storage in the registry:
this is done by GetInstallSourceWin32(), which replaces the hackish
GetRosInstallCD() function.

The $winnt$.inf file is also updated, and the registry values "SourcePath"
and "ServicePackSourcePath" are created / updated in:
HKLM\Software\Microsoft\Windows\CurrentVersion\Setup .

svn path=/branches/setup_improvements/; revision=75524
 2018-10-27 18:13:38 +02:00
Giannis Adamopoulos
e69213448d [BROWSEUI] CInternetToolbar: fix whitespace 2018-10-27 15:08:31 +03:00
Giannis Adamopoulos
a2bd9b44a9 [BROWSEUI] Simplify toggling the search band 
In windows the toolbar itself creates the search shell extension. In ros we send a command to the CShellBrowser to let it handle it itself. Use the same command for showing and hiding it.
 2018-10-27 15:08:28 +03:00
Giannis Adamopoulos
a0c5cafce5 [BROWSEUI] Implement toggling the folders and search band with the toolbar and make their buttons appear pressed when they are shown. 
CBaseBarSite: Ask the CBaseBar to close itself when the x button is pressed.
CBaseBar: Hide the bar and inform its site that it is closing when it gets the close command.
CShellBrowser: Cache the guid of the current vertical bar and use it to report correct command status to the toolbar.
Also implement toggling the Folders, Favorites, History and search commands.
CInternetToolbar: Query the Folders and Search command status from the site so that they can be properly be shown as pressed.
 2018-10-27 15:08:24 +03:00
Stanislav Motylkov
c83ac7600d [SHIMGVW] Fix image flickering when rendering animations 2018-10-24 23:05:00 +02:00
Baruch Rutman
6a3b1879a1 [LPK][GDI32] Enable mirroring via version resource (#965) 
Add a mechanism that detects via the version resource whether it's needed to mirror
the application layout or not. This is a "follow up" to commit 5b14b6f.

This code is taken from the GetProcessDefaultLayout() function from Wine
(called there "WIN_CreateWindowEx").

In Windows the version-resource mirroring happens when the GDI is loading the LPK.

- Implement mirroring via version resource. GDI linking on startup is required.

- GDI32: Add LPK loading on GDI startup.

To enable mirroring via version resource the lpk.dll must be loaded before any windows are created.
This is done through GdiInitializeLanguagePack() function which is called in GdiProcessSetup().

- LPK: Use Wine debug messaging.
 2018-10-24 21:34:38 +02:00
Katayama Hirofumi MZ
375a78e706
[SHIMGVW] Play gif animation (#934) 
Make "Picture and Fax Viewer" able to play GIF animation.
CORE-12680
 2018-10-24 19:51:30 +09:00
Eric Kohl
b5e956e7a8 [SETUPAPI] SetupDiGetClassDevPropertySheetsW: Implement adding property pages from an installer. 
SetupDiGetClassInstallParamsW must be implemented before this will work.
 2018-10-23 23:11:19 +02:00
Giannis Adamopoulos
c69ef281c0 [rosctrls.h] CListView: Add Arrange method 
[SHELL32] CDefView: Start implementing Auto arrange.
So far its effect is only shown when the browser window resizes.
 2018-10-22 23:51:37 +03:00
Giannis Adamopoulos
410cfbfe15 [SHELL32] CDefView: Disable auto arrange in list and details view mode. 
This supersedes PR #927 and does it correctly.
 2018-10-22 19:18:28 +03:00
Giannis Adamopoulos
e9cba5375b [BROWSEUI] CInternetToolbar: Implement hiding and showing the browser toolbars. 2018-10-22 18:42:38 +03:00
Adam Słaboń
7abc8be102 [TRANSLATION] Polish translation update 
Polish translation of net, telnet, diskpart, devcpux, fontext, iernonce, lsasrv, themes, arping, frag, screensavers, ctm, fontsub, WinetestsGUI and localmon.
Update for dxdiag, msgina, msports, netcfgx, shell32 and syssetup.
 2018-10-20 21:26:07 +02:00
Eric Kohl
debb1e521a [NETCFGX] Implement the Min and Max options for int, long and word parameters. 
CORE-15095
 2018-10-14 21:02:45 +02:00
Eric Kohl
731ef01361 [NEWDEV] Add InstallDevInstEx 2018-10-14 18:19:52 +02:00
Mark Jansen
80c53821c9
[SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view. 
CORE-14976
 2018-10-13 20:28:49 +02:00
Eric Kohl
a5172b4699 [NETCFGX] Move the NetClassInstaller to a separate file. 2018-10-13 19:18:37 +02:00
Mark Jansen
1968776bf2
[DBGHELP] Exclude stubs from pch 2018-10-12 19:30:36 +02:00
Mark Jansen
71993fd8c9
[KERNEL32] Fix some stubs for 0x600+ 2018-10-12 19:30:24 +02:00
Eric Kohl
d58f6558e0 [NETCFGX] NetworkPropertySheetProvider: Fix property selection because the property list box is sorted. 
CORE-15095
 2018-10-09 23:19:48 +02:00
Hermès Bélusca-Maïto
8468ad5cf4
[SYSSETUP] Delete the created fonts when needed. 2018-10-08 21:16:58 +02:00
Hermès Bélusca-Maïto
6267898583
[SYSSETUP] Use ARRAYSIZE / _countof instead of sizeof ratios. 
svn path=/branches/setup_improvements/; revision=75523
 2018-10-08 21:16:57 +02:00
Hermès Bélusca-Maïto
e9893906a7
[SYSSETUP] Code formatting. 
svn path=/branches/setup_improvements/; revision=75522
 2018-10-08 21:16:56 +02:00
Eric Kohl
11c9e773fb [NETCFGX] NetPropPageProvider: Add Base and Step parameter options. 2018-10-08 18:55:39 +02:00
Baruch Rutman
87c529a537
[LPK] Small fix and a related comment. (#890) 
[LPK][USER32] Fix reading layout checks.

- Both functions don't care about DT_RTLREADING flag.
- Added a different method to check reading order.

[USER32] Remove gcc-build breaker semicolon.
 2018-10-08 16:17:42 +02:00
Baruch Rutman
a494d0583f
[LPK] Implement LpkPSMTextOut(). (#890) 
- The function is almost fully implemented, but some return values change wildly.
  The results are mostly compatible to the Windows results.

- Remove #ifdef (this is primary ReactOS code).
 2018-10-08 16:16:40 +02:00
Hermès Bélusca-Maïto
2cbac3d049
[SHELL32] Finally fix the icon location path (un)expansion for shell links, and explain why I originally used SHExpandEnvironmentStringsW(). 
CORE-14009 CORE-14982
 2018-10-08 00:50:38 +02:00
Eric Kohl
1e20a3e5b5 [SHELL32] Fix a potential buffer overrun. 
Patch by Kudratov Olimjon.

CORE-8545
 2018-10-07 22:56:16 +02:00
Luo Yufan
b70ef2ee56 [TRANSLATION] Update Simplified Chinese translation. (#912) 2018-10-07 20:44:00 +02:00
Stanislav Motylkov
732a6b0801 [NETCFGX] Update russian translation 2018-10-07 18:28:43 +02:00
Stanislav Motylkov
0934d4f171 [MSPORTS] Update russian translation 2018-10-07 18:28:43 +02:00
Stanislav Motylkov
10b7b94f45 [DEVMGR] Update russian translation 2018-10-07 18:28:43 +02:00
Eric Kohl
45cd6d5e4e [NETCFGX] NetPropPageProvider: Store the parameters in the registry 2018-10-06 23:57:17 +02:00
Eric Kohl
7ad65a3773 [NETCFGX] NetPropPageProvider: Improve the handling of optional parameters 
- Add a pointer to the current parameter.
- Change the 'present' and 'not present' radio buttons to auto radio buttons.
- Display present and non-present optional parameters properly.
 2018-10-06 14:33:48 +02:00
Eric Kohl
c603c54ab0 [MSPORTS] When the LPT port number gets changed, update the PortName and FriendlyName values in the registry. 2018-10-06 11:12:16 +02:00
Eric Kohl
f9739601b3 [DEVMGR] Hackfix CORE-5643 2018-10-05 15:09:27 +02:00
Pierre Schweitzer
f2f24c1fa7
[DEVMGR] Update French translation 2018-10-04 11:13:15 +02:00
Eric Kohl
c444231b87 [MSPORTS] Check and show which parallel port is in use. 2018-10-04 10:21:06 +02:00
Bișoc George
758f9fbdb9 [NEWDEV] Fix a truncated text on device driver name 2018-10-02 21:54:30 +02:00
Eric Kohl
91ba4e7350 [NETCFGX] Network property page: Add support for enum type options, the 'Optional' setting and the 'TextLimit' and 'Uppercase' settings for edit type options. 2018-10-02 17:58:16 +02:00
Eric Kohl
c6142174af [NETCFGX] Network property page: Implement reading of configured settings. Editing and writing is not implemented yet. 2018-10-01 21:16:22 +02:00
Amine Khaldi
0ccdd32f50 [ITSS] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:57:08 +01:00
Amine Khaldi
6bd06f3b76 [INETMIB1] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:56:32 +01:00
Amine Khaldi
33351fe5ad [INETCOMM] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:55:17 +01:00
Amine Khaldi
789fa9c819 [IMM32] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:53:21 +01:00
Amine Khaldi
d4bc0feb6e [IMAADP32.ACM] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:52:44 +01:00
Amine Khaldi
336b2a4564 [IEFRAME] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:52:10 +01:00
Amine Khaldi
a214feb6fe [HHCTRL.OCX] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:51:35 +01:00
Amine Khaldi
8d2e1e843c [GDIPLUS] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:50:25 +01:00
Amine Khaldi
fe0fd16499 [FUSION] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:49:44 +01:00
Amine Khaldi
4fc4698f2a [CRYPTUI] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:49:09 +01:00
Amine Khaldi
997d44c915 [CRYPT32] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:47:51 +01:00
Amine Khaldi
409344041f [CREDUI] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:46:19 +01:00
Amine Khaldi
eaac1cc75f [COMDLG32] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 12:44:53 +01:00
Amine Khaldi
21d3faa2a6 [ATL] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:26:43 +01:00
Amine Khaldi
0df75d9648 [ADVPACK] Sync with Wine Staging 3.17. CORE-15127 2018-10-01 00:25:34 +01:00
Amine Khaldi
82faa151e5 [XDK][PSDK][WINE] Unify ARRAY_SIZE definition for Wine modules. CORE-15127 2018-09-30 23:57:08 +01:00
Hermès Bélusca-Maïto
ccde12483f
[SHELL32] Fixes and improvements for PickIconDlg(). 
- Deal with expanded paths only when loading icons. If the user specifies
  an unexpanded path to a module containing icons, this unexpanded path
  is returned to the caller!

- Perform the dialog cleanup in WM_DESTROY message handler.

- When pressing ENTER/OK in the dialog box, retrieve the selected icon and
  close the dialog *ONLY WHEN* the user actually has selected an icon.
  If the user modified manually the module path, pressing ENTER/OK instead
  reloads the icons list.
 2018-09-30 21:48:34 +02:00
Hermès Bélusca-Maïto
ae9ec94240
[SHELL32] Code formatting only. 2018-09-30 21:48:31 +02:00
Eric Kohl
4aa1bee757 [SYSETUP] Implement the CriticalDeviceCoInstaller 
The CriticalDeviceCoInstaller adds devices of registered classes to the critical device database.
 2018-09-30 17:23:38 +02:00
Eric Kohl
54eb5635d8 [MSPORTS] Implement the 'Enable legacy Plug and Play detection' setting 2018-09-29 18:05:22 +02:00
Eric Kohl
133611fed8 [MSPORTS] Implement the 'Filter Resource Method' setting for parallel ports 2018-09-29 14:58:55 +02:00
Eric Kohl
f155de483f [msports] Notify the system of changes to the serial port settings. 2018-09-29 01:57:59 +02:00
Hermès Bélusca-Maïto
c446ce0d62
[ADVAPI32] Improve a bit CreateProcessAsUser(). 
- Check whether the user-provided token is a primary token.

- Do not fail when the RtlAdjustPrivilege() call fails (see the code
  comment for an explanation). TL;DR is: that call may indeed fail but
  the privilege may also not be necessary because the user-provided
  token is a restricted version of the caller's primary token.
  And this is situation is perfectly fine.

This fixes Java 7 installation, CORE-14874.
 2018-09-28 00:45:04 +02:00
Eric Kohl
3c1e5f7cb9 [NETCFGX] Add the most simple property sheet provider for network adapters 
- Switch to WINE debug code.
- Build the UNICODE version of the DLL by default.
- Add the most simple property sheet provider.
 2018-09-26 23:49:02 +02:00
Eric Kohl
986ce63c4c [SETUPAPI] SetupDiGetClassDevPropertySheetsW: Support class property sheet providers. 2018-09-26 23:49:01 +02:00
Stanislav Motylkov
68c6641781 [MSPORTS] Add russian translation 
Addendum to 69e834f.
 2018-09-25 22:50:02 +02:00
Eric Kohl
af37e0e565 [MSPORTS] Hackfix the code to determine the serial and parallel port numbers. 
Now that SetupDiCreateDevRegKeyW is working as expected, we can no
longer (ab)use it to retrieve a ports resources. Use SetupDiGetDeviceInstanceIdW instead and open the registry keys manually.
 2018-09-25 17:48:27 +02:00
Eric Kohl
69e834fa54 [MSPORTS] Implement serial port settings 
- Fix the control styles and grouping in the dialogs.
- Implement reading, modifying and writing of the serial port settings.
 2018-09-25 14:28:29 +02:00
Eric Kohl
df36ee9fe2 [SETUPAPI] Replace the remaining internal calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKeyW by calls to SETUPDI_OpenDrvKey, SETUPDI_CreateDevKey or SETUPDI_CreateDrvKey. 2018-09-23 20:19:26 +02:00
Hermès Bélusca-Maïto
bf164caae8
[SERVICES] Simplify the implementation of RGetServiceDisplayNameA/W() and RGetServiceKeyNameA/W(). 
Also comment about the observed behaviour of the returned number of "characters"
returned by the ANSI versions of these APIs (which is tested by advapi32_winetest:service).

[ADVAPI32:SCM] Add a comment concerning wide characters vs. bytes mismatch.
 2018-09-23 18:09:10 +02:00
Eric Kohl
60e166535a [SETUPAPI] Do not use SetupDiOpenDevRegKey in other SetupDi functions. Use SETUPDI_OpenDevKey or SETUPDI_OpenDrvKey instead. 
Note: The remaining calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKey will be fixed in another patch.

Fixes CORE-15091
 2018-09-23 16:16:12 +02:00
Hermès Bélusca-Maïto
7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed. 
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
 2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto
e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings() 
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981
 2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto
41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine. 
- Adjust the code with respect to:
  "shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
  4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)

- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
  ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)

- "shell32: Assume that system directory always contains a drive letter."
  54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)

- "shell32: Use ARRAY_SIZE macro."
  612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)

- "shell32: Fix a trace message."
  bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)

- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
  f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)

- "shell32: Pass correct buffer length to RegQueryValueExW()."
  0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)

- "shell32: Remove unused string (Clang)."
  8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)

- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
  730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
 2018-09-23 00:16:02 +02:00
Eric Kohl
de08785ade [SETUPAPI] SetupDiCreateDevRegKeyW / SetupDiOpenDevRegKey: Create or open the 'Device Parameters' subkey of the given devices enum key when we try to access its hardware key. 
This creates the PortName value in the proper location for serial ports.
 2018-09-22 14:43:43 +02:00
Abdulganiev Rafael
2a6aa7770e [BTHCI] Add a bluetooth icon (#871) 
[BTHCI] Add a bluetooth icon
 2018-09-21 23:42:27 +02:00
Eric Kohl
f8f83d4d4d [BTHCI] Add a bluetooth class installer stub. 
Now we really need a tango-compatible bluetooth icon!
 2018-09-20 17:53:08 +02:00
Eric Kohl
5e2fe08918 [WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service. 
The Logoff-Handler might try to notify the scheduler service which might already have been shut down. We need to fix the shutdown sequence, so that the service manager stops all running services.

Might fix CORE-14521.
 2018-09-19 16:35:12 +02:00
Eric Kohl
76588be0d1 [ADVAPI32][SERVICES] Use the session key provided by SystemFunction028 to encrypt and decrypt the service passwords. 2018-09-19 12:30:33 +02:00
Eric Kohl
4114dcad46 [ADVAPI32] Implement SystemFunction028 to always return the default session key. 2018-09-19 00:20:11 +02:00
Eric Kohl
e5fcda922b [ADVAPI32][SERVICES] Pass encrypted passwords to the service manager. 
- Encrypt passwords before passing them to the service manager. Right now, we are using a fixed encryption key. This will be fixed later.
- Replace the calls to ZeroMemory which are used to wipe the password buffers by calls to SecureZeroMemory.
 2018-09-18 21:33:29 +02:00
Eric Kohl
da73c81259 [IDL][LSASRV] Improve the credentials interface a little and update the lsa server code accordingly. 2018-09-18 15:55:18 +02:00
Eric Kohl
6c0d9c01e2 [ADVAPI32] SystemFunction004 and SystemFunction005 must return the required output buffer size via out->Length when the buffer is too small. 2018-09-17 23:19:02 +02:00
Eric Kohl
5e2c4657ca [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager 2018-09-17 16:34:48 +02:00
Eric Kohl
47714b25a9 [NETAPI32] Add more DFS stubs 2018-09-16 21:11:16 +02:00
Pierre Schweitzer
8c5b0fbff3
[KERNEL32_VISTA] Make SleepConditionVariableSRW fail when it times out 
This fixes a few newly added winetests.
 2018-09-16 14:50:01 +02:00
Pierre Schweitzer
58853297dc
[KERNEL32_VISTA] Make SleepConditionVariableCS fail when it times out 
This fixes a few newly added winetests.
 2018-09-16 14:42:43 +02:00
Mark Jansen
12654d2852
[KERNEL32] Ensure the PebLock is always released in FlsFree 2018-09-15 17:56:03 +02:00
Mark Jansen
06eb99edef
[NTDLL][KERNEL32] Implement FLS callbacks. 2018-09-15 17:56:03 +02:00
Pierre Schweitzer
f4da2bab03
[MPR] Import Wine commit: 93fb279f4f3e150eee329b02ca5fb0251d8a239d 
Properly handle device-less connections.

CORE-15012
 2018-09-14 22:34:02 +02:00
Katayama Hirofumi MZ
31019e8c0c [TRANSLATION] Update Romanian translation (#851) 
Translation from Stefan Fulea.
CORE-15023
 2018-09-14 11:04:36 +02:00
Pierre Schweitzer
62f79fae93
[MPR] Import Wine commit: 0799550075654094a3bed080aac722b9bea01307 
Implement WNetClearConnections().

CORE-15012
 2018-09-14 08:08:57 +02:00
Mark Jansen
8642654a00
[KERNEL32] Do not embed binary data inside a string resource. 
CORE-14948
 2018-09-12 21:31:55 +02:00
Mark Jansen
25d143dd20
[DBGHELP] Prevent crashing on a malformed PE file. 
CORE-15030
 2018-09-12 21:30:49 +02:00
Eric Kohl
ee4ee2fc1d [NETAPI32] Remove the obsolete file group.c 2018-09-12 17:53:49 +02:00
Eric Kohl
221cdeafe2 [NETAPI32] Rename ENUM_CONTEXT to GROUP_ENUM_CONEXT and fix a use of the wrong type 2018-09-12 17:38:18 +02:00
Eric Kohl
4d9425d123 [NETAPI32] Implement NetGroupSetUsers 2018-09-12 17:11:52 +02:00
Eric Kohl
e0b5050089 [NETAPI32] Implement NetLogonGetTimeServiceParentDomain 2018-09-11 15:02:19 +02:00
Pierre Schweitzer
cf0112a6e6
[MPR] Implement WNetClearConnections() 
This has been submitted upstream.

CORE-15012
 2018-09-11 08:30:23 +02:00
Eric Kohl
74620c94d3 [NETAPI32] Implement NetGroupGetUsers 2018-09-10 22:05:49 +02:00
Baruch Rutman
ab5fdcc01f
[LPK] Make GetCharacterPlacement caret positions respect bidi. (#842) 
- Try to make use of ScriptStringCPtoX when trying to fill the lpCaretPos struct member;
  if USP10 error happens fallback to the unreorder method.
- Remove now incorrect debug print.
 2018-09-09 18:03:45 +02:00
Katayama Hirofumi MZ
a244e4f6dd [WIN32SS][COMCTL32] Fix button text Y positioning (#766) 
Fixes the vertical position of button text.
CORE-14906
 2018-09-09 17:37:37 +02:00
Eric Kohl
2d645f62fe [NETAPI32] Implement NetGroupAddUser and NetGroupDelUser 2018-09-09 17:35:18 +02:00
Eric Kohl
df0137a169 [NETAPI32] Implement NetGroupSetInfo 2018-09-09 13:39:01 +02:00
Eric Kohl
c48d09d19a [NETAPI32] Implement NetGroupAdd and NetGroupDel 2018-09-09 11:52:44 +02:00
Eric Kohl
a9da3c50be [NETAPI] Implement NetGroupGetInfo 2018-09-09 09:40:11 +02:00
Eric Kohl
033146ca23 [NETAPI] Implement NetGroupEnum 2018-09-08 20:55:13 +02:00
Eric Kohl
0e69bc3bce [SAMSRV] Fix SamrQueryInformationGroup 
- Use the registry value AdminComment for admin comments instead of Description. Fix SamrSetInformationGroup as well.
- Add some TRACEs.
- Do not fail if the Members value does not exist.
 2018-09-08 19:24:13 +02:00
Eric Kohl
df053b7d16 [MSV1_0] LsaApLogonUser: Update the logon time/count and bad password time/count 2018-09-05 00:10:54 +02:00
Eric Kohl
97382dee46 [MSV1_0] Use the account expiration time and check account expiration on logon 2018-09-04 23:15:15 +02:00
Eric Kohl
e25cbeba2f [IDL] Implement parts of SamrSetInformationUser.UserInternal2Information 2018-09-04 22:42:49 +02:00
Eric Kohl
653a9be05b [SAMSRV] Implement SamrQueryInformationUser.UserInternal2Information 2018-09-02 17:54:26 +02:00
Stanislav Motylkov
c7415b3faa [MSGINA] Update russian translation (#834) 
Addendum to 6f4d70b.
 2018-09-02 15:59:33 +02:00
Eric Kohl
6f4d70b405 [MSGINA] Display the 'account expired' message when a user tries to log on using an expired account. 2018-09-01 21:10:42 +02:00
Denis Malikov
69a040d275 [KERNEL32] fix spec file for -version=0x600+ 
CORE-12596
 2018-09-01 17:21:21 +02:00
Pierre Schweitzer
2bd33d58d8
[KERNEL32] Shhhh! 2018-09-01 15:46:44 +02:00
Joachim Henze
e217e926e1 [SHELL32] Fix typo in comment 2018-08-28 14:24:49 +02:00
Mark Jansen
ffae49deaf
[COMCTL32] Unregister some classes that were registered. 
This should help fix some crashes.
 2018-08-27 19:49:57 +02:00
Katayama Hirofumi MZ
39dc3cdaf6 [SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824) 
CORE-14974
 2018-08-27 12:21:51 +02:00
Mark Jansen
19e9a44118
[SHELL32] Check the result from PathUnExpandEnvStringsW 2018-08-27 11:58:29 +02:00
Mark Jansen
608cb60e44
[SHELL32] Remove some mostly dead code from CShellLink 2018-08-27 11:58:24 +02:00
Eric Kohl
fc2b4bc7ea [LSASRV] LsapLogonUser creates an impersonation token for a network logon 2018-08-27 00:19:10 +02:00
Eric Kohl
a7b52d6a44 [SAMSRV] Simplify the initialization of the account expiration time 2018-08-27 00:12:44 +02:00
Eric Kohl
2fafcff3ef [SAMLIB] Add stubs for SamTestPrivateFunctionsDomain and SamTestPrivateFunctionsUser 2018-08-27 00:11:21 +02:00
Eric Kohl
a9f2677782 [SAMSRV] Simplify the initialization of the account expiration date for new user accounts 2018-08-26 21:26:31 +02:00
Eric Kohl
dcc188e974 [NETAPI32] Add code to handle special values of the last logon time, last logoff time and account expiration time 2018-08-26 21:07:05 +02:00
Katayama Hirofumi MZ
6eb6aa2895 [SHELL32] Fix CShellLink::GetIconLocation (#810) 
Fixes a regression from PR #784.
CORE-14961, CORE-14009
 2018-08-26 15:37:15 +02:00
Baruch Rutman
e7d2bbe726 [WIN32SS][LPK] Add BiDi support to menus and window captions (#738) 
Added callback function that redirects calls to GreExtTextOutW that didn't went through lpk BiDi processing, calls that are from the kernel.

Completely solves JIRA issue CORE-6910.
 2018-08-23 19:43:12 +02:00
Serge Gautherie
990e7dfd1a [MSHTML] Fix 3 MSVC warnings about HTML*Element_handle_event() 
- "...\htmlanchor.c(769) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlarea.c(427) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlform.c(757) : warning C4028: formal parameter 2 different from declaration"

Cherry-pick Jacek Caban a660f673cb
CORE-7538
 2018-08-21 14:33:52 +02:00
Katayama Hirofumi MZ
73798d2e71 [SHELL32] Enable to change shortcut icon (#784) 
CORE-11407
 2018-08-21 13:49:32 +02:00
Robert Naumann
b3cfe88eda [BROWSEUI] Show Tooltip text for 'Go' Button 
-Patch by Barret Karish CORE-11058
 2018-08-21 12:49:04 +02:00
Timo Kreuzer
36051d3065 [SYSSETUP] Fix handling of the status message window 
This fixes a race condition, where the message thread was still running when InstallReactOS returned and syssetup.dll was unloaded by the caller (setup.exe).
 2018-08-20 22:10:04 +02:00
Serge Gautherie
2e7b73dc75 [MSHTML] Fix an MSVC warning about HTMLInputElementImpl_fire_event() 
"...\htmlinput.c(1303) : warning C4028: formal parameter 2 different from declaration"

Temporary fix, until WINESYNC replaces this function.
CORE-7538
 2018-08-20 19:06:00 +02:00
Adam Słaboń
af3d426685 [TRANSLATION] Polish translation update (#781) 
In addition: fix the encoding of the comdlg32 and ntvdm polish resource files.
 2018-08-20 17:00:33 +02:00
Eric Kohl
91fab9e53b [SETUPAPI] SetupDiGetDeviceRegistryPropertyW call CM_Get_DevNode_Registry_Property_ExW for properties that can not be retrieved from the registry 2018-08-20 00:16:18 +02:00
Stanislav Motylkov
844483504b [KERNEL32] Implement system firmware functions properly 2018-08-19 20:27:59 +02:00
EUPHORIA-IT\m.jansen
bb5f8cfccb [WSHOM.OCX] Zero-initialize timeout and type if they are not set. 
This should fix buildbot timeouts
 2018-08-19 16:14:08 +02:00
Eric Kohl
a8cf35d0e4 [SYSSETUP] SetupStartService: Remove the wait loop 
CORE-14909
 2018-08-19 14:32:29 +02:00
Eric Kohl
9a36ee8359 [WLNOTIFY] Use the wine debug method, add wlnotify to the build and fix some typos 2018-08-18 22:20:17 +02:00
Mark Jansen
cf56e1cb58 [GDIPLUS] Add sxs registration for 1.0 version. 
Needed by by some applications with MSVCR90.dll
CORE-14695
 2018-08-18 18:25:13 +02:00
Eric Kohl
df849213a2 [WLNOTIFY] Add SCard, Termsrv and Wlballon notifications and remove the test notifications 2018-08-18 16:18:36 +02:00
Timo Kreuzer
094a90ad4e [NTOS:PS] Fix an issue with PROCESS_DEVICEMAP_INFORMATION size on 64 bit builds 
The PROCESS_DEVICEMAP_INFORMATION  union has 2 fields, one is a handle, the other one is a structure of 36 bytes (independent of architecture). The handle forces 64 bit alignment on 64 bit builds, making the structure 4 bytes bigger than on 32 bit builds. The site is checked in NtQueryInformationProcess (case ProcessDeviceMap). The expected size on x64 is the size of the Query structure without alignment. autocheck correctly passes the site of the Query union member, while smss passes the full size of PROCESS_DEVICEMAP_INFORMATION. Packing the structure is not an option, since it is defined in public headers without packing. Using the original headers sizeof(PROCESS_DEVICEMAP_INFORMATION) is 0x28, sizeof(PROCESS_DEVICEMAP_INFORMATION::Query) is 0x24.
 2018-08-17 22:08:37 +02:00
Joachim Henze
abf9340f1b [SHELL32] Translation de-DE CORE-14916 
fix control overlapping in IDD_FOLDER_OPTIONS_FILETYPES
(broke in 0.4.10-dev-24-ed1c6bb0060d06f4c0167d9c2d732f4dc2b4cce4)

and translate IDD_NEWEXTENSION, IDD_EDITTYPE, IDD_ACTION, IDD_FOLDER_CUSTOMIZE
 2018-08-17 18:07:35 +02:00
Serge Gautherie
2ad650469e [OLEAUT32] Fix an MSVC warning about VarCyMul() 
"...\vartype.c(3808) : warning C4028: formal parameter 2 different from declaration"

Mininal cherry-pick Alexandre Julliard 18f7ec3670
CORE-7538
 2018-08-17 16:18:41 +02:00
Getequ
d559ca9c98 [ADVAPI32][SHELL32][DESK.CPL] Kill copy-paste of RegLoadMUIString. (#748) 
RegLoadMUIStringW/A is part of advapi32.dll . shell32.dll and desk.cpl contained exact line-by-line copy of that function.
 2018-08-16 16:10:41 +02:00
Katayama Hirofumi MZ
6d9f89f813 [SYSSETUP] Fix the button sizes of theme selection dialog (#746) 
CORE-14896
 2018-08-15 18:32:17 +02:00
Mike Swanson
3c7e9bb332 Remove unnecessary executable bits 2018-08-15 18:29:09 +02:00
Mark Jansen
9b6fb9f2f8
[RTL][KERNEL32] Add a comment indicating we need SEH in RtlImageNtHeaderEx 
CORE-14532
CORE-14857
 2018-08-13 13:24:12 +02:00
Eric Kohl
956086d369 [NETAPI32] Add DFS RPC interface and some DFS stubs 2018-08-12 14:31:07 +02:00
Katayama Hirofumi MZ
db13b422b3 [SHELL32] Fix a careless mistake of ShellExecCmdLine (#737) 
CORE-14886
 2018-08-10 13:25:50 +02:00
Eric Kohl
fb5d5ecd64 [WLNOTIFY] Add sens service stubs 2018-08-07 22:56:33 +02:00
Hermès Bélusca-Maïto
40000a1716
[WINLOGON][MSGINA] Fix typo. 2018-08-06 17:37:38 +02:00
Eric Kohl
8f911f21b8 [SYSSETUP] SetupStartService: Wait until the service is running 2018-08-05 20:02:22 +02:00
Eric Kohl
5ebcc6cdc1 [ADVAPI32] Add parameter checks to LogonUserExW and initialize the token handle. 2018-08-05 16:16:53 +02:00
Eric Kohl
b4040ea740 [NETAPI32] Implement I_NetServerSetServiceBits() 2018-08-05 15:57:03 +02:00
Eric Kohl
89f6e701d4 [NETAPI32] Add annotations and move NetUseGetInfo to a better location. 2018-08-05 15:36:48 +02:00
Katayama Hirofumi MZ
bfcbda227f [SHELL32] Fix handling of multiple parameters in the 'Run' dialog (#665) 
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.

- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.

CORE-14790
 2018-08-05 13:39:17 +02:00
Eric Kohl
4e32ad3623 [LSASRV] Implement and call the policy change notification routine 2018-08-05 01:05:52 +02:00
Eric Kohl
620217cec9 [LSASRV][SECUR32] Implement LsaRegisterPolicyChangeNotification and LsaUnregisterPolicyChangeNotification 2018-08-04 22:17:52 +02:00
Timo Kreuzer
0f8439aa71 [DLLS] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Timo Kreuzer
52ea7d39db [SHELL32] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Timo Kreuzer
4f0a158a2f [KERNEL32] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Julio Carchi
d7559e2354 [TRANSLATIONS] Fix spanish translations for some resources (#725) 
Setup wizard
Network settings wizard
Input CPL
Open file dialogs
Devmgr
Explorer
 2018-08-03 15:08:13 +02:00
Stanislav Motylkov
d956eafda8
[KERNEL32] Implement System Firmware functions 
- Implement EnumSystemFirmwareTables
- Implement GetSystemFirmwareTable

These functions currently using registry workaround and can be improved later.

CORE-12105
 2018-08-02 21:15:28 +02:00
Julio Carchi
d3045af9d5 [TRANSLATIONS] Fix some Spanish translations (#715) 
Also added some new ones.
 2018-07-31 10:58:21 +02:00
Eric Kohl
bf1e655172 [ADVAPI32] Stop the service dispatcher thread only if a SERVICE_CONTROL_STOP command was sent 2018-07-29 23:40:36 +02:00
Hermès Bélusca-Maïto
74adcadbd0
[SHELL32] Silence a noisy DPRINT. 2018-07-29 17:39:09 +02:00
Eric Kohl
24cd7bbe0b [RPCRT4] Update the support for remote pipes which was dropped by the sync to Wine Staging 2.9 and update rpcrt4_ros.diff accordingly 2018-07-29 07:30:43 +02:00