Commit graph

351 commits

Author SHA1 Message Date
Ioannis Adamopoulos 0d077c3068 [SHELL32] CDesktopFolder::GetUIObjectOf: fix crash when requested to create a IID_IContextMenu for 0 items.
* Tests show that we should return a valid object even in this case.
2020-04-20 17:37:03 +03:00
Mark Jansen d2b91deb33 [SHELL32] CMyDocsFolder: Ensure the object can be used without calling Initialize 2020-04-20 17:36:44 +03:00
Mark Jansen 6a6a28b634 [SHELL32] Ensure CIDLDataObject::GetData always returns an STGMEDIUM that is safe for use with ReleaseStgMedium 2020-04-20 17:36:43 +03:00
Joachim Henze 4af7888b29 [SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs
-Avoid text truncations regarding the checkbox
 in a uniform way
-Reduce chance of text truncations for a button
 in a uniform way
-Fix es-ES dlg layout and harmonize its dlg Size
 with other languages
-de-DE fix double accelerator
2020-04-20 02:08:45 +02:00
Joachim Henze c0d5e4fd6b [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs
-Some inspiration from de-DE which I improved years ago
-Avoid text truncations and control overlapping that
 happened in almost all other languages
-Increase the size of the listView for all except es-ES & pt-PT
-es-ES & pt-PT had different dlgs sizes, I only slightly tweaked
 those therefore
-In sum this brings the RCs much closer to each other

-Unrelated: fix a white-space-typo we had in some but not all RCs
2020-04-19 21:33:13 +02:00
Charles Ambrye 1bee97358e [SHELL32] Pass LVA_SNAPTOGRID to listview when 'Line up Icons' is selected 2020-04-17 13:23:29 +03:00
Stanislav Motylkov edc66fdc22
[SHELL32] Update Russian translation
CORE-16873
2020-04-16 13:40:49 +03:00
Piotr Hetnarowicz abd6954d6a
[SHELL32] Update Polish translation (#2364) 2020-04-16 13:24:17 +03:00
Stanislav Motylkov ea298746db
[SHELL32][BROWSEUI] Update Russian translation
Addendum to 033f0d9. CORE-16866
2020-04-16 00:10:12 +03:00
Joachim Henze 2032c3afba [SHELL32] CORE-12294 File & folder properties dialog fr-FR & de-DE resource
Avoids text truncation for french
Improves checkboxes alignment for german
2020-04-15 14:45:48 +02:00
Julen Urizar Compains d7a632a094
[TRANSLATION] Spanish minor fixes (#2547)
Translations for:
- Applications: clipbrd, dxdiag, rapps,
- cmdutils: attrib, find, help, label, reg, xcopy
- usetup
- dlls: browseui, shell32, syssetup

- Add Spanish translation for Accesibility Utility (utilman).

Update for the "Choose product options" strings in syssetup:

Originally "ProductType" and "ProductSuite" (typesetted without spaces) were the registry value names where these settings would go, but since it's meaningless to show these values it's better instead to use human-readable names with correct translation and spacing.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-15 13:27:36 +02:00
Stanislav Motylkov 033f0d998a [SHELL32] Add Russian translation (#2548)
CORE-16866
2020-04-15 12:38:27 +02:00
Eric Kohl 69e565891d [SHELL32] No french translation from "right click drag'n'drop"
CORE-16815
2020-04-13 15:41:13 +02:00
Eric Kohl c037278c5f [SHELL32] Fix missing french translation for "Command prompt here"
CORE-16855
2020-04-13 15:27:47 +02:00
Katayama Hirofumi MZ 5af2570b37 [SHELL32] Follow-up No.3 of #2539
Improve a comment in CreateNotificationParamAndSend.
CORE-13950
2020-04-13 13:19:12 +09:00
Katayama Hirofumi MZ b76d053a30 [SHELL32] Follow-up No.2 of #2539
Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950
2020-04-13 13:06:15 +09:00
Katayama Hirofumi MZ bfe36e4f0d [SHELL32] Follow-up of #2539
Improve comment. CORE-13950
2020-04-13 10:41:26 +09:00
Katayama Hirofumi MZ 2727245c86
[SHELL32] Shell notify rework for simplicity and readability (#2539)
Shell change notification has been implemented in #2432. But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950
2020-04-13 10:36:24 +09:00
Katayama Hirofumi MZ ddc1a46456 [SHELL32] Improve CChangeNotify::ShouldNotify more
Improved non-recursive cases.
CORE-13950
2020-04-11 11:55:06 +09:00
Katayama Hirofumi MZ 2a32094aa0 [SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify
CORE-13950
2020-04-11 09:27:45 +09:00
Katayama Hirofumi MZ 2a6bccb4ce [SHELL32] Make "Unable to get notification window" quiet
CORE-13950
2020-04-11 08:45:23 +09:00
Katayama Hirofumi MZ 60959e34aa [SHELL32] Simplify CChangeNotify::ShouldNotify
CORE-13950
2020-04-10 21:57:58 +09:00
Katayama Hirofumi MZ 59c48a5d33 [SHELL32] Improve CChangeNotify::ShouldNotify
Shell change notification was not sent to My Documents.
CORE-13950
2020-04-10 21:51:22 +09:00
Serge Gautherie 745cb1cbda
[SHELL32] Fix SHCNE_UPDATEITEM number of items (#2409)
Import
83acbb79c1

Related to CORE-13950
2020-04-09 19:42:00 +02:00
Joachim Henze bf342653df [SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file) 2020-04-09 18:17:06 +02:00
Katayama Hirofumi MZ 1c706d7483
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save (#2515)
- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391
2020-04-09 16:56:54 +09:00
Katayama Hirofumi MZ 0903c645a2 [SHELL32] Follow-up of #2432
Fixed hang of FireFox.
2020-04-09 08:19:47 +09:00
Katayama Hirofumi MZ 296192685b
[SHELL32] Implement shell change notification (#2432)
- Rewrite SHChangeNotify, SHChangeNotifyRegister, SHChangeNotify_Lock, SHChangeNotify_Unlock and SHChangeNotifyDeregister functions.
- Fix SHSimpleIDListFromPathA/W functions.
CORE-13950
2020-04-09 07:30:14 +09:00
Julen Urizar Compains d6e0fe78e7
[TRANSLATION] Updating Spanish translation (#2503)
Updating translation for:
notepad, reactos, usetup, explorer, netshell, msgina, setupapi, shell32.

- Complete and Fix the SPANISH TRANSLATION on Setup
- Correct the random names, fixing the denominations, translate of the English words, and fixing random and incorrect denominations like "Cabinet" or "distribuciones".
- Fixed the notepad shortcuts of "Save" (Ctrl+g) and "Replace".
2020-04-06 13:17:20 +02:00
Serge Gautherie 07efa2ef53
[SHELL32] HCR_GetIconA(): Properly use icon_idx (#2482)
CORE-11713

Import
7cc2806e0e
2020-03-30 12:24:59 +02:00
jimtabor 10d1afea18 [Explorer|Shell32]
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
2020-03-21 19:13:55 -05:00
Robert Naumann fc4c4d4911
Sync brsfolder.c with keyboard shortcut code from wine (#2290)
* [SHELL32] Add shortcut to rename folders with the F2 key.

Sync Wine Commit 2e25a43f3fb6230460447bae6fb5db2edbd4a42f by Fabian Maurer

* [SHELL32] Add shortcut to delete folders with the delete key.

Sync Wine Commit 43f44ffb3779ff23c863d9b3297f92720e7e3733 by Fabian Maurer

* Disable the code for file deletion. The Wine way doesn't work on ROS. Add an explaining comment why we can't use the Wine code, as requested by Amine
2020-03-18 21:57:10 +01:00
Serge Gautherie 92aabb07fb
[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)
Addendum to commit 554c41e4 (#2387).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:08:25 +01:00
Katayama Hirofumi MZ fc11cf78ca
[SHELL32] Improve ShellExecCmdLine in path resolving (#2397)
Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409
2020-03-01 19:32:33 +09:00
Katayama Hirofumi MZ 4df9355d0c
[SHELL32][BOOTDATA] Unselect filename extension upon renaming (#2398)
You can disable unselecting by setting TRUE to SelectExtOnRename value of HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer. CORE-15242
2020-02-29 08:08:26 +09:00
Katayama Hirofumi MZ 3c5b10f4e6
[SHELL32] Fix SHChangeNotify for one item events (#2386)
Windows sends notification even if two parameters are provided for notification of one parameter. CORE-13950
2020-02-26 10:59:28 +09:00
Katayama Hirofumi MZ 1e60116563
[SYSDM][MSGINA][NETID][SHELL32] Japanese translation (retrial) (#2369)
Improve Japanese resources. This PR is based on @Midi730's work (#2361).
2020-02-25 10:27:49 +09:00
Katayama Hirofumi MZ 0a626dedf8
[SHELL32] Set read-only for some shell folders and delete Desktop.ini of Desktop and Program Files (#2385)
Set read-only attribute instead of system attribute for some shell folders that has a folder icon.
Delete desktop.ini files in Desktop and Program Files. CORE-16711
2020-02-25 10:07:58 +09:00
Doug Lyons 4e721f780e
[SHELL32] Fix unneeded error Popup with Git for Windows. (#1854)
* Fix unnecessary error popup when installing Git for Windows.
* Add reasons for return value of 42.
2020-02-23 17:47:48 +01:00
Oleg Dubinskiy 7075bdacb2
[SHELL32] Don't hardcode My Documents path for My Music/Pictures/Videos folders in some translations (#2354)
Don't hardcode My Documents path in some translations of My Music, My Pictures and My Videos folders in Shell32. It fixes incorrect location of that folders when install ReactOS as Workstation.
Currently they are located in one more My Documents subfolder, which is, in its turn, in the correct My Documents directory. After this fix, they are directly in the 2nd one, as they should be.

CORE-16698
2020-02-15 20:06:16 +01:00
Bișoc George 6ce72ba172
[SHELL32] Better fix for the "Version" string in the About-dialog (#2349)
The version string kernel number and the localized "version" word were too near in translation files. The patch fixes the problem introduced by #2276.
Addendum to commit a57f7b50.
2020-02-14 22:17:48 +01:00
Katayama Hirofumi MZ 358f947975
[SHELL32] Rewrite SHAddToRecentDocs (#2333)
Rewrite shell32!SHAddToRecentDocs and use it in some applications.
Wine's SHAddToRecentDocs was not Unicode supported and unusable. I will dare to rewrite.
CORE-3588
2020-02-14 11:05:21 +09:00
Katayama Hirofumi MZ 9fc87dacdb [SDK][INCLUDE] Fix and improve comctl32_undoc.h 2020-02-13 09:16:59 +09:00
Katayama Hirofumi MZ 1cf564c25f [SHELL32] Use background context if no item selected on File menu
CORE-9467
2020-02-12 12:14:15 +09:00
Katayama Hirofumi MZ bc1519dd87
Shell Folders: Reject invalid characters (#2328)
Reject invalid input filename characters by using shell32!SHLimitInputEdit function and IItemNameLimits interface. Improve SHLimitInputEdit to sanitize paste.
CORE-11701
2020-02-12 09:18:24 +09:00
Serge Gautherie 9f4e8ef25b
[SHELL32] DoGetProductType(): Check RegQueryValueExW() dwType (#2331) 2020-02-11 17:36:12 +01:00
Katayama Hirofumi MZ ea8a6d6fb7 [SHELL32] Fix and improve SHLimitInputEdit
Use CallWindowProcW to call the subclass window procedure.
Use Wide functions explicitly.
CORE-11701
2020-02-11 14:10:38 +09:00
Katayama Hirofumi MZ 9e53e7cd5b [SHELL32] DoGetProductType should check "LanmanNT" value.
CORE-13795
2020-02-11 13:11:58 +09:00
Katayama Hirofumi MZ c6ed215eef [SHELL32] Initial implement SHLimitInputEdit (#2323)
Popup balloon window is not implemented yet.
CORE-11701
2020-02-10 15:57:30 +09:00
Katayama Hirofumi MZ 48160c74b7
[SHELL32][SYSSETUP] Add Product Options page to ReactOS Setup (#2315)
- Add "Product Options" wizard page into ReactOS Setup.
- Implement CSIDL_Type_InMyDocuments CSIDL type.
- If the product type is workstation, then some special folders will be in My Documents.
CORE-13795
2020-02-10 11:10:42 +09:00