Commit graph

1728 commits

Author SHA1 Message Date
Timo Kreuzer 3120320c65 [FRAMEDYN] Fix broken asm (.code64 is for x64 only) 2019-07-20 13:56:18 +02:00
Timo Kreuzer 1b70ddd834 [KERNEL32] Improve path name handling
Fixes GCC 8 warning:
dll/win32/kernel32/client/loader.c: In function 'LoadLibraryA':
dll/win32/kernel32/client/loader.c:129:17: error: 'strncat' specified bound 13 equals source length [-Werror=stringop-overflow=]
                 strncat(PathBuffer, "\\twain_32.dll", 13);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer 2800837dc0 [MSGINA] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/msgina/lsa.c:195:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "User32  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer f3a9b524f1 [ADVAPI32] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "Advapi  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Jose Carlos Jesus 69454b4302 [TRANSLATION] Add Portuguese (neutral) translation. (#1702)
Add Portuguese (neutral) translation for intl.cpl, main.cpl, msgina.dll, msports.dll, welcome.exe and rundll32.exe, and fix the one in mshtml.dll .
2019-07-15 00:07:50 +02:00
Eric Kohl 433c9d327e [SETUPAPI] Implement CM_Delete_DevNode_Key_Ex()
CM_REGISTRY_USER is not supported yet.
2019-07-13 14:26:57 +02:00
Mark Jansen b5423ba70b
[SHELL32] Fix SHCreateDirectoryExW showing an error on success
CORE-15145
2019-07-09 22:52:17 +02:00
Eric Kohl 93f77f2625 [SETUPAPI] CM_Delete_DevNode_Key[_Ex]: Use DEVINST instead of DEVNODE because we are using DEVINST anywhere else. 2019-07-08 00:08:22 +02:00
Eric Kohl 86e8a477b6 [SETUPAPI] CMP_RegisterNotification: When a window is registered, pass the window text to PNP_RegisterNotification(). 2019-07-07 23:47:01 +02:00
Bișoc George 019e3ffe5f
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. (#1688)
CORE-12313

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-07-07 19:01:09 +02:00
Hermès Bélusca-Maïto 8a30801516
[SHELL32] Recycle-Bin: Minor code enhancements.
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
2019-07-07 17:56:51 +02:00
Bișoc George 818d660868 [SHELL32] Enable the "Apply" button when user takes action on the edit box control (#1720)
CORE-12312
2019-07-07 14:47:44 +02:00
Eric Kohl ece54dcd2f [SETUPAPI][UMPNPMGR] The 3rd parameter of PNP_RegisterNotification() seems to be the service name 2019-07-07 13:41:00 +02:00
Doug Lyons 119c99ef7e
[TIMEDATE] Allow editing the time server combo box. CORE-13001 2019-07-07 12:45:45 +02:00
Doug Lyons 44b543bad3
[TIMEDATE] Handle manual time server entry. CORE-13001 2019-07-07 12:45:36 +02:00
Doug Lyons 33401f3875
[TIMEDATE] Use w32time compatible registry settings. CORE-13001 2019-07-07 12:45:17 +02:00
Thomas Faber d19b792511
[W32TIME] Implement a rudimentary version of W32TimeSyncNow. CORE-13001 2019-07-07 12:45:03 +02:00
Thomas Faber 1938b7484e
[TIMEDATE] Avoid the use of DisplayWin32Error in time sync utility functions. CORE-13001 2019-07-07 12:44:51 +02:00
Thomas Faber aa24ad7429
[TIMEDATE] Separate time sync functions out into their own file. CORE-13001
This is in preparation for the w32time service, and based on
work by Doug Lyons.
2019-07-07 12:44:37 +02:00
Victor Perevertkin 042646ceac [IPHLPAPI] Use if_descrlen field for determining the length of
if_descr in IFEntry structure. This fixes heap corruption on GCC8.
CORE-16088
2019-07-05 22:49:12 +03:00
Stanislav Motylkov a76e03d8bc [SHELL32][USERENV] Improve Russian translation (#1710)
CORE-16170
2019-07-01 21:43:22 +02:00
Oleg Dubinskiy 25e98eb0da [DSOUND_NEW] Add CMakeLists.txt + mostly fix gcc compilation 2019-06-30 20:06:36 +02:00
Jose Carlos Jesus 86d4156c39
[TRANSLATIONS] Add/Update Portuguese (neutral) translations. (#1687)
Translations for SYSDM.CPL, SETUPAPI, SHELL32, LSASRV, SAMSRV, SYSSETUP,
USRMGR, THEMEUI, USERENV, WININET, MSCONFIG.
2019-06-29 16:55:33 +02:00
Eric Kohl 7eb6e42626 [UMPNPMGR][SETUPAPI] PNP_RegisterNotification() has got 9 parameters. 2019-06-29 13:38:42 +02:00
Thomas Faber d16c9a798a
[LIBPNG] Update to version 1.6.37. CORE-16147 2019-06-27 12:52:12 +02:00
Thomas Faber 430656f0b9
[MBEDTLS] Update to version 2.7.11. CORE-16147 2019-06-27 12:52:00 +02:00
Eric Kohl a9c4c07955 [SETUPAPI][UMPNPMGR] PNP_UnregisterNotification: Add 2 unknown parameters 2019-06-23 21:45:54 +02:00
Eric Kohl ca0406131c [SETUPAPI][UMPNPMGR] Improve CMP_RegisterNotification/PNP_RegisterNotification
Pass the notification filter to PNP_RegisterNotification as a byte-pointer to the filter and the size of the filter.
2019-06-23 19:31:34 +02:00
Eric Kohl 89c936fdd6 [NETCFGX] Start a network adapter device after the custom install steps have been completed.
This could probably fix CORE-16103
2019-06-22 21:01:26 +02:00
Eric Kohl 8dc70d2454 [SETUPAPI] Implement SetupDiRestartDevices() 2019-06-22 21:01:25 +02:00
Andreas Maier 49165276f2 [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) (#1674)
* [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression)

Fix cb_states / rb_states lookup table.

* [README.WINE] comctl32 is synced to WineStaging-3.3.

See commit b3fb8555 .
2019-06-22 16:36:14 +02:00
Jose Carlos Jesus be820b9ca3
[NEWDEV] Add Portuguese (neutral) translation. 2019-06-22 16:17:03 +02:00
Jose Carlos Jesus 0e6732586d
[NETID] Add Portuguese (neutral) translation. 2019-06-22 16:16:58 +02:00
Jose Carlos Jesus 64a647a843
[NETCFGX] Add Portuguese (neutral) translation. 2019-06-22 16:11:55 +02:00
Bișoc George 4c9dc7302b [MAIN.CPL] Adjust the GROUPBOX control spacing for French resource (#1682)
CORE-12372
2019-06-22 15:37:59 +02:00
Eric Kohl 214692ff5e [NETSHELL] Improvements to the network setup (2a/x)
Step 2a: Really check the binding between network components.

Next Step: Bind the Tcpip transport to all enumerated network adapters.
2019-06-20 22:08:39 +02:00
Eric Kohl 73ca084e96 [NETCFGX] Read a components bind value and implement the IsBoundTo method. 2019-06-20 22:08:38 +02:00
Eric Kohl 79a0f2b430 [NETCFGX] EnumClientServiceProtocol: Use the right parent key when trying to open the 'NDI' subkey.
This makes the description of the selected item show up in the network connection properties.
2019-06-20 20:08:36 +02:00
Hermès Bélusca-Maïto 1dc4ba9da7
[DEVMGR] Add the missing pt-PT.rc translation file. Strange, I thought I added it before... 2019-06-20 18:04:26 +02:00
Mas Ahmad Muhammad fd928f9d6e
[CPL_DESK] Update Indonesian translation. 2019-06-20 17:31:57 +02:00
Mas Ahmad Muhammad e3c779a855
[CPL_MMSYS] Update Indonesian translation. 2019-06-20 17:31:57 +02:00
Mas Ahmad Muhammad 40be6abdd8
[CPL_TIMEDATE] Update Indonesian translation. 2019-06-20 17:31:56 +02:00
Mas Ahmad Muhammad 37d345d8cc
[CPL_CONSOLE] Update Indonesian translation. 2019-06-20 17:31:56 +02:00
Mas Ahmad Muhammad 456e06ae2a
[CPL_APPWIZ] Add Indonesian translation. 2019-06-20 17:31:55 +02:00
Mas Ahmad Muhammad aadd11c01d
[CPL_ACCESS] Update Indonesian translation. 2019-06-20 17:31:54 +02:00
Mas Ahmad Muhammad 682ea2206a
[NEWDEV] Update Indonesian translation. 2019-06-20 17:31:53 +02:00
Mas Ahmad Muhammad 11f1b911d8
[IEFRAME] Add Indonesian translation. 2019-06-20 17:31:52 +02:00
Mas Ahmad Muhammad 7f09d9512c
[DEVMGR] Update Indonesian translation. 2019-06-20 17:31:51 +02:00
Mas Ahmad Muhammad 867fdc24d9
[MSGINA] Update Indonesian translation. 2019-06-20 17:31:50 +02:00
Mas Ahmad Muhammad 859199ee16
[COMCTL32] Add Indonesian translation. 2019-06-20 17:31:49 +02:00
Mas Ahmad Muhammad bb499e4b4e
[THEMEUI] Add Indonesian translation. 2019-06-20 17:31:47 +02:00
Mas Ahmad Muhammad d0629fde40
[COMDLG32] Add Indonesian translation. 2019-06-20 17:31:46 +02:00
Mas Ahmad Muhammad 4742f65936
[BROWSEUI] Add Indonesian translation. 2019-06-20 17:31:44 +02:00
Jose Carlos Jesus 37c43a7414
[DEVMGR] Add Portuguese (neutral) translation. 2019-06-20 17:15:17 +02:00
Jose Carlos Jesus 666e6561d5
[CREDUI] Update Portuguese (neutral) translation. 2019-06-20 17:15:17 +02:00
Jose Carlos Jesus af10e1fb74
[COMDLG32] Update Portuguese (neutral) translation. 2019-06-20 17:15:16 +02:00
Jose Carlos Jesus 4bbeb21f6d
[COMCTL32] Update Portuguese (neutral) translation. 2019-06-20 17:15:15 +02:00
Jose Carlos Jesus 7df98d73b3
[BROWSEUI] Add Portuguese (neutral) translation. 2019-06-20 17:15:15 +02:00
Jose Carlos Jesus 64785cf7d3
[ACLUI] Add Portuguese (neutral) translation. 2019-06-20 17:15:14 +02:00
Eric Kohl e57f103d53 [NETCFGX] Add the interfaces INetCfgBindingInterface and IEnumNetCfgBindingInterface (stubs only). 2019-06-19 22:38:31 +02:00
Eric Kohl ec9c8fdf25 [NETCFGX] Add the interfaces INetCfgBindingPath and IEnumNetCfgBindingPath (stubs only). 2019-06-18 22:35:46 +02:00
Eric Kohl 2da533a8a4 [NETCFGX] NetPropPageProvider: Handle the Min and Max values for INT, LONG and WORD types properly
CORE-15095
2019-06-18 21:47:29 +02:00
Mark Jansen c8ef4912a7
[URLMON] Directly call cabinet!Extract instead of calling it via advpack!ExtractFilesW
CORE-15795
2019-06-17 19:51:58 +02:00
Jose Carlos Jesus 65dc8aba92
[APPWIZ.CPL] Update Portuguese Brazilian, and add Portuguese (neutral) translations. (#1656) 2019-06-17 15:12:08 +02:00
Jose Carlos Jesus 8aca2dafeb
[ACCESS.CPL] Add & update Portuguese translation. (#1656) 2019-06-17 15:12:08 +02:00
Eric Kohl 1270e0a4fc [NETCFGX] Add the INetCfgComponentBindings interface to the NetCfgComponent class. 2019-06-17 14:57:08 +02:00
Eric Kohl 78f13ae5ad [NETSHELL] Improvements to the network setup (1/x)
Step 1: Find the TcpIp transport and enumerate the installed network adapters using INetCfg.

Next Step: Find out how the binding process works and bind the TcpIp transport to all enumerated network adapters. This will replace the blind binding process we are using right now.
2019-06-17 01:18:05 +02:00
Eric Kohl 24b22db77e [NETCFGX] Resize a helper buffer to accommodate a device instance id.
This prevent NULL pointer exceptions in calls to INetCfgComponent::GetPnpDevNodeId().
2019-06-17 00:46:30 +02:00
Eric Kohl 9bf78b6a95 [NETCFGX] Set the ComponentId value when a NIC is installed. 2019-06-16 23:59:52 +02:00
Mark Jansen f3d1d38041
[INPUT] Don't race the system to free an imagelist 2019-06-16 23:11:03 +02:00
Mark Jansen bcffdd0b16
[RASAPI32] Add RasClearConnectionStatistics stub
CORE-10092
2019-06-16 13:56:54 +02:00
Serge Gautherie b13990bd78
[SETUPAPI] Revert "Fix a typo in CM_Query_Resource_Conflict_List." (#1634)
Previous code was correct.
This reverts commit c47ad98f.
2019-06-15 17:55:33 +02:00
Baruch Rutman 22064d7787
[LPK] Fix for CORE-16115. (#1654)
Proposed changes:

- Use the total extent (width) and font metrics (height) as values
  to put in the lpSize variable instead of calling ScriptString_pSize()
  in the LpkGetTextExtentExPoint() function.

- Use GetTextExtentExPointWPri in more cases as another effort to get the data.

- Trailing whitespace fixes.
2019-06-15 17:37:51 +02:00
Baruch Rutman 1a7ffd29d6
[LPK] Update Wine BiDi code. (#1651)
Imports the changes from
ef07087f47
2019-06-15 17:24:38 +02:00
Joachim Henze 10f00f8c1c [MSI] Fix regression CORE-14646
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.

The regression was introduced to ros by 0.4.8-dev-739-g
f8b992f2d3
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445

Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.

I also committed the same fix to 0.4.12-RC-32-g152ee20.
2019-06-14 23:21:37 +02:00
Eric Kohl 7b29f4d975 [NETCFGX] InstallNetDevice: Run the default device installer before making class-specific changes. 2019-06-13 14:16:25 +02:00
Giannis Adamopoulos cc25a266f2 [COMCTL32] imagelist: Make the exported functions use the internal IImageList2
- Add a hack to rename the exported functions and use the Internal_ prefix for them so that the IImageList can use them with minimal code changes.
- Add the correct implementation of the affected exported functions making them now use the IImageList of the passed HIMAGELIST.

This indirection is possible because an HIMAGELIST is also a IImageList*.
This indirection is also needed because we can end up using image lists created by either comctl32 v5 or comctl32 v6.
This is how windows manage to use an HIMAGELIST created by comctl32 v5 when it is passed to comctl32 v6.
What really happens in this scenario is that the exported functions of both versions end up using the interface
stored in the object without checking if this interface is the version provided in the same dll or in the other.
2019-06-12 19:20:44 +03:00
Pierre Schweitzer f381137c89
[BTRFS] Upgrade to 1.3
CORE-16111
2019-06-11 12:35:19 +02:00
Eric Kohl 90aa2c26f8 [NETCFGX] Improvements to the TCP/IP settings dialog.
- Separate the gateway settings from the DHCP settings.
- Enable Edit and Delete buttons only if an item in a list box has been selected.

CORE-9908
2019-06-11 06:58:42 +02:00
Eric Kohl 8f285f71c9 [NETCFGX] Do not update the TCP/IP properties when the cancels the advanced properties dialog.
CORE-9908
2019-06-10 20:28:58 +02:00
Pierre Schweitzer 72d229b38c
[NETPLWIZ] Add French translation 2019-06-10 19:01:30 +02:00
Eric Kohl de0e19bc72 [NETSHELL] Network connections can't be renamed
Enable the 'Rename' and 'Delete' menu items for Administrators.
CORE-15348
2019-06-10 17:23:13 +02:00
Yaroslav Kibysh 27cfe08016
[CONSOLE] Update Ukrainian translation. (#1643) 2019-06-10 17:02:58 +02:00
Yaroslav Kibysh f0163f124f
[MSGINA] Update Ukrainian translation. (#1642) 2019-06-10 17:00:44 +02:00
Yaroslav Kibysh b2e4ff8cfd
[SHELL32] Update Ukrainian translation. (#1637) 2019-06-10 16:45:20 +02:00
Pierre Schweitzer a7b6a1a97d
[MSGINA] Update French translation 2019-06-10 15:37:32 +02:00
Eric Kohl f2f698587c [MSGINA] Add missing logon restriction messages. 2019-06-09 22:42:10 +02:00
Serge Gautherie 8a8453494f [SHELL32] SHCreateShellFolderView(): Fix parameter validation order. (#1632)
Fixes one modification from commit ae2a85d0.
CORE-16098
2019-06-09 15:57:45 +02:00
Eric Kohl c1421c4108 [NETAPI32] Ignore usriX_logon_hours and usriX_units_per_week if usriX_logon_hours is NULL. 2019-06-09 15:25:13 +02:00
Eric Kohl 1b05c9586c [NETAPI32] Do not try to set usriX_max_storage. Just ignore it. 2019-06-09 14:50:07 +02:00
Serge Gautherie 92e5fabb55
[BROWSEUI] Fix SHEnumClassesOfCategories() parameter validation. (#1622)
Addendum to fdfef818. CORE-11711
2019-06-08 20:05:54 +02:00
Hermès Bélusca-Maïto ae2a85d003
[SHELL32] Fix some NULL-pointers validation.
- In the exported SHCreateDefaultContextMenu() and
  IDataObject_Constructor() functions (called amongst others by
  the exported CIDLData_CreateFromIDArray() function).

- In the exported SHCreateShellFolderView() function.

- In CDefView::GetItemObject(), where data was written to *ppvOut before
  ppvOut was being checked for NULL.
2019-06-08 19:43:02 +02:00
Yaroslav Kibysh 47d76db311
[BROWSEUI] Update Ukrainian translation. (#1626) 2019-06-08 18:43:13 +02:00
Yaroslav Kibysh 6a8e99e235
[NEWDEV] Update Ukrainian translation. (#1625) 2019-06-08 18:37:29 +02:00
Yaroslav Kibysh 4d44e11f1e
[SHELL32] Update Ukrainian translation. (#1623) 2019-06-08 17:58:42 +02:00
Eric Kohl c47ad98ff7 [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List. 2019-06-06 19:12:44 +02:00
Eric Kohl adc9bd48b7 [SETUPAPI] GetDeviceInstanceKeyPath: Create a new driver instance property if needed and SEH-protect calls to umpnpmgr. 2019-06-06 19:08:43 +02:00
Hermès Bélusca-Maïto fdfef818ef
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. (#1559)
CORE-11711
2019-06-06 17:07:38 +02:00
Serge Gautherie 1f8250f700
[BROWSEUI] browseui.spec: Fix SHEnumClassesOfCategories() parameters. (#1559) 2019-06-06 17:06:52 +02:00
Serge Gautherie addfb61d8b [NTDLL_VISTA] Check _DEBUG with #ifdef, not #if (#1615) 2019-06-06 01:49:18 +02:00