Commit graph

1429 commits

Author SHA1 Message Date
Joachim Henze
8b67edd8fa [INPUT][INTL][SYSSETUP] Limit Combobox height CORE-16252
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaa

Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
2019-07-30 23:14:31 +02:00
Eric Kohl
034c6fd0c5 [LSASRV] Improvements to LsapLogonUser()
- Token handle duplication must be the last step because we cannot close the duplicated token handle if something fails.
- Call LsaApLogonTerminated(), delete the logon session and free the profile buffer if something fails.
2019-07-30 23:10:33 +02:00
Eric Kohl
32861b84b9 [MSV1_0] Add debug messages to MsvpCheckWorkstations() and disable MsvpCheckLogonHours() for testing. 2019-07-29 01:22:37 +02:00
Jose Carlos Jesus
f699cc96ac [NETSHELL][SYSSETUP] Minor improvements for pt_PT translation and object position adjustments (#1761) 2019-07-29 00:20:40 +02:00
Eric Kohl
12aba91abb [MSV1_0] LsaApCallPackage: The messages MsV1_0EnumerateUsers, MsV1_0GetUserInfo and MsV1_0ReLogonUsers are obsolete. 2019-07-28 14:57:46 +02:00
Doug-Lyons
77671f0337
[NETID][WINLOGON] Fix Computer Name Change to update Domain/Hostname on reboot. (#1684)
CORE-16123

- NETID: Correct the call when using the "Computer Name Change" in ReactOS.
- WINLOGON: Update the volatile "Hostname" and "Domain" variables from
  their non-volatile counterparts.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-07-22 00:49:47 +02:00
Michael Maltsev
a303932803
[ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094 2019-07-21 11:39:30 +02:00
Timo Kreuzer
ddb56e8cca [OLEAUT32] Use snprintf instead of sprintf
Fixes GCC 8 warning:
dll/win32/oleaut32/oleaut.c:876:39: error: '%s' directive writing up to 99 bytes into a region of size between 92 and 291 [-Werror=format-overflow=]
     sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
                                       ^~                     ~~~
dll/win32/oleaut32/oleaut.c:876:5: note: 'sprintf' output between 18 and 316 bytes into a destination of size 300
     sprintf(typelibkey, "Typelib\\%s\\%s\\0\\win%u", tlguid, ver, sizeof(void *) == 8 ? 64 : 32);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer
3120320c65 [FRAMEDYN] Fix broken asm (.code64 is for x64 only) 2019-07-20 13:56:18 +02:00
Timo Kreuzer
1b70ddd834 [KERNEL32] Improve path name handling
Fixes GCC 8 warning:
dll/win32/kernel32/client/loader.c: In function 'LoadLibraryA':
dll/win32/kernel32/client/loader.c:129:17: error: 'strncat' specified bound 13 equals source length [-Werror=stringop-overflow=]
                 strncat(PathBuffer, "\\twain_32.dll", 13);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer
2800837dc0 [MSGINA] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/msgina/lsa.c:195:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "User32  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Timo Kreuzer
f3a9b524f1 [ADVAPI32] Fix copying the TokenSource string
TOKEN_SOURCE::SourceString is an 8 char non-null-terminated string. Copy it as such.

Fixes GCC 8 warning:
dll/win32/advapi32/misc/logon.c:638:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
     strncpy(TokenSource.SourceName, "Advapi  ", sizeof(TokenSource.SourceName));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Jose Carlos Jesus
69454b4302 [TRANSLATION] Add Portuguese (neutral) translation. (#1702)
Add Portuguese (neutral) translation for intl.cpl, main.cpl, msgina.dll, msports.dll, welcome.exe and rundll32.exe, and fix the one in mshtml.dll .
2019-07-15 00:07:50 +02:00
Eric Kohl
433c9d327e [SETUPAPI] Implement CM_Delete_DevNode_Key_Ex()
CM_REGISTRY_USER is not supported yet.
2019-07-13 14:26:57 +02:00
Mark Jansen
b5423ba70b
[SHELL32] Fix SHCreateDirectoryExW showing an error on success
CORE-15145
2019-07-09 22:52:17 +02:00
Eric Kohl
93f77f2625 [SETUPAPI] CM_Delete_DevNode_Key[_Ex]: Use DEVINST instead of DEVNODE because we are using DEVINST anywhere else. 2019-07-08 00:08:22 +02:00
Eric Kohl
86e8a477b6 [SETUPAPI] CMP_RegisterNotification: When a window is registered, pass the window text to PNP_RegisterNotification(). 2019-07-07 23:47:01 +02:00
Bișoc George
019e3ffe5f
[SHELL32] Recycle-Bin: Validate the MaxCapacity value with respect to the available disk space. (#1688)
CORE-12313

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-07-07 19:01:09 +02:00
Hermès Bélusca-Maïto
8a30801516
[SHELL32] Recycle-Bin: Minor code enhancements.
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
2019-07-07 17:56:51 +02:00
Bișoc George
818d660868 [SHELL32] Enable the "Apply" button when user takes action on the edit box control (#1720)
CORE-12312
2019-07-07 14:47:44 +02:00
Eric Kohl
ece54dcd2f [SETUPAPI][UMPNPMGR] The 3rd parameter of PNP_RegisterNotification() seems to be the service name 2019-07-07 13:41:00 +02:00
Victor Perevertkin
042646ceac [IPHLPAPI] Use if_descrlen field for determining the length of
if_descr in IFEntry structure. This fixes heap corruption on GCC8.
CORE-16088
2019-07-05 22:49:12 +03:00
Stanislav Motylkov
a76e03d8bc [SHELL32][USERENV] Improve Russian translation (#1710)
CORE-16170
2019-07-01 21:43:22 +02:00
Jose Carlos Jesus
86d4156c39
[TRANSLATIONS] Add/Update Portuguese (neutral) translations. (#1687)
Translations for SYSDM.CPL, SETUPAPI, SHELL32, LSASRV, SAMSRV, SYSSETUP,
USRMGR, THEMEUI, USERENV, WININET, MSCONFIG.
2019-06-29 16:55:33 +02:00
Eric Kohl
7eb6e42626 [UMPNPMGR][SETUPAPI] PNP_RegisterNotification() has got 9 parameters. 2019-06-29 13:38:42 +02:00
Eric Kohl
a9c4c07955 [SETUPAPI][UMPNPMGR] PNP_UnregisterNotification: Add 2 unknown parameters 2019-06-23 21:45:54 +02:00
Eric Kohl
ca0406131c [SETUPAPI][UMPNPMGR] Improve CMP_RegisterNotification/PNP_RegisterNotification
Pass the notification filter to PNP_RegisterNotification as a byte-pointer to the filter and the size of the filter.
2019-06-23 19:31:34 +02:00
Eric Kohl
89c936fdd6 [NETCFGX] Start a network adapter device after the custom install steps have been completed.
This could probably fix CORE-16103
2019-06-22 21:01:26 +02:00
Eric Kohl
8dc70d2454 [SETUPAPI] Implement SetupDiRestartDevices() 2019-06-22 21:01:25 +02:00
Andreas Maier
49165276f2 [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) (#1674)
* [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression)

Fix cb_states / rb_states lookup table.

* [README.WINE] comctl32 is synced to WineStaging-3.3.

See commit b3fb8555 .
2019-06-22 16:36:14 +02:00
Jose Carlos Jesus
be820b9ca3
[NEWDEV] Add Portuguese (neutral) translation. 2019-06-22 16:17:03 +02:00
Jose Carlos Jesus
0e6732586d
[NETID] Add Portuguese (neutral) translation. 2019-06-22 16:16:58 +02:00
Jose Carlos Jesus
64a647a843
[NETCFGX] Add Portuguese (neutral) translation. 2019-06-22 16:11:55 +02:00
Eric Kohl
73ca084e96 [NETCFGX] Read a components bind value and implement the IsBoundTo method. 2019-06-20 22:08:38 +02:00
Eric Kohl
79a0f2b430 [NETCFGX] EnumClientServiceProtocol: Use the right parent key when trying to open the 'NDI' subkey.
This makes the description of the selected item show up in the network connection properties.
2019-06-20 20:08:36 +02:00
Hermès Bélusca-Maïto
1dc4ba9da7
[DEVMGR] Add the missing pt-PT.rc translation file. Strange, I thought I added it before... 2019-06-20 18:04:26 +02:00
Mas Ahmad Muhammad
682ea2206a
[NEWDEV] Update Indonesian translation. 2019-06-20 17:31:53 +02:00
Mas Ahmad Muhammad
11f1b911d8
[IEFRAME] Add Indonesian translation. 2019-06-20 17:31:52 +02:00
Mas Ahmad Muhammad
7f09d9512c
[DEVMGR] Update Indonesian translation. 2019-06-20 17:31:51 +02:00
Mas Ahmad Muhammad
867fdc24d9
[MSGINA] Update Indonesian translation. 2019-06-20 17:31:50 +02:00
Mas Ahmad Muhammad
859199ee16
[COMCTL32] Add Indonesian translation. 2019-06-20 17:31:49 +02:00
Mas Ahmad Muhammad
bb499e4b4e
[THEMEUI] Add Indonesian translation. 2019-06-20 17:31:47 +02:00
Mas Ahmad Muhammad
d0629fde40
[COMDLG32] Add Indonesian translation. 2019-06-20 17:31:46 +02:00
Mas Ahmad Muhammad
4742f65936
[BROWSEUI] Add Indonesian translation. 2019-06-20 17:31:44 +02:00
Jose Carlos Jesus
37c43a7414
[DEVMGR] Add Portuguese (neutral) translation. 2019-06-20 17:15:17 +02:00
Jose Carlos Jesus
666e6561d5
[CREDUI] Update Portuguese (neutral) translation. 2019-06-20 17:15:17 +02:00
Jose Carlos Jesus
af10e1fb74
[COMDLG32] Update Portuguese (neutral) translation. 2019-06-20 17:15:16 +02:00
Jose Carlos Jesus
4bbeb21f6d
[COMCTL32] Update Portuguese (neutral) translation. 2019-06-20 17:15:15 +02:00
Jose Carlos Jesus
7df98d73b3
[BROWSEUI] Add Portuguese (neutral) translation. 2019-06-20 17:15:15 +02:00
Jose Carlos Jesus
64785cf7d3
[ACLUI] Add Portuguese (neutral) translation. 2019-06-20 17:15:14 +02:00
Eric Kohl
e57f103d53 [NETCFGX] Add the interfaces INetCfgBindingInterface and IEnumNetCfgBindingInterface (stubs only). 2019-06-19 22:38:31 +02:00
Eric Kohl
ec9c8fdf25 [NETCFGX] Add the interfaces INetCfgBindingPath and IEnumNetCfgBindingPath (stubs only). 2019-06-18 22:35:46 +02:00
Eric Kohl
2da533a8a4 [NETCFGX] NetPropPageProvider: Handle the Min and Max values for INT, LONG and WORD types properly
CORE-15095
2019-06-18 21:47:29 +02:00
Mark Jansen
c8ef4912a7
[URLMON] Directly call cabinet!Extract instead of calling it via advpack!ExtractFilesW
CORE-15795
2019-06-17 19:51:58 +02:00
Eric Kohl
1270e0a4fc [NETCFGX] Add the INetCfgComponentBindings interface to the NetCfgComponent class. 2019-06-17 14:57:08 +02:00
Eric Kohl
24b22db77e [NETCFGX] Resize a helper buffer to accommodate a device instance id.
This prevent NULL pointer exceptions in calls to INetCfgComponent::GetPnpDevNodeId().
2019-06-17 00:46:30 +02:00
Eric Kohl
9bf78b6a95 [NETCFGX] Set the ComponentId value when a NIC is installed. 2019-06-16 23:59:52 +02:00
Mark Jansen
bcffdd0b16
[RASAPI32] Add RasClearConnectionStatistics stub
CORE-10092
2019-06-16 13:56:54 +02:00
Serge Gautherie
b13990bd78
[SETUPAPI] Revert "Fix a typo in CM_Query_Resource_Conflict_List." (#1634)
Previous code was correct.
This reverts commit c47ad98f.
2019-06-15 17:55:33 +02:00
Baruch Rutman
22064d7787
[LPK] Fix for CORE-16115. (#1654)
Proposed changes:

- Use the total extent (width) and font metrics (height) as values
  to put in the lpSize variable instead of calling ScriptString_pSize()
  in the LpkGetTextExtentExPoint() function.

- Use GetTextExtentExPointWPri in more cases as another effort to get the data.

- Trailing whitespace fixes.
2019-06-15 17:37:51 +02:00
Baruch Rutman
1a7ffd29d6
[LPK] Update Wine BiDi code. (#1651)
Imports the changes from
ef07087f47
2019-06-15 17:24:38 +02:00
Joachim Henze
10f00f8c1c [MSI] Fix regression CORE-14646
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.

The regression was introduced to ros by 0.4.8-dev-739-g
f8b992f2d3
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445

Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.

I also committed the same fix to 0.4.12-RC-32-g152ee20.
2019-06-14 23:21:37 +02:00
Eric Kohl
7b29f4d975 [NETCFGX] InstallNetDevice: Run the default device installer before making class-specific changes. 2019-06-13 14:16:25 +02:00
Giannis Adamopoulos
cc25a266f2 [COMCTL32] imagelist: Make the exported functions use the internal IImageList2
- Add a hack to rename the exported functions and use the Internal_ prefix for them so that the IImageList can use them with minimal code changes.
- Add the correct implementation of the affected exported functions making them now use the IImageList of the passed HIMAGELIST.

This indirection is possible because an HIMAGELIST is also a IImageList*.
This indirection is also needed because we can end up using image lists created by either comctl32 v5 or comctl32 v6.
This is how windows manage to use an HIMAGELIST created by comctl32 v5 when it is passed to comctl32 v6.
What really happens in this scenario is that the exported functions of both versions end up using the interface
stored in the object without checking if this interface is the version provided in the same dll or in the other.
2019-06-12 19:20:44 +03:00
Pierre Schweitzer
f381137c89
[BTRFS] Upgrade to 1.3
CORE-16111
2019-06-11 12:35:19 +02:00
Eric Kohl
90aa2c26f8 [NETCFGX] Improvements to the TCP/IP settings dialog.
- Separate the gateway settings from the DHCP settings.
- Enable Edit and Delete buttons only if an item in a list box has been selected.

CORE-9908
2019-06-11 06:58:42 +02:00
Eric Kohl
8f285f71c9 [NETCFGX] Do not update the TCP/IP properties when the cancels the advanced properties dialog.
CORE-9908
2019-06-10 20:28:58 +02:00
Yaroslav Kibysh
f0163f124f
[MSGINA] Update Ukrainian translation. (#1642) 2019-06-10 17:00:44 +02:00
Yaroslav Kibysh
b2e4ff8cfd
[SHELL32] Update Ukrainian translation. (#1637) 2019-06-10 16:45:20 +02:00
Pierre Schweitzer
a7b6a1a97d
[MSGINA] Update French translation 2019-06-10 15:37:32 +02:00
Eric Kohl
f2f698587c [MSGINA] Add missing logon restriction messages. 2019-06-09 22:42:10 +02:00
Serge Gautherie
8a8453494f [SHELL32] SHCreateShellFolderView(): Fix parameter validation order. (#1632)
Fixes one modification from commit ae2a85d0.
CORE-16098
2019-06-09 15:57:45 +02:00
Eric Kohl
c1421c4108 [NETAPI32] Ignore usriX_logon_hours and usriX_units_per_week if usriX_logon_hours is NULL. 2019-06-09 15:25:13 +02:00
Eric Kohl
1b05c9586c [NETAPI32] Do not try to set usriX_max_storage. Just ignore it. 2019-06-09 14:50:07 +02:00
Serge Gautherie
92e5fabb55
[BROWSEUI] Fix SHEnumClassesOfCategories() parameter validation. (#1622)
Addendum to fdfef818. CORE-11711
2019-06-08 20:05:54 +02:00
Hermès Bélusca-Maïto
ae2a85d003
[SHELL32] Fix some NULL-pointers validation.
- In the exported SHCreateDefaultContextMenu() and
  IDataObject_Constructor() functions (called amongst others by
  the exported CIDLData_CreateFromIDArray() function).

- In the exported SHCreateShellFolderView() function.

- In CDefView::GetItemObject(), where data was written to *ppvOut before
  ppvOut was being checked for NULL.
2019-06-08 19:43:02 +02:00
Yaroslav Kibysh
47d76db311
[BROWSEUI] Update Ukrainian translation. (#1626) 2019-06-08 18:43:13 +02:00
Yaroslav Kibysh
6a8e99e235
[NEWDEV] Update Ukrainian translation. (#1625) 2019-06-08 18:37:29 +02:00
Yaroslav Kibysh
4d44e11f1e
[SHELL32] Update Ukrainian translation. (#1623) 2019-06-08 17:58:42 +02:00
Eric Kohl
c47ad98ff7 [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List. 2019-06-06 19:12:44 +02:00
Eric Kohl
adc9bd48b7 [SETUPAPI] GetDeviceInstanceKeyPath: Create a new driver instance property if needed and SEH-protect calls to umpnpmgr. 2019-06-06 19:08:43 +02:00
Hermès Bélusca-Maïto
fdfef818ef
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. (#1559)
CORE-11711
2019-06-06 17:07:38 +02:00
Serge Gautherie
1f8250f700
[BROWSEUI] browseui.spec: Fix SHEnumClassesOfCategories() parameters. (#1559) 2019-06-06 17:06:52 +02:00
Serge Gautherie
addfb61d8b [NTDLL_VISTA] Check _DEBUG with #ifdef, not #if (#1615) 2019-06-06 01:49:18 +02:00
Serge Gautherie
46259092f9 [ADVAPI32:REG] Remove some useless casts (#1614) 2019-06-05 18:37:07 +02:00
Serge Gautherie
38db074491 Misc addendum to CORE-14271 (#1529)
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check

RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.

No functional change.

Addendum to
CORE-14271

* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check

RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.

Also, add a FIXME.

No functional change.

Addendum to
CORE-14271

* [USER32] Simplify RegisterClipboardFormatA/W() a bit

No functional change.

* [UDFS] Simplify SeSinglePrivilegeCheck() return value check

No functional change.

Addendum to
CORE-14271
2019-06-04 16:56:33 +02:00
Joachim Henze
bc3eed68ca [MSHTML] Fake Success in HTMLDocument_put_bgColor()
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error 8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123

Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
2019-06-01 22:53:16 +02:00
Eric Kohl
adceb3807e [NETAPI32] Implement parts of NetGetDCName and declare some parameters optional. 2019-05-29 15:35:55 +02:00
Eric Kohl
968bdeddf3 [NETAPI32] Implement NetpAllocWStrFromStr(), NetpAllocWStrFromAnsiStr() (not public, but useful) and NetpAllocWStrFromWStr(). 2019-05-29 12:59:44 +02:00
Katayama Hirofumi MZ
9a39315d46
[SYSSETUP] Set registry hostname in WriteComputerSettings (#1589)
Based on @Doug-Lyons's patch. CORE-16067
2019-05-29 19:59:40 +09:00
Timo Kreuzer
801ec51a91 [BROWSEUI] Fix indentation
Fixes GCC 8 warning:
dll/win32/browseui/explorerband.cpp:1332:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
                 if (!SUCCEEDED(hr) || !pParent.p)
                 ^~
dll/win32/browseui/explorerband.cpp:1335:21: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
                     hr = pParent->SetNameOf(0, pidlChild, dispInfo->item.pszText, SHGDN_INFOLDER, &pidlNew);
                     ^~
2019-05-27 13:22:40 +02:00
Timo Kreuzer
207a0f520e [MSHTML] Convert tabs to spaces
Fixes GCC 8 warning:
dll/win32/mshtml/script.c:844:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if(!new_buf)
    ^~
dll/win32/mshtml/script.c:846:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
             This->size <<= 1;
             ^~~~
2019-05-27 13:22:40 +02:00
Timo Kreuzer
089d59bc6c [RSAENH] Use StringCbPrintfA instead of sprintf
Fixes GCC 8 warning:
dll/win32/rsaenh/rsaenh.c:161:23: error: '%s' directive writing up to 259 bytes into a region of size 235 [-Werror=format-overflow=]
 #define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:161:23: note: in definition of macro 'RSAENH_REGKEY'
 #define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:1107:5: note: 'sprintf' output between 26 and 285 bytes into a destination of size 260
     sprintf(szRSABase, RSAENH_REGKEY, pKeyContainer->szName);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-05-27 13:22:40 +02:00
Timo Kreuzer
81bdf4e360 [CRT] Add missing posix error codes
These are required by latest mingw-w64 stl and we are mixing this with our crt headers.
Define _CRT_NO_POSIX_ERROR_CODES in all modules that define their own constants.
2019-05-27 13:22:40 +02:00
Katayama Hirofumi MZ
2db0e159a4
[KERNEL32] Fix SetComputerNameExW (#1583)
Based on @Doug-Lyons's patch. CORE-16058
2019-05-27 16:18:38 +09:00
Jose Carlos Jesus
7f5e960e32
[TRANSLATIONS] Update/Add Portuguese translations.
Translations for: reactos/setup, usetup, syssetup, netshell, shell32.
2019-05-26 21:19:31 +02:00
Jose Carlos Jesus
73d7fd1415
[TRANSLATIONS] Update/Add Portuguese translations. (#1564)
Translations for: deskadp, deskmon, reactos/setup, usetup, syssetup.

Co-Authored-By: Bișoc George <fraizeraust99@gmail.com>
2019-05-19 17:04:47 +02:00
Pierre Schweitzer
ea7aca8bdd
[KERNEL32] Drop unused line breaks 2019-05-08 18:34:28 +02:00
Pierre Schweitzer
204bfa8574
[KERNEL32] Misc. fixes to DefineDosDeviceW
- Add support for LUIDDeviceMapsEnabled;
- Broadcast proper message in case of device removal;
- Use less memory for strings management;
- Make code a bit cleaner.
2019-05-05 18:33:15 +02:00
Pierre Schweitzer
5d20d512be
[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces
It also comes with a small performance boost: instead of performing object
queries one after another, we query them all at once.
2019-05-05 14:18:09 +02:00
Pierre Schweitzer
8d128aa441
[KERNEL32] Reduce QueryDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.
2019-05-05 10:17:16 +02:00
Pierre Schweitzer
1ed7f27466
[KERNEL32] Reduce DefineDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
2019-05-05 10:17:16 +02:00
Eric Kohl
5164c852e8 [POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState. 2019-05-02 20:39:58 +02:00
Hervé Poussineau
7033ab18df [HID] Use hidparser static library for HidP_* functions
hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys

At the same time, this permis implementation of some HidP_* functions.
2019-05-02 20:06:47 +02:00
Katayama Hirofumi MZ
dcaaf3e7af
[COMDLG32] Fix treatment of wrong filename extension (#1545)
Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270
2019-05-02 22:48:01 +09:00
Hermès Bélusca-Maïto
77d234b049
[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989 2019-04-29 22:51:35 +02:00
Serge Gautherie
cf48f8bf8a [REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)
No functional change otherwise.
2019-04-28 21:19:42 +02:00
Katayama Hirofumi MZ
2da24f7274 [COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension 2019-04-28 08:44:52 +09:00
Hermès Bélusca-Maïto
0e3a043526
[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee(). (#803)
This should remove some of the "SetThreadStackGuarantee(): stub" messages in some simple cases.
2019-04-27 18:41:50 +02:00
Katayama Hirofumi MZ
6a7d8112c3
[COMDLG32] Save open/save location by extension (#1514)
Use the proper open/save initial folder for comdlg32.GetOpenFileName and comdlg32.GetSaveFileName. CORE-7114
2019-04-27 23:02:34 +09:00
Andrew Cook
716613cddc [CMAKE] Use new policies for CMP0005 and CMP0018 (#1481)
* [CMAKE] Fix for CMP0018
The new behaviour lets us explicitly disabling position independent code, avoiding the need to change undocumented variables

* LINK_DEPENDS is semicolon separated

* [CMAKE] Fix for CMP0005
it seems impossible to have cmake correct escape PROXY_CLSID_IS so move it to the header
2019-04-27 11:33:37 +02:00
Jared Smudde
7e18b6d0eb
[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522)
CORE-13516, CORE-13518
2019-04-24 04:28:05 +02:00
Jared Smudde
bf431dd278
[MPR] Implement the function WNetDisconnectDialog(). (#1522)
CORE-13516, CORE-13518
2019-04-24 04:28:01 +02:00
Hermès Bélusca-Maïto
62823a08ce
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry. 2019-04-24 03:41:41 +02:00
Hermès Bélusca-Maïto
0416c598f8
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem(). 2019-04-24 03:36:27 +02:00
Katayama Hirofumi MZ
8e60c2efee
[SHELL32] Implement 'New Link' (Retrial of #1510), CORE-15511 (#1518)
Correctly create cache about ".lnk" and handling in the member functions.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-04-24 03:28:17 +02:00
Mark Jansen
774f497721
[SYSSETUP] Fix a broken DPRINT
Thanks to Thomas for spotting it.
2019-04-22 16:24:59 +02:00
Eric Kohl
eabae983e0 [POWRPROF] EnumPwrSchemes: Fix callback string lengths
The callback routine should get the real lengths of the name and description strings in bytes instead of the buffer sizes in characters. This fixes buffer overflows in powercfg.cpl.
2019-04-22 00:44:47 +02:00
Eric Kohl
afca8367ea [KERNEL32] GetSystemPowerStatus(): Set the BATTERY_FLAG_CRITICAL flag if the battery life gets lower than 5 percent. 2019-04-19 22:30:46 +02:00
Eric Kohl
333eb16f30 [KERNEL32] GetSystemPowerStatus(): Fix coding style. No code changes! 2019-04-19 22:28:11 +02:00
Andreas Maier
0263151f3c
[DBGHELP] SymFromAddr: Handle 2 or more symbols at the same address correct.
There could be more then 2 symbols at the same addr.
Adjust function to handle that case correct.
2019-04-19 21:09:45 +02:00
Andreas Maier
b2bcd8afdd
[DBGHELP] Set LastError for SymGetModuleBase-calls to ERROR_MOD_NOT_FOUND.
Correct last error in module_find_by_addr.
2019-04-19 21:09:45 +02:00
Andreas Maier
6175044aed
[DBGHELP] set correct values in symt_fill_sym_info (SYMBOL_INFO).
* symtype: set to SymPdb not SymCv (may be for old pdb-files pre VS 6.0)
* flags: return SYMFLAG_PUBLIC_CODE for SymTagPublicSymbol if its a function.
* flags: do not return SYMFLAG_FUNCTION for SymTagFuncion.
2019-04-19 21:09:45 +02:00
Andreas Maier
9466a005e9
[DBGHELP] Add SYMFLAG_- and SYMTYPE_-defines. 2019-04-19 21:09:44 +02:00
Andreas Maier
e3447d02c1
[DBGHELP] use correct record in codeview_snarf_public.
Use public_vx iststead of data_vx for public symbols.
2019-04-19 21:09:44 +02:00
Andreas Maier
183294a12e
[DBGHELP] search for debugfiles in modulepath too.
Debug symbols (like PDB, ...) could not be found if the direcory of
the module and application differs. Applying this patch they will
be found.
Dbghelp searches the module path too. (See MS docs).
2019-04-19 21:09:38 +02:00
Mark Jansen
9f00854bad
[MSGINA] Disable exceptions in atl when compiling without exceptions 2019-04-18 19:21:38 +02:00
Mark Jansen
f5731a41f8
[SHELL32] Use the same definitions for shell32 and it's static libs 2019-04-18 19:21:37 +02:00
Mark Jansen
9824a0154e
[ATL] Retire atlnew 2019-04-18 19:21:37 +02:00
Katayama Hirofumi MZ
083d6be31e [KERNEL32] Implement InvalidateNLSCache 2019-04-16 21:41:58 +09:00
Katayama Hirofumi MZ
a004233bd3 [KERNEL32] Fix handle leak and caching (follow-up of 7e38267) 2019-04-16 20:57:02 +09:00
Katayama Hirofumi MZ
7e3826786e [KERNEL32] Era first year is GANNEN 2019-04-16 11:10:00 +09:00
Thomas Faber
6122f3f436
[COMCTL32] Remove an unnecessary include. 2019-04-14 14:35:29 +02:00
Thomas Faber
5685ad4a12
[CMAKE] Don't use the PCH for generated files.
The PCH must be used with the same compiler flags it was generated with,
so don't use it for files that use modified flags.
2019-04-13 15:58:22 +02:00
Timo Kreuzer
146096cd2e [3RDPARTY] Make some warnings non-fatal 2019-04-13 14:07:50 +02:00
Timo Kreuzer
c2e16abc91 [DBGHELP] Fix 64 bit issue 2019-04-13 14:07:50 +02:00
Timo Kreuzer
f9a967b2ae [REACTOS] Fix misc 64 bit issues 2019-04-13 14:07:50 +02:00
Katayama Hirofumi MZ
c65156002c
[SHELL32] Fix SHFileOperation Move operation (#1487)
Reduce failures of Move operation of shell32!SHFileOperation function. CORE-13450
2019-04-08 21:59:33 +09:00
Stanislav Motylkov
d2a2632fd9 [SYSSETUP] Update Russian translation
Addendum to 5d4d48a, 21b7648, and ea799b7.
2019-04-07 23:51:34 +02:00
Foxlet
ea799b74f1 [SYSSETUP] Add Mizu to syssetup. 2019-04-07 22:47:20 +02:00
Hervé Poussineau
11d11cf6d0 [CMAKE] Temporarly disable pch in some modules to fix travis-ci
Problem appeared after 09c4d0a74b
2019-04-07 21:00:49 +02:00
Hervé Poussineau
10ecbaddd0 [ADVAPI32] Send correct type to ElfrChangeNotify()
This fixes the following compiler error:
../dll/win32/advapi32/service/eventlog.c:658:59: error: passing argument 3 of 'ElfrChangeNotify' makes integer from pointer without a cast [-Werror=int-conversion]
dll/win32/advapi32/eventlogrpc_c.h:391:20: note: expected 'ULONG {aka long unsigned int}' but argument is of type 'HANDLE {aka void *}'
2019-04-07 18:32:29 +02:00
Hervé Poussineau
09c4d0a74b [CMAKE] Prevent out-of-bound accesses in parser/lexer files
which try to remove path prefix from them.
2019-04-07 18:32:29 +02:00
Joachim Henze
b71429059a [COMCTL32] Improve status bar margin for unthemed and themed CORE-15834
Improve further what was recently committed in
0.4.12-dev-361-g
da9accfba6
2019-04-07 15:15:25 +02:00
Katayama Hirofumi MZ
f762aa3dd2 [SHELL32] Fix explorer file item label background CORE-15937 2019-04-07 21:38:00 +09:00
Katayama Hirofumi MZ
15537c3bbe
[KERNEL32] Support Japanese calendar (#1482)
Implement the Japanese calendar in kernel32. Locale info and date formatting. CORE-15920
2019-04-07 20:20:23 +09:00
Jérôme Gardou
23373acbb9 [CMAKE] Use modules instead of shared libraries
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.

On my system, this reduces the configure-time by a factor of two.
2019-04-06 17:43:38 +02:00
Katayama Hirofumi MZ
c7bebe40cb
[KERNEL32] Improve MultiByteToWideChar (#1477)
Reduce MultiByteToWideChar failures. CORE-13349
2019-04-06 20:11:07 +09:00
Katayama Hirofumi MZ
6150baf414 [SHELL32] pl-PL.rc escape sequence fix 2019-04-06 11:41:08 +09:00
Adam Słaboń
21b7648f15 [SYSSETUP] Add Lunar theme option to 2nd setup stage
This adds Lunar theme option to the 2nd setup stage theme chooser page.
2019-04-06 01:10:52 +02:00
Mark Jansen
5d4d48a850
[SYSSETUP] Add a theme chooser that can handle multiple styles 2019-04-05 21:56:31 +02:00
Adam Słaboń
7047aa80ef [TRANSLATION] Polish translation update
Polish translation update for calc, fltmc, magnify, notepad, osk, sndvol32, usetup, fdebug, appwiz, mmsys, sysdm, acppage, ziplfdr, browseui, cryptui, jscript, shell32, themeui and inf. Added translation for cyrptext, vcdcontroltool, and (not yet complete) getuname.
2019-04-05 10:34:10 +02:00
Katayama Hirofumi MZ
f55ded91a4
[SHIMGVW] Fix cursor (#1471)
Fix the cursor of shimgvw.dll. CORE-15219
2019-04-05 16:52:11 +09:00
Katayama Hirofumi MZ
d04b4e65d6
[SHELL32] Implement Explorer background image (Retrial of #801) (#1463)
IconArea_Image, IconArea_Text and IconArea_TextBackground values in desktop.ini in a folder will be supported. It denies network paths. CORE-5516
2019-04-05 07:59:35 +09:00
Mark Jansen
d71712e909
[SYSSETUP] Ask for common controls v6 when using v6 features 2019-04-03 19:44:27 +02:00
Mark Jansen
bae083355d
[SYSSETUP] Add a missing break 2019-04-03 19:44:16 +02:00
Maxim Smirnov
39c0fd5722 [SHELL32] Fix version info in the file dialog 2019-04-03 00:51:24 +02:00
Julien Schueller
23d0aead53 [KERNEL32] Fix typo in kernel32.spec (#1453) 2019-04-02 15:48:41 +02:00
Timo Kreuzer
be97da34ac [NETAPI32] Fix NetUserEnum to work on x64
The previous implementation used the resume_handle parameter to return a pointer to the active enumeration context, but resume_handle is a DWORD. To support 64 bit pointers, the enumeration context is inserted into a global linked list and given a unique 32 bit value as identifier for later lookup.
The way the function is implemented, leaking a data structure while the MSDN description does not indicate that, seems a little questionable in general, but that is something that I leave to the original author to investigate.
2019-04-02 01:45:51 +02:00
Timo Kreuzer
61e35141e8 [SETUPAPI] Use ClassInstallReserved field instead of Reserved to store a pointer.
The Reserved field is ULONG and we need ULONG_PTR. ClassInstallReserved was unused so far. I have no idea whether this is correct, but it cannot be more incorrect than what we had.
2019-04-01 22:20:39 +02:00
Hervé Poussineau
6cc607bac2 [SETUPAPI] SetupDiGetDeviceInfoListClass: fix buffer overflow (and return correct results) 2019-04-01 11:38:32 +02:00
Hervé Poussineau
faa938e9dc [USERENV] Initialize variable before using it 2019-04-01 11:38:32 +02:00
Hervé Poussineau
6668178cff [PSDK] Remove throw specifiers, deprecated in C++11 2019-04-01 11:38:32 +02:00
Yaroslav Kibysh
cc7c6d21f8 [DEVMGR] Fix Ukrainian translation (#1441) 2019-03-25 23:15:00 +01:00
Stanislav Motylkov
cd7011388e [COMCTL32] Edit: Fix caret and scroll position
Based on patch by JIRA contributor 'I_Kill_Bugs'. CORE-15780
2019-03-24 23:26:20 +01:00
Hermès Bélusca-Maïto
780f2ba215
[USER32][COMCTL32] Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
CORE-8526

Import Wine commit:
96d0af52eb

"user32: Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
This patch also changes the logic to get the control style with WM_GETDLGCODE
instead of GetWindowLong to make the message test pass.
"
by Dmitry Timoshkov.
See bug report https://bugs.winehq.org/show_bug.cgi?id=42010

- (ReactOS-only) Fix also the corresponding logic in COMCTL32.
2019-03-24 17:23:24 +01:00
Yaroslav Kibysh
a30e644dc4 [EXPLORER][SHPOLICY] Implement "NoSimpleStartMenu" policy (#1258)
- Enable "New Start Menu" control for all languages.
- Implement the "NoSimpleStartMenu" policy in shpolicy.c and its usage in explorer.
- Hide controls instead of disabling (as in Win XP/Vista).
2019-03-24 14:56:43 +01:00
Baruch Rutman
1078479358
[LPK] Implement LpkGetTextExtentExPoint(). (#1362)
- Add argument checking.
- Use logic from NtGdiGetTextExtentExW().
2019-03-23 23:31:02 +01:00
Stanislav Motylkov
cc99d3ad5f [SHELL32] Add line bar to About dialog for consistence
Addendum to f9d2931. CORE-15215
2019-03-23 19:11:28 +01:00
Yaroslav Kibysh
3999e875be [SHPOLICY] Fix the missing backslash in SHRestricted. CORE-15666 (#1267)
Import Wine commit https://source.winehq.org/git/wine.git/?a=commit;h=dbbfa481539acd29de47ff6cd5cc2d24a2e01871

Original patch from Yaroslav Kibysh, reported to Wine and committed there by Fabian Maurer.
Thank you all!
2019-03-23 18:28:39 +01:00
Hermès Bélusca-Maïto
b9148b8c62
[WTSAPI32][PSDK] Addendum to 27ed609a: Some of the WTS_INFO_CLASS values are NT6-SP1+ 2019-03-23 16:31:15 +01:00
Andrew Boyarshin
27ed609acd [WTSAPI32] Implement WTSConnectState and WTSClientProtocolType in WTSQuerySessionInformation
Since ReactOS doesn't actually support non-local WinSTA/WTS capabilities, this seems to be a good way to reduce spam in the log while providing correct behaviour.
Also call Unicode version from ANSI one to reduce code duplication.
2019-03-23 16:06:10 +01:00
Stanislav Motylkov
56ccf8d832 [COMCTL32] Edit: Fix rectangle overflow when inserting characters
Based on patch by JIRA contributor 'I_Kill_Bugs'. CORE-11475
2019-03-23 15:52:43 +01:00
Stanislav Motylkov
8e05f5509c [MSI] Allow to pass product key validation check
CORE-14710 CORE-15864
2019-03-19 23:05:57 +01:00
Luo Yufan
4785291ff3 [SAMSRV] Update Chinese translation 2019-03-19 23:05:34 +01:00
Thomas Faber
49fbaa758e
[RICHED20] Simplify MSVC thiscall & stdcall wrappers.
Imports Wine commit b64511c00a5.
2019-03-19 21:19:20 +01:00
Eric Kohl
be54b37dd6 [USERENV] UnloadUserProfile: When a profiles ref count gets 0, delete the profile if the user is a member of the guests group. 2019-03-18 23:27:29 +01:00
Eric Kohl
c8d44606d6 [USERENV] Implement GetProfileType(). 2019-03-17 17:51:32 +01:00
Eric Kohl
0f21a8a6e6 [USERENV] LoadUserProfileW: Check the user for Administators and Guests group membership and set the State value accordingly.
See https://www.pcreview.co.uk/threads/purpose-of-the-state-key-located-in-users-profiles.2939114/post-9722112
2019-03-17 12:44:54 +01:00
Eric Kohl
646ab9286c [NETAPI32] NetUserEnum, NetUserGetInfo: Get the user privileges and auth flags for info levels 1, 2, 3, 4 and 11. 2019-03-17 12:34:49 +01:00
Eric Kohl
cf6a5d6e7c [USERENV] Store the profiles load time, flags and state in the profile list. 2019-03-16 19:13:15 +01:00
Jared Smudde
6707efc534 [SHELL32] Disable the Hardware tab in the properties dialog for Network drives (#1249)
This matches Windows behaviour.
2019-03-16 15:37:56 +01:00
Eric Kohl
7d28dfd184 [USERENV] Use a reference counter when loading and unloading profiles. Unload the hive only when the reference counter reaches 0. This fixes the remaining bugs in "userenv_apitest LoadUserProfile". 2019-03-16 07:45:30 +01:00
Joachim Henze
e3e173ffaa [COMCTL32] Combobox Implement logic for set and get dropdown height CORE-15833
by import of Wine commit
313c63e194
merged from current Wine head.

Thanks to patches author Fabian Maurer
and also Doug Lyons for tests and adding initial the merge-patch.
2019-03-16 02:11:00 +01:00
Eric Kohl
05886b83e9 [USERENV] Use a mutex to serialize profile loading and unloading. 2019-03-15 21:20:14 +01:00
Katayama Hirofumi MZ
332ca5f572
[OLE32] Implement WS_EX_ACCEPTFILES (#1403)
The window that has WS_EX_ACCEPTFILES extended style, should pretend like a drop target that accepts CF_HDROP data. CORE-11238
2019-03-15 22:31:13 +09:00
Eric Kohl
30c501fc9f [USERENV] LoadUserProfileW: If a user profile has already been loaded, just open and return the profile key. 2019-03-14 23:49:16 +01:00
Eric Kohl
85c5d035d9 [NETAPI32] NetUserAdd, NetUserSetInfo: Start to set parm_err in case of invalid parameters. 2019-03-12 01:02:47 +01:00
Eric Kohl
33eb43d6e7 [NETAPI32] NetUserSetInfo: Support the logon hours for level 2, 3, 4, 22 and 1020. Also make sure that we do not leak memory on invalid levels. 2019-03-12 00:20:07 +01:00
Eric Kohl
0425d866bf [NETAPI32] NetUserGetInfo: Build and return the users SID for level 4 and 23. 2019-03-11 22:31:36 +01:00
Eric Kohl
462418fe38 [NETAPI32] Initialize parm_err 2019-03-09 20:26:00 +01:00
Arnav Bhatt
c17bcb65b9 [TRANSLATION] Hindi translation of SYSSETUP AND SAMSRV. (#1400) 2019-03-08 15:48:20 +01:00
Arnav Bhatt
3a85677531 Hindi translation of comdlg32. (#1391)
Hindi translation of comdlg32.
2019-03-07 10:05:08 +01:00
Timo Kreuzer
f5f6ea2965 [REACTOS] Fix 64 bit issues 2019-03-04 21:58:42 +01:00
Eric Kohl
ac73ba7db6 [MSV1_0] Check logon hours and workstation names on logon. Also return the machine name on logon and fix the LOGONSERVER environment variable. 2019-03-04 17:26:27 +01:00
Ged Murphy
0649f25b48 [SHELL32] Implement SHTestTokenMembership and forward IsUserAnAdmin to it
Moved to the bottom of the file with the other ros functions to help keep wine syncs easier.
2019-03-04 11:54:43 +00:00
Eric Kohl
6748d72c9f [MSV1_0] Export LsaApLogonUserEx2 instead of LsaApLogonUser and remove the outdated logon functions. 2019-03-04 10:20:10 +01:00
Eric Kohl
ef4ee94feb [LSASRV] LsapLogonUser: Support LsaTokenInformationNull logins. 2019-03-04 01:37:15 +01:00
Eric Kohl
96466710f8 [MSV1_0] LsaApLogonUser: Pass the Authenticating Authority to the caller. 2019-03-04 01:37:14 +01:00
Joachim Henze
1d7287288d [SHELL32] Update all languages RCs to fix possible text truncation CORE-15765
IDD_BROWSE_FOR_FOLDER displays text controlled by the calling applications in
IDC_BROWSE_FOR_FOLDER_TITLE. Its old height could lead to text truncation
for existing 3rd party apps.
The new height value for IDC_BROWSE_FOR_FOLDER_TITLE
was inspired by IDC with the same from dialog IDD_BROWSE_FOR_FOLDER_NEW.
I could change all languages to the same height,
as dimensions of the dialog and surrounding controls were same.
2019-03-03 02:23:34 +01:00
Joachim Henze
026c575577 [MSI] In dialogs show titlebar buttons CORE-15301
Import the Wine fix
https://source.winehq.org/git/wine.git/?a=commit;h=84e6b331918d57f39e20a3063b67eb7fc0876288
Many thanks to the fixes author Fabian Maurer.
2019-03-03 01:26:59 +01:00
Eric Kohl
e88a6b2053 [SETUPAPI] Implement CM_Next_Range() 2019-03-02 20:59:12 +01:00
Bișoc George
0bc8e2a5bb [COVERITY][SETUPAPI] Release the blocks of memory when done
pRange variable allocates blocks of memory from the heap by HeapAlloc() although this resource is never freed afterwards.

COVERITY CID 1427056
2019-03-02 20:39:09 +01:00
Pierre Schweitzer
6ee2f9882c
[MSAFD] Don't leak event while querying/setting socket options 2019-02-25 22:34:29 +01:00
Pierre Schweitzer
6bc61f63f1
[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF 2019-02-25 22:34:29 +01:00
Mark Jansen
5c05a29d3d
[APPHELP] Implement ShimDumpCache and ShimFlushCache
These functions simply call into the Base* functions,
having a prototype that is compatible with rundll32
CORE-11301
2019-02-25 20:00:34 +01:00
Luo Yufan
ca9cdce760 [TRANSLATION] Update Chinese and Traditional Chinese translations. (#1369) 2019-02-25 00:36:53 +01:00
Pierre Schweitzer
f6c50cb93d
[MSAFD] Make WSPSetSockOpt() SO_RCVBUF stub return success 2019-02-24 21:25:39 +01:00
Stanislav Motylkov
8c90a67da6 [MSGINA] Add bar bitmap to logon and shutdown dialogs 2019-02-24 15:52:49 +01:00
Stanislav Motylkov
fe1d611e0f [MSGINA] Improve Ctrl-Alt-Del invitation window 2019-02-24 15:52:49 +01:00
Stanislav Motylkov
f9d29319a6 [MSGINA] Implement rotation bar animation
Based on initial work by Bisoc George. Rotation bar image by Zcooger. CORE-15215
2019-02-24 15:52:49 +01:00
Pierre Schweitzer
d1598788cd
[WS2_32] Use SEH in WSCGetProviderPath() 2019-02-23 13:35:07 +01:00
Pierre Schweitzer
02e84521cc
[WS2_32] Implement WSCGetProviderPath() 2019-02-23 10:57:30 +01:00
Mark Jansen
860f96f431
[MSI] Prevent uninitialized variable usage 2019-02-18 23:00:54 +01:00
Mark Jansen
2fade6ede4
[MSI] Do not leak rootkey 2019-02-18 23:00:54 +01:00
Mark Jansen
d766391231
[SHELL32] Abort change notifications on a nullptr
CORE-15703
2019-02-18 23:00:31 +01:00
Thomas Faber
8dcdf82e71
[COMCTL32] Check for NULL pointer when handling BCM_GETIDEALSIZE.
Fixes crash in comctl32_winetest:button.
2019-02-17 09:51:18 +01:00
Thomas Faber
3445129dd3
[COMCTL32] Add NULL checks to SetWindowSubclass.
Imports Wine commit 04847e68f87 by Sven Baars.

Fixes crash in comctl32_winetest:subclass.
2019-02-17 09:51:16 +01:00
Pierre Schweitzer
db3f3921b6
[KERNEL32] Stub SetThreadErrorMode()
Now, Steam crashes because of the stub of GetSystemTimePreciseAsFileTime

CORE-14966
2019-02-16 14:12:55 +01:00
Pierre Schweitzer
2b1f6c8b0d
[MSAFD] Add an initial implementation of SIO_GET_EXTENSION_FUNCTION_POINTER IOCTL
Also stub the related functions the IOCTL will return, namely: WSAID_ACCEPTEX,
WSAID_CONNECTEX, WSAID_DISCONNECTEX, WSAID_GETACCEPTEXSOCKADDRS

This will allow Steam client not to fail in an ASSERT
related to the Steam client PlatformSocketsInit function.

Even though, this doesn't fix Steam running on ReactOS since its UI requires
a Windows 7 API from Kernel32: SetThreadErrorMode().

Nota: its crash got fixed thanks to the Wine sync done recently.

CORE-14966
2019-02-16 13:51:32 +01:00
Pierre Schweitzer
22cb300805
[IPHLPAPI] Properly handle GetModuleBaseName failure
CID 1442662, 1442663
2019-02-16 09:05:15 +01:00
Pierre Schweitzer
93b0957641
[IPHLPAPI] Check pointers when returning module info from specific connection 2019-02-16 09:00:06 +01:00
Pierre Schweitzer
22f60faf43
[IPHLPAPI] Remove dead code
CID 513306, 1442673, 1442697
2019-02-16 08:48:08 +01:00
Pierre Schweitzer
6295cc506e
[OOPS] That was not meant to be pushed/commited 2019-02-10 20:52:55 +01:00
Pierre Schweitzer
d2c71d761e
[CRYPTEX] Add French translation 2019-02-10 20:43:14 +01:00
Hermès Bélusca-Maïto
c0d97cec88
[NETCFGX] Fix an assignment typo. 2019-02-10 17:30:56 +01:00
Mark Jansen
0bdca09a85
[IPHLPAPI] Preserve decoration in exported symbols
CORE-8462
CORE-15665
2019-02-10 13:44:08 +01:00
Amine Khaldi
e98ef4992e [WINDOWSCODECS] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:12:26 +01:00
Amine Khaldi
46add00db5 [WBEMPROX] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:10:55 +01:00
Amine Khaldi
8786e12d13 [WBEMDISP] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:09:55 +01:00
Amine Khaldi
f8a6a70be1 [VERSION] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:09:00 +01:00
Amine Khaldi
72fa0fd6cc [VBSCRIPT] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:07:56 +01:00
Amine Khaldi
c0b82105b5 [USP10] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:06:21 +01:00
Amine Khaldi
ad73c0a040 [URLMON] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:04:30 +01:00
Amine Khaldi
9622551c51 [T2EMBED] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:03:27 +01:00
Amine Khaldi
8d3e69919b [SXS] Sync with Wine Staging 4.0. CORE-15682 2019-02-04 13:02:29 +01:00
Luo Yufan
96d1cd2b62 [TRANSLATION] Update Chinese translation. 2019-02-03 13:17:13 +01:00
Thomas Faber
1a14dcb53f
[RPCRT4][RPCRT4_WINETEST] Don't unset IDL_FLAGS. Fixes build on 64 bit hosts. 2019-02-02 19:06:04 +01:00
Eric Kohl
8687529bdf [SETUPAPI] Add a stub for SetupDiDeleteDeviceInterfaceData to make the wine tests work. 2019-02-02 15:13:35 +01:00
Amine Khaldi
876fef085a [SHDOCVW] Sync with Wine Staging 4.0. CORE-15682 2019-02-02 14:16:02 +01:00
Amine Khaldi
dbfaf10dc0 [RICHED20] Sync with Wine Staging 4.0. CORE-15682 2019-02-02 14:10:37 +01:00
Amine Khaldi
9ce8769f4e [QMGR] Sync with Wine Staging 4.0. CORE-15682 2019-02-02 13:30:06 +01:00
Amine Khaldi
ab64b47497 [PROPSYS] Sync with Wine Staging 4.0. CORE-15682 2019-02-02 13:28:11 +01:00
Amine Khaldi
59e9abd907 [PIDGEN] Sync with Wine Staging 4.0. CORE-15682 2019-02-02 13:27:41 +01:00
Amine Khaldi
c9de708a9b [PDH] Sync with Wine Staging 4.0. CORE-15682 2019-02-02 13:26:39 +01:00
Amine Khaldi
4abf2277a1 [OLEDLG] Sync with Wine Staging 4.0. CORE-15682 2019-02-02 13:25:12 +01:00
Thomas Faber
42b5f5ec06
[OLEAUT32] Add AMD64 version of call_double_method aka fix build. 2019-02-01 18:09:52 +01:00
Amine Khaldi
b6fdb56b9a [RPCRT4] Sync with Wine Staging 4.0. CORE-15682 2019-01-30 12:31:33 +01:00
Joachim Henze
1e05f9cc32 [COMCTL32] Revert "button: Don't erase the area of the checkbox or the text."
This reverts commit 0.4.12-dev-347-g
75a80ec823
by explcit request of Giannis Adamopoulos.

I double-checked and confirm, that
this revert fixes both regressions CORE-15595 & CORE-15696.
On the downside the revert will intensify again the regression CORE-13278
(will make the text flash again as well).

Giannis Adamopoulos mentioned earlier, that using double-buffering
eventually could be a valid way out of CORE-13278 instead.
2019-01-29 19:25:57 +01:00
Ștefan Fulea
092b67c723 [TRANSLATION] Improve the existing translated contents 2019-01-29 13:48:48 +01:00