Commit graph

3595 commits

Author SHA1 Message Date
Robert Naumann a0235bf877 [UXTHEME] Fix incorrect part IDs in button class map.
Wine Patch by Zhiyi Zhang. (Commit ec82a0ebe65a0bd9f41c743d301c853e77dd8b8b)
2021-08-01 12:22:58 +02:00
Katayama Hirofumi MZ d7f13aa696
[IMM32] Improve ImmSimulateHotKey (#3858)
- Improve ImmSimulateHotKey function.
- Modify IMEDPI structure.
CORE-11700
2021-07-31 15:56:11 +09:00
Katayama Hirofumi MZ 89cb8a38b3
[IMM32] Rewrite ImmEnumInputContext (#3859)
- Rewrite ImmEnumInputContext function.
- Modify NtUserBuildHimcList.
CORE-11700
2021-07-31 15:45:07 +09:00
Victor Perevertkin 49cfac17c5
[FFS] Remove the FFS/UFS driver
The upstream driver is not maintained and the file system itself
is in a semi-abandoned state.
Originally imported at 3a3ef631d1

The driver is written by Lee Jae-Hong, updated by Bo Brantén.
ReactOS porting made by Peter Hater and Pierre Schweitzer.
Follow updates at http://www.acc.umu.se/~bosse/

FS Recognizer code is left to keep the FS support as an
installable driver.

CORE-11040
2021-07-30 17:14:57 +03:00
Victor Perevertkin 2e2190df57
[REISERFS] Remove the ReiserFS driver
The upstream driver is not maintained and the file system itself
is in a semi-abandoned state.
Originally imported at e308102f4a

The driver is written by Mark W Piper, updated by Bo Brantén.
ReactOS porting made by Peter Hater and Pierre Schweitzer.
Follow updates at http://www.acc.umu.se/~bosse/

FS Recognizer code is left to keep the FS support as an
installable driver.

CORE-11005
2021-07-30 17:14:53 +03:00
Katayama Hirofumi MZ e996662afb [IMM32] s/idThread/dwThreadId/
- Rename idThread variable as dwThreadId.
- Rename idImeThread variable as dwImeThreadId.
CORE-11700
2021-07-29 08:21:33 +09:00
Katayama Hirofumi MZ f972a9fbd5
[IMM32] Rewrite ImmSetCompositionWindow (#3855)
Implementing Japanese input... CORE-11700
2021-07-28 23:26:02 +09:00
Katayama Hirofumi MZ 8e1dea0c8c
[IMM32] Implement ImmLoadLayout (#3854)
Implementing Japanese input... CORE-11700
2021-07-28 23:25:10 +09:00
Katayama Hirofumi MZ fb2aef9e4e
[IMM32] Rewrite ImmNotifyIME (#3853)
Implementing Japanese input... CORE-11700
2021-07-28 23:24:09 +09:00
Katayama Hirofumi MZ a71de262d3
[IMM32] Rewrite ImmSetStatusWindowPos (#3852)
Implementing Japanese input... CORE-11700
2021-07-28 23:23:09 +09:00
Katayama Hirofumi MZ ecb0c0963d
[IMM32] Imm(Lock|Unlock)ImeDpi and ImmSetOpenStatus (#3830)
- Add IMEDPI structure to ntuser.h.
- Implement ImmLockImeDpi/ImmUnlockImeDpi functions.
- Rewrite ImmSetOpenStatus function.
- Modify some NTUSER function prototypes.
- Modify imm32.spec.
CORE-11700
2021-07-25 11:57:57 +09:00
Katayama Hirofumi MZ 97847f2078
[IMM32] Improve ImmGetImeInfoEx (#3833)
- Rewrite ImmGetImeInfoEx function.
- Implement CtfImmIsTextFrameServiceDisabled function.
- Modify imm32.spec.
CORE-11700
2021-07-25 11:56:17 +09:00
Katayama Hirofumi MZ 5afc324359
[IMM32] Improve ImmUnlockClientImc and Imm32HeapAlloc (#3834)
- Fix Imm32HeapAlloc function.
- Fix ImmUnlockClientImc function.
CORE-11700
2021-07-25 11:55:03 +09:00
Joachim Henze c30b1fe893 [SHELL32] Update de-DE.rc in IDD_BROWSE_FOR_FOLDER_NEW
More space for the german text in that button.
Correct the keyboard accelerator.
2021-07-24 15:11:54 +02:00
Mark Jansen d039653959
[SHELL32] CDefView: Respect item attributes 2021-07-23 22:10:36 +02:00
Mark Jansen 91e63ee0b5
[FONTEXT] Cache attributes, handle sorting 2021-07-23 22:10:30 +02:00
Timo Kreuzer 41bc57ddf0 [REACTOS] Silence warnings in 3r-party code 2021-07-23 22:03:48 +02:00
Timo Kreuzer 5d8e834897 [REACTOS] Fix a number of MSVC warnings 2021-07-23 22:03:48 +02:00
Joachim Henze 6e177edbad [FONTEXT] Add de-DE translation CORE-17692 2021-07-19 00:33:39 +02:00
Joachim Henze 7b98717c6a [FONTEXT] Improve it-IT.rc comments
addendum to (#831)
2021-07-18 23:56:31 +02:00
Joachim Henze 1078340f5c [SYSSETUP] Update de-DE.rc
The buttons name on the last dialog of 2nd stage
is "Fertig" and not "Beenden".
So make the help-texts consistent with that.
2021-07-18 17:51:44 +02:00
Eric Kohl 4cae349811 [ADVAPI32][SERVICES] Use the context handle to encrypt and decrypt service passwords 2021-07-17 16:26:16 +02:00
Katayama Hirofumi MZ 3965c93732
[IMM32] Rewrite ImmGetStatusWindowPos (#3824)
Rewrite ImmGetStatusWindowPos function. CORE-11700
2021-07-16 07:30:55 +09:00
Katayama Hirofumi MZ 0966e32146
[IMM32] Rewrite ImmGetCandidateWindow (#3823)
Rewrite ImmGetCandidateWindow function. CORE-11700
2021-07-16 03:04:00 +09:00
Doug Lyons 34d5d1dbd4
[DDRAW] ddraw.c ddraw7_FlipToGDISurface() to Wine-6.8 (#3827) CORE-15128
fixes CORE-15128 "Fall 0.1.3, black controls all over the desktop after exiting the game"
which regressed by 0.4.9-dev-155-g 9987f02917
(the sync to Wine Staging 3.3)

the patch on top of 0.4.15-dev-2923-g2210d23:
KVM: https://reactos.org/testman/compare.php?ids=78290,78295 LGTM
VBox: https://reactos.org/testman/compare.php?ids=78291,78294 LGTM
2021-07-15 19:04:46 +02:00
Eric Kohl 228dab60da [SAMSRV] SamrQueryInformationDomain: Older functions should call new functions 2021-07-15 17:25:06 +02:00
Katayama Hirofumi MZ b06b628f30
[IMM32] Rewrite ImmGetIMEFileNameA/W (#3822)
- Rewrite ImmGetIMEFileNameA and ImmGetIMEFileNameW functions. CORE-11700
2021-07-15 23:01:50 +09:00
Katayama Hirofumi MZ 3714ee269b
[IMM32] Rewrite ImmGetDefaultIMEWnd (#3821)
- Rewrite ImmGetDefaultIMEWnd function.
- Add g_dwImm32Flags global variable.
- Add Imm32QueryWindow helper function.
- Implement CtfImmIsCiceroEnabled function.
- Modify imm32.spec.
CORE-11700
2021-07-15 21:59:53 +09:00
Eric Kohl 2210d23fc7 [NETAPI32] Return the old values for NetGetJoinInformation() to fix Chrome Installer regression
Should fix CORE-17679
2021-07-14 15:22:17 +02:00
Katayama Hirofumi MZ 192981a1fe
[IMM32] Rewrite ImmGetCompositionWindow (#3820)
Rewrite ImmGetCompositionWindow function. CORE-11700
2021-07-13 21:13:39 +09:00
Katayama Hirofumi MZ 1558e6d0b3
[IMM32] Rewrite ImmGetCompositionFontA/W (#3813)
- Rewrite ImmGetCompositionFontA and ImmGetCompositionFontW functions.
- Add INIT_* macro definitions in <ddk/imm.h>.
CORE-11700
2021-07-13 20:51:28 +09:00
Katayama Hirofumi MZ ee3b5b44c1
[IMM32] Rewrite ImmGetCandidateListCountA/W (#3812)
Implement ImmGetCandidateListCountA and ImmGetCandidateListCountW functions by using newly defined ImmGetCandidateListCountAW function. CORE-11700
2021-07-13 20:17:17 +09:00
Joachim Henze a5365194f4 [COMCTL32] Listview: Only apply horizontal offset when setting header position CORE-17674
This imports
Wine commit d92906249f (diff-7f0ae6301b1f6ea1128640b76cd831308e24466f15399de6d5040557b79f0f16)
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Thanks to Doug Lyons who picked the fix for us from Wine 6.0

It fixes for us CORE-17674 "Corruption of the listview header"
which regressed by 0.4.14-dev-150-g 00f14ee1f2
when we synced to Wine Staging 4.18

Testbot results of the patch:
KVM https://reactos.org/testman/compare.php?ids=78225,78270 LGTM
VBox https://reactos.org/testman/compare.php?ids=78226,78271 LGTM

I intend to port this back into 0.4.14RC94 also, so no official reactos release
will ever be affected by it.
2021-07-13 07:38:45 +02:00
Hervé Poussineau a6005299c6 [DESK] Only try to restart graphic device after installation
If it fails, require a reboot.

CORE-17675
2021-07-12 23:51:39 +02:00
Eric Kohl ccde294b24 [SAMSRV] Older functions should call newer functions 2021-07-11 12:54:28 +02:00
Katayama Hirofumi MZ e2d8837986
[BROWSEUI] Multithreaded auto-completion (#3794)
- Make auto-completion multi-threaded.
CORE-9281
2021-07-11 13:00:00 +09:00
Katayama Hirofumi MZ 92393a7517
[IMM32] Add some candidate handlings (#3799)
- Implement ImmGetCandidateListA and ImmGetCandidateListW, by using newly added ImmGetCandidateListAW function.
- Implement ImmLockClientImc and ImmUnlockClientImc functions.
- Modify imm32.spec.
- Remove #ifdef's.
CORE-11700
2021-07-11 09:48:15 +09:00
Hervé Poussineau c3da00c42c [DESK] Start video card after its installation + let win32k detect it 2021-07-10 16:27:44 +02:00
Robert Naumann 65387805a0
Add/Update German translation (#3805)
Add translations for:

- [CHARMAP_NEW]
- [COMP]
- [EVENTCREATE]
- [TIMEOUT]
- [WHERE]
- [UTILMAN]
- [CHKDSK]
- [SHELLEXT]: cryptext, devcpux, mycomp, netplwiz
- [MSXML3R]
- [THEMES]: Blackshade, Lunar

Update translations for:

- [CLIPBRD]
- [SHORTCUTS.INF]
2021-07-09 11:15:34 +02:00
Eric Kohl 7faca935e6 [SETUPAPI] PNP_RegisterNotification: Parameter 8 seems to be a process ID 2021-07-08 10:58:47 +02:00
Katayama Hirofumi MZ 5c624d40e7
[IMM32] Rewrite ImmGetOpenStatus (#3804)
- Rewrite ImmGetOpenStatus function. CORE-11700
2021-07-08 14:24:27 +09:00
Katayama Hirofumi MZ 211de1257e
[IMM32] Rewrite ImmIsIME (Retry) (#3803)
- Rewrite ImmIsIME function.
- Fix enum IMEINFOEXCLASS.
CORE-11700
2021-07-08 14:23:25 +09:00
Katayama Hirofumi MZ 6eeea92530
[IMM32] Rewrite IMCC handling functions (#3788)
Rewrite ImmCreateIMCC, ImmDestroyIMCC, ImmReSizeIMCC, ImmGetIMCCLockCount, ImmUnlockIMCC, ImmLockIMCC, and ImmGetIMCCSize functions. CORE-11700
2021-07-07 10:04:30 +09:00
Joachim Henze 7962db4cc1 [NETSHELL] Fix MSVC compiler warning in de-DE.rc
MSVC2010 compiler warning shellext\netshell\lang/de-DE.rc(118) : warning RC4206 : title string too long; truncated at 256
introduced by SVN r71434 == git 6ce8ee357a

The string was displayed properly and was not truncated even before this patch.
2021-07-07 01:51:33 +02:00
Joachim Henze 2cbb3ebdcb [SHELL32] EOL-white-space-fixes dialogs.cpp
Exclusively touching code that was recently
added during 0.4.15-dev'ing.
2021-07-06 23:27:32 +02:00
Doug Lyons 33c7c91b36
[SHELL32] Improve Start-Run Dialog Box Features (#3797) CORE-17351 CORE-16898
Improve performance of Start-Run Dialog Box Options

This will fix:
CORE-17351 'RunDlg fails calling URL without http'
and
CORE-16898 'RunCommand "iexplore" fails to open Wine IE'
Both regressed by 0.4.10-dev-419-g bfcbda227f
2021-07-06 19:36:15 +02:00
Joachim Henze 728f90dd18 [DESK] Update de-DE.rc regarding IDC_ADVAPPEARANCE_DISCLAIMER
It was recently added during 0.4.15-dev'ing.
2021-07-06 10:59:03 +02:00
Serge Gautherie 513f3d179c [NTDLL] LdrpWalkImportDescriptor(): Fix 'Status' copypasta
Addendum to f6cd52a (r70646).
2021-07-06 08:26:26 +02:00
Katayama Hirofumi MZ c238b554b1
[IMM32] Rewrite ImmGetConversionStatus (#3790)
Implementing Japanese input... CORE-11700
2021-07-05 21:20:20 +09:00
Eric Kohl fb8edf90a0 [SAMSRV] Start work on the display cache
Initialize the cache and fill it on demand
2021-07-04 12:45:19 +02:00
Eric Kohl 556cef5be3 [SAMLIB] Add function names to trace messages 2021-07-04 12:31:22 +02:00
Katayama Hirofumi MZ 89f5f5bb95
[IMM32] Rewrite ImmGetDescriptionA/W (#3780)
CORE-11700
2021-07-04 08:18:15 +09:00
Eric Kohl bf05fcbd29 [SAMSRV] Older functions should call newer functions 2021-07-03 14:46:32 +02:00
Timo Kreuzer adc86c2442 [NETAPI32] Zero out lpNameBuffer in NetGetJoinInformation
This is needed, because for some reason, otherwise RPCRT4 will assume that whatever value is in there is already the buffer and copy the string there.
Fixes exception in Chrome 48.
2021-07-03 12:56:48 +02:00
Katayama Hirofumi MZ 650cd77234
[IMM32] ImmDisableIME calls NtUserDisableThreadIme (#3776)
- Just call NtUserDisableThreadIme in ImmDisableIME directly. CORE-11700
2021-07-01 18:03:42 +09:00
Katayama Hirofumi MZ 561fa8d29b
[SHELL32] Implement PathResolveA function (#3771)
- Follow-up of #3762.
- Add PathResolveA implementation by ANSI/Unicode string conversion.
CORE-12665
2021-07-01 08:42:29 +09:00
Hermès Bélusca-Maïto e7a5850d65
Revert "[SHELL32] Don't check for link files being targets for other link files. Addendum to 3a822e4f."
This reverts commit 3249a00364.
2021-06-28 04:11:00 +02:00
Hermès Bélusca-Maïto 3199fdbd44 [SHLWAPI] Fix a trivial bug in PathFileExistsDefExtW() that seems to exist since 16+ years in Wine.
Suppose dwFlags == 1 | 4 (i.e. skipping the flag 2).
Then the while-loop would only run once, because at the second iteration
(after dwWhich >>= 1; has been executed once), dwWhich value == 2, but
dwWhich & 0x1 == 0, which makes the while-loop condition false.
Instead the loop should run, but the handling of the extension should be
skipped.
2021-06-28 02:19:31 +02:00
Hermès Bélusca-Maïto 8ec3580123 [SHELL32] Add the handy WHICH_DEFAULT value to the list of flags in shlwapi_undoc.h.
- Add as well the undocumented 0x40 dwFlags value from shlwapi!PathFileExistsDefExtW()
  to the list.

- Fix a bug (also present in Win2k3) in PathResolveW() where, specifying
  the PRF_DONTFINDLNK flag, would also erroneously exclude checking for
  the .cmd extension as well (which was obviously NOT the original
  intention, from the name of the flag and the documentation as well:
  https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-pathresolve
  ).

Addendum to 3a822e4f.
2021-06-28 02:19:30 +02:00
Hermès Bélusca-Maïto 3249a00364 [SHELL32] Don't check for link files being targets for other link files. Addendum to 3a822e4f. 2021-06-28 02:19:30 +02:00
Joachim Henze adee5ca255 [COMCTL32] Addendum to last commit (#3674) CORE-17199
Keep that section like we had it to
support compilation on VS2010.
It does still work like that.

Addendum to commit 0.4.15-dev-2796-g e382b7bc35
2021-06-28 02:05:56 +02:00
Doug Lyons e382b7bc35
[COMCTL32] Sync datetime.c to Wine-6.0 (#3674) CORE-17199
Fix automatic toggling of date display on second stage setup
Update comctrl from Wine with fix.

Sync datetime.c to Wine-6.0
2021-06-28 01:18:10 +02:00
Katayama Hirofumi MZ 3a822e4f74
[SHELL32] Implement PathResolveW function (#3762)
- Implement PathResolveW function.
- Implement PathQualifyA/W functions using newly-defined PathQualifyExW function.
CORE-12665
2021-06-28 07:53:26 +09:00
Joachim Henze 81f8bcea8c [DSOUND][WAVE] Workaround crash when recording sound in Scratch 1.4 CORE-13202
It regressed by SVN r44721 == git 356d4bab16092de335705e02b0e87698ec35c393
when #define USE_MMIXER_LIB was removed.

Thanks to the patches author Doug Lyons.

VBox https://reactos.org/testman/compare.php?ids=77914,77919 LGTM
 KVM https://reactos.org/testman/compare.php?ids=77913,77918 LGTM
2021-06-27 23:04:36 +02:00
Eric Kohl 37f38a80de [SAMSRV] Fix call to SamrCloseHandle in SamrGetDomainPasswordInformation 2021-06-21 21:38:42 +02:00
Eric Kohl be65a8568b [SAMLIB] Check the server name in the binding routine 2021-06-19 21:51:06 +02:00
Eric Kohl 5b6e8af1bd [SAMLIB] SamConnect: Pass a zero-terminated server name to SamrConnect 2021-06-19 20:29:24 +02:00
Joachim Henze d042f51838 [LDR] Restore Logging when images overlap CORE-17635
This reverts
0.4.13-dev-284-g 74be88ac47

The logging is helpful to alert us when we should really
recalculate the base addresses for performance reasons.
Spams a bit sometimes, sure, but it's worth it!
2021-06-16 13:38:51 +02:00
Joachim Henze a3cadf630a [COMCTL32] Strip EOL whitespace within ifdef __REACTOS__ section
no functional change.
Make that look beautiful before porting it back further.

Addendum to 0.4.15-dev-534-g 887764e607
(CORE-17062)
2021-06-16 11:41:56 +02:00
Joachim Henze d5265b07bb [MSI] Enumerate only type DRIVE_FIXED CORE-17623 (& CORE-14432)
MSI on 2k3sp2 hides empty CD-ROM, and hides CD-ROM with iso mounted.
MSI on 2k3sp2 hides VBox shares, both: writable and read-only-ones.
MSI on 2k3sp2 hides floppy drives with a floppy img mounted.
MSI on XPSP3 hides a mounted writable USB stick.

Thanks to the patches author Doug Lyons.

This patch supersedes
0.4.15-dev-2651-g 864e20b881 (CORE-14432)
and we are also better than Wines
0dd0d879a1
2021-06-13 15:30:49 +02:00
Katayama Hirofumi MZ 46c84779b6 [CPL][APPWIZ] Follow-up of #3726
Sorry, #3726 doesn't fix CORE-5737. CORE-17550
2021-06-07 18:03:49 +09:00
Eric Kohl 6ae7fc2b04 [LSASRV] Notify all authentication packages of a session to be deleted 2021-06-06 11:38:26 +02:00
Mark Jansen 1d68fe209f
[SYSSETUP] Use the calculated full path 2021-06-05 22:14:34 +02:00
Joachim Henze 864e20b881 [MSI] setup should not enumerate read-only CDRoms as install-targets CORE-14432
We decided to check a bit different than Wine currently does.
Wine checks for
if (GetVolumeInformationW(ptr, NULL, 0, NULL, 0, &flags, NULL, 0) && flags & FILE_READ_ONLY_VOLUME)
to exclude read-only-media while we (for now) check for
if (GetDriveTypeW(ptr) == DRIVE_CDROM)

For now this gives us the benefit of covering also CDROM drives, that do not have
a CD put into it.
That does not work properly for us with the Wine patch yet, but it does for Wine!
So this maybe points to some other bug in ros, maybe in our CDROM(FS)-drivers?

In the future we should also test this on other read-only-media in Windows e.g.
a read-only USB stick to decide whether we want to stick with our current solution
or whether we want to switch to Wines solution or whether we want to logically OR
both conditions!

Thanks to Doug Lyons for providing what *currently* does work best for us!

VBox https://reactos.org/testman/compare.php?ids=77537,77546 (no change)
KVM https://reactos.org/testman/compare.php?ids=77531,77541 (no change)
2021-06-05 21:27:40 +02:00
Serge Gautherie 83fcd65700
[MPR] spec: Add stubs, document parameter types, stub-enable 2 functions (#3696)
* Add 20 stubs from mpr.dll v5.2.3790.3959.
* Document some parameter types from https://github.com/Microsoft/winfile/
* Change WNetGetDirectoryType[A|W] to no-op stubs

CORE-14376
2021-06-05 20:49:41 +02:00
Katayama Hirofumi MZ 2106bc4a81
[CPL][APPWIZ] Make gecko download cancellable by keyboard (#3726)
We shouldn't disable nor hide the control with focus. CORE-17550, CORE-5737
2021-06-05 18:21:25 +09:00
Timo Kreuzer 11ffa31155 [BROWSEUI] Fix broken code 2021-06-04 09:15:55 +02:00
Piotr Hetnarowicz 4771551c74
[BROWSEUI] Polish translation update (#3703) 2021-06-02 11:53:07 +02:00
Piotr Hetnarowicz d05a20e7b3
[SHELL32] Polish translation update (#3701) 2021-06-02 11:50:54 +02:00
Eric Kohl 7b970c67a8 [NETCFGX] Create unique network connection names 2021-05-30 21:12:58 +02:00
Mark Jansen f0bee6c4bc
[SHELL32] CDefView: Prevent use after free
While updating the item, the LVIF_STATE would be requested,
for which the old lParam would be accessed.
2021-05-26 22:57:43 +02:00
Eric Kohl 894cc4ac0c [dnsapi][dnsrslvr] Implement DnsFlushResolverCacheEntry_A/_UTF8/_W 2021-05-24 14:43:30 +02:00
Mark Jansen 9fcdc68182
[SHELL32] Include the folder path in logging 2021-05-22 16:34:54 +02:00
Mark Jansen b58c3d73ca
[RTL][KERNEL32] Move the STUB printing code to a place where it's actually called 2021-05-22 16:33:19 +02:00
Joachim Henze cf6c191f69 [SHELL32] *.rc Whitespace fixes just, no functional change
Motivation to fix them in master is to avoid having to also port them back
when porting back nearby code.
2021-05-15 03:44:48 +02:00
Max Korostil 7fd004e50b
[SDBINST] Add uninstall option 2021-05-08 14:24:20 +02:00
Max Korostil b1dfdc95af
[APPHELP] Add api functions declaration.
Add define
2021-05-08 14:24:20 +02:00
Catalin Gabriel Draghita 2636cff09f
[SHELL32] Show Product version on About dialog bmp (#3621)
The About dialog banner will now show the correspondent Product version selected on install.
This will make it easier to tell which edition of ReactOS is installed.
2021-05-08 15:54:32 +09:00
Hermès Bélusca-Maïto ab8d7f2548
[SYSDM] Fix uninitialized variables warnings detected by Clang. (#3619)
CORE-17545

Addendum to commit d635ce0c.

dll/cpl/sysdm/general.c:156:25: warning: variable 'hCreditsDC' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
                    if (hDC == NULL)
                        ^~~~~~~~~~~
dll/cpl/sysdm/general.c:216:25: note: uninitialized use occurs here
                    if (hCreditsDC != NULL) DeleteDC(hCreditsDC);
                        ^~~~~~~~~~

and the same for hLogoDC:

dll/cpl/sysdm/general.c:215:25: note: uninitialized use occurs here
                    if (hLogoDC != NULL) DeleteDC(hLogoDC);
                        ^~~~~~~
2021-05-05 17:24:11 +02:00
Hermès Bélusca-Maïto cba0d64645
[SYSDM][USERINIT] Fix uninitialized variables warnings detected by Clang. (#3619)
CORE-17545

Addendum to commit d635ce0c.

- Move the HDC variables initialization via function calls, out of
  the variables declaration block.

- Fix warnings (and identical for base/system/userinit/livecd.c):

dll/cpl/sysdm/general.c:72:9: warning: variable 'hLogo' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (hDC == NULL || hDCLogo == NULL || hDCMask == NULL)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/cpl/sysdm/general.c:130:9: note: uninitialized use occurs here
    if (hLogo != NULL) DeleteObject(hLogo);
        ^~~~~

and similar for hMask too:

dll/cpl/sysdm/general.c:129:9: note: uninitialized use occurs here
    if (hMask != NULL) DeleteObject(hMask);
        ^~~~~
2021-05-05 17:24:10 +02:00
Hermès Bélusca-Maïto 89860ab543
[SYSDM][USERINIT] Rewrite a if-condition in order to fail early, and save one level of code indentation. 2021-05-05 17:24:10 +02:00
Mas Ahmad Muhammad fd4d8f550c [TRANSLATION] indonesian add and update apps/shell translation 2021-05-05 11:34:28 +02:00
Jérôme Gardou 523912536e [KERNEL32] Sync NLS RC files with wine 6.7
Mostly for having them UTF-8 encoded
2021-05-03 22:00:57 +02:00
Jérôme Gardou 061c7ecb1a [FRAMEDYN] Fix the whole situation with regards to wchar_t
Alias CHSTRING_WCHAR to unsigned short and use inline wrappers
to be able to use the thing with modern compilers

Put the GCC aliases into the public header.

Enable build with clang-cl
2021-05-03 22:00:57 +02:00
Serge Gautherie 249f2388bd
[REACTOS] Fix parameter types on some exports (#3217)
Fix some wrong parameter types on some exports in NTDLL, KERNEL32, WTSAPI32, and NTOSKRNL.
2021-05-01 21:11:34 +02:00
Jérôme Gardou e470b58376 [REACTOS] Explicitly link against pseh & include pseh headers in a few places 2021-04-28 13:10:23 +02:00
Jérôme Gardou 9ef5a7eb7a [CMAKE] Fix compilation with newer windres versions
Also use clang as preprocessor when using it
Also, use *our* headers instead of the platform ones
2021-04-27 11:54:12 +02:00
Omer Itzic Schwartz 5582fb30a5
[JOY] Update Hebrew (he-IL) translation (#3563) 2021-04-27 10:52:09 +03:00
Hermès Bélusca-Maïto 869a914cfd
[SYSSETUP] Forgot to update the ROS banner after 2021. Addendum to b570fac1. 2021-04-26 02:21:59 +02:00
Eric Kohl 9cdd53ffeb [MMSYS] Implement ShowAudioPropertySheet() and ShowFullControlPanel() 2021-04-25 19:04:35 +02:00
Serge Gautherie db416e3914 [REACTOS] InitImageList(): Fix error checks
And simplify code a bit.
2021-04-24 20:35:48 +02:00
Serge Gautherie a120d67d0e [USRMGR] Increase name sizes to 'UNLEN + 1' 2021-04-24 20:30:58 +02:00
George Bișoc 1cf1892b14
[COMCTL32] Fix an incorrect returned value for ImageList_Remove
Thanks goes to Kyle Katarn. Had to make a commit myself due to author's account being deleted.

Signed-off-by: Kyle Katarn <contact@kcsoftwares.com>
2021-04-24 20:13:56 +02:00
George Bișoc 84b3fecb26
[MSGINA] Determine which kind of dialog box is before terminating it
Do a sanity check onto the dialog box type before terminating it. As it stands now, a call of PostQuitMessage() is invoked even when the dialog box is modal. This is illegal due to the fact that the shutdown dialog box is initiated by the "Security" main window thus WlxDialogBoxParam.

A call to PostQuitMessage onto a modal dialog box leads to a undefined behaviour, as it'll not just terminate the thread but also eventually killing the Winlogon process whose the thread belongs to.
CORE-17535
2021-04-22 13:30:55 +02:00
Eric Kohl 32428a39ed [NEWDEV] Set the CM_PROB_FAILED_INSTALL problem code on failed install
CORE-17527
2021-04-20 22:00:41 +02:00
Serge Gautherie 0dedb9b474
[WINLOGON][MPR][SDK] WNetClearConnections: Fix function parameter type (#3480)
Addendum to 62f79fae93.

Signed-off-by: Serge Gautherie <reactos-git_serge_171003@gautherie.fr>
2021-04-18 21:58:44 +03:00
Hervé Poussineau af9df93274 [WS2_32] Create registry keys Protocol_Catalog9/NameSpace_Catalog5 if needed
This fixes networking in LiveCD and installation in 2nd stage.
CORE-17514
2021-04-17 23:57:41 +02:00
Eric Kohl 9e947e2b2b [DEVMGR] Get rid of the unknown device class hack
Treat the unknown device class like any other device class.

CORE-17527
2021-04-16 23:45:08 +02:00
Eric Kohl 3fa57b8ff7 [NEWDEV] When a device install fails, set the 'Unknown' device class for that device
CORE-17527
2021-04-15 21:49:32 +02:00
Serge Gautherie 1758c3831b [MSHTML] MSVC: There is no 'error C4028' anymore
MSVC amd64
'...\dll\win32\mshtml\nsio.c(3755): error C4028: formal parameter 3 different from declaration'
was fixed by 5ed1867.

CORE-7538
2021-04-14 20:55:57 +02:00
Tibor Lajos Füzi ea04edce2d [TRANSLATION] Add/update Hungarian translation for solitaire, spider solitaire, rapps, usetup, cpl/timedate, shell32, user32 2021-04-14 16:16:24 +02:00
Hervé Poussineau e044df8736 [SETUPAPI] Correctly enumerate non-installed devices in SetupDiGetClassDevsExW
Always try to read the correct device GUID from registry, even if GUID filter is disabled.

CORE-17527
2021-04-11 15:12:02 +02:00
Hervé Poussineau f9df7af28a [SETUPAPI] Reimplement SetupDiBuildClassInfoListExW using CM_* functions
We can now enumerate device classes on other computers.
2021-04-11 15:12:02 +02:00
Hervé Poussineau 8da00cd97c [SETUPAPI] Fix CM_Open_Class_Key_ExW, when pClassGuid is used
Braces around GUID were missing.
2021-04-11 15:12:02 +02:00
Chan Chilung 6b700c6af1
[TRANSLATION] Chinese Traditional (zh-TW) translation update (#3526)
*Add Chinese Traditional translation for:
- [THEMES]
- [HIVESFT]
- [HIVEDEF]
- [HIVECLS]
- [SCREENSAVERS]
- [VGAFONTEDIT]
- [KERNEL32]
- [TASKLIST]
- [MYDOCS]
- [MSXML3R]
- INFs

*Chinese Traditional translation update for:
PR 3399
- [MSGINA]
- [SHELL32]

PR 3422
- [SOLITAIRE]

Others...

*Wine translation sync
2021-04-11 10:59:19 +02:00
George Bișoc 2ae526a039
[SHELL32] Do not format the partition if it's a system drive
Implement a sanity check helper which determines if the partition is a system drive or not based on the %SystemDrive% environment variable, preventing the user from nuking accidentally the partition with ReactOS system files installed. :P

NOTE: This code serves as a temporary measure to prevent accidental formatting of the system drive. In the future most of this code has to be totally rewritten (and stopping syncing with WINE altogether) as well as FMIFS library code so that we're on par in terms of compatibility with Windows.
2021-04-10 17:38:23 +02:00
Eric Kohl c2757032c8 [DEVMGR] Use FlagsEx to check for DI_FLAGSEX_POWERPAGE_ADDED 2021-04-10 16:22:47 +02:00
Eric Kohl ab0bbeb126 [DEVMGR] UpdateDevInfo: Enable built-in property pages by default
CORE-17532
2021-04-10 15:50:37 +02:00
Victor Perevertkin 74ec94e12c [CMAKE] Some options are only supported by GCC, don't use them for clang
These are (so far):
-Wno-format-overflow
-Wno-nonnull-compare
-Wno-old-style-declaration
-Wno-unused-but-set-variable
2021-04-09 03:58:19 +03:00
Mark Jansen 2587d72ef7 [WINSXS] Add some amd64 manifests
Co-authored-by: Timo Kreuzer <timo.kreuzer@reactos.org>
2021-04-08 20:48:24 +03:00
Katayama Hirofumi MZ 773ad7aebc
[BROWSEUI] auto-completion: Support large number items (#3592)
If the items are too many, enable filtering in item enumeration. CORE-9281
2021-04-08 15:02:05 +09:00
Eric Kohl e4646bc5d1 [SETUPAPI] SetupDiInstallDevice: Do not fail if the .inf file does not have a .Services section
CORE-17530
2021-04-07 21:39:55 +02:00
Hervé Poussineau 4d25869e0e [SYSSETUP] Manually start PlugPlay service, and wait for it before continuing
That way, class installers are already registered before installing devices.

CORE-17538
2021-04-07 19:35:50 +02:00
Katayama Hirofumi MZ 2fd058dce6
[BROWSEUI] Reduce IAutoComplete failures (#3590)
- Delete OnEditUpdate method.
- Improve the expand condition.
CORE-9281
2021-04-07 13:38:22 +09:00
Katayama Hirofumi MZ 2eaf0afcd2
[BROWSEUI] auto-completion: Reduce failures in ACListISF (#3589)
Reduce failures in ACListISF testcase. Skip left space in auto-completion. Accept the pair of drive letter and colon. CORE-9281
2021-04-06 21:56:40 +09:00
Katayama Hirofumi MZ fefac1fb1d [BROWSEUI] Accept environment variables in ACLO_FILESYSDIRS
Properly handle ACLO_FILESYSDIRS. CORE-9281
2021-04-05 22:20:01 +09:00
Katayama Hirofumi MZ badcfb2f7d [BROWSEUI] Accept environment variables on auto-completion
Expand %WINDIR%, %SystemRoot% etc. at CACListISF::Expand. CORE-9281
2021-04-05 17:20:35 +09:00
Katayama Hirofumi MZ a5950308fd [BROWSEUI] Follow-up of #3582
Also fixes VK_HOME and VK_END. CORE-9281
2021-04-05 07:43:40 +09:00
Katayama Hirofumi MZ ab7d8f3616
[BROWSEUI][BROWSEUI_APITEST] Add CLSID_ACLHistory stubs (#3582)
- Initial implement CLSID_ACLHistory as stub.
- Add IACLHistory testcase into browseui_apitest.
CORE-9281
2021-04-05 04:20:18 +09:00
Eric Kohl 6c4b4a107b [DEVMGR] Display hexadecimal values of Capabilities, ConfigFlags, DevnodeFlags and CsFlags 2021-04-04 11:44:38 +02:00
Serge Gautherie 28dadda8be [CMAKE] Properly generate all Bison and Flex files at build time
This fully reverts 09c4d0a.

Addendum to 5375e33.
CORE-15991
2021-04-03 21:50:08 +03:00
Katayama Hirofumi MZ 206156fad5
[BROWSEUI] Fix auto-completion on relative paths (#3578)
Fix the CLSID_ACListISF object about relative paths. If the given path is relative at CACListISF::Expand, then convert it to a full path. CORE-9281
2021-04-03 20:38:25 +09:00
Hervé Poussineau 4712deb8a8 [SETUPAPI] Fix wrong buffer size given to CM_Get_Device_ID_List_ExW
This buffer overflow was introduced in previous commit.
2021-04-03 00:52:01 +02:00
Hervé Poussineau 0f3133c308 [SETUPAPI] Use CM_* functions to get list of devices
- this prevents duplicating the code with umpnpmgr::PNP_GetDeviceList
- we can enumerate devices on other computers

This is part of the bugfix for CORE-17529
2021-04-02 21:41:09 +02:00
Katayama Hirofumi MZ ade5413362
[SHELL32] Auto-completion on Properties for Shortcut (#3574)
Enable auto-completion on "Properties for Shortcut files". CORE-9281
2021-04-02 17:04:43 +09:00
Katayama Hirofumi MZ 62b13979f5
[NEWDEV] Enable auto-completion on Hardware Wizard (#3573)
Realize auto-completion on Hardware Wizard. CORE-9281
2021-04-02 11:06:01 +09:00
Katayama Hirofumi MZ b591bd3354 [NEWDEV] Use new UI dialog for browsing folder
Add BIF_USENEWUI flag to BROWSEINFO. CORE-9281
2021-04-02 08:58:09 +09:00
Katayama Hirofumi MZ bebdfda8b7
[NOTEPAD][WORDPAD][MSPAINT]... Use newer file open dialog (#3571)
Use new-style file open/save-as dialog.
- Add OFN_EXPLORER flag to OPENFILENAME structure in notepad, wordpad, mspaint, clipbrd, mmc, mplay32, mscutils, regedit, winhlp32, progman, shellbtrfs, cryptui, shell32, setupapi, vgafontedit, infinst, and vfdlib modules.
2021-04-01 22:50:32 +09:00
Katayama Hirofumi MZ 7e6550b35e
[COMDLG32] Enable auto-completion on comdlg32 (#3564)
Auto-completion will be enabled when the user opens "Open" or "Save As" dialog of the common dialogs. CORE-9281

NOTE: The relative pathes, "..\" and "\" are not working. Those are bugs in CLSID_ACListISF.
2021-04-01 06:41:24 +09:00
Katayama Hirofumi MZ 91e591b3d5
[BROWSEUI] Enable AutoAppend of auto-completion (#3552)
Fix and improve Auto-Append of auto-completion. CORE-9281
- Implement CAutoComplete::DoAutoAppend method.
2021-03-30 06:50:32 +09:00
Katayama Hirofumi MZ d5c72a2e09
[BROWSEUI] Support ACO_USETAB and SHACF_USETAB on auto-completion (#3549)
Support Tab key on auto-completion. CORE-9281
2021-03-25 07:42:24 +09:00
Serge Gautherie ca1814f2c9 [SYSSETUP] security.c: Remove 3 useless casts
And
* Make 1 cast more explicit.
* Fix 1 'SamSetInformationUser' copypasta in DPRINT1() text.
* Optimize 1 '.MaximumLength' assignment.
2021-03-24 12:15:55 +01:00
Serge Gautherie 4cd92f0d01
[SYSSETUP][TIMEDATE] Use exact setTimer() timeouts, to stay in sync (#3355)
CORE-13121
2021-03-21 12:01:22 +09:00
Katayama Hirofumi MZ 53005587f4
[BROWSEUI] Fix return value on sanity check of auto-completion (#3544)
Reduce failures on sanity check of auto-completion. CORE-9281
- Return E_FAIL rather than E_INVALIDARG in sanity check of CAutoComplete::Init (IAutoComplete::Init).
2021-03-20 14:04:02 +09:00
Katayama Hirofumi MZ f49c164428
[BROWSEUI] Fix auto-completion on VK_DELETE (#3543)
Reduce failures against Delete key on auto-completion. CORE-9281
2021-03-20 13:18:47 +09:00
Mark Jansen 4885c34fa8
[SYSSETUP] SamQueryInformationUser expects a pointer 2021-03-20 00:28:07 +01:00
Piotr Hetnarowicz e264c3b3f2 Update dll/cpl/hdwwiz/lang/pl-PL.rc
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
2021-03-19 22:49:47 +01:00
Piotr Hetnarowicz edc314e741 Update dll/cpl/hdwwiz/lang/pl-PL.rc
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
2021-03-19 22:49:47 +01:00
Piotr Hetnarowicz a9a6f6e163 Update pl-PL.rc 2021-03-19 22:49:47 +01:00
Piotr Hetnarowicz 9114bd9882 [MMSYSCPL] Update Polish [pl-PL] translation 2021-03-19 22:47:19 +01:00
Katayama Hirofumi MZ 880252fd46 [SHELL32] Fix assertion failure in CDirectoryWatcher.cpp
CORE-17511
2021-03-19 08:30:10 +09:00
Mark Jansen c59ab8fce1 [SYSSETUP] SamQueryInformationDomain expects a pointer 2021-03-18 23:28:17 +01:00
Jérôme Gardou 0d41593749 [WS2_32] Check that the handle table is initialized before accessing it. 2021-03-17 18:53:12 +01:00
Katayama Hirofumi MZ b66bdef370
[SHELL32] Enable auto-completion on SHBrowseForFolder (#3535)
This PR realizes auto-completion on SHBrowseForFolder. CORE-9281

- Call SHAutoComplete in WM_INITDIALOG message handling.
- Fix focus.
- Remove ES_NOHIDESEL style.
- Fix layout initialization.
2021-03-15 16:30:32 +09:00
Katayama Hirofumi MZ 2d066c93fe
[SHELL32] Fix SHBrowseForFolder new UI layout (#3533)
CORE-17507

- Change layout of resource dialogs IDD_BROWSE_FOR_FOLDER_NEW.
- Delete IDC_BROWSE_FOR_FOLDER_FOLDER control.
- Fix focus.
- Add ES_NOHIDESEL style to IDC_BROWSE_FOR_FOLDER_FOLDER_TEXT control.
- Add TVS_SHOWSELALWAYS style to IDC_BROWSE_FOR_FOLDER_TREEVIEW control.
- Fix assertion failure in LayoutUpdate function in <layout.h>.
2021-03-15 07:13:03 +09:00
Katayama Hirofumi MZ e1a5ba188e
[SHELL32] SHBrowseForFolder with BIF_EDITBOX should use new UI (#3532)
CORE-17506

- Convert some judgements against BIF_NEWDIALOGSTYLE to judgements against BIF_USENEWUI. Here BIF_USENEWUI == (BIF_NEWDIALOGSTYLE | BIF_EDITBOX).
- Remove WS_SIZEBOX window style from new UI dialog resource (IDD_BROWSE_FOR_FOLDER_NEW).
- Fix header layout.h for resizing without WS_SIZEBOX.
2021-03-14 18:35:40 +09:00
Katayama Hirofumi MZ 9259ded8ae
[ATL][SHELL32][EXPLORER] Disable ATLASSERT (#3527)
We are not ready for enabling ATLASSERT. Enabling ATL assertions takes time to realize. CORE-17505
- Disable ATLASSERT by undefining _DEBUG.
- Revert currently non-fixable codes.
2021-03-11 20:26:45 +09:00
Katayama Hirofumi MZ 4583eae4f7 [SHELL32] Fix CMenuToolbarBase
CORE-17505
2021-03-11 17:51:47 +09:00
Katayama Hirofumi MZ 6546ad7700 [BROWSEUI] Fix CACListISF::Next assertion
CORE-9281
2021-03-11 17:12:06 +09:00
Katayama Hirofumi MZ bcba930622 [BROWSEUI] Fix CAutoComplete::OnMeasureItem assertion
CORE-17505
2021-03-11 16:56:01 +09:00
Katayama Hirofumi MZ 32a9b64051 [BROWSEUI] Fix addreseditbox.h assertion
CORE-17505
2021-03-11 16:42:36 +09:00
Piotr Hetnarowicz 31f20137b6
[DESKCPL] Update Polish [pl-PL] translation (#3520) 2021-03-11 02:36:48 +01:00
Piotr Hetnarowicz a9b6df917b
[DESKADP] Update Polish [pl-PL] translation (#3518) 2021-03-11 02:35:37 +01:00
Mark Jansen 1952e5b795
Fix some assertions now that they are enabled (#3524)
Fix some assertions, hack out some others (they need more ATL work).
CORE-17505
2021-03-11 07:43:06 +09:00
Katayama Hirofumi MZ a63213272a
[SHELL32] Enable auto-completion on 'Folder Options' > 'Change Icon' (#3522)
CORE-9281
2021-03-10 21:00:36 +09:00
Katayama Hirofumi MZ c43efcb1bb
[APPWIZ] Enable auto-completion on 'Create Shortcut' (#3521)
CORE-9281
2021-03-10 20:59:57 +09:00
Katayama Hirofumi MZ 71e4450761 [BROWSEUI] Follow-up of #3507
Case insensitiveness fix. CORE-9281
2021-03-10 19:45:03 +09:00
Katayama Hirofumi MZ c19d9df259
[BROWSEUI] Implement auto-completion (#3507)
Implement IAutoComplete to realize input auto completion. CORE-9281, CORE-1419

- The main features of this PR are Auto-Suggest and Auto-Append.
- Auto-Suggest shows a list near the textbox (an EDIT control) when the user has typed partial pathname into the textbox.
- Auto-Append appends complement text into the textbox to complete the pathname with selected status.
- The list of AutoSuggest is a top-level window whose window class is "Auto-Suggest Dropdown". We call it "the drop-down window".
- The drop-down window contains three controls: a listview, a scrollbar and a sizebox.
- The drop-down window watches the input into the textbox. If the textbox changed, then the window updates the list.
- The sizebox control enables the user to resize the drop-down window.
2021-03-10 16:22:57 +09:00
Chan Chilung 6a31fe6ca7
[TRANSLATION][INF] Update Chinese Traditional (zh-TW) translation (#3468)
- Add / improve Chinese Traditional Translations for INFs.

- Name changing (removed Aobi in my name)

Add Chinese Traditional translation for:
- cmdutils/at
- cmdutils/comp
- hotplug.cpl
- rosapps' sysutils/ctm

Chinese Traditional (zh-TW) translation update for:
- cmdutils/find
- cmdutils/help
- cmdutils/label
- cmdutils/whoami
- mspaint
- shutdown
- taskmgr
- diskpart
- format
- appwiz.cpl
- input.cpl
- powercfg.cpl
- shimgvw
- user32
2021-03-09 16:51:37 +01:00
George Bișoc 5fbf5e78e1
[SHELL32] Avoid code duplication on FAT and EXT2/BtrFS related FSs insertion (#3505)
This is a slight refactor of InsertDefaultClusterSizeForFs() code with the goal to avoid having the same code for FAT-related and EXT2/BtrFS filesystems.
2021-03-09 16:17:23 +01:00
Arnav Bhatt 06f57e1696
initial commit (#3506) 2021-03-06 19:13:05 +01:00
Serge Gautherie 8c18617fa7
[CMAKE] Fix few copy-paste typos in add_pch() calls (#3508)
Follow-up to e898c9e.
2021-03-06 19:11:56 +01:00
Serge Gautherie 62b4c61f82
[NETCFGX] LoadDNSSettings(): Improve one RegQueryValueExW() call (#2870) 2021-03-04 23:29:38 +01:00
Jérôme Gardou 43ea864405 [DBGHELP] Fix use of unix path 2021-03-04 17:41:25 +01:00
Jérôme Gardou 93d741c3f4 [SHLWAPI] Use an object library to separate C & C++ compilation units
CORE-17423
2021-03-03 08:34:32 +01:00
Jose Carlos Jesus 6e40a96145
[DEVMGR][NETID] Update PT translation (#3487)
And readjust objects size to fit all text in Driver tab.
2021-03-03 04:18:15 +01:00
Serge Gautherie 55b93aecdc
[CMAKE] target_compile_definitions() calls: Remove (now) useless '-D' (#3490)
Documented as automatically removed, since CMake 3.12.4 at least.
https://cmake.org/cmake/help/v3.12/command/target_compile_definitions.html
2021-03-03 04:16:02 +01:00
Victor Perevertkin fc2b105e5d
[CMAKE] Use remove_target_compile_option when disabling manually enabled warnings 2021-03-03 06:04:25 +03:00
George Bișoc 9536f44c81
[SHELL32] Determine if the FS is of type FATX (#3398)
FATX is listed as a filesystem for format within the list but it's classed out from current proposed filesystems, thus spamming the debug output and not allowing to actually format a storage drive with this FS.
CORE-17272
2021-03-02 19:37:31 +01:00
Piotr Hetnarowicz 27ca352d2b
[SHELL32] Improve Polish [pl-PL] translation (#3494) 2021-03-02 19:09:53 +01:00
Jérôme Gardou 42b94e728a [ADVAPI32] In RegSetValueExW, do not fail if we fault when checking for ending NUL character 2021-03-02 15:42:21 +01:00
Jérôme Gardou 7320c989fe [WS2_32] Fix error handling on non-existing registry keys 2021-03-02 14:39:22 +01:00
Carlo Bramini a141c91135
[SHIMGVW] Improve zooming feature and realize image edit (#3473)
* [SHIMGVW] Add OLE32 for CoInitializeEx()
* Implemented support for effective image size (100%).
* Fix bug that could leave one of the zoom buttons if 100% size button is now pressed.
* Replace a CreateWindowEx() with CreateWindowExW().
* Added stub for image delete function.
* Implemented support for 'Modify' button.
* [SHIMGVW] Added CoUninitialize()
* [SHIMGVW] Pair CoUninitialize with CoInitializeEx
2021-03-01 23:40:06 +09:00
Arnav Bhatt fd39a292af
[MSGINA][SHELL32] Rework friendly UI shutdown dialog box and implement friendly UI log off dialog box (#3399)
Implement the re-worked shut down dialog box as well as implementing fancy log off dialog box.
- Fancy shut down dialog box has been redesigned to be more comparable to of XP.
- Implement features that were missing earlier.
- Implement the fancy log off dialog which is more comparable to of XP.
2021-02-28 20:03:35 +09:00
Eric Kohl 1fbb295d4a [LSASRV][SECUR32] Fix the naming mess
Rename Untrusted to TrustredCaller in LSA_CONNECTION_INFO and LSAP_LOGON_CONTEXT in order to clarify the meaning of the variable.
2021-02-28 11:03:33 +01:00
Eric Kohl 76247390e5 [LSASRV] Fix a typo in the trusted user identification 2021-02-28 01:57:43 +01:00
Katayama Hirofumi MZ f04890c2af
[BROWSEUI] Fix and small improvement (#3486)
Fix a mistake in CAutoComplete PR #3472 (6bfb76b) and improve.
- Fix confusion between m_hwndEdit and hwndEdit.
- Delete extra this-> codes.
CORE-9281
2021-02-25 20:36:20 +09:00
Jose Carlos Jesus 9039de127c [BROWSEUI]Update PT translation 2021-02-24 07:23:39 +01:00
Katayama Hirofumi MZ 6bfb76b68a
[BROWSEUI] Refactoring CAutoComplete Part 1 (#3472)
- Expand tabs to spaces in CAutoComplete.h.
- Add m_ prefix to every member variable.
CORE-9281
2021-02-23 06:07:09 +09:00
Doug Lyons 834394abd9
[OPENGL32] Fix Red and Green Color Swap (#3478)
CORE-16221
2021-02-22 17:45:33 +01:00
George Bișoc b00ecdcab9
Replace my E-mail with the ReactOS org one (#3475)
From now on for ReactOS related contributions only the organization e-mail shall be used and also reverse the order of my real full name.
2021-02-22 18:26:55 +03:00
Eric Kohl dd1f0d02bc [LSASRV] Improve the policy change registration code and notify registered events 2021-02-21 18:05:11 +01:00
Katayama Hirofumi MZ 0c15f7d183
[SHIMGVW] Use _countof instead of ARRAYSIZE and use UINT (#3471)
- Use _countof macro instead of non-standard ARRAYSIZE macro.
- Use UINT type for array index instead of INT type, to erase signed/unsigned comparison warning.
JIRA issue: N/A
2021-02-21 10:28:08 +09:00
Colin Finck fd8080b094
[KERNEL32] Align the PROCESS_PRIORITY_CLASS variable in GetPriorityClass on a 4-byte boundary.
Fixes CORE-16757.
This is required for NtQueryInformationProcess as proven by my test application in the bug report.
2021-02-20 17:13:38 +01:00
Eric Kohl ea26bef01d [LSASRV] Add start code for the netlogon service 2021-02-19 21:53:00 +01:00
Václav Zouzalík 0f8224e985 [SHIMGVW] Update Czech (cs-CZ) translation 2021-02-16 15:11:50 +01:00
Hervé Poussineau 796a536a22 Revert "Disable some C++ code, which doesn't compile for me"
This reverts commit 83d9920cb9.
2021-02-16 00:13:18 +01:00
Hervé Poussineau 83d9920cb9 Disable some C++ code, which doesn't compile for me 2021-02-16 00:12:25 +01:00
Katayama Hirofumi MZ 99a9e7e493
[SHIMGVW] Refactoring (#3461)
- Make the calls of CallWindowProc and DefWindowProc Wide (Unicode).
- Delete needless type casts.
- Add const to function arguments.
- Improve ImageView_LoadSettings function.
- Insert OFN_EXPLORER flag.
2021-02-15 19:21:55 +09:00
Jared Smudde 8b6e5e87c3
[MMSYS] Add the OFN_EXPLORER flag to the Browse for sound dialog. (#3460) 2021-02-14 21:40:30 +01:00