reactos/dll
Joachim Henze 864e20b881 [MSI] setup should not enumerate read-only CDRoms as install-targets CORE-14432
We decided to check a bit different than Wine currently does.
Wine checks for
if (GetVolumeInformationW(ptr, NULL, 0, NULL, 0, &flags, NULL, 0) && flags & FILE_READ_ONLY_VOLUME)
to exclude read-only-media while we (for now) check for
if (GetDriveTypeW(ptr) == DRIVE_CDROM)

For now this gives us the benefit of covering also CDROM drives, that do not have
a CD put into it.
That does not work properly for us with the Wine patch yet, but it does for Wine!
So this maybe points to some other bug in ros, maybe in our CDROM(FS)-drivers?

In the future we should also test this on other read-only-media in Windows e.g.
a read-only USB stick to decide whether we want to stick with our current solution
or whether we want to switch to Wines solution or whether we want to logically OR
both conditions!

Thanks to Doug Lyons for providing what *currently* does work best for us!

VBox https://reactos.org/testman/compare.php?ids=77537,77546 (no change)
KVM https://reactos.org/testman/compare.php?ids=77531,77541 (no change)
2021-06-05 21:27:40 +02:00
..
3rdparty [CMAKE] Some options are only supported by GCC, don't use them for clang 2021-04-09 03:58:19 +03:00
apisets [WINSXS] Add some amd64 manifests 2021-04-08 20:48:24 +03:00
appcompat [SDBINST] Add uninstall option 2021-05-08 14:24:20 +02:00
cpl [CPL][APPWIZ] Make gecko download cancellable by keyboard (#3726) 2021-06-05 18:21:25 +09:00
directx [CMAKE] Some options are only supported by GCC, don't use them for clang 2021-04-09 03:58:19 +03:00
keyboard [KEYBOARD] Add Swiss French keyboard layout (#3408) 2021-01-05 17:48:53 +03:00
nls [CMAKE] Replace custom functions to built-in ones 2020-04-16 15:59:38 +03:00
np [REACTOS] Explicitly link against pseh & include pseh headers in a few places 2021-04-28 13:10:23 +02:00
ntdll [REACTOS] Fix parameter types on some exports (#3217) 2021-05-01 21:11:34 +02:00
opengl [CMAKE] Some options are only supported by GCC, don't use them for clang 2021-04-09 03:58:19 +03:00
shellext [TRANSLATION] Chinese Traditional (zh-TW) translation update (#3526) 2021-04-11 10:59:19 +02:00
win32 [MSI] setup should not enumerate read-only CDRoms as install-targets CORE-14432 2021-06-05 21:27:40 +02:00
CMakeLists.txt [APISETS] Add the initial set of auto-generated files. 2018-04-07 14:50:59 +02:00