Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-08-21 02:43:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
73568 commits 90 branches 274 tags 1 GiB
Commit graph

164 commits

Author SHA1 Message Date
Katayama Hirofumi MZ c17c0326ff [0.4.11][SHELL32] Fix SHFileOperation Move operation (#1487) 
Reduce failures of Move operation of shell32!SHFileOperation function. CORE-13450

And also fixes regression CORE-13176 "Drag and drop with multiple files is broken"
which regressed by SVN r74380 == git
fd91fe3337

fix picked from commit 0.4.12-dev-1080-g
c65156002c
 2020-11-09 13:06:32 +01:00
Joachim Henze b93990e7fb [0.4.11] [SHELL32] Revert the sraboy workaround CORE-14696 
This reverts the workaround of 0.4.11-RC-2-g
7e9c37c58f
Because we got a proper ole32-fix from Wine that I will apply in next commit.
 2018-12-17 22:22:16 +01:00
Joachim Henze 231daa48f7 [0.4.11] [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again 
CORE-15412

addendum to 0.4.10-dev-502-g
d559ca9c98

That copy-paste was done once intentionally to keep our imports similar to 2003.
It's worth reading the conversation in PR #748: Getequ seems to be ok with this.

The ideal solution most likely would be to instead *statically*
link against RegLoadMUIStringW() from advapi32_vista when WINNT=0x502.
For now the stuff runs again at least.
I left the func existing in advapi32_vista.dll.

cherry picked from commit 0.4.12-dev-99-g
6f8cb05cad
 2018-12-17 22:06:17 +01:00
Katayama Hirofumi MZ 00a1f2214f [0.4.11] [SHELL32] 'Run' dialog box should accept URL (#1153) 
Fix ShellExecCmdLine function. CORE-15455, CORE-11772
CORE-11772 mentioned it was a regression.

cherry picked from commit 0.4.12-dev-93-g
c94ca8128d
 2018-12-17 18:59:50 +01:00
Katayama Hirofumi MZ 29f9c0433f [0.4.11] [SHELL32] Fix 'Run' dialog crash (#1117) 
CORE-15431 (2 of 2)
Running "%SYSTEMROOT%" sometimes crashed. This will fix it.
cherry picked from commit 0.4.12-dev-36-g
472787ffea
 2018-12-16 20:35:13 +01:00
Katayama Hirofumi MZ 5aea1c7118 [0.4.11] [SHELL32] Enable environment variables in 'Run' dialog (#1111) 
CORE-15431 (1 of 2)
cherry picked from commit 0.4.12-dev-19-g
06d717e3bc
 2018-12-16 20:34:22 +01:00
Joachim Henze 7e9c37c58f [0.4.11] [SHELL32] Avoid regression CORE-14696 
"It was not longer possible to delete any file or folder via context menu"

By applying the workaround from Doug Lyons and sraboy, slightly adapted.
 2018-12-09 18:02:29 +01:00
Luo Yufan 07b120bd56 [TRANSLATION] Update Simplified Chinese translation. (#1094) 2018-12-04 17:13:39 +01:00
Luo Yufan a9f634b5fe [SHELL32] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Katayama Hirofumi MZ cbd52e30d7
[SHELL32] Don't show taskbar button of Folder Options (#1091) 
CORE-10481
 2018-12-03 13:38:09 +09:00
Katayama Hirofumi MZ c1eb420a91
careless s/E_FAIL/FALSE/ (#1089) 2018-12-03 05:43:21 +09:00
Katayama Hirofumi MZ 623b2e153e
[SHELL32] Follow up of #1085 (#1088) 
CORE-10481
 2018-12-03 05:38:36 +09:00
Katayama Hirofumi MZ ecd51d99f4
[SHELL32] Don't show taskbar button of file property sheet (#1085) 
CORE-10481
 2018-12-03 04:25:46 +09:00
Giannis Adamopoulos 1d55f459d6 [SHELL32] CFSDropTarget: Fix right click menu when shown over the tree view. CORE-11240 2018-11-27 12:58:08 +02:00
Luo Yufan a2819679ec [TRANSLATION] Update Simplified Chinese translation. (#1057) 2018-11-23 16:24:47 +01:00
Joachim Henze 432afb4161 [SHELL32] Improve CORE-15295 IDD_FILE_PROPERTIES 
addendum to 0.4.11-dev-673-g
04e1263921

Actually this control must not statically consume width of 170.
There are two different versions of that dialog.
One has a "change"-button. In this case the edit must be only 100 wide.
In case we have the version without the change button, we resize it to have
170 width (same as its neighbor).

This commit is shared work of
Stanislav Motylkov, Giannis Adamopoulos and Joachim Henze.

Commit supersedes PR#1056.
 2018-11-23 02:25:28 +01:00
Bișoc George c00bafaad9 [SHELL32] Print out the error code (#973) 
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
 2018-11-16 23:09:15 +01:00
Giannis Adamopoulos 9baf05f164 [SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file 
CORE-15353
 2018-11-15 21:26:17 +02:00
Luo Yufan d8a4e0a8e3 [TRANSLATION]Update Simplified Chinese translation. (#1032) 2018-11-14 21:42:21 +09:00
Giannis Adamopoulos bcd309cb7a [SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before 
CORE-14116
 2018-11-11 20:28:27 +02:00
Luo Yufan 5cdee1ab82 [TRANSLATION] Update Simplified Chinese translation. (#1028) 2018-11-11 17:57:12 +01:00
Luo Yufan 91e032f9b1 [TRANSLATION] Update Simplified Chinese translation. (#1025) 2018-11-09 15:31:53 +01:00
Joann Mõndresku b63e2d5046 [TRANSLATIONS] Style fixes for Estonian 2018-11-07 22:10:27 +01:00
Joachim Henze 04e1263921 [SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs 2018-11-07 01:40:53 +01:00
Mark Jansen 4bfac27ce6
[SHELL32] Fix broken control definition 2018-10-28 13:06:27 +01:00
Giannis Adamopoulos c69ef281c0 [rosctrls.h] CListView: Add Arrange method 
[SHELL32] CDefView: Start implementing Auto arrange.
So far its effect is only shown when the browser window resizes.
 2018-10-22 23:51:37 +03:00
Giannis Adamopoulos 410cfbfe15 [SHELL32] CDefView: Disable auto arrange in list and details view mode. 
This supersedes PR #927 and does it correctly.
 2018-10-22 19:18:28 +03:00
Adam Słaboń 7abc8be102 [TRANSLATION] Polish translation update 
Polish translation of net, telnet, diskpart, devcpux, fontext, iernonce, lsasrv, themes, arping, frag, screensavers, ctm, fontsub, WinetestsGUI and localmon.
Update for dxdiag, msgina, msports, netcfgx, shell32 and syssetup.
 2018-10-20 21:26:07 +02:00
Mark Jansen 80c53821c9
[SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view. 
CORE-14976
 2018-10-13 20:28:49 +02:00
Hermès Bélusca-Maïto 2cbac3d049
[SHELL32] Finally fix the icon location path (un)expansion for shell links, and explain why I originally used SHExpandEnvironmentStringsW(). 
CORE-14009 CORE-14982
 2018-10-08 00:50:38 +02:00
Eric Kohl 1e20a3e5b5 [SHELL32] Fix a potential buffer overrun. 
Patch by Kudratov Olimjon.

CORE-8545
 2018-10-07 22:56:16 +02:00
Luo Yufan b70ef2ee56 [TRANSLATION] Update Simplified Chinese translation. (#912) 2018-10-07 20:44:00 +02:00
Hermès Bélusca-Maïto ccde12483f
[SHELL32] Fixes and improvements for PickIconDlg(). 
- Deal with expanded paths only when loading icons. If the user specifies
  an unexpanded path to a module containing icons, this unexpanded path
  is returned to the caller!

- Perform the dialog cleanup in WM_DESTROY message handler.

- When pressing ENTER/OK in the dialog box, retrieve the selected icon and
  close the dialog *ONLY WHEN* the user actually has selected an icon.
  If the user modified manually the module path, pressing ENTER/OK instead
  reloads the icons list.
 2018-09-30 21:48:34 +02:00
Hermès Bélusca-Maïto ae9ec94240
[SHELL32] Code formatting only. 2018-09-30 21:48:31 +02:00
Hermès Bélusca-Maïto 7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed. 
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
 2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings() 
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981
 2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto 41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine. 
- Adjust the code with respect to:
  "shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
  4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)

- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
  ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)

- "shell32: Assume that system directory always contains a drive letter."
  54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)

- "shell32: Use ARRAY_SIZE macro."
  612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)

- "shell32: Fix a trace message."
  bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)

- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
  f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)

- "shell32: Pass correct buffer length to RegQueryValueExW()."
  0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)

- "shell32: Remove unused string (Clang)."
  8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)

- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
  730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
 2018-09-23 00:16:02 +02:00
Katayama Hirofumi MZ 31019e8c0c [TRANSLATION] Update Romanian translation (#851) 
Translation from Stefan Fulea.
CORE-15023
 2018-09-14 11:04:36 +02:00
Joachim Henze e217e926e1 [SHELL32] Fix typo in comment 2018-08-28 14:24:49 +02:00
Katayama Hirofumi MZ 39dc3cdaf6 [SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824) 
CORE-14974
 2018-08-27 12:21:51 +02:00
Mark Jansen 19e9a44118
[SHELL32] Check the result from PathUnExpandEnvStringsW 2018-08-27 11:58:29 +02:00
Mark Jansen 608cb60e44
[SHELL32] Remove some mostly dead code from CShellLink 2018-08-27 11:58:24 +02:00
Katayama Hirofumi MZ 6eb6aa2895 [SHELL32] Fix CShellLink::GetIconLocation (#810) 
Fixes a regression from PR #784.
CORE-14961, CORE-14009
 2018-08-26 15:37:15 +02:00
Katayama Hirofumi MZ 73798d2e71 [SHELL32] Enable to change shortcut icon (#784) 
CORE-11407
 2018-08-21 13:49:32 +02:00
Adam Słaboń af3d426685 [TRANSLATION] Polish translation update (#781) 
In addition: fix the encoding of the comdlg32 and ntvdm polish resource files.
 2018-08-20 17:00:33 +02:00
Joachim Henze abf9340f1b [SHELL32] Translation de-DE CORE-14916 
fix control overlapping in IDD_FOLDER_OPTIONS_FILETYPES
(broke in 0.4.10-dev-24-ed1c6bb0060d06f4c0167d9c2d732f4dc2b4cce4)

and translate IDD_NEWEXTENSION, IDD_EDITTYPE, IDD_ACTION, IDD_FOLDER_CUSTOMIZE
 2018-08-17 18:07:35 +02:00
Getequ d559ca9c98 [ADVAPI32][SHELL32][DESK.CPL] Kill copy-paste of RegLoadMUIString. (#748) 
RegLoadMUIStringW/A is part of advapi32.dll . shell32.dll and desk.cpl contained exact line-by-line copy of that function.
 2018-08-16 16:10:41 +02:00
Katayama Hirofumi MZ db13b422b3 [SHELL32] Fix a careless mistake of ShellExecCmdLine (#737) 
CORE-14886
 2018-08-10 13:25:50 +02:00
Katayama Hirofumi MZ bfcbda227f [SHELL32] Fix handling of multiple parameters in the 'Run' dialog (#665) 
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.

- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.

CORE-14790
 2018-08-05 13:39:17 +02:00
Timo Kreuzer 52ea7d39db [SHELL32] Fix 64 bit issues 2018-08-04 19:19:34 +02:00