ports back the following commits:
0.4.15-dev-3822-g 78a7d7dc32 [CMIDRIVER] Remove useless Visual Studio resource editor aps-file
0.4.12-dev-399-g 32faa24733 [BUTTERFLIES] Fix GCC build, addendum to 0.4.12-dev-397-g 2890a22179
a tiny fraction of 0.4.12-dev-397-g 2890a22179 just the [BUTTERFLIES] Avoid DLGPROC cast
0.4.8-dev-58-g bcbe0dd8cd [CPL] Remove unnecessary DLGPROC casts. (#99)
0.4.8-dev-30-g 830fc82afe [SERIALUI] Set the stdcall calling convention for CommDlgProc() and make it return INT_PTR
Ftr, there are still a few DLGPROC casts left after this commit in ros source tree,
but I don't want to port back the commits yet, which addressed them.
Too fresh still, no need to rush that.
This ports back the following commits about lossless PNG-shrinking:
0.4.15-dev-6410-g cf4bb8fced [WALLPAPERS] Optimize PNG images (#5506)
0.4.15-dev-6398-g e5993f13f0 [REACTOS] Optimize PNG images (#5492)
0.4.15-dev-6376-g 8f3a09722e [MSPAINT] Optimize images for help docs (#5486)
Most of those PNGs have not been touched ever since we switched from SVN to git, so they can safely be ported back by copying over.
But did not port them back any further than where they existed already.
Tweak a few related txt/html files also with trivial stuff like EOL-whitespace-removal.
this ports back (also) the following commit:
0.4.15-dev-6308-g 2d9877470d
While touching those files, port back some minor translation improvements also.
but actually I did concentrate here on porting back the following commits:
0.4.8-dev-547-g e9d8fa57c3 [TRANSLATION][BASE][FDEBUG][MODULES][WIN32SS] Use correct font name in Chinese resources, CORE-9566 (#227)
0.4.8-dev-546-g d09998dfc7 [TRANSLATION][APPLICATIONS] Use correct font name in Chinese resources, CORE-9566 (#226)
0.4.8-dev-539-g bf51ed17f8 [SHELLEXT] Use correct font name in Chinese resources, CORE-9566 (#224)
0.4.8-dev-538-g 1ebe4a5b83 [TRANSLATION] Use correct font name in Chinese resources, Part 3/3, CORE-9566 (#223)
0.4.8-dev-537-g 074f5c6c13 [TRANSLATION] Use correct font name in Chinese resources, Part 2/3, CORE-9566 (#222)
0.4.8-dev-536-g 81d6232aa3 [TRANSLATION] Use correct font name in Chinese resources, Part 1/3, CORE-9566 (#221)
partially 0.4.8-dev-534-g b214b160b6 setup: Use correct font name in resource: CORE-9566 (#219) (I left out all the changes to [WELCOME])
0.4.8-dev-533-g 2b91b29642 [CPL] Control Panel Applets: Use correct font name in Chinese resources, CORE-9566 (#220)
------
tr-TR.rc: Also strip outdated email address erdemersoy@live.com instead of following 0.4.8-dev'ing
with replacing it with an even longer address, that later got changed another time.
The auto-replacement during 0.4.8-dev'ing did lead to some very long lines in many header sections. Don't want that.
Localized resources should use the correct Korean fonts that are most suitable
for UI and compatible with Windows.
fix picked from commit 0.4.8-dev-548-g 89f9c9101a
This fixes a part of CORE-9566
Switches from "FreeMono" and "Dejavu Sans Mono" to "Courier New" and "Lucida Console"
and therefore brings us closer to 2k3sp2 stock fonts. Saves some RAM also.
Deletes some "Ubuntu" font left-overs in some Themes.
CORE-18605 (and partially CORE-16264)
By porting back the following commits:
0.4.15-dev-5362-g c47758b102 [SETUP][INF][MEDIA] Get rid of the last Ubuntu references CORE-18607 (#4871)
0.4.15-dev-5336-g bd40c13f6f [SETUP][BOOTDATA][FONTS][INF] Delete DejaVu Sans Mono and re-map (#4856)
0.4.15-dev-5335-g a4193ade03 [SETUP][FONTS][INF][GDI32_APITEST] Delete FreeMono and re-map (#4852)
0.4.15-dev-5324-g d035452148 [SETUP][INF][ROSTESTS] Delete font substitutions and tests for "DejaVu Sans" (#4829)
0.4.13-dev-768-g dc1aa8010a [FONTS][SETUP][BOOTDATA] Add Lucida Console font (#1793) CORE-16264
0.4.13-dev-750-g faa3237d46 [FONTS][BOOTDATA][SETUP] Add Courier New fonts (#1783)
See https://reactos.org/wiki/ReactOS_Foundation for more information.
the first part of CORE-18191
picked from 0.4.15-dev-4866-g 6881d8c624
Respect:
-Colins wish to leave out for now all the matches in kbdtool for legal uncertainty
-boot_images.cmake on master vs. boot/CMakeLists.txt in older branches
-treating cpu.inf special in this first commit for the sake of keeping sync to all other infs
-unlike master I decided to groom also cdmake, because I don't see any reason yet to dump that
in the older branches
-all releases down to releases/0.4.7 were released for the first time after the "ReactOS foundation"
dissolved already in 2015. So all are definitely fine to receive this commit.
-port back some EOL whitespace fixes as well in common.ver to sync the file to 100% to master head
can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration:
C:\047rls\reactos\modules\rosapps\applications\screensavers\cylfrac\cylfrac.c(109) : warning C4305: 'function' : truncation from 'double' to 'float'
C:\047rls\reactos\modules\rosapps\applications\screensavers\cylfrac\cylfrac.c(110) : warning C4305: 'function' : truncation from 'double' to 'float'
C:\047rls\reactos\modules\rosapps\applications\screensavers\cylfrac\cylfrac.c(137) : warning C4305: 'initializing' : truncation from 'double' to 'GLfloat'
partial pick of 0.4.15-dev-2951-g 5d8e834897
can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuration:
[11438/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\config.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'
[11441/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\httpd.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'
[11442/11751] Building CXX object modules\rosapps\applications\net\roshttpd\CMakeFiles\roshttpd.dir\roshttpd.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\httpd.h(70) : warning C4373: 'CHttpDaemon::OnAccept': virtual function overrides 'CServerSocket::OnAccept', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
C:\047rls\reactos\modules\rosapps\applications\net\roshttpd\include\socket.h(132) : see declaration of 'CServerSocket::OnAccept'
partial pick of 0.4.15-dev-2951-g 5d8e834897
the warning can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuation:
[11432/11751] Building CXX object modules\rosapps\applications\net\netreg\CMakeFiles\netreg.dir\netreg.cpp.obj
C:\047rls\reactos\modules\rosapps\applications\net\netreg\netreg.cpp(188) : warning C4065: switch statement contains 'default' but no 'case' labels
partial pick of 0.4.15-dev-2951-g 5d8e834897
Mutes too many to list them all here, but the motivation to pick that part was:
can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuation:
C:\047rls\reactos\modules\rostests\winetests\rpcrt4\server.c(910) : warning C4305: 'function' : truncation from 'double' to 'float'
C:\047rls\reactos\modules\rostests\winetests\rpcrt4\server.c(910) : warning C4305: 'function' : truncation from 'double' to 'float'
Timo thought most likely that muting is okay here, to keep the diff to upstream low in the tests.
Partial pick from 0.4.14-dev-847-g 42d2d5ec9c
can be observed with MSVC 2010SP1 (16.0.40219.1) x86 target in dbg configuation:
c:\047rls\reactos\modules\rostests\apitests\ntdll\stackoverflow.c(57) : warning C4717: 'infinite_recursive' : recursive on all control paths, function will cause runtime stack overflow
Muting is okay here, because stack overflow is specifically what is aimed to be tested here.
Fix is a partial pick of 0.4.14-dev-847-g 42d2d5ec9c
No warnings left in module NTDLL_APITEST and no C4717 left in releases/0.4.7.
Can be observed when building with MSVC2010SP1 x86-target in dbg config:
- "...\ebrowser.c(1188) : warning C4133: 'function' : incompatible types - from 'DWORD *' to 'EXPLORER_BROWSER_OPTIONS *'"
- "...\ebrowser.c(1198) : warning C4133: 'function' : incompatible types - from 'DWORD *' to 'EXPLORER_BROWSER_OPTIONS *'"
Cherry-pick 535f2f9e66
fix picked from:
0.4.10-dev-513-g 669d6b445b
-fixes CORE-14192 Notepad text rendering performance improves dramatically
-fixes 50% of CORE-13631 GSView Setup, dramatic speedup, but only partially solved because the jumping does persist
-fixes CORE-14002 "It takes 8seconds to open up about dlg of DevCPP 5.11" reduces to 2seconds
-fixes "about-dlg of DoubleCommander takes long to open"
[USP10] Re-use script caches for the same font. CORE-14192
This significantly speeds up WM_SETTEXT in multiline edit controls.
by porting back the fix from 0.4.8-dev-779-g cd992d022f
-----------------------------------------------------------
but since that commit on its own would introduce the regression CORE-14226
I have to additionally port back 0.4.12-dev-151-g c086edf366
That final fixes commit message:
[USP10] Don't mix character and glyph index caches. CORE-14226
Import Wine commits by Nikolay Sivov:
* d1e618d31da usp10: Use glyph index consistently in ScriptGetGlyphABCWidth().
* 8d018d8d1da usp10: Make sure metrics cache is used with glyph indices only.
* eda3a3e37da usp10: Remove extra parentheses.
Fixes font display in UltraISO and GOG and many other installers.
See also https://bugs.winehq.org/show_bug.cgi?id=44410
-------------------------------------------------------------
and I have to sync the
modules\rostests\winetests\usp10\usp10.c to the state of 0.4.8-release-30-gfb23ed8
Symptom CORE-14072: '1C: Enterprise 8.2 Educational Edititon can't launch anymore due to "not enough memory" error'
It regressed by SVN r74513 == git 5b6e082869
Actually the most important part of this fix are just the changes in win32ss/printing/base/winspool/printers.c func GetPrinterW()
But I felt more safe when porting back the whole 2 fix-commits including the tests:
---------------------------
[PRINTING] Fix GetPrinterW, add tests for it and GetDefaultPrinterA/W, and add a proper stub for GetPrinterDriverDirectoryA.
* Pass the correct handle to _RpcGetPrinter in GetPrinterW.
* Pass an empty string instead of a NULL pointer as wszComputerName to the GetPrinterLevel* functions, because this variable is later used as source for StringCbCopyExW.
* Don't check for GetLastError() == ERROR_SUCCESS in tests. Windows apparently only sets the last error in case of failure.
The Printing code should probably be changed similarly in a future commit.
Should fix CORE-14072
fix picked from commit 0.4.8-dev-314-g
3a69fd4e96
----------------------------
[WINSPOOL] Convert the returned Unicode string back to ANSI in GetDefaultPrinterA.
Thanks to Mark for the hint in CORE-14072!
fix picked from commit 0.4.8-dev-300-g
45b9b5c1ef
* [KMTEST] Initial usermode support for testing FS mini-filters
- Add base routines to wrap the win32 'Filter' APis
- Add support routines to be used when testing FS filter drivers
- Move KmtCreateService to a private routine so it can be shared with KmtFltCreateService
- Completely untested at the mo, so likely contains bugs at this point
[FLTMGR]
- Partially implement registering contexts
- Add a misc file which contains stubs of the APIs needed in the test suite
- Export some APIs needed by the test suite
[KMTESTS]
- Create a File System Mini-filter wrapper to host drivers for the filter manager tests
- Add a test file which will be used for testing that mini-filters load correctly
- Add a test file which will be used to write tests for IRP_MJ_CREATE requests
In C89, you can only initialize the first member of a union within a declaration. Unfortunately, that is the S_un_b UCHAR array for the S_un union inside struct in_addr.
So we have to initialize it with each UCHAR member of Address.
