This ports back:
partially 0.4.15-dev-99-g ad591d0269 (only the defwnd.c part)
which was committed as part of the still unresolved CORE16163 PR2152. It was not enough on its own to fix that.
But in return it does properly fix:
CORE-15297 [USER32] mIRC 6.35 options dlg - unintended scrollbars that are not clickable
and its duplicate
CORE-17778 HxD 2.5.0.0 shows a horizontal scrollbar that should not be there
For improved formatting reasons I did also port back the:
0.4.15-dev-8022-g a69532ec4a [USER32] defwnd.c only formatting, no functional change
and additionally in the backport I had to strip 1 ERR which actually was a good-path-log
to prevent binary size increase. Thanks to that compensation
user32.dll binary even slightly shrinks on some branches:
user32.dll master RosBEWin2.2.2 GCC8.4.0dbg 1.582.592 (0.4.15-dev-8022-ga69532e)
user32.dll 0.4.14 RosBEWin2.2.2 GCC8.4.0dbg 1.551.360 -> 1.550.336
user32.dll 0.4.14 RosBEWin2.1.6 GCC4.7.2dbg 1.444.864 -> 1.444.864
user32.dll 0.4.13 RosBEWin2.1.6 GCC4.7.2dbg 1.441.792 -> 1.441.280
user32.dll 0.4.12 RosBEWin2.1.6 GCC4.7.2dbg 1.452.032 -> 1.452.032
user32.dll 0.4.11 RosBEWin2.1.6 GCC4.7.2dbg 1.449.472 -> 1.448.960
user32.dll 0.4.10 RosBEWin2.1.6 GCC4.7.2dbg 1.431.552 -> 1.431.552
user32.dll 0.4. 9 RosBEWin2.1.6 GCC4.7.2dbg 1.418.752 -> 1.418.752
user32.dll 0.4. 8 RosBEWin2.1.6 GCC4.7.2dbg 1.418.240 -> 1.418.240
user32.dll 0.4. 7 RosBEWin2.1.6 GCC4.7.2dbg 1.415.680 -> 1.415.680
This ports back 3 commits:
0.4.15-dev-7861-g a771729e69 [COMCTL32] Fix Status Bar Updating (#6696)
which fixes CORE-19497 'Regression, part of the statusbar with the sizegrip is not redrawn properly'
which regressed on this branch by 0.4.11-release-193-g dafd020c07
also port back:
0.4.13-dev-888-g 76dfa2b284 [COMCTL32] Checking size grip bounds in x-axis only (#991)
0.4.13-dev-887-g b9ddad0bbb [COMCTL32] Hide size grip when the parent window is maximized CORE-15240 (#991)
To compensate binary increase, I stripped a few TRACE's and the debugstr_t() function in the older branches.
comctl32.dll binary therefore has a tendency to shrink a tiny bit on most branches:
comctl32.dll master RosBEWin2.2.2 GCC8.4.0dbg 2.001.408 (0.4.15-dev-7906-g1b85a5f)
comctl32.dll 0.4.14rls RosBEWin2.2.1 GCC8.4.0dbg 1.998.336 -> 1.997.824
comctl32.dll 0.4.14rls RosBEWin2.1.6 GCC4.7.2dbg 1.807.872 -> 1.807.360
comctl32.dll 0.4.13rls RosBEWin2.1.6 GCC4.7.2dbg 1.804.800 -> 1.803.264
comctl32.dll 0.4.12rls RosBEWin2.1.6 GCC4.7.2dbg 1.817.600 -> 1.817.088
comctl32.dll 0.4.11rls RosBEWin2.1.6 GCC4.7.2dbg 1.809.920 -> 1.809.408
comctl32.dll 0.4.10rls RosBEWin2.1.6 GCC4.7.2dbg 1.806.848 -> 1.806.848
comctl32.dll 0.4. 9rls RosBEWin2.1.6 GCC4.7.2dbg 1.806.848 -> 1.806.848
comctl32.dll 0.4. 8rls RosBEWin2.1.6 GCC4.7.2dbg 1.633.792 -> 1.632.768
comctl32.dll 0.4. 7rls RosBEWin2.1.6 GCC4.7.2dbg 1.602.048 -> 1.602.048
Port back:
0.4.15-dev-7362-g 1aeac0bf24 [REGEDIT] Fix condition of enabling load/unload hive menu item (#6251) CORE-19298
which was an addendum to 0.4.15-dev-243-g 4d1cd72317 (where I ported back parts earlier from)
and ports back various unrelated RC-tweaks, e.g.
partially 0.4.15-dev-7887-g 64a59a17b5 [REGEDIT] RC-tweak, only the it-IT-addendum
0.4.15-dev-6940-g 03dc2ef724 [REGEDIT] Update Romanian (ro-RO) translation (#5961)
and a few others
regedit.exe binary does shrink a tiny bit on all branches:
regedit.exe master RosBEWin2.2.2 GCC8.4.0 dbg x86 1.049.600 (0.4.15-dev-7886-g938a39a)
regedit.exe releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 755.712 -> 755.200
regedit.exe releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 750.080 -> 749.056
regedit.exe releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 742.400 -> 741.888
regedit.exe releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 744.448 -> 743.424
regedit.exe releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 744.448 -> 743.424
regedit.exe releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 744.448 -> 743.424
regedit.exe releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 744.448 -> 743.424
regedit.exe releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 743.936 -> 742.912
regedit.exe releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 743.936 -> 742.912
This ports back:
*PARTIALLY* 0.4.15-dev-7884-g d72d61fe47 [COMDLG32] *.rc Improve translations (#6729)
0.4.15-dev-7351-g 449a08a6a8 [COMDLG32] Fix IDC_TOOLBARPLACES size (#6228) CORE-16925
This part is relevant only for releases/0.4.10 to releases/0.4.14 because that dlg was only introduced during 0.4.10-dev'ing
0.4.15-dev-3493-g a36cc8054d [COMDLG32] Fix ico3 not shown in Print dialog (#2831)
0.4.15-dev-95-g 7895704952 [COMDLG32] Enlarge list area in CHOOSE_FONT dialog (#2670)
As always pick some selected/improved translations here and there from newer branches.
Furthermore strip the accelerators from the pshhelp-buttons *in the older branches*, not in master. They do collide in so many languages,
and since the old releases will never get any help-functionality ported to, they are actually counterproductive.
Stripping them is not so easy though, because some dlgs, especially the file-open-dlgs get dynamically resized at runtime
by the height of that button, and by the height of the read-only-checkboxes. Ugly stuff.
Maybe they can be hidden later, and de-stringified to save a few bytes and missing translations.
Not important for today, maybe something to consider in 10years from now.
The stripped accelerators can then serve as a reminder for that.
Binary size of comdlg32.dll shrinks slightly for all branches:
comdlg32.dll master RosBEWin2.2.2 GCC8.4.0 dbg x86 1.011.712 (0.4.15-dev-7874-g0cfc9ab)
comdlg32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 1.008.128 -> 1.006.080
comdlg32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 974.336 -> 972.288
comdlg32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 974.336 -> 972.288
comdlg32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 958.464 -> 956.416
comdlg32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 944.128 -> 941.568
comdlg32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 941.568 -> 939.520
comdlg32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 914.432 -> 912.384
comdlg32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 914.944 -> 912.384
comdlg32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 899.584 -> 896.512
CORE-17819 This allows Microsoft VirtualPC 2004/2007 to boot LiveCD SAFEMODE to desktop,
the regular mode booted also without that addition already.
Fix picked from 0.4.15-dev-1537-g b1c460d34e
This commit was part of a much bigger PR3396, which I don't pick entirely today.
For CORE-17819 only this part is actually needed.
This backport covers tons of improvements within the Shell32-RCs.
E.g. It improves the IDD_FILE_PROPERTIES and IDD_FOLDER_PROPERTIES significantly in the older releases for all langs, but also the Run-Dlg and IDD_OPEN_WITH.
The following master commits are part of it:
0.4.15-dev-7838-g e3bfcdf9e2 [SHELL32] pl-PL.rc: Fix IDD_FILE_PROPERTIES & IDD_FOLDER_PROPERTIES (#6678)
Some 100%-safe parts of the yet uncommitted PR6657 [SHELL32] Update Romanian (ro-RO) translation. I didn't pick all of that yet, as most parts are still WIP.
0.4.15-dev-7833-g ee0329e0e2 [SHELL32] *.rc: accelerator fixes, drive-properties bg-BG and fr-FR (#6591).
I addressed many of the FIXMEs already in the backport so this state is superior to master even.
0.4.15-dev-7216-g d387c799ed [SHELL32] 640x480-ify four dialogs (#6004) IDD_DRIVE_PROPERTIES, IDD_DRIVE_TOOLS, IDD_DRIVE_HARDWARE, IDD_FOLDER_CUSTOMIZE
0.4.15-dev-6333-g fa429c8e2f [SHELL32] *.rc: Use 1996 as birth year in IDD_ABOUT for consistency (this leaves now only the cmd-part left to be done in this context)
0.4.15-dev-5993-g a5bff2457a [SHELL32] Improve disk properties pie chart (#5239) CORE-18906
(I picked only the rc changes for that, but left the code changes out of the backport, the result is still appealing to my eyes)
0.4.14-dev-1492-g 4af7888b29 [SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs
In releases/0.4.14 and lower I stripped the en-GB.rc,
because that was (aside from 3-4 lines of forgotten sync) the same content to en-US.rc still. Real intended changes reached en-GB.rc not before 0.4.15-dev.
Furthermore this translation does not exist in 2k3sp2 afaik.
Also strip GUI-controls for some other features that are yet unimplemented in older ros versions, and that I won't port back, namely:
- drive-indexing/compression-checkboxes and "Disk Cleanup"-button in IDD_DRIVE_PROPERTIES
- controls for GUI-versions of "Backup" and "Defragmentation" in IDD_DRIVE_TOOLS DIALOGEX
- and the related icons for the above
Binary size of shell32.dll shrinks for all branches:
shell32.dll master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.579.968 (0.4.15-dev-7836-g72a27e6)
shell32.dll releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.316.684 -> 9.201.664
shell32.dll releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.345.024 -> 9.230.336
shell32.dll releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.199.616 -> 9.086.976
shell32.dll releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.146.368 -> 9.031.680
shell32.dll releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.077.248 -> 8.954.880
shell32.dll releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.069.568 -> 8.945.152
shell32.dll releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.821.760 -> 8.618.496
shell32.dll releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.736.256 -> 8.536.576
shell32.dll releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.663.040 -> 8.466.944
This fixes the same 2 warnings that we fixed on master by 0.4.15-dev-7676-g a08b83a90b (#6539)
But I ported back only the first commit of (#6539) and left out the 2nd.
The 2 warnings were introduced by 0.4.10-dev-202-g 698cbc6184
binary size of shell32.dll tends to shrink slightly (e.g. in releases/0.4.13),
but is not enough to reach the next lower quantum for most branches:
master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.550.272 (0.4.15-dev-7715-gbb297bc)
releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.316.684 -> 9.316.684
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.345.024 -> 9.345.024
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.200.640 -> 9.199.616
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.146.880 -> 9.146.368
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.077.248 -> 9.077.248
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.069.568 -> 9.069.568
No older branch than releases/0.4.10 was affected.
Picks various trivial improvements from newer branches, does not fix specific JIRA-tickets and also doesn't
*entirely* cover a specific PR, therefore none of those are mentioned here.
Main motivation is to reduce large scale white-noise diff between the branches, to make
future commits diffs (with some fixes that actually matter) smaller in size and therefore easier to review.
Specifically:
- large-scale formatting & logging improvements, including but not limited to 0.4.15-dev-7653-g 6f91b6c0fe
- strip trailing whitespace
- also typos like 'unkown', missing \n as it was
part of 0.4.15-dev-6323-g 3854a5d8e9 and
0.4.15-dev-4492-g 03422451b3
(I left out the MOUSE_MOVE-one from that, because I consider the missing \n there intentional)
- ports back many usages of ARRAYSIZE/_countof as it was added as part of some commits from Hermes, e.g.:
*partial* pick of 0.4.13-dev-622-g 8a30801516 and
*partial* pick of 0.4.15-dev-3642-g 83be315abf (I left out the literals here for now, ...
I *might* pick them later on their own, but not now. I first want to verify their isolated impact on all compilers generated file-sizes.
Some of those changes would even increase the binary size, especially those where the same literal is used multiple times,
because string-pooling is currently not enabled for all toolchains and configurations.)
- COpenWithMenu.cpp: strip double-semicolon
- COpenWithMenu.cpp && folder_options.cpp: add \n to some dbg-prints without increasing their length
- CFSDropTarget.cpp: add \n to some dbg-prints, strip some good-path-traces that are no longer present in master in return to avoid size increase, fix indentation
- CShellLink.cpp: add \n to some dbg-prints without increasing their length
- iconcache.cpp: fix wrong indentation
binary size of shell32.dll has tendency to shrink slightly, which is caused solely by the logging changes:
master RosBEWin2.2.2 GCC8.4.0 dbg x86 10.538.496 (0.4.15-dev-7640-gbdcfc6b)
releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 9.317.888 -> 9.316.684
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.345.024 -> 9.345.024
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.201.152 -> 9.200.640
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.146.880 -> 9.146.880
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.077.760 -> 9.077.248
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 9.074.176 -> 9.072.128
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.825.856 -> 8.824.832
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.740.864 -> 8.738.816
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 8.668.160 -> 8.666.624
0.4.15-dev-7606-g 874b5a4e00 [NETSHELL] Trivial tweaks (#6484)
0.4.15-dev-7126-g a6341b49d8 [NETSHELL] 640x480-ify complete that module (#6109)
0.4.15-dev-7018-g cbc60aa07a [NETSHELL] Double click on component should open properties (#6008) CORE-19330
PARTIALLY 0.4.15-dev-6857-g 55563fa891 [NETSHELL] IDD_NETPROPERTIES must fit 640x480 CORE-19284 (#5899) (I left out the 3 accelerators)
Also port back some other rc tweaks and strip EOL-whitespaces and the IDS_NET_REPAIR from the context menu which is still unimplemented in the older branches
and for which I do never intend to port back the implementation.
binary size of netshell.dll shrinks slightly on all branches:
master RosBEWin2.2.2 GCC8.4.0 dbg x86 659.968 (0.4.15-dev-7598-geb55d98)
releases/0.4.14 RosBEWin2.2.2 GCC8.4.0 dbg x86 644.608 -> 640.512 (netshell.dll is one of the rare modules where GCC8.4.0 produces more efficient output than GCC4.7.2)
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 687.104 -> 682.496
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 685.568 -> 681.472
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 666.624 -> 662.016
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 657.408 -> 653.312
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 576.512 -> 572.928
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 576.512 -> 572.416
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 576.512 -> 572.416
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 576.000 -> 571.904
This ports back:
0.4.15-dev-7456-g cbc3ee2287 CORE-19424 "Game Controller" control panel applet : ESC does not close
and a few trivial rc improvements.
Tendency for binary size is to shrink slightly, but manages to only reach the next lower quantum in releases/0.4.14:
master RosBEWin2.2.2 GCC8.4.0 dbg x86 144.384 (0.4.15-dev-7557-gc858429)
releases/0.4.14 RosBEWin2.1.6 GCC4.7.2 dbg x86 133.632 -> 133.120
releases/0.4.13 RosBEWin2.1.6 GCC4.7.2 dbg x86 125.440 -> 125.440 (interesting: 0.4.12 & 0.4.13 do have the exact same code *within* this module)
releases/0.4.12 RosBEWin2.1.6 GCC4.7.2 dbg x86 127.488 -> 127.488 (interesting: 0.4.12 & 0.4.13 do have the exact same code *within* this module)
releases/0.4.11 RosBEWin2.1.6 GCC4.7.2 dbg x86 125.952 -> 125.952
releases/0.4.10 RosBEWin2.1.6 GCC4.7.2 dbg x86 125.952 -> 125.952
releases/0.4. 9 RosBEWin2.1.6 GCC4.7.2 dbg x86 125.952 -> 125.952
releases/0.4. 8 RosBEWin2.1.6 GCC4.7.2 dbg x86 125.952 -> 125.952
releases/0.4. 7 RosBEWin2.1.6 GCC4.7.2 dbg x86 125.952 -> 125.952
I am not aware yet which exact commit in the toolchain or dependent libs made it shrink from releases/0.4.12 to releases/0.4.13
Ports back a real fix:
0.4.15-dev-1173-g ba09834c5e [PARPORT] Fix I/O port length check
Ports back logging and formatting:
0.4.15-dev-6794-g 4eace8d762 [IPHLPAPI] Silence obsolete FIXME in GetAdaptersAddresses (#5834) CORE-14388
0.4.15-dev-6438-g b12ab486d8 [MUP] Mute DPRINT1's that slow down shared folder accesses (#5545) CORE-19105
And mutes some other loggings as well for stuff, that I either never want to port back, e.g. the IMM-implementations,
or which is not really helpful in the older branches:
fixme:(win32ss/user/user32/misc/imm.c:446) WINNLSEnableIME is UNIMPLEMENTED!
fixme:(../dll/win32/iphlpapi/address.c:290) GetAdaptersAddresses - Semi Stub: Family 2, Flags 0x0000002e, Reserved 00000000, pAdapterAddress 00000000, pOutBufLen 0143EBD4.
(dll/ntdll/ldr/ldrinit.c:1649) LdrpInitializeProcessCompat: Not applying automatic fix for winver 0xa00 due to policy
when browsing the startmenu:
fixme:(dll/win32/comctl32/toolbar.c:394) [00080086] TBSTYLE_REGISTERDROP not implemented
fixme:(dll/win32/comctl32/toolbar.c:5636) [00080086] response 2045774661 not handled to NM_CUSTOMDRAW (CDDS_PREERASE)
fixme:(dll/win32/comctl32/toolbar.c:5673) [00080086] response 3225142 not handled to NM_CUSTOMDRAW (CDDS_POSTERASE)
fixme:(dll/win32/comctl32/toolbar.c:5636) [000200BA] response 9 not handled to NM_CUSTOMDRAW (CDDS_PREERASE)
fixme:(dll/win32/comctl32/toolbar.c:5636) [00080086] response 2288892 not handled to NM_CUSTOMDRAW (CDDS_PREERASE)
fixme:(dll/win32/comctl32/toolbar.c:5673) [00080086] response 3291448 not handled to NM_CUSTOMDRAW (CDDS_POSTERASE)
and a bigger block regarding the parallel port during booting:
(drivers/parallel/parport/parport.c:127) Parport DriverEntry
(drivers/parallel/parport/fdo.c:391) AddDevice(B0B50548 B0FED980)
(drivers/parallel/parport/fdo.c:25) AddDeviceInternal()
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:582) IRP_MJ_PNP / IRP_MN_FILTER_RESOURCE_REQUIREMENTS
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:546) IRP_MJ_PNP / IRP_MN_START_DEVICE
(drivers/parallel/parport/misc.c:42) Calling lower device B0FED980
(drivers/parallel/parport/fdo.c:116) FdoStartDevice ()
(drivers/parallel/parport/fdo.c:160) Port: BaseAddress 0x378 Length 8
(drivers/parallel/parport/fdo.c:160) Port: BaseAddress 0x778 Length 8
(drivers/parallel/parport/fdo.c:174) Interrupt: Level 20 Vector 55
(drivers/parallel/parport/fdo.c:195) New LPT port: Base 0x378
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:586) Unknown minor function 0x9
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:586) Unknown minor function 0x14
(drivers/parallel/parport/fdo.c:513) FdoPnp()
(drivers/parallel/parport/fdo.c:564) IRP_MJ_PNP / IRP_MN_QUERY_DEVICE_RELATIONS / BusRelations
(drivers/parallel/parport/fdo.c:351) FdoQueryBusRelations()
(drivers/parallel/parport/fdo.c:233) FdoCreateRawParallelPdo()
(drivers/parallel/parport/fdo.c:378) Done
(drivers/parallel/parport/pdo.c:165) PdoPnp()
This backports the following commits:
0.4.15-dev-6770-g ddd1d19b3f [TASKMGR] Get rid of cplusplus extern c (#5808)
partially 0.4.15-dev-6120-g 6e77747b30 [TASKMGR] Simplify tray icon code
0.4.15-dev-6114-g 9a6c85f68a [TASKMGR] Fix PerfDataDeallocCommandLineCache, part of CORE-18014 (unresolved still)
0.4.15-dev-6113-g 7989e3f26c [TASKMGR] GraphCtrl_Dispose: Delete hdcGraph first, part of CORE-18014 (unresolved still)
0.4.15-dev-6112-g dc14a9f6e0 [TASKMGR] GraphCtrl: Use DeleteDC instead of DeleteObject to delete inst->hdcGraph, part of CORE-18014 (unresolved still)
partially 0.4.15-dev-4994-g 15a0f7adb0 picked a tiny part from PR4657 (I picked only the refactoring to switch-statement, no functional changes. Especially NOT the formatting changes which would require the additional winnls.h-include)
0.4.15-dev-3737-g f8faa0b660 [TASKMGR] Fix a heap corruption bug (#4311), just an addendum to PR4141 which is picked with this backport as well. Older branches were never affected.
partially 0.4.15-dev-3514-g 1c82bf0324 [TASKMGR] Avoid freezing in getting icons, from (PR4180) CORE17894. I picked only the 1000ms->100ms part and the stripping of WM_QUERYDRAGICON call. Therefore I don't consider CORE17894 as fully covered.
0.4.15-dev-3486-g 545e1190f2 [TASKMGR] Avoid hangs as much as possible (#4166) CORE17894
partially 0.4.15-dev-3483-g 403222dd4f [TASKMGR] Preserve graphs history on resizes (#4141). I left aside the structs type renaming and OOM-Handling upon graph creation. Picked all the logical changes though.
0.4.15-dev-3269-g 0ed04e3640 [TASKMGR] Make performance graph grid scroll (#3581)
0.4.15-dev-3268-g a4ab9a1e19 [TASKMGR] Formatting only (#3581). Covers the last bits of that PR.
Main motivation was getting the toggling of ShowKernelTimes in the Performance tab
switch on and off in realtime without introducing gaps in the graph.
It also makes the grid scroll together with the data, like on Windows.
Most other parts I picked solely for their binary-shrinking effect.
I decided to strip the ID_HELP_TOPICS from the rc files, as this was not implemented,
and I would never port that back later. So it is one less non-functional-button in the older branches.
I favored memset() over Zeromemory() in this usermode-app everywhere, and favoref for (;;) over while(1).
Binary size shrinks slightly on all branches:
master taskmgr.exe RosBEWin2.2.2 GCC8.4.0dbg 696.832 (0.4.15-dev-6820-gb3194e3)
0.4.14 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 549.888 -> 548.864
0.4.13 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 542.720 -> 542.208
0.4.12 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 545.792 -> 543.232
0.4.11 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 545.792 -> 543.232
0.4.10 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 532.480 -> 530.432
0.4. 9 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 532.480 -> 530.432
0.4. 8 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 532.480 -> 530.432
0.4. 7 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 531.456 -> 529.408
taskmgr.exe MS XPSP3 german 140.800 Bytes
0.4.14 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=de-DE 110.080 Bytes -> 109.056 Bytes (my current taskmgr of choice)
0.4. 8 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US 108.032 Bytes -> 105.984 Bytes
0.4. 7 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US 107.520 Bytes -> 105.472 Bytes
ports back:
0.4.15-dev-6640-g 02883d1c16
SpareData and SpareLength need to be calculated correctly, as they are used
later in that function as well.
This allows to not overwrite Source UString when writing to Destination UString.
Fixes the problem described in the following JIRA issue, where services could
not start in 2nd-stage-bootcd-setup when installing ReactOS in a very-long-named directory.
CORE-18988
Some commits I do port back all the way down till releases/0.4.7:
partially 0.4.15-dev-6768-g 63eaf2bd52 [TASKMGR] *.rc Deduplicate dynamic menu strings (#5772) (I left out the FIXME-comments)
0.4.15-dev-6712-g 46b4b5581d [TASKMGR] Favor _countof(), no functional change intended (#5757)
0.4.15-dev-6703-g 6528ab8fcb [TASKMGR] de-DE.rc Update part 3
0.4.15-dev-6702-g 65ce20896a [TASKMGR] *.rc Strip unused IDD_DEBUG_CHANNELS_DIALOG
0.4.15-dev-6700-g e15d68ba5d [TASKMGR] de-DE German Update & bug-fixes
partially 0.4.15-dev-6447-g 016acd170d [TASKMGR] Do not free shared icon for ShellAbout() calls (I picked just the taskmgr part) (was part of larger PR5519)
0.4.15-dev-6297-g 831288fe69 [TASKMGR] Fix text truncation for fr-FR.rc (#5380) CORE-18523
0.4.15-dev-6127-g c706222f3f [TASKMGR] Fix the license. Turns out it's LGPL-2.1-or-later from the texts.
0.4.15-dev-6124-g 9927163455 [TASKMGR] Reorder page controls to have natural TAB-ordering.
0.4.15-dev-6122-g d5707eefe2 [TASKMGR] High speed update is twice per second, and not every second.
0.4.15-dev-6121-g 2da0506f2a [TASKMGR] Remove more dead code.
partially 0.4.15-dev-6120-g 6e77747b30 [TASKMGR] Simplify tray icon code. (I left out using the strsafe.h-dependent stuff, as this is safe also in old-style)
0.4.15-dev-6119-g 0b4c8bdd1c [TASKMGR] Clamp the values returned from PerfDataGetProcessorUsage() and PerfDataGetProcessorSystemUsage() inside these functions.
0.4.15-dev-6118-g 7b53126375 [TASKMGR] Completely reformat perfpage.c, perfpage.h, procpage.h and trayicon.c
partially 0.4.15-dev-6117-g da7dcec6a0 [TASKMGR] Reformat the files' headers
0.4.15-dev-6115-g 36aea8e56e [TASKMGR] affinity.c: Use _countof instead of sizeof/sizeof (was part of the larger CORE18991)
partially 0.4.15-dev-6109-g 99fb812be4 [TASKMGR] Refactor trayicon.c
0.4.15-dev-5404-g c093d4f803 [TASKMGR] Prevent context menu on idle process (#4889) CORE-18640
0.4.15-dev-5031-g 46ea5171bd [TASKMGR] Pixel-perfection for left border (#4680) CORE-18061
0.4.15-dev-4988-g de5af76811 [TASKMGR] Fix overlapping controls (French only) (#4658)
0.4.15-dev-4987-g f8c28b9773 [TASKMGR] Fix UI on SwitchTo for multiple application (#4652)
0.4.15-dev-3497-g e8a7e0da2b [TASKMGR] Make 'Hide When Minimized' non-default (#4169)
0.4.15-dev-3085-g 515e0cf38f [TASKMGR] Handles: Get number only, skip data (#3910)
and a few *.rc improvements that are not explicitly mentioned here,
especially I stripped the menuLoop-statusbar-help-texts within the older branches.
I also port back the following feature into all releases down to releases/0.4.8, but I left out releases/0.4.7 for now:
0.4.13-dev-875-g 3276824586 [TASKMGR] Implement proper process tree ending (#1738)
A few improvements are still left to be done in a future commit (mostly around the plotgraphs and the trayicon-handling),
but I need to have a closer look at them and their impact on binary size,
so I do not want to squash them into this bigger backport,
where I concentrated on the safe/obvious and easy things.
Binary size decreases for all branches:
master taskmgr.exe RosBEWin2.2.2 GCC8.4.0dbg 708.608 -> 696.832 (0.4.15-dev-6768-g63eaf2b)
0.4.14 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 660.992 -> 549.888
0.4.13 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 659.968 -> 542.720
0.4.12 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 662.016 -> 545.792
0.4.11 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 662.016 -> 545.792
0.4.10 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 645.120 -> 532.480
0.4. 9 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 645.120 -> 532.480
0.4. 8 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 645.120 -> 532.480
0.4. 7 taskmgr.exe RosBEWin2.1.6 GCC4.7.2dbg 645.120 -> 531.456
taskmgr.exe MS XPSP3 german 140.800 Bytes
0.4.14 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=de-DE -> 110.080 Bytes (my current taskmgr of choice)
0.4. 8 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US -> 108.032 Bytes
0.4. 7 taskmgr.exe RosBEWin2.1.6 MSVC2010SP1rls I18N=en-US -> 107.520 Bytes
Because we reverted [WINHTTP] in releases/0.4.9 and releases/0.4.10 and releases/0.4.11
to the state before 9048599788 (==SVN r75944) which was WineStaging-2.9
Ftr: Back then the winhttp_winetest was not reverted as well, which makes a few of the tests hang. (which is one but not the only reason)
Current state of those tests:
0.4.14-release-93-g10d0e9b RosBELin GCC8.4.0 does not hang 'most of the times' but sometimes it does, later during 0.4.15-dev even more tests were disabled here
0.4.14-release-93-g10d0e9b RosBEWin2.1.6dbg winhhtp.dll 301.568 Winestaging-4.18 kernel32_vista-dep winhttp_apitest 21executed, 1failure winhttp_winetest notification 643executed, 26fail, 1skip winhttp_winetest url 243executed, 1failure winhttp_winetest winhttp 4964executed, 14failures, 1skip
0.4.13-release-159-ge70a565 RosBEWin2.1.6dbg winhhtp.dll 301.568 Winestaging-4.18 kernel32_vista-dep winhttp_apitest 21executed, 1failure winhttp_winetest notification 409executed, 26fail, 1skip winhttp_winetest url 223executed, 1failure winhttp_winetest winhttp (hangs more than 5minutes)
0.4.12-release-188-gd73c71e RosBEWin2.1.6dbg winhttp.dll 303.616 Winestaging-3.9 kernel32_vista-dep winhttp_apitest 21executed, 1failure winhttp_winetest notification 409executed, 26fail, 1skip winhttp_winetest url 223executed, 1failure winhhtp_winetest winhhtp 5037executed, 15failures, 0skip
0.4.11-release-197-gdbcd8aa RosBEWin2.1.6dbg winhhtp.dll 297.984 Winestaging-2.9 winhttp_apitest 21executed, 1failure winhttp_winetest notification (hangs more than 5minutes) winhttp_winetest url 223executed, 1failure winhttp_winetest winhttp (hangs more than 5minutes)
0.4.10-release-214-g711e70c RosBEWin2.1.6dbg winhhtp.dll 295.424 Winestaging-2.9
0.4.9-release-225-g9ff478e RosBEWin2.1.6dbg winhttp.dll 295.424 Winestaging-2.9 winhttp_apitest 21executed, 1failure winhttp_winetest notification (hangs more than 5minutes) winhttp_winetest url 223executed, 1failure winhttp_winetest winhttp (hangs more than 5minutes)
0.4.8-release-234-g862997f RosBEWin2.1.6dbg winhttp.dll 302.592 Wine-3.0 kernel32_vista-dep winhttp_apitest 21executed, 1failure winhttp_winetest notification 409executed, 26fail, 1skip winhttp_winetest url 223executed, 1failure winhttp_winetest winhttp 5028executed, 12failures
0.4.7-release-263-g0c09cd7 RosBEWin2.1.6dbg winhttp.dll 301.056 WineStaging-2.16 kernel32_vista-dep winhttp_apitest 21executed, 1failure winhttp_winetest notification (hangs more than 5minutes) winhttp_winetest url 223executed, 1failure winhttp_winetest winhttp 5015executed, 12failures
We toggled some of the hanging tests in:
0.4.14-dev-787-g 0685e02d9e workaround more tests in winhttp:winhttp hang
0.4.14-dev-717-g 68490c1613 Restore winhttp:notification test_persistent_connection execution
0.4.8-dev-861-g 89670a48ab workaround winhttp:notification test_persistent_connection hang
0.4.8-dev-237-g a22031dba6 workaround winhttp:notification test_persistent_connection hang
Since the testbots do no longer run with the GCC4.7.2 builds, it does not really make a lot of sense to port any of those workarounds back atm.
I do consider none of the above states really desireable, therefore I don't touch the mess today, just document it.
I dislike: the kernel32_vista-dep.
I dislike: the behavior in the synthetic tests.
I appreciate: In practice all of the above do behave rather sane in most practical (non-synthetic) tests.
Remember: The Flash-ONLINE-setups are broken also on XPSP3. We should not accept that as a valid testcase. That does not work even in 0.4.9RosBEWin2.1.6 / 0.4.13RosBEWin2.1.6 / 0.4.14RosBEWin2.1.6! Despite what the ticket CORE-13952 says. It lies!
Flash OFFLINE setup from rapps works. The app is discontinued.
I could imagine in the future:
-downgrade releases/0.4.8 and 0.4.7 also back to Winestaging 2.9 to kill the kernel32_vista-import. (Could be done with or without suppressing the hangs in the [too new] synthetic tests)
-observe whether releases/0.4.13 has any other issues in winhhtp-context, and if so we might want to step back to Winestaging-3.9 (the natural fit).
But not today.
The reverts were questionable from the standpoint of the synthetic tests and also
from the standpoint of the broken "Adobe Flash Online Updater". They might work by chance on the linux builds, but that does not transfer to the Windows builds. And most likely points to some (memory) corruption.
Reverts could only be justified by the kernel_vista removal.
ports back the following commits:
0.4.15-dev-3822-g 78a7d7dc32 [CMIDRIVER] Remove useless Visual Studio resource editor aps-file
0.4.12-dev-399-g 32faa24733 [BUTTERFLIES] Fix GCC build, addendum to 0.4.12-dev-397-g 2890a22179
a tiny fraction of 0.4.12-dev-397-g 2890a22179 just the [BUTTERFLIES] Avoid DLGPROC cast
Ftr, there are still a few DLGPROC casts left after this commit in ros source tree,
but I don't want to port back the commits yet, which addressed them.
Too fresh still, no need to rush that.
port back the following commit:
0.4.15-dev-6613-g e13ebd44c6 [USER32] Pure Whitespace sync from comctl32/combo.c, no functional change
0.4.15-dev-6612-g d97313181e [USER32] Sync comctl32 combo.c code in context of CORE-17883
0.4.15-dev-3453-g ff89651ed0 [COMCTL32] Redraw children when the combo box is dropped down (#4138) CORE-17883
and tweak [USER32] combo.c a bit more even than on master, e.g. strip a few TRACEs. Possible because
unlike master we don't need to be as much in sync as possible to Wine in the older branches.
But we need to have binary size under control for the backports due to base-addresses.
Binary size:
user32.dll master RosBEWin2.2.2 GCC8.4.0dbg 1.579.008
user32.dll 0.4.14rls RosBEWin2.1.6 GCC4.7.2dbg 1.448.448 -> 1.448.448
user32.dll 0.4.13rls RosBEWin2.1.6 GCC4.7.2dbg 1.445.376 -> 1.444.864
user32.dll 0.4.12rls RosBEWin2.1.6 GCC4.7.2dbg 1.455.616 -> 1.455.104
user32.dll 0.4.11rls RosBEWin2.1.6 GCC4.7.2dbg 1.453.056 -> 1.451.008
user32.dll 0.4.10rls RosBEWin2.1.6 GCC4.7.2dbg 1.434.624 -> 1.434.112
user32.dll 0.4. 9rls RosBEWin2.1.6 GCC4.7.2dbg 1.422.336 -> 1.421.824
user32.dll 0.4. 8rls RosBEWin2.1.6 GCC4.7.2dbg 1.421.824 -> 1.421.824
user32.dll 0.4. 7rls RosBEWin2.1.6 GCC4.7.2dbg 1.418.752 -> 1.417.216
port back:
0.4.15-dev-6456-g 918a818071 [WINESYNC][COMCTL32] Listview: Initialize marqueeRect from left-click coordinates before starting a marquee highlight (#5555)
The infoPtr->marqueeRect structure is not currently initialized before the
marquee highlight sequence starts, resulting in the RECT having initial
coordinates of (0,0)-(0,0). These coordinates cause the first item in
the listview control to be identified as being within the range of the
marqueeRect's coordinates. This can be best observed when our filebrowser is in details-mode.
That item is then set to LVIS_SELECTED even though it is not part of the
marquee selection.
Wine commit: daf95aaadf3a59f0ccc129a853327417b5e4f07c
author: Hugh McMaster <hugh.mcmaster@outlook.com>
Mon, 26 Apr 2021 10:59:51 +0000 (20:59 +1000)
---------------
Also fix CORE-16650 'VB6 installation does not show the wizard correctly'
by porting back:
0.4.14-dev-844-g ea35843c30 [COMCTL] Use DIALOG instead of DIALOGEX resources (#2270)
This is needed, because property sheets can modify the dialog resource,
and example code (and some existing applications) expect DIALOG.
One such application is the VB6 setup.
CORE-16650
---------------
also port back a few other trivial improvements from never branches, e.g.:
a tiny fraction of 0.4.14-dev-150-g 00f14ee1f2 the type/cast-changes in LISTVIEW_MouseWheel()
---------------
0.4.13-dev-26-g 6122f3f436 [COMCTL32] Remove an unnecessary include
---------------
and port back also a few trivial RC improvements, mainly to keep binary size under control.
Binary size:
comctl32.dll master RosBEWin2.2.2 GCC8.4.0dbg 1.999.872
comctl32.dll 0.4.14rls RosBEWin2.1.6 GCC4.7.2dbg 1.808.896 -> 1.808.896
comctl32.dll 0.4.13rls RosBEWin2.1.6 GCC4.7.2dbg 1.810.944 -> 1.805.312
comctl32.dll 0.4.12rls RosBEWin2.1.6 GCC4.7.2dbg 1.823.232 -> 1.818.112
comctl32.dll 0.4.11rls RosBEWin2.1.6 GCC4.7.2dbg 1.816.064 -> 1.810.944
comctl32.dll 0.4.10rls RosBEWin2.1.6 GCC4.7.2dbg 1.813.504 -> 1.808.384
comctl32.dll 0.4. 9rls RosBEWin2.1.6 GCC4.7.2dbg 1.813.504 -> 1.808.384
comctl32.dll 0.4. 8rls RosBEWin2.1.6 GCC4.7.2dbg 1.639.424 -> 1.634.304
comctl32.dll 0.4. 7rls RosBEWin2.1.6 GCC4.7.2dbg 1.634.304 -> 1.629.184
This ports back the following commits about lossless PNG-shrinking:
0.4.15-dev-6410-g cf4bb8fced [WALLPAPERS] Optimize PNG images (#5506)
0.4.15-dev-6398-g e5993f13f0 [REACTOS] Optimize PNG images (#5492)
0.4.15-dev-6376-g 8f3a09722e [MSPAINT] Optimize images for help docs (#5486)
Most of those PNGs have not been touched ever since we switched from SVN to git, so they can safely be ported back by copying over.
But did not port them back any further than where they existed already.
Tweak a few related txt/html files also with trivial stuff like EOL-whitespace-removal.
This effective one-liner-backport fixes flickering in some apps like:
- CORE-7652 Hyperlink Blinking text while installing vc2008 redist package
and many duplicate-tickets of that same symptom, like:
- CORE-18553 CPUID CPU-Z 1.84 "about" flickers
- CORE-7753 Caesar 3: Autorun.exe flickers endlessly
- CORE-10741 API monitor high CPU usage
- CORE-15300 Worksoft Navigator 0.985 installer is locked in an endless redrawing loop
- CORE-16325 Some of MWSnap's installation windows fail to display content
- CORE-17925 MS Visual C++ 2008 Redistributable Setup takes long time
- CORE-18153 BitComet 1.86 forces the shell to a endless redrawing
- CORE-18434 Ubisoft installers (SetupUbi) - continously refresh of window
- CORE-15546 Shed 1.0 from rapps - setup does not draw some dlgs initially, but redraw can be enforced
- CORE-18582 Emule 0.50a - Interface frozen / flickering until window is moved
And since I do also port back the follow-up-commit of that, we can achieve that without introducing
the following regressions which the initial fixes caused:
- CORE-18817 [NTUSER] Winpos.c modification generates bad first drawing of some elements
- CORE-18830 Explorer Drawing glitch: Missing "X" on "Folder" pane when Right Click > Explore from Desktop icons
Those 2 things did not happen in the older releases beforehand.
In sum this is a squashed backport of:
0.4.15-dev-6507-g 49dbc8fbbb [NTUSER] Whitespace-fixes winpos.c
0.4.15-dev-5684-g 57eb2a6bf4 [NTUSER] Missing "X" on "Folder" pane when Right Click > Explore from Desktop icons & Rapps toolbar errors (#5068) CORE-18830, CORE-18817
the superseded 0.4.15-dev-5618-g 8866b9d7b0 Update win32ss/user/ntuser/winpos.c
the superseded 0.4.15-dev-5617-g 7866eb2886 [NTUSER] Fix winpos bug hyperlink&images loop redrawing CORE-7652 (#4995)
To prevent increased binary size for the added conditions in the code in older branches, strip a single good-path-TRACE()
which had no trailing \n in the older branches,
but where that \n was added in master head meanwhile. So that TRACE was a diff to older branches anyway.
Don't call ClientToScreen in handling NM_RCLICK message because NMMOUSE.pt is already in screen coordinates.
CORE-18966
A backport of:
0.4.15-dev-6298-g b4e946f5b0
and strip EOL whitespace
For some reason I accidentally forgot to add the CMakeLists.txt to the previous commit and left it in my workspace.
Sorry, this happened only in releases/0.4.11 but in no other branch.
So this actually brings all that I wanted to have from:
0.4.12-dev-237-g 446e13745c [ADVAPI32] Stop pretending our advapi32 is NT6+, inconsistent TEB definitions CORE-15526
Ports back:
0.4.15-dev-5910-g 99e5f51d5b
in a slightly adapted form, which respects that we were still
a "Team" in 0.4.7 - 0.4.14 and no "Project" yet.
The idea with the "Project" was born during 0.4.15-dev'ing.
That existing difference does also manifest in media/inf/*.inf and I don't intend to
ever change that for the older branches.
That means also that in the older branches we do not need to scroll at all to
see all the text.
Also adopt ReactOS birth year from 1998 to 1996 which we do also use in the msgina startup-dlgs-pics
all the way from releases/0.4.7 at least to todays master head.
Actually I was working on a much bigger commit in the same context for releases/0.4.7
when I realized that related glitches do also affect master head
and also other release-branches in some areas.
this ports back (also) the following commit:
0.4.15-dev-6308-g 2d9877470d
While touching those files, port back some minor translation improvements also.
partially 0.4.15-dev-6292-g 5f533bd019 [RAPPS] Update *.rc
partially 0.4.15-dev-6280-g ec974d8a81 [RAPPS] Main toolbar: Tooltip strings refactoring (#5007)
and pick some other translation improvements from master, strip outdated email-addresses
releases/0.4.7 - releases/0.4.11: Had a bug regarding category "Selected for installation",
it was populated with garbage after starting up the app. The bug in ReactOS is outside of the rapps source-folder.
So I decided to delay introduction of that feature to releases/0.4.12
by porting back:
0.4.15-dev-6231-g a5360f542f [IPHLPAPI] Formatting only, no functional change
partially 0.4.15-dev-4492-g 03422451b3 [IPHLPAPI] Add a missing \n in an ERR() logging within ipstats_reactos.c getNumRoutes(). And strip a good-path TRACE in return in the same func.
partially 0.4.14-dev-1425-g f540b2b20c [IPHLPAPI] GetAdaptersAddresses(): Add 1 free() in ERROR_NO_DATA case (#2526) (but leave out adding the comments in .h)
partially 0.4.13-dev-14-g f9a967b2ae [IPHLPAPI] Fix misc 64 bit issues (only the parts in iphlpapi_main.c with the format strings)
0.4.12-dev-686-g 22f60faf43 [IPHLPAPI] Remove dead code to fix CID 513306, 1442673, 1442697
only whitespace fixes within [TCPIP][IP][LWIP]
fix CORE-18328 'FileZilla 3.8 unable to list content of a remote directory due to undue ECONNRESET'
I tested to list the contents of ftp.heise.de and downloaded some files from its pub.
by porting back:
0.4.15-dev-5870-g 9f9b81e396 [AFD] ReceiveActivity: Don't return STATUS_FILE_CLOSED in case of FCB overread CORE-18328 (#4972)
Prevent the window from being destroyed twice
fixes CORE-18821 'WIN32K BSOD 0x1E when opening Build menu in AVR Studio 4.19'
port of 0.4.15-dev-5938-g 77d4653164
And port back also some unrelated formatting improvements,
and kill a block of code that was commented out in all branches,
and was not x64 compatible in 0.4.7/0.4.8, and therefore was a diff already anyway.
Optimize IOCTL_CONSOLE_FILL_OUTPUT_ATTRIBUTE and IOCTL_CONSOLE_FILL_OUTPUT_CHARACTER for speed by using cache.
a part of CORE-18838
It is faster because it minimizes the amount of pointer dereferences within the for-loops.
fix picked from 0.4.15-dev-5881-g 3526ffc094
---------
also partially pick unrelated cleanup from:
0.4.14-dev-439-g 75f188c200 (only the change in blue.c)
---------
and take back with me some whitespace-tweaks to bring the file closer to todays releases/0.4.14
0.4.15-dev-5985-g 31fdaca8c0 [REGEDIT] Strip redundant include, minor formatting (#5264)
0.4.15-dev-5970-g 9d7d3314b3 [REGEDIT] Check whether pszSelectKey is NULL on CDN_FILEOK (#5255)
0.4.15-dev-5898-g 84e580b67e [REGEDIT] Fix ListView selection and finding (#5150)
(superseded) 0.4.15-dev-5802-g cce3eb9393 Fix buffer read past end problem. (#5146) CORE-15896 and CORE-18230
partially 0.4.15-dev-5753-g 1ee9ea4518 [REGEDIT] Avoid buffer overflow in SelectNode. CORE-18602 (I left the wscpy-replacement at the end for the fixed size strings, as they would increase binary size, and are totally safe)
partially 0.4.15-dev-5308-g 5daf5cd057 [REGEDIT] Use shell icons for the tree view (#4841) CORE-10764
0.4.15-dev-4850-g 568383c9b9 [REGEDIT] Fix issue at Find registry key (#4341)
partially 0.4.15-dev-2265-g bebdfda8b7 [REGEDIT]... Use newer file open dialog (#3571)
0.4.15-dev-1470-g 9de8787187 [REGEDIT] Display search finished messagebox when using Find Next (F3) menu item (#3371) CORE-17368
0.4.15-dev-1302-g 6aae5f4fdd [REGEDIT] Make "finished find" messagebox owned by Regedit window (#3369) CORE-17367
0.4.15-dev-169-g 0461de33c5 [REGEDIT] Fix HeapFree() on the wrong variable (#2736)
0.4.14-dev-1484-g c832112771 [REGEDIT] Fix tree view popup menu issues CORE-16887
0.4.14-dev-1468-g 763de230b2 [REGEDIT] Fix inconsistent menu state for 'Permissions' CORE-16889
a more efficient solution than 0.4.14-dev-1467-g b280615b85 [REGEDIT] Crash on selecting 'New' on root item 'My computer' CORE-16888
0.4.14-dev-1466-g 13dd917589 [REGEDIT] CORE-16892 fr-FR Translation update
0.4.13-dev-464-g 6b95727282 [REGEDIT] Adjust ListView column widths (#1663) CORE-15187
0.4.12-dev-47-g 63a0ac0461 [REGEDIT] Set background brush to child window (#1122) CORE-15442
a few fragments only of 0.4.15-dev-5304-g 36a7f0dc7c [REGEDIT] framewnd.c resize_frame_rect(), main.h strip externs before func declarations and reordering, treeview.c InitTreeViewImageLists()
also port back a few selected translation improvements, and strip the suggestions-feature in older branches <= 0.4.13 which does not exist in 2k3sp2.
port back:
0.4.15-dev-5901-g c37addcbf5 [CONSOLE] Harmonize IDC_LBOX_FONTTYPE height to 40 for *.rc (#5211), tweak some headers
and partially 0.4.15-dev-5503-g 5123edd731 [CONSOLE] Improve font preview and Update de-DE.rc (#4933)
and also pick a few other rc improvements here and there, mainly dupe-accelerator-fixes, and whitespace+logmuting in some .c
0.4.15-dev-5890-g 56bf3969cd [SYSSETUP] Tweak IDD_COMPUTERPAGE positioning (#5158)
0.4.15-dev-5875-g 7c755d9b84 [SYSSETUP] Delete obsolete lt-LT.rc
0.4.15-dev-5874-g c762234546 [SYSSETUP] Fix font glitch in ja-JP.rc (#5192)
0.4.15-dev-5871-g 3963d7d5f2 [SYSSETUP] Delete obsolete fi-FI.rc
0.4.15-dev-5772-g 784946db8c [SYSSETUP] Tweak resources CORE-18870
0.4.15-dev-5732-g 909b165c4a [SYSSETUP] Removed qemu credit entirely (#4971)
0.4.15-dev-5678-g cc54ecd779 [SYSSETUP] Fix a space-typo in IDS_WZD_PASSWORDEMPTY for *.rc (#5049)
0.4.15-dev-1102-g ad4c174eb6 [SYSSETUP] fr-FR: Change keyboard accelerator for Owner Organization field (#3282)
0.4.14-dev-1445-g 173a2af48c CORE-16874 [SYSSETUP] Update authors page in second stage setup
(that part got unhidden by 0.4.10-dev-466-g 35f62fc5ba . Picked as one of the needed preparations in case I would ever port back the guilty rev later)
and a few other gems from other partially picked master-commits that are not explicitly mentioned here.
--------
Also strip the IDC_LOCALETEXT and IDC_LAYOUTTEXT from the resources as that was only implemented in releases/0.4.15,
is even today still not properly localized there, they changed their dimensions again with that
and I don't intend to port that back anytime soon. And if I ever will, then all the resources would need to be touched again anyway.
--------
0.4.11 zh-CN.rc lacked the GPL button, although it was present in releases/0.4.10 and releases/0.4.12. Fixed that as well.
port back:
0.4.15-dev-5785-g c766ee9ebb CORE-18874 [NETSHELL] Shrink radio buttons vertically (#5157)
0.4.14-dev-1481-g fff2fc9327 CORE-16903 [NETSHELL] RC Overhaul all languages IDD_LAN_NETSTATUS & IDD_LAN_NETSTATUSADVANCED
0.4.14-dev-293-g 2b39b42a0a CORE-15248 [NETSHELL] Fix checkboxes in the network adapter properties
partially 0.4.12-dev-315-g 01e5cb0c04 [NETSHELL] Fix incorrect resource IDs.
and port back also a few other small RC-improvements from master here and there
0.4.15-dev-5102-g 18d40ebe81 [BOOTDATA] hivesys.inf: Remove redundant fastfat "Start" entry. The one in the [AddReg] section has the very same value.
-------
0.4.15-dev-5012-g e3f8f52f3d [BOOTDATA] Delete "Layout Id" from Japanese/Korean Keyboard Layout
Katayama explained: These registry values are for pre-installed IMEs we don't have. It is safe to remove them also in the older branches.
-------
0.4.15-dev-4352-g cfe387a9b0 [BOOTDATA] Add two missing separating commas in the ServiceGroupOrder List multi-string.
-------
PARTIALLY PICK: 0.4.15-dev-4412-g 94d144f8a5 [BOOTDATA] Fix some services groups
- AudioSrv belongs to "AudioGroup" (and not "Audio" that doesn't exist).
- lanmanworkstation belongs to "NetworkProvider" (without a space).
I dared only to pick the "NetworkProvider" and "AudioGroup" part for now. The MUP part I might do later when actually being able to retest CORE12107 "VMWare tools" myself.
-------
0.4.15-dev-1097-g 0689455bb3 [BOOTDATA] Comment out biosinfo.inf (#3266)
This allows ros to boot with its LiveCD files using MS NTLDR!
I stripped the line here, instead of commenting it as the master commit did. The file does not exist.
-------
Additionally to those backports I cleaned up some of the stuff that was previously commented out and/or broken:
- instead of following 0.4.15-dev-3322-g c6e002bfb3 to fix the Latvian kbdlv1.dll QUERTY->QWERTY typo, I just stripped those lines, as
they are commented out anyway. And were added in the broken and already commented way by 0.4.9-dev-825-g c2089d5319
We never had them active. No such file even.
- Also strip some 'translated' service strings that were just copy-pasted from the english strings section
without actually getting translated at all. The english ones will be used anyway.
It is enough to have that redundant stuff in master to allow translators to see it.
- Also strip the disabled kbdfo.dll Faeroese keyboard layout. Enough to have those commented lines in master as a TODO reminder. Was never active ever. No such file even.
- Also strip the disabled BENGALI_INSCRIPT kbdinben.dll. Where the existing lines even had bugs in the older branches as proven by 0.4.15-dev-3322-g c6e002bfb3
It was always disabled and was neither localizable, nor did it have the correct layout code even. No such file even.
None of those changes will introduce any additional diff or break any existing features.
They just slightly move the already existing diffs position in time towards newer release-branches.
by porting back:
0.4.15-dev-5784-g 2aea4ab945 [NTUSER] Scrollbar.c pure whitespace fixes
0.4.15-dev-5680-g 5ad5737370 CORE-18050 [NTUSER] Delete temporary workarounds in co_IntSetScrollInfo() (#4985)
0.4.15-dev-5355-g 0484beb04b CORE-18593 [NTUSER] Don't redraw scrollbar if it is hidden command prompt (#4849)
0.4.15-dev-4492-g 03422451b3 Add '\n' to debug logs (partially, only the scrollbar.c part)
0.4.15-dev-3875-g 977c129f33 CORE-18048 [USER32] SetScrollPos should not bypass UserApiHook (#4372)
0.4.15-dev-3849-g fd28a69de6 CORE-17780 [WIN32SS] Store the scrollbar theming enabled flag in the scrollbar (#4367)
0.4.15-dev-3175-g 222acf5a3e CORE-17777 [NTUSER] Scrollbar.c, Avoid potential out-of-bounds-accesses in co_IntSetScrollInfo()
0.4.15-dev-3174-g dda9c3979e CORE-17769 'Rapps Listview manual resize may erroneously not draw the triangles sometimes'
0.4.15-dev-3147-g 3bf7e3ac13 CORE-17754 and CORE-17755 [NTUSER] Improve Themed Scrollbars by Minimizing Updates (#3953)
0.4.15-dev-3086-g 236649c626 CORE-16375 [UXTHEME][NTUSER] Fix flashing of scrollbar when scrolling (#3868)
0.4.15-dev-2375-g ffea5152e6 [WIN32SS][NTUSER] Fix an integer underflow within scrollbar info setting
0.4.14-dev-1134-g 00adb1a3f9 [WIN32SS] Improve Drawing Scrollbars
- CORE-14755 fixed, flashing scrollbar triangles (we know 131 affected apps just from rapps!)
- CORE-13931 fixed, FamiTracker invisible about-dlg
- CORE-14685 improves a bit, but is not entirely fixed
- CORE-11561 'Notepad scrollbars problem' fixed
This will also speed up NSIS installers that display their file-copy-progress by
a self-scrolling listview.
by partially porting back:
0.4.15-dev-xxx [WMISVC][WUAUSERV] Fix 2 DPRINTs that lack arguments
0.4.13-dev-684-g eab73ad1a4 [SRVSVC] Make the server service stoppable
0.4.13-dev-683-g 4073a8c58d [WKSSVC] Make the workstation service stoppable
0.4.13-dev-680-g eb532bc641 [WMISVC] Accept stop and shutdown commands when the service is running
0.4.12-dev-1063-g 15a828c86d [DHCPCSVC] Eliminate unused code and associated parameters
and revert 0.4.10-dev-558-g 55368bacc8 (#355) [WUAUSERV][WUSA]
on this branch as that Service stub does not even start in releases/0.4.10-0.4.12.
And it doesn't allow any application to run that wouldn't have run before.
Even with those changes the .NET4.5 and Python 3.5 mentioned in that PR don't work yet.
We postpone introduction of WUAUSERV to releases/0.4.13 therefore.
VC1 Linker fills BSS.SizeOfRawData with data in IMAGE_OPTIONAL_HEADER.SizeOfUninitializedData but keeps PointerToRawData to zero.
Fixes CORE-18797 and some duplicates of that. (Apps, e.g. Doom95, compiled with Watcom-C-compilers wouldn't run otherwise.)
which regressed by
0.4.10-dev-136-g c7eb46d9fd
fix picked from
0.4.15-dev-5589-g 0d4a8d0ea6
----------
Port back also some unrelated formatting-improvements within section.c, e.g.: return(xyz) -> return xyz
A *partial* port of
0.4.15-dev-1793-g b7eb0fddf3
----------
Port back also
0.4.12-dev-973-g d29e216f99
[NTOSKRNL] In MmCreateImageSection, properly check whether cache was initialized
This fixes a crash that occurs if nul is typed in cmd.exe (BSOD0x1E)
