Commit graph

41888 commits

Author SHA1 Message Date
Eric Kohl 39eeae29f8 [SERVICES]
Disable more debug messages.

svn path=/trunk/; revision=51439
2011-04-23 14:40:30 +00:00
Eric Kohl 5e449dfe39 [NPFS]
Silence some debug messages.

svn path=/trunk/; revision=51438
2011-04-23 11:26:16 +00:00
Eric Kohl 2ec4368714 [CLASS2]
Prepare ReactOS for the change from the ancient 32 sectors / 64 tracks disk layout (used until Windows NT4) to the modern 63 sectors / 255 tracks disk layout (used since Windows 2000).

svn path=/trunk/; revision=51437
2011-04-23 10:52:01 +00:00
Gregor Schneider 87a668d95f [shell32] Split declarations and operations, in case any pure C compiler cares
svn path=/trunk/; revision=51436
2011-04-22 22:58:09 +00:00
Gregor Schneider 2fda6e7d2a [shell32] Pass an argument array to FormatMessage to insert the filename details into error messages (instead of failing)
See issue #5977 for more details.

svn path=/trunk/; revision=51435
2011-04-22 22:53:31 +00:00
Gregor Schneider 6a89b41bff [ipconfig] Respect the size parameter in the LoadStringAndOem helper function, fixes "ipconfig /?"
See issue #6146 for more details.

svn path=/trunk/; revision=51434
2011-04-22 21:29:30 +00:00
Eric Kohl 63bd3c88e9 [SERVICES]
RChangeServiceConfig2W: Use the error code of a call to RegSetValueExW.

svn path=/trunk/; revision=51429
2011-04-22 15:18:31 +00:00
Amine Khaldi d05dbec4a3 [NETID]
* Use EDITTEXT instead of LTEXT. Patch by Edijs Kolesnikovics <terminedijs at yahoo dot com>
See issue #6129 for more details.

svn path=/trunk/; revision=51428
2011-04-22 14:23:49 +00:00
Eric Kohl d58660ce71 [SERVICES]
Lock the service database in order to protect it from concurrent access.

svn path=/trunk/; revision=51427
2011-04-22 14:09:21 +00:00
Amine Khaldi 295e7d388c [Translations]
* explorer-new: Fix some wrong UK and RU translations.
* shell32: Update UK and RU translations.
* Patch by Igor Paliychuk <mansonigor at gmail dot com>

svn path=/trunk/; revision=51426
2011-04-22 14:07:22 +00:00
Gabriel Ilardi b0d9033638 [shimgvw]
Add Italian translation.
[mplay32]
Fix Italian translation for play.

svn path=/trunk/; revision=51424
2011-04-22 12:30:50 +00:00
Rafal Harabien d8e1c6609b [MPLAY32]
* Move "Play" string from shell32. It will be used in audio files context menu in explorer

[SHIMGVW]
* Move "Preview" string from shell32. It will be used in image files context menu in explorer
* Add Polish translation

[SHELL32]
* Remove "Play" and "Preview" translations - they shouldn't be in shell32
* Add "explore" translation for folder context menu

svn path=/trunk/; revision=51423
2011-04-22 11:51:08 +00:00
Gregor Schneider 0314742b01 [kernel32] Radek Liska: sync czech NLS resources to Wine
See issue #6122 for more details.

svn path=/trunk/; revision=51419
2011-04-21 21:59:17 +00:00
Timo Kreuzer 3b11a6bdbc [CRT]
Fix a typo in a comment

svn path=/trunk/; revision=51418
2011-04-21 21:49:46 +00:00
Timo Kreuzer 35a1d66de7 [WIN32K/GDI32]
Add official ENTRY structure definition

svn path=/trunk/; revision=51417
2011-04-21 21:48:24 +00:00
Gregor Schneider 7037613d3d [cardlib] Install a button release callback
[spider] Use the button release callback instead of button click callbacks
See issue #6125 for more details.

svn path=/trunk/; revision=51416
2011-04-21 21:25:30 +00:00
Gregor Schneider f3aa24aa4f Rename paint to mspaint to maintain script compatibility
See issue #6071 for more details.

svn path=/trunk/; revision=51415
2011-04-21 21:05:47 +00:00
James Tabor a6294542d0 - Add Unicows to packing list.
svn path=/trunk/; revision=51414
2011-04-21 16:43:52 +00:00
Rafal Harabien a861f7c282 [KERNEL32]
* Properly check if buffer given to GetComputerName is too small. Fixes hostname.exe if computer name is MAX_COMPUTERNAME_LENGTH long (the default for bootcd since it's generated randomly in Setup).
* Simplify it a bit

svn path=/trunk/; revision=51412
2011-04-20 21:31:41 +00:00
Timo Kreuzer be4bb69ef8 [WIN32K]
Don't try to lock a dcs clip region if its NULL

svn path=/trunk/; revision=51411
2011-04-20 21:10:13 +00:00
Rafal Harabien 1e27c057e4 [FLOPPY]
Formatting only, no code changes.

svn path=/trunk/; revision=51410
2011-04-20 18:13:27 +00:00
Rafal Harabien 057f42a554 [FLOPPY]
Increase floppy drives count in global ConfigurationInformation. Fixes not working floppies in explorer.
See issue #4236 for more details.

svn path=/trunk/; revision=51409
2011-04-20 17:44:12 +00:00
James Tabor a75c77dfa7 [Unicows]
- Import wine unicows for Adobe Reader 7.1.0. See bug 5560.

svn path=/trunk/; revision=51408
2011-04-20 04:55:08 +00:00
James Tabor 81a19f5ad5 [Win32k]
- This should fix the dcattr leaked when deleting a DC, See bug 6119.

svn path=/trunk/; revision=51405
2011-04-19 18:18:19 +00:00
James Tabor b307a60502 [Win32k]
- Replace patch point for forced DC removal. See bug 6119.

svn path=/trunk/; revision=51403
2011-04-19 17:18:05 +00:00
Gabriel Ilardi e3c5f3cdd8 [win32csr/file.c]
Add missing new lines to some DPRINT1

svn path=/trunk/; revision=51399
2011-04-19 07:59:23 +00:00
Amine Khaldi 27bd630de0 * Fix build.
svn path=/trunk/; revision=51395
2011-04-18 22:17:25 +00:00
Aleksey Bragin a63e424516 Sam Arun Raj Seeniraj:
[KERNEL32]
- DefineDosDeviceW() is implemented and calls into csrss.exe CsrDefineDosDevice().
- Fixed a minor bug in DefineDosDeviceA(), as calling RtlCreateUnicodeStringFromAsciiz() prevented NULL lpTargetPath to be passed down to DefineDosDeviceW().
- Fixed a minor bug in QueryDosDeviceW() that causes lpTargetPath buffer to be returned with NULL string terminator placed at the wrong point in the buffer.

[WIN32CSR.DLL]
- Implemented CsrDefineDosDevice() in win32csr.dll, the symbolic links are created in global name space currently.

[SUBST.EXE]
- Implemented a subst.exe clone.
See issue #993 for more details.

svn path=/trunk/; revision=51393
2011-04-18 21:48:19 +00:00
Timo Kreuzer 46662954bd [WIN32K]
- Use shared locks for surfaces and palettes

svn path=/trunk/; revision=51392
2011-04-18 19:09:05 +00:00
Timo Kreuzer 186ed6e13d [WIN32K]
Set ulShareCount of static palettes to 1, so they won't get dereferenced to 0

svn path=/trunk/; revision=51391
2011-04-18 14:15:18 +00:00
Giannis Adamopoulos f53d1fd407 [win32k]
- GetKeyboardState and SetKeyboardState should use the thread key state and not the global key state

svn path=/trunk/; revision=51389
2011-04-18 09:13:31 +00:00
Eric Kohl 1b2a6e5f37 [ADVAPI32]
Implement EnumServiceGroupW.

svn path=/trunk/; revision=51380
2011-04-17 14:43:32 +00:00
Giannis Adamopoulos 3026082bde [win32k]
- Improve IS_KBD_MESSAGE macro. Should fix some more tests

svn path=/trunk/; revision=51379
2011-04-17 12:33:29 +00:00
Eric Kohl 4321ac7baa [EVENTVWR]
- Change string resource id prefix from IDC to IDS.
- Add missing string resources.

svn path=/trunk/; revision=51378
2011-04-17 11:58:26 +00:00
Giannis Adamopoulos cde9d99bc3 [win32k]
- Do not distinguish left and right keys in WH_KEYBOARD and key messages. Based on wine
Fixes several tests

svn path=/trunk/; revision=51377
2011-04-17 10:38:06 +00:00
Olaf Siejka 9c44037679 [VIDEOPRT]
- Check for the correct, just created, registry key. Fix
a wrong comparison. Patch by Thomas Faber.
See issue #6123 for more details.

svn path=/trunk/; revision=51375
2011-04-17 10:20:22 +00:00
Matthias Kupfer 7ce75cdf13 fix accidentally set property svn:executable
svn path=/trunk/; revision=51374
2011-04-17 09:50:07 +00:00
Olaf Siejka 04603e0af6 [CALC]
- Swedish translation by Jaix Bly.

See issue #6113 for more details.

svn path=/trunk/; revision=51371
2011-04-16 22:29:55 +00:00
Olaf Siejka 7de326fe0e [VIDEOPRT]
- Fix whitespace and logic order (formatting only). Patch by Thomas Faber
See issue #6123 for more details.

svn path=/trunk/; revision=51370
2011-04-16 22:16:25 +00:00
Rafal Harabien 66a33a5246 [SYSSETUP]
* Generate random computer name (REACTOS-xxxxxxx) in Setup. Patch by David Quintana <gigaherz at gmail dot com> modified by me
See issue #6099 for more details.

svn path=/trunk/; revision=51358
2011-04-15 20:42:07 +00:00
Timo Kreuzer 46a8c8f9fa [WIN32K]
Implement gdi pool. An allocator for user mode gdi object attributes.
The old method allocated a 4k page for every object, wasting 4k physical memory and 64k address space (allcoation granularity)
The new allocator creates a per process pool for each object attribute type. Allocations are done from "sections" that start with 1 page and grow dynamically up to 64k, if neccessary a new section is allocated. This will use about 1/10 of memory for dc attributes and 1/512 for brush attributes. Also allocation is way faster. Caching object attributes is not neccessary anymore.

svn path=/trunk/; revision=51357
2011-04-15 20:14:44 +00:00
Rafal Harabien 99c3b4ec57 [WIN32K]
* Revert part of 37148. One FontGDI is used for fonts with different sizes. Do not cache font metrics then and instead calculate them every time when needed. It fixes spacing in menus if some application uses default GUI font with size other than 11.
See issue #4106 for more details.

svn path=/trunk/; revision=51356
2011-04-15 20:03:44 +00:00
Rafal Harabien 423497b1b2 [SYSSETUP]
* Fix information about computer name length limit in Setup. Translators: please review

svn path=/trunk/; revision=51354
2011-04-15 16:54:25 +00:00
Timo Kreuzer 197cf31913 [WIN32K]
- Use shared locks for surfaces and palettes

svn path=/trunk/; revision=51352
2011-04-15 15:29:08 +00:00
Timo Kreuzer 8357192be7 [WIN32K]
- Use shared locks for surfaces and palettes
- Unimplement NtGdiEngUnlockSurface, it was wrong

svn path=/trunk/; revision=51351
2011-04-15 15:20:17 +00:00
Rafal Harabien ce720bbf52 [SYSSETUP]
* Computer name length is limited to 15 characters, not 63. Fixes possible buffer overflow
* Spotted by Victor Martinez

svn path=/trunk/; revision=51349
2011-04-15 14:29:14 +00:00
Matthias Kupfer ae8ebc72e4 property svn:executable removed
svn path=/trunk/; revision=51347
2011-04-15 12:17:50 +00:00
Matthias Kupfer 706a9911e2 potential memory problem fixed, obsolete assignment removed
svn path=/trunk/; revision=51346
2011-04-15 12:16:26 +00:00
Michael Martin a2b8986a0d [win32k]
- Move dereferencing of the MessageQueue from co_UserDestroyWindow to co_UserFreeWindow.
A reference is added to the MessageQueue for all windows created.co_UserFreeWindow is called for all windows and needs to be where the dereferencing of MessageQueue occurs.
This fixes NonPagedPool memory leak. See bug 6112 for more info.

svn path=/trunk/; revision=51345
2011-04-15 07:10:00 +00:00
Michael Martin 3b717045b6 [usbdriver]
- KbdDispatch: Set Status vice IoStatus.Status for all branches of switch. Use break instead of goto intcontfailure.
The previous code would set Status to what ever was in the IoStatus.Status of the IRP and return that Status.
Some times this would be STATUS_PENDING, which IIRC is a no-no.
This caused the kbdclass to enter into a wait that would never be satisifed hence blocking the keyboard thread.
This should fix the failure of keyboard input bugs.

svn path=/trunk/; revision=51344
2011-04-15 06:44:13 +00:00
Aleksey Bragin 1b2e00d581 [RTL]
- If there is no data provided and parameters are valid, fail with STATUS_SXS_KEY_NOT_FOUND.

svn path=/trunk/; revision=51339
2011-04-14 12:20:47 +00:00
Amine Khaldi c512ea5c43 [TRANSLATIONS]
Igor Paliychuk (mansonigor at gmail dot com):
* Update Ukrainian localization.
* Leftover from r51055: Update reactos.exe strings and resource sizes.
* Fix displaying of doskey localizations.

svn path=/trunk/; revision=51338
2011-04-14 12:13:38 +00:00
Aleksey Bragin 9561880163 [RTL]
- Properly check parameters in RtlFindActivationContextSectionString. Almost the same as Wine did, but factored out into a standalone function, improved undocumented flags checks and allowing null data pointer in certain cases.

svn path=/trunk/; revision=51333
2011-04-14 09:57:08 +00:00
Michael Martin 3203ddd6e1 [Win32k]
- Fix implementation of message callbacks,  now callbacks can be called across processes. 
- Fix some comments.

svn path=/trunk/; revision=51332
2011-04-14 01:21:38 +00:00
Matthias Kupfer 1968375672 remove obsolete object handling
svn path=/trunk/; revision=51331
2011-04-13 20:20:16 +00:00
Giannis Adamopoulos 45fc0e0951 [explorer]
- Use the shell default auto-arrangement positioning. Aloow using custom positioning when configured. This fixes the positioning of icons of the desktop to look like windows

svn path=/trunk/; revision=51330
2011-04-13 18:25:58 +00:00
Rafal Harabien b69fae78db [GDI32]
* DPtoLP/LPtoDP functions should return TRUE even if they get 0 or less points or if pointer to points is invalid. See gdi32:DPtoLP apitest.
* Fixes 24 gdi32:DPtoLP apitests.

svn path=/trunk/; revision=51328
2011-04-13 08:14:37 +00:00
Michael Martin 35e6c5fe82 [USB\USBEHCI]
- Implement ExecuteTransfer to replace SubmitTransfer.
- Start implentation for BulkTransfers and needed DMA. This needs much more work to be done correctly. We will get to it.
- Implement URB_FUNCTION_CLASS_INTERFACE.
- Add comments.
Change 3 of 3.

svn path=/trunk/; revision=51327
2011-04-13 04:48:50 +00:00
Michael Martin fe97558adf [USB\USBEHCI]
- For common buffer memory, only allocate one page and allocate more as needed. This implementation will most likely be replaced with janderwalds.
- Use a safecount while attempting to stop and start the controller, so that an error can be displayed vice doing endless loop for controllers that are misbehaving.
- Reorganize a few structuers and remove members of structures that are not used.
- Add comments for some of the DirectCall Interface Functions.
Change 2 of 3.

svn path=/trunk/; revision=51326
2011-04-13 04:43:25 +00:00
Michael Martin b6256418e9 [USB\USBEHCI]
- Fix linking of QueueHeads. Implement LinkQueueHeadToCompletedList and CleanupAsyncList. These functions are used to software link the completed queueheads to a completed list. Only after the driver handshakes with the controller can this memory be freed.
Fix a few incorrect values for QueueHead.
- EhciDefferedRoutine: Implement handling of completed QueueHeads by removing them from the AnsycList and setting any errors for failure.
- Reserved a QueueHead that will always be in the AsyncList Address Register. By setting it as the Head of Reclamation the controller can know when it has reached the end of the QueueHead list.
- Remove all code from FdoDispatchInternalDeviceControl. This should never be called by upper level drivers.
Change 1 of 3.

svn path=/trunk/; revision=51325
2011-04-13 04:33:14 +00:00
Giannis Adamopoulos 9c9874002e [shell32]
- Properly arrange icons in explorer shell view window. This also fixes navigating in files with keyboard arrows

svn path=/trunk/; revision=51323
2011-04-12 20:59:50 +00:00
Rafal Harabien e58c66359a [SHELL32]
* Return 1 in WM_ERASEBKGND when desktop is painted
* Fix background for desktop icons and their labels
* Moreover fixes explorer_new background

svn path=/trunk/; revision=51322
2011-04-12 18:45:06 +00:00
Rafal Harabien 7db2a95a80 [COMCTL32]
* Sync listview to Wine 1.3.17
* Set background and text color before calling DrawFocusRect. Those colors are used by monochrome brush during painting. Tested this function in Windows and our implementation is correct. Wine has DrawFocusRect not correctly implemented and that's why they don't see this bug. Should be sent to wine (tm).

svn path=/trunk/; revision=51321
2011-04-12 18:38:38 +00:00
Eric Kohl 0dda24faea [NPFS]
PATCH: Arty's fixes based on CMake branch testing. Just the NPFS code.
See issue #6103 for more details.

svn path=/trunk/; revision=51320
2011-04-11 17:52:06 +00:00
Aleksey Bragin 0669ecfaf3 [RAPPS]
- Swedish translation by Jan Blomqvist-Kinander.

svn path=/trunk/; revision=51319
2011-04-11 17:36:44 +00:00
Aleksey Bragin bdf1dd8864 [WIN32CSR]
- Swedish translation by Jan Blomqvist-Kinander.

svn path=/trunk/; revision=51318
2011-04-11 17:03:20 +00:00
Gabriel Ilardi 7281838670 [SNDVOL32]
Italian and Spanish translation updates.

svn path=/trunk/; revision=51317
2011-04-11 12:26:16 +00:00
Gabriel Ilardi e52e2fbef6 [WIN32CSR]
Italian translation of command prompt's window title

svn path=/trunk/; revision=51316
2011-04-11 10:56:45 +00:00
James Tabor e059680fea [Win32k]
- PATCH: Arty's fixes based on CMake branch testing. Just the timer code. See bug 6103.

svn path=/trunk/; revision=51315
2011-04-11 03:24:14 +00:00
Rafal Harabien 52ce60c8d8 [ADVAPI32]
* Copy RegQueryValueExA from Wine. Fixes 24 winetests fails which appeared after r51222. They are caused by calling RegQueryValueExA with buffer size set to large value. Old implementation was allocating new buffer with specified size (it was failing) and using unicode function. New implementation use given buffer size only when coping data.
See issue #6105 for more details.

svn path=/trunk/; revision=51314
2011-04-10 21:24:49 +00:00
Eric Kohl 9f1ea5942e [NETAPI32]
NetUserModalsGet failed if the domain SID returned by LsaQueryInformationPolicy was NULL. Handle the NULL SID case correctly.
See issue #6102 for more details.

svn path=/trunk/; revision=51313
2011-04-10 15:42:55 +00:00
Olaf Siejka dcd0dff4cc Fix build. The translation patch was outdated.
svn path=/trunk/; revision=51311
2011-04-10 14:55:11 +00:00
Matthias Kupfer 70bef06a00 Radek Liska <radekliska AT gmail DOT com>
- Czech translations for sndrec32 and sndvol32.
- See issue #6098 for details.

svn path=/trunk/; revision=51310
2011-04-10 13:19:01 +00:00
Johannes Anderwald d896f82fa7 [SHELL32]
- Fix control style of property dialogs
- Patch Edijs Kolesnikovics, terminedijs@yahoo.com, irc:Edijus

svn path=/trunk/; revision=51309
2011-04-10 10:44:05 +00:00
Olaf Siejka efe9675fbd [WIN32CSR]
Polish translation of Command prompt window title

svn path=/trunk/; revision=51308
2011-04-10 08:49:31 +00:00
Amine Khaldi 588882aa00 [DOSKEY/SNDREC32]
- Activate polish translations. Patch by Adam Stachowicz.

svn path=/trunk/; revision=51307
2011-04-09 21:02:25 +00:00
James Tabor e5989efb7f - Fix build
svn path=/trunk/; revision=51306
2011-04-09 20:41:04 +00:00
James Tabor 86153cc8a8 [Win32k]
- Revert parts of 51283, thanks to Giannis for setting me straight on SetCursorPos and without breaking setting the Track window for TrackMouseEvent. Pass the new SetCursorPos, and wine test_TrackMouseEvent and input test_mouse_ll_hook tests.

svn path=/trunk/; revision=51305
2011-04-09 20:32:52 +00:00
Johannes Anderwald e6b7c8a1e1 [EXPLORER_NEW]
- Use ReactOS registry key for ReactOS features
- Patch by Edijus Kolesnikovičs, terminedijs@yahoo.com

svn path=/trunk/; revision=51300
2011-04-09 16:34:15 +00:00
Johannes Anderwald 057f632693 [SNDVOL32]
- Remove 'E'

svn path=/trunk/; revision=51298
2011-04-09 15:28:46 +00:00
Daniel Reimer bec28e056e Partial revert, as explained on ML. Sry...
svn path=/trunk/; revision=51297
2011-04-09 15:21:22 +00:00
Daniel Reimer dc37bd8b99 - Sync all resource files with the English one.
- Translate the new Dialog in the German one.
- Normally we use BEGIN and END, no {}
- DIALOG -> DIALOGEX

svn path=/trunk/; revision=51296
2011-04-09 14:46:37 +00:00
Giannis Adamopoulos 893a0bfccb [win32k]
- Rewrite GetKeyState based on wine. Now it's results are based on whether or nor the message queue has processed a keyboard message and not the actual state of the keyboard.c
- TODO: ensure it works corectly and use this implementation in most other places in win32k when we need to check the state of a key. To ensure nothing breaks, this change affects only GetKeyState

svn path=/trunk/; revision=51295
2011-04-09 12:44:45 +00:00
Kamil Hornicek 4041e16e6f Updated Czech translations for ping, charmap, reactos, usetup, console, desk and shell32 by Radek Liska (radekliska at gmail dot com) with some subtle modifications by me.
See issue #6067 for more details.

svn path=/trunk/; revision=51294
2011-04-09 12:18:34 +00:00
Matthias Kupfer f02f58236a Command Prompt with translated window title
- German translation added
- other languages need to be translated (.rc files prepared)

svn path=/trunk/; revision=51293
2011-04-09 12:01:36 +00:00
Johannes Anderwald 39dac2cce0 [SNDVOL32]
- Fix more subtle bugs:
- Check with long line name if the current connection is activated when adding lines to dialog or when adding lines to the preferences dialog
- Use the temporary preferences context when writing the line settings
- Don't destroy the mixer when the preferences dialog is closed. the new mixer will be used for the application when the preferences are changed
- Pass the current selected line to the preferences dialog





svn path=/trunk/; revision=51292
2011-04-09 10:36:25 +00:00
Michael Martin 6301753d1d [Win32k]
- Only call hooks and check if Win32Thread is in cleanup if the windows procedure is being called.
- Set DispatchingListEntry.Flink to NULL. The real fix for bug 5580. This bug may be the cause of other crashes experienced by users just before loading desktop. Found by rafalh.

svn path=/trunk/; revision=51291
2011-04-09 07:19:31 +00:00
James Tabor f78f9456fb [Win32k]
- Added more missed mouse injection flag and extra data being passed in and from set cursor position. Wine mouse low level hook msg tests now see it and check the validity of the hook message.

svn path=/trunk/; revision=51290
2011-04-09 07:08:17 +00:00
Sylvain Petreolle 02a6a17e28 [SNDVOL32]
Redraw window with correct size.
Window height was growing after changing preferences.

svn path=/trunk/; revision=51289
2011-04-08 23:18:20 +00:00
Sylvain Petreolle 6d9847ecb3 [SNDVOL32]
Update french translation.

svn path=/trunk/; revision=51288
2011-04-08 22:40:12 +00:00
Johannes Anderwald 3fe212aea3 [SNDVOL32]
- Fix mute switch control style

svn path=/trunk/; revision=51287
2011-04-08 22:17:18 +00:00
Johannes Anderwald a54b06c8cd [SNDVOL32]
- Always write line states configuration values in one step
- Fixes the problem when old line state settings were not present
- Advantage is that it is faster and sndvol32 now works in ReactOS

svn path=/trunk/; revision=51286
2011-04-08 22:04:41 +00:00
Olaf Siejka fcdea4c19d [DOSKEY]
- Polish translation by Adam "Saibman" Stachowicz

[SNDREC32]
- Polish translation by Adam "Saibman" Stachowicz

[SNDVOL32]
- Polish translation update by me

[TRANSLATION]
- Polish translation fixes (spelling, typos, grammar) and updates on multiple modules by Adam "Saibman" Stachowicz, few small corrections by me.

See issue #6087 for more details.

svn path=/trunk/; revision=51285
2011-04-08 21:57:32 +00:00
Johannes Anderwald d234fd5fc8 [SNDVOL32]
- Add english resources for sndvol32
- Enjoy ;)

svn path=/trunk/; revision=51284
2011-04-08 21:09:07 +00:00
James Tabor 5399e1d53e [User32|Win32k]
- Fix TrackMouseEvent! Keyboard and Mouse pass all the right flags. Update to accelerator code. Fixed recursion in global hooks. Hack-implement GetMouseMovePointsEx due to slack time and boredom, it passes the input tests but does nothing. Pass all the test_TrackMouseEvent!!! test_accelerators and test_menu_messages work too, so far no hangs.


svn path=/trunk/; revision=51283
2011-04-08 19:29:15 +00:00
James Tabor efe3b7a684 [Win32k]
- Fix crash in msg test_interthread_message test. Noticed it once and not sure how to track it.

svn path=/trunk/; revision=51282
2011-04-08 18:48:28 +00:00
Aleksey Bragin a6586c33b1 [NTDLL]
- Fix incorrect prototypes and partially implement fast unsafe versions of activation context activation/deactivation, however disable them for now, until the new loader is in place.
- Fix their usage in the new loader code, which by mistake (which got copypasted into three other places) was passing a totally empty activation context to the activate function.

svn path=/trunk/; revision=51281
2011-04-08 17:49:49 +00:00
Timo Kreuzer b63bf768a6 [NTOSKRNL]
ExInitializePushLock takes a PEX_PUSH_LOCK as parameter, do it the same in the inline version instead of casting to PULONG_PTR everywhere

svn path=/trunk/; revision=51278
2011-04-08 12:30:33 +00:00
Aleksey Bragin a3690ead55 [KERNEL32]
- Zero-initialize base address in BasepLoadLibraryAsDatafile. Should fix 2nd stage problems.
- Add a trace debugprint, silented by default.
See issue #6092 for more details.

svn path=/trunk/; revision=51277
2011-04-08 09:21:41 +00:00
Michael Martin 0a6bb0f70d [Win32k]
- co_IntSendMessageWithCallBack: Insert the message into the messagequeue before attempting to wake the queue. Probably fixes bug 5580.
- Remove the use of MSQ_SENTNOWAIT that was used to determine if messagequeues needed dereferencing. Instead use the SenderQueue member of the message.
- Do not close the NewMessagesHandle member of the messagequeue in IntDereferenceMessageQueue. 
The last reference on a messagequeue could be released by a thread belonging to a process other than the on that created the handle.
Also the creating process could already be long gone. Instead close this handle in MsqDestroyMessageQueue which is in the thread/process that created the handle. Problem noticed by smiley.
- Revert change done in 51254. James you are indeed correct. 
Testing shows that the WM_PARENTNOTIFY message is not sent when the program is exiting.

svn path=/trunk/; revision=51275
2011-04-07 23:57:00 +00:00
Johannes Anderwald 07de2df4a2 [SNDVOL32]
- Implement retrieving current volume level and mute state and set the dialog controls on startup
- Remove last line separator from GUI
- Implement updating slider / switch control when another application modifies volume settings
- Implement writing current selected lines settings into registry when the preference dialog is closed
- Implement helper functions which receive / set volume level
- Sndvol32 is now fully functional and has been tested in Windows XP SP3
- TODO: implement support for setting volume balance (left - right slider)
- TODO: Resources have not yet been commited

svn path=/trunk/; revision=51274
2011-04-07 21:31:21 +00:00
Aleksey Bragin 3983f64027 [KERNEL32]
- Finish the ldr.c rewrite. Properly implement LoadLibraryExW (which contained some good code pieces added by Alex). Implement BasepLoadLibraryAsDatafile, however it doesn't support redirection yet and a call to load alternate resource module is commented out (it's totally absent in the existing ntdll/ldr API now).
- Mark GetDllLoadPath as deprecated, should be removed when SearchPathW is rewritten (or at least, reviewed). The new function to use is BasepGetDllPath.

svn path=/trunk/; revision=51272
2011-04-06 21:49:04 +00:00
Johannes Anderwald 446f42d3af [SNDVOL32]
- Implement loading of resources and parsing the dialog template in memory
- Store the created windows in an array
- Implement destroying of controls when mixer is changed / line selection is altered
- Implement generating layout for each new line
- Implement setting line name
- Resources have not yet been commited
- Sndvol32 is not yet functional

svn path=/trunk/; revision=51271
2011-04-06 21:05:05 +00:00
Aleksey Bragin 672303db6b [KERNEL32]
- Rewrite most of kernel32 module loading APIs (except for LoadLibraryExW, for testing purposes it's gonna be committed in a separate commit). Rewritten parts include:
* Better definition of LOADPARMS32 structure for LoadModule, and rewritten LoadModule which is now a well structured function with proper parameters validation, proper work algorithm and setting proper last error values in failure cases. Optimization of allocating MAX_PATH buffer on stack instead of in the heap is saved from the old version of the function.
* LoadLibraryA, added a path-hack (present at least up to Windows 2003) for twain_32.dll loading (not that important, but still a compatibility issue).
* Make GetProcAddress() use BasepMapModuleHandle for mapping the passed-in handle (including properly handling NULL module handle which was incorrectly handled by the old implementation), and check for a special failure case when LdrGetProcedureAddress returns pointer to the image base address.

svn path=/trunk/; revision=51270
2011-04-06 19:03:20 +00:00
Timo Kreuzer 0e072c5063 [RPCRT4]
Fix return type of *ClientCall functions.
Merged from cmake branch

svn path=/trunk/; revision=51269
2011-04-06 18:49:16 +00:00
James Tabor 3890323807 [User32|Win32k]
- Pass all the wine test_capture_1/2/3/4.
- Fix the menu tracking pop up hang issue by looking for deceased windows that pass on while in the start of tracking. This could be a fix for other wine tests.
- ReactOS is not Linux and wine is not enough!

svn path=/trunk/; revision=51265
2011-04-06 12:53:52 +00:00
James Tabor 374e21b4e0 [Win32k]
- The Reak fix to unfocused explorer minimize hang, spotted by R3dDr4g0n <vins8920@hotmail.com>.

svn path=/trunk/; revision=51264
2011-04-06 12:23:54 +00:00
James Tabor f43d2fe8ca [Win32k]
- Fix to unfocused explorer minimize hang, spotted by R3dDr4g0n <vins8920@hotmail.com>.

svn path=/trunk/; revision=51263
2011-04-06 01:31:50 +00:00
Eric Kohl ddb4a8780d [WIDL]
Reapply the switchtype patch.

svn path=/trunk/; revision=51262
2011-04-05 21:37:54 +00:00
Rafal Harabien 26504807cd [USRMGR]
Free buffer instead of freeing pointer to buffer

svn path=/trunk/; revision=51261
2011-04-05 21:24:25 +00:00
Rafal Harabien be54395eb8 [PSDK]
Add GetAdaptersAddresses declaration
Add forgotten GetComputerNameEx macro

svn path=/trunk/; revision=51259
2011-04-05 21:14:18 +00:00
Michael Martin 6ecaf80fcf [NTOS/MM]
- Update PoolTag used with ExFreePooWithTag to match changes made in 46987 by richard.

svn path=/trunk/; revision=51258
2011-04-05 11:42:38 +00:00
Eric Kohl 35a75304b7 [ADVAPI32/LSASRV]
- Implement LsaLookupNames2 in advapi32.dll.
- Implement LsarLookupNames3 in lsasrv.dll as a mock-up which returns a hard-coded user account (Administrator).

This fixes several wine tests.

svn path=/trunk/; revision=51257
2011-04-04 22:08:45 +00:00
Michael Martin 862d46f96e - Revert 51255 that was committed on accident. The patch is not ready yet.
svn path=/trunk/; revision=51256
2011-04-04 22:08:39 +00:00
Michael Martin 771f834c43 [Win32k]
- co_MsqDispatchOneSentMessage: After calling the windows procedure check if the message was a callback. If so place the message into the calling MessageQueue.  Also check if the current MessageQueue is the calling MessageQueue in which case dont call the Windows procedure but call the callback routine. SendMessageCallback is now properly implemented.
- Remove the use of MSQ_SENTNOWAIT and instead use the SenderQueue and CallBackSenderQueue members to determine if the MessageQueues need to be dereferenced.
- Modify co_MsqSendMessage to accept more parameters so that it can handle Notification, Callback and Internal messages. These changes make this function more complex but removes duplicate code in messages.c and move the handling for all queued messages in one location.
- co_IntSendMessageWithCallBack: If the callback is for the same Message Queue, call it vice queuing it.
Insert the message into the MessageQueue before waking the thread to handle the message. Should fix bug 5580.

svn path=/trunk/; revision=51255
2011-04-04 21:50:24 +00:00
Michael Martin 9990b69447 [Win32k]
- Do not block calling thread when sending WM_PARENTNOTIFY messages. Fixes hang at end of user32 winetest for msg.

svn path=/trunk/; revision=51254
2011-04-04 21:15:07 +00:00
Aleksey Bragin 7fcd953546 [KERNEL32]
- Minor cleanup, better flag names (thanks to ProcessHacker team for the good names and values).
- Return error in failure path of BasepGetModuleHandleExW.
- Optimize GetModuleHandleExA so that it calls the internal routine directly, without going through GetModuleHandleExW first and thus validating parameters second time.

svn path=/trunk/; revision=51253
2011-04-04 19:35:24 +00:00
Johannes Anderwald 15474a66e9 [SNDVOL32]
- Set Control variable to null, which prevents that mixer controls being assigned to another line when the current line does not have any controls. Bug was highlighted when opening the property window. In that case sndvol32 frees the previous setting, so all mixer lines are also getting freed including their controls, which caused a double free in the case the line did not have any controls assigned.

svn path=/trunk/; revision=51252
2011-04-04 14:27:29 +00:00
James Tabor 94b1cd39cd - Fix build.
svn path=/trunk/; revision=51249
2011-04-04 07:22:41 +00:00
James Tabor 7a18540a92 [User32|Win32k]
- Working on wine win test_capture_4, pass all the tests in test_capture_4_proc but still waiting forever in MenuTrackMenu:WaitMessage!

svn path=/trunk/; revision=51248
2011-04-04 07:18:54 +00:00
Sylvain Petreolle 594dd8de49 [RBUILD]
Use msvcrt as default crt for DLLs/OCX modules.

svn path=/trunk/; revision=51247
2011-04-03 22:09:07 +00:00
Aleksey Bragin 53af1b545e [KERNEL32]
- Implement BasepMapModuleHandle and use it in GetModuleFileNameW. Later, it'll be used by other module and loader related functions in kernel32.
- Wrap a call to RtlImageNtHeader into SEH, because winetest and for some reason FF installer call it with incorrect handle and expect it to not crash (Windows also has SEH, but inside RtlImageNtHeader).
- Fix null-termination problems in GetModuleFileNameA, and incorrect calculation of characters returned in GetModuleFileNameW.
- Various smaller improvements to the rewritten code (missing parenthesis, better variable names, use pretty LDR_ macros from http://msdn.microsoft.com/en-us/library/ms684179(v=vs.85).aspx ).
- Thanks for your feedback!
See issue #6079 for more details.

svn path=/trunk/; revision=51246
2011-04-03 21:46:42 +00:00
James Tabor 526f2d84e4 [Win32k]
- Fix GetPeekMessage apitest that was broken when fixing the last two post quite message test.

svn path=/trunk/; revision=51245
2011-04-03 21:12:40 +00:00
Sylvain Petreolle 9d955773ac [CONSOLE]
Fix french resource file name.
Dedicated to HeisSpiter & JanusMagnus.


svn path=/trunk/; revision=51243
2011-04-03 20:26:57 +00:00
Ged Murphy 4c2b7d67a1 [FULLFAT]
- Add the kernel APIs required by the library

svn path=/trunk/; revision=51241
2011-04-03 16:22:15 +00:00
Eric Kohl 8907f384eb [LSASRV]
Fix typos in lsa.idl (LsarLookupNames2, LsarLookupNames3 and LsarLookupNames4) and fix resulting errors in lsasrv.dll.

svn path=/trunk/; revision=51240
2011-04-03 14:51:18 +00:00
James Tabor f66194544b [Win32k]
- Fix DDE test crash. it's a band-aide.
- Fix the last two post quite message test, all pass now.

svn path=/trunk/; revision=51239
2011-04-03 12:22:00 +00:00
Aleksey Bragin 629be1865d [KERNEL32]
- Rewrite large part of ldr.c code, including FreeLibrary, FreeLibraryAndExitThread, GetModuleFileNameA/W, GetModuleHandleA/W, ExA/W. Now they properly validate parameters, common code for getting module handles is factored into a standalone function which is reused for all 4 APIs instead of duplicating almost the same code four times. GetModuleFileNameA became a typical A->W wrapper around GetModuleFileNameW so duplication is also removed there.
- Getting module handle also became a correct implementation because now it takes process's dll path into account instead of always assuming a "default" one (which is incompatible with a new ntdll loader).
- Fixed a typo in BasepGetProcessPath which led to incorrect value being returned. Downgrade two debugprints.

svn path=/trunk/; revision=51238
2011-04-03 09:42:08 +00:00
James Tabor 6f4a96d594 [Win32k]
- Fix the return checks for  co_MsqWaitForNewMessages, now the wait_idle test no longer randomly crash, also tested the testkbd check from bug 3212. Setup co_MsqWaitForNewMessages to act like get message, checking QS bits and dispatching send messages if queued.
- Added desktop hit test data point, now the new track mouse timer code works. Not yet committed.

svn path=/trunk/; revision=51237
2011-04-03 02:14:14 +00:00
Ged Murphy f6c92d8d84 [FULLFAT]
- Map the memory functions onto kernel APIs

svn path=/trunk/; revision=51236
2011-04-02 18:51:41 +00:00
Aleksey Bragin 901b5f0d91 [NDK]
- Add RTL_PERTHREAD_CURDIR structure definition.
- Fix RTL_DRIVE_LETTER_CURDIR type vs. structure definition typo (adding more underscores is a truly universal fix!).

svn path=/trunk/; revision=51235
2011-04-02 18:32:04 +00:00
Ged Murphy d7899fc474 [FULLFAT]
- Fix warnings for both msc and rbuild
- These fixes will be applied to the FullFat source too, so I've not bothered with a local ros.diff

svn path=/trunk/; revision=51234
2011-04-02 18:12:31 +00:00
Ged Murphy 50fd13ae9c [FULLFAT]
- Switch UTF-16 support on throughout the library.

svn path=/trunk/; revision=51230
2011-04-02 16:37:25 +00:00
Ged Murphy 271454653d [FULLFAT]
- Update FullFat to the latest SVN code on James' recommendation.
- This release has many advantages over the previous, including full UTF-8 and UTF-16 support and the ability to modify attributes and timestamps. All of which are important for ros.
- It currently has a few warnings (in both gcc and msc), so I've had to turn allow warnings on.

svn path=/trunk/; revision=51229
2011-04-02 16:31:43 +00:00
Ged Murphy 91e657f782 {FULLFAT]
- Update FullFat to the latest stable release (1.0.5)
- I'm awaiting a reply from James as to when 1.1.0 will be released as it have some nice improvements.

svn path=/trunk/; revision=51227
2011-04-02 15:22:48 +00:00
Giannis Adamopoulos 0857319218 [win32k]
- Simplify co_IntWaitMessage
- In co_IntGetPeekMessage, call co_MsqWaitForNewMessages instead of co_IntWaitMessage when we  need to wait for a new message. co_IntWaitMessage calls co_IntPeekMessage again without removing messages. The problem is that processing some messages produce other messages or hooks even though the message must not be removed. As a result some messages like WM_NCHITTEST were received twice by the application
- Should fix bug 3232

svn path=/trunk/; revision=51224
2011-04-02 10:12:44 +00:00
Aleksey Bragin 1d045ebeb3 [NTDLL]
- Fix a typo which led to incorrect logic of TLS allocation. This repairs those installers broken by r51051.
See issue #6009 for more details.

svn path=/trunk/; revision=51223
2011-04-02 09:20:16 +00:00
Rafal Harabien f4f2b68256 [ADVAPI32]
* Fix bug in RegQueryValueExA, which causes buffer overflow
* Fixes systeminfo in ReactOS
See issue #6050 for more details.

svn path=/trunk/; revision=51222
2011-04-01 22:10:52 +00:00
Aleksey Bragin 472df5e17a - Fix build. Happens.
svn path=/trunk/; revision=51218
2011-04-01 12:18:54 +00:00
Aleksey Bragin 0ca9a93ca6 [KERNEL32]
- Implement a simple version of BasepGetDllPath()/BasepGetProcessPath().

svn path=/trunk/; revision=51217
2011-04-01 10:06:03 +00:00
James Tabor 951d604b0c [Win32k]
- Fix wine post message test, corrected the peek message window selection.
- Add a check for dead windows and new message queue flags. 
- Other miscellaneous fix ups.

svn path=/trunk/; revision=51216
2011-03-31 21:20:06 +00:00
Johannes Anderwald 0a3b87a1ef - Fix build attempt #1
svn path=/trunk/; revision=51214
2011-03-31 16:21:38 +00:00
Johannes Anderwald 62d4baba03 [PSDK]
- More header updates

svn path=/trunk/; revision=51213
2011-03-31 16:16:10 +00:00
Aleksey Bragin 73b6d5b3d6 [NTDLL]
- Change Context/Parameter in LdrEnumerateLoadedModules() to PVOID (previous ULONG type was a typo).

svn path=/trunk/; revision=51210
2011-03-31 11:32:57 +00:00
Aleksey Bragin c7b59706ce - Fix build.
svn path=/trunk/; revision=51209
2011-03-30 21:33:57 +00:00
Aleksey Bragin b98f8ccd88 [NTDLL]
- Implement LdrEnumerateLoadedModules().

svn path=/trunk/; revision=51208
2011-03-30 21:21:42 +00:00
Aleksey Bragin b94139f67f [NTDLL]
- Add RtlDosApplyFileIsolationRedirection_Ustr() stub.

svn path=/trunk/; revision=51207
2011-03-30 20:56:05 +00:00
Olaf Siejka 5882dc9038 [DESK]
- Translation patch by Adam "Saibamen" Stachowicz. See issue #6057 for more details.

[EXPLORER]
- Translation patch by Adam "Saibamen" Stachowicz.

[SERVMAN]
- Translation patch by Adam "Saibamen" Stachowicz. 

[SHELL32]
- Translation patch by Adam "Saibamen" Stachowicz. See issue #6060 for more details.

svn path=/trunk/; revision=51206
2011-03-30 18:49:01 +00:00
Gabriel Ilardi e37934bec0 [CMD] Fix a typo in dir that led to omitting the last character in the AM/PM time format.
See issue #6061 for more details.

svn path=/trunk/; revision=51205
2011-03-30 13:02:57 +00:00
Aleksey Bragin 550e976e24 [NTOS/KE]
- Clear KernelApcPending flag every time the Kernel APCs queue is not empty.

svn path=/trunk/; revision=51204
2011-03-30 11:05:40 +00:00
James Tabor 88339aa831 [User32|Win32k]
- Move EnableWindow to Win32k.
- Fix sign in class function.

svn path=/trunk/; revision=51203
2011-03-30 08:19:52 +00:00
James Tabor 815eb466ba [User32]
- Connect the rest of the pump hooks and start tracking from application testing.

svn path=/trunk/; revision=51202
2011-03-30 01:26:54 +00:00
James Tabor 0d6b3c7ebd [User32|Win32k]
- Update NtUser pump functions, based on known values. Move one more function to the right place.

svn path=/trunk/; revision=51201
2011-03-30 01:00:28 +00:00
James Tabor f42a29cf5c [Win32k]
- Move IntGdiSetBrushOwner and IntGdiSetRegionOwner out of the export section.

svn path=/trunk/; revision=51200
2011-03-29 23:44:22 +00:00
Olaf Siejka c07f34ceee [SHELL32]
- Fix a bug, by Johannes Anderwald

svn path=/trunk/; revision=51199
2011-03-29 21:59:57 +00:00
Olaf Siejka 615f45bf9a [SHELL32]
- Fix build, borked by copypasta

svn path=/trunk/; revision=51198
2011-03-29 21:48:30 +00:00
Aleksey Bragin a77d09adf9 [KERNEL32]
- Rename global vars to some better names (some of the names seen in Windows 2003 asserts and text messages).
- Add BaseDefaultPath initialization, which will be needed but the new kernel32/ldr code, which is in turn required by the new ntdll/ldr code.
- Add some beginnings of BasepGetDllPath(), but it returns NULL anyway now so no change in execution.

svn path=/trunk/; revision=51197
2011-03-29 21:48:13 +00:00
Olaf Siejka ed27eba843 [SHELL32]
- Fix compile warning (uninitialized use). Based on patch by Edijs Kolesnikovics <terminedijs at yahoo dot com> slightly modified by Aleksiej
See issue #6058 for more details.

svn path=/trunk/; revision=51196
2011-03-29 21:41:14 +00:00
Olaf Siejka c98d64bacb [SYSSETUP]
- Fix compilation warning. Patch by Edijs Kolesnikovics <terminedijs at yahoo dot com>
See issue #6059 for more details.

svn path=/trunk/; revision=51195
2011-03-29 21:21:18 +00:00
Timo Kreuzer 2127ff030c [WIN32K]
Addendum to r51188: set last error, when overflow check fails.
Fixes test regression.

svn path=/trunk/; revision=51194
2011-03-29 15:35:10 +00:00
Aleksey Bragin 6771858659 [RTL]
- Turn off LdrVerifyMappedImageMatchesChecksum() verification for now. (should have been part of r51192).

svn path=/trunk/; revision=51193
2011-03-29 11:00:34 +00:00
Aleksey Bragin fb0b4f31c4 [NTOS/MM]
- Remove IMG_SCN_TYPE_NOLOAD support which was firstly removed by Alex, then reenabled by Herve. Hopefully it works this time.
- Return proper image size after successfully mapping an image section (previously, 0 was always returned). The change above is necessary for returning correct size.

svn path=/trunk/; revision=51192
2011-03-29 10:56:28 +00:00
Timo Kreuzer d7e597d60e [WIN32K]
- Move IntGdiSetBrushOwner to brush.c
- Move IntGdiSetDCOwnerEx to dclife.c
- Move IntGdiSetRegionOwner to region.c

svn path=/trunk/; revision=51191
2011-03-29 10:25:10 +00:00
Timo Kreuzer e78589d99a [WIN32K]
Disable system service hooks, that got accidentally enabled.


svn path=/trunk/; revision=51190
2011-03-29 10:07:11 +00:00
Timo Kreuzer 854e23cc3e [WIN32K]
Make GdiTableSection a static variable and use it only from gdiobj.c

svn path=/trunk/; revision=51189
2011-03-29 10:02:38 +00:00
Timo Kreuzer 216026918d [WIN32K]
Fix parameter check and buffer probing in NtUserSetSysColors

svn path=/trunk/; revision=51188
2011-03-29 09:52:39 +00:00
James Tabor 0bf0c70444 [User32|Win32k]
- Properly implement RealGetWindowClass, fixes the ApiTest. Keeping the Ansi support for now, will use it as a reference.

svn path=/trunk/; revision=51187
2011-03-29 05:53:34 +00:00
James Tabor 827e75cb89 [User32]
- Fix select old brush in FillRect.

svn path=/trunk/; revision=51186
2011-03-29 05:11:02 +00:00
James Tabor 9e22fe5962 [Win32k]
- Finish object attribute support part 2.
- Removed DC from the list, ReactOS handles this in a different way. Comment out Brush and Pen switches until proper handling is implemented.

svn path=/trunk/; revision=51185
2011-03-29 02:57:48 +00:00
Rafal Harabien c5dad4998c [USER32]
Fix a bug causing "Attempted to lock object, wrong reuse counter" messages when CMD was started in LiveCD. Once got desktop HDC was used in different threads. When thread, which created handle terminated, DC handle was removed and next calls to CreateIcon* API was using invalid hDC.

svn path=/trunk/; revision=51184
2011-03-28 20:52:27 +00:00
James Tabor 4ef3dbc225 [GDI32|User32|Win32k]
- Fix ScrollDC ApiTest.

svn path=/trunk/; revision=51179
2011-03-28 00:17:21 +00:00
Rafal Harabien f21acd6f09 [USER32]
Don't fail if FillRect is called without brush. Fixes user32:uitools winetest

svn path=/trunk/; revision=51178
2011-03-27 23:19:56 +00:00
Rafal Harabien 54cac2ef9e [PING]
Fix crash if option, which needs number is on the end of command line
Get rid of GetULONG and GetULONG2 functions. MS doesn't check input so precisely
Command line options can be preceded by "/"

See issue #6047 for more details.

svn path=/trunk/; revision=51177
2011-03-27 22:47:59 +00:00
Rafal Harabien 8174c5cfde [SYSSETUP]
Set HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\InstallDate to install date.
Patch by Edijs Kolesnikovics <terminedijs at yahoo dot com> slightly modified by me
See issue #6044 for more details.

svn path=/trunk/; revision=51176
2011-03-27 21:51:41 +00:00
Daniel Reimer 91eff339fd Update the Applications to the recent Versions.
Add the dlls the C,VB etc Runtime Packs will install into the description.
Remove goOO from rapps.

svn path=/trunk/; revision=51175
2011-03-27 18:34:22 +00:00
Aleksey Bragin 29b96f834c - Lay out critical system DLLs so that they don't overlap when loaded properly.
svn path=/trunk/; revision=51173
2011-03-27 16:37:26 +00:00
Eric Kohl 4288ba6306 [SERVICES]
ScmWriteDependencies:
- Fixed an off-by-one bug. This bug caused a wrong calculation of the 'DependOnGroup' value data length. Group dependencies were not written properly to the registry.

- Write 'DependOnService' and 'DependOnService' values to the registry only if the dependency strings are not empty. Delete a value if the corresponding dependency string is empty.

This fixes another winetest.

svn path=/trunk/; revision=51172
2011-03-27 13:12:12 +00:00
Aleksey Bragin 828d04705a [NTOS/MM]
- Return STATUS_IMAGE_NOT_AT_BASE when mapping an image section to a different base address. New ntdll loader depends on this and fails to relocate the image if this status is not returned.

svn path=/trunk/; revision=51171
2011-03-27 11:32:55 +00:00
James Tabor 34bb476056 [GDI32]
- Finish object attribute support.

svn path=/trunk/; revision=51170
2011-03-27 05:40:30 +00:00
Rafal Harabien 8900f7d5d4 [WIN32K]
Rename IntResetMonitorSize to IntUpdateMonitorSize
Use IntUpdateMonitorSize instead of setting monitor size manually when attaching monitor
Change display device name from VIDEOx to DISPLAYx as it is in Windows (fixes user32:monitor winetest)

[USER32]
Return FALSE in EnumDisplayMonitors if EnumProc returned FALSE (fixes user32:monitor winetest)

svn path=/trunk/; revision=51169
2011-03-27 01:12:25 +00:00
Olaf Siejka 47d38c2989 [RAPPS]
- Add DoubleCommander to app list. Russian and Ukrainian translation by Igorko, Polish translation by me.

[CMD]
- Fix Russian translation of cmd. Patch by seven_ro. See bugreport no.#6043

svn path=/trunk/; revision=51168
2011-03-26 23:53:49 +00:00
Olaf Siejka 7dfe6edff5 [NTDLL]
- Fix "entry point not found" harderror parameters. Patch by Thomas Faber
See issue #5983 for more details.

svn path=/trunk/; revision=51167
2011-03-26 23:36:56 +00:00
Rafal Harabien 164140d904 Fix duplicated startup version string
Patch by Thomas Faber <thfabba at gmx dot de>
See issue #6015 for more details.

svn path=/trunk/; revision=51165
2011-03-26 21:41:49 +00:00
Rafal Harabien 299f6a7826 [VIDEOPRT]
Add missing check
Don't assume UNICODE_STRING is NULL-terminated

svn path=/trunk/; revision=51163
2011-03-26 17:49:55 +00:00
Rafal Harabien 291012914d [GDI32]
Fix gdi32:CreatePen apitest

svn path=/trunk/; revision=51161
2011-03-26 15:24:05 +00:00
Rafal Harabien 7e914b6e08 [NDIS]
Correct Length value in case string is truncated

svn path=/trunk/; revision=51159
2011-03-26 15:12:23 +00:00
James Tabor 00a64f39cb [User32]
- Cleanup edit and add back missing break in combo.

svn path=/trunk/; revision=51148
2011-03-26 05:31:59 +00:00
James Tabor b294b7d774 [GDI32]
- Patch by Thomas Faber: GetTextExtentPoint32 must not assume null termination of lpString.

svn path=/trunk/; revision=51147
2011-03-26 02:10:04 +00:00
Timo Kreuzer 6af9026458 [USER32]
Improve formatting

svn path=/trunk/; revision=51146
2011-03-26 01:20:11 +00:00
James Tabor 6e23217097 [Csrss|Win32k]
- Enable the desktop class and set the ReactOS variant of csrss back to local desktop class. Now all class tests pass, see bug 4778.

svn path=/trunk/; revision=51145
2011-03-26 00:43:56 +00:00
Rafal Harabien 61b6e9119f [WIN32K]
wcsncpy -> RtlStringCbCopyW (part 4/x)
Avoid unneeded allocation

svn path=/trunk/; revision=51144
2011-03-25 23:09:06 +00:00
Rafal Harabien 03a8c91d75 [WIN32K]
wcsncpy -> safe api (part 3/x)

svn path=/trunk/; revision=51143
2011-03-25 22:57:46 +00:00
Rafal Harabien 00cfa29229 [WIN32K]
Fix GDITAG_LDE/TAG_LDE mess

svn path=/trunk/; revision=51142
2011-03-25 22:49:30 +00:00
Rafal Harabien eeaccfdfe1 [WIN32K]
Forgotten in r51139...

svn path=/trunk/; revision=51141
2011-03-25 22:45:59 +00:00
Rafal Harabien 04d67b9ebd [WIN32K]
Change wcsncpy to safe functions (part 2/x)

svn path=/trunk/; revision=51140
2011-03-25 22:36:37 +00:00
Rafal Harabien 0b986764d4 [WIN32K]
Make sure strings returned by internal function RegQueryValue are NULL terminated

svn path=/trunk/; revision=51139
2011-03-25 22:34:53 +00:00
Rafal Harabien 547a7d215f [NTOSKRNL]
Change strncpy calls to RtlStringSbCopyA (PART 1/x)
Fix bug in MmLoadSystemImage which caused FileName parameter to be freed

svn path=/trunk/; revision=51138
2011-03-25 22:28:15 +00:00
Rafal Harabien 54dc46543f [USER32]
Fix bug causing no NULL termination of strings after conversion in EnumDisplayDevicesA. Fixes one usr32:monitor winetest

svn path=/trunk/; revision=51137
2011-03-25 21:58:39 +00:00
Rafal Harabien c14b8afbdc Forgotten in r51135...
svn path=/trunk/; revision=51136
2011-03-25 21:49:03 +00:00
Rafal Harabien e0191e8920 [PSDK]
Import strsafe.h from mingw-w64. It's more complete compared to our headers

[DDK]
Import ntstrsafe.h from mingw-w64 (converted from strsafe.h). It's more complete compared to our headers

[NTOSKRNL]
Use sizeof instead of magic numbers

Let's use strsafe functions now instead of strncpy/wcsncpy, which doesn't always NULL terminate :)

svn path=/trunk/; revision=51135
2011-03-25 21:42:48 +00:00
Gabriel Ilardi 855227336f [SHELL32]
Italian & Spanish fixes + RunFileDlg translations

svn path=/trunk/; revision=51133
2011-03-24 08:34:49 +00:00
Amine Khaldi 70a12312e3 [BUILD]
- Remove redundant -fms-extensions as we set it globally already.

svn path=/trunk/; revision=51132
2011-03-23 23:17:45 +00:00
Rafal Harabien 58789369ad Revert previous commit
Sorry... I'll test first next time.

svn path=/trunk/; revision=51131
2011-03-23 20:48:20 +00:00
Rafal Harabien a3c683546c [DDK]
Add most of RtlString***W functions based on ANSI versions.

svn path=/trunk/; revision=51130
2011-03-23 20:36:25 +00:00
Rafal Harabien 4732a3af3d [WIN32K]
Remove a useless if in cliprgn.c
Patch by Thomas Faber <thfabba at gmx dot de>
See issue #6015 for more details.

svn path=/trunk/; revision=51129
2011-03-23 17:11:40 +00:00
Rafal Harabien cd1a61c18f [USER32]
Gray close button if SC_CLOSE is disabled is sysmenu or class has CS_NOCLOSE flag
See issue #5272 for more details.

svn path=/trunk/; revision=51128
2011-03-23 16:51:26 +00:00
Rafal Harabien fcd25281d9 [SHELL32]
Sync RunFileDlg to wine. It was crashing for one char input.
Add "All files (*.*)" filter to RunDlg and OpenWith dialogs. 
Improved polish translation.
Translators: please localize rest...

svn path=/trunk/; revision=51127
2011-03-23 16:22:38 +00:00
Rafal Harabien cd22887a97 [NTOSKRNL]
Revert r51108. ProbeForRead doesn't check if memory is readable.
Improve comments and replace trick raising exception with call to ExRaiseAccessViolation.

[WIN32K]
Remove ASSERTs in IntSetSysColors: this function is only called in NtUserSetSysColors in SEH block. It shouldn't crash for NULL pointers.

svn path=/trunk/; revision=51126
2011-03-23 15:49:44 +00:00
Rafal Harabien 2165af8818 [WIN32K]
Check for failed allocations when creating window
See issue #6021 for more details.

svn path=/trunk/; revision=51125
2011-03-23 15:33:13 +00:00
Gabriel Ilardi aeddc6ac0c Jeisson Toscano: Some Spanish translation updates plus some corrections added by elhoir and me. Bugs: 5891, 5892 and 5897.
See issue #5891 for more details.

svn path=/trunk/; revision=51124
2011-03-23 14:39:39 +00:00
Aleksey Bragin 17d6f165a7 [NTDLL/LDR]
- Fix a few bugs (wrong variable usage, wrong variable initialization) which led to incorrect snapping of import address table.
- Wrap LdrpSnapThunk() invocations into SEH.

svn path=/trunk/; revision=51123
2011-03-23 12:25:53 +00:00
Gabriel Ilardi 906bcad66a Paolo Devoti: Some Italian fixes.
See issue #5847 for more details.

svn path=/trunk/; revision=51122
2011-03-23 11:56:35 +00:00
Gabriel Ilardi d312252d26 [NTOS/INBV]
- Update boot screen copyright year.

svn path=/trunk/; revision=51121
2011-03-23 11:44:35 +00:00
Aleksey Bragin cc6c8e90e2 [NTOS/KE]
- Remove VirtualBox SYSENTER-hack added in r50991.
- Bring back NT-compatible SYSENTER support detection changed in r50991.

svn path=/trunk/; revision=51120
2011-03-22 16:35:51 +00:00
Aleksey Bragin 4fb00286d5 [RTL/HEAP]
- Thomas Faber: Use macro instead of manually removing item from the list.
See issue #6016 for more details.

svn path=/trunk/; revision=51119
2011-03-22 16:27:41 +00:00
Aleksey Bragin 64e9e4c196 [NTDLL]
- Implement LdrpInitializeProcess(). Currently unused.
- Add a whole bunch of supportive PE related code. Used only by the new code, which is not enabled yet in trunk.
- Implement LdrpCheckForLoadedDll().
- Move on to usage of various global vars defined in the new code, rename some of them to match.
- Almost no changes for the codepath in trunk.

svn path=/trunk/; revision=51117
2011-03-22 12:41:52 +00:00
Giannis Adamopoulos 4a05e4ef29 [win32k]
- Simplify BuildWindowStationNameList a bit

svn path=/trunk/; revision=51116
2011-03-22 09:59:36 +00:00
Giannis Adamopoulos 8cf95d1319 [ntoskrnl]
- Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects
- Fix a bug that caused ObpCloseHandle to return success even when OkayToCloseProcedure failed

[win32k]
- Rewrite SetProcessWindowStation to actually set the current window station and close the previous one
- Implement OkayToCloseProcedure callouts from the kernel to prevent closing the current desktop or window station

svn path=/trunk/; revision=51115
2011-03-22 09:19:26 +00:00
Pierre Schweitzer eb3ddf59b3 [NTDLL]
Fixed build

svn path=/trunk/; revision=51114
2011-03-22 06:53:56 +00:00
Aleksey Bragin 1df2f8464a [NTDLL/LDR]
- Implement misc utility functions needed for monstrous LdrpInitializeProcess(). Currently unused.

svn path=/trunk/; revision=51113
2011-03-21 22:58:47 +00:00
Rafal Harabien 46afc9aa8c Fix for r51111. Fixes build...
svn path=/trunk/; revision=51112
2011-03-21 18:30:17 +00:00
Rafal Harabien 08632f7128 [GDI32]
GetTextExtentExPointW doesn't fail if nMaxExtent is negative (only ANSI version does)
Fixes gdi32:GetTextExtentExPoint apitest

svn path=/trunk/; revision=51111
2011-03-21 17:58:08 +00:00
Rafal Harabien f561f03d31 Fix gdi32:SetSysColors apitest
svn path=/trunk/; revision=51110
2011-03-21 14:52:08 +00:00
Rafal Harabien 347b8aee6f Make sure rectangle is not inverted in Rectangle function
Fixes gdi32:Rectangle apitest

svn path=/trunk/; revision=51109
2011-03-21 14:47:06 +00:00
Rafal Harabien ec3c8d2441 Fix ProbeForRead. It wasn't ever checking if memory can be accessed. Thanks to big-endian it wasn't breaking MmUserProbeAddress as well. Code is now nearly the same as in ProbeForWrite. It shouldn't break anything. If it does, it's not bug in this code. :)
svn path=/trunk/; revision=51108
2011-03-21 14:43:56 +00:00
Rafal Harabien 6a7c60945f Set last error to ERROR_INVALID_PARAMETER in NtGdiGetRandomRgn if invalid hdc is given
Fixes gdi32:GetClipRgn apitest

svn path=/trunk/; revision=51106
2011-03-21 14:32:46 +00:00
Rafal Harabien 32b6884390 Don't assume WM_DESTROY is last message - listview sends notification after it. Confirmed in Windows 7.
See issue #6026 for more details.

svn path=/trunk/; revision=51105
2011-03-21 14:21:16 +00:00
Rafal Harabien 8fb7057c46 Set last error to ERROR_PROC_NOT_FOUND in case of NULL module in GetProcAddress
Check for error when freeing datafile
Fixes 2 winetests

svn path=/trunk/; revision=51104
2011-03-21 14:16:01 +00:00
Rafal Harabien 073c778dcb Don't destroy ImageList used by ListView if control was created without LVS_SHAREIMAGELISTS flag
Fixes crashes when closing RegEdit, RApps and hardware tab in mouse settings.

svn path=/trunk/; revision=51103
2011-03-21 14:07:29 +00:00
James Tabor 01ecf02e26 [Win32k]
- Setup RectInRegion for internal use.

svn path=/trunk/; revision=51102
2011-03-21 02:20:24 +00:00
Giannis Adamopoulos 508ce4d9f8 [win32k]
- Fix disconnecting from a desktop when IntSetThreadDesktop gets NULL parameter

svn path=/trunk/; revision=51101
2011-03-20 14:28:12 +00:00
James Tabor 66f5809036 - Fix a miss var for testing.
svn path=/trunk/; revision=51099
2011-03-20 11:29:51 +00:00
Olaf Siejka 099a888ea2 [CACLS]
- Danish translation by Wilhelm Wiens

[RAPPS]
- Polish translations of SumatraPDF entry by Adam Stachowicz

[SETUP]
- Polish translation of 'VBR only' in the reactos.exe

svn path=/trunk/; revision=51098
2011-03-20 11:25:34 +00:00
Pierre Schweitzer 75629abccd [MSI]
Fix build according to Christoph recommandations

svn path=/trunk/; revision=51097
2011-03-20 10:10:52 +00:00
Christoph von Wittich 7dfa68869c [msi]
-partial sync to wine 1.3.16

svn path=/trunk/; revision=51096
2011-03-20 08:47:41 +00:00
James Tabor 06afcd3dd6 [User32]
- Finishing with setting window class types from the window proc. Next step will be checking it in the User32 message exchange instead of using the class structure. This was recognized with the MDI tests, this too could fix the combo listbox issue.
- Minor static test fixes and miscellaneous notes.

svn path=/trunk/; revision=51095
2011-03-20 01:29:39 +00:00
James Tabor 1b6ac48af4 [Win32k]
- Move the appropriate code from window.c to winpos.c, decreasing the size in window.c. Adding proper checks for maximums and desktop/message windows.
- Started MinMaximize, experimental, based on an idea and boredom, needing a good test case. Also away of troubleshooting our window positioning with minimize and maximizing windows.

svn path=/trunk/; revision=51094
2011-03-20 01:09:15 +00:00
James Tabor f106ac2d2b [Win32k]
- Fix sign for BeginDeferWindowPos(-1) test, see bug 6025.


svn path=/trunk/; revision=51093
2011-03-20 00:21:45 +00:00
Eric Kohl 80b43e7b13 [SERVICES]
RQueryServiceConfig2A/W must return ERROR_SUCCESS if the Description value of a service does not exist. This fixes a winetest failure.

svn path=/trunk/; revision=51092
2011-03-19 19:14:53 +00:00
Olaf Siejka fb3cc815f7 [DESK.CPL]
- Activate "Show window contents while dragging" button for all languages present. Spotted by Piotr_hh
See issue #6002 for more details.

svn path=/trunk/; revision=51091
2011-03-19 14:11:37 +00:00
Pierre Schweitzer 5f2514cd75 [HAL]
Remove HAL entry point (HalInitSystem) from generic lib, and move it to generic libs that handle different build flags.
This fixes HAL MP entry point, for example

svn path=/trunk/; revision=51090
2011-03-19 13:59:23 +00:00
James Tabor 115d07d686 [Win32k]
- Implement the set of DeferWindowPos functions. Regedit (one of many application) uses it and allocated three when it should be four. This was a good test to verify the batch list growing routine. Instead of drawing per DeferWindowPos call, now a real list is created and run down as a batch.
- ReactOS should handle this the correct way and a good test case is located here: http://bugs.winehq.org/show_bug.cgi?id=23187
- The code is from wine and modified for the use in ReactOS.

svn path=/trunk/; revision=51089
2011-03-18 22:41:22 +00:00
Aleksey Bragin f5912e7155 [NTDLL]
- Rewrite the very first initialization routine: LdrpInit().
- Rename LdrpInit2() to LdrpInitializeProcess(), and LdrpAttachThread() to LdrpInitializeThread(). Still old code there.

svn path=/trunk/; revision=51088
2011-03-18 20:23:18 +00:00
Giannis Adamopoulos b75783bd61 [win32k]
- SetThreadDesktop: Actually set hdesk in PTHREADINFO
Now GetThreadDesktop doesn't return 0

svn path=/trunk/; revision=51086
2011-03-17 20:32:24 +00:00
Aleksey Bragin 1ba1132e21 [NTDLL/LDR]
- Use LdrpRunInitializeRoutines() instead of the old LdrpAttachThread(). This adds calls to unimplemented context functions, but since they were not called at all by the old code it shouldn't change the behaviour significantly. Besides of that, it's start of significant changes in the "mainstream" codepaths, so regressions might occur.

svn path=/trunk/; revision=51085
2011-03-17 17:47:42 +00:00
Aleksey Bragin 3b6432c7ed [NTDLL]
- Implement fetching address of a security cookie in an image. Still not used even if it's present there.
- Silence some debug prints.

svn path=/trunk/; revision=51084
2011-03-17 14:25:59 +00:00
Aleksey Bragin 6fc1e4e122 [RTL]
- Limit unimplemented warnings about RtlActivateActivationContextUnsafeFast calls for now so that they don't flood the log too much.

svn path=/trunk/; revision=51083
2011-03-17 14:24:34 +00:00
Giannis Adamopoulos 71201dea2c [win32k]
- Improve the definition and simplify NtUserCreateDesktop, NtUserOpenDesktop, NtUserCreateWindowStation, NtUserOpenWindowStation

svn path=/trunk/; revision=51082
2011-03-17 13:19:18 +00:00
Aleksey Bragin bfb74cd0bc - Fix build.
svn path=/trunk/; revision=51080
2011-03-17 11:20:16 +00:00
Aleksey Bragin 22cb80d434 [NTDLL/LDR]
- Fix a typo in LdrQueryProcessModuleInformationEx().
- Stub LdrpEnsureLoaderLockIsHeld() for now.
- Improve LdrpRunInitializeRoutines() and enable it (just compiling, it's not in the running path of the code yet).
- Fix an uninit var warning in ldrpe.c
- Implement LdrpClearLoadInProgress().
- Rename "ExeModule" to a more consistent LdrpImageEntry.

svn path=/trunk/; revision=51079
2011-03-17 10:59:54 +00:00