Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-30 18:01:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[WIN32K]

Browse source 
Fix parameter check and buffer probing in NtUserSetSysColors

svn path=/trunk/; revision=51188
This commit is contained in:
Timo Kreuzer 2011-03-29 09:52:39 +00:00
parent 0bf0c70444
commit 216026918d
1 changed files with 11 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
reactos/subsystems/win32/win32k/ntuser/ntstubs.c
View file

@ -539,37 +539,34 @@ NtUserSetSysColors(
FLONG Flags)
{
DWORD Ret = TRUE;
NTSTATUS Status = STATUS_SUCCESS;
if (cElements == 0)
return TRUE;
if ((ULONG)cElements >= 0x40000000)
return FALSE;
UserEnterExclusive();
_SEH2_TRY
{
ProbeForRead(lpaElements,
sizeof(INT),
1);
ProbeForRead(lpaRgbValues,
sizeof(COLORREF),
1);
// Developers: We are thread locked and calling gdi.
ProbeForRead(lpaElements, cElements * sizeof(INT), 1);
ProbeForRead(lpaRgbValues, cElements * sizeof(COLORREF), 1);
IntSetSysColors(cElements, lpaElements, lpaRgbValues);
}
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
{
Status = _SEH2_GetExceptionCode();
}
_SEH2_END;
if (!NT_SUCCESS(Status))
{
SetLastNtError(Status);
SetLastNtError(_SEH2_GetExceptionCode());
Ret = FALSE;
}
_SEH2_END;
if (Ret)
{
UserSendNotifyMessage(HWND_BROADCAST, WM_SYSCOLORCHANGE, 0, 0);
}
UserLeave();
return Ret;
}