* Fix count of visible buttons getting out of sync when removing buttons. Fixes empty space at the end of the notification toolbar.
CORE-8840 #resolve #comment This should be fixed as of r65805.
svn path=/trunk/; revision=65805
* Improve an older change that I commited by mistake, with the improvbements based on a patch by Giannis.
* In Windows, fixes the taskbar having a size grip with the taskbar is themed and locked.
* In ReactOS, the size grip never seems to disappear, contrary to Giannis' concerns in the issue.
* Because of the above, I decided to commit the changes, and let the sizing edge inconsistency be a followup to the issue.
CORE-6966 #resolve #comment A modified version of the patch was commited in r65804. Thanks.
svn path=/trunk/; revision=65804
* Handle WM_CONTEXTMENU in the notification area so it does not spread upwards to the taskbar window.
* In theory, only one of the two handlers would be necessary, and it is true when testing in Windows, but in ReactOS, the handler in CSysPagerWnd was not enough. This may be worth a look by the win32k experts to see if it's a bug, or Windows was correcting my error.
CORE-8870 #resolve #comment Should be fixed in r65803. Thanks for reporting.
svn path=/trunk/; revision=65803
So far, totally disable VPB swapout on dismount. It appears to have brought more issues than it actually solves.
A more accurate implementation will be required.
CORE-8928 #comment Can you please retry with r65801
svn path=/trunk/; revision=65801
[USER32][USERSRV][WIN32K]
- Flag CSRSS threads as such.
- Each time a win32 thread is "created" (or a win32k system call is done) a PsConvertToGuiThread call is done, that makes a Win32ThreadCallout which calls UserCreateThreadInfo. We should call back ClientThreadSetup to set client-side info.
- Introduce a ClientThreadSetupHelper function to try to understand what happens when doing direct calls to ClientThreadSetup and via win32k callbacks.
- Reenable CSR call in user32::DllMain but add shame hacks in Init(..) to force NtUserProcessConnect callbacks (yet they should not be done there): see the code comment associated for more details.
- Temporarily disable ClientThreadSetupHelper call in ClientThreadSetup because it makes things fail, like console input thread failing and so on...
- ... and in ClientThreadSetupHelper, some correct code is commented out because it currently breaks other things (like menu initialization etc...), and HACKS ARE ADDED!! (see especially the "if (gpsi)" one, that should not exist, but if removed we fail sometimes in MenuInit because gpsi becomes NULL for some reason, if some other code that makes redundant calls to NtUserProcessConnect, is uncommented).
To sum up I tried to scaffold the thing as it should be, but with disabled code to not break everything.
CORE-8949 #comment Revision 65799 committed the patch v1.
svn path=/trunk/; revision=65799
- Reenable UserClientConnect callback, it's not the problematic code that made bots to fail at 3rd stage and caused r65716 to be committed.
- Put the system threads hack *after* having called NtUserInitialize (that really initializes user-kernel interface with win32k), and not before.
svn path=/trunk/; revision=65798
- Call NtGdiInit before initializing ourselves (ok, in ROS NtGdiInit does nothing interesting, but still do it to be call-compatible with win2k3 so everything initializes as it should).
- Do some cleanup on process detach.
svn path=/trunk/; revision=65797
- In German translation, replace erroneous \" to "" for putting quotes inside strings. Fixes resource compilation in GCC/MSVC.
- Make proper help string indentation in resource files. NOTE FOR TRANSLATORS: Please keep the identation correct!
svn path=/trunk/; revision=65790
Fix invalid memory usage, memory leaks, partial zeroes, big if blocks, ...
Would be nice also to check all the allocations which are not checked yet
CORE-8533
svn path=/trunk/; revision=65788
* Fix the fallback case when BCM_GETIDEALSIZE doesn't work.
* Take into account the size of the borders of the start button twice. Now the caption has enough space and doesn't hide part of the border and more importantly the button is vertically aligned to the tasks buttons.
svn path=/trunk/; revision=65780
Start implementing the recovery console: CLS, EXIT and HELP have been implemented. I also added a DUMPSECTOR command that enables us to dump disk sectors to the screen. For example "DUMPSECTOR 0 63" dumps disk 0 sector 63 to the screen.
svn path=/trunk/; revision=65778
Fix some translations as preparation to get this one fixed: CORE-5790
At least most languages now look sort of nicely. Next: apply the patch and check the non ResHacker compatible languages
svn path=/trunk/; revision=65776
* Forward focus to the defview window when the shell browser gets the focus.
* We can now navigate to the opened window with the keyboard right after it opens. That means that after opening from the desktop a window with the keyboard, we can navigate right away without any additional mouse clicks.
svn path=/trunk/; revision=65775
"No shortcut to the On Screen Keyboard in the start menu" by Jared
CORE-8883 #resolve #comment Committed with minor fix in German translation, thx for help.
svn path=/trunk/; revision=65773
* Do not enable the CExplorerBand wrapper by default. Avoids crashing due to a stack overflow.
CORE-8930 #resolve #comment Oops. Fixed in r65772. Thanks.
svn path=/trunk/; revision=65772
* Make the shell menus focus the parent before displaying themselves. Fixes keyboard focus when opening the start menu with the windows key.
NOTE: I put this in the focus manager for lack of a better place, but it may not be how Windows does it.
svn path=/trunk/; revision=65769
* Do not add two additional pixels at the top margin of the toolbar. This is the behaviour of comctl32 v6 and our explorer depends on that to appear properly. We don't have a proper solution for these differences in behavior and since we already opt to use the v6 behavior I think it is fine.
CORE-5483 #resolve #comment Committed a slightly different version of the patch, thanks.
svn path=/trunk/; revision=65766
* Halfplement IExtractIconAW support into the recycle bin. This is not fully correct as it always uses the fallback file icon, but it's better than nothing at all.
CORE-3938
svn path=/trunk/; revision=65759
* Move to shellext folder.
* Do not initialize the notification SSO, stobject will do so (like in Windows).
* Move some GUIDs to a shared header.
[STOBJECT]
* Initialize netshell's SSO the way Windows does it. Fixes network icon inconsistency.
* Move some GUIDs to a shared header.
CORE-8818 #resolve Fixed in trunk r65758.
svn path=/trunk/; revision=65758