Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-07-07 13:15:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
73400 commits 87 branches 274 tags 1 GiB
Commit graph

1106 commits

Author SHA1 Message Date
Eric Kohl 54eb5635d8 [MSPORTS] Implement the 'Enable legacy Plug and Play detection' setting 2018-09-29 18:05:22 +02:00
Abdulganiev Rafael 6f138e2811 [DESK.CPL] Remove monitor resource scaling (#876) 2018-09-29 16:24:10 +02:00
Stanislav Motylkov 4eccca5943
[SYSDM] Add hardware model name print 2018-09-29 17:12:18 +03:00
Stanislav Motylkov 797d2354fa
[SYSDM] Add one more IDC_MACHINELINE for model name 2018-09-29 17:11:57 +03:00
Stanislav Motylkov bd1fc964e7
[SYSDM] Move system information controls 16 points higher 2018-09-29 17:11:31 +03:00
Eric Kohl 133611fed8 [MSPORTS] Implement the 'Filter Resource Method' setting for parallel ports 2018-09-29 14:58:55 +02:00
Pierre Schweitzer 1f85e4fe9f
[DEVCPUX] Add French translation 2018-09-29 11:36:45 +02:00
Eric Kohl f155de483f [msports] Notify the system of changes to the serial port settings. 2018-09-29 01:57:59 +02:00
Hermès Bélusca-Maïto c446ce0d62
[ADVAPI32] Improve a bit CreateProcessAsUser(). 
- Check whether the user-provided token is a primary token.

- Do not fail when the RtlAdjustPrivilege() call fails (see the code
  comment for an explanation). TL;DR is: that call may indeed fail but
  the privilege may also not be necessary because the user-provided
  token is a restricted version of the caller's primary token.
  And this is situation is perfectly fine.

This fixes Java 7 installation, CORE-14874.
 2018-09-28 00:45:04 +02:00
Stanislav Motylkov 0fa744241f [DEVCPUX] Add russian translation 
Also make MHz string translatable. Addendum to 793e2a3.
 2018-09-27 12:10:06 +02:00
Eric Kohl 3c1e5f7cb9 [NETCFGX] Add the most simple property sheet provider for network adapters 
- Switch to WINE debug code.
- Build the UNICODE version of the DLL by default.
- Add the most simple property sheet provider.
 2018-09-26 23:49:02 +02:00
Eric Kohl 986ce63c4c [SETUPAPI] SetupDiGetClassDevPropertySheetsW: Support class property sheet providers. 2018-09-26 23:49:01 +02:00
Stanislav Motylkov 68c6641781 [MSPORTS] Add russian translation 
Addendum to 69e834f.
 2018-09-25 22:50:02 +02:00
Eric Kohl 793e2a38b4 [DEVCPUX] Make the CPU property sheet page a little nicer and make it translatable 2018-09-25 21:51:19 +02:00
Eric Kohl af37e0e565 [MSPORTS] Hackfix the code to determine the serial and parallel port numbers. 
Now that SetupDiCreateDevRegKeyW is working as expected, we can no
longer (ab)use it to retrieve a ports resources. Use SetupDiGetDeviceInstanceIdW instead and open the registry keys manually.
 2018-09-25 17:48:27 +02:00
Eric Kohl 69e834fa54 [MSPORTS] Implement serial port settings 
- Fix the control styles and grouping in the dialogs.
- Implement reading, modifying and writing of the serial port settings.
 2018-09-25 14:28:29 +02:00
Eric Kohl 185a8fd835 [NETSHELL] Read, write and display the 'Notify me when this connection...' option for network connections. 2018-09-23 23:31:00 +02:00
Eric Kohl df36ee9fe2 [SETUPAPI] Replace the remaining internal calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKeyW by calls to SETUPDI_OpenDrvKey, SETUPDI_CreateDevKey or SETUPDI_CreateDrvKey. 2018-09-23 20:19:26 +02:00
Hermès Bélusca-Maïto bf164caae8
[SERVICES] Simplify the implementation of RGetServiceDisplayNameA/W() and RGetServiceKeyNameA/W(). 
Also comment about the observed behaviour of the returned number of "characters"
returned by the ANSI versions of these APIs (which is tested by advapi32_winetest:service).

[ADVAPI32:SCM] Add a comment concerning wide characters vs. bytes mismatch.
 2018-09-23 18:09:10 +02:00
Eric Kohl 60e166535a [SETUPAPI] Do not use SetupDiOpenDevRegKey in other SetupDi functions. Use SETUPDI_OpenDevKey or SETUPDI_OpenDrvKey instead. 
Note: The remaining calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKey will be fixed in another patch.

Fixes CORE-15091
 2018-09-23 16:16:12 +02:00
Hermès Bélusca-Maïto 7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed. 
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
 2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings() 
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981
 2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto 41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine. 
- Adjust the code with respect to:
  "shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
  4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)

- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
  ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)

- "shell32: Assume that system directory always contains a drive letter."
  54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)

- "shell32: Use ARRAY_SIZE macro."
  612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)

- "shell32: Fix a trace message."
  bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)

- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
  f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)

- "shell32: Pass correct buffer length to RegQueryValueExW()."
  0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)

- "shell32: Remove unused string (Clang)."
  8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)

- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
  730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
 2018-09-23 00:16:02 +02:00
Eric Kohl de08785ade [SETUPAPI] SetupDiCreateDevRegKeyW / SetupDiOpenDevRegKey: Create or open the 'Device Parameters' subkey of the given devices enum key when we try to access its hardware key. 
This creates the PortName value in the proper location for serial ports.
 2018-09-22 14:43:43 +02:00
Abdulganiev Rafael 2a6aa7770e [BTHCI] Add a bluetooth icon (#871) 
[BTHCI] Add a bluetooth icon
 2018-09-21 23:42:27 +02:00
Eric Kohl f8f83d4d4d [BTHCI] Add a bluetooth class installer stub. 
Now we really need a tango-compatible bluetooth icon!
 2018-09-20 17:53:08 +02:00
Eric Kohl 5e2fe08918 [WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service. 
The Logoff-Handler might try to notify the scheduler service which might already have been shut down. We need to fix the shutdown sequence, so that the service manager stops all running services.

Might fix CORE-14521.
 2018-09-19 16:35:12 +02:00
Eric Kohl 76588be0d1 [ADVAPI32][SERVICES] Use the session key provided by SystemFunction028 to encrypt and decrypt the service passwords. 2018-09-19 12:30:33 +02:00
Eric Kohl 4114dcad46 [ADVAPI32] Implement SystemFunction028 to always return the default session key. 2018-09-19 00:20:11 +02:00
Eric Kohl e5fcda922b [ADVAPI32][SERVICES] Pass encrypted passwords to the service manager. 
- Encrypt passwords before passing them to the service manager. Right now, we are using a fixed encryption key. This will be fixed later.
- Replace the calls to ZeroMemory which are used to wipe the password buffers by calls to SecureZeroMemory.
 2018-09-18 21:33:29 +02:00
Eric Kohl da73c81259 [IDL][LSASRV] Improve the credentials interface a little and update the lsa server code accordingly. 2018-09-18 15:55:18 +02:00
Eric Kohl 6c0d9c01e2 [ADVAPI32] SystemFunction004 and SystemFunction005 must return the required output buffer size via out->Length when the buffer is too small. 2018-09-17 23:19:02 +02:00
Eric Kohl 5e2c4657ca [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager 2018-09-17 16:34:48 +02:00
Eric Kohl 47714b25a9 [NETAPI32] Add more DFS stubs 2018-09-16 21:11:16 +02:00
Pierre Schweitzer 8c5b0fbff3
[KERNEL32_VISTA] Make SleepConditionVariableSRW fail when it times out 
This fixes a few newly added winetests.
 2018-09-16 14:50:01 +02:00
Pierre Schweitzer 58853297dc
[KERNEL32_VISTA] Make SleepConditionVariableCS fail when it times out 
This fixes a few newly added winetests.
 2018-09-16 14:42:43 +02:00
Mark Jansen 12654d2852
[KERNEL32] Ensure the PebLock is always released in FlsFree 2018-09-15 17:56:03 +02:00
Mark Jansen 06eb99edef
[NTDLL][KERNEL32] Implement FLS callbacks. 2018-09-15 17:56:03 +02:00
Eric Kohl e13ff1470e [DESK] Add MonitorClassInstaller 2018-09-15 14:11:04 +02:00
Pierre Schweitzer 71ac5e6c65
[SHELLBTRFS] Fix GCC build 
CORE-15048
 2018-09-15 10:54:00 +02:00
Thomas Faber 0f47f27829
[SHELLBTRFS] Add exports according to upstream .def file. CORE-15048 2018-09-15 09:43:31 +02:00
Pierre Schweitzer f4da2bab03
[MPR] Import Wine commit: 93fb279f4f3e150eee329b02ca5fb0251d8a239d 
Properly handle device-less connections.

CORE-15012
 2018-09-14 22:34:02 +02:00
Stanislav Motylkov 8d6c519a95 [SYSDM.CPL] Fixup control positions after font metrics fix 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 877dffa918 [DESK.CPL] Settings: Fixup control positions 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 8df45999f2 [DESK.CPL] Screensaver: Fixup control positions 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 36bebe7427 [DESK.CPL] Background: Fixup control positions after font metrics fix 2018-09-14 11:15:26 +02:00
Stanislav Motylkov 432788b59f [DESK.CPL] Appearance: Fixup control positions after font metrics fix 
CORE-14274
 2018-09-14 11:15:26 +02:00
Katayama Hirofumi MZ 31019e8c0c [TRANSLATION] Update Romanian translation (#851) 
Translation from Stefan Fulea.
CORE-15023
 2018-09-14 11:04:36 +02:00
Pierre Schweitzer 62f79fae93
[MPR] Import Wine commit: 0799550075654094a3bed080aac722b9bea01307 
Implement WNetClearConnections().

CORE-15012
 2018-09-14 08:08:57 +02:00
Mark Jansen 8642654a00
[KERNEL32] Do not embed binary data inside a string resource. 
CORE-14948
 2018-09-12 21:31:55 +02:00
Mark Jansen 25d143dd20
[DBGHELP] Prevent crashing on a malformed PE file. 
CORE-15030
 2018-09-12 21:30:49 +02:00
Eric Kohl ee4ee2fc1d [NETAPI32] Remove the obsolete file group.c 2018-09-12 17:53:49 +02:00
Eric Kohl 221cdeafe2 [NETAPI32] Rename ENUM_CONTEXT to GROUP_ENUM_CONEXT and fix a use of the wrong type 2018-09-12 17:38:18 +02:00
Eric Kohl 4d9425d123 [NETAPI32] Implement NetGroupSetUsers 2018-09-12 17:11:52 +02:00
Eric Kohl e0b5050089 [NETAPI32] Implement NetLogonGetTimeServiceParentDomain 2018-09-11 15:02:19 +02:00
Pierre Schweitzer cf0112a6e6
[MPR] Implement WNetClearConnections() 
This has been submitted upstream.

CORE-15012
 2018-09-11 08:30:23 +02:00
Eric Kohl 74620c94d3 [NETAPI32] Implement NetGroupGetUsers 2018-09-10 22:05:49 +02:00
Baruch Rutman ab5fdcc01f
[LPK] Make GetCharacterPlacement caret positions respect bidi. (#842) 
- Try to make use of ScriptStringCPtoX when trying to fill the lpCaretPos struct member;
  if USP10 error happens fallback to the unreorder method.
- Remove now incorrect debug print.
 2018-09-09 18:03:45 +02:00
Katayama Hirofumi MZ a244e4f6dd [WIN32SS][COMCTL32] Fix button text Y positioning (#766) 
Fixes the vertical position of button text.
CORE-14906
 2018-09-09 17:37:37 +02:00
Eric Kohl 2d645f62fe [NETAPI32] Implement NetGroupAddUser and NetGroupDelUser 2018-09-09 17:35:18 +02:00
Eric Kohl df0137a169 [NETAPI32] Implement NetGroupSetInfo 2018-09-09 13:39:01 +02:00
Eric Kohl c48d09d19a [NETAPI32] Implement NetGroupAdd and NetGroupDel 2018-09-09 11:52:44 +02:00
Eric Kohl a9da3c50be [NETAPI] Implement NetGroupGetInfo 2018-09-09 09:40:11 +02:00
Eric Kohl 033146ca23 [NETAPI] Implement NetGroupEnum 2018-09-08 20:55:13 +02:00
Eric Kohl 0e69bc3bce [SAMSRV] Fix SamrQueryInformationGroup 
- Use the registry value AdminComment for admin comments instead of Description. Fix SamrSetInformationGroup as well.
- Add some TRACEs.
- Do not fail if the Members value does not exist.
 2018-09-08 19:24:13 +02:00
Abdulganiev Rafael 25f4ed75a0 [CPL][DESK] Update monitor resource (#816) 
[DESK.CPL] Update monitor resource
 2018-09-07 08:43:36 +01:00
Pierre Schweitzer 000bbe074e
[LIBTIRPC] Fix CVE-2018-14622 by backporting its fix 
CORE-15005
 2018-09-05 22:06:30 +02:00
Eric Kohl df053b7d16 [MSV1_0] LsaApLogonUser: Update the logon time/count and bad password time/count 2018-09-05 00:10:54 +02:00
Eric Kohl 97382dee46 [MSV1_0] Use the account expiration time and check account expiration on logon 2018-09-04 23:15:15 +02:00
Eric Kohl e25cbeba2f [IDL] Implement parts of SamrSetInformationUser.UserInternal2Information 2018-09-04 22:42:49 +02:00
Bișoc George 4208e7eed8 [FONTEXT] Add Italian translation (#831) 2018-09-04 22:02:44 +02:00
Bișoc George 773d6a536a [ACCESS] Fix some truncated strings in French resource (#838) 2018-09-03 14:14:57 +02:00
Eric Kohl 653a9be05b [SAMSRV] Implement SamrQueryInformationUser.UserInternal2Information 2018-09-02 17:54:26 +02:00
Stanislav Motylkov c7415b3faa [MSGINA] Update russian translation (#834) 
Addendum to 6f4d70b.
 2018-09-02 15:59:33 +02:00
Eric Kohl 6f4d70b405 [MSGINA] Display the 'account expired' message when a user tries to log on using an expired account. 2018-09-01 21:10:42 +02:00
Denis Malikov 69a040d275 [KERNEL32] fix spec file for -version=0x600+ 
CORE-12596
 2018-09-01 17:21:21 +02:00
Pierre Schweitzer 2bd33d58d8
[KERNEL32] Shhhh! 2018-09-01 15:46:44 +02:00
Joachim Henze e217e926e1 [SHELL32] Fix typo in comment 2018-08-28 14:24:49 +02:00
Mark Jansen 191dceb034
[LDR] Load kernel32 in LdrpInitializeProcess. 
This allows kernel32 to register itself for manifest probing when loading dlls
CORE-9219
 2018-08-27 20:05:00 +02:00
Mark Jansen ffae49deaf
[COMCTL32] Unregister some classes that were registered. 
This should help fix some crashes.
 2018-08-27 19:49:57 +02:00
Katayama Hirofumi MZ 39dc3cdaf6 [SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824) 
CORE-14974
 2018-08-27 12:21:51 +02:00
Mark Jansen 19e9a44118
[SHELL32] Check the result from PathUnExpandEnvStringsW 2018-08-27 11:58:29 +02:00
Mark Jansen 608cb60e44
[SHELL32] Remove some mostly dead code from CShellLink 2018-08-27 11:58:24 +02:00
Eric Kohl fc2b4bc7ea [LSASRV] LsapLogonUser creates an impersonation token for a network logon 2018-08-27 00:19:10 +02:00
Eric Kohl a7b52d6a44 [SAMSRV] Simplify the initialization of the account expiration time 2018-08-27 00:12:44 +02:00
Eric Kohl 2fafcff3ef [SAMLIB] Add stubs for SamTestPrivateFunctionsDomain and SamTestPrivateFunctionsUser 2018-08-27 00:11:21 +02:00
Eric Kohl a9f2677782 [SAMSRV] Simplify the initialization of the account expiration date for new user accounts 2018-08-26 21:26:31 +02:00
Eric Kohl dcc188e974 [NETAPI32] Add code to handle special values of the last logon time, last logoff time and account expiration time 2018-08-26 21:07:05 +02:00
Katayama Hirofumi MZ 6eb6aa2895 [SHELL32] Fix CShellLink::GetIconLocation (#810) 
Fixes a regression from PR #784.
CORE-14961, CORE-14009
 2018-08-26 15:37:15 +02:00
Baruch Rutman e7d2bbe726 [WIN32SS][LPK] Add BiDi support to menus and window captions (#738) 
Added callback function that redirects calls to GreExtTextOutW that didn't went through lpk BiDi processing, calls that are from the kernel.

Completely solves JIRA issue CORE-6910.
 2018-08-23 19:43:12 +02:00
Katayama Hirofumi MZ 86b915ef84 [TRANSLATION][ZIPFLDR] Add Japanese translation (#799) 
CORE-14954
 2018-08-22 14:26:53 +02:00
Andreas Bjerkeholt 5a2a0314a1 [TRANSLATION][ZIPFLDR] Add Swedish translation (#794) 2018-08-21 16:57:01 +02:00
Serge Gautherie 990e7dfd1a [MSHTML] Fix 3 MSVC warnings about HTML*Element_handle_event() 
- "...\htmlanchor.c(769) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlarea.c(427) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlform.c(757) : warning C4028: formal parameter 2 different from declaration"

Cherry-pick Jacek Caban a660f673cb
CORE-7538
 2018-08-21 14:33:52 +02:00
Katayama Hirofumi MZ 73798d2e71 [SHELL32] Enable to change shortcut icon (#784) 
CORE-11407
 2018-08-21 13:49:32 +02:00
Robert Naumann b3cfe88eda [BROWSEUI] Show Tooltip text for 'Go' Button 
-Patch by Barret Karish CORE-11058
 2018-08-21 12:49:04 +02:00
Andreas Bjerkeholt a4554c07b0
[ZIPFLDR] Enable / disable the correct wizard buttons 2018-08-21 12:06:41 +02:00
Timo Kreuzer 36051d3065 [SYSSETUP] Fix handling of the status message window 
This fixes a race condition, where the message thread was still running when InstallReactOS returned and syssetup.dll was unloaded by the caller (setup.exe).
 2018-08-20 22:10:04 +02:00
Serge Gautherie 2e7b73dc75 [MSHTML] Fix an MSVC warning about HTMLInputElementImpl_fire_event() 
"...\htmlinput.c(1303) : warning C4028: formal parameter 2 different from declaration"

Temporary fix, until WINESYNC replaces this function.
CORE-7538
 2018-08-20 19:06:00 +02:00
Adam Słaboń af3d426685 [TRANSLATION] Polish translation update (#781) 
In addition: fix the encoding of the comdlg32 and ntvdm polish resource files.
 2018-08-20 17:00:33 +02:00
Eric Kohl 91fab9e53b [SETUPAPI] SetupDiGetDeviceRegistryPropertyW call CM_Get_DevNode_Registry_Property_ExW for properties that can not be retrieved from the registry 2018-08-20 00:16:18 +02:00
Pierre Schweitzer e8611d3e65
[NETSHELL] Update French translation to reflect 0725098 2018-08-19 20:50:55 +02:00
Stanislav Motylkov 844483504b [KERNEL32] Implement system firmware functions properly 2018-08-19 20:27:59 +02:00
EUPHORIA-IT\m.jansen bb5f8cfccb [WSHOM.OCX] Zero-initialize timeout and type if they are not set. 
This should fix buildbot timeouts
 2018-08-19 16:14:08 +02:00
Eric Kohl a8cf35d0e4 [SYSSETUP] SetupStartService: Remove the wait loop 
CORE-14909
 2018-08-19 14:32:29 +02:00
Thomas Faber c97e9defc1
[WINED3D] Yield CPU to the scheduler in wined3d_pause. CORE-14637 CORE-14534 
Much like the previous commit, this is a workaround for our buggy Win32k.
 2018-08-19 13:46:08 +02:00
Thomas Faber adfbefde2b
[WINED3D] Avoid spinning in wined3d_cs_run. CORE-14534 
Spinning here is supposed to improve performance by avoiding scheduling
overhead, but because ReactOS's Win32 subsystem does not deal with this well,
it causes the system to freeze on ROS.
As a workaround, we disable spinning and jump directly to the wait.

It should become obvious when this starts actually causing performance issues
again and it's time to undo.
 2018-08-19 13:46:02 +02:00
Eric Kohl 9a36ee8359 [WLNOTIFY] Use the wine debug method, add wlnotify to the build and fix some typos 2018-08-18 22:20:17 +02:00
Mark Jansen cf56e1cb58 [GDIPLUS] Add sxs registration for 1.0 version. 
Needed by by some applications with MSVCR90.dll
CORE-14695
 2018-08-18 18:25:13 +02:00
Eric Kohl df849213a2 [WLNOTIFY] Add SCard, Termsrv and Wlballon notifications and remove the test notifications 2018-08-18 16:18:36 +02:00
Katayama Hirofumi MZ 0725098c74 [NETSHELL] Fix the too long texts 2018-08-18 13:18:03 +02:00
Timo Kreuzer 094a90ad4e [NTOS:PS] Fix an issue with PROCESS_DEVICEMAP_INFORMATION size on 64 bit builds 
The PROCESS_DEVICEMAP_INFORMATION  union has 2 fields, one is a handle, the other one is a structure of 36 bytes (independent of architecture). The handle forces 64 bit alignment on 64 bit builds, making the structure 4 bytes bigger than on 32 bit builds. The site is checked in NtQueryInformationProcess (case ProcessDeviceMap). The expected size on x64 is the size of the Query structure without alignment. autocheck correctly passes the site of the Query union member, while smss passes the full size of PROCESS_DEVICEMAP_INFORMATION. Packing the structure is not an option, since it is defined in public headers without packing. Using the original headers sizeof(PROCESS_DEVICEMAP_INFORMATION) is 0x28, sizeof(PROCESS_DEVICEMAP_INFORMATION::Query) is 0x24.
 2018-08-17 22:08:37 +02:00
Joachim Henze abf9340f1b [SHELL32] Translation de-DE CORE-14916 
fix control overlapping in IDD_FOLDER_OPTIONS_FILETYPES
(broke in 0.4.10-dev-24-ed1c6bb0060d06f4c0167d9c2d732f4dc2b4cce4)

and translate IDD_NEWEXTENSION, IDD_EDITTYPE, IDD_ACTION, IDD_FOLDER_CUSTOMIZE
 2018-08-17 18:07:35 +02:00
Serge Gautherie 2ad650469e [OLEAUT32] Fix an MSVC warning about VarCyMul() 
"...\vartype.c(3808) : warning C4028: formal parameter 2 different from declaration"

Mininal cherry-pick Alexandre Julliard 18f7ec3670
CORE-7538
 2018-08-17 16:18:41 +02:00
Getequ d559ca9c98 [ADVAPI32][SHELL32][DESK.CPL] Kill copy-paste of RegLoadMUIString. (#748) 
RegLoadMUIStringW/A is part of advapi32.dll . shell32.dll and desk.cpl contained exact line-by-line copy of that function.
 2018-08-16 16:10:41 +02:00
Stanislav Motylkov 68a4cdd5ec [SYSDM] Use single string control for system version 2018-08-15 19:30:23 +02:00
Katayama Hirofumi MZ 6d9f89f813 [SYSSETUP] Fix the button sizes of theme selection dialog (#746) 
CORE-14896
 2018-08-15 18:32:17 +02:00
Mike Swanson 3c7e9bb332 Remove unnecessary executable bits 2018-08-15 18:29:09 +02:00
Mark Jansen 9b6fb9f2f8
[RTL][KERNEL32] Add a comment indicating we need SEH in RtlImageNtHeaderEx 
CORE-14532
CORE-14857
 2018-08-13 13:24:12 +02:00
Mark Jansen ad08c6631b
[LDR] Guard some sections where we grab a lock. 
CORE-14532
 2018-08-13 13:24:12 +02:00
Mark Jansen 55053f0099
[LDR] Add debug logging when we encountered an exception in dll/tls callbacks. 
CORE-14532
 2018-08-13 13:24:12 +02:00
Mark Jansen dfff8ed0d8
[LDR] Protect calls from LdrpCallInitRoutine and LdrpCallTlsInitializers with SEH. 
CORE-14532
 2018-08-13 13:24:00 +02:00
Eric Kohl 956086d369 [NETAPI32] Add DFS RPC interface and some DFS stubs 2018-08-12 14:31:07 +02:00
Katayama Hirofumi MZ db13b422b3 [SHELL32] Fix a careless mistake of ShellExecCmdLine (#737) 
CORE-14886
 2018-08-10 13:25:50 +02:00
Eric Kohl fb5d5ecd64 [WLNOTIFY] Add sens service stubs 2018-08-07 22:56:33 +02:00
Hermès Bélusca-Maïto 40000a1716
[WINLOGON][MSGINA] Fix typo. 2018-08-06 17:37:38 +02:00
Eric Kohl 8f911f21b8 [SYSSETUP] SetupStartService: Wait until the service is running 2018-08-05 20:02:22 +02:00
Eric Kohl 5ebcc6cdc1 [ADVAPI32] Add parameter checks to LogonUserExW and initialize the token handle. 2018-08-05 16:16:53 +02:00
Eric Kohl b4040ea740 [NETAPI32] Implement I_NetServerSetServiceBits() 2018-08-05 15:57:03 +02:00
Eric Kohl 89f6e701d4 [NETAPI32] Add annotations and move NetUseGetInfo to a better location. 2018-08-05 15:36:48 +02:00
Katayama Hirofumi MZ bfcbda227f [SHELL32] Fix handling of multiple parameters in the 'Run' dialog (#665) 
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.

- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.

CORE-14790
 2018-08-05 13:39:17 +02:00
Mark Jansen 572976bb14
[ZIPFLDR] Add 'Extract All' to individual item context menu. 2018-08-05 11:54:56 +02:00
Mark Jansen 875e58d781
[ZIPFLDR] Add 'Extract All' menu item to the folder context menu. 2018-08-05 11:54:56 +02:00
Mark Jansen eb324b6a9c
[ZIPFLDR] Implement RouteTheCall, so that applications can 'launch' zip files 2018-08-05 11:54:56 +02:00
Eric Kohl 4e32ad3623 [LSASRV] Implement and call the policy change notification routine 2018-08-05 01:05:52 +02:00
Eric Kohl 620217cec9 [LSASRV][SECUR32] Implement LsaRegisterPolicyChangeNotification and LsaUnregisterPolicyChangeNotification 2018-08-04 22:17:52 +02:00
Timo Kreuzer 0f8439aa71 [DLLS] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Timo Kreuzer e59d7a5687 [APPHELP] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Timo Kreuzer 52ea7d39db [SHELL32] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Timo Kreuzer 4f0a158a2f [KERNEL32] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Julio Carchi d7559e2354 [TRANSLATIONS] Fix spanish translations for some resources (#725) 
Setup wizard
Network settings wizard
Input CPL
Open file dialogs
Devmgr
Explorer
 2018-08-03 15:08:13 +02:00
Bișoc George dd4cc2c2ff [INPUT] Fix a truncated text 2018-08-03 12:08:41 +02:00
Stanislav Motylkov d956eafda8
[KERNEL32] Implement System Firmware functions 
- Implement EnumSystemFirmwareTables
- Implement GetSystemFirmwareTable

These functions currently using registry workaround and can be improved later.

CORE-12105
 2018-08-02 21:15:28 +02:00
Jared Smudde 4ceea74919 [USRMGR] Disable the Extra tab. It serves no purpose. (#700) 2018-08-01 22:15:27 +02:00
Julio Carchi d3045af9d5 [TRANSLATIONS] Fix some Spanish translations (#715) 
Also added some new ones.
 2018-07-31 10:58:21 +02:00
Eric Kohl bf1e655172 [ADVAPI32] Stop the service dispatcher thread only if a SERVICE_CONTROL_STOP command was sent 2018-07-29 23:40:36 +02:00
Hermès Bélusca-Maïto 74adcadbd0
[SHELL32] Silence a noisy DPRINT. 2018-07-29 17:39:09 +02:00
Eric Kohl 24cd7bbe0b [RPCRT4] Update the support for remote pipes which was dropped by the sync to Wine Staging 2.9 and update rpcrt4_ros.diff accordingly 2018-07-29 07:30:43 +02:00
Baruch Rutman 65a5a989c5
[LPK] Changes (#622). 
- Changed how the ScriptIsComplex check is made to account direction, most noticeble on dxdiag,
  https://docs.microsoft.com/en-us/windows/desktop/api/usp10/nf-usp10-scriptiscomplex
  However commented out the ScriptIsComplex flag change because of a bug.

- Added a check and debug print if BIDI_Reorder fails.
 2018-07-27 00:47:48 +02:00
Baruch Rutman e054a053ff
[LPK] Added more error handling code (#622). 
- Added a codepath if both glyphs and reordered_str arrays are NULL.
- Move variables back to the beginning of function.

CORE-14732
 2018-07-27 00:47:28 +02:00
Baruch Rutman 7fe6a14ede
[LPK] Diverse fixes (#622). 
- Changed wcspy to strsafe function.
- Use GetCharWidthI instead of GetCharWidth32W if dealing with glyph indices.
 2018-07-27 00:47:14 +02:00
Baruch Rutman 33d3e56cf4
[LPK] Refactoring (#622). 
- Moved lpDx and lpGlyphs operations to seperate brackets.
- lpGlyphs == NULL checks + memory managment additions.

CORE-14732
 2018-07-27 00:46:02 +02:00
Hermès Bélusca-Maïto 2158f31b71
[KERNEL32] Use RtlStringCbCopyNW() to correctly fill the WIN32_FIND_DATA.cFileName and cAlternateFileName members without any overflow and with a terminating NULL character. 2018-07-22 21:32:38 +02:00
Mark Jansen 9c48edb58c
[LDR] Release the loader lock the same way it was acquired 2018-07-22 17:17:36 +02:00
Serge Gautherie 246005c625 [WINDOWSCODECS] Fix an MSVC warning about get_decoder_info() (#684) 
"...\info.c(2163) : warning C4028: formal parameter 1 different from declaration"

Cherry-pick 90518ebd2c
CORE-7538
 2018-07-14 02:50:23 +02:00
Katayama Hirofumi MZ 75b09f3f88 [EXPLORER][SHELL32][USER32] Implement 'Show the Desktop' action of Task Bar (#668) 
The keyboard shortcuts Win+D and Win+M are also enabled.

- Implement IShellDispatch4::ToggleDesktop().
- Implement some commands in CTrayWindow.
- Add "sdk/include/reactos/traycmd.h" for tray commands.
- Fix task window switching.
- Improve the user32!SwitchToThisWindow() function and use it.

CORE-14318, CORE-13157
See also: CORE-14806 and CORE-8723
 2018-07-13 10:34:42 +02:00
Julio Carchi 5943bbb8b4 [TRANSLATIONS][DISPLAY] Translate to spanish some strings on the display (#667) 
CORE-14767
 2018-07-12 17:48:57 +02:00
Katayama Hirofumi MZ e018ccea4b [SHELL32] lpDirectory must have priority in ShellExecuteEx (#681) 
Based on a patch by Mark Jansen.
CORE-14469
 2018-07-12 17:45:43 +02:00
Katayama Hirofumi MZ 55469633cf [SHELL32] Add 'Properties' menu item in My Computer (#647) 
- Add a Shell_DefaultContextMenuCallBack() helper function.
- Implement the IContextMenuCB interface in CDrivesFolder.
CORE-12509
 2018-07-08 17:01:12 +02:00
Katayama Hirofumi MZ 96c0ef4209 [SHELL32] Improve CShellLink a little (#651) 
Improve the display and UI in the shortcut dialog.
CORE-11407
 2018-07-08 16:45:40 +02:00
Katayama Hirofumi MZ 33a65d45aa [APPWIZ] Add support for creating internet shortcuts (#664) 
CORE-8737
 2018-07-08 16:40:14 +02:00
Katayama Hirofumi MZ a882ec7a02 [SHELL32][EXPLORER] Update system-wide environment variables (#663) 
- Implement shell32 RegenerateUserEnvironment() function and use it.
- CShellBrowser and CDesktopBrowser implements WM_SETTINGCHANGE actions.

CORE-1459, CORE-14397
 2018-07-08 16:32:42 +02:00
Hermès Bélusca-Maïto c7022c1b0c
[KERNEL32] Use NULL for pointers. 2018-07-07 18:58:03 +02:00
Mark Jansen 3904fd6257
[SHELL32] Ensure OpenAs_RunDLL does not loop to infinity and beyond. 
This should fix a timeout on the apitests.
 2018-07-06 21:51:24 +02:00
Eric Kohl aad801914b [LICCPA] Fix translation and align dialog controls 2018-07-01 17:28:29 +02:00
Eric Kohl 2fdb4d99c7 [LICCPA] Make the License Manager GUI build and make it visible (again) 
- Add the missing CMakeLists.txt file.
- Comment-out an unused variable.
- Make WM_INITDIALOG return TRUE, so that the dialog gets visible.
 2018-07-01 17:28:28 +02:00
Timo Kreuzer e39876dab7 [SDK] Fix 64 bit issues 2018-07-01 14:45:21 +02:00
Hermès Bélusca-Maïto b7c4c4dc79
[COMDLG32] Add the missing NEWFILEOPENV2ORD dialog resource, whose absence made all of the Open/Save-file dialogs not displaying anymore. 
This was a regression from last Wine (Staging) 3.9 sync (f68b0c51) that
introduced the usage of this new dialog.
To do: Properly generate the dialog localization.

CORE-14656, CORE-14674, CORE-14689, CORE-14769
 2018-07-01 00:44:48 +02:00
Hermès Bélusca-Maïto 2afb483a9e
[SHELL32] Shell Profile Folders fixes. 
- Fix a regression introduced in r65415 (1795a3bf) where the directory
  paths stored in "Windows\CurrentVersion\Explorer\User Shell Folders"
  were stored in expanded format instead of in unexpanded format:
  _SHGetDefaultValue() *MUST* return unexpanded paths by design!!

- Augment _SHExpandEnvironmentStrings() and _SHGetUserShellFolderPath()
  to take a user token handle to be able to correctly resolve/expand
  user-specific directory paths.

- Fix _SHExpandEnvironmentStrings() so that it always retrieve the
  correct current user / all-users directory paths by calling userenv
  functions, instead of hardcoding a broken logic. As a result this
  removes the "C:\Documents and Settings\SYSTEM" ghost directory we got
  during ReactOS installation.

- Delimit the changes with respect to Wine by #if(n)def __REACTOS__ .
 2018-06-30 18:20:08 +02:00
Stanislav Motylkov 73aa420f0e [SHELL32] Update russian translation 
CORE-11407
 2018-06-30 01:15:41 +02:00
Stanislav Motylkov 707f2ed360 [SHELL32] Fix some elements positions and styles 
Addendum to eb1912b. CORE-11407
 2018-06-30 01:15:41 +02:00
Mark Jansen a731be3f12
[DEVENUM] Initialize rgpins. 2018-06-29 22:28:57 +02:00
Katayama Hirofumi MZ e353b48cb2 [SHELL32] Refresh 'General' tab if the folder icon is updated (#646) 
CORE-11407
 2018-06-29 14:13:37 +02:00
Katayama Hirofumi MZ eb1912b15f [SHELL32] Initial implementation of Folder Customization (#642) 
- Add property sheet;
- Implement changing the folder icon.
CORE-11407
 2018-06-28 21:51:37 +02:00
Serge Gautherie 3766d836c7 [DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() (#643) 
- Fixes MSVC errors: "...\dll\win32\dbghelp\minidump.c(857) : error C4028: formal parameter 5 different from declaration", for parameters 5, 6 and 7.
- Fix spec file too.
CORE-7538
 2018-06-28 17:44:49 +02:00
Hermès Bélusca-Maïto a9eda8f492
[LSASRV] Enable SE_CREATE_TOKEN_PRIVILEGE in LSASS since one of our purposes is to create access tokens -- NtCreateToken() requires this privilege. 2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto c901c3d37f
[LSASRV] Move the LSA_RPC_SERVER_ACTIVE event creation to a better place, in LsarStartRpcServer(). 2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto 0208a4d196
[LSASRV] Add the SE_GROUP_OWNER attributes to the token owner. 2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto cf56db2eb3
[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status fixup in the assignment loop as done in the allocation loop. 
This avoids this function returning failure while everything actually succeeded.
 2018-06-27 23:40:13 +02:00
Hermès Bélusca-Maïto 62384951c8
[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid pointer to a valid but empty privilege structure to NtCreateToken(), as it always want a non-NULL pointer. 2018-06-27 23:40:12 +02:00
Hermès Bélusca-Maïto d4b4da5385
[ADVAPI32] Additions for CreateProcessAsUserA/W(). 
- Use a common helper function used by both the ANSI and UNICODE functions
  so that the large code block that deals with setting the new process token
  becomes automatically common to both these functions, while the ANSI vs.
  UNICODE conversions are handled directly via the CreateProcessA/W() calls.

- Duplicate the token and acquire the process primary token assignment
  privilege before calling NtSetInformationProcess().
 2018-06-27 23:40:07 +02:00
Katayama Hirofumi MZ 3189ec9428 [SHELL32] Add missing desktop.ini files (#640) 
Add the "desktop.ini" files to the special folders to realize their custom icons.
CORE-10045
 2018-06-27 23:11:31 +02:00
Katayama Hirofumi MZ c74bd5d662 [SHELL32] Enable custom CD/DVD icons (#639) 
Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766
 2018-06-27 23:06:54 +02:00
Bișoc George 23881cfcf3 [NEWDEV] Fix a truncated text 2018-06-25 13:55:19 +02:00
Russell Johnson 6a683dc6d8 [SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() (#635) 
Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.

CORE-12340
 2018-06-24 20:29:57 +02:00
Katayama Hirofumi MZ 1b1e1baa6e [SHELL32] Implement Folder Options File Types 'Change' button (#629) 
CORE-12906
 2018-06-24 20:04:25 +02:00
Katayama Hirofumi MZ 6e6c46a832 [BROWSEUI] Re-enable the "Folder Options" menu item (#630) 
It was originally disabled in r71192 (8b77c254).
CORE-11141
 2018-06-24 20:02:36 +02:00
Katayama Hirofumi MZ 1829f5fed7 [SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632) 
#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196
 2018-06-24 19:59:03 +02:00
Katayama Hirofumi MZ cc8b2717ae [SHELL32] Implement OpenAs_RunDLLA/W (#628) 
CORE-14751
 2018-06-24 19:46:06 +02:00
Abdulganiev Rafael 824a52aa99 [TRANSLATION][SHELL32] Update Russian translation (#633) 2018-06-24 19:42:34 +02:00
Katayama Hirofumi MZ a33908b60f [SHELL32] Improve French Folder Options 2018-06-23 10:51:48 +02:00
Katayama Hirofumi MZ 6f82659da6 [SHLWAPI][APITESTS] Add test for PathUnExpandEnvStringsForUser (#602) 
ROSTESTS-308
 2018-06-22 16:44:58 +02:00
Katayama Hirofumi MZ cb69443362 [SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604) 
CORE-14678
 2018-06-22 16:40:06 +02:00
Katayama Hirofumi MZ f8926dccbd [SHELL32] Fix desktop.ini folder icon (#595) 
The folder icon location specified in desktop.ini of a folder should accept its relative path.
CORE-9196
 2018-06-22 15:37:03 +02:00
Andrea Crescentini d303b70b7a [TRANSLATION] Improving italian translation (#623) 
- Improved Italian translation for USETUP, WELCOME, REACTOS, EXPLORER.
- Completed translation in SYSSETUP.
- Correct some characters encoding and text alignment in USETUP.
 2018-06-21 14:03:35 +02:00
Denis Malikov 7916d0ae3e [SHELL32] Copy-paste files/folders into current place. 
Files are copied with trying to find new path by adding (%d) suffix before asking for overwrite existing item

CORE-13788
 2018-06-13 20:13:44 +02:00
Serge Gautherie 1668527acf
[SYSSETUP] Fix a DPH report about dwPageCount 
- "(sdk/lib/rtl/heappage.c:1329) corrupted suffix pattern"
  detected at
  "dll/win32/syssetup/wizard.c:2672 (InstallWizard)"
- Add an ASSERT(), as hinted by Mark Jansen.
 2018-06-12 23:57:12 +02:00
Adam Słaboń 565ce5e827 [TRANSLATION] Polish translation update (#611) 
Polish translation update for MODE, USETUP and SHELL32.
 2018-06-12 15:51:37 +02:00
Thomas Faber 95c3e17a80
[ADVAPI32] Fix crash when running advapi32:security with DPH. 
Import the following Wine commits:
* 79636bebbfa Michael Müller: advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
* 1d03ba76116 Hans Leidekker: advapi32: Fix parsing empty DACL/SACL security descriptor strings.
* 5bc2e83c7ab Hans Leidekker: advapi32: Fix size returned from ConvertStringSecurityDescriptorToSecurityDescriptor on 64-bit.
 2018-06-10 19:05:26 +02:00
Katayama Hirofumi MZ 698cbc6184 [SHELL32] Split dialogs/folder_options.cpp (#582) 
The dialogs/folder_options.cpp source file in shell32 is too big to manage. We will split it to smaller files.
CORE-12906
 2018-06-06 14:04:50 +02:00
Serge Gautherie 2ca29e142c [BROWSEUI] Remove a duplicated add_custom_command() call 2018-06-05 20:03:16 +02:00