Format-strings, but no args.
Those were fixed during 0.4.15-dev'ing on master.
Just touched this branch, because I want to update some
older branches and wanted to take that with me as well.
Switches from "FreeMono" and "Dejavu Sans Mono" to "Courier New" and "Lucida Console"
and therefore brings us closer to 2k3sp2 stock fonts. Saves some RAM also.
Deletes some "Ubuntu" font left-overs in some Themes.
CORE-18605 (and partially CORE-16264)
By porting back the following commits:
0.4.15-dev-5362-g c47758b102 [SETUP][INF][MEDIA] Get rid of the last Ubuntu references CORE-18607 (#4871)
0.4.15-dev-5336-g bd40c13f6f [SETUP][BOOTDATA][FONTS][INF] Delete DejaVu Sans Mono and re-map (#4856)
0.4.15-dev-5335-g a4193ade03 [SETUP][FONTS][INF][GDI32_APITEST] Delete FreeMono and re-map (#4852)
0.4.15-dev-5324-g d035452148 [SETUP][INF][ROSTESTS] Delete font substitutions and tests for "DejaVu Sans" (#4829)
WS_EX_NOACTIVATE flag forbids the window to be activated
fix picked from 0.4.15-dev-5137-g 826bd41d88 (1 of 3 commits for CORE-18417)
My reason for picking it is that it fixes CORE-13257 'Reboot leaving Evernote 5.9.8 in tray causes WIN32K BSOD 0x50'
I also had to pick together with it the
0.4.15-dev-5491-g 1fbed1710e to prevent it from introducing (+2 failures in user32:msg_focus) unittests.
----------------
The above patch allows/encourages us to pick then also:
0.4.15-dev-5492-g 47f3a4e144 [OSK] Delete WS_EX_NOACTIVATE workaround code
(which referenced CORE-18528, but is not fixing this minor GUI glitch yet, it just removes workaround-code that is no longer needed,
I just mention the ticket here, because the commit on master did that as well)
----------------
----------------
The following 2 things were small *unrelated* improvements nearby, and I decided to take them with me:
0.4.15-dev-4323-g 9f5cde9cbe [WIN32K:NTUSER] window.c Remove broken assert in NtUserCreateWindowEx. CORE-18123 fixed
and
a tiny part of 0.4.15-dev-3476-g 55a1c29341 [WIN32K] appswitch.c: delete unused func DWORD wtodw(const WCHAR *psz)
ports back some minor tweaks, mostly in translations:
0.4.14-dev-1409-g 951e5f2851 CORE-12477 part3
0.4.14-dev-1408-g f03c4c4378 CORE-12477 part2
0.4.14-dev-1405-g dcc6dcb0bd CORE-12477 part1
- Less text truncation for all languages
- Manually Tweaked fr-FR the most, see CORE-12477
- Manually Tweaked de-DE enlarged a buttons size
- For All Languages harmonized the maximized available space for dynamic strings in 2nd tab right side from 100->120
This fixes tons of font rendering issues for many localizations, brings the set
of fonts closer to the 2k3sp2 stock fonts, and adapts some font substitutions.
Best of all is that it shrinks the iso size by ~13MB on average and stabilizes ros by
consuming significantly less memory.
Especially releases/0.4.13 suffered from having all the new replacement fonts added already,
without having had removed the old replaced ones already, and therefore was the most
"bloated" release up to now. It basically had most fonts twice.
It is a squashed backport of the following commits:
0.4.15-dev-5287-g 4615c824db [SETUP][INF] Delete obsolete font substitutions "DejaVu Serif" (#4827)
0.4.14-dev-1515-g 30fae1a2df [MEDIA][FONTS] Fix French glyphs of Tahoma font CORE-16899 (#2607)
0.4.14-dev-586-g 9525593660 [MEDIA][FONTS] Improve tahomabd.ttf (Latin) No.35 CORE-8408
0.4.14-dev-584-g 94f92b0b2e [MEDIA][FONTS] Improve tahomabd.ttf (Latin) No.34 CORE-8408
0.4.14-dev-469-g 0b938a35bd [MEDIA][FONTS] Improve tahomabd.ttf (Latin and Punctuation) No.33 CORE-8408
0.4.14-dev-467-g c3da027012 [MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.32 CORE-8408
0.4.14-dev-462-g 591b2b807c [MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.31 CORE-8408
0.4.14-dev-456-g d8187d33be [MEDIA][FONTS] Improve tahomabd.ttf (Punctuations) No.30 CORE-8408
0.4.14-dev-430-g f41366daad [MEDIA][FONTS] Improve tahoma.ttf (Punctuations) No.29 CORE-8408
0.4.14-dev-426-g 55251a0a8e [MEDIA][FONTS] Improve tahomabd.ttf (Latin, Greek and Cyrillic) No.28 CORE-8408
0.4.14-dev-400-g b7076dc2bc [MEDIA][FONTS] Improve tahoma.ttf (Latin) No.27 CORE-8408
0.4.14-dev-397-g 551b101720 [MEDIA][FONTS] Improve tahomabd.ttf (Latin) No.26 CORE-8408
0.4.14-dev-396-g 8cbcb172f6 [MEDIA][FONTS] Improve tahoma.ttf (Latin and Cyrillic) No.25 CORE-8408
0.4.14-dev-395-g 65cbadf2d6 [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic, Greek and Latin) No.24 CORE-8408
0.4.14-dev-391-g 454ea3d85b [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin and Greek) No.23 CORE-8408
0.4.14-dev-389-g 9ef61bb887 [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin and Greek) No.22 CORE-8408
0.4.14-dev-385-g 6f2662688b [MEDIA][FONTS] Improve UniVGA16.ttf (VGA) font CORE-8408
0.4.14-dev-378-g 871d322f92 [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic and Latin) No.21 CORE-8408
0.4.14-dev-377-g 21f4e69ee8 [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.20 CORE-8408
0.4.14-dev-374-g e4de098127 [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.19 CORE-8408
0.4.14-dev-370-g dda8185297 [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic and Latin) No.18 CORE-8408
0.4.14-dev-367-g 36163a235b [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.17 CORE-8408
0.4.14-dev-357-g 203a6babdf [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.16 CORE-8408
0.4.14-dev-356-g 7d7f134f94 [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic and Latin) No.15 CORE-8408
0.4.14-dev-339-g 54c8cc66ab [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic) No.14 CORE-8408
0.4.14-dev-338-g 9f803ab091 [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.13 CORE-8408
0.4.14-dev-333-g 67c78d88c8 [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.12 CORE-8408
0.4.14-dev-330-g 15748cf03a [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic) No.11 CORE-8408
0.4.14-dev-329-g 463a3f8c06 [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic) No.10
0.4.14-dev-328-g c58eced19b [MEDIA][FONTS] Improve Cyrillic glyphs of tahoma.ttf a bit
0.4.14-dev-327-g ff715073ca [MEDIA][FONTS] More improve Cyrillic glyphs of tahomabd.ttf
0.4.14-dev-325-g 6b1ca2895b [MEDIA][FONTS] Improve Cyrillic glyphs of tahomabd.ttf
0.4.14-dev-324-g ff77ddff5e [MEDIA][FONTS] Improve Cylliric glyphs of tahoma.ttf more
0.4.14-dev-323-g 6fe6a88b04 [MEDIA][FONTS] Improve Cyrillic bitmap glyphs of tahoma.ttf
0.4.14-dev-231-g 2627b52d95 [MEDIA][FONTS] Improve Tahoma font (tahoma.ttf) for Hungarian (#2018) CORE-16480
0.4.14-dev-20-g 2f4fb903b4 (partially) [MEDIA][FONTS] Delete many fonts CORE-16407 (#1955)
This avoids spamming "Syntax Errors" to the cmd-prompt when starting the VS2010 command prompt.
Or when typing something like "@Rem Hello" at the prompt.
Fix picked from 0.4.15-dev-202-g 9c11be5a3a
Chinese manually groomed similar to the
western '\n.'->'.\n' fixes (Chinese does not match our regular pattern matches).
fix is a partial (intentionally non-squashed) pick of 0.4.14-dev-1142-g 92aabb07fb (#2393)
Phew, these are the last ones for this branch!
Now reduced by the preceding commits to a manageable amount.
fix is a partial (intentionally non-squashed) pick of 0.4.14-dev-1142-g 92aabb07fb (#2393)
Yes, I do see the 'conti\n\n\n\n\n\n\nnue'-mess within dll/win32/rasdlg/lang/en-US.rc
Will be taken care of later.
fix is a partial (intentionally non-squashed) pick of 0.4.14-dev-1142-g 92aabb07fb (#2393)
Yes, I do see that we still have some '\n.' typos in some files, e.g.
base/applications/shutdown/it-IT.rc. I will take care of them later!
fix is a partial (intentionally non-squashed) pick of 0.4.14-dev-1142-g 92aabb07fb (#2393)
Yes, I double-checked the msi_en.rc, and we do only use the \t after the \n (without additional spaces).
It is a good harmonization therefore to reduce the indentation level here.
Since more than 10 years we do ship two binaries for the very same purpose in our isos:
msconfig and msconfig_new.
msconfig_new was an attempt to refactor the old tool, but it got stuck rather soon
and is bloating our isos since then, and consuming build-time.
My testing shows that the older version is superior in many ways
compared to that refactoring attempt: see CORE-18067 for examples of some bugs.
Personally I think focusing on the older tool exclusively would make more sense
than trying to improve that refactoring proposal.
But since one never knows what the future might bring and I did not want to step on anyones toes,
I decided to just disable the build and iso-integration of the unfinished one meanwhile,
instead of dumping it entirely. Although my feeling is that after 10years of waiting
it's not worth waiting another 10 years with that.
Fix picked from:
0.4.15-dev-3882-g e6de6098fb
ports back the fixes of:
0.4.15-dev-3886-g c791d4ee4e CORE-18075
0.4.14-dev-1325-g 1fdf06c563 CORE-16792
0.4.14-dev-1324-g 75edf1071a CORE-16792
0.4.14-dev-1323-g d079342e0a CORE-16792
0.4.14-dev-1322-g 7ed0701983 CORE-16791
While respecting the individual requirements of ancient branches,
e.g. when stuff was put somewhere else like the recovery console.
Or when we did not use code7bit yet (we started that with 0.4.12).
by picking the following commits:
0.4.15-dev-413-g ed7196d964 [TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific
0.4.15-dev-2488-g fd4d8f550c [TASKMGR] id-ID.rc, just the single line in this module
[USER32] GetQueueStatus() should not return 0 when passing QS_ALLINPUT flag that includes QS_RAWINPUT (#4115)
GTK applications call GetQueueStatus(QS_ALLINPUT), where QS_ALLINPUT
specifies the QS_RAWINPUT flag as well, when these are compiled for
Windows XP+, and they expect the call to succeed on this platform.
On one side, ReactOS does not currently support this flag at all, but
since it claims to be XP/2003-compatible, applications may implicitly
expect the flag to be supported by GetQueueStatus() and the function
*NOT* failing when this flag is set.
(Later GTK apps don't care and just call GetQueueStatus(QS_ALLINPUT)
that includes QS_RAWINPUT, and therefore would fail as well on e.g.
Windows 2000...)
Otherwise, an observable effect is that some versions of libgdk-win32-2.0.0.dll
enter into an infinite loop when calling GetQueueStatus(QS_ALLINPUT),
since this call always failed on ReactOS.
On the other side, however, we should honour our winetests that handle
the presence of the QS_RAWINPUT flag and behave differently accordingly.
But since we do not support QS_RAWINPUT yet, we should keep their old
behaviour where QS_RAWINPUT is unused.
Thus, in order to accomodate both sides, we don't fail the GetQueueStatus()
call, but just set the ERROR_INVALID_FLAGS last error and continue it.
This fixes:
'All user32:TrackMouseEvent tests'
CORE-15686: Gimp 2.8.22 from rapps hangs after startup with 90%-100% CPU usage
and many dupes of that ticket like:
CORE-17551: Ardour hangs at the first start (GTK2 issue)
CORE-15151: newer "Inkscape 0.92.3" is unusable due to WIN32SS message queue lockup
CORE-14086: RawTherapee 5.0-r1-gtk2 fails to start (using 100% CPU)
CORE-11850: Geany 1.28 hangs with endless MsqSendMessage timed out
CORE-8475: Wireshark hangs after launch
It will also slightly appease, but not entirely fix:
CORE-8217: 3D Text ScreenSaver freezes system
Fix picked from 0.4.15-dev-3407-g 9c4397afdf
---------------------
[NTUSER] Do not remove message from the Msg Queue if it is not for us. (#4129)
CORE-8217 This part of the fix keeps the buttons working (Cancel/Ok/top-Right-X) even under high CPU-load
Patch from 'I_Kill_Bugs' contributor.
Fix picked from 0.4.15-dev-3499-g 7d1b50394b
---------------------
[3DTEXT] Fix 3dtext.scr using near 100% CPU (#4125) CORE-17866, CORE-8217
Fix picked from 0.4.15-dev-3443-g 5c9fdcb1de
We did strip that superfluous "Operating system"
during 0.4.15-dev'ing to prevent line-overflow when
we added the target platform to the version string.
picked from 0.4.15-dev-1605-g ab45955a5a
Recently I found out that the git hashes will also become
longer when there is hash collision. So the shortening adds to
safety also for the old branches.
While touching those RCs do also pick:
0.4.15-dev-2336-g d3fc345730 [CMD] de-DE: Fix 'Paramater' typo
0.4.14-dev-1446-g cd5364ae8e [CMD] pl-PL.rc the line Wersja
and some EOL-whitespace stripping and the parts targetting [CMD]-only! from
0.4.14-dev-1037-g 554c41e4d7 [CMD] " \n"->"\n"
0.4.14-dev-1142-g 92aabb07fb [CMD] " \n"->"\n"
As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
Several fixes ported back:
0.4.15-dev-3726-g c262020016 README CORE-18018
0.4.15-dev-3724-g 3a7c0d82d2 size fallback part 1 CORE-18018
0.4.15-dev-3569-g b5a6357d93 available.h/.cpp Strip 3 useless functions
0.4.15-dev-384-g 393a2c42fe CDPath in README
0.4.15-dev-227-g a6084d7440 ShellAbout() (#2751)
and some whitespace corrections, especially in cabinet.cpp
My main motivation was a fix for the bug
CORE-17815 'Fix incorrect opaque text rendering' (#2760)
which was unhidden by 0.4.12-dev-824-g d57f7becc3 .
That specific and most important fix
was picked from 0.4.15-dev-190-g d839e3d9b4
We left out the additional WIN32SS-hardening in this context in the backport to older
releases for now.
Then I looked further in sndrec32 and compared each file of that module on master
head with both: current 0.4.14RC and also current 0.4.7rls and found the rare
situation that I liked each and every change within since 2017.
Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup,
and (for older releases than 0.4.14RC) it will also bring some x64-improvements.
So I decided to take everything from current master head except the changes in CMakeLists.txt
because that subset is applicable and a win for all ros releases down to 0.4.7.
LOAD_LIBRARY_AS_IMAGE_RESOURCE and LOAD_LIBRARY_SEARCH_SYSTEM32 are Vista+
This fixes some blurry icons in systray when 2k3sp2 kernel32.dll is used in ros CORE-12004
That part in user32 was a regression of SVN r71609 == git a44dfe6c76
While we are at it we do fix some other modules as well, that used those NT6+flags.
The fix was picked from 0.4.15-dev-788-g a04831677e
CORE-16742 'Start button background in themes is scaled incorrectly' (especially MS Luna)
The problem once was unhidden by
0.4.7-dev-705-g 85ae842105
Fix picked from 0.4.15-dev-3441-g 67ad4e7f60
This prevents the tracking menu from erroneously closing itself right after it was opened in some cases.
Fixes CORE-17338 which got unhidden by 0.4.15-dev-1126-g 58b0558f94
And fixes CORE-15760 which got unhidden by SVN r74972 == git 19dd22d422
Since both symptoms look very similar but the unhiding revisions did differ,
that could mean we do have some kind of race condition here.
I guess this fix is more like a workaround.
2 Fixes picked:
0.4.15-dev-3313-g 6417b2323d [NTUSER][USER32] Workaround tracking menu on CORE-17338 CORE-15760 (#4048)
to prevent the menu from auto-closing
and
0.4.15-dev-3297-g 037c744eb1 [EXPLORER] Send WM_POPUPSYSTEMMENU asynchronously CORE-16353 (#4047)
to make the taskbar button turn into pressed state when the menu opens
Within the current ShowTcpTable function logic, tcpTable would be freed twice.
The bug was introduced in 0.4.13-dev-579-g b695971c7f
Remove the second tcpTable free and fix coverity #1477187.
fix picked from 0.4.15-dev-3338-g 0e75fc9240
* CORE-5823 Fix icons for toolbar and formatbar in Wordpad.
which regressed by SVN r47776 == git 5dbfbb5201
* Add wordpad_ros.diff noting toolbar.bmp and formatbar.bmp are not wine-synced
Thanks to the patches author Doug Lyons.
Fix picked from 0.4.15-dev-2862-g e068c68452
Display the shutdown message popup dialog on the current input desktop,
and periodically monitor for any change of the input desktop. When the
latter changes, close the dialog and recreate it on the new input desktop.
In addition, retain the current dialog position and restore it when the
dialog is recreated on the new desktop.
A patch authored by HBelusca.
The regression was introduced by 0.4.10-dev-579-g
c697f191cf
This commit is merging back the changes of 0.4.15-dev-1096-g
0ff9b0ff7e
(the minimized patch from JIRA avoiding most surrounding style changes)
It regressed by 0.4.12-dev-1064-g 09c4d0a74b
when we tried to mute compiler warnings in the GCC Release configuration
for all modules, that do contain .y files.
In master we switched to use flex+bison to process those files at build-time
in 0.4.15-dev-2277-g 28dadda8be and at the same
time reverted the guilty rev.
In the backport to the old releases we do only revert, but do not introduce
flex+bison. This will reintroduce the warnings in GCC Release configuration.
CORE-17312
Hide everything under the same foreground & background colors, so that
the actual color and text blanking reset does not create a visual "blinking".
Then, blank the text and finally reset the actual foreground &
background colors.
We do this because we cannot do the screen scrolling trick that would
allow to change both the text and the colors at the same time (the
function is currently not available in our console "emulation" layer).
The issue was unhidden when we introduced the red progress bar in
0.4.11-dev-111-g e5c0bfacf1
Fix picked from 0.4.15-dev-1078-g 434fa562ce
CORE-16103 "Network adapters sporadically fail to install with Code31 CM_PROB_FAILED_ADD"
This first and foremost reverts the guilty rev 0.4.12-dev-72-g 043a98ddd9
by porting back the fix 0.4.15-dev-1074-g ffc96d26ec
------------
Dedicated to the hard work of Joachim Henze! xD
This reverts part of commit 043a98dd (see also commit b2aeafca).
Contrary to what I assumed in commit 043a98dd (and was also assumed in
the older commit b2aeafca), we cannot use the singled-linked lists to
queue and dequeue the PnP device-install events, because:
- the events must be treated from the oldest to the newest ones, for
consistency, otherwise this creates problems, as shown by e.g. CORE-16103;
- the system singled-linked lists only offer access to the top of the
list (like a stack) instead of to both the top and the bottom of the
list, as would be required for a queue. Using the SLISTs would mean
that only the newest-received events would be treated first, while the
oldest (which were the first received) events would be treated last,
and this is wrong.
Therefore one must use e.g. the standard doubly-linked list. Also, using
locked operations (insertion & removal) on the list of device-install
events is necessary, because these operations are done concurrently by
two different threads: PnpEventThread() and DeviceInstallThread().
Since the interlocked linked list functions are not available in user-mode,
we need to use instead locking access through e.g. a mutex.
"Let's encrypt" certificate issuer string changed within last 24hours remotely.
Update its name to make RAPPS stop complaining on DB update.
And also fix a bug in rapps mixing A()/W() in the
messagebox that informs about that cert check failure.
Fix is port of
0.4.15-dev-1120-g 12caaece25
0.4.15-dev-1617-g f77f5a30cf
Next time this happens I will relentlessly undefine CMakeLists.txt USE_CERT_PINNING
Missed a file. See CORE-14439.
cherry picked from commit 0.4.14-dev-1210-g
78098f99e0
[0.4.13][EXPLORER|SHELL3232] Fix CORE-14439 part 1 of 2
Prevent ros from halting when Miranda IM 0.10.21 snap-to-border-feature is used.
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
cherry picked from commit 0.4.14-dev-1209-g
10d1afea18
since support for secure screensaver desktop is not
completely implemented in Winlogon.
This fixes a regression introduced between
0.4.10-dev-579-gc697f19 and 0.4.10-dev-582-g3270979
fix cherry picked from commit 0.4.14-dev-581-g
40db385716
To fix regression CORE-16467 which was caused
by adding encoding-heuristic in 0.4.13-dev-927-g
e85664a3d8
fix cherry picked from commit 0.4.14-dev-184-g
142d16c8a0
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in LiveCD
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaa
Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
Similar commit for bootcd CORE-16252
went into 0.4.13-dev-740-g
8b67edd8fa