Commit graph

1280 commits

Author SHA1 Message Date
Joachim Henze
e10d31f6a2 [0.4.14][WORDPAD] Fix icons for toolbar and formatbar (#3792) CORE-5823
* CORE-5823 Fix icons for toolbar and formatbar in Wordpad.
which regressed by SVN r47776 == git 5dbfbb5201

* Add wordpad_ros.diff noting toolbar.bmp and formatbar.bmp are not wine-synced

Thanks to the patches author Doug Lyons.

Fix picked from 0.4.15-dev-2862-g e068c68452
2021-07-04 14:44:14 +02:00
Joachim Henze
6ff325e77a [0.4.14][RAPPS] Reduce the chance assert failed CORE-17649
This assertion happened whenever we canceled a download and
was unhidden by 0.4.14-dev-1305-g bcd301d136

Fix picked from 0.4.15-dev-716-g c5e111427c
2021-07-03 15:26:49 +02:00
Joachim Henze
33f4311f6c [0.4.14][PROGMAN][CRT][USER32] Do not use LoadLibraryEx() NT6+ flags (#3152) CORE-12004
This fixes some blurry icons in systray when 2k3sp2 kernel32.dll is used in ros CORE-12004
That part in user32 was a regression of SVN r71609 == git a44dfe6c76
While we are at it we do fix some other modules as well, that used those NT6+flags.

The fix was picked from 0.4.15-dev-788-g a04831677e
2021-07-02 19:15:10 +02:00
Joachim Henze
de93f488fa [0.4.14][USETUP] Fix letter encoding in translation. (#3619)
Addendum to CORE-16792
The fix is part (but not all) of CORE-17545 Fixing several Clang warnings.

Fix Clang warning:

base/setup/usetup/lang/de-DE.h:1099:24: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
        "die Partition <E4>ndern, die derzeit als aktiv markiert ist.",
                       ^~~~
It regressed by 0.4.14-dev-1323-g d079342e0a

picked from 0.4.15-dev-2489-g 33c210da37

With that backport we have no affected releases left.
2021-06-20 23:39:25 +02:00
Joachim Henze
366c46b4fa [0.4.14] Fix VSSolution's msbuild CORE-15991
It regressed by 0.4.12-dev-1064-g 09c4d0a74b
when we tried to mute compiler warnings in the GCC Release configuration
for all modules, that do contain .y files.

In master we switched to use flex+bison to process those files at build-time
in 0.4.15-dev-2277-g 28dadda8be and at the same
time reverted the guilty rev.

In the backport to the old releases we do only revert, but do not introduce
flex+bison. This will reintroduce the warnings in GCC Release configuration.
2021-05-25 23:06:44 +02:00
Joachim Henze
ad8521d023 [0.4.14][RAPPS] "Let's encrypt" Certificate-Issuer-Update hamster-wheel
"Let's encrypt" certificate issuer string changed within last 24hours remotely.
Update its name to make RAPPS stop complaining on DB update.

And also fix a bug in rapps mixing A()/W() in the
messagebox that informs about that cert check failure.

Fix is port of
0.4.15-dev-1120-g 12caaece25
0.4.15-dev-1617-g f77f5a30cf

Next time this happens I will relentlessly undefine CMakeLists.txt USE_CERT_PINNING
2021-01-11 21:14:34 +01:00
Joachim Henze
e6a5af4315 [0.4.14][CMD] Quick fix for the REM command parser. CORE-17030
This avoids spamming Syntax Errors when starting the VS2010 command prompt.

Fix picked from 0.4.15-dev-202-g 9c11be5a3a
2021-01-04 21:43:50 +01:00
Joachim Henze
263c5f0a2e [0.4.14][USETUP] Do a trick to avoid visual "blinking" during screen clearing. (#3255)
CORE-17312

Hide everything under the same foreground & background colors, so that
the actual color and text blanking reset does not create a visual "blinking".
Then, blank the text and finally reset the actual foreground &
background colors.

We do this because we cannot do the screen scrolling trick that would
allow to change both the text and the colors at the same time (the
function is currently not available in our console "emulation" layer).

The issue was unhidden when we introduced the red progress bar in
0.4.11-dev-111-g e5c0bfacf1

Fix picked from 0.4.15-dev-1078-g 434fa562ce
2020-12-13 03:38:48 +01:00
Joachim Henze
1a270d9bbf [0.4.14][WINLOGON] Display the shutdown message popup dialog on the current input desktop. (#3259)
CORE-17050

Display the shutdown message popup dialog on the current input desktop,
and periodically monitor for any change of the input desktop. When the
latter changes, close the dialog and recreate it on the new input desktop.

In addition, retain the current dialog position and restore it when the
dialog is recreated on the new desktop.

A patch authored by HBelusca.

The regression was introduced by 0.4.10-dev-579-g
c697f191cf

This commit is merging back the changes of 0.4.15-dev-1096-g
0ff9b0ff7e
(the minimized patch from JIRA avoiding most surrounding style changes)
2020-10-11 02:06:38 +02:00
Hermès Bélusca-Maïto
902872fc0c [0.4.14][UMPNPMGR][USETUP] Fix the way device-install events are queued and dequeued. Fixes CORE-16103.
Dedicated to the hard work of Joachim Henze! xD

This reverts part of commit 043a98dd (see also commit b2aeafca).

Contrary to what I assumed in commit 043a98dd (and was also assumed in
the older commit b2aeafca), we cannot use the singled-linked lists to
queue and dequeue the PnP device-install events, because:

- the events must be treated from the oldest to the newest ones, for
  consistency, otherwise this creates problems, as shown by e.g. CORE-16103;

- the system singled-linked lists only offer access to the top of the
  list (like a stack) instead of to both the top and the bottom of the
  list, as would be required for a queue. Using the SLISTs would mean
  that only the newest-received events would be treated first, while the
  oldest (which were the first received) events would be treated last,
  and this is wrong.

Therefore one must use e.g. the standard doubly-linked list. Also, using
locked operations (insertion & removal) on the list of device-install
events is necessary, because these operations are done concurrently by
two different threads: PnpEventThread() and DeviceInstallThread().
Since the interlocked linked list functions are not available in user-mode,
we need to use instead locking access through e.g. a mutex.

the regression was introduced by 0.4.12-dev-72-g
043a98ddd9

fix cherry picked from commit 0.4.15-dev-1074-g
ffc96d26ec
2020-10-01 19:57:43 +02:00
Joachim Henze
bd6c343b4f [0.4.14][DNSRSLVR] Define NDEBUG in cache.c
To avoid leaking private data into logs by default.
Some testers may consider their DNS-suffix private data.
And DnsIntCacheAddEntry() logs that via Record->pName.

The logging was activated by 0.4.14-dev-173-g
d49d7b3282

fix cherry picked from commit 0.4.15-dev-383-g
1b8b339aae
2020-09-28 01:37:50 +02:00
Katayama Hirofumi MZ
22210acfdf [0.4.14][FONTVIEW] Fix regression; opening files won't list files (#3045)
Based on Mark Jansen's patch in CORE-17001.

The issue started to show with 0.4.14-dev-77-g
d9e7c48c1a

fix cherry picked from commit 0.4.15-dev-513-g
49be08bc69

no official ros release was affected therefore.
2020-08-15 13:15:36 +02:00
Serge Gautherie
5ce61092b5 [EXPLORER] Update now-redirected 'http' and 'www.reactos.org' URLs 2020-04-23 10:20:15 +02:00
Thomas Faber
5a5ba1ad10
[SHSVCS] Don't call UnregisterWait from within the wait callback.
Doing this causes deadlocks, the process runs out of worker threads and
the system runs out of memory by allocating too many I/O completion ports
when using ntdll.dll from Windows.
2020-04-22 12:37:26 +02:00
Serge Gautherie
333b7f254b
[IEXPLORE] Update now-redirected 'http' and 'www.reactos.org' URLs (#2619) 2020-04-22 14:45:12 +09:00
Serge Gautherie
c62b7a67ef
[USETUP] Update now-redirected 'http' and 'www.reactos.org' URLs (#2622)
NB:
http://www.reactos.org/uk/
is not updated, as it returns
Error 404 - Page not found.
2020-04-22 14:44:13 +09:00
Serge Gautherie
03006ecfad
[RAPPS] Update now-redirected 'http' and 'www.reactos.org' URLs (#2621)
NB:
http://www.reactos.org/wiki/Bulgarian_translation
is not updated, as it returns
Error 404 - Page not found.
2020-04-22 14:42:43 +09:00
Stanislav Motylkov
bc7c8ed45b
[REGEDIT] Improve Russian translation
Also fix minor issues in other translations. CORE-16914
2020-04-21 02:30:21 +03:00
Sylvain Deverre
0a271bb106 [RAPPS] Addendum to previous commit, fix condition 2020-04-20 18:45:37 +02:00
Kyle Katarn
779f31a731
[RAPPS] Proxy fields default state fix (CORE-16853) (#2594)
* Fix for CORE-16853 https://jira.reactos.org/browse/CORE-16853

Co-authored-by: Sylvain Deverre <deverre.sylv@gmail.com>
2020-04-20 18:30:33 +02:00
Mark Jansen
5cee1b95c0 [EXPLORER] Keep processing messages while waiting for a startup task
CORE-16909
2020-04-20 15:37:19 +03:00
Stanislav Motylkov
435d2b5652
[REGEDIT] Improve Russian translation
CORE-16913
2020-04-20 01:44:45 +03:00
Eric Kohl
c832112771 [REGEDIT] Fix tree view popup menu issues
Move the tree view popup menu code from the childwindow to the framewindow.

CORE-16887
2020-04-19 15:14:44 +02:00
Piotr Hetnarowicz
154917e72e
[TASKKILL] Polish translation update (#2566) 2020-04-18 19:19:31 +02:00
Joachim Henze
25fd966e1b [SERVMAN] CORE-16879 fr-FR Update
Avoid text truncation and realign controls.
2020-04-18 16:38:59 +02:00
Joachim Henze
47744a97a9 [SERVMAN] CORE-16879 RC en-US & de-DE Pixel Tweaking
The left x-margin was inconsistent within 'General'-tab
and tabbing through multiple tabs looked unprofessional
because 'General'-tab had much smaller left-margin.
2020-04-18 15:34:04 +02:00
Joachim Henze
c6dc574390 [SERVMAN] RC Update All languages
Align a treeviews horizontal and vertical size
to exactly fit its neighbor treeview in last
tab 'Dependencies'.
Slightly related to CORE-16879.
2020-04-18 14:14:55 +02:00
Kyle Katarn
40e82c4b94
[INETCPL][SERVMAN] French translation update (#2572)
CORE-16900

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-18 13:21:37 +02:00
Eric Kohl
45ad7a7ac3 [NOTEPAD] Fix missing french 'About notepad' menu item translation
CORE-16886
2020-04-18 11:28:42 +02:00
Eric Kohl
763de230b2 [REGEIT] Fix inconsistent menu state for 'Permissions'
- Disable the 'Permissions' item in the main menu, when 'My Computer' is selected.
- Enable the 'Permissions' item in the tree view context menu.

CORE-16889
2020-04-18 09:59:41 +02:00
Eric Kohl
b280615b85 [REGEDIT] Add a special popup menu for the tree view root item
CORE-16888
2020-04-18 08:53:17 +02:00
Joachim Henze
13dd917589 [REGEDIT] CORE-16892 fr-FR Translation update
Fix 3 text truncations in search-dlg
2020-04-18 01:59:39 +02:00
He Yang
2ac13afefc
[RAPPS] Use _beginthreadex instead of CreateThread (#2552) 2020-04-17 19:27:16 +02:00
Bișoc George
975d417b34
[UTILMAN] Move most of the code in a library (#2530)
Windows XP and Server 2003 Utility Manager has a dedicated library for the resources and other stuff. Utility Manager is just a simple process that loads it. Hence create a library for the program, UManDlg.dll, and move the resources and other stuff there.

In addition to that, use ExtractIconW to get the icon resource from the program (the DLL doesn't share icons by default) and remove the icon resource from the "About" dialog window. Also change the encoding type of other translation files to UTF-8 (which were previously set with UTF-8 with BOM).
2020-04-17 13:42:47 +03:00
Piotr Hetnarowicz
eba6f7dad0
[SHUTDOWN] Update Polish translation (#2557) 2020-04-16 21:48:16 +02:00
Piotr Hetnarowicz
864271120d
[CHARMAP] Update Polish translation (#2555) 2020-04-16 21:47:51 +02:00
Piotr Hetnarowicz
9b43dce094 [attrib] pl-pl lang update 2020-04-16 18:32:22 +02:00
Piotr Hetnarowicz
cd5364ae8e [cmd] pl-pl update 2020-04-16 18:32:08 +02:00
Victor Perevertkin
7e069ccdb2
[CMAKE] Replace custom functions to built-in ones
add_target_compile_definitions -> target_compile_definitions
add_target_compile_flags -> target_compile_options
add_target_include_directories -> target_include_directories
2020-04-16 15:59:38 +03:00
Piotr Hetnarowicz
97bb1fa49a
[WINLOGON] Update Polish translation (#2363) 2020-04-16 12:17:02 +03:00
Charles Ambrye
d90e1061e1
[CHARMAP] Updates to behaviour and UI (#2543)
Purpose
~=~=~=~

This pull request updates charmap to look a bit better (removes gap at bottom of the window), removes the blank space character (0x0020) from the charmap, and also modifies the behaviour of when a larger glyph is rendered (allowing the user to select a new glyph by holding down the mouse button). This better mimics the charmap.exe that is bundled by Microsoft.

Proposed changes
~=~=~=~=~=~=~=~=

- Remove gap where the advanced button is normally rendered when compiled with REMOVE_ADVANCED (which is the default behaviour).
- Skip over the blank space character.
- Change behaviour of rendering large glyphs to allow mouse move, and to hide on double click.
- Optimize search for glyph under the mouse by using the cellSize instead of PtInRect.


* [CHARMAP] Resize the window slightly when compiled with REMOVE_ADVANCED to avoid deadspace at the bottom of the window

* [CHARMAP] Skip over the non-printable characters by starting with character ' ' + 1

* [CHARMAP] Instead of iterating over every cell, simply compute the cell x and y using the CellSize

Modify behaviour of charmap to allow large character render on mouse move, only hiding the larger character on double click.
2020-04-15 23:31:16 +02:00
Julen Urizar Compains
d7a632a094
[TRANSLATION] Spanish minor fixes (#2547)
Translations for:
- Applications: clipbrd, dxdiag, rapps,
- cmdutils: attrib, find, help, label, reg, xcopy
- usetup
- dlls: browseui, shell32, syssetup

- Add Spanish translation for Accesibility Utility (utilman).

Update for the "Choose product options" strings in syssetup:

Originally "ProductType" and "ProductSuite" (typesetted without spaces) were the registry value names where these settings would go, but since it's meaningless to show these values it's better instead to use human-readable names with correct translation and spacing.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-15 13:27:36 +02:00
Joachim Henze
951e5f2851 [DXDIAG] fr-FR Translation Addendum CORE-12477 part 3/3
Leave english strings untouched regarding space before colon.
Thanks to HBelusca for review as well.
I hope next one translating these will take care still.
2020-04-14 00:42:33 +02:00
Joachim Henze
f03c4c4378 [DXDIAG] fr-FR Translation Addendum CORE-12477
Addendum to 0.4.14-dev-1405-g
dcc6dcb0bd

Readd all spaces before the colons that I removed,
as that is a french speciality and was correct,
and also add some more of those that were missing even
before my commit (was inconsistent).

Thanks to Serge Gautherie, Thomas Faber and hpoussin
for the review.
2020-04-14 00:06:48 +02:00
Joachim Henze
a050378835 [MSPAINT] fr-FR Translate some menu items CORE-12357 2020-04-13 23:28:30 +02:00
Joachim Henze
dcc6dcb0bd [DXDIAG] Less text truncation for all languages
Manually Tweaked fr-FR the most, see CORE-12477
Manually Tweaked de-DE enlarged a buttons size
For All Languages harmonized " :"->":"

For All Languages harmonized the maximized available space
for dynamic strings in 2nd tab right side from 100->120
2020-04-13 22:43:37 +02:00
Eric Kohl
1ca7d5d948 [IPCONFIG] Improvements to ipconfig
- Simplify the cleanup-code in ShowInfo
- Print the 'Primary DNS suffix' and the 'DNS Suffix Search List'
- Move the /registerdns message into its own function
2020-04-13 11:25:50 +02:00
Hermès Bélusca-Maïto
622c7ed609
[W32TIME][BOOTDATA] Export SvchostEntry_W32Time() as an alias to W32TmServiceMain, and use the former as the service entry point specified in the registry, for Windows compatibility. 2020-04-09 23:22:40 +02:00
Tibor Lajos Füzi
652806396a
[TRANSLATION] Hungarian translation update (#2519)
Hungarian translation update for solitaire, spider solitaire, winemine, task manager.
2020-04-09 21:49:34 +02:00
Mas Ahmad Muhammad
b8dd046ee4
[TRANSLATION] Add and update Indonesian translations (#2506)
- CMDUTILS: attrib, label (update translation)
- USETUP (add translation)
- HOTPLUG (add translation)
- CONSRV  (update translation)
- USERSRV (update translation)
- USER32  (update translation)
- ACLUI  (update translation)
- LICCPA  (update translation)
- SUBST  (update translation)
- REGSVR32  (update translation)
- REGEDIT-CLB  (update translation)
- ACPPAGE  (update translation)
- TIMEDATE  (update translation)
- SOLITAIRE  (update translation)
- FDEBUG  (update translation)
- SYSSETUP (update translation)
2020-04-09 18:49:45 +02:00