Commit graph

1190 commits

Author SHA1 Message Date
Pierre Schweitzer 9c2a264d77
[MPR] Import Wine commit: 9988bb5e0729178b527052803d3ad670e5e0b46e
Implement remembered connection enumeration.

CORE-15310
2018-12-05 08:47:25 +01:00
Luo Yufan 07b120bd56 [TRANSLATION] Update Simplified Chinese translation. (#1094) 2018-12-04 17:13:39 +01:00
Eric Kohl 2037bab6c4 [SETUPAPI] GetDeviceInstanceKeyPath: Trying to open the hardware key opens the software key and vice versa. Fix it by swapping the code paths. 2018-12-03 22:03:38 +01:00
Mark Jansen faddd38b36
[KERNEL32] Revert d897e27, which would re-initialized a list.
Spotted by Andrew Boyarshin.
2018-12-03 20:48:14 +01:00
Luo Yufan 6a506156a8 [MSGINA] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Luo Yufan 5066ee4606 [IEFRAME] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Luo Yufan a9f634b5fe [SHELL32] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Katayama Hirofumi MZ cbd52e30d7
[SHELL32] Don't show taskbar button of Folder Options (#1091)
CORE-10481
2018-12-03 13:38:09 +09:00
Katayama Hirofumi MZ c1eb420a91
careless s/E_FAIL/FALSE/ (#1089) 2018-12-03 05:43:21 +09:00
Katayama Hirofumi MZ 623b2e153e
[SHELL32] Follow up of #1085 (#1088)
CORE-10481
2018-12-03 05:38:36 +09:00
Katayama Hirofumi MZ ecd51d99f4
[SHELL32] Don't show taskbar button of file property sheet (#1085)
CORE-10481
2018-12-03 04:25:46 +09:00
Eric Kohl 3f570f3369 [SETUPAPI] Implement SetupGetNonInteractiveMode() and SetupSetNonInteractiveMode(). 2018-12-02 14:10:25 +01:00
Pierre Schweitzer 81aa879c13
[IPHLPAPI] Implement GetOwnerModuleFromUdpEntry() 2018-12-01 14:49:38 +01:00
Joachim Henze 3050d93deb [BROWSEUI] Properly fix CORE-13003 "Explorer address bar display problem"
The patches author is Doug Lyons. Thank you very much!
The patch is an addendum to 0.4.9-dev-732-g
ea0cc1c783
2018-12-01 14:26:33 +01:00
Pierre Schweitzer f5f3ff86ea
[LIBTIRPC] Fix CVE-2018-14621 by backporting its fix
CORE-15407
2018-12-01 12:16:41 +01:00
Hermès Bélusca-Maïto 95deef460b
[XOLEHLP] Import xolehlp.dll from Wine(-Staging) 3.21.
Should help improving the situation of the Microsoft SQL Server 2005
Express Edition installer. CORE-15399
2018-11-30 21:49:28 +01:00
Pierre Schweitzer 226195d4f2
[IPHLPAPI] Don't assume first member of MIB tables is always DWORD-big
This fixes last bits of heap corruption when using UDP/TCP enumeration
functions.
2018-11-30 20:06:29 +01:00
Pierre Schweitzer bf052e120b
[IPHLPAPI] Reduce code duplication and use a single function for TCP and UDP enumerations
Furthermore, memory was improperly allocated before (alignment issues) leading to heap
corruption under certain circumstances
2018-11-30 20:06:29 +01:00
Stanislav Motylkov ed7a78e97a
[SYSDM] Explicitly check DMI strings for NULL pointers
...to make CRT string comparison functions happy. CORE-15403
2018-11-30 16:55:29 +03:00
Pierre Schweitzer 3d2d957f81
[IPHLPAPI] Implement GetOwnerModuleFromTcpEntry()
CORE-4792
2018-11-29 20:36:08 +01:00
Pierre Schweitzer f87c88f6fe
[IPHLPAPI] Implement the *_TABLE_OWNER_MODULE_* in GetExtendedTcp/UdpTable() functions
This fixes CurrPorts in ReactOS. It now properly displays current connections along
with their creation time.

CORE-10134
2018-11-27 23:12:57 +01:00
Pierre Schweitzer 159f5b676a
[IPHLPAPI] Fix broken size computation leading to buffer overrun 2018-11-27 23:12:57 +01:00
Pierre Schweitzer 559297fe81
[IPHLPAPI] Implement getOwnerModUdpTable() and getOwnerModTcpTable()
These allow to enumerate UDP and TCP connections with module information
2018-11-27 23:12:56 +01:00
Pierre Schweitzer 7ce2f09a70
[SDK] Add AllocateAndGetTcp/UdpEx/2TableFromStack() functions family 2018-11-27 21:36:47 +01:00
Giannis Adamopoulos 1d55f459d6 [SHELL32] CFSDropTarget: Fix right click menu when shown over the tree view. CORE-11240 2018-11-27 12:58:08 +02:00
Giannis Adamopoulos 62c33fbf69 [BROWSEUI] CShellBrowser: Don't pass any parameters to Initialize. Let users use the BrowseObject method instead. 2018-11-27 10:33:57 +02:00
Pierre Schweitzer 6d6e371225
[IPHLPAPI] Start handling certain flags in GetAdaptersAddresses()
For now, we only support the most useful ones: IP_ADAPTER_DDNS_ENABLED,
IP_ADAPTER_REGISTER_ADAPTER_SUFFIX, IP_ADAPTER_DHCP_ENABLED
2018-11-26 22:43:43 +01:00
Luo Yufan 289301e22a [INETCFG] Update Simplified Chinese translation. (#1076) 2018-11-26 15:55:57 +01:00
Eric Kohl 57d48a7f1c [NETAPI32] Implement DsGetDcNameA/W --> DsGetDcNameWithAccountA/W --> DsrGetDcNameEx2. 2018-11-25 23:24:21 +01:00
Mark Jansen da02cc337a
[APISETS] Update from wine-3.20-144-g2ef62f9085 2018-11-25 19:06:29 +01:00
Mark Jansen a95afd562e
[APISETS] Teach update.py how to generate a manifest 2018-11-25 19:06:29 +01:00
Mark Jansen 6121df7321
[APISETS] Stubplement versioned forwarders 2018-11-25 19:06:16 +01:00
Pierre Schweitzer 1a964b5139
[IPHLPAPI] In GetAdaptersAddresses(), return friendly name if asked for 2018-11-25 18:04:13 +01:00
Pierre Schweitzer 26415375e3
[IPHLPAPI] Implement AllocateAndGetUdpExTable2FromStack()
CORE-14391
2018-11-25 13:32:52 +01:00
Pierre Schweitzer 0bca12e01f
[IPHLPAPI] Implement AllocateAndGetTcpExTable2FromStack()
CORE-14391
2018-11-25 13:29:26 +01:00
Pierre Schweitzer 291a58951f
[IPHLPAPI] Implement AllocateAndGetUdpExTableFromStack() 2018-11-25 12:23:27 +01:00
Pierre Schweitzer 58799a0ceb
[IPHLPAPI] Implement AllocateAndGetTcpExTableFromStack() 2018-11-25 12:19:44 +01:00
Bernhard Feichtinger 9cc37704f5 [OPENGL32] Fix wglDescribePixelFormat 2018-11-25 11:29:18 +01:00
Pierre Schweitzer 370b03b523
[IPHLPAPI] Reimplement GetUdpTable() using GetExtendedUdpTable() 2018-11-24 21:41:10 +01:00
Pierre Schweitzer 58cef01422
[IPHLPAPI] Implement GetExtendedUdpTable()
We only support IPv4 and UDP_TABLE_BASIC, UDP_TABLE_OWNER_PID
for now

CORE-5126
2018-11-24 21:41:10 +01:00
Pierre Schweitzer 6fb6c7b50b
[IPHLPAPI] Implement getOwnerUdoTable(), to get UDP connections with owner PID 2018-11-24 21:41:10 +01:00
Pierre Schweitzer 73c87d5c14
[IPHLPAPI] Reimplement GetTcpTable() using GetExtendedTcpTable() 2018-11-24 21:41:09 +01:00
Pierre Schweitzer d76ac645e8
[IPHLPAPI] Don't leak memory 2018-11-24 21:41:09 +01:00
Pierre Schweitzer c949a12506
[IPHLPAPI] Implement the IPv4 TCP_TABLE_OWNER_PID_* cases in GetExtendedTcpTable() 2018-11-24 21:41:09 +01:00
Pierre Schweitzer dca7e5689f
[IPHLPAPI] Implement getOwnerTcpTable(), to get TCP connections with owner PID 2018-11-24 21:41:09 +01:00
Pierre Schweitzer 702d44c683
[IPHLPAPI] Implement the IPv4 TCP_TABLE_BASIC_* cases in GetExtendedTcpTable() 2018-11-24 21:41:08 +01:00
Luo Yufan a2819679ec [TRANSLATION] Update Simplified Chinese translation. (#1057) 2018-11-23 16:24:47 +01:00
Joachim Henze 432afb4161 [SHELL32] Improve CORE-15295 IDD_FILE_PROPERTIES
addendum to 0.4.11-dev-673-g
04e1263921

Actually this control must not statically consume width of 170.
There are two different versions of that dialog.
One has a "change"-button. In this case the edit must be only 100 wide.
In case we have the version without the change button, we resize it to have
170 width (same as its neighbor).

This commit is shared work of
Stanislav Motylkov, Giannis Adamopoulos and Joachim Henze.

Commit supersedes PR#1056.
2018-11-23 02:25:28 +01:00
Stanislav Motylkov c1195f5300 [SYSDM][DXDIAG][SYSTEMINFO] Include only one user-mode DMI library (#1054)
Include only one user-mode DMI library. Addendum to baf2c0c.
2018-11-21 22:07:54 +01:00
Denis Malikov d897e271a2
[KERNEL32] FlsAlloc - fiber local storage list was not initialized before using 2018-11-21 19:18:01 +01:00
Pierre Schweitzer 8a98c85c1f
[IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections
This fixes the API not to return the current TCP connections while
enumerating them (and thus, netstat not displaying them).
It seems we return garbage for now though
2018-11-20 22:14:25 +01:00
Serge Gautherie 154ed37062 [NETSHELL] Fix '0' typo, in a text 2018-11-19 09:57:42 +02:00
Hermès Bélusca-Maïto 2d320f5a8d
[OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber. 2018-11-18 21:06:22 +01:00
Pierre Schweitzer d18b1fe24b
[IPHLPAPI] Properly count UDP entries
Fixes crash when running netstat -a with
no TCP connections but with UDP connections

CORE-5401
2018-11-18 18:56:36 +01:00
Pierre Schweitzer e3cb9697a4
[IPHLPAPI] Implement getNumUdpEntries() and getUdpTable()
CORE-5401
2018-11-18 16:30:45 +01:00
Pierre Schweitzer 678204790c
[IPHLPAPI] Implement getNumTcpEntries() and getTcpTable()
CORE-5401
2018-11-18 16:30:45 +01:00
Denis Malikov 6a2f967302 [OLE32] Add stub for CoDisconnectContext function (#1044) 2018-11-18 15:32:07 +01:00
Giannis Adamopoulos a9d92a99c6 [NETSHELL] Add some notes about how it can be tested in windows 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos f722ddac96 [NETSHELL] CNetConnectionPropertyUi: Add a comment about how windows write the settings 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 0654d60eef [NETSHELL] Move the implementation of the Disable button of the status dialog to CNetConnection::Disconnect 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 132463abf2 [NETSHELL] CNetConUiObject: Implement the Connect and Disconnect context menu items 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 7506198780 [NETSHELL] Optionally use the system's CLSID_ConnectionManager
Use a central compile option like we do in the rest of the shell so that when testing in windows we can switch using the one in the current dll or the one registered in the system.
Note that not only CLSID_ConnectionManager isn't implemented in netshell, it can't even be instantiated as CLSCTX_INPROC_SERVER because it is implemented by the netman service
2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 21a5a559f2 [NETSHELL] Rewrite how pidls are created and accessed.
What we did before was completely wrong as we stored pointers in the pidl.
2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 769b102e5f [NETSHELL] Use smart pointers and IID_PPV_ARG 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos c73d8c64bb [NETSHELL] Use ATL 2018-11-18 14:01:54 +02:00
Giannis Adamopoulos 8d47872ea0 [NETSHELL] Add missing license headers
Since one of the first files in the module (shfldr_netconnect.c) used the LGPL2.1+ license, all the other files have the same license
2018-11-18 14:01:54 +02:00
Pierre Schweitzer 5e024bfeb6
[MPR] Drop a nasty ReactOS specific hack
That hack (cf. previous commit) was used to restore all
the saved connections. But, because it was implemented
in the wrong place, each time the MPR DLL was attached,
it was trying to restore connections.

With that commit and the previous one, now, ReactOS has
a correct behavior (it tries to bring back connections
only at session opening) and will reduce "workload" for
applications attaching MPR dll.

CORE-15310
2018-11-17 22:13:34 +01:00
Pierre Schweitzer 8b0a126445
[MPR] Implement remembered connection enumeration
Submitted upstream

CORE-15310
2018-11-17 22:13:25 +01:00
Bișoc George c00bafaad9 [SHELL32] Print out the error code (#973)
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
2018-11-16 23:09:15 +01:00
Pierre Schweitzer 007cc5cd8a
[ACGENRAL] Don't leak memory on failure in InitIgnoreFreeLibrary()
CID 1441306
2018-11-16 22:07:09 +01:00
Pierre Schweitzer 52da844825
[COMCTL32] Don't leak memory in CB_ThemedPaint()
CID 1441313
2018-11-16 22:07:09 +01:00
Pierre Schweitzer 699af9f62a
[SETUPAPI] Allocate big enough buffer in CM_Query_Resource_Conflict_List().
CID 1441357
2018-11-16 22:07:08 +01:00
Pierre Schweitzer 3fddd3157c
[COMCTL32] Don't leak memory in PB_ThemedPaint()
CID 1441373
2018-11-16 22:07:08 +01:00
Pierre Schweitzer 402c983094
[SYSSETUP] Fix error message in ApplyRegistryValues()
CID 1441398
2018-11-16 22:07:07 +01:00
Giannis Adamopoulos 9baf05f164 [SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file
CORE-15353
2018-11-15 21:26:17 +02:00
Luo Yufan d8a4e0a8e3 [TRANSLATION]Update Simplified Chinese translation. (#1032) 2018-11-14 21:42:21 +09:00
Baruch Rutman 97150ce9dd [WINMM] Sync wine commit ebae298 as a fix for CORE-15336 (#1031)
Reduce CPU usage by only attempting once to load the default joystick driver.
Fix for CORE-15336

Imported wine commit ebae298
ebae298aa4
https://www.winehq.org/pipermail/wine-devel/2018-November/134767.html
2018-11-14 12:32:55 +01:00
Giannis Adamopoulos 73b679e4a6 [NETSHELL] CNetConUiObject: Fix implementation of IContextMenu.
The id that InvokeCommand gets is the one used by QueryContextMenu after subtracting idCmdFirst.
2018-11-11 20:28:36 +02:00
Giannis Adamopoulos cd7a331749 [NETSHELL] CNetConUiObject: Implement handling the rename context menu item 2018-11-11 20:28:34 +02:00
Giannis Adamopoulos af3a1b1936 [NETSHELL] CNetConUiObject: Use a switch in InvokeCommand 2018-11-11 20:28:32 +02:00
Giannis Adamopoulos 41639e94c2 [NETSHELL] CNetworkConnections: Remove SFGAO_CANRENAME bit when renaming shouldn't be enabled.
This fixes the problem where renaming could take place by clicking on a name even when it is disabled in the context menu.
CORE-14116
2018-11-11 20:28:31 +02:00
Giannis Adamopoulos 91119080bc [NETSHELL] CNetworkConnections: SetNameOf should always return a new pidl on success.
CORE-14116
2018-11-11 20:28:29 +02:00
Giannis Adamopoulos bcd309cb7a [SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before
CORE-14116
2018-11-11 20:28:27 +02:00
Luo Yufan 5cdee1ab82 [TRANSLATION] Update Simplified Chinese translation. (#1028) 2018-11-11 17:57:12 +01:00
Adam Słaboń b8044d6783 [TRANSLATION] Polish translation update (#1029)
Translated missing strings and improved existing translations.
2018-11-11 17:55:01 +01:00
Luo Yufan 91e032f9b1 [TRANSLATION] Update Simplified Chinese translation. (#1025) 2018-11-09 15:31:53 +01:00
Luo Yufan 7fafe923cb [SYSDM] Update Simplified Chinese translation. (#1021) 2018-11-08 14:08:34 +01:00
Joann Mõndresku b63e2d5046 [TRANSLATIONS] Style fixes for Estonian 2018-11-07 22:10:27 +01:00
Zcooger 52eee8955c [APPWIZ] Update polish translation (#921) 2018-11-07 16:20:32 +01:00
Joachim Henze 04e1263921 [SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs 2018-11-07 01:40:53 +01:00
Eric Kohl f26513f942 [NETSHELL] Add missing interface stubs to CNetworkConnections (aka CConnectionFolder). 2018-11-06 22:23:45 +01:00
Eric Kohl ee90e7f608 [LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions that use a policy handle and a domain name or domain SID when the machine is not a domain controller. 2018-11-04 15:27:57 +01:00
Eric Kohl 91eaa5e2d4 [LSASRV] Coding style fixes 2018-11-04 12:50:21 +01:00
Pierre Schweitzer 497a9c8087
[SETUPAPI] Don't let LZClose() reset error code 2018-11-02 09:34:25 +01:00
Carlo Bramini 8236bb8f38
Avoid stray temp files in failure cases of do_file_copyW. CORE-12616 2018-11-02 09:22:34 +01:00
Joachim Henze ad34c91d1c [RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.
2018-10-30 19:06:50 +01:00
Bișoc George 0c88f79480 [USRMGR] Fix a truncated text on French resource
CORE-15267
2018-10-28 19:30:17 +01:00
Mark Jansen 4bfac27ce6
[SHELL32] Fix broken control definition 2018-10-28 13:06:27 +01:00
Mark Jansen 95682e5406
[SETUPAPI] Fix broken control definition. 2018-10-28 13:06:08 +01:00
Mark Jansen 824e5dba51
[KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup 2018-10-28 13:01:38 +01:00