Commit graph

375 commits

Author SHA1 Message Date
Katayama Hirofumi MZ
b70232d416 [SHELL32] Half-implement SHWinHelp 2020-05-14 09:38:38 +09:00
Katayama Hirofumi MZ
711f631849
[SHELL32] Don't hardcode C: drive (#2768)
CORE-13235
2020-05-11 11:43:07 +09:00
Charles Ambrye
e978ec6125
[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted (#2703)
Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.
2020-05-09 21:54:15 +09:00
Katayama Hirofumi MZ
1f3cb13fb9
[SHELL32] Distinguish floppy and removable drives (#2645)
Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221
2020-05-06 00:35:01 +09:00
Katayama Hirofumi MZ
11b6f973b7 [SHELL32] Follow-up 2 of #2659
Add TODO comments.
Make CreateAPCThread static.
CORE-13950
2020-05-04 16:22:38 +09:00
Katayama Hirofumi MZ
7980f40911 [SHELL32] Follow-up of #2659
Add CreateAPCThread function and use it. CORE-13950
2020-05-04 15:28:16 +09:00
Katayama Hirofumi MZ
5c589b5537
[SHELL32] Notify filesystem changes (#2659)
Notify filesystem change notifications by using ReadDirectoryChangesW function. Creating/Deleting files/folders will be responsive in Explorer. CORE-13950
2020-05-04 14:53:23 +09:00
Jared Smudde
5b7be1572b
[SHELL32] Set the Run dialog to use the newer style browse for file dialog. (#2728)
Apply the OFN_EXPLORER flag to the Run dialog so the dialog uses the newer style browse dialog.
2020-05-04 12:53:35 +09:00
Katayama Hirofumi MZ
77b8505393
[SHELL32] Delete IDM_RECENTMENUHEAD resource menu (#2705)
Follow-up of #2648. Reduce translation cost and resource data.
CORE-3588, CORE-11483
2020-05-01 15:58:58 +09:00
Kyle Katarn
cd6e1c73c0
[SHELL32] Fix "Open With..." spamming registry MRU keys. (#2685)
CORE-16981

The problem:
============

- When opening "Open With..." dialog for a given file format, multiple MRU items are appended to registry : 2 items written, even if dialog is closed "cancel".
- Expected behavior : 1 MRU item if execute is selected and 0 MRU if cancel is selected.

Fix:
====

- MRU item to be added when "Execute" is selected only.
- Once added, set the presence flag to avoid multiple MRU items being added later.
2020-04-30 23:03:10 +02:00
Adam Stachowicz
bd33e6b26f
[SHELL32] Update Polish translation (#2700)
Addendum to 8f3079c.
2020-04-30 13:37:31 +03:00
Katayama Hirofumi MZ
8f3079c67f
[SHELL32][EXPLORER] Improve Recent Documents of Start Menu (#2648)
Improve Recent Documents of Start Menu. Add items of "My Documents" and "My Pictures" into Recent menu item.
CORE-3588, CORE-11483
2020-04-30 17:09:14 +09:00
Stanislav Motylkov
68f9fd2f5d
[SHELL32] Fix dialog labels in Recycle Bin properties page (#2676)
Also fix remaining "Max size" edit box positions.

Addendum to e6e45b3. CORE-16972
2020-04-27 16:03:27 +03:00
Kyle Katarn
e6e45b34cc
[SHELL32] Fix "Max size" Edit box position in Recycle Bin properties page (#2676)
CORE-16972
2020-04-27 12:48:26 +02:00
Katayama Hirofumi MZ
771457f37f
[SHELL32] Implement VK_DELETE on SHBrowseForFolder (#2661)
Enable Del/Delete key to delete the selected folder in "Browse for Folder" dialog.
You can use https://jira.reactos.org/secure/attachment/40118/getfolder.zip as a test program.
CORE-7592
2020-04-26 22:06:19 +09:00
Serge Gautherie
a7e4d66be5 [SHELL32] DoGetProductType(): Use RegGetValueW()
instead of RegQueryValueExW(), to enforce a null terminator.

Addendum to 9f4e8ef25b.
2020-04-26 14:16:59 +02:00
Katayama Hirofumi MZ
c04010c9ad [SHELL32] Update name in CDefView::LV_RenameItems 2020-04-26 13:21:14 +03:00
Kyle Katarn
07e80dead4
[SHELL32] Improve french translations 2020-04-25 10:38:35 +02:00
Katayama Hirofumi MZ
d32858413d
[SHELL32] Command 'start C:' should open 'C:\' (#2642)
Based on JIRA user amaneureka's idea.
In SHELL_execute function, add a backslash for Drive "C:", "D:" or "E:" etc.
CORE-16384
2020-04-25 11:01:20 +09:00
Katayama Hirofumi MZ
a48aa21102
[SENDMAIL][ZIPFLDR][MYDOCS] Fix creation of SendTo files (#2616)
- Improve and move SendTo files creation code and timing.
- Delete IDS_DESKLINK of shell32.
- Add IDS_DESKLINK into sendmail.
CORE-16924
2020-04-23 04:19:20 +09:00
Jose Carlos Jesus
181ed94e22
[SHELL32] Fix grammar mistake in portuguese translation (#2605) 2020-04-21 16:38:23 +03:00
Stanislav Motylkov
c6abe80af5
[SHELL32] Update Russian translation
Addendum to c82ba34.
2020-04-21 00:38:42 +03:00
Charles Ambrye
8c4bd09518 [SHELL32] Fix a bug that caused Auto Arrange to always be highlighted in the file explorer
This occurred in the file explorer because the menu isn't destroyed and recreated each time, so the menu item, once checked, will stay checked forever.  We must call CheckMenuItem with MF_UNCHECKED to clear the check when necessary
2020-04-20 23:13:09 +03:00
Charles Ambrye
c82ba3485e [SHELL32] Modify context menu to include Align To Grid, and remove Line Up Icons
Implement support for using Align To Grid, which itself simply sets the LVS_EX_SNAPTOGRID extended style of the list view control
2020-04-20 23:13:09 +03:00
Ioannis Adamopoulos
0d077c3068 [SHELL32] CDesktopFolder::GetUIObjectOf: fix crash when requested to create a IID_IContextMenu for 0 items.
* Tests show that we should return a valid object even in this case.
2020-04-20 17:37:03 +03:00
Mark Jansen
d2b91deb33 [SHELL32] CMyDocsFolder: Ensure the object can be used without calling Initialize 2020-04-20 17:36:44 +03:00
Mark Jansen
6a6a28b634 [SHELL32] Ensure CIDLDataObject::GetData always returns an STGMEDIUM that is safe for use with ReleaseStgMedium 2020-04-20 17:36:43 +03:00
Joachim Henze
4af7888b29 [SHELL32] CORE-16895 RC IDD_OPEN_WITH All langs
-Avoid text truncations regarding the checkbox
 in a uniform way
-Reduce chance of text truncations for a button
 in a uniform way
-Fix es-ES dlg layout and harmonize its dlg Size
 with other languages
-de-DE fix double accelerator
2020-04-20 02:08:45 +02:00
Joachim Henze
c0d5e4fd6b [SHELL32] CORE-16895 RC IDD_FOLDER_OPTIONS_FILETYPES All langs
-Some inspiration from de-DE which I improved years ago
-Avoid text truncations and control overlapping that
 happened in almost all other languages
-Increase the size of the listView for all except es-ES & pt-PT
-es-ES & pt-PT had different dlgs sizes, I only slightly tweaked
 those therefore
-In sum this brings the RCs much closer to each other

-Unrelated: fix a white-space-typo we had in some but not all RCs
2020-04-19 21:33:13 +02:00
Charles Ambrye
1bee97358e [SHELL32] Pass LVA_SNAPTOGRID to listview when 'Line up Icons' is selected 2020-04-17 13:23:29 +03:00
Stanislav Motylkov
edc66fdc22
[SHELL32] Update Russian translation
CORE-16873
2020-04-16 13:40:49 +03:00
Piotr Hetnarowicz
abd6954d6a
[SHELL32] Update Polish translation (#2364) 2020-04-16 13:24:17 +03:00
Stanislav Motylkov
ea298746db
[SHELL32][BROWSEUI] Update Russian translation
Addendum to 033f0d9. CORE-16866
2020-04-16 00:10:12 +03:00
Joachim Henze
2032c3afba [SHELL32] CORE-12294 File & folder properties dialog fr-FR & de-DE resource
Avoids text truncation for french
Improves checkboxes alignment for german
2020-04-15 14:45:48 +02:00
Julen Urizar Compains
d7a632a094
[TRANSLATION] Spanish minor fixes (#2547)
Translations for:
- Applications: clipbrd, dxdiag, rapps,
- cmdutils: attrib, find, help, label, reg, xcopy
- usetup
- dlls: browseui, shell32, syssetup

- Add Spanish translation for Accesibility Utility (utilman).

Update for the "Choose product options" strings in syssetup:

Originally "ProductType" and "ProductSuite" (typesetted without spaces) were the registry value names where these settings would go, but since it's meaningless to show these values it's better instead to use human-readable names with correct translation and spacing.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-15 13:27:36 +02:00
Stanislav Motylkov
033f0d998a [SHELL32] Add Russian translation (#2548)
CORE-16866
2020-04-15 12:38:27 +02:00
Eric Kohl
69e565891d [SHELL32] No french translation from "right click drag'n'drop"
CORE-16815
2020-04-13 15:41:13 +02:00
Eric Kohl
c037278c5f [SHELL32] Fix missing french translation for "Command prompt here"
CORE-16855
2020-04-13 15:27:47 +02:00
Katayama Hirofumi MZ
5af2570b37 [SHELL32] Follow-up No.3 of #2539
Improve a comment in CreateNotificationParamAndSend.
CORE-13950
2020-04-13 13:19:12 +09:00
Katayama Hirofumi MZ
b76d053a30 [SHELL32] Follow-up No.2 of #2539
Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950
2020-04-13 13:06:15 +09:00
Katayama Hirofumi MZ
bfe36e4f0d [SHELL32] Follow-up of #2539
Improve comment. CORE-13950
2020-04-13 10:41:26 +09:00
Katayama Hirofumi MZ
2727245c86
[SHELL32] Shell notify rework for simplicity and readability (#2539)
Shell change notification has been implemented in #2432. But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950
2020-04-13 10:36:24 +09:00
Katayama Hirofumi MZ
ddc1a46456 [SHELL32] Improve CChangeNotify::ShouldNotify more
Improved non-recursive cases.
CORE-13950
2020-04-11 11:55:06 +09:00
Katayama Hirofumi MZ
2a32094aa0 [SHELL32] Check pidl->mkid.cb == 0 at CChangeNotify::ShouldNotify
CORE-13950
2020-04-11 09:27:45 +09:00
Katayama Hirofumi MZ
2a6bccb4ce [SHELL32] Make "Unable to get notification window" quiet
CORE-13950
2020-04-11 08:45:23 +09:00
Katayama Hirofumi MZ
60959e34aa [SHELL32] Simplify CChangeNotify::ShouldNotify
CORE-13950
2020-04-10 21:57:58 +09:00
Katayama Hirofumi MZ
59c48a5d33 [SHELL32] Improve CChangeNotify::ShouldNotify
Shell change notification was not sent to My Documents.
CORE-13950
2020-04-10 21:51:22 +09:00
Serge Gautherie
745cb1cbda
[SHELL32] Fix SHCNE_UPDATEITEM number of items (#2409)
Import
83acbb79c1

Related to CORE-13950
2020-04-09 19:42:00 +02:00
Joachim Henze
bf342653df [SHELL32] CORE-16808 fr-FR "Browse for folder" too narrow (extract zip file) 2020-04-09 18:17:06 +02:00
Katayama Hirofumi MZ
1c706d7483
[SHELL32] Watch for common desktop and SHCNE_CREATE for IShellLink::Save (#2515)
- On desktop view, we have to watch both the common desktop and the private desktop.
- In Windows, IShellLink::Save (shortcut creation) sends SHCNE_CREATE or SHCNE_UPDATEITEM notification.
- Simplify CChangeNotify::ShouldNotify.
CORE-10391
2020-04-09 16:56:54 +09:00