Commit graph

287 commits

Author SHA1 Message Date
Giannis Adamopoulos
218b8eda92 [SYSSETUP] Don't load ISOLATIONAWARE_MANIFEST_RESOURCE_ID manually
Such a manifest is meant to be activated by the caller of the exports of the dll.
This means that the user of syssetup which is setup.exe is the one that should do the proper handling of the manifests.
Since setup.exe is the one that needs to do the right thing, add a CREATEPROCESS_MANIFEST_RESOURCE_ID to it and avoid
dealing with ISOLATIONAWARE_MANIFEST_RESOURCE_ID altogether (which is supposed to be used by activating the activation context
before calling the exports of the dll that has it). We don't really use ISOLATIONAWARE_MANIFEST_RESOURCE_ID correctly in any
place in the tree so let's rely on CREATEPROCESS_MANIFEST_RESOURCE_ID for now.

This fixes one part of CORE-14228 where no image was shown in the theme selector buttons. This happened because comctl32 was
statically linked and calling ImageList_LoadImage ended up creating an image list with comctl32 v5. Then we passed this image
list to a button created with comctl32 v6 and as a result the image list was unusable. This is yet another issue that needs
to be addressed in the future. Namely, it seems that in windows comctl32 v6 can use image lists created by comctl32 v5 whereas
we cannot.

This fix is not a hack but cleverly works around these two bugs that need to be addressed some time in the future.
CORE-14228
2018-02-07 01:15:49 +02:00
Luo Yufan
b97f0a8fed [TRANSLATION][BROWSEUI][MEDIA] Simplified Chinese translations update (#360) 2018-02-05 18:47:53 +01:00
Mark Jansen
058c2658a4 [SHELL32] CDefViewBckgrndMenu: Fix a crash when pasting on a new explorer window. 2018-02-05 17:39:32 +01:00
Eric Kohl
e5870819a3 [SETUPAPI] Machine handles are pointers. 2018-02-04 22:03:17 +01:00
Eric Kohl
19fc20f222 [SETUPAPI] Add a proper (SEH protected) check for LOG_CONF handles 2018-02-04 20:23:51 +01:00
Eric Kohl
60a218948e [SETUPAPI] Fix the coding style, annotations and debug messages
* Fix the coding style.
* Add missing annotations.
* Add the function name to the debug messages.
* Treat all machine handles like pointers.
2018-02-04 20:16:46 +01:00
Thomas Faber
b9f88d594d
[PSDK][XDK] Remove DECLSPEC_* from windef.h, protect against redefinition in winnt.h 2018-02-04 19:28:36 +01:00
Hermès Bélusca-Maïto
131678a025
[SHELL32] Rewrite the wrapping code for shell taskbar notifications.
- Introduce the TRAYNOTIFYDATAW structure, as documented by Geoff
  Chappell in "WM_COPYDATA for Taskbar Interface", at
  http://www.geoffchappell.com/studies/windows/shell/shell32/api/shlnot/copydata.htm
  that is the data structure passed between shell32 and explorer for
  communicating shell notify icon information.

- In Shell_NotifyIcon(), correctly capture the (ANSI and) UNICODE
  structures provided by the caller, properly taking into account for
  the different NOTIFYICONDATA structure sizes existing out there.
  The different strings are now properly null-terminated (especially
  szTip if it needs to be truncated out), and the flags validated.

- Remove the now unneeded "SHELL_NotifyIcon()" helper function.

[EXPLORER] Use TRAYNOTIFYDATAW and adjust the callers.
2018-02-04 18:11:50 +01:00
Hermès Bélusca-Maïto
e2c6c3cfc7
[BROWSEUI] Shut a warning down ("windef.h(121) : warning RC4005: 'DECLSPEC_IMPORT' : redefinition" when compiling the resource). 2018-02-04 18:11:47 +01:00
Eric Kohl
65d3bf7482 [SETUPAPI] Fix the coding style, add annotations and fix the debug messages. 2018-02-04 15:41:13 +01:00
Eric Kohl
c7fc2ef4d2 [SETUPAPI] Update some more functions to the current coding style, add annotations and add function names to the TRACE calls. 2018-02-04 11:17:30 +01:00
Hermès Bélusca-Maïto
5ecabcce59
[SHELL32] Fix copy-pasta. 2018-02-04 01:56:56 +01:00
Luo Yufan
a13c998183 [TRANSLATION] Simplified Chinese translations updated. (#348) 2018-02-01 02:50:29 +01:00
Stanislav Motylkov
63ad8a71c0 [IPHLPAPI] Fix IcmpSendEcho output when host is not reachable
- Add missing error code to DDK/NDIS
- Fix error code in IP driver
- Patch MSAFD to reply correct WSA error code
- Fix IcmpSendEcho function
  - Fix returning error code in ICMP_ECHO_REPLY (see MSDN)
  - Fix returning host address (using GetBestInterface and GetIpAddrTable functions)
- Fix GetBestRoute function (it is used by GetBestInterface)

Relates to #318 and CORE-14241
2018-01-31 17:28:21 +00:00
Stanislav Motylkov
3624c5d6fd [SHELL32] Fix file and folder properties dialogs
CORE-12755
2018-01-31 18:25:14 +01:00
Thomas Faber
682735fb56
[SHELLMENU] Add missing psdk dependency. 2018-01-31 11:48:37 +01:00
Luo Yufan
7082b621a5 [TRANSLATION] Simplified Chinese translation improved. (#346) 2018-01-30 21:49:40 +01:00
Katayama Hirofumi MZ
0864d2de85 [SHIMGVW] Enable zooming
* merge ZoomIn and ZoomOut functions
* NULL to hbrBackground
* use GET_X_LPARAM and GET_Y_LPARAM for WM_MOUSEWHEEL
2018-01-30 19:36:59 +00:00
Jared Smudde
817beaf9c5 [NETCFGX] Rename 'Network connection' to 'Network Connection'. (#345)
English capitalization fix. It should look a little better both in the system tray and in the Network Connections folder.
2018-01-30 18:07:09 +01:00
Timo Kreuzer
2b57c9f47d Revert "[OLEAUT32] Sync with Wine 3.0. CORE-14225"
This reverts commit 13fd286c18.

The "sync" zapped a lot of fixes, in particular 64 bit compatibility.
2018-01-29 23:31:08 +01:00
Luo Yufan
09168aae12 [TRANSLATION] Update Simplified Chinese Translations of SHELL32 and USRMGR (#340) 2018-01-29 18:21:20 +01:00
Joann Mõndresku
d80ef2c90a [TRANSLATION] Various translations to Estonian (#329)
Estonian translations for shell + explorer, cpl files (access, appwiz, desk, timedate), devmgr, browseui, comctl32, aclui, avifil32, comdlg32 and credui.
2018-01-29 17:03:27 +01:00
Giannis Adamopoulos
8c4b7b0747 [COMCTL32] toolbar: Use szBarPadding.cy as the default top margin 2018-01-29 17:51:06 +02:00
Adam Słaboń
fbcf05062e [TRANSLATION] Polish translation update (#328) 2018-01-27 13:21:22 +01:00
Giannis Adamopoulos
5b8975211d [GDIPLUS] Add it to winsxs.
[NTDLL_APITEST] Remove a hack for gdiplus
2018-01-27 02:45:50 +02:00
Stanislav Motylkov
25564cda9d [UXTHEME] Add missing THEME_BUTTON_STATES
CORE-14245 #resolve
2018-01-23 14:46:57 +02:00
Hermès Bélusca-Maïto
9e07da5ccb
[SHLWAPI] Partly revert SHLWAPI Wine 3.0 sync b725032 .
This Wine sync (that was not done against WineStaging) erased code
that had been submitted to WineStaging by the ReactOS team (clist.c
fixes, see r73565 a05881c and r73976 7b6b597) or added in r68042 9a78054.

To that aim I add explicit #if(n)def __REACTOS__ guards around the code.
2018-01-22 21:07:21 +01:00
Eric Kohl
9d29ee3a62 [DEVMGR] Implement missing device power information (current power state, power capabilities and power state mappings). 2018-01-22 00:35:21 +01:00
Amine Khaldi
90f14ccef3 [WTSAPI32] Sync with Wine 3.0. CORE-14225 2018-01-21 22:01:34 +01:00
Amine Khaldi
3672658e75 [WSHOM.OCX] Sync with Wine 3.0. CORE-14225 2018-01-21 21:59:45 +01:00
Amine Khaldi
81b5ed93e1 [WMVCORE] Sync with Wine 3.0. CORE-14225 2018-01-21 21:58:37 +01:00
Amine Khaldi
87c506baca [WLDAP32] Sync with Wine 3.0. CORE-14225 2018-01-21 21:57:04 +01:00
Amine Khaldi
c95e9203e6 [WININET] Sync with Wine 3.0. CORE-14225 2018-01-21 21:53:54 +01:00
Kamil Smoliński
00ed9fc88b [SHELL32] Fix typo in Polish translation pl-PL.rc 2018-01-21 19:13:57 +01:00
Thomas Faber
cd992d022f
[USP10] Re-use script caches for the same font. CORE-14192
This significantly speeds up WM_SETTEXT in multiline edit controls.
2018-01-20 15:55:07 +01:00
Amine Khaldi
9048bdf976 [WINHTTP] Sync with Wine 3.0. CORE-14225 2018-01-20 13:55:24 +01:00
Amine Khaldi
c8f158b700 [WINEMP3.ACM] Sync with Wine 3.0. CORE-14225 2018-01-20 13:52:52 +01:00
Amine Khaldi
c3715ca58f [WINDOWSCODECS] Sync with Wine 3.0. CORE-14225 2018-01-20 13:50:46 +01:00
Amine Khaldi
7e99651d65 [WBEMPROX] Sync with Wine 3.0. CORE-14225 2018-01-20 13:47:34 +01:00
Amine Khaldi
b99f0b4922 [WBEMDISP] Sync with Wine 3.0. CORE-14225 2018-01-20 13:45:23 +01:00
Amine Khaldi
9e01104f70 [VERSION] Sync with Wine 3.0. CORE-14225 2018-01-20 13:41:59 +01:00
Amine Khaldi
e0b80a0929 [VBSCRIPT] Sync with Wine 3.0. CORE-14225 2018-01-20 13:39:40 +01:00
Amine Khaldi
2eb77351e0 [URLMON] Sync with Wine 3.0. CORE-14225 2018-01-20 13:29:39 +01:00
Amine Khaldi
0edcbac349 [TWAIN_32] Sync with Wine 3.0. CORE-14225 2018-01-20 13:17:45 +01:00
Amine Khaldi
b7250325e4 [SHLWAPI] Sync with Wine 3.0. CORE-14225 2018-01-20 13:15:19 +01:00
Amine Khaldi
b2462dae72 [SHDOCVW] Sync with Wine 3.0. CORE-14225 2018-01-20 13:14:14 +01:00
Amine Khaldi
90155f749f [RPCRT4] Sync with Wine 3.0. CORE-14225 2018-01-20 13:13:03 +01:00
Amine Khaldi
2bf764722b [RICHED20] Sync with Wine 3.0. CORE-14225 2018-01-20 13:09:57 +01:00
Amine Khaldi
95c3773f73 [PROPSYS] Sync with Wine 3.0. CORE-14225 2018-01-20 13:02:49 +01:00
Amine Khaldi
13fd286c18 [OLEAUT32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:59:23 +01:00
Amine Khaldi
2178977b54 [OLE32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:57:25 +01:00
Amine Khaldi
0506c9332a [MSXML3] Sync with Wine 3.0. CORE-14225 2018-01-20 12:35:17 +01:00
Amine Khaldi
d023d396ee [MSVIDC32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:33:41 +01:00
Amine Khaldi
76e5652fb4 [MSVFW32] Sync with Wine 3.0. CORE-14225 2018-01-20 12:31:50 +01:00
Amine Khaldi
f8b992f2d3 [MSI] Sync with Wine 3.0. CORE-14225 2018-01-20 12:29:30 +01:00
Amine Khaldi
a3eb2d3811 [MMDEVAPI] Sync with Wine 3.0. CORE-14225 2018-01-20 12:26:03 +01:00
Amine Khaldi
cea8085626 [USP10] Sync with Wine 3.0. CORE-14225 2018-01-20 12:17:14 +01:00
Thomas Faber
73e6bc960a
[COMCTL32] Unset the toolbar's hot item when deleting a button. CORE-14222
This fixes occasional crashes when hovering over disappearing tray icons.
2018-01-20 02:24:01 +01:00
Amine Khaldi
7821493171 [MPR] Sync with Wine 3.0. CORE-14225 2018-01-19 12:30:00 +01:00
Amine Khaldi
5e2c163f70 [MLANG] Sync with Wine 3.0. CORE-14225 2018-01-19 12:27:23 +01:00
Amine Khaldi
3381ee4b89 [JSCRIPT] Sync with Wine 3.0. CORE-14225 2018-01-19 00:45:08 +01:00
Amine Khaldi
08fb1fc8fe [ITSS] Sync with Wine 3.0. CORE-14225 2018-01-19 00:43:54 +01:00
Amine Khaldi
31fbc03b86 [INSENG] Sync with Wine 3.0. CORE-14225 2018-01-19 00:42:56 +01:00
Amine Khaldi
88221e598a [INETCOMM] Sync with Wine 3.0. CORE-14225 2018-01-19 00:39:56 +01:00
Amine Khaldi
fc87cf0bc3 [IMAGEHLP] Sync with Wine 3.0. CORE-14225 2018-01-19 00:37:52 +01:00
Amine Khaldi
c4b0f2155f [IEFRAME] Sync with Wine 3.0. CORE-14225 2018-01-19 00:36:36 +01:00
Amine Khaldi
d848f99bf9 [ICCVID] Sync with Wine 3.0. CORE-14225 2018-01-19 00:32:44 +01:00
Amine Khaldi
221fc8fd30 [HNETCFG] Sync with Wine 3.0. CORE-14225 2018-01-19 00:30:10 +01:00
Amine Khaldi
73921e9412 [HLINK] Sync with Wine 3.0. CORE-14225 2018-01-19 00:23:23 +01:00
Amine Khaldi
8d2d12d7ee [HHCTRL.OCX] Sync with Wine 3.0. CORE-14225 2018-01-19 00:21:29 +01:00
Amine Khaldi
007122e774 [GDIPLUS] Sync with Wine 3.0. CORE-14225 2018-01-19 00:17:41 +01:00
Amine Khaldi
975d9d4d4c [FUSION] Sync with Wine 3.0. CORE-14225 2018-01-19 00:10:53 +01:00
Amine Khaldi
f9c57f8489 [DBGHELP] Sync with Wine 3.0. CORE-14225 2018-01-19 00:09:29 +01:00
Amine Khaldi
736e16553a [CABINET] Sync with Wine 3.0. CORE-14225 2018-01-19 00:06:11 +01:00
Amine Khaldi
f1713a3c60 [AVIFIL32] Sync with Wine 3.0. CORE-14225 2018-01-19 00:04:19 +01:00
Amine Khaldi
9c96b06291 [ATL][ATL80][ATL100] Sync with Wine 3.0. CORE-14225 2018-01-19 00:01:06 +01:00
Amine Khaldi
b53d60cfc5 [COMDLG32] Sync with Wine 3.0. CORE-14225 2018-01-18 23:52:46 +01:00
Amine Khaldi
edd99e8ccc [COMCTL32] Sync with Wine 3.0. CORE-14225 2018-01-18 23:49:20 +01:00
Giannis Adamopoulos
4c23b78b5e [BROWSEUI] CISFBand: Handle DBID_SETWINDOWTHEME. CORE-14176 2018-01-16 11:50:51 +02:00
Mark Jansen
4a2ad113e5 [KERNEL32] Add version info to VerifyVersionInfo mismatch print. 2018-01-15 19:47:58 +01:00
Giannis Adamopoulos
7e9f56229f [UXTHEME] -Pass a non 0 wParam when themes get enabled and 0 when they get disabled 2018-01-15 12:57:08 +02:00
Giannis Adamopoulos
b8062bde5d [COMCTL32] rebar: Remove some hacks and fix checking for transparent background 2018-01-15 12:57:06 +02:00
Mark Jansen
1d4d88b062 [PSDK][ACTXPROXY] Add IExplorerCommand and related classes (Vista+) 2018-01-13 23:49:58 +01:00
Mark Jansen
e5f9029826
[BROWSEUI] Do not clear a CComPtr with memset. 2018-01-13 20:57:04 +01:00
Giannis Adamopoulos
6d9a0d0fd4 [SHELL32] CDrivesFolder: Fix showing the drive capacity. CORE-14201 2018-01-13 21:27:57 +02:00
Giannis Adamopoulos
5966a18e66 [COMCTL32] toolbar: Use the theme text color for the dropdown arrows. CORE-13855 2018-01-13 16:19:27 +02:00
Giannis Adamopoulos
5618b33c3b [SHELL32] CMenuBand: Redraw the toolbars if this is the menu bar of a window and its active state changed. Use COLOR_GRAYTEXT for the text of the inactive menu bar items. CORE-14197 2018-01-13 14:57:24 +02:00
Giannis Adamopoulos
f463ebe9e7 [COMCTL32] -toolbar: Improve drawing diabled text with themes. CORE-13855 2018-01-10 23:30:26 +02:00
Giannis Adamopoulos
789881672a [COMCTL32] status: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-10 15:52:42 +02:00
Giannis Adamopoulos
92732f1bcf [COMCTL32] rebar: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-10 13:44:32 +02:00
Thomas Faber
bf5e33201e
[MSAFD] Avoid magic numbers in NtCreateEvent calls. 2018-01-10 11:26:21 +01:00
Colin Finck
63a3a2cbb8
[KERNEL32] Accept all images for NT 3.1 and higher instead of bailing out at image versions > 5.01 (#273)
Print a debug message whenever an application newer than ReactOS' internal NT version is started.
This gets a simple "Hello World" compiled by VS' 2017 regular "v141" toolchain to run under ReactOS.

Please retry NT6+ applications!
2018-01-10 09:24:22 +01:00
Andreas Maier
387067ad29
[SETUPAPI]: Fix a FIXME in SetupDiSetDeviceRegistryPropertyA.
Rename SetupDiSetDeviceRegistryPropertyW to IntSetupDiSetDeviceRegistryPropertyAW and use it for both (A/W).
The FIXME in the A-Version was already implemented in the W-Version.

CORE-14173.
2018-01-09 18:51:12 +01:00
Thomas Faber
58f2c14c23
[ADVAPI32] Fix non-PCH build. 2018-01-08 09:51:15 +01:00
Mark Jansen
d0f3fa51fb [ADVAPI32] Stub OpenTrace and ProcessTrace so newer versions of ProcessExplorer start again.
CORE-10312
2018-01-07 22:29:17 +01:00
Erdem Ersoy
ba3f074320 [TRANSLATIONS] Update the email address and add a note in the Turkish translation document (#271) 2018-01-07 22:09:42 +01:00
Luo Yufan
59aa6b9e74 [TRANSLATION] Improve Simplified Chinese Translations (#265)
* Update Simplified Chinese translation of SYSSETUP
* Update Simplified Chinese translations and font settings.
* Update Translation of SHELL32.
2018-01-05 14:15:03 +01:00
Giannis Adamopoulos
a671923037 [SHELL32] CMenuToolbarBase: Use COLOR_MENUTEXT color for the text color in normal menu items. CORE-13855 2018-01-05 11:53:35 +02:00
Giannis Adamopoulos
695147eaac [COMCTL32] tab: Use DrawThemeText when drawing text with themes. CORE-13855 2018-01-04 23:27:48 +02:00
Giannis Adamopoulos
522601d050 [COMCTL32] toolbar: Draw checked and not hot buttons as checked, not hot. CORE-13592
Should be sent to wine.
2018-01-04 14:30:47 +02:00