Eric Kohl
a9da3c50be
[NETAPI] Implement NetGroupGetInfo
2018-09-09 09:40:11 +02:00
Eric Kohl
033146ca23
[NETAPI] Implement NetGroupEnum
2018-09-08 20:55:13 +02:00
Eric Kohl
0e69bc3bce
[SAMSRV] Fix SamrQueryInformationGroup
...
- Use the registry value AdminComment for admin comments instead of Description. Fix SamrSetInformationGroup as well.
- Add some TRACEs.
- Do not fail if the Members value does not exist.
2018-09-08 19:24:13 +02:00
Eric Kohl
df053b7d16
[MSV1_0] LsaApLogonUser: Update the logon time/count and bad password time/count
2018-09-05 00:10:54 +02:00
Eric Kohl
97382dee46
[MSV1_0] Use the account expiration time and check account expiration on logon
2018-09-04 23:15:15 +02:00
Eric Kohl
e25cbeba2f
[IDL] Implement parts of SamrSetInformationUser.UserInternal2Information
2018-09-04 22:42:49 +02:00
Eric Kohl
653a9be05b
[SAMSRV] Implement SamrQueryInformationUser.UserInternal2Information
2018-09-02 17:54:26 +02:00
Stanislav Motylkov
c7415b3faa
[MSGINA] Update russian translation ( #834 )
...
Addendum to 6f4d70b
.
2018-09-02 15:59:33 +02:00
Eric Kohl
6f4d70b405
[MSGINA] Display the 'account expired' message when a user tries to log on using an expired account.
2018-09-01 21:10:42 +02:00
Denis Malikov
69a040d275
[KERNEL32] fix spec file for -version=0x600+
...
CORE-12596
2018-09-01 17:21:21 +02:00
Pierre Schweitzer
2bd33d58d8
[KERNEL32] Shhhh!
2018-09-01 15:46:44 +02:00
Joachim Henze
e217e926e1
[SHELL32] Fix typo in comment
2018-08-28 14:24:49 +02:00
Mark Jansen
ffae49deaf
[COMCTL32] Unregister some classes that were registered.
...
This should help fix some crashes.
2018-08-27 19:49:57 +02:00
Katayama Hirofumi MZ
39dc3cdaf6
[SHELL32] Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. ( #824 )
...
CORE-14974
2018-08-27 12:21:51 +02:00
Mark Jansen
19e9a44118
[SHELL32] Check the result from PathUnExpandEnvStringsW
2018-08-27 11:58:29 +02:00
Mark Jansen
608cb60e44
[SHELL32] Remove some mostly dead code from CShellLink
2018-08-27 11:58:24 +02:00
Eric Kohl
fc2b4bc7ea
[LSASRV] LsapLogonUser creates an impersonation token for a network logon
2018-08-27 00:19:10 +02:00
Eric Kohl
a7b52d6a44
[SAMSRV] Simplify the initialization of the account expiration time
2018-08-27 00:12:44 +02:00
Eric Kohl
2fafcff3ef
[SAMLIB] Add stubs for SamTestPrivateFunctionsDomain and SamTestPrivateFunctionsUser
2018-08-27 00:11:21 +02:00
Eric Kohl
a9f2677782
[SAMSRV] Simplify the initialization of the account expiration date for new user accounts
2018-08-26 21:26:31 +02:00
Eric Kohl
dcc188e974
[NETAPI32] Add code to handle special values of the last logon time, last logoff time and account expiration time
2018-08-26 21:07:05 +02:00
Katayama Hirofumi MZ
6eb6aa2895
[SHELL32] Fix CShellLink::GetIconLocation ( #810 )
...
Fixes a regression from PR #784 .
CORE-14961, CORE-14009
2018-08-26 15:37:15 +02:00
Baruch Rutman
e7d2bbe726
[WIN32SS][LPK] Add BiDi support to menus and window captions ( #738 )
...
Added callback function that redirects calls to GreExtTextOutW that didn't went through lpk BiDi processing, calls that are from the kernel.
Completely solves JIRA issue CORE-6910.
2018-08-23 19:43:12 +02:00
Serge Gautherie
990e7dfd1a
[MSHTML] Fix 3 MSVC warnings about HTML*Element_handle_event()
...
- "...\htmlanchor.c(769) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlarea.c(427) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlform.c(757) : warning C4028: formal parameter 2 different from declaration"
Cherry-pick Jacek Caban a660f673cb
CORE-7538
2018-08-21 14:33:52 +02:00
Katayama Hirofumi MZ
73798d2e71
[SHELL32] Enable to change shortcut icon ( #784 )
...
CORE-11407
2018-08-21 13:49:32 +02:00
Robert Naumann
b3cfe88eda
[BROWSEUI] Show Tooltip text for 'Go' Button
...
-Patch by Barret Karish CORE-11058
2018-08-21 12:49:04 +02:00
Timo Kreuzer
36051d3065
[SYSSETUP] Fix handling of the status message window
...
This fixes a race condition, where the message thread was still running when InstallReactOS returned and syssetup.dll was unloaded by the caller (setup.exe).
2018-08-20 22:10:04 +02:00
Serge Gautherie
2e7b73dc75
[MSHTML] Fix an MSVC warning about HTMLInputElementImpl_fire_event()
...
"...\htmlinput.c(1303) : warning C4028: formal parameter 2 different from declaration"
Temporary fix, until WINESYNC replaces this function.
CORE-7538
2018-08-20 19:06:00 +02:00
Adam Słaboń
af3d426685
[TRANSLATION] Polish translation update ( #781 )
...
In addition: fix the encoding of the comdlg32 and ntvdm polish resource files.
2018-08-20 17:00:33 +02:00
Eric Kohl
91fab9e53b
[SETUPAPI] SetupDiGetDeviceRegistryPropertyW call CM_Get_DevNode_Registry_Property_ExW for properties that can not be retrieved from the registry
2018-08-20 00:16:18 +02:00
Stanislav Motylkov
844483504b
[KERNEL32] Implement system firmware functions properly
2018-08-19 20:27:59 +02:00
EUPHORIA-IT\m.jansen
bb5f8cfccb
[WSHOM.OCX] Zero-initialize timeout and type if they are not set.
...
This should fix buildbot timeouts
2018-08-19 16:14:08 +02:00
Eric Kohl
a8cf35d0e4
[SYSSETUP] SetupStartService: Remove the wait loop
...
CORE-14909
2018-08-19 14:32:29 +02:00
Eric Kohl
9a36ee8359
[WLNOTIFY] Use the wine debug method, add wlnotify to the build and fix some typos
2018-08-18 22:20:17 +02:00
Mark Jansen
cf56e1cb58
[GDIPLUS] Add sxs registration for 1.0 version.
...
Needed by by some applications with MSVCR90.dll
CORE-14695
2018-08-18 18:25:13 +02:00
Eric Kohl
df849213a2
[WLNOTIFY] Add SCard, Termsrv and Wlballon notifications and remove the test notifications
2018-08-18 16:18:36 +02:00
Timo Kreuzer
094a90ad4e
[NTOS:PS] Fix an issue with PROCESS_DEVICEMAP_INFORMATION size on 64 bit builds
...
The PROCESS_DEVICEMAP_INFORMATION union has 2 fields, one is a handle, the other one is a structure of 36 bytes (independent of architecture). The handle forces 64 bit alignment on 64 bit builds, making the structure 4 bytes bigger than on 32 bit builds. The site is checked in NtQueryInformationProcess (case ProcessDeviceMap). The expected size on x64 is the size of the Query structure without alignment. autocheck correctly passes the site of the Query union member, while smss passes the full size of PROCESS_DEVICEMAP_INFORMATION. Packing the structure is not an option, since it is defined in public headers without packing. Using the original headers sizeof(PROCESS_DEVICEMAP_INFORMATION) is 0x28, sizeof(PROCESS_DEVICEMAP_INFORMATION::Query) is 0x24.
2018-08-17 22:08:37 +02:00
Joachim Henze
abf9340f1b
[SHELL32] Translation de-DE CORE-14916
...
fix control overlapping in IDD_FOLDER_OPTIONS_FILETYPES
(broke in 0.4.10-dev-24-ed1c6bb0060d06f4c0167d9c2d732f4dc2b4cce4)
and translate IDD_NEWEXTENSION, IDD_EDITTYPE, IDD_ACTION, IDD_FOLDER_CUSTOMIZE
2018-08-17 18:07:35 +02:00
Serge Gautherie
2ad650469e
[OLEAUT32] Fix an MSVC warning about VarCyMul()
...
"...\vartype.c(3808) : warning C4028: formal parameter 2 different from declaration"
Mininal cherry-pick Alexandre Julliard 18f7ec3670
CORE-7538
2018-08-17 16:18:41 +02:00
Getequ
d559ca9c98
[ADVAPI32][SHELL32][DESK.CPL] Kill copy-paste of RegLoadMUIString. ( #748 )
...
RegLoadMUIStringW/A is part of advapi32.dll . shell32.dll and desk.cpl contained exact line-by-line copy of that function.
2018-08-16 16:10:41 +02:00
Katayama Hirofumi MZ
6d9f89f813
[SYSSETUP] Fix the button sizes of theme selection dialog ( #746 )
...
CORE-14896
2018-08-15 18:32:17 +02:00
Mike Swanson
3c7e9bb332
Remove unnecessary executable bits
2018-08-15 18:29:09 +02:00
Mark Jansen
9b6fb9f2f8
[RTL][KERNEL32] Add a comment indicating we need SEH in RtlImageNtHeaderEx
...
CORE-14532
CORE-14857
2018-08-13 13:24:12 +02:00
Eric Kohl
956086d369
[NETAPI32] Add DFS RPC interface and some DFS stubs
2018-08-12 14:31:07 +02:00
Katayama Hirofumi MZ
db13b422b3
[SHELL32] Fix a careless mistake of ShellExecCmdLine ( #737 )
...
CORE-14886
2018-08-10 13:25:50 +02:00
Eric Kohl
fb5d5ecd64
[WLNOTIFY] Add sens service stubs
2018-08-07 22:56:33 +02:00
Hermès Bélusca-Maïto
40000a1716
[WINLOGON][MSGINA] Fix typo.
2018-08-06 17:37:38 +02:00
Eric Kohl
8f911f21b8
[SYSSETUP] SetupStartService: Wait until the service is running
2018-08-05 20:02:22 +02:00
Eric Kohl
5ebcc6cdc1
[ADVAPI32] Add parameter checks to LogonUserExW and initialize the token handle.
2018-08-05 16:16:53 +02:00
Eric Kohl
b4040ea740
[NETAPI32] Implement I_NetServerSetServiceBits()
2018-08-05 15:57:03 +02:00
Eric Kohl
89f6e701d4
[NETAPI32] Add annotations and move NetUseGetInfo to a better location.
2018-08-05 15:36:48 +02:00
Katayama Hirofumi MZ
bfcbda227f
[SHELL32] Fix handling of multiple parameters in the 'Run' dialog ( #665 )
...
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.
- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.
CORE-14790
2018-08-05 13:39:17 +02:00
Eric Kohl
4e32ad3623
[LSASRV] Implement and call the policy change notification routine
2018-08-05 01:05:52 +02:00
Eric Kohl
620217cec9
[LSASRV][SECUR32] Implement LsaRegisterPolicyChangeNotification and LsaUnregisterPolicyChangeNotification
2018-08-04 22:17:52 +02:00
Timo Kreuzer
0f8439aa71
[DLLS] Fix 64 bit issues
2018-08-04 19:19:34 +02:00
Timo Kreuzer
52ea7d39db
[SHELL32] Fix 64 bit issues
2018-08-04 19:19:34 +02:00
Timo Kreuzer
4f0a158a2f
[KERNEL32] Fix 64 bit issues
2018-08-04 19:19:34 +02:00
Julio Carchi
d7559e2354
[TRANSLATIONS] Fix spanish translations for some resources ( #725 )
...
Setup wizard
Network settings wizard
Input CPL
Open file dialogs
Devmgr
Explorer
2018-08-03 15:08:13 +02:00
Stanislav Motylkov
d956eafda8
[KERNEL32] Implement System Firmware functions
...
- Implement EnumSystemFirmwareTables
- Implement GetSystemFirmwareTable
These functions currently using registry workaround and can be improved later.
CORE-12105
2018-08-02 21:15:28 +02:00
Julio Carchi
d3045af9d5
[TRANSLATIONS] Fix some Spanish translations ( #715 )
...
Also added some new ones.
2018-07-31 10:58:21 +02:00
Eric Kohl
bf1e655172
[ADVAPI32] Stop the service dispatcher thread only if a SERVICE_CONTROL_STOP command was sent
2018-07-29 23:40:36 +02:00
Hermès Bélusca-Maïto
74adcadbd0
[SHELL32] Silence a noisy DPRINT.
2018-07-29 17:39:09 +02:00
Eric Kohl
24cd7bbe0b
[RPCRT4] Update the support for remote pipes which was dropped by the sync to Wine Staging 2.9 and update rpcrt4_ros.diff accordingly
2018-07-29 07:30:43 +02:00
Baruch Rutman
65a5a989c5
[LPK] Changes ( #622 ).
...
- Changed how the ScriptIsComplex check is made to account direction, most noticeble on dxdiag,
https://docs.microsoft.com/en-us/windows/desktop/api/usp10/nf-usp10-scriptiscomplex
However commented out the ScriptIsComplex flag change because of a bug.
- Added a check and debug print if BIDI_Reorder fails.
2018-07-27 00:47:48 +02:00
Baruch Rutman
e054a053ff
[LPK] Added more error handling code ( #622 ).
...
- Added a codepath if both glyphs and reordered_str arrays are NULL.
- Move variables back to the beginning of function.
CORE-14732
2018-07-27 00:47:28 +02:00
Baruch Rutman
7fe6a14ede
[LPK] Diverse fixes ( #622 ).
...
- Changed wcspy to strsafe function.
- Use GetCharWidthI instead of GetCharWidth32W if dealing with glyph indices.
2018-07-27 00:47:14 +02:00
Baruch Rutman
33d3e56cf4
[LPK] Refactoring ( #622 ).
...
- Moved lpDx and lpGlyphs operations to seperate brackets.
- lpGlyphs == NULL checks + memory managment additions.
CORE-14732
2018-07-27 00:46:02 +02:00
Hermès Bélusca-Maïto
2158f31b71
[KERNEL32] Use RtlStringCbCopyNW() to correctly fill the WIN32_FIND_DATA.cFileName and cAlternateFileName members without any overflow and with a terminating NULL character.
2018-07-22 21:32:38 +02:00
Serge Gautherie
246005c625
[WINDOWSCODECS] Fix an MSVC warning about get_decoder_info() ( #684 )
...
"...\info.c(2163) : warning C4028: formal parameter 1 different from declaration"
Cherry-pick 90518ebd2c
CORE-7538
2018-07-14 02:50:23 +02:00
Katayama Hirofumi MZ
75b09f3f88
[EXPLORER][SHELL32][USER32] Implement 'Show the Desktop' action of Task Bar ( #668 )
...
The keyboard shortcuts Win+D and Win+M are also enabled.
- Implement IShellDispatch4::ToggleDesktop().
- Implement some commands in CTrayWindow.
- Add "sdk/include/reactos/traycmd.h" for tray commands.
- Fix task window switching.
- Improve the user32!SwitchToThisWindow() function and use it.
CORE-14318, CORE-13157
See also: CORE-14806 and CORE-8723
2018-07-13 10:34:42 +02:00
Katayama Hirofumi MZ
e018ccea4b
[SHELL32] lpDirectory must have priority in ShellExecuteEx ( #681 )
...
Based on a patch by Mark Jansen.
CORE-14469
2018-07-12 17:45:43 +02:00
Katayama Hirofumi MZ
55469633cf
[SHELL32] Add 'Properties' menu item in My Computer ( #647 )
...
- Add a Shell_DefaultContextMenuCallBack() helper function.
- Implement the IContextMenuCB interface in CDrivesFolder.
CORE-12509
2018-07-08 17:01:12 +02:00
Katayama Hirofumi MZ
96c0ef4209
[SHELL32] Improve CShellLink a little ( #651 )
...
Improve the display and UI in the shortcut dialog.
CORE-11407
2018-07-08 16:45:40 +02:00
Katayama Hirofumi MZ
a882ec7a02
[SHELL32][EXPLORER] Update system-wide environment variables ( #663 )
...
- Implement shell32 RegenerateUserEnvironment() function and use it.
- CShellBrowser and CDesktopBrowser implements WM_SETTINGCHANGE actions.
CORE-1459, CORE-14397
2018-07-08 16:32:42 +02:00
Hermès Bélusca-Maïto
c7022c1b0c
[KERNEL32] Use NULL for pointers.
2018-07-07 18:58:03 +02:00
Mark Jansen
3904fd6257
[SHELL32] Ensure OpenAs_RunDLL does not loop to infinity and beyond.
...
This should fix a timeout on the apitests.
2018-07-06 21:51:24 +02:00
Timo Kreuzer
e39876dab7
[SDK] Fix 64 bit issues
2018-07-01 14:45:21 +02:00
Hermès Bélusca-Maïto
b7c4c4dc79
[COMDLG32] Add the missing NEWFILEOPENV2ORD dialog resource, whose absence made all of the Open/Save-file dialogs not displaying anymore.
...
This was a regression from last Wine (Staging) 3.9 sync (f68b0c51
) that
introduced the usage of this new dialog.
To do: Properly generate the dialog localization.
CORE-14656, CORE-14674, CORE-14689, CORE-14769
2018-07-01 00:44:48 +02:00
Hermès Bélusca-Maïto
2afb483a9e
[SHELL32] Shell Profile Folders fixes.
...
- Fix a regression introduced in r65415 (1795a3bf
) where the directory
paths stored in "Windows\CurrentVersion\Explorer\User Shell Folders"
were stored in expanded format instead of in unexpanded format:
_SHGetDefaultValue() *MUST* return unexpanded paths by design!!
- Augment _SHExpandEnvironmentStrings() and _SHGetUserShellFolderPath()
to take a user token handle to be able to correctly resolve/expand
user-specific directory paths.
- Fix _SHExpandEnvironmentStrings() so that it always retrieve the
correct current user / all-users directory paths by calling userenv
functions, instead of hardcoding a broken logic. As a result this
removes the "C:\Documents and Settings\SYSTEM" ghost directory we got
during ReactOS installation.
- Delimit the changes with respect to Wine by #if(n)def __REACTOS__ .
2018-06-30 18:20:08 +02:00
Stanislav Motylkov
73aa420f0e
[SHELL32] Update russian translation
...
CORE-11407
2018-06-30 01:15:41 +02:00
Stanislav Motylkov
707f2ed360
[SHELL32] Fix some elements positions and styles
...
Addendum to eb1912b
. CORE-11407
2018-06-30 01:15:41 +02:00
Katayama Hirofumi MZ
e353b48cb2
[SHELL32] Refresh 'General' tab if the folder icon is updated ( #646 )
...
CORE-11407
2018-06-29 14:13:37 +02:00
Katayama Hirofumi MZ
eb1912b15f
[SHELL32] Initial implementation of Folder Customization ( #642 )
...
- Add property sheet;
- Implement changing the folder icon.
CORE-11407
2018-06-28 21:51:37 +02:00
Serge Gautherie
3766d836c7
[DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() ( #643 )
...
- Fixes MSVC errors: "...\dll\win32\dbghelp\minidump.c(857) : error C4028: formal parameter 5 different from declaration", for parameters 5, 6 and 7.
- Fix spec file too.
CORE-7538
2018-06-28 17:44:49 +02:00
Hermès Bélusca-Maïto
a9eda8f492
[LSASRV] Enable SE_CREATE_TOKEN_PRIVILEGE in LSASS since one of our purposes is to create access tokens -- NtCreateToken() requires this privilege.
2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto
c901c3d37f
[LSASRV] Move the LSA_RPC_SERVER_ACTIVE event creation to a better place, in LsarStartRpcServer().
2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto
0208a4d196
[LSASRV] Add the SE_GROUP_OWNER attributes to the token owner.
2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto
cf56db2eb3
[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status fixup in the assignment loop as done in the allocation loop.
...
This avoids this function returning failure while everything actually succeeded.
2018-06-27 23:40:13 +02:00
Hermès Bélusca-Maïto
62384951c8
[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid pointer to a valid but empty privilege structure to NtCreateToken(), as it always want a non-NULL pointer.
2018-06-27 23:40:12 +02:00
Hermès Bélusca-Maïto
d4b4da5385
[ADVAPI32] Additions for CreateProcessAsUserA/W().
...
- Use a common helper function used by both the ANSI and UNICODE functions
so that the large code block that deals with setting the new process token
becomes automatically common to both these functions, while the ANSI vs.
UNICODE conversions are handled directly via the CreateProcessA/W() calls.
- Duplicate the token and acquire the process primary token assignment
privilege before calling NtSetInformationProcess().
2018-06-27 23:40:07 +02:00
Katayama Hirofumi MZ
3189ec9428
[SHELL32] Add missing desktop.ini files ( #640 )
...
Add the "desktop.ini" files to the special folders to realize their custom icons.
CORE-10045
2018-06-27 23:11:31 +02:00
Katayama Hirofumi MZ
c74bd5d662
[SHELL32] Enable custom CD/DVD icons ( #639 )
...
Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766
2018-06-27 23:06:54 +02:00
Bișoc George
23881cfcf3
[NEWDEV] Fix a truncated text
2018-06-25 13:55:19 +02:00
Russell Johnson
6a683dc6d8
[SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() ( #635 )
...
Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.
CORE-12340
2018-06-24 20:29:57 +02:00
Katayama Hirofumi MZ
1b1e1baa6e
[SHELL32] Implement Folder Options File Types 'Change' button ( #629 )
...
CORE-12906
2018-06-24 20:04:25 +02:00
Katayama Hirofumi MZ
6e6c46a832
[BROWSEUI] Re-enable the "Folder Options" menu item ( #630 )
...
It was originally disabled in r71192 (8b77c254
).
CORE-11141
2018-06-24 20:02:36 +02:00
Katayama Hirofumi MZ
1829f5fed7
[SHELL32] Fix desktop.ini folder icon again (retrial of #595 ) ( #632 )
...
#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196
2018-06-24 19:59:03 +02:00
Katayama Hirofumi MZ
cc8b2717ae
[SHELL32] Implement OpenAs_RunDLLA/W ( #628 )
...
CORE-14751
2018-06-24 19:46:06 +02:00
Abdulganiev Rafael
824a52aa99
[TRANSLATION][SHELL32] Update Russian translation ( #633 )
2018-06-24 19:42:34 +02:00
Katayama Hirofumi MZ
a33908b60f
[SHELL32] Improve French Folder Options
2018-06-23 10:51:48 +02:00