Commit graph

99 commits

Author SHA1 Message Date
Katayama Hirofumi MZ 0a8fb87d84 [COMCTL32] IP Address controls follow-up of #3212 (3f30b1e)
The rightest field didn't work Left arrow key.

CORE-3479
2020-09-25 15:32:58 +09:00
Katayama Hirofumi MZ 3f30b1eda7
[COMCTL32] Improve IP Address Controls (Tab and caret) (#3212)
Improve IP address controls.
- Set focus to EDIT control to show caret.
- Process WM_GETDLGCODE messages on EDIT control to catch Tab key.
- Process Tab key and Shift+Tab key in processing WM_KEYDOWN.
CORE-3479
2020-09-23 08:32:40 +09:00
Katayama Hirofumi MZ 8c87489a43
[COMCTL32][SHELL32] Fix arrow keys and reordering on ListView (#3162)
- Disable special auto-arrange codes in LISTVIEW_GetNextItem function.
- Add auto-arrange reordering codes on CDefView.
CORE-16875
2020-09-17 22:18:34 +09:00
Joachim Henze 7c909cbc7c [COMCTL32] Addendum to last commit
Sorry, something went terribly wrong with the CORE-ID
in my head 2 times, one time in the commit comment
and one time in the code!

Addendum to 0.4.15-dev-663-g
cd7db5df89
2020-08-28 01:02:00 +02:00
Joachim Henze cd7db5df89 [COMCTL32] Workaround regression with toolbar in 7zip CORE-16996
The regression was introduced by SVN r68553
3b13364f05

Many thanks to the author Doug Lyons for excellent
cooperation once more. Always a pleasure.
2020-08-28 00:53:18 +02:00
Jose Carlos Jesus 887764e607
[COMCTL32] Fix issue on showing current mouse pointer (#2829)
GetIconInfo() fill info.hbmColor with NULL HBITMAP handle on black/white bitmaps.

CORE-17062
2020-08-16 18:42:12 +03:00
Amine Khaldi 139a3d6661
[CMAKE] Implement PCH builds with target_precompile_headers. CORE-16905 2020-06-06 21:58:41 +03:00
Julen Urizar Compains 546862babc
[TRANSLATION] Update Spanish, and add Basque translation (#2667)
Add/update translation for:
charmap_new, logoff, mspaint, notepad, usetup, welcome,
hotplug.cpl, sysdm.cpl, aclui.dll, comctl32.dll, comdlg32.dll,
hhctrl.ocx, kernel32.dll, msi.dll, oledlg.dll, shell32.dll,
tapiui.dll, themeui.dll, wininet.dll, winmm.dll, wldap32.dll,
winsrv.dll.
2020-05-17 18:46:36 +02:00
Jose Carlos Jesus 2bd6bfdd90
[COMCTL32] Fix recalculation of property-sheet dialog position (#1818)
During initialization of property sheet dialogs, their overall size can change (when adding property sheets) after the dialog has been created and pre-positioned by win32k.
Therefore their position needs to be recomputed so that they try to fit the best on screen.

CORE-9008, CORE-9602
2020-05-15 18:12:02 +02:00
Kyle Katarn 295ba62820
Fix of comdlg32 Treeview undue handling of WM_SYSKEYDOWN (#2731)
Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...)
Early embodiement of the fix proposed to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functionnal limitation in ReactOS. CORE-17020
2020-05-09 21:37:26 +09:00
Katayama Hirofumi MZ 413d722628
Revert "Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)" (#2758)
This reverts commit 66b0a48a75.
2020-05-09 15:32:15 +09:00
Katayama Hirofumi MZ 66b0a48a75
Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)
This reverts commit 2d4d3f5fce.

Reverts #2146. I think #2135 (e329e83) and #2146 (2d4d3f5) are my mistakes.
CORE-16552, CORE-16747
2020-05-09 11:30:11 +09:00
Charles Ambrye 733a32dade [LISTVIEW] Add basic support for LVS_EX_SNAPTOGRID 2020-04-20 23:13:09 +03:00
Charles Ambrye 963d39bf66 [COMCTL32] Implement a simple version of snap to grid for listview 2020-04-17 13:23:29 +03:00
Charles Ambrye 08364d08c7 [COMCTL32] Do not allow user to move icons when in auto-arrange mode 2020-04-17 13:23:29 +03:00
Hervé Poussineau 5ed1867632 [CMAKE] Add some -D__ROS_LONG64__ to please gcc x64
We can now pass a UINT* to a function wanting a DWORD*
2020-03-26 16:39:16 +01:00
Mas4hmad 228eeb7d79 [TRANSLATION] Update Indonesian Translation (#2268)
- Update Indonesian translation for:
  BROWSEUI.DLL, COMCTL32.DLL, DEVMGR.DLL, IEFRAME.DLL, NETID.DLL, SHELL32.DLL,
  SYSSETUP.DLL, TIMEDATE.CPL, APPWIZ.CPL, ACCESS.CPL, DESK.CPL and TASKMGR.EXE.

- Add Indonesian translation for: MSHTML.DLL, OLEAUT32.DLL, INPUT.CPL and NTVDM.EXE.
2020-01-26 18:29:38 +01:00
Mark Jansen ea35843c30
[COMCTL] Use DIALOG instead of DIALOGEX resources
This is needed, because property sheets can modify the dialog resource,
and example code (and some existing applications) expect DIALOG.
One such application is the VB6 setup.
CORE-16650
2020-01-25 12:58:27 +01:00
Katayama Hirofumi MZ 2d4d3f5fce
[COMCTL32][USER32] Fix radio button regression (#2146)
PR #2135 (e329e83) caused radiobutton regression. This PR will fix it.
- Clear DT_BOTTOM | DT_VCENTER flags upon calculating the button text height.
CORE-16552
2019-12-10 11:07:56 +09:00
Serge Gautherie 27502f5c51 [COMCTL32] Minimize Wine diff (#2035)
Addendum to b931f643e3.

CORE-16466
2019-11-27 07:27:21 +09:00
Tibor Lajos Füzi 352b2410cc [TRANSLATION] Add/update Hungarian translation for comctl32, samsrv, syssetup (#2036) 2019-11-15 00:12:25 +01:00
Joachim Henze f9e4d81056 [COMCTL32] Beautification addendum CORE-16466
I overlooked those missing white-spaces in
0.4.14-dev-312-g
b931f643e3

No functional change.
2019-11-13 01:22:00 +01:00
Joachim Henze b931f643e3 [COMCTL32] Fix listview scrollbars flashing CORE-16466
Many Thanks to patches author JIRA user 'I_Kill_Bugs',
but also to Doug Lyons and Fabian Maurer.

Unhidden by SVN r75735 == git 0.4.7-dev-168-g
6af37fd54e

I will merge that back into 0.4.13-RC as well.
2019-11-13 00:30:00 +01:00
James Tabor d96f24e384 [ComCtl32] Fix Build 2
Part 2
2019-11-06 21:29:56 -06:00
James Tabor 680d63eed3 [ComCtl32] Fix Build
Add missing header.
2019-11-06 20:50:32 -06:00
James Tabor 040c0c8376 [ComCtl32] Properly handle WM_CTLCOLOR* messages.
Patch by Fabian Maurer : Properly handle WM_CTLCOLOR* messages.

See CORE-15560 and
https://source.winehq.org/git/wine.git/?a=commit;h=1dc3ec2cdc83da0c1cab96f2dc61b2c917fd1e29
.
2019-11-06 20:29:28 -06:00
Amine Khaldi 00f14ee1f2 [COMCTL32] Sync listview.c and progress.c with Wine Staging 4.18. CORE-16441 2019-10-26 22:51:10 +01:00
Joachim Henze f2f833c53c [COMCTL32] Address regression CORE-14622
"Avira Antivir Personal 6.35.00.243" had issues painting its
setup wizard dialog with correct background color.
That part was a regression of SVN r74136 == git
b1b42795a9

and also did not draw its umbrella bmp, which did never work
in ros up to now afaik.

https://reactos.org/testman/compare.php?ids=69394,69478 VBOX
https://reactos.org/testman/compare.php?ids=69395,69479 KVM

Thanks to patches author Doug Lyons and HBelusca.

Wine has been reported to be affected by that bug as well:
https://bugs.winehq.org/show_bug.cgi?id=46636
Not sure whether our patch will be accepted by Wine,
to my naive eye this looks like an interim solution.
2019-10-22 01:10:28 +02:00
Joachim Henze a40331b0f4 [COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147

But greatly eliminates perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.

I committed the same workaround already into 0.4.12-RC-30-g
9513c9bf12

CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de714c

CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476074
2019-09-22 21:17:10 +02:00
Joachim Henze 841732e45c [COMCTL32] Updown Suppress the NM_RELEASEDCAPTURE notification CORE-14365
This fixes a strange toggle-back-effect in 'Zeckensacks Glide Wrapper 0.84c'
by importing Wine commit
9dbe886e3f
Thanks to patches author Akihiro Sagawa <sagawa.aki@gmail.com>
2019-09-20 20:13:09 +02:00
Mark Jansen c2b9f94234
[COMCTL32] imagelist: Invalidate the cookie of a destroyed imagelist
CORE-16316
CORE-16275
2019-08-19 21:25:07 +02:00
Katayama Hirofumi MZ 344d559935
[COMCTL32] Unchange the property sheet page after WM_INITDIALOG (#1842)
In my testing on Win2k3, EN_CHANGE is generated in OnInitDialog, that is correct. The target is property sheet. The property sheet does unchange the page after WM_INITDIALOG generation. CORE-16280
2019-08-17 20:02:57 +09:00
Andreas Maier 2b5f38295b [COMCTL32] remove unused theme_*.c files. 2019-08-17 12:08:04 +02:00
Jose Carlos Jesus 0b4510301b
[SHELL][COMCTL32] pt_PT_Translation Improvements 2019-08-16 19:32:23 +02:00
Andrew Boyarshin 0a84597679
[COMCTL32] Export LoadIconMetric and LoadIconWithScaleDown
They are already implemented and there is little sense for them to be hidden.
Required for ProcessHacker 3.0+.
2019-08-16 18:31:07 +02:00
Waritnan Sookbuntherng 76dfa2b284 [COMCTL32] Checking size grip bounds in x-axis only 2019-08-16 16:22:24 +02:00
Waritnan Sookbuntherng b9ddad0bbb [COMCTL32] Hide size grip when the parent window is maximized 2019-08-16 16:22:24 +02:00
Andreas Maier 4093681ad0 [COMCTL32] Saturated images: Take mask-images in account.
This fixes CORE-14209 - Some icons not drawn in IDA Free
2019-08-15 21:11:45 +02:00
Andreas Maier 49a797543f [COMCTL32] Improve failure cases. 2019-08-15 21:11:45 +02:00
Timo Kreuzer ad89837c0e [3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code 2019-08-15 15:24:12 +02:00
Andreas Maier 49165276f2 [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) (#1674)
* [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression)

Fix cb_states / rb_states lookup table.

* [README.WINE] comctl32 is synced to WineStaging-3.3.

See commit b3fb8555 .
2019-06-22 16:36:14 +02:00
Mas Ahmad Muhammad 859199ee16
[COMCTL32] Add Indonesian translation. 2019-06-20 17:31:49 +02:00
Jose Carlos Jesus 4bbeb21f6d
[COMCTL32] Update Portuguese (neutral) translation. 2019-06-20 17:15:15 +02:00
Giannis Adamopoulos cc25a266f2 [COMCTL32] imagelist: Make the exported functions use the internal IImageList2
- Add a hack to rename the exported functions and use the Internal_ prefix for them so that the IImageList can use them with minimal code changes.
- Add the correct implementation of the affected exported functions making them now use the IImageList of the passed HIMAGELIST.

This indirection is possible because an HIMAGELIST is also a IImageList*.
This indirection is also needed because we can end up using image lists created by either comctl32 v5 or comctl32 v6.
This is how windows manage to use an HIMAGELIST created by comctl32 v5 when it is passed to comctl32 v6.
What really happens in this scenario is that the exported functions of both versions end up using the interface
stored in the object without checking if this interface is the version provided in the same dll or in the other.
2019-06-12 19:20:44 +03:00
Thomas Faber 6122f3f436
[COMCTL32] Remove an unnecessary include. 2019-04-14 14:35:29 +02:00
Joachim Henze b71429059a [COMCTL32] Improve status bar margin for unthemed and themed CORE-15834
Improve further what was recently committed in
0.4.12-dev-361-g
da9accfba6
2019-04-07 15:15:25 +02:00
Jérôme Gardou 23373acbb9 [CMAKE] Use modules instead of shared libraries
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.

On my system, this reduces the configure-time by a factor of two.
2019-04-06 17:43:38 +02:00
Stanislav Motylkov cd7011388e [COMCTL32] Edit: Fix caret and scroll position
Based on patch by JIRA contributor 'I_Kill_Bugs'. CORE-15780
2019-03-24 23:26:20 +01:00
Hermès Bélusca-Maïto 780f2ba215
[USER32][COMCTL32] Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
CORE-8526

Import Wine commit:
96d0af52eb

"user32: Move the auto radio button group logic from BM_SETCHECK to WM_LBUTTONUP handler.
This patch also changes the logic to get the control style with WM_GETDLGCODE
instead of GetWindowLong to make the message test pass.
"
by Dmitry Timoshkov.
See bug report https://bugs.winehq.org/show_bug.cgi?id=42010

- (ReactOS-only) Fix also the corresponding logic in COMCTL32.
2019-03-24 17:23:24 +01:00
Stanislav Motylkov 56ccf8d832 [COMCTL32] Edit: Fix rectangle overflow when inserting characters
Based on patch by JIRA contributor 'I_Kill_Bugs'. CORE-11475
2019-03-23 15:52:43 +01:00