Commit graph

71945 commits

Author SHA1 Message Date
Pierre Schweitzer 07a13ca67c [0.4.9] cherry-pick [FASTFAT] Properly queue pending write IRPs.
Addendum to 30b836b

(cherry picked from commit e9e14be661)
2018-05-26 14:12:29 +02:00
Pierre Schweitzer 4af12f40ca [0.4.9] cherry-pick [FASTFAT] When extending a file, also lock the DirResource.
This avoids race conditions under high IOs and thus corruption on
the FS, or assertions failures in the kernel.
Easily triggered by building ReactOS on ReactOS ;-).

(cherry picked from commit 30b836bf3f)
2018-05-26 14:12:22 +02:00
Joachim Henze a04d7c300e [0.4.9] [WINE DIRECTX] Sledge-hammer-revert to avoid CORE-14534
This commit reverts
dll/directx/wine/* and
sdk/include/reactos/wine/wined3d.h
to the state of 0.4.8rls.

The current state of Ddraw without this revert is totally broken,
so we need this interim solution. I will happily replace it with
a proper fix if someone finds one until release.
2018-05-21 17:14:08 +02:00
Joachim Henze 4de8a0d96f [0.4.9] revert [NTDLL/LDR] Overhaul sxs work
This reverts commit 0.4.8-dev-502-g
7000fe2340.

This reverts commit 0.4.8-dev-503-g
f318a25e10.

The two changes were done once to work towards better
shim-supporting APIs of newer Windows versions on demand
in the future. Luckily we do not depend on them yet.

Giannis already fixed most regressions of the 2 commits
before branching 0.4.8RC (e.g. 2nd stage theme-selector).

Unfortunately we still have issues atm with the existing mixture
of Wine comctl32 v5 vs v6.
The image-lists of both are not compatible as Giannis told us.

We revert both commits for this release to fix CORE-14433
(missing icons due to incompatible image-lists). We can not
simply add a manifest here, because 3rd party apps are affected.

I double-checked, all of those (formerly affected) apps
are working fine and show the icons after the revert:
2nd-stage-theme-selection, MS Excel Viewer 2007 open-dlg,
MSVCPP 6 installer open-dlg, FaxViewer save-dlg,
MS Word Viewer 2003 open-dlg

This revert also obsoletes works/fixes like
2f11904000.

(cherry picked from commit 11bf8fa047)
2018-05-20 23:40:47 +02:00
Joachim Henze ad20c37358 [0.4.9] [SETUPAPI] Apply yet uncommitted fix for CORE-12616 PR-408
This commit was *not* committed to master yet.
I'll leave the ticket unresolved until it'll be.

This fixes a regression introduced in SVN r73442:
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.

This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.

There are ongoing discussions about an alternative approach
to the initial problem that SVN r73442 tried to address.
Serge Gautherie can and shall be evaluate that alternative
later during 0.4.10dev.

For now many thanks to Carlo Bramini for this fix.

(cherry picked from commit dba2f743c5)
2018-05-20 22:50:15 +02:00
Joachim Henze 4127f70e94 [0.4.9] [RDBSS] avoid CORE-13938
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.

(cherry picked from commit 1906186e83)
2018-05-20 22:49:26 +02:00
Joachim Henze 6ce8028f87 [0.4.9] [AFD] Apply unfinished patch to avoid BSODs CORE-14048 & CORE-12520
Fixes BSODs when starting Deluge Torrent 1.3.12.1 & QBitTorrent 3.2.0
due to running "Out of NP Expansion Pool"

This patch is still WIP of ThFabba.

like in 0.4.8 before

(cherry picked from commit 6b8b704e6f)
2018-05-20 22:48:46 +02:00
Joachim Henze c19ce9549a [0.4.9] [USP10] Apply unfinished patch to avoid CORE-14226
Thomas linked the patch in Wine Bug 44410
I tested it for some weeks without noticing any side-effects.
It avoids text rendering regressions in some setups like UltraISO

like in 0.4.8 before

(cherry picked from commit 937c2615e6)
2018-05-20 22:47:53 +02:00
Thomas Faber f926d742d5 [0.4.9] Revert r73436 to avoid trouble with VirtualBox Guest Additions. CORE-13172 CORE-12700 CORE-12765
like in 0.4.8 before

(cherry picked from commit 766ef24948)
2018-05-20 22:47:19 +02:00
Joachim Henze 7f96f90110 [0.4.9] [CDFS_NEW] Mute continuable assertion to avoid CORE-14067
like in 0.4.8 before

(cherry picked from commit 51f9494d48)
2018-05-20 22:46:42 +02:00
Thomas Faber d46570474a [0.4.9] cherry-pick [WIN32SS] Mask WndProc exceptions to hide all tickets linked to CORE-11915
e.g. this allows using MsDepends

(cherry picked from commit 9274859438)
cherry-picked by Joachim Henze
2018-05-20 21:31:53 +02:00
Joachim Henze e7e831a6ff [0.4.9] Branch releases/0.4.9 & change KERNEL_VERSION_BUILD_TYPE "RC"
as first commit before! adding the git-tag
2018-05-20 20:31:06 +02:00
Hermès Bélusca-Maïto ddd03a8973
[CMD] Use string-safe call to build the new console title (possibly truncated, we don't care), avoiding any buffer overflow. Caught by David Quintana. 2018-05-20 19:57:43 +02:00
Hermès Bélusca-Maïto 7b618314c2
[USETUP] Remove now-unneeded file. 2018-05-20 19:27:57 +02:00
Hermès Bélusca-Maïto cb679a8917
[BOOTDATA] Set the 'BootExecute' SMSS value to an empty value as we do not want AutoChk to start when booting the LiveCD. CORE-14633
Add also a missing closing quote.
2018-05-20 18:34:35 +02:00
Hermès Bélusca-Maïto edc0aeb5a8
[SETUPAPI] Fix MSVC build; pathetic GCC/LD didn't see we were using two different prototypes for these functions. 2018-05-20 15:32:06 +02:00
Pierre Schweitzer a10f6c7a0c
[FASTFAT] Fail if allocating the stream FO fails. 2018-05-20 13:53:43 +02:00
Eric Kohl b250eb5f3e [SAMSRV] SamrChangePasswordUser: Check StoredLmEmpty and StoredNtEmpty instead of checking StoredNtEmpty twice 2018-05-20 11:53:01 +02:00
Eric Kohl d1c376f37d [SETUPAPI] Implement CM_Get_Resource_Conflict_Count and add stubs for CM_Get_Resource_Conflict_DetailsA/W 2018-05-20 11:48:39 +02:00
Pierre Schweitzer f99f48045d
[EVENTMSG] Add French translation. 2018-05-20 11:36:00 +02:00
Joachim Henze 6d5aae4865 [OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608 2018-05-20 01:41:34 +02:00
Hermès Bélusca-Maïto de87a936ce
[NTOS] Demote an ASSERT to a mere DPRINT since we only support registry hives with cluster size == 1 in any case so far (other sizes are UNIMPLEMENTED!) 2018-05-19 22:07:06 +02:00
Eric Kohl cee1817e06 [SETUPAPI] Implement CM_Free_Resource_Conflict_Handle() and CM_Query_Resource_Conflict_List() 2018-05-19 18:12:28 +02:00
Katayama Hirofumi MZ 82a5983504 [SHELL32] Allow deleting a file type/extension (#553)
CORE-12906
2018-05-19 16:12:11 +02:00
Eric Kohl d7e40954d5 [SETUPAPI] Add CM_Free_Resource_Conflict_Handle and CM_Query_Resource_Conflict_List stubs 2018-05-19 15:14:30 +02:00
Pierre Schweitzer 7283f3cfd9
[FASTFAT] Addendum to d69f318 2018-05-19 13:46:34 +02:00
Eric Kohl de824808b7 [USETUP] Use _wcstoui64() instead of atoi() to convert the partition size in order to prevent unexpected misinterpretation of leading zeroes. 2018-05-19 13:33:28 +02:00
Adam Słaboń 72ad0fe70b [TRANSLATION] Polish translation update (#554)
- Added translations for cmdutils (at, clip, comp, eventcreate, mode, taskkill, wmic) and zipfldr.
- Updated translations for cmdutils (reg), drwtsn32, mmc, eventvwr, shell32 and cpl applets (console, input).
2018-05-19 13:17:49 +02:00
Eric Kohl 76eeb35148 [BOOTDATA] Add the (still disabled) faeroese keyboard layout
CORE-13127
2018-05-19 12:41:37 +02:00
Eric Kohl 8a2cc3cdda [USETUP] Improved entering of partition size
Patch by Эдуард.

CORE-13249
2018-05-19 12:09:58 +02:00
Pierre Schweitzer d69f31848e
[FASTFAT] Misc. fixes spotted by Thomas. 2018-05-19 10:07:14 +02:00
Pierre Schweitzer 7c01587680
[FASTFAT] Completely rewrite support for dirty volumes.
Until now, our support for dirty volumes was totally broken
to a point where, on FAT32 volume, the dirty couldn't even
be written nor read from the disk.

This commit totally rewrites its handling, for both FAT16 and FAT32
so that it's now fully functionnal. Furthermore, it also gets
totally compatible with our vfatlib, and thus, autochk.
Now, on mount, FastFAT will check if the volume is dirty or not, and
autochk will be able to ask for a repair if dirty. vfatlib will
repair the volume and remove the dirty bit. So that, on next
reboot, the volume will be mounted clean.

As a reminder, the dirty bit is set immediately after mounting
the volume, so that, if you crash or have a powercut, autochk
will always attempt to repair your volume (with more or less,
that's FAT!).

If you want to experience without breaking your FAT volume,
just boot, open a cmd prompt and type: fsutil dirty set c:
and reboot!

CORE-13758
CORE-13760
CORE-13759
2018-05-18 23:05:05 +02:00
Pierre Schweitzer efa75dd5b2
[FASTFAT] Allow locking system volume on boot.
This is a hack, and totally not the default behavior.
But it will allow autochk locking the boot volume in
order to verify it on boot, in case it would have
been improperly dismounted.

CORE-13759
2018-05-18 23:05:05 +02:00
Katayama Hirofumi MZ bfb19dd251 [SHELL32] Fix usage of DeferWindowPos (fix of #544) (#552) 2018-05-18 22:27:22 +02:00
Mark Jansen bb5db143f0
[DRWTSN32] Use GetCommandLineW for CommandLineToArgvW.
Spotted by Hermès
2018-05-18 18:27:36 +02:00
Pierre Schweitzer a837694518
[FASTFAT] Uninit directory cache on last handle close.
CORE-14629
CORE-14557
2018-05-18 14:51:24 +02:00
Pierre Schweitzer 3c3ebe3320
[FASTFAT] Only initialize directory cache on use.
This avoids initializing cache directly on directory
open/create.
The advantage is we reduce the load on cache manager
and on memory manager by avoiding creating everytime
a stream file object, and initializing cache for it.

This will avoid initializing cache for started
applications 'current directory' which is just opened
for having a valid handle but no read/write is performed
in it, by default.

This is a step forward for autochk.

CORE-14629
2018-05-18 14:09:30 +02:00
Katayama Hirofumi MZ f20bdf1994 [SHELL32] Add 'Create New Extension' IDD_NEWEXTENSION dialog (#544)
A 'Create New Extension' dialog is implemented, which enables the user to add a new file extension.
CORE-12906
2018-05-18 12:47:52 +02:00
Pierre Schweitzer 5d743b7bd7
[FASTFAT] When attaching our FCB to a FO, also set the VPB.
Spotted by Alex.
2018-05-18 10:30:52 +02:00
Wexpo Lyu 1d11d56d1a [TRANSLATION][DRWTSN32] Add zh-CN translation. (#549) 2018-05-17 19:57:57 +02:00
Wexpo Lyu 6b5f84dfcd [TRANSLATION][TASKMGR] Update Chinese Translation. 2018-05-17 19:56:48 +02:00
Serge Gautherie 6c9359221c [IPHLPAPI] ipstats_reactos: Review all TRACE/WARN calls
- Improve/Promote failures to ERR.
- Improve other TRACE calls.
2018-05-17 17:11:17 +01:00
Baruch Rutman bf34d6bf8b [CHARMAP]Code improvements (#436)
* [CHARMAP][GETUNAME] Code improvements

Based on the code from nls2txt,
switches the linking from dynamic to static, also simplifies the code.
2018-05-17 16:18:57 +01:00
Serge Gautherie 0c683c264c [KMTEST] Check/Wait for start/stop of services to complete
This is cleaner behavior and lets report failures.

- Create KmtEnsureServiceState(),
  called at end of KmtStartService() and KmtStopService().
- Create KmtGetServiceStateAsString(),
  called from KmtEnsureServiceState().

ROSTESTS-263
2018-05-17 16:17:36 +01:00
Peter Wathall ae9cc6bb52 Fixed typo 2018-05-17 16:15:25 +01:00
Peter Wathall 6412253d44 Fixed typo 2018-05-17 16:15:25 +01:00
Peter Wathall 3a3a4f7970 Fixed typo 2018-05-17 16:15:25 +01:00
Pierre Schweitzer d37280efaa
[FASTFAT] Deny dismounting system volume or a volume with a pagefile 2018-05-16 21:45:35 +02:00
Eric Kohl 7c3cff3a68 [USETUP] Remove the WIN32 support because usetup is a native-only application 2018-05-15 23:35:17 +02:00
Eric Kohl 4038773f45 [USETUP] Disable install path test that may tests 2018-05-15 22:58:34 +02:00