Bișoc George
c00bafaad9
[SHELL32] Print out the error code ( #973 )
...
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
2018-11-16 23:09:15 +01:00
Pierre Schweitzer
52da844825
[COMCTL32] Don't leak memory in CB_ThemedPaint()
...
CID 1441313
2018-11-16 22:07:09 +01:00
Pierre Schweitzer
699af9f62a
[SETUPAPI] Allocate big enough buffer in CM_Query_Resource_Conflict_List().
...
CID 1441357
2018-11-16 22:07:08 +01:00
Pierre Schweitzer
3fddd3157c
[COMCTL32] Don't leak memory in PB_ThemedPaint()
...
CID 1441373
2018-11-16 22:07:08 +01:00
Pierre Schweitzer
402c983094
[SYSSETUP] Fix error message in ApplyRegistryValues()
...
CID 1441398
2018-11-16 22:07:07 +01:00
Giannis Adamopoulos
9baf05f164
[SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file
...
CORE-15353
2018-11-15 21:26:17 +02:00
Luo Yufan
d8a4e0a8e3
[TRANSLATION]Update Simplified Chinese translation. ( #1032 )
2018-11-14 21:42:21 +09:00
Baruch Rutman
97150ce9dd
[WINMM] Sync wine commit ebae298 as a fix for CORE-15336 ( #1031 )
...
Reduce CPU usage by only attempting once to load the default joystick driver.
Fix for CORE-15336
Imported wine commit ebae298
ebae298aa4
https://www.winehq.org/pipermail/wine-devel/2018-November/134767.html
2018-11-14 12:32:55 +01:00
Giannis Adamopoulos
bcd309cb7a
[SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before
...
CORE-14116
2018-11-11 20:28:27 +02:00
Luo Yufan
5cdee1ab82
[TRANSLATION] Update Simplified Chinese translation. ( #1028 )
2018-11-11 17:57:12 +01:00
Adam Słaboń
b8044d6783
[TRANSLATION] Polish translation update ( #1029 )
...
Translated missing strings and improved existing translations.
2018-11-11 17:55:01 +01:00
Luo Yufan
91e032f9b1
[TRANSLATION] Update Simplified Chinese translation. ( #1025 )
2018-11-09 15:31:53 +01:00
Joann Mõndresku
b63e2d5046
[TRANSLATIONS] Style fixes for Estonian
2018-11-07 22:10:27 +01:00
Joachim Henze
04e1263921
[SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs
2018-11-07 01:40:53 +01:00
Eric Kohl
ee90e7f608
[LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions that use a policy handle and a domain name or domain SID when the machine is not a domain controller.
2018-11-04 15:27:57 +01:00
Eric Kohl
91eaa5e2d4
[LSASRV] Coding style fixes
2018-11-04 12:50:21 +01:00
Pierre Schweitzer
497a9c8087
[SETUPAPI] Don't let LZClose() reset error code
2018-11-02 09:34:25 +01:00
Carlo Bramini
8236bb8f38
Avoid stray temp files in failure cases of do_file_copyW. CORE-12616
2018-11-02 09:22:34 +01:00
Joachim Henze
ad34c91d1c
[RICHED20] Revert ocr_reverse.cur to fix CORE-15190
...
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.
Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.
2018-10-30 19:06:50 +01:00
Mark Jansen
4bfac27ce6
[SHELL32] Fix broken control definition
2018-10-28 13:06:27 +01:00
Mark Jansen
95682e5406
[SETUPAPI] Fix broken control definition.
2018-10-28 13:06:08 +01:00
Mark Jansen
824e5dba51
[KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup
2018-10-28 13:01:38 +01:00
Mark Jansen
40549483f6
[KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup.
...
This should allow unhandled exceptions in a thread to trigger our crash reporter,
instead of killing the process directly.
2018-10-28 13:01:38 +01:00
Eric Kohl
0ce15a8faa
[LSASRV][IDL] The first parameter of the Credr* functions is a PLSAPR_SERVER_NAME.
2018-10-27 18:17:35 +02:00
Hermès Bélusca-Maïto
c8d37c1a0d
[SYSSETUP] Use a $winnt$.inf file to retrieve setup information for the 2nd-stage setup.
...
Following r75518, we use the $winnt$.inf file (created in System32
by the 1st-stage installer) as the setup information file for the
2nd-stage setup for:
- retrieving the installation source media path;
- retrieving the unattended information that was copied from the
unattend.inf file from the installation source media.
The installation source media path is converted from NT format to
Win32 format for usage with Win32 functions and storage in the registry:
this is done by GetInstallSourceWin32(), which replaces the hackish
GetRosInstallCD() function.
The $winnt$.inf file is also updated, and the registry values "SourcePath"
and "ServicePackSourcePath" are created / updated in:
HKLM\Software\Microsoft\Windows\CurrentVersion\Setup .
svn path=/branches/setup_improvements/; revision=75524
2018-10-27 18:13:38 +02:00
Giannis Adamopoulos
e69213448d
[BROWSEUI] CInternetToolbar: fix whitespace
2018-10-27 15:08:31 +03:00
Giannis Adamopoulos
a2bd9b44a9
[BROWSEUI] Simplify toggling the search band
...
In windows the toolbar itself creates the search shell extension. In ros we send a command to the CShellBrowser to let it handle it itself. Use the same command for showing and hiding it.
2018-10-27 15:08:28 +03:00
Giannis Adamopoulos
a0c5cafce5
[BROWSEUI] Implement toggling the folders and search band with the toolbar and make their buttons appear pressed when they are shown.
...
CBaseBarSite: Ask the CBaseBar to close itself when the x button is pressed.
CBaseBar: Hide the bar and inform its site that it is closing when it gets the close command.
CShellBrowser: Cache the guid of the current vertical bar and use it to report correct command status to the toolbar.
Also implement toggling the Folders, Favorites, History and search commands.
CInternetToolbar: Query the Folders and Search command status from the site so that they can be properly be shown as pressed.
2018-10-27 15:08:24 +03:00
Stanislav Motylkov
c83ac7600d
[SHIMGVW] Fix image flickering when rendering animations
2018-10-24 23:05:00 +02:00
Baruch Rutman
6a3b1879a1
[LPK][GDI32] Enable mirroring via version resource ( #965 )
...
Add a mechanism that detects via the version resource whether it's needed to mirror
the application layout or not. This is a "follow up" to commit 5b14b6f
.
This code is taken from the GetProcessDefaultLayout() function from Wine
(called there "WIN_CreateWindowEx").
In Windows the version-resource mirroring happens when the GDI is loading the LPK.
- Implement mirroring via version resource. GDI linking on startup is required.
- GDI32: Add LPK loading on GDI startup.
To enable mirroring via version resource the lpk.dll must be loaded before any windows are created.
This is done through GdiInitializeLanguagePack() function which is called in GdiProcessSetup().
- LPK: Use Wine debug messaging.
2018-10-24 21:34:38 +02:00
Katayama Hirofumi MZ
375a78e706
[SHIMGVW] Play gif animation ( #934 )
...
Make "Picture and Fax Viewer" able to play GIF animation.
CORE-12680
2018-10-24 19:51:30 +09:00
Eric Kohl
b5e956e7a8
[SETUPAPI] SetupDiGetClassDevPropertySheetsW: Implement adding property pages from an installer.
...
SetupDiGetClassInstallParamsW must be implemented before this will work.
2018-10-23 23:11:19 +02:00
Giannis Adamopoulos
c69ef281c0
[rosctrls.h] CListView: Add Arrange method
...
[SHELL32] CDefView: Start implementing Auto arrange.
So far its effect is only shown when the browser window resizes.
2018-10-22 23:51:37 +03:00
Giannis Adamopoulos
410cfbfe15
[SHELL32] CDefView: Disable auto arrange in list and details view mode.
...
This supersedes PR #927 and does it correctly.
2018-10-22 19:18:28 +03:00
Giannis Adamopoulos
e9cba5375b
[BROWSEUI] CInternetToolbar: Implement hiding and showing the browser toolbars.
2018-10-22 18:42:38 +03:00
Adam Słaboń
7abc8be102
[TRANSLATION] Polish translation update
...
Polish translation of net, telnet, diskpart, devcpux, fontext, iernonce, lsasrv, themes, arping, frag, screensavers, ctm, fontsub, WinetestsGUI and localmon.
Update for dxdiag, msgina, msports, netcfgx, shell32 and syssetup.
2018-10-20 21:26:07 +02:00
Eric Kohl
debb1e521a
[NETCFGX] Implement the Min and Max options for int, long and word parameters.
...
CORE-15095
2018-10-14 21:02:45 +02:00
Eric Kohl
731ef01361
[NEWDEV] Add InstallDevInstEx
2018-10-14 18:19:52 +02:00
Mark Jansen
80c53821c9
[SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view.
...
CORE-14976
2018-10-13 20:28:49 +02:00
Eric Kohl
a5172b4699
[NETCFGX] Move the NetClassInstaller to a separate file.
2018-10-13 19:18:37 +02:00
Mark Jansen
1968776bf2
[DBGHELP] Exclude stubs from pch
2018-10-12 19:30:36 +02:00
Mark Jansen
71993fd8c9
[KERNEL32] Fix some stubs for 0x600+
2018-10-12 19:30:24 +02:00
Eric Kohl
d58f6558e0
[NETCFGX] NetworkPropertySheetProvider: Fix property selection because the property list box is sorted.
...
CORE-15095
2018-10-09 23:19:48 +02:00
Hermès Bélusca-Maïto
8468ad5cf4
[SYSSETUP] Delete the created fonts when needed.
2018-10-08 21:16:58 +02:00
Hermès Bélusca-Maïto
6267898583
[SYSSETUP] Use ARRAYSIZE / _countof instead of sizeof ratios.
...
svn path=/branches/setup_improvements/; revision=75523
2018-10-08 21:16:57 +02:00
Hermès Bélusca-Maïto
e9893906a7
[SYSSETUP] Code formatting.
...
svn path=/branches/setup_improvements/; revision=75522
2018-10-08 21:16:56 +02:00
Eric Kohl
11c9e773fb
[NETCFGX] NetPropPageProvider: Add Base and Step parameter options.
2018-10-08 18:55:39 +02:00
Baruch Rutman
87c529a537
[LPK] Small fix and a related comment. ( #890 )
...
[LPK][USER32] Fix reading layout checks.
- Both functions don't care about DT_RTLREADING flag.
- Added a different method to check reading order.
[USER32] Remove gcc-build breaker semicolon.
2018-10-08 16:17:42 +02:00
Baruch Rutman
a494d0583f
[LPK] Implement LpkPSMTextOut(). ( #890 )
...
- The function is almost fully implemented, but some return values change wildly.
The results are mostly compatible to the Windows results.
- Remove #ifdef (this is primary ReactOS code).
2018-10-08 16:16:40 +02:00
Hermès Bélusca-Maïto
2cbac3d049
[SHELL32] Finally fix the icon location path (un)expansion for shell links, and explain why I originally used SHExpandEnvironmentStringsW().
...
CORE-14009 CORE-14982
2018-10-08 00:50:38 +02:00
Eric Kohl
1e20a3e5b5
[SHELL32] Fix a potential buffer overrun.
...
Patch by Kudratov Olimjon.
CORE-8545
2018-10-07 22:56:16 +02:00
Luo Yufan
b70ef2ee56
[TRANSLATION] Update Simplified Chinese translation. ( #912 )
2018-10-07 20:44:00 +02:00
Stanislav Motylkov
732a6b0801
[NETCFGX] Update russian translation
2018-10-07 18:28:43 +02:00
Stanislav Motylkov
0934d4f171
[MSPORTS] Update russian translation
2018-10-07 18:28:43 +02:00
Stanislav Motylkov
10b7b94f45
[DEVMGR] Update russian translation
2018-10-07 18:28:43 +02:00
Eric Kohl
45cd6d5e4e
[NETCFGX] NetPropPageProvider: Store the parameters in the registry
2018-10-06 23:57:17 +02:00
Eric Kohl
7ad65a3773
[NETCFGX] NetPropPageProvider: Improve the handling of optional parameters
...
- Add a pointer to the current parameter.
- Change the 'present' and 'not present' radio buttons to auto radio buttons.
- Display present and non-present optional parameters properly.
2018-10-06 14:33:48 +02:00
Eric Kohl
c603c54ab0
[MSPORTS] When the LPT port number gets changed, update the PortName and FriendlyName values in the registry.
2018-10-06 11:12:16 +02:00
Eric Kohl
f9739601b3
[DEVMGR] Hackfix CORE-5643
2018-10-05 15:09:27 +02:00
Pierre Schweitzer
f2f24c1fa7
[DEVMGR] Update French translation
2018-10-04 11:13:15 +02:00
Eric Kohl
c444231b87
[MSPORTS] Check and show which parallel port is in use.
2018-10-04 10:21:06 +02:00
Bișoc George
758f9fbdb9
[NEWDEV] Fix a truncated text on device driver name
2018-10-02 21:54:30 +02:00
Eric Kohl
91ba4e7350
[NETCFGX] Network property page: Add support for enum type options, the 'Optional' setting and the 'TextLimit' and 'Uppercase' settings for edit type options.
2018-10-02 17:58:16 +02:00
Eric Kohl
c6142174af
[NETCFGX] Network property page: Implement reading of configured settings. Editing and writing is not implemented yet.
2018-10-01 21:16:22 +02:00
Amine Khaldi
0ccdd32f50
[ITSS] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:57:08 +01:00
Amine Khaldi
6bd06f3b76
[INETMIB1] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:56:32 +01:00
Amine Khaldi
33351fe5ad
[INETCOMM] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:55:17 +01:00
Amine Khaldi
789fa9c819
[IMM32] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:53:21 +01:00
Amine Khaldi
d4bc0feb6e
[IMAADP32.ACM] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:52:44 +01:00
Amine Khaldi
336b2a4564
[IEFRAME] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:52:10 +01:00
Amine Khaldi
a214feb6fe
[HHCTRL.OCX] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:51:35 +01:00
Amine Khaldi
8d2e1e843c
[GDIPLUS] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:50:25 +01:00
Amine Khaldi
fe0fd16499
[FUSION] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:49:44 +01:00
Amine Khaldi
4fc4698f2a
[CRYPTUI] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:49:09 +01:00
Amine Khaldi
997d44c915
[CRYPT32] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:47:51 +01:00
Amine Khaldi
409344041f
[CREDUI] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:46:19 +01:00
Amine Khaldi
eaac1cc75f
[COMDLG32] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 12:44:53 +01:00
Amine Khaldi
21d3faa2a6
[ATL] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 00:26:43 +01:00
Amine Khaldi
0df75d9648
[ADVPACK] Sync with Wine Staging 3.17. CORE-15127
2018-10-01 00:25:34 +01:00
Amine Khaldi
82faa151e5
[XDK][PSDK][WINE] Unify ARRAY_SIZE definition for Wine modules. CORE-15127
2018-09-30 23:57:08 +01:00
Hermès Bélusca-Maïto
ccde12483f
[SHELL32] Fixes and improvements for PickIconDlg().
...
- Deal with expanded paths only when loading icons. If the user specifies
an unexpanded path to a module containing icons, this unexpanded path
is returned to the caller!
- Perform the dialog cleanup in WM_DESTROY message handler.
- When pressing ENTER/OK in the dialog box, retrieve the selected icon and
close the dialog *ONLY WHEN* the user actually has selected an icon.
If the user modified manually the module path, pressing ENTER/OK instead
reloads the icons list.
2018-09-30 21:48:34 +02:00
Hermès Bélusca-Maïto
ae9ec94240
[SHELL32] Code formatting only.
2018-09-30 21:48:31 +02:00
Eric Kohl
4aa1bee757
[SYSETUP] Implement the CriticalDeviceCoInstaller
...
The CriticalDeviceCoInstaller adds devices of registered classes to the critical device database.
2018-09-30 17:23:38 +02:00
Eric Kohl
54eb5635d8
[MSPORTS] Implement the 'Enable legacy Plug and Play detection' setting
2018-09-29 18:05:22 +02:00
Eric Kohl
133611fed8
[MSPORTS] Implement the 'Filter Resource Method' setting for parallel ports
2018-09-29 14:58:55 +02:00
Eric Kohl
f155de483f
[msports] Notify the system of changes to the serial port settings.
2018-09-29 01:57:59 +02:00
Hermès Bélusca-Maïto
c446ce0d62
[ADVAPI32] Improve a bit CreateProcessAsUser().
...
- Check whether the user-provided token is a primary token.
- Do not fail when the RtlAdjustPrivilege() call fails (see the code
comment for an explanation). TL;DR is: that call may indeed fail but
the privilege may also not be necessary because the user-provided
token is a restricted version of the caller's primary token.
And this is situation is perfectly fine.
This fixes Java 7 installation, CORE-14874.
2018-09-28 00:45:04 +02:00
Eric Kohl
3c1e5f7cb9
[NETCFGX] Add the most simple property sheet provider for network adapters
...
- Switch to WINE debug code.
- Build the UNICODE version of the DLL by default.
- Add the most simple property sheet provider.
2018-09-26 23:49:02 +02:00
Eric Kohl
986ce63c4c
[SETUPAPI] SetupDiGetClassDevPropertySheetsW: Support class property sheet providers.
2018-09-26 23:49:01 +02:00
Stanislav Motylkov
68c6641781
[MSPORTS] Add russian translation
...
Addendum to 69e834f
.
2018-09-25 22:50:02 +02:00
Eric Kohl
af37e0e565
[MSPORTS] Hackfix the code to determine the serial and parallel port numbers.
...
Now that SetupDiCreateDevRegKeyW is working as expected, we can no
longer (ab)use it to retrieve a ports resources. Use SetupDiGetDeviceInstanceIdW instead and open the registry keys manually.
2018-09-25 17:48:27 +02:00
Eric Kohl
69e834fa54
[MSPORTS] Implement serial port settings
...
- Fix the control styles and grouping in the dialogs.
- Implement reading, modifying and writing of the serial port settings.
2018-09-25 14:28:29 +02:00
Eric Kohl
df36ee9fe2
[SETUPAPI] Replace the remaining internal calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKeyW by calls to SETUPDI_OpenDrvKey, SETUPDI_CreateDevKey or SETUPDI_CreateDrvKey.
2018-09-23 20:19:26 +02:00
Hermès Bélusca-Maïto
bf164caae8
[SERVICES] Simplify the implementation of RGetServiceDisplayNameA/W() and RGetServiceKeyNameA/W().
...
Also comment about the observed behaviour of the returned number of "characters"
returned by the ANSI versions of these APIs (which is tested by advapi32_winetest:service).
[ADVAPI32:SCM] Add a comment concerning wide characters vs. bytes mismatch.
2018-09-23 18:09:10 +02:00
Eric Kohl
60e166535a
[SETUPAPI] Do not use SetupDiOpenDevRegKey in other SetupDi functions. Use SETUPDI_OpenDevKey or SETUPDI_OpenDrvKey instead.
...
Note: The remaining calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKey will be fixed in another patch.
Fixes CORE-15091
2018-09-23 16:16:12 +02:00
Hermès Bélusca-Maïto
7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed.
...
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.
As a by-product, this commit (together with the previous one e2960914
)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto
e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings()
...
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.
CORE-14981
2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto
41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine.
...
- Adjust the code with respect to:
"shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)
- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)
- "shell32: Assume that system directory always contains a drive letter."
54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)
- "shell32: Use ARRAY_SIZE macro."
612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)
- "shell32: Fix a trace message."
bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)
- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)
- "shell32: Pass correct buffer length to RegQueryValueExW()."
0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)
- "shell32: Remove unused string (Clang)."
8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)
- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
2018-09-23 00:16:02 +02:00
Eric Kohl
de08785ade
[SETUPAPI] SetupDiCreateDevRegKeyW / SetupDiOpenDevRegKey: Create or open the 'Device Parameters' subkey of the given devices enum key when we try to access its hardware key.
...
This creates the PortName value in the proper location for serial ports.
2018-09-22 14:43:43 +02:00
Abdulganiev Rafael
2a6aa7770e
[BTHCI] Add a bluetooth icon ( #871 )
...
[BTHCI] Add a bluetooth icon
2018-09-21 23:42:27 +02:00