Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 01:55:19 +00:00
Code Issues Projects Releases Packages Wiki Activity
73309 commits 96 branches 276 tags 1 GiB
Commit graph

73309 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bișoc George
c00bafaad9 [SHELL32] Print out the error code (#973) 
When SearchPathW, GetFullPathNameW and PathFileExistsW fail, output the error code.
 2018-11-16 23:09:15 +01:00
Ștefan Fulea
3d48aa2992 [MSPAINT] Fix scrollbar presence on canvas/view fitting (#878) 
* [MSPAINT] Fix scrollbar presence on canvas/view fitting

This is a small fix for a scrollbar related edge case functionality exhibited in mspaint (and in a lesser degree also elsewhere in instances of) scrollbar controlled content. As known, the scrollbars presence is given by the size ratio between the accommodating outer frame and the scroll-controlled contents inside it, and it works for the most part. There is, however, a case where the presence of both toolbars is kept even when the contents would fit the frame (if not for the scrollbars themselves that increase the size of the contents' area). Please take the current commit as a demo fix and a provisional correction for mspaint (as I think that the proper fix should reside in common controls).

* [MSPAINT] Fix a small mistake and improve readability in UpdateScrollbox()

Although with no visible impact on testing, I've used a wrong constant related to vertical scrollbox width in one instance (SM_CXHSCROLL instead of SM_CXVSCROLL), and this fixes it. Also, prefer using constants, to improve a bit readability and performance (by avoiding repeated function calls).
 2018-11-16 23:05:51 +01:00
Eric Kohl
c83c683bc3 [MC] Add messages 3190-3299. The first NELOG range is done. 2018-11-16 22:26:50 +01:00
Eric Kohl
4a889acc63 [PSDK] Add missing NELOG-codes to lmerrlog.h 2018-11-16 22:26:49 +01:00
Pierre Schweitzer
007cc5cd8a
[ACGENRAL] Don't leak memory on failure in InitIgnoreFreeLibrary() 
CID 1441306
 2018-11-16 22:07:09 +01:00
Pierre Schweitzer
52da844825
[COMCTL32] Don't leak memory in CB_ThemedPaint() 
CID 1441313
 2018-11-16 22:07:09 +01:00
Pierre Schweitzer
6416ee982f
[WIN32SS] Don't leak memory on failure in IntGdiWidenPath(). 
CID 1441350
 2018-11-16 22:07:08 +01:00
Pierre Schweitzer
699af9f62a
[SETUPAPI] Allocate big enough buffer in CM_Query_Resource_Conflict_List(). 
CID 1441357
 2018-11-16 22:07:08 +01:00
Pierre Schweitzer
2255d5f5b6
[WIN32SS] Avoid an user-after-free in FontFamilyFillInfo(). 
CID 1441367
 2018-11-16 22:07:08 +01:00
Pierre Schweitzer
3fddd3157c
[COMCTL32] Don't leak memory in PB_ThemedPaint() 
CID 1441373
 2018-11-16 22:07:08 +01:00
Pierre Schweitzer
a0c33934fc
[NTOSKRNL] Properly check for negative values in IoCheckEaBufferValidity() 
CID 1441355, 1441382
 2018-11-16 22:07:08 +01:00
Pierre Schweitzer
402c983094
[SYSSETUP] Fix error message in ApplyRegistryValues() 
CID 1441398
 2018-11-16 22:07:07 +01:00
Pierre Schweitzer
4b4c0aabcd
[FASTFAT] Properly return failure in vfatFindDirSpace() 
CID 1441394
 2018-11-16 22:07:07 +01:00
Ercan Ersoy
23b1103fd5 [TRANSLATION] Add/update Turkish translations. (#1043) 
Add or update Turkish translations for: CHKDSK, DISKPART, FORMAT, SUBST and WINLOGON.
 2018-11-16 16:59:09 +01:00
Katayama Hirofumi MZ
5aa7bb32f1
[SYSTEMINFO] Fix Chinese resource to fix MSVC2010 build (#1041) 2018-11-16 09:32:41 +09:00
Eric Kohl
b21177a7d8 [MC] Add messages 3150-3186 and 3530-3547 to netmsg.dll. 2018-11-15 22:39:31 +01:00
Giannis Adamopoulos
9baf05f164 [SHELL32] COpenWithMenu: Use ShellExecuteExW to open the file 
CORE-15353
 2018-11-15 21:26:17 +02:00
Pako Smith
40288a7032 [TRACERT] Fix Coverity #1434258 "Out-of-Bounds access" (#1038) 2018-11-15 14:15:23 +01:00
Pako Smith
6cc4e9f6f3 [CMD] Fix Coverity #715934 "Copy-paste error" (#1040) 
Fix linked-list pointer comparison.
 2018-11-15 11:57:41 +01:00
Eric Kohl
9491979ac3 [MC] Add messages 3100-3141 and 3516-3529 to netmsg.dll. 2018-11-14 22:30:19 +01:00
Luo Yufan
d8a4e0a8e3 [TRANSLATION]Update Simplified Chinese translation. (#1032) 2018-11-14 21:42:21 +09:00
Baruch Rutman
97150ce9dd [WINMM] Sync wine commit ebae298 as a fix for CORE-15336 (#1031) 
Reduce CPU usage by only attempting once to load the default joystick driver.
Fix for CORE-15336

Imported wine commit ebae298
ebae298aa4
https://www.winehq.org/pipermail/wine-devel/2018-November/134767.html
 2018-11-14 12:32:55 +01:00
Pako Smith
13e566444d [TFTPD] Fix Coverity #1434273 "Out-of-Bounds access" (#1037) 
'extbuff' must be of size _MAX_PATH to comply with its usage in the GetModuleFileName() call made in the code.
 2018-11-14 12:30:30 +01:00
Pierre Schweitzer
95bc44e214
[NTOSKRNL] Don't leak DACL 
Spotted by Thomas :-)
 2018-11-11 23:21:36 +01:00
Eric Kohl
3c8356e752 [MC] Add messages 2500-2999. The NERR-range is complete. 2018-11-11 22:43:09 +01:00
Eric Kohl
1f80b6648b [PSDK] Add missing NERR-codes to lmerr.h 2018-11-11 22:43:08 +01:00
Hermès Bélusca-Maïto
cbaa8e7dfb
[NTOS:IO] RAW-FS: Few improvements. 
- Simplify the volume-deletion code in RawCheckForDismount().

- Fixes the OpenCount check in RawClose(): the VCB mutex must be
  released when the volume has not been dismounted, either because
  OpenCount != 0 or because RawCheckForDismount() returned FALSE.

- Explicitly use VCB_STATE_LOCKED instead of hardcoding its value.

- In IRP_MN_VERIFY_VOLUME handling, lock the volume before playing
  with it, and again let the volume be dismounted only if OpenCount == 0
  (and the IoDeleteDevice() call is done by RawCheckForDismount()).
 2018-11-11 21:56:18 +01:00
Hermès Bélusca-Maïto
a5ead049d9
[NTOS:IO] RAW-FS: Minor code formatting only. 2018-11-11 21:56:17 +01:00
Hermès Bélusca-Maïto
f527e23aa7
[SETUPLIB] Lock the BTRFS volume before installing the new bootsector code. 
CORE-15334 CORE-15339

The BTRFS driver requires the volume to be locked in order to modify
the first sectors of the partition, even though they are outside the
file-system space / in the reserved area (they are situated before
the super-block at 0x1000) and is in principle allowed by the NT
storage stack.
So we lock here in order to write the bootsector at sector 0.
If locking fails, we ignore and continue nonetheless.

See also the following links for reference:
https://stackoverflow.com/a/12928934
https://docs.microsoft.com/en-us/windows/desktop/api/fileapi/nf-fileapi-writefile
https://support.microsoft.com/en-us/help/942448/changes-to-the-file-system-and-to-the-storage-stack-to-restrict-direct
 2018-11-11 21:55:48 +01:00
Hermès Bélusca-Maïto
bfb2b88f82
[SETUPLIB] Use proper file share access when opening partitions for raw access. 2018-11-11 21:47:37 +01:00
Mark Harmstone
5729380349
[BTRFS] Import BTRFS upstream commit e43183a0 "open_file: set granted_access when creating file". 
Better solution for the original problem described at:
https://github.com/maharmstone/btrfs/pull/123
 2018-11-11 21:47:29 +01:00
Eric Kohl
bebbb69b21 [MC] Add messages 2300-2484 to netmsg.dll. 2018-11-11 19:54:32 +01:00
Eric Kohl
7021115c21 [PSDK] Add missing NERR_IsDfsShare to lmerr.h. 2018-11-11 19:54:30 +01:00
Giannis Adamopoulos
73b679e4a6 [NETSHELL] CNetConUiObject: Fix implementation of IContextMenu. 
The id that InvokeCommand gets is the one used by QueryContextMenu after subtracting idCmdFirst.
 2018-11-11 20:28:36 +02:00
Giannis Adamopoulos
cd7a331749 [NETSHELL] CNetConUiObject: Implement handling the rename context menu item 2018-11-11 20:28:34 +02:00
Giannis Adamopoulos
af3a1b1936 [NETSHELL] CNetConUiObject: Use a switch in InvokeCommand 2018-11-11 20:28:32 +02:00
Giannis Adamopoulos
41639e94c2 [NETSHELL] CNetworkConnections: Remove SFGAO_CANRENAME bit when renaming shouldn't be enabled. 
This fixes the problem where renaming could take place by clicking on a name even when it is disabled in the context menu.
CORE-14116
 2018-11-11 20:28:31 +02:00
Giannis Adamopoulos
91119080bc [NETSHELL] CNetworkConnections: SetNameOf should always return a new pidl on success. 
CORE-14116
 2018-11-11 20:28:29 +02:00
Giannis Adamopoulos
bcd309cb7a [SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before 
CORE-14116
 2018-11-11 20:28:27 +02:00
Ged Murphy
f66f58991c [FLTMC] Add volumes usage info 2018-11-11 18:05:47 +00:00
Ged Murphy
0231c8baec [FLTMC] Implement 'fltmc volumes' 2018-11-11 17:58:39 +00:00
Ged Murphy
5617ba9841 [FLTMC] Support displaying legacy FS filters 2018-11-11 17:58:38 +00:00
Ged Murphy
14a05528d0 [FLTMC] Fix output when no args are shown 2018-11-11 17:58:38 +00:00
Ercan Ersoy
44323e610f [TRANSLATION] Turkish translations of many components. (#1026) 2018-11-11 18:13:48 +01:00
Luo Yufan
5cdee1ab82 [TRANSLATION] Update Simplified Chinese translation. (#1028) 2018-11-11 17:57:12 +01:00
Eric Kohl
0d3f1a1c02 [MC] Add messages 2250-2299 and 3510-3513 to netmsg.dll. 2018-11-11 17:56:05 +01:00
Adam Słaboń
b8044d6783 [TRANSLATION] Polish translation update (#1029) 
Translated missing strings and improved existing translations.
 2018-11-11 17:55:01 +01:00
Pierre Schweitzer
26408b02f1
[SETUP] Align partition start at 2048 minimum 
This will allow compatibility with modern OSes and
modern disk management utilities.
It will also improve performances by properly aligning
partition start.
And it will let enough room at the begin of the disk
for 3rd party bootloaders.

WARNING: this is not compatible with previous partition
model, and old one will likely not be compatible. You'll
have to erase your whole partition table and start from
scratch.
 2018-11-11 17:38:37 +01:00
Mark Jansen
86ced3f237
[DRWTSN32] Include displacement in stacktrace. 2018-11-11 17:21:16 +01:00
Mark Jansen
027df341f3
[GFLAGS] Use the registry access flags passed in 2018-11-11 17:21:16 +01:00