Commit graph

687 commits

Author SHA1 Message Date
Serge Gautherie 3eb03ef9ce [0.4.9] cherry-pick [SYSSETUP] Fix a DPH report about dwPageCount
- "(sdk/lib/rtl/heappage.c:1329) corrupted suffix pattern"
  detected at
  "dll/win32/syssetup/wizard.c:2672 (InstallWizard)"
- Add an ASSERT(), as hinted by Mark Jansen.

(cherry picked from commit 1668527acf)
2018-06-19 21:00:11 +02:00
Joachim Henze 9d758ae1cd [0.4.9] [COMCTL32] Fix regression CORE-14671
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.

Thanks to patches author Doug Lyons.
The patch is new and has not been committed to master yet.
2018-06-19 20:56:21 +02:00
Joachim Henze fb0fd2b462 [0.4.9] cherry-pick [COMCTL32] Simplify some ifdefs CORE-14649
Addendum to 16d6c9b5e0
Giannis suggested and Thomas explained:

Before the Wine sync, comctl32/button.c was based on ROS's
user32/button.c, so _USER32_ would highlight changes between
user32 (originally based on Wine) and comctl32. Now our
comctl32/button.c is based on Wine's comctl32/button.c, so
__REACTOS__ is enough.

(cherry picked from commit 1c151c9977)
2018-06-03 14:40:20 +02:00
Joachim Henze b2a415edc2 [0.4.9] cherry-pick [ZIPFLDR] Fix text-cutoff + improve de-DE CORE-14682
(cherry picked from commit ea42633bed)
2018-06-02 22:09:05 +02:00
Joachim Henze 4268605cb9 [0.4.9] cherry-pick [COMCTL32] Fix regression CORE-14649
Fixes a regression that was introduced by Wine Staging 3.3 Sync.
Symptom was missing button text and icons for specific buttons
in Delphi applications, e.g. Double-Commander, Lazarus, Peazip.
The patch restores and ifdef-guards previous changes of Giannis.

(cherry picked from commit 16d6c9b5e0)
2018-06-02 12:38:19 +02:00
Joachim Henze d33b71e9d4 [0.4.9] [WINHTTP] Revert to SVN r75943 to fix regression CORE-13952
Our RCs were still affected by that regression.
The revert allows to run the current Online! setup
of Flash-Player 29.0.0.171 to download.
(I was able to watch a flash video in Opera 12.18 afterwards.)
2018-05-26 17:00:47 +02:00
Joachim Henze a04d7c300e [0.4.9] [WINE DIRECTX] Sledge-hammer-revert to avoid CORE-14534
This commit reverts
dll/directx/wine/* and
sdk/include/reactos/wine/wined3d.h
to the state of 0.4.8rls.

The current state of Ddraw without this revert is totally broken,
so we need this interim solution. I will happily replace it with
a proper fix if someone finds one until release.
2018-05-21 17:14:08 +02:00
Joachim Henze 4de8a0d96f [0.4.9] revert [NTDLL/LDR] Overhaul sxs work
This reverts commit 0.4.8-dev-502-g
7000fe2340.

This reverts commit 0.4.8-dev-503-g
f318a25e10.

The two changes were done once to work towards better
shim-supporting APIs of newer Windows versions on demand
in the future. Luckily we do not depend on them yet.

Giannis already fixed most regressions of the 2 commits
before branching 0.4.8RC (e.g. 2nd stage theme-selector).

Unfortunately we still have issues atm with the existing mixture
of Wine comctl32 v5 vs v6.
The image-lists of both are not compatible as Giannis told us.

We revert both commits for this release to fix CORE-14433
(missing icons due to incompatible image-lists). We can not
simply add a manifest here, because 3rd party apps are affected.

I double-checked, all of those (formerly affected) apps
are working fine and show the icons after the revert:
2nd-stage-theme-selection, MS Excel Viewer 2007 open-dlg,
MSVCPP 6 installer open-dlg, FaxViewer save-dlg,
MS Word Viewer 2003 open-dlg

This revert also obsoletes works/fixes like
2f11904000.

(cherry picked from commit 11bf8fa047)
2018-05-20 23:40:47 +02:00
Joachim Henze ad20c37358 [0.4.9] [SETUPAPI] Apply yet uncommitted fix for CORE-12616 PR-408
This commit was *not* committed to master yet.
I'll leave the ticket unresolved until it'll be.

This fixes a regression introduced in SVN r73442:
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.

This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.

There are ongoing discussions about an alternative approach
to the initial problem that SVN r73442 tried to address.
Serge Gautherie can and shall be evaluate that alternative
later during 0.4.10dev.

For now many thanks to Carlo Bramini for this fix.

(cherry picked from commit dba2f743c5)
2018-05-20 22:50:15 +02:00
Joachim Henze c19ce9549a [0.4.9] [USP10] Apply unfinished patch to avoid CORE-14226
Thomas linked the patch in Wine Bug 44410
I tested it for some weeks without noticing any side-effects.
It avoids text rendering regressions in some setups like UltraISO

like in 0.4.8 before

(cherry picked from commit 937c2615e6)
2018-05-20 22:47:53 +02:00
Thomas Faber f926d742d5 [0.4.9] Revert r73436 to avoid trouble with VirtualBox Guest Additions. CORE-13172 CORE-12700 CORE-12765
like in 0.4.8 before

(cherry picked from commit 766ef24948)
2018-05-20 22:47:19 +02:00
Hermès Bélusca-Maïto edc0aeb5a8
[SETUPAPI] Fix MSVC build; pathetic GCC/LD didn't see we were using two different prototypes for these functions. 2018-05-20 15:32:06 +02:00
Eric Kohl b250eb5f3e [SAMSRV] SamrChangePasswordUser: Check StoredLmEmpty and StoredNtEmpty instead of checking StoredNtEmpty twice 2018-05-20 11:53:01 +02:00
Eric Kohl d1c376f37d [SETUPAPI] Implement CM_Get_Resource_Conflict_Count and add stubs for CM_Get_Resource_Conflict_DetailsA/W 2018-05-20 11:48:39 +02:00
Joachim Henze 6d5aae4865 [OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608 2018-05-20 01:41:34 +02:00
Eric Kohl cee1817e06 [SETUPAPI] Implement CM_Free_Resource_Conflict_Handle() and CM_Query_Resource_Conflict_List() 2018-05-19 18:12:28 +02:00
Katayama Hirofumi MZ 82a5983504 [SHELL32] Allow deleting a file type/extension (#553)
CORE-12906
2018-05-19 16:12:11 +02:00
Eric Kohl d7e40954d5 [SETUPAPI] Add CM_Free_Resource_Conflict_Handle and CM_Query_Resource_Conflict_List stubs 2018-05-19 15:14:30 +02:00
Adam Słaboń 72ad0fe70b [TRANSLATION] Polish translation update (#554)
- Added translations for cmdutils (at, clip, comp, eventcreate, mode, taskkill, wmic) and zipfldr.
- Updated translations for cmdutils (reg), drwtsn32, mmc, eventvwr, shell32 and cpl applets (console, input).
2018-05-19 13:17:49 +02:00
Katayama Hirofumi MZ bfb19dd251 [SHELL32] Fix usage of DeferWindowPos (fix of #544) (#552) 2018-05-18 22:27:22 +02:00
Katayama Hirofumi MZ f20bdf1994 [SHELL32] Add 'Create New Extension' IDD_NEWEXTENSION dialog (#544)
A 'Create New Extension' dialog is implemented, which enables the user to add a new file extension.
CORE-12906
2018-05-18 12:47:52 +02:00
Serge Gautherie 6c9359221c [IPHLPAPI] ipstats_reactos: Review all TRACE/WARN calls
- Improve/Promote failures to ERR.
- Improve other TRACE calls.
2018-05-17 17:11:17 +01:00
Katayama Hirofumi MZ 2e96d85133 [SHELL32] In #543, I forgot sq-AL.rc and sv-SE.rc 2018-05-12 17:09:59 +02:00
Katayama Hirofumi MZ 2b0238a48a
[shell32] add some control IDs for IDD_FOLDER_OPTIONS_FILETYPES 2018-05-12 13:47:09 +02:00
Mark Jansen 60a1006d0f
[LDR] Initial verifier implementation 2018-05-12 13:35:10 +02:00
Mark Jansen ad8a2edd85
[VERIFIER] Add skeleton provider. 2018-05-12 13:35:09 +02:00
Mark Jansen 5a68fbeb43
[SDK] Correct NtGlobalFlag names. 2018-05-12 13:34:24 +02:00
Eric Kohl 35bd6571bd [SETUPAPI] SetupDiCallClassInstaller: Use the class GUID enclosed in curly brackets as a sub key name to retrieve the class co-installer. 2018-05-12 12:42:56 +02:00
Bișoc George 337e7322a6 [INETCPL] Fix a typo in Romanian resource file 2018-05-11 23:34:52 +02:00
Bișoc George 96c3d8d9eb [COMCTL32] Update Romanian translation (#538) 2018-05-08 23:06:33 +02:00
Serge Gautherie 627f3dc725 [DEVMGR] Fix a Clang-Cl warning about DriverInfoDetailData.SectionName
"warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]"

CORE-14306
2018-05-07 14:00:41 +02:00
Eric Kohl 12bdbe5710 [IDL][NETAPI32][SRVSVC] Hack around another midl/rpcrt4 bug
NETAPI32: Get rid of the old WINE NetServerGetInfo and replace it by a proper call to NetrServerGetInfo.
SRVSVC: Implement parts of NetrServerGetInfo.
srvsvc.idl: Hack around a bug in midl or rpcrt4. They are not able to handle a pointer to a union of pointers to structs. A pointer to a union of structs works a advertised.
2018-05-06 16:49:24 +02:00
Hermès Bélusca-Maïto 34b0f3e4f8
[BOOTDATA][SHELL32] Add some recognized file extensions (.db, .efi, .nls, .ocx, .tlb, .nt), and update some reported MIME types.
CORE-11308
2018-05-05 22:20:21 +02:00
Serge Gautherie 444553c7f0 [DESK.CPL] Fix a Clang-Cl warning about "LogPixels"
"warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]"

CORE-14306
2018-05-04 22:02:48 +02:00
Robert Naumann d6cebe736a [ZIPFLDR] Add German translation 2018-05-04 21:34:09 +02:00
Serge Gautherie 8c312fe7e1 [ADVAPI32] Fix 2 TRACE() format copypastas. 2018-05-03 08:10:43 +02:00
Eric Kohl db60cd219c [ADVAPI32] SEH-protext the calls to service control handlers
ScControlService:
- SEH-protext the calls to service control handlers.
- Return ERROR_EXCEPTION_IN_SERVICE if a service control handler throws an exception.
- Return ERROR_SERVICE_CANNOT_ACCEPT_CTRL if no service control handler has been registered for the service.
2018-05-02 23:24:26 +02:00
Hermès Bélusca-Maïto 11f0e2c0f6
[MSGINA] Fix layout of the security dialog box; add some french translation. 2018-05-02 00:24:01 +02:00
Hermès Bélusca-Maïto 73f799629b
[TRANSLATION] Minor translation update. 2018-05-01 17:45:06 +02:00
Hermès Bélusca-Maïto bf88116252
[SHELL32] Fix the layout of the Run/Execute dialog for many languages.
French fix covers CORE-12548.
2018-05-01 17:45:03 +02:00
Eric Kohl b6ebd50d3f [SYSSETUP] Close the device key after the property sheet page has been released. 2018-04-29 15:41:38 +02:00
Eric Kohl 1cb019bd21 [SYSSETUP] Read driver settings from and write them to the registry
- Read the driver settings from the registry.
- Write the driver settings to the registry.
- Make the read-only edit control for the input buffer length look like a non-read-only one because it is controlled by the up-down control.
2018-04-29 14:55:57 +02:00
Thomas Faber 708d26acf3
[MSXML3] Fix buffer overflow in BindStatusCallback_GetBindInfo. CORE-14570 2018-04-26 15:00:24 +02:00
Eric Kohl dd653de251 [SYSSETUP] PS2MousePropPageProvider: Use the UDN_DELTAPOS notification to change the input buffer size in steps of 10 2018-04-23 23:58:49 +02:00
Eric Kohl 065e70048d [SYSSETUP] Initialize the property sheet page dialog and implement the Defaults button 2018-04-23 00:00:46 +02:00
Bișoc George e445b305bb [CPL][CONSOLE] Mistake corrections 2018-04-22 22:52:48 +02:00
Mark Jansen 8b15a5ecd7
[SDK][ACGENRAL] Add the shim IgnoreFreeLibrary 2018-04-22 18:52:00 +02:00
Mark Jansen 2eaf526484
[SHIMLIB] Update helper functions, add ShimLib_StringNDuplicateA 2018-04-22 18:51:48 +02:00
Eric Kohl 4970f92d6c [ZIPFLDR] Fix russian translation 2018-04-22 17:43:05 +02:00
Mark Jansen b569195ecf
[SHELL32] Partially sync SHGetFileInfo with wine to improve folder type names.
CORE-14542
2018-04-22 17:38:44 +02:00