Commit graph

71970 commits

Author SHA1 Message Date
Joachim Henze a920a9672c [0.4.9] [SDK] Remove 'RC' from version.cmake 2018-07-12 17:37:32 +02:00
Serge Gautherie 3eb03ef9ce [0.4.9] cherry-pick [SYSSETUP] Fix a DPH report about dwPageCount
- "(sdk/lib/rtl/heappage.c:1329) corrupted suffix pattern"
  detected at
  "dll/win32/syssetup/wizard.c:2672 (InstallWizard)"
- Add an ASSERT(), as hinted by Mark Jansen.

(cherry picked from commit 1668527acf)
2018-06-19 21:00:11 +02:00
Joachim Henze 9d758ae1cd [0.4.9] [COMCTL32] Fix regression CORE-14671
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.

Thanks to patches author Doug Lyons.
The patch is new and has not been committed to master yet.
2018-06-19 20:56:21 +02:00
Pierre Schweitzer ea76ef8477 [0.4.9] cherry-pick [FASTFAT] Properly check for buffer size on dir enumeration.
This avoids improper returns when multiple entries are requested
and, in rare circumstances, entries not being seen by umode.

CORE-14699

(cherry picked from commit 01e2877161)
2018-06-07 20:57:47 +02:00
Joachim Henze fb0fd2b462 [0.4.9] cherry-pick [COMCTL32] Simplify some ifdefs CORE-14649
Addendum to 16d6c9b5e0
Giannis suggested and Thomas explained:

Before the Wine sync, comctl32/button.c was based on ROS's
user32/button.c, so _USER32_ would highlight changes between
user32 (originally based on Wine) and comctl32. Now our
comctl32/button.c is based on Wine's comctl32/button.c, so
__REACTOS__ is enough.

(cherry picked from commit 1c151c9977)
2018-06-03 14:40:20 +02:00
Hermès Bélusca-Maïto 09c64b5982 [0.4.9] cherry-pick [CMD] Improve the situations when the console title can be changed.
- Introduce two small helpers to change and restore the console title.
- Console title can change even when internal commands are executed.
- Note that when commands are run from within batch files, title is unchanged.
- When "cmd.exe /c command" is run, the console title is unchanged; however
  when "cmd.exe /k command" is run, the console title changes.

(cherry picked from commit a165999067)
picked to fix CORE-14648 which was the last puzzle-piece to build ros on ros
2018-06-03 14:40:01 +02:00
Hermès Bélusca-Maïto 9a6be75d5f [0.4.9] cherry-pick [CMD] Print a newline after the interactive 'pause' command message finishes to run.
(cherry picked from commit 39af25024a)
2018-06-03 14:37:45 +02:00
Pierre Schweitzer 7b3affa096 [0.4.9] cherry-pick [CRT] Reimplement qsort() using FreeBSD implementation.
Our implementation had a bug that could be triggered while
building our USBD library on ReactOS: the compare function
could be called with a NULL pointer instead of a valid value.

With this bug fixed (and the cmd hack in CORE-14648), ReactOS
can totally selfhost :-)! I was able to build LiveCD and BootCD
without any trouble, crash, deadlock or whatever.
(Next step: having a buildbot slave hosted on ReactOS ;-)).

Enjoy: https://twitter.com/HeisSpiter/status/1002880397103988737

CORE-14680

(cherry picked from commit 2dfe5e3f46)
2018-06-03 14:37:28 +02:00
Joachim Henze b2a415edc2 [0.4.9] cherry-pick [ZIPFLDR] Fix text-cutoff + improve de-DE CORE-14682
(cherry picked from commit ea42633bed)
2018-06-02 22:09:05 +02:00
Joachim Henze 39f5e56a29 [0.4.9] [NFSD] Apply a hack to avoid CORE-13498
Committing into rls was requested by Pierre.
The hack allows to startup nfsd even when getnameinfo() fails.
2018-06-02 13:23:06 +02:00
Joachim Henze 4268605cb9 [0.4.9] cherry-pick [COMCTL32] Fix regression CORE-14649
Fixes a regression that was introduced by Wine Staging 3.3 Sync.
Symptom was missing button text and icons for specific buttons
in Delphi applications, e.g. Double-Commander, Lazarus, Peazip.
The patch restores and ifdef-guards previous changes of Giannis.

(cherry picked from commit 16d6c9b5e0)
2018-06-02 12:38:19 +02:00
Pierre Schweitzer 98e87bcafd [0.4.9] cherry-pick [FASTFAT] Lock DirResource on flush in case we're updating entry
CORE-14660

(cherry picked from commit 9f3169b295)
2018-05-28 19:44:27 +02:00
Pierre Schweitzer ae5aa9cd8b [0.4.9] cherry-pick [VFATLIB] Only attempt to clear the dirty set bit in rw mode.
(cherry picked from commit 59dc951bf7)
2018-05-28 19:44:17 +02:00
Joachim Henze 519cdd3c52 [0.4.9] [SDK] Change gcc baseaddress for user32.dll to fix CORE-12752
Giving this risky fix a chance.
It reliably prevents the conflict between MSVCP71.dll
& our user32.dll (that can't be relocated by design).
But we'll have to check very carefully that this
patch does not break anything else.
2018-05-27 14:16:03 +02:00
Pierre Schweitzer 367cb1fff3 [0.4.9] cherry-pick [FASTFAT] Lock DirResource when modifying an entry on disk.
Likely not optimal, but fixes some races conditions where
the directory is uninit in the middle of the write.

(cherry picked from commit fc788cf2fd)
2018-05-27 12:58:00 +02:00
Benedikt Freisen 8b45da6d3d [0.4.9] cherry-pick [MSPAINT] When clicking selection, invalidate _and_ repaint Scroll Client _and_ Image Area
Previously, the canvas disappeared when a selection was clicked until the mouse was moved.

CORE-13288 & CORE-10053

(cherry picked from commit cca1a3f47f)
2018-05-27 12:57:03 +02:00
Benedikt Freisen 49687637b3 [0.4.9] cherry-pick [MSPAINT] Store subsequent changes to file selected via Save As
Paint has erroneously been storing subsequent changes to Unnamed.bmp

CORE-13291

(cherry picked from commit 97025c3e06)
2018-05-27 12:56:34 +02:00
Joachim Henze d33b71e9d4 [0.4.9] [WINHTTP] Revert to SVN r75943 to fix regression CORE-13952
Our RCs were still affected by that regression.
The revert allows to run the current Online! setup
of Flash-Player 29.0.0.171 to download.
(I was able to watch a flash video in Opera 12.18 afterwards.)
2018-05-26 17:00:47 +02:00
Pierre Schweitzer c71d198fd8 [0.4.9] cherry-pick [FASTFAT] Initialize cache if neded for changing volume label.
CORE-14654

(cherry picked from commit 47b9db9d02)
2018-05-26 14:13:17 +02:00
Stanislav Motylkov a757a3fb04 [0.4.9] cherry-pick [MSPAINT] Fix call sequence in OnRButtonUp
This fixes unexpected undo action when zooming out with right mouse
click.

The call sequence in OnLButtonUp is already correct.

CORE-14539

(cherry picked from commit 1007a2e0f9)
2018-05-26 14:13:11 +02:00
Stanislav Motylkov 16d7d9d27c [0.4.9] cherry-pick [MSPAINT] Fix divide by zero in drawZoomFrame
CORE-14539 #resolve

(cherry picked from commit 8c726ae0d2)
2018-05-26 14:13:05 +02:00
Stanislav Motylkov 22a0c675ba [0.4.9] cherry-pick [MSPAINT] Fix copy-pasta bug (#562)
This would fix setting image height via Attributes dialog and help fixing CORE-14539.
(cherry picked from commit e27d5d2efc)
2018-05-26 14:12:59 +02:00
Pierre Schweitzer 9bccee3237 [0.4.9] cherry-pick [NTOSKRNL] Addendum to 8a8cb4d: don't print uninit pointer.
(cherry picked from commit 2cf9a69bce)
2018-05-26 14:12:49 +02:00
Pierre Schweitzer 09f068086d [0.4.9] cherry-pick [NTOSKRNL] Only consider SharedCacheMap value once ViewLock is acquired.
This avoids a really nasty race condition in our cache controler where
two concurrents could try to initialize cache on the same file.
This had two nasty effects: first shared map was purely leaked and erased
by the second one. And the private cache map, allocated on the first shared
cache map couldn't be freed and was leading to Mm BSOD (free in a middle of
a block).

This was often triggered while building ReactOS on ReactOS (with multi threads).
With that patch, I cannot crash anylonger while building ReactOS.

CORE-14634

(cherry picked from commit 8a8cb4d890)
2018-05-26 14:12:42 +02:00
Pierre Schweitzer bf2d787a94 [0.4.9] cherry-pick [FASTFAT] Properly handle IRPs that can wait and these that cannot.
CORE-14634

(cherry picked from commit b4363068d1)
2018-05-26 14:12:36 +02:00
Pierre Schweitzer 07a13ca67c [0.4.9] cherry-pick [FASTFAT] Properly queue pending write IRPs.
Addendum to 30b836b

(cherry picked from commit e9e14be661)
2018-05-26 14:12:29 +02:00
Pierre Schweitzer 4af12f40ca [0.4.9] cherry-pick [FASTFAT] When extending a file, also lock the DirResource.
This avoids race conditions under high IOs and thus corruption on
the FS, or assertions failures in the kernel.
Easily triggered by building ReactOS on ReactOS ;-).

(cherry picked from commit 30b836bf3f)
2018-05-26 14:12:22 +02:00
Joachim Henze a04d7c300e [0.4.9] [WINE DIRECTX] Sledge-hammer-revert to avoid CORE-14534
This commit reverts
dll/directx/wine/* and
sdk/include/reactos/wine/wined3d.h
to the state of 0.4.8rls.

The current state of Ddraw without this revert is totally broken,
so we need this interim solution. I will happily replace it with
a proper fix if someone finds one until release.
2018-05-21 17:14:08 +02:00
Joachim Henze 4de8a0d96f [0.4.9] revert [NTDLL/LDR] Overhaul sxs work
This reverts commit 0.4.8-dev-502-g
7000fe2340.

This reverts commit 0.4.8-dev-503-g
f318a25e10.

The two changes were done once to work towards better
shim-supporting APIs of newer Windows versions on demand
in the future. Luckily we do not depend on them yet.

Giannis already fixed most regressions of the 2 commits
before branching 0.4.8RC (e.g. 2nd stage theme-selector).

Unfortunately we still have issues atm with the existing mixture
of Wine comctl32 v5 vs v6.
The image-lists of both are not compatible as Giannis told us.

We revert both commits for this release to fix CORE-14433
(missing icons due to incompatible image-lists). We can not
simply add a manifest here, because 3rd party apps are affected.

I double-checked, all of those (formerly affected) apps
are working fine and show the icons after the revert:
2nd-stage-theme-selection, MS Excel Viewer 2007 open-dlg,
MSVCPP 6 installer open-dlg, FaxViewer save-dlg,
MS Word Viewer 2003 open-dlg

This revert also obsoletes works/fixes like
2f11904000.

(cherry picked from commit 11bf8fa047)
2018-05-20 23:40:47 +02:00
Joachim Henze ad20c37358 [0.4.9] [SETUPAPI] Apply yet uncommitted fix for CORE-12616 PR-408
This commit was *not* committed to master yet.
I'll leave the ticket unresolved until it'll be.

This fixes a regression introduced in SVN r73442:
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.

This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.

There are ongoing discussions about an alternative approach
to the initial problem that SVN r73442 tried to address.
Serge Gautherie can and shall be evaluate that alternative
later during 0.4.10dev.

For now many thanks to Carlo Bramini for this fix.

(cherry picked from commit dba2f743c5)
2018-05-20 22:50:15 +02:00
Joachim Henze 4127f70e94 [0.4.9] [RDBSS] avoid CORE-13938
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.

(cherry picked from commit 1906186e83)
2018-05-20 22:49:26 +02:00
Joachim Henze 6ce8028f87 [0.4.9] [AFD] Apply unfinished patch to avoid BSODs CORE-14048 & CORE-12520
Fixes BSODs when starting Deluge Torrent 1.3.12.1 & QBitTorrent 3.2.0
due to running "Out of NP Expansion Pool"

This patch is still WIP of ThFabba.

like in 0.4.8 before

(cherry picked from commit 6b8b704e6f)
2018-05-20 22:48:46 +02:00
Joachim Henze c19ce9549a [0.4.9] [USP10] Apply unfinished patch to avoid CORE-14226
Thomas linked the patch in Wine Bug 44410
I tested it for some weeks without noticing any side-effects.
It avoids text rendering regressions in some setups like UltraISO

like in 0.4.8 before

(cherry picked from commit 937c2615e6)
2018-05-20 22:47:53 +02:00
Thomas Faber f926d742d5 [0.4.9] Revert r73436 to avoid trouble with VirtualBox Guest Additions. CORE-13172 CORE-12700 CORE-12765
like in 0.4.8 before

(cherry picked from commit 766ef24948)
2018-05-20 22:47:19 +02:00
Joachim Henze 7f96f90110 [0.4.9] [CDFS_NEW] Mute continuable assertion to avoid CORE-14067
like in 0.4.8 before

(cherry picked from commit 51f9494d48)
2018-05-20 22:46:42 +02:00
Thomas Faber d46570474a [0.4.9] cherry-pick [WIN32SS] Mask WndProc exceptions to hide all tickets linked to CORE-11915
e.g. this allows using MsDepends

(cherry picked from commit 9274859438)
cherry-picked by Joachim Henze
2018-05-20 21:31:53 +02:00
Joachim Henze e7e831a6ff [0.4.9] Branch releases/0.4.9 & change KERNEL_VERSION_BUILD_TYPE "RC"
as first commit before! adding the git-tag
2018-05-20 20:31:06 +02:00
Hermès Bélusca-Maïto ddd03a8973
[CMD] Use string-safe call to build the new console title (possibly truncated, we don't care), avoiding any buffer overflow. Caught by David Quintana. 2018-05-20 19:57:43 +02:00
Hermès Bélusca-Maïto 7b618314c2
[USETUP] Remove now-unneeded file. 2018-05-20 19:27:57 +02:00
Hermès Bélusca-Maïto cb679a8917
[BOOTDATA] Set the 'BootExecute' SMSS value to an empty value as we do not want AutoChk to start when booting the LiveCD. CORE-14633
Add also a missing closing quote.
2018-05-20 18:34:35 +02:00
Hermès Bélusca-Maïto edc0aeb5a8
[SETUPAPI] Fix MSVC build; pathetic GCC/LD didn't see we were using two different prototypes for these functions. 2018-05-20 15:32:06 +02:00
Pierre Schweitzer a10f6c7a0c
[FASTFAT] Fail if allocating the stream FO fails. 2018-05-20 13:53:43 +02:00
Eric Kohl b250eb5f3e [SAMSRV] SamrChangePasswordUser: Check StoredLmEmpty and StoredNtEmpty instead of checking StoredNtEmpty twice 2018-05-20 11:53:01 +02:00
Eric Kohl d1c376f37d [SETUPAPI] Implement CM_Get_Resource_Conflict_Count and add stubs for CM_Get_Resource_Conflict_DetailsA/W 2018-05-20 11:48:39 +02:00
Pierre Schweitzer f99f48045d
[EVENTMSG] Add French translation. 2018-05-20 11:36:00 +02:00
Joachim Henze 6d5aae4865 [OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608 2018-05-20 01:41:34 +02:00
Hermès Bélusca-Maïto de87a936ce
[NTOS] Demote an ASSERT to a mere DPRINT since we only support registry hives with cluster size == 1 in any case so far (other sizes are UNIMPLEMENTED!) 2018-05-19 22:07:06 +02:00
Eric Kohl cee1817e06 [SETUPAPI] Implement CM_Free_Resource_Conflict_Handle() and CM_Query_Resource_Conflict_List() 2018-05-19 18:12:28 +02:00
Katayama Hirofumi MZ 82a5983504 [SHELL32] Allow deleting a file type/extension (#553)
CORE-12906
2018-05-19 16:12:11 +02:00
Eric Kohl d7e40954d5 [SETUPAPI] Add CM_Free_Resource_Conflict_Handle and CM_Query_Resource_Conflict_List stubs 2018-05-19 15:14:30 +02:00