Commit graph

983 commits

Author SHA1 Message Date
Joachim Henze 1c6eb6d0b8 [0.4.14][RICHED20] Decorate thiscall functions as such. ROSTESTS-375 CORE-17021
This fixes CORE-17021 'Mail.ru agent crashes on master'
(just threw first-chance exception in 0.4.14RC without actually causing the crash there)
which regressed by 0.4.14-dev-418-g 661b8a2a05

and it fixes ROSTESTS-375 'riched20:txtsrv crashes on Test WHS x86'
which regressed by 0.4.14-dev-419-g 76cf09cfea

fix picked from 0.4.15-dev-3370-g c8b6abab80
2021-11-15 22:30:53 +01:00
Joachim Henze 8632c996cb [0.4.14][RICHED20_WINETEST] Restore Wine sync in txtsrv.c. ROSTESTS-355 + addendum
In particular, add the missed diff in ITextHostImpl_TxGetCharFormat.

It regressed when we did improperly sync to Wine Staging 4.18 via
0.4.14-dev-419-g 76cf09cfea

Fix is squashed back-port of:
0.4.15-dev-3252-g e30b0a356d and
0.4.15-dev-3251-g 5a9535e694
2021-10-10 17:54:36 +02:00
Joachim Henze bb786a63dd [0.4.14][SHELL32_APITEST] ShellHook testcase Fix compiler error (addendum to #3289)
addendum to 0.4.15-dev-1123-g 0089291751

Fix a compiler error on RosBE2.1.6 GCC4.7.2
that I got when I merged this test back to
0.4.14-RC-67-g ef623b1616

C:/0414rls/reactos/modules/rostests/apitests/shell32/ShellHook.cpp: In function
'LRESULT WindowProc(HWND, UINT, WPARAM, LPARAM)':
C:/0414rls/reactos/modules/rostests/apitests/shell32/ShellHook.cpp:339:26: error
: comparison between signed and unsigned integer expressions [-Werror=sign-compa
re]
cc1plus.exe: all warnings being treated as errors
ninja: build stopped: subcommand failed.

Fix picked from 0.4.15-dev-2662-g d30a1673d4
2021-06-06 16:44:17 +02:00
Joachim Henze 08e6117142 [0.4.14][WINETESTS] Workaround crashes in riched20:richole on VBox/KVM bots CORE-16799
The crashes began when those tests were synced to Wine Staging 4.18 in
0.4.14-dev-419-g 76cf09cfea

WHS 2k3sp2 Before the revert implies the tests were actually ok:
https://reactos.org/testman/compare.php?ids=77492

Disabling some of the tests is very unsatisfying of course,
but at least allows us to observe again
the results of the other tests from that suite.

VBox https://reactos.org/testman/compare.php?ids=77504,77506
KVM https://reactos.org/testman/compare.php?ids=77502,77505

picked from 0.4.15-dev-2639-g ae574e16f8
2021-06-04 21:13:40 +02:00
Joachim Henze 99f203c36f [0.4.14][NTUSER] DVD Write Now 1.5.12 SP2 setup has no taskbar pane CORE-15669
This is a sane addendum to 0.4.14-RC-67-g ef623b1616
by porting back the following master commits:

[WIN32SS][NTUSER] ShowWindow.SW_MINIMIZE should show window (#3700)
- user32!ShowWindow.SW_MINIMIZE should show the window.
- Fix the return value of ShowWindow function on invalid parameter.
CORE-15669
picked from 0.4.15-dev-2621-g 59d4c11203

[WIN32SS][NTUSER] Improve HSHELL_WINDOWCREATED condition (#3697)
Modify the condition of generating HSHELL_WINDOWCREATED, especially on WS_CHILD window style. CORE-15669
picked from 0.4.15-dev-2618-g 32b0cf6fc6

[USER32_APITEST] Add ShowWindow testcase (#3689)
Investigate the implementation of user32!ShowWindow. CORE-15669
picked from 0.4.15-dev-2616-g a8ed286c86

[SHELL32_APITEST] Strengthen and improve ShellHook testcase (#3687)
- Add tests to find the missing parameters against HSHELL_WINDOWCREATED conditions.
- Improve code readability. CORE-15669
picked from 0.4.15-dev-2611-g d21adc9b31
2021-06-02 04:33:27 +02:00
Katayama Hirofumi MZ ef623b1616 [0.4.14][NTUSER][SHELL32_APITEST] Fix regressions with taskbar panes CORE-17330 (#3289) (#3294) & CORE-13584
fixes CORE-17330 'Regression, many installers that should have only 1 taskbar pane, now have 2 of them erroneously'
which was introduced by 0.4.14-dev-369-g 141cf04239
and made ros behave a lot different than previous and future releases would perform.
The main fix was picked from 0.4.15-dev-1126-g 58b0558f94 (#3294)
and the new ShellHook testcase from 0.4.15-dev-1123-g 0089291751 (#3289)
The implementation atm passes all those 384 new ShellHookTests.

Beside that it entirely fixes the very old:
CORE-13584 'Winamp 5.666 erroneously has a secret tab shown in taskbar'

But brings back:
CORE-15669 'DVD Write Now 1.5.12 SP2 setup has no taskbar pane' (which was never working in any earlier release up to now)
but which we had fixed for a very short moment in master since the guilty 0.4.14-dev-369-g 141cf04239
That alone would be no biggy, but it also unhides?/introduces? for me the new:
CORE-17338 'Can not open a context menu in the taskbar pane of Double Commander setup, instantly closes'

Well in sum it is an improvement, but we are not in urgent need of porting it back any further than 0.4.14 yet,
because older releases would only benefit from CORE-13584 'Winamp...'
2021-05-22 03:21:11 +02:00
Serge Gautherie 3b122fdc36 [0.4.14][GFLAGS] ModifyStatus(): Remove a remnant HeapFree() (#3283) CORE-17325
Addendum to 0.4.11-dev-439-g
ec621270a1

I will not rebuild any iso for this commit as gflags.exe is by
default not built into our isos.

cherry picked from commit 0.4.15-dev-1101-g
374f9db341
2020-10-11 19:03:36 +02:00
Kyle Katarn f0a2e6efa2 [0.4.14][ROSTEST] Fix copy paste bug in RtlBitmap.c ROSTESTS-356 #3221
The glitch was introduced by 0.4.14-dev-626-g
465745b683

fix cherry picked from commit 0.4.15-dev-1051-g
b217d8bd14
2020-09-28 20:24:55 +02:00
Thomas Faber 3e9c4dad66
[WINDOWSCODECS] Use upstream Wine fix for 4bps BGRA TIFF. CORE-16796
Import Wine commits by Dmitry Timoshkov:
* 0cd8502b49 windowscodecs: Add support for 4bps RGBA format to TIFF decoder.
* 962bb99352 windowscodecs/tests: Add a separate test for 4bps BGRA TIFF format.
2020-04-24 14:56:26 +02:00
Katayama Hirofumi MZ 774ef4e80e
[SDK][RTL][NTDLL_APITEST] Add RtlMultipleAllocateHeap and RtlMultipleFreeHeap (#2641)
- Add RtlMultipleAllocateHeap and RtlMultipleFreeHeap functions (2k3+).
- Add a testcase for two functions.
CORE-12026
2020-04-24 17:45:43 +09:00
Doug Lyons 02e27dd512
[GDI32_APITEST] Add Tahoma font to GetTextMetrics apitest set (#2615)
Tahoma is available in Windows and ReactOS both, so this allows us to compare these fonts in both systems.
2020-04-22 14:21:31 +09:00
Mark Jansen bf54369dbb
[LOADCONFIG_APITEST] Tell GCC that the .def is not just included for fun,
but that it should actually use it.
2020-04-19 15:18:51 +02:00
Mark Jansen 0b948581fc
[SDK][HOST-TOOLS] Add load_config workaround for gcc builds
Since binutils can not add this, we re-introduce pefixup.
It searches for the exported symbol '_load_config_used',
and uses that to fill out the LOAD_CONFIG directory in the PE header
2020-04-17 17:47:24 +02:00
Mark Jansen f1e5bc3d74
[LOADCONFIG_APITEST] Add apitest using the load config section
For now, the only test is related to a user trace stack db.
The entire test application is disabled for gcc,
since it is unable to generate this load config info.
The stacktrace test is disabled until it is implemented.
2020-04-17 17:47:09 +02:00
Bișoc George d778d04a16
[APITEST][NTDLL] Implement RtlGetNtProductType testcase (#2489) 2020-04-17 13:47:09 +03:00
Victor Perevertkin 7e069ccdb2
[CMAKE] Replace custom functions to built-in ones
add_target_compile_definitions -> target_compile_definitions
add_target_compile_flags -> target_compile_options
add_target_include_directories -> target_include_directories
2020-04-16 15:59:38 +03:00
Foxlet 6a8c894642
[WALLPAPER] Rename Soft Blue to Mizu (#1945)
Cleanup of filenames to match the Mizu theme.
2020-04-16 02:37:17 +03:00
Mark Jansen 365fafc03b
[MSCTF_WINETEST] Skip crashing test when it fails
CORE-16797
2020-04-13 22:44:56 +02:00
Thomas Faber 9bcd835074
[ACPI_APITEST] Add a unit test for Bus_PDO_QueryResourceRequirements. CORE-12892
This will allow us to verify fixes made to function, which is quite broken.
2020-04-11 23:42:59 +02:00
Julen Urizar Compains f7cab5a1d4
[TRANSLATION] Multiple minor fixes and addings. (#2516)
- Applications: eventvwr, fltmgr, servman.
- rosapps: arping, CTM, fontsub, fraginator, imagesoft, systeminfo, vcdcontroltool, vgafontedit.
- CPLs: desk.cpl.
- ReactOS Setup GUI app.
- Screensavers: butterflies, maze, Starfield.
- System: NTVDM, printing/monitors/localmon; the freeze dialog in user32, the error strings in usersrv.
2020-04-09 18:13:46 +02:00
Katayama Hirofumi MZ 2c306e9fa2
[SHELL32_APITEST] Add SHAppBarMessage testcase (#2517)
Add a testcase for shell32!SHAppBarMessage function. CORE-7237
2020-04-10 00:57:08 +09:00
Victor Perevertkin a12d029ec0
[ROSAUTOTEST] Revert 9ff3adb. This fixes MSVC build.
This reverts commit 9ff3adb7d7.
2020-04-09 03:04:44 +03:00
Victor Perevertkin 9ff3adb7d7
[ROSAUTOTEST] Change custom auto_array_ptr to std::unique_ptr 2020-04-09 02:08:10 +03:00
Colin Finck 7d1f270918
[ROSAUTOTEST] Submit results to https://reactos.org:8443 instead of https://tlsv1.reactos.org
It is much easier server-side to maintain a different TLS configuration on another port rather than another subdomain.
2020-04-04 20:35:58 +02:00
Colin Finck 3c02749f92
[ROSAUTOTEST] Use tlsv1.reactos.org for submitting test results now that reactos.org is TLS 1.2+
We still need to be able to submit test results from Windows Server 2003, which supports TLS 1.0 only.
2020-04-04 12:57:50 +02:00
Serge Gautherie 803b5e1371
[WINETESTS] Remove forced _WIN32_WINNT defines (#2463)
Only comctl32 is affected.

Import
be3cda6ec0
2020-04-03 14:01:22 +02:00
Joachim Henze 30dcc229f0 [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code
Just to satisfy static code analysis. No change in behavior expected.

The same way as the external applications maintainers
fixed it in their latest version
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/

By killing the whole function ScrollUp() with the disabled code.
Like the original authors I left the functions unused declaration
existing within hardware.h
2020-03-30 17:18:16 +02:00
Serge Gautherie c6e854ce7b
[KERNEL32_APITEST][WS2_32_APITEST] Call SetLastError() before checking LastError (#2437)
Follow-up to cb5aa7be.
2020-03-30 12:52:37 +02:00
Bișoc George f70e43c8f3 [APITEST][NTDLL] Initial implementation of NtSetInformationProcess() testcase
The following testcase only performs argument checks for ProcessForegroundInformation class for the moment. The testcase will be expanded with further tests when needed.
2020-03-30 13:52:15 +03:00
Serge Gautherie 724466597f [REACTOS] Remove forced _WIN32_IE defines
No impact, as already deactivated or superseded or superfluous.

Import
7770e26f2d
2020-03-30 13:47:09 +03:00
Serge Gautherie 5d393d73ad
[NTDLL_WINETEST] Remove forced 0x500 API versions (#2483)
No impact, as conditional.

Import
71d8103190
2020-03-30 12:38:47 +02:00
Serge Gautherie 72fa935128 [CMAKE] kernel32_winetest: Enable 'generated.c', at last
Follow-up to 20f4039666.

ROSTESTS-251
2020-03-28 20:57:16 +01:00
Serge Gautherie 9bbbe84ca3
[KERNEL32_WINETEST] Uncomment out 'LPEXCEPTION_RECORD' checks
Revert part of r70802 (dd21fa115a).
Follow-up to 2e82175ba4.

ROSTESTS-251
2020-03-28 20:56:25 +01:00
Serge Gautherie d471558dbc
[WINETESTS] */generated.c: Remove forced 0x0501 API versions
This actually affects 2 modules only:
* kernel32: this file is still commented out, these defines were going to be deactivated anyway.
* rpcrt4: I don't know why it had these defines (still) activated. Anyway.

Import
aa384d3642
2020-03-28 20:50:28 +01:00
Serge Gautherie 8d3d2b1bef
[SHELL32_WINETEST] shlexec.c: Remove forced 0x0501 API versions
No impact, as already deactivated.

Import
8fc0b7d525
2020-03-28 20:46:44 +01:00
Serge Gautherie 9d943b788a
[RPCRT4_WINETEST] ndr_marshall.c: Remove forced 0x0500 API versions
Import
57f08ba525
2020-03-28 20:46:44 +01:00
Thomas Faber f027384e48
[KMTEST] Delete special-purpose driver services on unload. ROSTESTS-263
Based on a patch by Serge Gautherie.
2020-03-28 20:33:43 +01:00
Serge Gautherie 660383b855
[WINEFILE] Fix 'LANGUAGE_SI_SI' typo (#2474) 2020-03-28 13:23:35 +01:00
Bișoc George fcb156388d
[NTDLL_APITEST] Add testcase for process priority class. CORE-16757
Currently the testcase function only addresses the behaviour of getting an
unaligned buffer (either of correct length size or not) for now.
2020-03-28 13:10:44 +01:00
Serge Gautherie a8dbe6805a
[GDI32_WINETEST][USER32_WINETEST] Remove forced WINVER defines (#2455)
No impact, as already deactivated.

Import
d0fd12b909
2020-03-20 19:20:52 +01:00
Tibor Lajos Füzi 432a5ddc7f
[TRANSLATION] Update Hungarian translation of usetup, syssetup, explorer, netshell, userenv, shortcuts (#2442) 2020-03-20 17:52:46 +01:00
Katayama Hirofumi MZ 1816e4f6cb
[USER32_APITEST] Strengthen DrawText testcase (#2450)
Add uFormat and pszText parameters into user32_apitest DrawText testcase. CORE-16753
2020-03-17 23:24:11 +09:00
Serge Gautherie cb5aa7bee4
[APITESTS] Tested function must be called before GetLastError() log (#2433)
So as to get the relevant LastError value.
Fixes for apphelp_apitest, kernel32_apitest and ws2_32_apitest.
2020-03-13 18:15:21 +01:00
Serge Gautherie dbfd511ecd
[PSDK] SYSTEM_POWER_STATUS: Rename Reserved1 to SystemStatusFlag (#2419)
As on Win10.

Cherry pick
7c5ea436af
2020-03-13 18:14:16 +01:00
Katayama Hirofumi MZ 02f68dcb7a
[SHELL32_APITEST] Strengthen SHChangeNotify testcase (#2417)
Add pathname checks. CORE-13950
2020-03-07 11:36:55 +09:00
Serge Gautherie 92aabb07fb
[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)
Addendum to commit 554c41e4 (#2387).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-03-06 19:08:25 +01:00
Serge Gautherie 20f4039666
[KERNEL32_WINETEST] Fix COMMCONFIG.wcProviderData values (#2410)
Import test part of
a59d6387b6

ROSTESTS-251
2020-03-06 18:24:22 +01:00
Katayama Hirofumi MZ fc11cf78ca
[SHELL32] Improve ShellExecCmdLine in path resolving (#2397)
Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409
2020-03-01 19:32:33 +09:00
Katayama Hirofumi MZ 302356bf57 [SHELL32_APITEST] Add DoPropTest to SHChangeNotify testcase
CORE-13950
2020-02-29 16:02:48 +09:00
Katayama Hirofumi MZ 7f766e94d4
[SHELL32_APITEST] Support multi-process of SHChangeNotify testcase (#2399)
The shell32!SHChangeNotify function must be tested on multiple processes. CORE-13950
2020-02-29 08:13:52 +09:00