Intravision
/
reactos
mirror of https://github.com/reactos/reactos.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code 

Just to satisfy static code analysis. No change in behavior expected.

The same way as the external applications maintainers
fixed it in their latest version
https://sourceforge.net/projects/pice/files/pICE%20source/build_20/

By killing the whole function ScrollUp() with the disabled code.
Like the original authors I left the functions unused declaration
existing within hardware.h
This commit is contained in:
Joachim Henze 2020-03-30 17:18:16 +02:00
parent 76a41370d0
commit 30dcc229f0
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
modules/rosapps/applications/sysutils/utils/pice/module/hardware.c
View File

@ -664,27 +664,6 @@ void ClrLine(ULONG line)
ohandlers.ClrLine(line);
}
//*************************************************************************
// ScrollUp()
//
// Scroll a specific window up one line
//*************************************************************************
void ScrollUp(USHORT Window)
{
USHORT i;
return;
if(!wWindow[Window].bScrollDisabled)
{
for(i=1;i<wWindow[Window].cy;i++)
{
CopyLineTo((USHORT)(wWindow[Window].y+i-1),(USHORT)(wWindow[Window].y+i));
}
ClrLine((USHORT)(wWindow[Window].y+wWindow[Window].cy-1));
}
}
//*************************************************************************
// Home()
//
@ -848,7 +827,6 @@ void Print(USHORT Window,LPSTR p)
if(wWindow[Window].usCurY>=wWindow[Window].cy)
{
wWindow[Window].usCurY=wWindow[Window].cy-1;
ScrollUp(Window);
}
if(wWindow[Window].bScrollDisabled==TRUE)break;
}