Commit graph

78165 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 95466904db
[CMD] SHIFT: Use _istdigit(). 2020-09-13 22:50:10 +02:00
Hermès Bélusca-Maïto 00ce3c48fe
[CMD] Use pointers to const strings in error functions, where applicable. 2020-09-13 22:50:09 +02:00
Hermès Bélusca-Maïto 3f8f3a2bba
[CMD] Minor formatting only. 2020-09-13 22:50:09 +02:00
Hermès Bélusca-Maïto 14599b0a37
[SHELL32][SHLWAPI] Forward shell32.ShellMessageBoxW directly to shlwapi.ShellMessageBoxWrapW. (#3179)
This makes ShellMessageBoxW use the correct implementation where the
text buffer size is dynamic, instead of having a too small hardcoded
size.

Fixes CORE-17271.
See also PR #3172 by Kyle Katarn, supplemented with some ideas from
Mark Jansen.

However we cannot straightforwardly implement ShellMessageBoxA around
ShellMessageBoxW, by converting some parameters from ANSI to UNICODE,
because there may be some variadic ANSI strings, associated with '%s'
printf-like formatters inside the format string, that would also need
to be converted; however there is no way for us to find these and perform
the conversion ourselves.
Therefore, we re-implement ShellMessageBoxA by doing a copy-paste ANSI
adaptation of the shlwapi.ShellMessageBoxWrapW function.

Note that, on Vista+ onwards, shlwapi implements both ShellMessageBoxA/W,
and shell32 directly forwards these exports to shlwapi, thus avoiding
these workarounds.

[PSDK] Explicily use WINAPIV for the variadic ShellMessageBoxA/W functions.

[INCLUDE/REACTOS] Add ShellMessageBoxWrapW in shlwapi_undoc.h .
2020-09-13 22:44:58 +02:00
He Yang 5077e400d5
[RAPPS] Update Chinese Simplified (zh-CN) translation (#3155)
Addendum to 7a11c65.
2020-09-13 22:00:08 +03:00
Adam Stachowicz f3bc1b396a
[NTOBJSHEX] Update Polish (pl-PL) translation (#3175)
Addendum to e358d1d. CORE-17268
2020-09-13 18:22:11 +03:00
Timo Kreuzer 3c1f6631e6 [MSVCRT] Add vista exports 2020-09-13 15:37:29 +02:00
Timo Kreuzer 767a975cf6 [MSVCRT] -i386 -> -arch=i386 for consistency 2020-09-13 15:37:29 +02:00
Timo Kreuzer dfaba507dc [MSVCRT] Fix some architecture specific exports 2020-09-13 15:37:29 +02:00
Katayama Hirofumi MZ f1e2c3f70e [MSPAINT] Improve Japanese (ja-JP) translation 3 2020-09-13 17:33:57 +09:00
Katayama Hirofumi MZ 6e2ede3bd8 [NTOBJSHEX] Improve Japanese (ja-JP) translation 2020-09-13 17:16:12 +09:00
Katayama Hirofumi MZ b88717f5c4 [MSPAINT] Improve Japanese (ja-JP) translation 2 2020-09-13 17:15:05 +09:00
Katayama Hirofumi MZ bd7ad59a48 [MSPAINT] Improve Japanese (ja-JP) translation 2020-09-13 17:01:49 +09:00
Katayama Hirofumi MZ 8396cf8696 [CONSRV] Improve Japanese (ja-JP) translation 2020-09-13 16:50:15 +09:00
Katayama Hirofumi MZ 7ec021fdc4 [NTOBJSHEX] Add Japanese (ja-JP) translation 2020-09-13 16:39:29 +09:00
Michael Stamper b8e936a57b
[WDMAUD] Fix race condition bug with USE_MMIXER_LIB defined (#3148)
Remove misuse of multithreading and use NtDeviceIoContol with completion apc
callback instead (mirrors usage of WriteFileEx in WdmAudCommitWaveBufferByLegacy).

This fixes a crash caused by race condition. Code was simulating completion
callback using a thread, this resulted in single threaded code being executed
simultaneously by multiple threads.

CORE-17214
2020-09-13 01:56:34 +03:00
Serge Gautherie 4aeb45ce0c
[KERNEL32] GetPriorityClass(): Return explicit 0, not FALSE (match return type) (#3170) 2020-09-12 21:38:06 +02:00
Stanislav Motylkov 25458c7775
[NTOBJSHEX] Update Russian (ru-RU) translation
Addendum to e358d1d. CORE-17268
2020-09-12 22:26:52 +03:00
Kyle Katarn e358d1d219
[NTOBJSHEX] Localize the descriptions of the NT object and registry shell extension (#3167)
CORE-17268
2020-09-12 19:43:59 +02:00
chirsz cd2eaf1e51
[CONSRV] Improve zh-CN translation (#3157)
The new word is more in line with PRC people's usage habits, and it
is actually used in the Simplified Chinese translation of Windows.
2020-09-12 18:23:05 +02:00
Katayama Hirofumi MZ de9c32bfed
[SHELL32_APITEST] Strengthen ShellExecuteW testcase (#3165)
Add tests for special folders. CORE-16939
2020-09-13 00:47:56 +09:00
Timo Kreuzer 61192390cf
[KERNEL32_VISTA][NTDLL_VISTA][RTL_VISTA] Move Vista Rtl functions from kernel32_vista and ntdll_vista to rtl_vista (#3149)
* Move RtlRunOnce functions from kernel32_vista to rtl_vista and export them from ntdll_vista
* Move condvar.c and srw.c from ntdll_vista to rtl_vista
* Move ntdll_vista build script to a subfolder of ntdll

The RtlRunOnce functions are taken from wine, completely unmodified.
The code that was in kernel32_vista had change that used a global keyed_event handle, but was never initialized, so we were still passing NULL thus using the global ExpCritSecOutOfMemoryEvent.
2020-09-12 15:04:02 +02:00
Timo Kreuzer 2aca4b2795 [ASM] Fix boot with VS 16.7.3 / MSVC 19.27
See https://developercommunity.visualstudio.com/content/problem/1180800/ml-x86-assume-directive-causes-invalid-code-genera.html
2020-09-12 15:01:04 +02:00
Mark Jansen b5d2da6d35
[CABMAN] Replace linked lists with std::list
CORE-17231
2020-09-12 13:25:55 +02:00
Katayama Hirofumi MZ 183e1eb71b
[FONTEXT] Initial implementation of CFontExt::DoGetFontTitle (#3127)
This PR is a preparation of fonts folder implementation. CORE-12861
2020-09-12 09:40:48 +09:00
Mark Jansen ee69ca786a [CERTUTIL] Add skeleton application with support for -hashfile 2020-09-11 15:29:28 +02:00
Nguyen Trung Khanh 166f815e7b
[FILESYSTEMS] Fix pool memory disclosure in filesystem drivers supporting FS_INFORMATION_CLASS.FileFsVolumeInformation (#2975)
* FileFsVolumeInformation-memory-disclosure

* remove unnecessary assignment to 0

* fix
2020-09-11 15:51:35 +03:00
Nguyen Trung Khanh ede7a20a17
[FILESYSTEMS] Fix pool memory disclosure in NtQueryAttributesFile handlers (#2926)
Fix pool memory disclosure caused by alignment bytes at the end of the _FILE_BASIC_INFORMATION structure
2020-09-11 15:47:43 +03:00
Joachim Henze 35dbdaaa0e [SHELL32] Fix regression CORE-12364
The sorting in explorer broke by
SVN r73128 == git
24fcf531e7

Thanks to Doug Lyons for providing this patch.
I do intend to port it back into 0.4.14RC.
2020-09-11 02:24:42 +02:00
Kyle Katarn 7d44c1cb07
[SHELL32] Show "size on disk" in file/folder properties (#3107)
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
2020-09-10 20:48:40 +02:00
Mark Jansen f2ffd21232
[SHLWAPI] Fix SHLoadIndirectString executing code when loading a string 2020-09-10 19:45:22 +02:00
Mark Jansen 922a956805
[SHLWAPI_APITEST] Add test showing SHLoadIndirectString should load a dll as datafile 2020-09-10 19:45:15 +02:00
Oleg Dubinskiy 07f98eb10a [DBGENG] Import dbgeng.dll from Wine Staging 4.18
CORE-17153.
2020-09-10 18:19:28 +02:00
Oleg Dubinskiy 408b179220 [PSDK] Import dbgeng.h header from Wine Staging 4.18
Required by Wine's dbgeng.dll CORE-17153.
2020-09-10 18:19:28 +02:00
Serge Gautherie e6956dd3b1 [CMAKE] Remove obsolete '_ROSBE_VERSION' checks
following upgrade to RosBE (2.1 and now) 2.2.
2020-09-10 18:16:36 +02:00
Doug Lyons e06ec0a594
[GDI32_APITEST] Create StretchBlt Regression Test (#3109)
* Add gdi32_apitest:StretchBlt regression test.
* Give Wine proper credit for base code.
2020-09-10 18:15:12 +02:00
Katayama Hirofumi MZ c8e3ef7894
[SHELLFIND] Split encoding detection code (#3147)
Split encoding detection code to improve code quality. This is follow-up of #3134 (7376cde). CORE-17250
2020-09-10 19:03:20 +09:00
Timo Kreuzer 92f4746845 [NTDLL] Add Vista exports 2020-09-09 19:33:29 +02:00
Timo Kreuzer aaa7dda945 [NTDLL] Mark 2k3 only functions and improve some arch specific definitions 2020-09-09 19:33:29 +02:00
Omer I.S bca076269f
[INPUT.CPL] Update Hebrew translation (#3121) 2020-09-08 23:01:56 +02:00
Kyle Katarn d7fd62d478
[BOOT][DIRECTX][SHELL32] Unneeded semicolons (trivial) (#3133)
Except in 3rd-party code.
CORE-13162
2020-09-08 21:57:13 +02:00
Kyle Katarn d54e50f3dc
[EXPLORER] Registry key not closed on error (#3136)
CORE-14519
2020-09-08 21:55:45 +02:00
Kyle Katarn 2c7ccf4bc9
[SOLITAIRE] French translation update (#3138)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-09-08 21:52:24 +02:00
James Tabor 3ca217621d [Printing] Fix Typos and Test Regressions
Fix WinSpool API regressions.
Fix typos and debug prints.
2020-09-08 13:15:16 -05:00
James Tabor 8313483202 [GDI32] Force Return if other Type of Device Requested
Fix CORE-17241 assert.
2020-09-08 12:52:28 -05:00
Victor Perevertkin 32c7c1157d
[NTOS:IO] Fix a reference leak in IopSynchronousCall on failure case
Co-authored-by: Vadim Galyant <vgal@rambler.ru>
2020-09-08 14:51:20 +03:00
Mark Jansen 9bd9c9d5a4
[CABMAN] Ensure we are minimally building with c++11 2020-09-07 22:16:42 +02:00
Mark Jansen 63f3275d15
[CABMAN] Move CCFDATAStorage to a separate header 2020-09-07 22:16:42 +02:00
Mark Jansen 7394d12f7e
[CABMAN] Replace some dynamically allocated strings with std::string
CORE-17231
2020-09-07 22:16:28 +02:00
Mark Jansen 58092fb4da [ATL][ATL_APITEST] Add CString::Tokenize + testcase 2020-09-07 22:13:43 +02:00